[koha-commits] main Koha release repository branch master updated. v18.11.00-45-gdbff938
Git repo owner
gitmaster at git.koha-community.org
Tue Dec 11 22:10:05 CET 2018
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via dbff938c7ff7eb277c6b94b56b5f03d3348f0017 (commit)
via ce160066a2b06742e348011324620c8e58b26f40 (commit)
via 30874dea519d379134174cf9c5fd5051588a8629 (commit)
via d90d5d2254d55752bf1e524885284ba8e3e86f60 (commit)
via e75c869785d09e6a2b1eb8dbe47cca868fb86105 (commit)
via 1622f0f609fbf7862c481eeec98cd1668b09b145 (commit)
via 9a2bd027e5d2380b39776059066d8f06b42d68dd (commit)
via a02b322fe7f6a35c0613a33a2e266bb79a721260 (commit)
via da5e41f6def8a5cbafc9303b0fff35cb13e50e72 (commit)
via 875f3162c8008ef288adfcd18ada490cf06ecc15 (commit)
via a1b08269a7031417312e6265ace9ef5b995933fa (commit)
via c36597bc0c72cc31249c02af5aaaf1c1f977ee50 (commit)
via a2b5407ba5c74f826c1665c1a2ef1ff6d52689fd (commit)
via 2dbaaa300877ff6d96ae84b5a703753d97b6c340 (commit)
via 3adf7708d544338250703165fe7e87f2690d8639 (commit)
via 39c93e87f648978ec7907220710efaf64e556ea0 (commit)
via 06e6378899631da162d57d477381782f3764ec89 (commit)
via 842a4befd342e46a0abda8300c339bb37f943c09 (commit)
via 0295fc2fc6062d9bb43e70bce5f5504b418f3629 (commit)
via 65ff39f6a56e3bf252883b484f8892d6efcbeb9e (commit)
via 3c50245cfe272dc105033ff2e59f8e2689f7dd26 (commit)
via e5585a10d5f2ee24cad94b2cf17df1ce13e8a01a (commit)
via 4c0682f5598d53992b6966a217b10f71a9cdaebb (commit)
via 21372f78f825c0ec439ea4a7cfe7dff6656467b9 (commit)
via ee96d18b2cee07aa64d5e68078bc898d36e22146 (commit)
via f3b8c66392098d69bca48bbf04b7e93fa2100280 (commit)
via 96b3889390f8efe9851aaa9c2cafa9e20bda3f43 (commit)
via 4bf033c6d6b2a8bf4d5597b3fdf6355fb7060b60 (commit)
from b4580bff5ba7753f9db2513c3b87ecb9bba5258c (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit dbff938c7ff7eb277c6b94b56b5f03d3348f0017
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Dec 6 15:59:10 2018 -0300
Bug 21969: Fix Koha::Account->outstanding_* matching the opposite on pathological cases
This patch makes outstanding_* methods be safe regarding pathological
account lines that get converted into another type because of the value
of amountoutstanding
To test:
- Run:
$ kshell
k$ prove t/db_dependent/Koha/Account.t
=> FAIL: Tests fail because pathological account lines are wrongly
picked.
- Apply this patch
- Run:
k$ prove t/db_dependent/Koha/Account.t
=>SUCCESS: All green!
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit ce160066a2b06742e348011324620c8e58b26f40
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Dec 6 15:37:37 2018 -0300
Bug 21969: Regression tests
This patch introduces regression tests for Koha::Account::outstanding_*
methods so they don't pick wrong lines when amountoutstanding matches
what we are looking for (i.e. negative for credits and positive for
debits).
To test:
- Apply this patch
- Run:
$ kshell
k$ prove t/db_dependent/Koha/Account.t
=> FAIL: Tests fail because pathological account lines are wrongly
picked.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 30874dea519d379134174cf9c5fd5051588a8629
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Wed Dec 5 03:44:25 2018 +0000
Bug 21947: Address other misordered FILTER lines
As per comment #3, this patch changes the order for all
the filters found with the recommended git grep.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit d90d5d2254d55752bf1e524885284ba8e3e86f60
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Tue Dec 4 18:58:17 2018 +0000
Bug 21947: Swap the filter order
TEST PLAN
----------
1) start your kohadevbox
2) cd kohaclone
3) git checkout -b bug_21947 origin/master
4) git bz apply 21947
5) reset_all
6) log in to staff client and add a 500$a with lots
of blank lines between strings with some HTML.
7) look at the opac record Title notes tab.
-- does it have <br>-mess? Should not.
8) repeat steps 5-7 on master, and you'll see
a <br>-mess.
9) run qa test tools
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit e75c869785d09e6a2b1eb8dbe47cca868fb86105
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Dec 10 16:45:00 2018 -0300
Bug 21759: Avoid manually setting amountoutstanding in _FixAccountForLostAndReturned
This patch changes the behaviour in the _FixAccountForLostAndFound
method.
The method will now add the amountoutstanding value for the lost item
fee to the CR credit to be generated. This means that:
- If there's some remaining debt, the same amount will be added to the
CR credit and used to cancel that debt. The final amountoutstanding
will be the same as before, but an offset will be generated as
required.
- If the line was written off, the behaviour remains unchanged, so no
offset.
- If the line was payed and/or written off in full only the payments are
refund, preserving the current behaviour.
To test:
- Apply the regression tests patch
- Run:
$ kshell
k$ prove t/db_dependent/Circulation.t
=> FAIL: Tests fail because the behaviour is not correct
- Apply this patch
- Run:
k$ prove t/db_dependent/Circulation.t
=> SUCCESS: Tests now pass!
- Sign off :-D
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 1622f0f609fbf7862c481eeec98cd1668b09b145
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Dec 10 16:38:05 2018 -0300
Bug 21759: Regression tests
This patch tests for a new behaviour in the _FixAccountForLostAndFound
method.
The method will now add the amountoutstanding value for the lost item
fee to the CR credit to be generated. This means that:
- If there's some remaining debt, the same amount will be added to the
CR credit and used to cancel that debt. The final amountoutstanding
will be the same as before, but an offset will be generated as
required.
- If the line was written off, the behaviour remains unchanged, so no
offset.
- If the line was payed and/or written off in full only the payments are
refund, preserving the current behaviour.
Only changes to the 'remaining debt' use cases on this tests are
expected.
To test:
- Apply this patch
- Run:
$ kshell
k$ prove t/db_dependent/Circulation.t
=> FAIL: Tests fail because the behaviour is not correct.
Note: some tests order changes are introduced to avoid calling
discard_changes twice
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 9a2bd027e5d2380b39776059066d8f06b42d68dd
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Oct 2 19:48:02 2018 +0000
Bug 21465: Don't throw duplicate userid error if userid belongs to the matched patron
To test:
1 - Export your patrons
a - Create a report 'SELECT * FROM borrowers'
b - Run and save the report as csv (check your delimiter)
c - Delete the borrowernumebr column
2 - Use the Patron Import tool to import the csv from above
3 - Set matching to 'cardnumber'
4 - Set 'If matching record is already in the borrowers table:' to
Overwrite
5 - Import
6 - None are import because of matchign userid (their own)
7 - Apply patch
8 - Repeat
9 - Patrons are successfully overwritten
10 - prove -v t/db_dependent/Koha/Patrons/Import.t
11 - prove -v t/db_dependent/Koha/Patrons.t
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a02b322fe7f6a35c0613a33a2e266bb79a721260
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Dec 11 20:31:19 2018 +0000
Bug 21961: DBRev 18.12.00.001
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit da5e41f6def8a5cbafc9303b0fff35cb13e50e72
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Thu Dec 6 12:42:12 2018 +0100
Bug 21961: Fix typo in manage_didyoumean permission
The typo in the installer files will cause problems on new
installations as the code for the permission is wrong.
This means that on new installations the Did you mean? section
on the administration page won't show up.
In order to fix this, we need to correct the code in
permissions, but also the permissions for users who
this permission has been given to.
To test:
- Start without the patch
- Use a new installation with the permission typo
- Log in as superlibrarian
- Verify that the "did you mean?" configuration page
is not visible
- Create another staff user with permission to access
staff and manage_didyoumean checked
- Verify configuration page remains invisible
- Apply patch and run database update
- Check both users again, the config page should now sohw
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 875f3162c8008ef288adfcd18ada490cf06ecc15
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Fri Dec 7 10:19:44 2018 +0100
Bug 21908: (QA follow-up) Remove useless parentheses in query
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a1b08269a7031417312e6265ace9ef5b995933fa
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Thu Nov 29 10:50:06 2018 +0100
Bug 21908: Add DISTINCT biblionumber to rebuild_zebra.pl
Zebra indexing script misc/migration_tools/rebuild_zebra.pl as a table arg to allow filtering.
When using table=items we should use DISTINCT(biblionumber) to avoid indexing several times the same biblio record when it has several items.
This patch adds DISTINCT(biblionumber) in all cases it does not harm if its already unique.
Test plan :
1) Be sur you have a biblio record with biblionumber 1 with 3 items
2) Run misc/migration_tools/rebuild_zebra.pl -v -b --table items --where="biblionumber=1"
3) Without patch you see "Records exported: 3", with patch only one
4) Check indexing works well
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit c36597bc0c72cc31249c02af5aaaf1c1f977ee50
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Thu Nov 29 10:15:00 2018 +0100
Bug 21908: Add biblio_metadata to rebuild_zebra.pl tables
Zebra indexing script misc/migration_tools/rebuild_zebra.pl as a table arg to allow filtering.
It is missing biblio_metadata to allow filtering on MARCXML with ExtractValue.
Test plan :
1) Be sur you have a biblio record with biblionumber 1
2) Run misc/migration_tools/rebuild_zebra.pl -h
3) You see : --table specify a table (can be items, biblioitems, biblio, biblio_metadata) to retrieve biblionumber to index.
4) Run misc/migration_tools/rebuild_zebra.pl -v -b --table biblio_metadata --where="biblio_metadata.biblionumber=1"
5) Check you dont have SQL errors
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a2b5407ba5c74f826c1665c1a2ef1ff6d52689fd
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Nov 16 07:01:39 2018 -0500
Bug 21849: Two useless Koha::Account::Offset->new calls need attention
Came across those calls in bug 20598 in _FixOverduesOnReturn
Koha::Account::Offset->new(
{
debit_id => $accountline->id,
type => 'Forgiven',
amount => $amountoutstanding * -1,
}
);
This does nothing if you don't store data.
Test Plan:
1) Apply this patch
2) Set up 2 items with overdue fines
3) Return one with dropbox mode
4) Note the dropbox account offset is created
5) Return one with full fine forgiveness
6) Note the forgiven account offset is created
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 2dbaaa300877ff6d96ae84b5a703753d97b6c340
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Nov 16 09:54:39 2018 -0500
Bug 21849: Add unit tests
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 3adf7708d544338250703165fe7e87f2690d8639
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Dec 6 12:42:45 2018 +0000
Bug 21962: Fix authority search using 'all'
To test:
1 - Set search engine to Zebra
2 - Have some authorities and indexes up to date
3 - Search authorities with option 'search entire record'
4 - No results
5 - Apply patch
6 - Run unit tests, they pass!
7 - Repeat search
8 - Results!
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 39c93e87f648978ec7907220710efaf64e556ea0
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Dec 6 12:41:41 2018 +0000
Bug 21962: Unit tests
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 06e6378899631da162d57d477381782f3764ec89
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Dec 3 13:05:49 2018 +0000
Bug 21405: Fix authorities pagination for Zebra and ES
Bug 20261 introduced an error because search_auth_compat responded
differently for ES and Zebra, now bug 19365 fixed the underlying
difference. This patch restores previous code to fix pagination.
Additionally we add a fix for 10000+ results in ES and remove a double
import of C4::Auth
To test:
1 - Perform an authorities search with 1+ pages using Zebra
2 - Page through results, note you are only offseeting by 1 each time
3 - Perform an authorities search with 10,000+ results in ES
4 - Click on the last page and get an error
5 - Apply patch
6 - Retry Zebra search
7 - Results should paginate correctly
8 - Clicking on last page should return last results
9 - Retry ES results
10 - Results should paginate correct
11 - Clicking on last page should return last results
Signed-off-by: Ere Maijala <ere.maijala at helsinki.fi>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 842a4befd342e46a0abda8300c339bb37f943c09
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Dec 7 09:43:58 2018 +0100
Bug 21608: (QA follow-up) Rename revert button
The label 'Revert found status' is replaced by 'Revert waiting status'
or 'Revert transit status' depending on hold.found/hold.intransit.
Note that hold comes from reserveloop in request.pl. The columns/keys
found and intransit are just booleans.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 0295fc2fc6062d9bb43e70bce5f5504b418f3629
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Nov 26 18:19:03 2018 +0000
Bug 21608: Add value for 'rank-request' when dropdwn disabled
When a field is disabled no value is submitted in the form - this was
causing found holds to be reverted
To test:
1 - Apply all patches except this one
2 - PLace several holds on one bib
3 - Set at least one waiting or intransit
4 - Making no adjustments hit "Update holds"
5 - Waiting/intransit holds are all reset
6 - Mark them waiting/intransit again
7 - Apply this patch
8 - Click 'update holds'
9 - Found status is not accidentally reverted
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 65ff39f6a56e3bf252883b484f8892d6efcbeb9e
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Nov 13 19:22:48 2018 +0000
Bug 21608: Add ID and fix filters
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 3c50245cfe272dc105033ff2e59f8e2689f7dd26
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Oct 25 11:45:25 2018 +0000
Bug 21608: Disable dropdown for found holds - add button to revert
This patch disables the dropdown for found holds, and adds a new button
to revert the waiting status, setting the hold to priority 1
Additionally we remove some changes from 19469 and update the JS to skip
found holds when updating priority
To test:
1 - Find a record with multiple items
2 - Place 4 holds (or more)
3 - Capture one ohld as waiting, one as in transit
4 - View the holds on the record - switch the last to priority one
5 - Waiting and transit statuses get confused
6 - Apply patch
7 - Observe dropdown is now disabled for waiting holds
8 - Confirm other holds operate as expected
9 - Confirm 'Revert found status' resets hold
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Bug 21608: (follow-up) Use RevertWaitingStatus and do not alter _FixPriority
[EDIT]
Completely removed the changes to Reserves.pm by adding module prefix in
the request.pl script.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit e5585a10d5f2ee24cad94b2cf17df1ce13e8a01a
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Fri Nov 30 07:09:23 2018 +0000
Bug 21911: Regression test
This tests usuall cases, but note, that administrator could make a
branch with code "%%%" or so, which this test does not cover, and some
functionalities will not work in that case: opac limit override,
holdinbranch facet
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 4c0682f5598d53992b6966a217b10f71a9cdaebb
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Nov 29 14:17:37 2018 +0000
Bug 21911: Fix OPAC scoping to work with new group system
To test:
0 - Apply patch
1 - Create a library group enabled for opac search limits and add some
libraries
2 - Check the DB (or advanced search dropdown) to get the id of the
group (using 7 as example below)
3 - Add to apache configuration (OPAC virtualhost)
SetEnv OPAC_SEARCH_LIMIT branch:multibranchlimit-7
SetEnv OPAC_LIMIT_OVERRIDE 1
RequestHeader add X-Koha-SetEnv "OPAC_SEARCH_LIMIT
branch:multibranchlimit-7"
RequestHeader add X-Koha-SetEnv "OPAC_LIMIT_OVERRIDE 1"
4 - Ensure OpacAddMastheadLibraryPulldown is disabled
5 - Restart all the things
6 - Visit the opac
7 - Perform a search, confirm it is scoped to the branches in the group
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 21372f78f825c0ec439ea4a7cfe7dff6656467b9
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Dec 6 12:53:24 2018 -0300
Bug 21910: Does not deal with call context, ->search does already
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit ee96d18b2cee07aa64d5e68078bc898d36e22146
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Dec 6 12:52:54 2018 -0300
Bug 21910: Remove duplicated lines in tests
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit f3b8c66392098d69bca48bbf04b7e93fa2100280
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Nov 29 14:11:36 2018 +0000
Bug 21910: Koha::Library::Groups->get_search_groups should return the groups
To test:
1 - Add a library group (Admin->Library groups)
2 - Enable use as an opac and staff search limit
3 - Add some libraries to the group
4 - Visit advanced search on staff and opac
5 - Note the dropdown has as many empty rows as there are libraries
in the group
6 - Apply patch, restart all the things
7 - Visit staff and opac advanced search
8 - Confirm the group dropdowns are correct
9 - Enable OpacMastheadLibraryPulldown
10 - Ensure the dropdown on opac shows groups correctly
11 - Confirm earchign groups works from all three locations
12 - prove -v t/db_dependent/LibraryGroups.t
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 96b3889390f8efe9851aaa9c2cafa9e20bda3f43
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Nov 7 01:32:26 2018 +0000
Bug 21778: Sort user list by surname,firstname unless user cannot manage patron lists OR edit patrons
To test:
1 - Create four users:
1 superlibrarian (or with both edit patrons and manage patron
lists)
1 with only edit patrons and catalogue
1 with only add to list and catalogue
1 with catalogue but neither edit patrons or manage patron lists
2 - Search patrons signed in as each user
3 - Note different sorting
4 - Apply patch
5 - Try searching with each patron
6 - Results should always be sorted by surname, firstname
7 - Only in the case of neither extra permission should the checkboxes
be absent
Signed-off-by: Devinim <kohadevinim at devinim.com.tr>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 4bf033c6d6b2a8bf4d5597b3fdf6355fb7060b60
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Dec 5 16:39:02 2018 -0300
Bug 21955: Remove Cache::Memory as fallback for L2 cache
If Plack is running with several workers we must not use Cache::Memory
as L2 cache.
If a value is set from a worker, it will not be available from other
workers as the Cache::Memory instance is not shared (of course!)
Moreover we now have Koha::Cache::Memory::Lite that does the same job,
so we should not expect performance regressions by removing it.
See also the email sent to koha-devel for more info
http://lists.koha-community.org/pipermail/koha-devel/2018-December/045004.html
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Auth.pm | 4 +-
C4/AuthoritiesMarc.pm | 3 +
C4/Circulation.pm | 50 ++++++++--------
C4/Installer/PerlDependencies.pm | 5 --
Koha.pm | 2 +-
Koha/Account.pm | 2 +
Koha/Cache.pm | 36 ------------
Koha/Library/Groups.pm | 8 +--
Koha/Patrons/Import.pm | 2 +-
authorities/authorities-home.pl | 19 +++---
installer/data/mysql/updatedatabase.pl | 12 ++++
installer/data/mysql/userpermissions.sql | 2 +-
.../intranet-tmpl/prog/en/includes/holds_table.inc | 7 ++-
.../prog/en/modules/catalogue/detail.tt | 4 +-
.../prog/en/modules/members/member.tt | 2 +-
.../prog/en/modules/members/notices.tt | 2 +-
.../prog/en/modules/reserve/request.tt | 27 ++++-----
.../prog/en/modules/serials/subscription-detail.tt | 8 +--
.../opac-tmpl/bootstrap/en/includes/masthead.inc | 6 +-
.../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 6 +-
.../bootstrap/en/modules/opac-serial-issues.tt | 4 +-
misc/migration_tools/rebuild_zebra.pl | 6 +-
reserve/request.pl | 19 +++---
t/db_dependent/Auth.t | 30 +++++++++-
t/db_dependent/Circulation.t | 36 ++++++++----
t/db_dependent/Koha/Account.t | 40 ++++++++-----
t/db_dependent/Koha/Patrons.t | 3 +-
t/db_dependent/Koha/Patrons/Import.t | 61 +++++++++++++++++---
t/db_dependent/LibraryGroups.t | 19 +++++-
t/db_dependent/Search.t | 7 ++-
30 files changed, 268 insertions(+), 164 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list