[koha-commits] main Koha release repository branch master updated. v18.11.00-53-g64242ca
Git repo owner
gitmaster at git.koha-community.org
Fri Dec 14 16:47:12 CET 2018
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 64242cabea21e9ee7673666cad88eb403d1053d6 (commit)
via 1e09fefcb05abf6496c89fe8115f0437a26b9490 (commit)
via 8bf032f512687cfe7ddc3748675c54f18b08c010 (commit)
via d561273ef84f4bc2534ac63d0f8793c9eb2a7fb9 (commit)
via cade3103ecd4008ccb0bb82e1fd77497894f68f5 (commit)
via e29f0bce403d5d7c1f292d57b105e0a2ab31e01d (commit)
via 702c727470d332615fb1428c55f503183935f29d (commit)
via 3a7053346c760144a8d7fe595d52806f739ead64 (commit)
from dbff938c7ff7eb277c6b94b56b5f03d3348f0017 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 64242cabea21e9ee7673666cad88eb403d1053d6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Dec 7 14:14:06 2018 -0300
Bug 14334: Remove AutoCommit from tests
And use a DBIx transaction instead.
Test plan:
prove that the test files modified by this patch are passing
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 1e09fefcb05abf6496c89fe8115f0437a26b9490
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu Dec 13 15:35:59 2018 +0100
Bug 21880: (follow-up) Add some uri filters
Theoretically, source needs a filter.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 8bf032f512687cfe7ddc3748675c54f18b08c010
Author: Andreas Roussos <arouss1980 at gmail.com>
Date: Fri Nov 23 19:30:23 2018 +0200
Bug 21880: "Relationship information" disappears when accessing paginated results in authority searches
When linking authorities with authorities, if you perform a
search that returns >20 results, the "Relationship information"
section disappears when you click on the pagination hyperlinks.
This patch fixes that.
Test plan:
1) In the Authorities module, edit an authority (or create a new
one) and try to link it with another authority (via UNIMARC
500$a, for example).
2) When the authority finder comes up, search for something that
will yield more than 20 results, then click on the pagination
links -- notice how the "Relationship information" section is
no longer visible.
3) Apply the patch (and restart Plack/memcached, if necessary).
4) Repeat step 2) -- "Relationship information" is now persistent.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit d561273ef84f4bc2534ac63d0f8793c9eb2a7fb9
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Dec 12 11:05:19 2018 -0300
Bug 21986: Do not escape quotation marks when cataloguing
In several places we escape quotation marks using
$value =~ s/"/"/g;
All the occurrences are wrong and must be removed.
Most of them are leftover of bug 11638 (Remove HTML from
addbiblio.pl), which removes the construction of html from pl scripts.
The problem has been highlighted by bug 13618, I did not track down why
the issue did not exist before (?)
Test plan:
0/ Use strings with quotation marks, like:
'Fiddle tune history : "bad" tunes'
You can also use other html characters to make the tests more complete,
like 'Fiddle tune history : <"bad" tunes>'
1/ authorities/authorities.pl
a. Edit an authority filling different fields with quotation marks
b. Edit it again
=> The display (inputs' values) is wrong, if you save the escaped quotes
will be inserted
2/ cataloguing/addbiblio.pl
Same editing a bibliographic record
3/ cataloguing/additem.pl
Same editing items
4/ members/memberentry.pl
Edit a patron's record and fill some fields with quotation marks
+ fields borrowernotes and opacnotes
=> The quotes are inserted directly in DB (escape is done before the
insert!)
5/ opac/opac-review.pl
For QA only: $js_ok_review is never used
6/ tools/batchMod.pl
For QA only: $value is always undefined at that point
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit cade3103ecd4008ccb0bb82e1fd77497894f68f5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Dec 7 10:26:02 2018 -0300
Bug 21973: Do not url escape casServerUrl
It is already escaped correctly in
C4::Auth_with_cas::_url_with_get_params using URI::Escape::uri_escape
Note that shibbolethLoginUrl is not and must be url escaped in template
("be consistent, they said")
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit e29f0bce403d5d7c1f292d57b105e0a2ab31e01d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Dec 7 16:49:00 2018 -0300
Bug 21931: Do not reset the ES mapping on 3.23.00.050
This update DB entry uses DBIx schema which does not make it crashes if
the table structure is changed.
Which happens on 18.06.00.054, that added search_field.weight
The entry 3.23.00.050 fails with
Unknown column 'me.weight' in 'field list'
This patch removes the reset of the mapping and display a warning to
tell the administrator the mapping must be reset/inserted
Test plan:
Use a 3.22 dump and upgrade it
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 702c727470d332615fb1428c55f503183935f29d
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Dec 12 16:16:50 2018 +0000
Bug 21991: Pass param names to report limit tool
To test:
1 - Define a report like:
SELECT barcode, itemnumber
FROM items
WHERE (homebranch = <<Branch|branches>> AND 0 ) OR
<<Branch|branches>>=<<Branch|branches>>
2 - Run it, you get results
3 - Select 'Rows to display' 50
4 - No results
5 - Apply patch
6 - Run report
7 - Change display rows
8 - Results remain!
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 3a7053346c760144a8d7fe595d52806f739ead64
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Dec 6 10:07:18 2018 -0300
Bug 21950: Remove filtering for query_cgi and limit_cgi
We must not escape query_cgi and limit_cgi template-side, they are already
escape properly from build_query_compat using uri_escape_utf8.
To fix further problems we should replace all occurrences to make things
clear (I decided to keep the html filter so far, which did not hurt, but uri or url do)
Same patch as the following commit will be provided
commit 2fc599c0893620c395ca0492c9d9e3c860c8f951
Bug 21526: Fix search result pages (url vs uri vs raw)
query_cgi is uri_escaped from the pl, so we should displayed as raw
Test plan:
Use wide characters ❤
Search, filter, facets, search history, rss (both interfaces)
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
authorities/authorities.pl | 2 --
cataloguing/addbiblio.pl | 2 --
cataloguing/additem.pl | 6 ++----
installer/data/mysql/updatedatabase.pl | 11 +++--------
koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc | 2 +-
koha-tmpl/intranet-tmpl/prog/en/includes/page-numbers.inc | 10 +++++-----
.../prog/en/modules/authorities/searchresultlist-auth.tt | 12 ++++++------
.../intranet-tmpl/prog/en/modules/catalogue/results.tt | 6 +++---
.../prog/en/modules/catalogue/search-history.tt | 8 ++++----
.../prog/en/modules/reports/guided_reports_start.tt | 3 +++
koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc | 4 ++--
.../opac-tmpl/bootstrap/en/includes/page-numbers.inc | 10 +++++-----
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt | 4 ++--
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 6 +++---
.../opac-tmpl/bootstrap/en/modules/opac-search-history.tt | 8 ++++----
members/memberentry.pl | 1 -
opac/opac-review.pl | 3 ---
t/db_dependent/Acquisition/FillWithDefaultValues.t | 6 +++---
t/db_dependent/AdditionalField.t | 8 +++-----
t/db_dependent/Auth_with_cas.t | 11 +++--------
t/db_dependent/BackgroundJob.t | 8 ++++----
t/db_dependent/Charset.t | 8 ++++----
t/db_dependent/Circulation/CheckIfIssuedToPatron.t | 8 +-------
t/db_dependent/Circulation/CheckValidBarcode.t | 8 +++-----
t/db_dependent/Circulation/GetHardDueDate.t | 9 +++------
t/db_dependent/Circulation/OfflineOperation.t | 9 +++------
t/db_dependent/ColumnsSettings.t | 8 ++++----
t/db_dependent/Contract.t | 7 +++----
t/db_dependent/Fines.t | 7 ++-----
t/db_dependent/Koha/GetDailyQuote.t | 9 +++------
t/db_dependent/Koha/Item/Search/Field.t | 7 +++----
t/db_dependent/Koha_Misc_Files.t | 8 +++-----
t/db_dependent/Labels/t_Batch.t | 8 +++-----
t/db_dependent/Languages.t | 10 ++++------
t/db_dependent/Letters/GetLetterTemplates.t | 5 +++--
t/db_dependent/Letters/GetLettersAvailableForALibrary.t | 5 +++--
t/db_dependent/LibraryGroups.t | 7 ++++---
t/db_dependent/MarcModificationTemplates.t | 5 +++--
t/db_dependent/MungeMarcPrice.t | 13 ++++---------
t/db_dependent/NewsChannels.t | 9 +++------
t/db_dependent/Overdues.t | 5 +++--
t/db_dependent/Record.t | 7 +++----
t/db_dependent/Record/marcrecord2csv.t | 5 +++--
t/db_dependent/RotatingCollections.t | 10 +++-------
t/db_dependent/Serials.t | 10 +++-------
t/db_dependent/Serials/Claims.t | 5 +++--
t/db_dependent/Serials/Frequency.t | 7 +++----
t/db_dependent/Serials/GetNextSeq.t | 8 +++-----
t/db_dependent/Serials/Numberpattern.t | 12 ++++++------
t/db_dependent/Stats.t | 9 +++------
t/db_dependent/Virtualshelves.t | 4 +++-
t/db_dependent/XISBN.t | 8 +++-----
t/db_dependent/sysprefs.t | 8 +++-----
tools/batchMod.pl | 3 +--
54 files changed, 158 insertions(+), 224 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list