[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.06-52-gf6f5de1

Tue Dec 18 20:37:32 CET 2018

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  f6f5de147af71d7ff6f8eb505c58c272d26173ee (commit)
       via  f9a4e3656102d982923989ce49641ff0a267322f (commit)
       via  989c507fb380d66b72954bfadc8926dc33013450 (commit)
       via  479967c4dd603956d7ecb8f032cc94b31d9db58a (commit)
       via  f4b16c70150a139a3600575ef3d113645c931e9c (commit)
       via  41ff722307adb1ce01ce6e5423024d0d5fce8ff5 (commit)
       via  99824ca8a3953aa461169d5adcc25d821cd07677 (commit)
       via  77e846c441d976df69146cd96018a9039d534e25 (commit)
       via  7ffd1602a005310978a8b1e08efc7397826b4668 (commit)
      from  fe280815aa9027f582c05e275cc23b352a23ee5c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit f6f5de147af71d7ff6f8eb505c58c272d26173ee
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Dec 6 12:42:45 2018 +0000

    Bug 21962: Fix authority search using 'all'

    To test:
    1 - Set search engine to Zebra
    2 - Have some authorities and indexes up to date
    3 - Search authorities with option 'search entire record'
    4 - No results
    5 - Apply patch
    6 - Run unit tests, they pass!
    7 - Repeat search
    8 - Results!

    Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 3adf7708d544338250703165fe7e87f2690d8639)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit a110125338202f30cec0bc061141d82c80652f30)

commit f9a4e3656102d982923989ce49641ff0a267322f
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Dec 6 12:41:41 2018 +0000

    Bug 21962: Unit tests

    Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 39c93e87f648978ec7907220710efaf64e556ea0)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit d6b7e00b9cd04e15c472b2f7b075d85886ffa3e5)

commit 989c507fb380d66b72954bfadc8926dc33013450
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Dec 3 13:05:49 2018 +0000

    Bug 21405: Fix authorities pagination for Zebra and ES

    Bug 20261 introduced an error because search_auth_compat responded
    differently for ES and Zebra, now bug 19365 fixed the underlying
    difference. This patch restores previous code to fix pagination.

    Additionally we add a fix for 10000+ results in ES and remove a double
    import of C4::Auth

    To test:
     1 - Perform an authorities search with 1+ pages using Zebra
     2 - Page through results, note you are only offseeting by 1 each time
     3 - Perform an authorities search with 10,000+ results in ES
     4 - Click on the last page and get an error
     5 - Apply patch
     6 - Retry Zebra search
     7 - Results should paginate correctly
     8 - Clicking on last page should return last results
     9 - Retry ES results
    10 - Results should paginate correct
    11 - Clicking on last page should return last results

    Signed-off-by: Ere Maijala <ere.maijala at helsinki.fi>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 06e6378899631da162d57d477381782f3764ec89)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit fb5dd96552e84380fd30575880effd0d116309b3)

commit 479967c4dd603956d7ecb8f032cc94b31d9db58a
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Fri Nov 30 07:09:23 2018 +0000

    Bug 21911: Regression test

    This tests usuall cases, but note, that administrator could make a
    branch with code "%%%" or so, which this test does not cover, and some
    functionalities will not work in that case: opac limit override,
                    holdinbranch facet

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit e5585a10d5f2ee24cad94b2cf17df1ce13e8a01a)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 2e6c3b19899c51b801cc5647259793206e2de622)

commit f4b16c70150a139a3600575ef3d113645c931e9c
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Nov 29 14:17:37 2018 +0000

    Bug 21911: Fix OPAC scoping to work with new group system

    To test:

    0 - Apply patch
    1 - Create a library group enabled for opac search limits and add some
    libraries
    2 - Check the DB (or advanced search dropdown) to get the id of the
    group (using 7 as example below)
    3 - Add to apache configuration (OPAC virtualhost)
       SetEnv OPAC_SEARCH_LIMIT branch:multibranchlimit-7
       SetEnv OPAC_LIMIT_OVERRIDE 1
       RequestHeader add X-Koha-SetEnv "OPAC_SEARCH_LIMIT
       branch:multibranchlimit-7"
       RequestHeader add X-Koha-SetEnv "OPAC_LIMIT_OVERRIDE 1"
    4 - Ensure OpacAddMastheadLibraryPulldown is disabled
    5 - Restart all the things
    6 - Visit the opac
    7 - Perform a search, confirm it is scoped to the branches in the group

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 4c0682f5598d53992b6966a217b10f71a9cdaebb)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 647b853073bde006c0477c886a5cce727c3035a1)

commit 41ff722307adb1ce01ce6e5423024d0d5fce8ff5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Dec 6 12:53:24 2018 -0300

    Bug 21910: Does not deal with call context, ->search does already

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 21372f78f825c0ec439ea4a7cfe7dff6656467b9)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 7b849d70e7acf818d33d0602401dd613b8787535)

commit 99824ca8a3953aa461169d5adcc25d821cd07677
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Dec 6 12:52:54 2018 -0300

    Bug 21910: Remove duplicated lines in tests

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit ee96d18b2cee07aa64d5e68078bc898d36e22146)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 5ab531818003874635d842a59ec3234370b200c3)

commit 77e846c441d976df69146cd96018a9039d534e25
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Nov 29 14:11:36 2018 +0000

    Bug 21910: Koha::Library::Groups->get_search_groups should return the groups

    To test:
     1 - Add a library group (Admin->Library groups)
     2 - Enable use as an opac and staff search limit
     3 - Add some libraries to the group
     4 - Visit advanced search on staff and opac
     5 - Note the dropdown has as many empty rows as there are libraries
      in the group
     6 - Apply patch, restart all the things
     7 - Visit staff and opac advanced search
     8 - Confirm the group dropdowns are correct
     9 - Enable OpacMastheadLibraryPulldown
    10 - Ensure the dropdown on opac shows groups correctly
    11 - Confirm earchign groups works from all three locations
    12 - prove -v t/db_dependent/LibraryGroups.t

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit f3b8c66392098d69bca48bbf04b7e93fa2100280)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 7e9ab97390b8cad111bbe9853dc0e27172719c27)

commit 7ffd1602a005310978a8b1e08efc7397826b4668
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Dec 5 16:39:02 2018 -0300

    Bug 21955: Remove Cache::Memory as fallback for L2 cache

    If Plack is running with several workers we must not use Cache::Memory
    as L2 cache.

    If a value is set from a worker, it will not be available from other
    workers as the Cache::Memory instance is not shared (of course!)

    Moreover we now have Koha::Cache::Memory::Lite that does the same job,
    so we should not expect performance regressions by removing it.

    See also the email sent to koha-devel for more info
    http://lists.koha-community.org/pipermail/koha-devel/2018-December/045004.html

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 4bf033c6d6b2a8bf4d5597b3fdf6355fb7060b60)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 6039f64e53172a046c5b579271df7cf434b20e81)

-----------------------------------------------------------------------

Summary of changes:
 C4/Auth.pm                                         |    4 +--
 C4/AuthoritiesMarc.pm                              |    3 ++
 C4/Installer/PerlDependencies.pm                   |    5 ---
 Koha/Cache.pm                                      |   36 --------------------
 Koha/Library/Groups.pm                             |    8 +----
 authorities/authorities-home.pl                    |   19 +++++++----
 .../opac-tmpl/bootstrap/en/includes/masthead.inc   |    6 +++-
 t/db_dependent/Auth.t                              |   30 +++++++++++++++-
 t/db_dependent/LibraryGroups.t                     |   19 ++++++++++-
 t/db_dependent/Search.t                            |   12 +++++++
 10 files changed, 82 insertions(+), 60 deletions(-)

hooks/post-receive
-- 
main Koha release repository