[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.06-57-g0a6c0c3

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  0a6c0c32604ebbd89ccff8d2dc0ff4a11bd204dd (commit)
       via  56cbc940acba33003cb49f3edc964976dd2e0340 (commit)
      from  eb9e17e26f9398507eb820055fa33e197276828a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0a6c0c32604ebbd89ccff8d2dc0ff4a11bd204dd
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Nov 16 09:54:39 2018 -0500

    Bug 21849: Add unit tests
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 2dbaaa300877ff6d96ae84b5a703753d97b6c340)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit aa565b8e9919ee414d0693f391b141985ebacb93)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

commit 56cbc940acba33003cb49f3edc964976dd2e0340
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Fri Nov 16 07:01:39 2018 -0500

    Bug 21849: Two useless Koha::Account::Offset->new calls need attention
    
    Came across those calls in bug 20598 in _FixOverduesOnReturn
    
            Koha::Account::Offset->new(
                {
                    debit_id => $accountline->id,
                    type => 'Forgiven',
                    amount => $amountoutstanding * -1,
                }
            );
    
    This does nothing if you don't store data.
    
    Test Plan:
    1) Apply this patch
    2) Set up 2 items with overdue fines
    3) Return one with dropbox mode
    4) Note the dropbox account offset is created
    5) Return one with full fine forgiveness
    6) Note the forgiven account offset is created
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit a2b5407ba5c74f826c1665c1a2ef1ff6d52689fd)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit ff3d3776a4d9b52da49b6ad4b2a1dde1da9425ee)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm            |    4 ++--
 t/db_dependent/Circulation.t |    8 +++++++-
 2 files changed, 9 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
main Koha release repository