[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.07-10-ge2cfc26

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  e2cfc2615c119252e5c317059312c0d020f2924f (commit)
      from  b89e7f3a2741390ca1acf7f254f058883d7b957c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e2cfc2615c119252e5c317059312c0d020f2924f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Dec 12 11:05:19 2018 -0300

    Bug 21986: Do not escape quotation marks when cataloguing
    
    In several places we escape quotation marks using
      $value =~ s/"/"/g;
    All the occurrences are wrong and must be removed.
    Most of them are leftover of bug 11638 (Remove HTML from
    addbiblio.pl), which removes the construction of html from pl scripts.
    
    The problem has been highlighted by bug 13618, I did not track down why
    the issue did not exist before (?)
    
    Test plan:
    0/ Use strings with quotation marks, like:
    'Fiddle tune history : "bad" tunes'
    You can also use other html characters to make the tests more complete,
    like 'Fiddle tune history : <"bad" tunes>'
    1/ authorities/authorities.pl
    a. Edit an authority filling different fields with quotation marks
    b. Edit it again
    => The display (inputs' values) is wrong, if you save the escaped quotes
    will be inserted
    2/ cataloguing/addbiblio.pl
    Same editing a bibliographic record
    3/ cataloguing/additem.pl
    Same editing items
    4/ members/memberentry.pl
    Edit a patron's record and fill some fields with quotation marks
    + fields borrowernotes and opacnotes
    => The quotes are inserted directly in DB (escape is done before the
    insert!)
    5/ opac/opac-review.pl
    For QA only: $js_ok_review is never used
    6/ tools/batchMod.pl
    For QA only: $value is always undefined at that point
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit d561273ef84f4bc2534ac63d0f8793c9eb2a7fb9)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 305729fdc04c723b2eb372441500d3151e1a62d3)
    
    Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 authorities/authorities.pl |    2 --
 cataloguing/addbiblio.pl   |    2 --
 cataloguing/additem.pl     |    6 ++----
 members/memberentry.pl     |    1 -
 opac/opac-review.pl        |    3 ---
 tools/batchMod.pl          |    3 +--
 6 files changed, 3 insertions(+), 14 deletions(-)


hooks/post-receive
-- 
main Koha release repository