[koha-commits] main Koha release repository branch master updated. v18.11.00-80-g3f73490
Git repo owner
gitmaster at git.koha-community.org
Wed Dec 26 22:05:48 CET 2018
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 3f734900f0a86e5478afc22cb77b493500e998e9 (commit)
via 085cfc6bca30718a6d719d645709097cf86f01db (commit)
via 66f1605c59763613a4e955fd259a845e4fc06324 (commit)
via 3c14a0d3526351fde4d785b5f60117f62edea5a9 (commit)
via a200aafd3b181b736dc288e208730a50372fbfd8 (commit)
via a5eaa7a37d38f4de623918d498d56a2e7bd2bcec (commit)
via 2e5e127b085b0cb6c795a31f16b3a36bad0ebca1 (commit)
via dc7e886379b7035ae9dfc650d995f1e475ca1dff (commit)
via d9ca9f699bdf1718e3923c0cbc6b11c67512abc1 (commit)
via d153e728bb8fa677153281b9bdf8325e76358b4b (commit)
via e91393988d15bd2bf0954dd8de209edf8b7f21a1 (commit)
via 727f33d858e50d26dfb60cec516533d0c4107d2a (commit)
via ccbed38e213de6a6b9331fc34d2f872bf5ab5fc7 (commit)
from 5e17032700790032088fe3f2209c3d173e77d540 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 3f734900f0a86e5478afc22cb77b493500e998e9
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Dec 26 12:25:54 2018 -0300
Bug 21547: (follow-up) Rely on Koha::Patron->set_password checks
This patch makes the controller just call $patron->set_password and use
the exceptions it might raise instead of manually checking the passwor
strength.
No behaviour change should be expected. It also removes some leftovers.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 085cfc6bca30718a6d719d645709097cf86f01db
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu Oct 11 12:00:31 2018 +0200
Bug 21547: Use set_password in opac-passwd and remove sub goodkey
Remove sql statement to change password by calling set_password.
Remove sub goodkey by calling C4::Auth::checkpw_hash.
Adding the scalar before param Oldkey (from bug 21036).
Rebased on top of 21178 (using set_password instead of update_password).
Test plan:
Try to change password in OPAC with good and bad pw.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 66f1605c59763613a4e955fd259a845e4fc06324
Author: Alex Buckley <alexbuckley at catalyst.net.nz>
Date: Wed Oct 31 10:27:41 2018 +0000
Bug 21754: Automatically clean up outstanding transfers on lost items
This is an alternative to bug 21732 as transfers are automatically cancelled on marking an item lost, and the items holding rbanch is set to the transfers source ('from') branch.
When an item is marked as lost, the routine should also clean up any
outstanding transfers.
Also added tests to t/db_dependent/Circulation.t which check:
* If transfer is automatically deleted when item is marked as lost
* If the items holdingbranch automatically changes when item with
transfers on it is marked as lost.
Test plan:
1. Find a item which is in transfer, i.e. find an item with the text in
the 'Status' field of the table in detail.pl that indicates it is in
transfer
2. Set the item to 'Lost' either by clicking on Edit->Edit items from
the detail.pl page
OR
clicking on the Items tab on the left side of the detail.pl page
3. Notice that the transfer is now cancelled for the item and the items
holdingbranch is the transfers source ('from') branch
4. Run t/db_dependent/Circulation.t
Sponsored-by: Brimbank Library, Australia
Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace at sub.su.se>
(fixed the introduction of a whitespace line and removed a double
declare warning from the new tests as part of QA)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 3c14a0d3526351fde4d785b5f60117f62edea5a9
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Sat Dec 1 10:05:38 2018 +0000
Bug 21929: Typo in orderreceive.tt
lass -> class
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a200aafd3b181b736dc288e208730a50372fbfd8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Oct 16 11:51:40 2018 -0300
Bug 21571: Make ACCTDETAILS translatable
This patch makes the notice "ACCTDETAILS" translatable.
Test plan:
1. Switch on TranslateNotices and AutoEmailOpacUser
2. Define templates for different languages for ACCTDETAILS
3. Create a new patron, define an email address, userid and password.
Also pick a different "preferred language" then the default value
4. You should receive the email with the correct, translated, email.
Signed-off-by: Hugo Agud <hagud at orex.es>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a5eaa7a37d38f4de623918d498d56a2e7bd2bcec
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Nov 15 18:56:00 2018 +0000
Bug 21844: Include itemcallnumber in lost fine description
To test:
1 - Make sure WhenLostChargeReplacementFee is set to charge
2 - Find an item with a replacement cost (or default) and a call number
3 - Checkout the item to a patron
4 - Mark the item lost
5 - View the fine - the description includes title and barcode
6 - Apply patch
7 - Check the item in
8 - Check it out again
9 - Mark it lost
10 - Note the fine includes the callnumber
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 2e5e127b085b0cb6c795a31f16b3a36bad0ebca1
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sat Oct 27 11:49:11 2018 +0000
Bug 21693: Make page title consistent with other pages
For some reason we use 'Home' in the bread crumbs, but
'Koha' as starting point in the page title.
Changed to make consistent with other pages in Circulation.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit dc7e886379b7035ae9dfc650d995f1e475ca1dff
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Oct 26 16:15:39 2018 +0000
Bug 21693: Clean up checkout notes template
This patch modifies the checkout notes template to help compliance with
coding guidelines and interface patterns:
- Convert to Bootstrap grid
- Improve DataTables configuration
- Put buttons into a toolbar and move above selection links
Also corrected: Minor markup error in circ-nav.inc
To test, apply the patch and enable the AllowCheckoutNotes system
preference. Add a few checkout notes via the OPAC.
- Go to Circulation -> Checkout notes.
- Confirm that the page looks correct at various browser widths.
- Confirm that the first and last columns of the table of notes are
not sortable.
- The table should be sorted by default by title.
- Title sorting should ignore articles "a," "an," and "the."
- Test with the CircSidebar preference both on and off.
- With CircSidebar turn on, the checkout notes menu item in the
left hand sidebar should show a count of checkout notes.
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit d9ca9f699bdf1718e3923c0cbc6b11c67512abc1
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Oct 26 18:36:59 2018 +0000
Bug 21695: Clean up access files template
This patch modifies the access files template to help
compliance with several coding guidelines:
- Bootstrap grid
- Improve DataTables configuration
- Move date formatting from the script to the template
- Markup corrections
To test you must modify koha-conf.xml to contain something like the
following:
<access_dirs>
<access_dir>/tmp/koha-public</access_dir>
</access_dirs>
Make sure the directory exists and contains multiple files.
- Go to Tools -> Access files
- Confirm that the page looks correct and the layout adjusts at various
browser widths.
- Confirm that DataTables functionality works correctly, including
correct sorting by date.
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit d153e728bb8fa677153281b9bdf8325e76358b4b
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Nov 8 17:53:51 2018 +0000
Bug 21795: Switch two-column templates to Bootstrap grid: Notices and slips
This patch updates notices and slips templates to use Bootstrap grids
instead of YUI.
This patch also removes obsolete "text/css" attributes from <style> tags
in the modified templates.
To test, apply the patch and go to Tools -> Notices and slips. Test that
these pages look correct and adujst well to various browser widths.
- The main page listing notices and slips
- The add/edit form
- The notice preview modal available when editing CHECKIN, CHECKOUT and
HOLD_SLIP.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit e91393988d15bd2bf0954dd8de209edf8b7f21a1
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Nov 8 16:37:19 2018 +0000
Bug 21790: Switch error page template to Bootstrap grid
This patch updates the error page template to use a Bootstrap grid
instead of YUI.
To test, apply the patch and disable Plack and restart Apache if
necessary.
Navigate to a page in Koha which doesn't exist. The error page should
look correct and adapt well to various browser widths.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 727f33d858e50d26dfb60cec516533d0c4107d2a
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Wed Dec 16 01:25:44 2015 +0100
Bug 21789: Example usage of I18N Template::Toolkit plugin
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit ccbed38e213de6a6b9331fc34d2f872bf5ab5fc7
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Dec 20 18:55:34 2018 -0300
Bug 22033: Remove related_resultset from the list of available methods
It is not covered by tests.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Circulation.pm | 8 ++-
C4/Letters.pm | 1 +
C4/Search.pm | 1 -
Koha/Object.pm | 4 +-
.../intranet-tmpl/prog/en/includes/circ-nav.inc | 2 +-
.../prog/en/modules/acqui/orderreceive.tt | 2 +-
.../prog/en/modules/catalogue/results.tt | 3 +-
.../prog/en/modules/circ/checkout-notes.tt | 75 +++++++++++---------
.../prog/en/modules/errors/errorpage.tt | 14 ++--
.../prog/en/modules/tools/access_files.tt | 40 ++++++-----
.../intranet-tmpl/prog/en/modules/tools/letter.tt | 30 ++++----
.../prog/en/modules/tools/preview_letter.tt | 16 ++---
koha-tmpl/intranet-tmpl/prog/js/letter.js | 2 +-
opac/opac-passwd.pl | 47 ++++--------
t/db_dependent/Circulation.t | 53 +++++++++++++-
tools/access_files.pl | 2 +-
16 files changed, 178 insertions(+), 122 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list