[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.02-23-gdeb7d17
Git repo owner
gitmaster at git.koha-community.org
Fri Feb 2 16:38:26 CET 2018
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 17.11.x has been updated
via deb7d1717736e00b0dbb3a45d9b41d6259d0d6ce (commit)
via 2a06f9be43184c12e37e2cca0057b7584d8610bd (commit)
via 8f4b2b7b37221e626d45263090ce9f8cce0247aa (commit)
via 3c5a561cfc156b4d465d25ca03d9a3d11b09d23d (commit)
via 5cdf443250ac028093dd41942a9477cd7473a775 (commit)
via 5bdeeda457205cb11d02bc4d615cd75044b57702 (commit)
via a66fdeaa63919d66970f3c3e4aa89ab9ef7da0f7 (commit)
via 0d36e8a429dcadb3bbc48d43e9ead8b8ad947a77 (commit)
via e83f5c807d717e447a52353af1067c6c241e952a (commit)
via 68f595c1c7fd51c528a6029bf3d45715c12f769b (commit)
via 3e93c07250f3909df796d412b2160b949f9f8b46 (commit)
via dab2f8e327e2140e82ee3bf3bceafc0939fcf408 (commit)
via 9ed362a566b345c842be812f94fcdd27dbf241f1 (commit)
via 71cb493c6805385f2ab3b1ddf64561f58205679c (commit)
via 7837347fc99f9e6550d8fbc043ad13d16e96bb0e (commit)
via fc172d3252b8587006f7d6b4d747ce2b339ea803 (commit)
via 8005d27c5d0c1a2063e94e8b8931306e37fb9498 (commit)
via fac379745770ec518b9068d0454b23843f71dcb4 (commit)
via a6d6b0fdf68e56fd41eb3a8e38362a0e8005de9e (commit)
via 55d8ea59e7964d05ffb68e7bfcf14d6556ed8739 (commit)
via e1a61134eb921760ebe3ac992a151591bb3977bf (commit)
via 2a0423778e73467beeb57379db49b49b811894aa (commit)
via 23090cac1ea82ff7958097562fa38c92219a1e9e (commit)
from 2a87bcc1c40b72672d429e5ac3ef8c548bf75cf5 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit deb7d1717736e00b0dbb3a45d9b41d6259d0d6ce
Author: Mirko Tietgen <mirko at abunchofthings.net>
Date: Tue Jan 23 14:00:05 2018 +0100
Bug 17108 - Automatic debian/control updates (stable)
Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 2a06f9be43184c12e37e2cca0057b7584d8610bd
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu Jan 25 12:01:30 2018 +0100
Bug 20088: Fix uninitialized warning from svc/holds
Use of uninitialized value in array element at svc/holds line 56.
Test plan:
Check if the warn is no longer in the logs; the warning is triggered by
an ajax call from the circulation template in staff.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 8f4b2b7b37221e626d45263090ce9f8cce0247aa
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Mon Jan 22 09:49:36 2018 +0100
Bug 20056: Resolve uninitialized warn in cmp_sysprefs.pl
When running a compare with --upd flag, I got the following warn:
Use of uninitialized value in addition (+) at misc/maintenance/cmp_sysprefs.pl line 125.
This is simply resolved by not returning undef but 0 in case of the Version
syspref in the sub UpdateOnePref.
Test plan:
Look at this simple change.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 3c5a561cfc156b4d465d25ca03d9a3d11b09d23d
Author: Zoe Bennett <zoebennett1308 at gmail.com>
Date: Wed Jan 17 23:16:38 2018 +0000
Bug 19827: Removing &checkuniquemember from the export in C4/Members.pm
Test Plan:
- Check that the line &checkuniquemember has been removed from the
export in C4/Members.pm
Signed-off-by: Roch D'Amour <roch.damour at inlibro.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 5cdf443250ac028093dd41942a9477cd7473a775
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Jan 26 12:43:58 2018 +0000
Bug 20091: Moved FailedLoginAttempts out of Norwegian Patron Database heading
To test:
1 - View systempreferences patron tab
2 - Note FailedLoginAttempts is uner 'Norwegian Patron Database'
3 - apply patch
4 - Now it is under 'General'
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Maksim Sen <maksim at inlibro.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 5bdeeda457205cb11d02bc4d615cd75044b57702
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Sun Jan 28 01:41:01 2018 -0500
Bug 13990: (follow-up) silence warnings on testing
prove t/db_dependent/ILSDI_Services.t
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a66fdeaa63919d66970f3c3e4aa89ab9ef7da0f7
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Sun Jan 28 01:18:54 2018 -0500
Bug 13990: (QA follow-up) Add unit test coverage
prove t/db_dependent/ILSDI_Services.t
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 0d36e8a429dcadb3bbc48d43e9ead8b8ad947a77
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Fri Jan 26 16:20:20 2018 +0000
Bug 13990: (follow-up) fix various whitespace errors
- tabs to 4 spaces
- trailing whitespace
- missing vertical whitespace before =head3
Without this patch, this bug fails qa test tools.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit e83f5c807d717e447a52353af1067c6c241e952a
Author: Jon Knight <J.P.Knight at lboro.ac.uk>
Date: Tue Nov 7 17:27:56 2017 +0000
Bug 13990: ILS-DI LookupPatron requires ID Type
Patch provides a constrained set of borrower attributes to try in turn if the
ID type is not specified. Also added "email" to the POD documented list of
id types seeing as its quite a useful one for integration developers.
Test plan:
1) without the patch applied, turn on ils-di interface in your admin sysprefs
and then try accessing the URL:
https://your-server/cgi-bin/koha/ilsdi.pl?service=LookupPatron&id=Mabel
replacing "your-server" your Koha dev test domain name (localhost:8080 if
you're using a kohadevbox VM) and "Mabel" with the first name of a patron
(Mabel is in the test database already if you're using that).
You should get back an error message in the XML.
2) Apply the patch and repeat. This time you should get an <id> element in
the XML with Mabel's patron ID in it.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 68f595c1c7fd51c528a6029bf3d45715c12f769b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jan 30 14:06:27 2018 -0300
Bug 19230: (follow-up) Preventing warn when deleting course
Simplify 'unless' statement
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Conflicts:
koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 3e93c07250f3909df796d412b2160b949f9f8b46
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Thu Dec 21 00:57:21 2017 +0000
Bug 19230: Preventing warn when deleting course
To test:
1) Ensure UseCourseReserves is enabled
2) Go to Course Reserves, create a course
3) When you are taken to the course page, you should notice the
'Argument "" isn't numeric in numeric gt' warn
4) Delete course
5) Notice warn, and that no confirm message popped up
6) Apply patch
7) Create a course again. Confirm the 'Argument "" isn't numeric in
numeric gt' warn did not show
8) Delete the course
9) Notice no warn and the confirm message pops up
Sponsored-by: Catalyst IT
Signed-off-by: Roch D'Amour <roch.damour at inlibro.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Conflicts:
koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit dab2f8e327e2140e82ee3bf3bceafc0939fcf408
Author: Liz Rea <liz at catalyst.net.nz>
Date: Fri Jan 26 15:01:39 2018 +1300
Bug 20041: ILL module missing from more menu in staff when activated
Apply this patch
Check that ILL requests are now listed in More menu when ILL requests syspref is enabled
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 9ed362a566b345c842be812f94fcdd27dbf241f1
Author: Grace Smyth <gracesmythh at gmail.com>
Date: Wed Jan 17 20:36:59 2018 +0000
Bug 19986: 'Server name' doesn't appear as required
Test plan:
[1.] Go to Admin -> z39.50/SRU servers
[2.] Make a new z39.50 server
[3.] Fill in the required field (hostname, port, database)
[4.] Save the server
[5.] Notice that the form does not submit, tells you that Sever name is
required
[6.] Repeat steps 2 - 5 but this time make a new SRU server
[6.] Upload the patch and repeat steps 1 - 3 (make a new z39.50 server
and a new SRRU server)
[7.] See that now 'Server name:' is red and on the right side of the box
there is a required note
[8.] Save both servers and it should have created a new z39.50 server
and a new SRU server
Signed-off-by: Roch D'Amour <roch.damour at inlibro.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 71cb493c6805385f2ab3b1ddf64561f58205679c
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Jan 26 21:05:39 2018 +0000
Bug 20003: (QA follow-up) use patron checkouts method instead of Koha::Checkouts
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 7837347fc99f9e6550d8fbc043ad13d16e96bb0e
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Thu Jan 18 07:56:15 2018 +0000
Bug 20003: Fix showing number of remaining checkouts during checking in
Test plan:
0) Do not apply the patch
1) Have a patron with more then one checkout
2) Return one of patron's checkout and confirm the remaining number of
checkout is not shown
3) Apply the patch
4) Try it again and confirm the number is now shown
Signed-off-by: Roch D'Amour <roch.damour at inlibro.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit fc172d3252b8587006f7d6b4d747ce2b339ea803
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Jan 22 17:04:28 2018 -0300
Bug 19975: Fix search by tags at the OPAC
This bug has certainly be caused by
commit 091d6c513bcbee224ff06477e79be48cea7fe825
Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes
The reason is quite simple, in Koha::ItemType->translated_description
(called in opac-search.pl l.229) there is an eval to know if we have
access to the translated description of the item type, to avoid
retrieving it again.
The evaluation of $@ later in opac-search.pl is supposed to test the 2
eval made few lines before (a "normal" search, without tags), but
$@ contains the error message from the *last* eval command.
So we are raising an error that have been correctly handled in
Koha::ItemType.
Test plan:
At the OPAC, click Tag cloud, then click any of the tags
=> Without the patch you get
Koha::ItemType::get_column generated this error: DBIx::Class::Row::get_column(): No such column 'translated_description' on Koha::Schema::Result::Itemtype at /usr/share/koha/lib/Koha/Object.pm line 307
=> With the patch applied the page is correctly displayed
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 8005d27c5d0c1a2063e94e8b8931306e37fb9498
Author: Mirko Tietgen <mirko at abunchofthings.net>
Date: Tue Jan 23 11:43:10 2018 +0100
Bug 20072: Fix build-git-snapshot for Debian source format quilt
With bug 18696 we need a few tiny changes to build-git-snapshot:
- Debian revision number for debian/changelog
- "orig" in the file name for the tar.gz archive
Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit fac379745770ec518b9068d0454b23843f71dcb4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jan 30 12:24:48 2018 -0300
Revert "Bug 19669: (QA follow-up) Remove itemstypes.plugin"
This reverts commit 7140a5e4ecc68759c1bee04571386f9cc9a16d92.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a6d6b0fdf68e56fd41eb3a8e38362a0e8005de9e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jan 23 17:00:16 2018 -0300
Bug 19705: Try to fix random failures from DecreaseLoanHighHolds.t
No idea if it will do the trick, wait and see...
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 55d8ea59e7964d05ffb68e7bfcf14d6556ed8739
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Jan 22 17:18:59 2018 -0300
Bug 19985: Make TestBuilder.t pass even if default_circ_rules is not empty
This table cannot contain more than 1 row, so we need to remove its data
before trying to generate a new entry.
Test plan:
Set a default circ rule
prove t/db_dependent/TestBuilder.t
should return green
Without this patch you get:
# Failed test 'TestBuilder should be able to create an object for every source'
# at t/db_dependent/TestBuilder.t line 78.
# got: '1'
# expected: '0'
# The following sources have not been generated correctly: DefaultCircRule
# Looks like you failed 1 test of 1.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit e1a61134eb921760ebe3ac992a151591bb3977bf
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon May 8 16:47:06 2017 +0000
Bug 18477: Populate article_requests table values for AR_PENDING notices
The default AR_PENDING letter does not print populate <<article_requests.*>> fields.
Test Plan:
1) Enable article requests ( syspref: ArticleRequests => Enable, Circ and fine rules ALL/ALL (or a given category/itemtype): Article requests => Yes )
2) Search for a title, click in to catalog detail, click 'Request Article' button.
3) Select Patron
4) Fill out request information
5) Click 'Place request'
6) Go to notices in patron record, inspect 'Article Request Received' notice. You should see the request information from step 4, but it doesn't display.
7) Apply this patch
8) Repeat steps 2-6, not the fields now display!
Signed-off-by: Eric Phetteplace <phette23 at gmail.com>
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 2a0423778e73467beeb57379db49b49b811894aa
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jan 2 14:36:43 2018 -0300
Bug 18477: Add tests
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 23090cac1ea82ff7958097562fa38c92219a1e9e
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Mon Jan 22 23:52:21 2018 +0000
Bug 20068: Check if user logged in before passing dashboard params to template
This prevents warns from dashboard variables when not logged in
To test:
1) Go to OPAC main homepage. Do not log in
2) Notice warn
3) Apply patch and refresh
4) Warn should be gone
5) Log in
6) Confirm dashboard shows as normal
Sponsored-by: Catalyst IT
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/ILSDI/Services.pm | 143 +++++++++++---------
C4/Members.pm | 1 -
Koha/ArticleRequest.pm | 1 +
circ/returns.pl | 3 +-
course_reserves/mod_course.pl | 12 +-
debian/build-git-snapshot | 4 +-
debian/control | 32 +++--
.../intranet-tmpl/prog/en/includes/header.inc | 3 +
.../prog/en/modules/admin/preferences/patrons.pref | 10 +-
.../prog/en/modules/admin/z3950servers.tt | 4 +-
.../en/modules/course_reserves/course-details.tt | 2 +-
koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt | 5 +-
misc/maintenance/cmp_sysprefs.pl | 2 +-
opac/ilsdi.pl | 2 +-
opac/opac-main.pl | 31 +++--
opac/opac-search.pl | 2 +-
reports/itemtypes.plugin | 109 +++++++++++++++
svc/holds | 4 +-
t/db_dependent/ArticleRequests.t | 25 +++-
t/db_dependent/DecreaseLoanHighHolds.t | 5 +
t/db_dependent/ILSDI_Services.t | 57 +++++++-
t/db_dependent/TestBuilder.t | 1 +
22 files changed, 340 insertions(+), 118 deletions(-)
create mode 100755 reports/itemtypes.plugin
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list