[koha-commits] main Koha release repository branch master updated. v17.11.00-320-g750adfb
Git repo owner
gitmaster at git.koha-community.org
Fri Jan 19 19:58:08 CET 2018
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 750adfb41484352e36723edc4cb292cae425cf25 (commit)
via 231817c40f528144d8fe29f5a0b20470205052f2 (commit)
via 3dfb27605c9f953d311382e662155f7f282f0e07 (commit)
via 2c4974cc1246ceb5d84ed01ce70456ef34b9b330 (commit)
via dfc82dbc418bc79781df3a9e231e60491c501220 (commit)
via d2a045b9d508d56e556ecbbb11238d8108ce4512 (commit)
via 5a2d0a8f652aa958b1c650fdf8002846970ce98c (commit)
via f37ebd0f76e3bfcdcde6c27bbc2671910449fc59 (commit)
via 6252c297a957124169b69b281ea764223bb71218 (commit)
via 727177df5c0c02814f6f5c1cfeca65674d54c8fc (commit)
via 1ebb19a94b7e28016048b9220f3e8b75ded22062 (commit)
via 66693d84a8c5949766c1de76649c45ffe6a39815 (commit)
via e85b584499946cee7f725fb839e484fdc049adbd (commit)
via 59ea245f854ec04e8e081f6effececa4193f84c5 (commit)
via 6f68f5c90136d6da1ec91778b3ee0ba9fb8ca613 (commit)
via 2da5356e4b8dc5a7313a7d117a664764d4afc31c (commit)
via 4933de21ea0d5d70d078456ff2317187134f1a4c (commit)
via 6ef92056ffea9dd47d59dc9695391167ed3fdcb1 (commit)
via 42d7b23c0256e4aab9aa6f1d014524ad9c5e0cd6 (commit)
via 42d8c599e577e0595555892b83f9bee420516c0d (commit)
via 01af3bb7dd1cd92eca2f33429048030655f7a0a0 (commit)
via 8329eb174a4f856b11c0fd8c331bdd6f0371085c (commit)
via 898b17ba8e8906870f7876f5e8283b05a1c93c7b (commit)
via 6559f5524fdd586838bd48d03ee86f5c710ff35e (commit)
via 326e83748c300ace9679244989c54ef6cffb9e5a (commit)
from 129ffee791da9f8ab4ad85a4473a138fc81ccbef (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 750adfb41484352e36723edc4cb292cae425cf25
Author: Zoe Bennett <zoebennett1308 at gmail.com>
Date: Wed Jan 17 03:27:06 2018 +0000
Bug 19988: Fixing the case where terminolgy referred to sex instead of gender.
To test:
1) Change a users gender in the OPAC
2) View it in the patron request in the staff client
3) Check that under 'Field' it now says 'Gender' instead of 'Sex'
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 231817c40f528144d8fe29f5a0b20470205052f2
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Jan 19 15:42:54 2018 -0300
Bug 18083: Simplify the condition - if there are more than 1 library
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3dfb27605c9f953d311382e662155f7f282f0e07
Author: Te Rauhina Jackson <terauhina.jackson at gmail.com>
Date: Tue Jan 16 03:03:47 2018 +0000
Bug 18083: Don't show 'library' selection on popular titles page for single-branch libraries
This patch hides the search filter labelled "From" that offers you to
select a library branch which is located on the 'popular titles' page on the OPAC. It is hidden when the library only has one branchas it would be unneccessary to have an option for other branches when there is only one.
Test Plan:
1) Make sure you have a single-branch library
2) Make sure OPACTopIssue is allowed in the OPAC preferences
3) In the OPAC, got to 'Most Popular' page
4) Check that there is no "From" filter in the refine search
5) Create a new branch so that you have more than one branch
6) Check that there is a "From" filter in the refine search on the Most Popular page.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Amended white space on second change.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2c4974cc1246ceb5d84ed01ce70456ef34b9b330
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu Nov 2 10:55:42 2017 +0100
Bug 19585: Inventory: Allow additional separators in a barcode file
This patch makes \n, \r, |, comma, semicolon and hyphen ('-') all valid
separators between barcodes passed to inventory.
An additional grep removes empty barcodes. (Note: The grep looks for at
least one non-whitespace character. We could be more specific, but this
allows for more flexibility like testing with alphanumeric barcodes etc.)
Test plan:
Upload a barcode file that contains various allowed separators.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jenny Way <jwayway at hotmail.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit dfc82dbc418bc79781df3a9e231e60491c501220
Author: Grace Smyth <gracesmythh at gmail.com>
Date: Tue Jan 16 02:16:50 2018 +0000
Bug 18878: Align labels in item form to the right
Test Plan
[1.] Search for an item and click on it
[2.] Press the edit button to edit an item
[3.] Notice that the labels are aligned to the left and very far away
from the boxes
[4.] Load the patch and now notice that the labels are closer to the
boxes and are easier to read
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d2a045b9d508d56e556ecbbb11238d8108ce4512
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Dec 20 20:29:29 2017 -0300
Bug 15770: Do not format numbers if too big
At several places we got the following error if we use numbers too big
for Number::Format
Template process failed: undef error - round() overflow. Try smaller
precision or use Math::BigFloat at /home/koha/src/Koha/Number/Price.pm line 44
It make the app explodes.
The goal here is to handle these errors gracefully and easily.
Test plan:
- Add a manual fine to a patron of 100000000000000
- Create a patron category with an enrolment fee of 123456789012345
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5a2d0a8f652aa958b1c650fdf8002846970ce98c
Author: Olivier Crouzet <kohateam at univ-lyon3.fr>
Date: Mon Jan 15 17:22:22 2018 +0100
Bug 19971: Typo in the comments of parseQuery routine
TEST PLAN
---------
1) Run these commands:
git checkout master
git pull
perldoc C4::Search
2) look for parseQuery
-- NOTE: The sample code provided below this heading has
the wrong function name!
3) Run these commands:
git checkout -b bug_19971 origin/master
perldoc C4::Search
4) look for parseQuery
-- NOTE: The wrong function name is corrected.
5) Run koha qa test tools
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f37ebd0f76e3bfcdcde6c27bbc2671910449fc59
Author: Te Rauhina Jackson <terauhina.jackson at gmail.com>
Date: Tue Jan 16 21:21:21 2018 +0000
Bug 19221: Onboarding tool says user needs to be made superlibrarian
I changed the "To give new patron superlibrarian permissions go to:"
message to "To edit patron permissions, go to:". Please clarify if this
is clearer or not.
Test plan:
1) Apply patch
2) Go through the web installer
3) At the create koha administrator patron step, notice that at the
bottom, there is a message saying "To edit patron permissions, go
to:"
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6252c297a957124169b69b281ea764223bb71218
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Sun Dec 17 08:45:41 2017 +0000
Bug 19825: Make links to biblios on pending offline circulation page working again
0) Do not apply the patch
1) Have pending offline circulation operations - you can use standalone
application, Firefox add-on or built-in offline circulatin client - it
does not matter in this case
2) Go to Circulation -> pending offline circulation actions
3) You see all barcode in red and without links - even if the item and
biblio existed
4) Apply the patch
5) Repeat 1-3, now you should see the links to biblio on existing items
Note: Don't add non-existent barcodes actions and payment actions unti
bug 19771 is not fixed
Signed-off-by: Charlotte Cordwell <charlotte.cordwell123 at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 727177df5c0c02814f6f5c1cfeca65674d54c8fc
Author: Grace Smyth <gracesmythh at gmail.com>
Date: Tue Jan 16 03:41:15 2018 +0000
Bug 19839: Removed Warning (invoice.pl - uncertainprices)
Test Plan
[1.] Check the patch to see that I have removed:
$template->param( uncertainprices => 1 ); from line 204 as Mr Druart has instructed to do
(to get to the patch see the comment above by Mr Druart)
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1ebb19a94b7e28016048b9220f3e8b75ded22062
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Jan 19 15:49:28 2018 -0300
Bug 17682: DBRev 17.12.00.006
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 66693d84a8c5949766c1de76649c45ffe6a39815
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Jan 19 15:26:32 2018 -0300
Bug 17682: Replace 2 occurrences in de-DE and nb-NO
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e85b584499946cee7f725fb839e484fdc049adbd
Author: Charlotte Cordwell <charlotte.cordwell123 at gmail.com>
Date: Tue Jan 16 20:14:20 2018 +0000
Bug 17682: (follow-up) Change URL for Google Scholar in OPACSearchForTitleIn
Amended the sql statement so it only affects the http://www.scholar.google.com url
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 59ea245f854ec04e8e081f6effececa4193f84c5
Author: Charlotte Cordwell <charlotte.cordwell123 at gmail.com>
Date: Tue Jan 16 03:55:49 2018 +0000
Bug 17682: Change URL for Google Scholar in OPACSearchForTitleIn
1)apply patch
2) go into administration --> search for OPACSearchForTitleIn
3) *click to edit*
4) look at the link and read the google scholar one.
5) check that the start link is https://scholar.google.com.
6) http://www.scholar.google is incorrect
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6f68f5c90136d6da1ec91778b3ee0ba9fb8ca613
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Jan 19 14:11:51 2018 +0000
Bug 16603: (QA follow-up) Add a FIXME
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2da5356e4b8dc5a7313a7d117a664764d4afc31c
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Dec 1 18:23:01 2017 +0000
Bug 16603: When processing uploaded offline circulation file, "apply directly" option fails
This patch is a temporary mitigation of whatever the real problem is.
The patch hides the "Apply directly" button so that the option isn't
available.
To test, apply the patch and generate a .koc file with some
transactions. Upload the file via Circulation -> Offline
circulation file upload. After the file is uploaded, you should see only
a "Add to offline circulation queue" button, which should work
correctly.
Signed-off-by: Grace Smyth <gracesmythh at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 4933de21ea0d5d70d078456ff2317187134f1a4c
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Dec 18 14:42:25 2017 +0000
Bug 19677: Properly escape enumchrom/serialseq data
Some serial issues use angle brackets for denoting certain data.
Currently this is not displayed in Koha. This patch escapes the data so
that angle brackets will display.
To test:
1 - Add an enumchron field to an item containg angle brackets:
"This is a <test>"
2 - View the record in the staff and opac, not the field displays as:
"This is a"
3 - Apply patch
4 - Note full text now displays
Signed-off-by: Charlotte Cordwell <charlotte.cordwell123 at gmail.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6ef92056ffea9dd47d59dc9695391167ed3fdcb1
Author: Mirko Tietgen <mirko at abunchofthings.net>
Date: Fri Jan 19 14:06:48 2018 +0100
Bug 18696: Change debian/source/format to quilt
debian/source/format uses 'native'. As Koha is not native Debian software,
and to allow Debian revision numbers like -2 in 16.05.13-2, it should be
changed to 'quilt'.
This is only relevant to packaging and does not affect Koha itself.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 42d7b23c0256e4aab9aa6f1d014524ad9c5e0cd6
Author: Mirko Tietgen <mirko at abunchofthings.net>
Date: Fri Jan 19 13:55:30 2018 +0100
Bug 19783: Move check_kohastructure.t to db_dependent
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 42d8c599e577e0595555892b83f9bee420516c0d
Author: Mirko Tietgen <mirko at abunchofthings.net>
Date: Fri Jan 19 13:59:43 2018 +0100
Bug 20042: 00-load.t fails when Elasticsearch is not installed
00-load.t fails when Elasticsearch is not installed. Blocks packaging.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 01af3bb7dd1cd92eca2f33429048030655f7a0a0
Author: Grace Smyth <gracesmythh at gmail.com>
Date: Thu Jan 18 20:30:00 2018 +0000
Bug 19987: If no z39.50/SRU servers the button should not show
Test plan:
[1.] Load the patch and make sure you have some Z39.50/SRU servers
(Administration => Z39.50/SRU servers administration)
[2.] Then go to authorities and notice that the 'New from
Z39.50/SRU' button is there
[3.] Next go to cataloging and notice that the 'New from Z39.50/SRU'
button is there too
[4.] Now make sure you have no Z39.50/SRU servers (remove the
servers)
(Administration => Z39.50/SRU servers administration)
[5.] Go to authorities and notice that the 'New from Z39.50/SRU'
button is not there
[6.] Lastly go to cataloging and notice that the 'New from Z39.50/SRU'
button is not there too
:)
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
I added a missing [% END %] during signoff. Hope no one minds!
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8329eb174a4f856b11c0fd8c331bdd6f0371085c
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Tue Jan 16 10:20:21 2018 +0100
Bug 19977: Open only .pref files in Local Use tab (sysprefs)
Test plan:
1. Open .../prog/en/modules/admin/preferences/circulation.pref
with vim (check that it creates a .circulation.pref.swp in the same
directory)
2. Go to the "Local Use" tab in admin/systempreferences.pl
3. Confirm that the page works normally
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 898b17ba8e8906870f7876f5e8283b05a1c93c7b
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Sun Dec 17 08:53:18 2017 +0000
Bug 19771: Fix crashing in pending offline circulation actions list
When the barcode is empty or invalid, an "Internal Server Error"
is triggered on the kohadev box.
TEST PLAN
---------
0) back up your database if you care about it.
1) Run the following commands:
git checkout master
git pull
git checkout -b bug_19771 origin/master
git bz apply 19771
-- This should be quite uneventful. Standard promptings.
2) Continue to run the following commands:
git checkout master
reset_all
sudo koha-shell -c bash kohadev
./misc/cronjobs/create_te_koc_db.pl --sqlite3
-- This will create a borrowers.db in your current directory.
3) On the host where you intend on running the koct install it.
-- https://sourceforge.net/projects/koha-oc/files/
download and install.
4) get the borrowers.db file to your host where you installed koct
5) point koct at the file you downloaded
Database -> Select Borrowers DB File
6) Create a .koc file with the following transactions.
check in, check out, check in (bad barcode),
pay fines (any non-zero amount).
7) Run the following commands:
restart_all
-- we want to make sure caching for plack isn't in the way.
8) In the staff client: Home -> Circulation
-> Upload offline circulation file (.koc)
9) Choose the file created and click 'Upload file'.
10) Add to offline circulation queue.
11) View pending offline circulation actions
-- This should die. Reading /var/log/koha/kohadev/plack-error.log
should be the same error as comment #0.
However, this was only the bad biblio error.
12) Run the following commands:
git checkout bug_19771
restart_all
13) Refresh staff client page.
-- it should all come up.
14) Select the bad biblio line, and delete it.
15) Run the following commands:
git checkout master
restart_all
16) Refresh the staff client page.
-- it should die. Same error as comment #0.
This confirms the fine payment issue.
17) Run the following commands
git checkout bug_19771
restart_all
18) Refresh the staff client page.
-- it should all come up.
19) run the koha qa test tools
20) if you backed up your database, restore it. :)
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6559f5524fdd586838bd48d03ee86f5c710ff35e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Jan 18 12:49:12 2018 -0300
Bug 20001: Fix confusion between array and arrayref
Illrequest->available_backends always returned only 1 element
TEST PLAN
---------
See bug 7317 comment #20 for configuring ILL
Make sure to restart_all
Strangely, ILLIBS didn't exist, but IL did in default install,
so use that as the patron code in your koha-conf.xml
Make sure to turn on the ILL related system preference.
1) Configure ILL.
-- this is the hard part. Hopefully the above will give you
enough.
2) open OPAC and log in
3) Click the 'your interlibrary loan request' in the left pane
4) Click the 'Create a new request' button.
-- when you hover your mouse over the links for the backends,
they will have ARRAY(...) instead of a meaningful name.
This is what triggers the error (see comment #7).
5) Run the following commands
git checkout -b bug_20001 origin/master
git bz apply 20001
restart_all
6) Refresh the OPAC page, and repeat step 4.
-- when hovering your mouse over the links for the backends,
they will have meaningful values now.
7) run koha qa test tools.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 326e83748c300ace9679244989c54ef6cffb9e5a
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Oct 20 10:00:19 2016 -0300
Bug 17467: Add missing --status switch handling
RM note: I forgot this patch (no idea what happened!)
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
C4/Search.pm | 2 +-
Koha.pm | 2 +-
Koha/Illrequest.pm | 4 ++--
Koha/Number/Price.pm | 5 +++++
acqui/invoice.pl | 1 -
admin/systempreferences.pl | 2 +-
authorities/authorities-home.pl | 12 ++++++++++++
cataloguing/addbooks.pl | 12 ++++++++++++
debian/scripts/koha-zebra | 3 +++
debian/source/format | 2 +-
.../data/mysql/de-DE/mandatory/system_preferences.sql | 2 +-
.../data/mysql/nb-NO/1-Obligatorisk/system_preferences.sql | 2 +-
installer/data/mysql/sysprefs.sql | 2 +-
installer/data/mysql/updatedatabase.pl | 10 ++++++++++
koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 6 +++++-
.../intranet-tmpl/prog/en/includes/authorities-toolbar.inc | 8 +++++---
.../intranet-tmpl/prog/en/modules/catalogue/detail.tt | 6 +++---
.../intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt | 2 ++
.../prog/en/modules/members/members-update.tt | 2 +-
.../intranet-tmpl/prog/en/modules/offline_circ/list.tt | 2 +-
.../prog/en/modules/offline_circ/process_koc.tt | 3 ++-
.../prog/en/modules/onboarding/onboardingstep3.tt | 2 +-
.../opac-tmpl/bootstrap/en/includes/opac-topissues.inc | 2 ++
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 6 +++---
offline_circ/list.pl | 10 ++++++----
t/00-load.t | 3 +++
t/Number/Price.t | 4 +++-
t/{ => db_dependent}/check_kohastructure.t | 0
tools/inventory.pl | 5 +----
29 files changed, 89 insertions(+), 33 deletions(-)
rename t/{ => db_dependent}/check_kohastructure.t (100%)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list