[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.01-107-g9c3eb14
Git repo owner
gitmaster at git.koha-community.org
Tue Jan 23 04:15:30 CET 2018
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 17.11.x has been updated
via 9c3eb146fa8ff22452f87afb12cb6de25ac00b5d (commit)
via 937237a1f29192c8be73fbcc3cd7e29c40468831 (commit)
via 431d315534c9f41d4418b528bf9b78970f235a46 (commit)
via 42ff4bfca63da3e4e8df39b4f6bce703f7cc9213 (commit)
via 14a3e2fddf031aca6b76d69122464412c461c5f9 (commit)
via db7e3a41b15829a11d9f4465c95e36c7fd3eb735 (commit)
via 84ab40c64680641cc0fe3bc0b277909b85ff278a (commit)
via 7b4b8699a69df4d4c6e0bedd421e385bfdc5dcee (commit)
via 5bf7600456aa66c1984ba7e8f2d781f468f23b6e (commit)
via 17a0a796bb3349f175ae82fa8a7ba05eb614391c (commit)
via 479945b208d15dd9ea4290e512a873c75a994e3c (commit)
via 18e5177e1a3a0fc6f0b16b827c2c28474ff54c03 (commit)
via 8be48eeb5180a529c079a32e4db3766bd0e4e142 (commit)
via 7086c399fd8a9329d440fa636fa8e383c265865b (commit)
via 6c7ea2aeb1f81c3d1e3418dd3587c02a7712dad1 (commit)
via 5c2a90e80c310200c7ddf26584586efff03e596f (commit)
via 0b3e70c961be7dcc5aa18f5dc7e0996852563e66 (commit)
via fe2560c06a6ae8c93291c99b5afd410b5f721f52 (commit)
via 6b93aca4066ea92bb0410103d094a37aa21f72cf (commit)
via 349359841a2ea379a183e181da37af38a55be7a9 (commit)
via cc8738afd113298ade1f0fa9135cd7e272f610b8 (commit)
via 3f38b34445ada2bfb7c7dc48f340fd408b1a5b67 (commit)
via a44804f015964ec95d997c9adfdaae4b3527fb50 (commit)
via ceeb92081a8dc67f8c685319eb461162b0ba7a19 (commit)
via 1107590df2a7fab465225c683a3ba62b7796584c (commit)
via f25d650a1ca4fd6bb927484586210b74e2c40eb6 (commit)
via ee819e6862cab4a504828de17a24f1f08d635df7 (commit)
via e7dd617de0e8eb1769c81cbfe85333ace701764d (commit)
via 065d3de88c55d8ce9efd05ecf80b073fffef242a (commit)
via 92972fa3de205d736185e8a39b1e59309794f875 (commit)
via c199ced310abdef53379115ee285757df20ac335 (commit)
via f6adfb4257d0326a101771246777b10965632bc8 (commit)
via 25b2cd2d72feda887d0d0f242972baa80f0d3463 (commit)
via d735b4957b6073c6d8bf085cc81382dc4dc50d06 (commit)
via 4538e6c4981b096f8ddcf4b235a7f9e2860ffe9b (commit)
via 57605308436cb0f60e2f45933126a61f17f88092 (commit)
from 5d3265f52751d70cb87b7919cb0258ffb7c2e768 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 9c3eb146fa8ff22452f87afb12cb6de25ac00b5d
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed Jan 17 14:26:38 2018 +0100
Bug 20063: (bug 18811 follow-up) Allow hidden $9 subfields
Although we could argue that the user should make all $9 subfields
visible, this might be a good compromise. It selectively reverts the
change from the first patch by accepting $9 subfields without checking
the hidden flag in the framework.
Test plan:
[1] Make a subfield $9 visible for some authority field.
[2] Put a value in it somewhere in authorities.pl
[3] Make subfield $9 invisible in the auth framework.
[4] Open and save the adjusted authority record.
[5] Check the marcxml of this record.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 937237a1f29192c8be73fbcc3cd7e29c40468831
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Dec 20 20:29:29 2017 -0300
Bug 15770: Do not format numbers if too big
At several places we got the following error if we use numbers too big
for Number::Format
Template process failed: undef error - round() overflow. Try smaller
precision or use Math::BigFloat at /home/koha/src/Koha/Number/Price.pm line 44
It make the app explodes.
The goal here is to handle these errors gracefully and easily.
Test plan:
- Add a manual fine to a patron of 100000000000000
- Create a patron category with an enrolment fee of 123456789012345
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 431d315534c9f41d4418b528bf9b78970f235a46
Author: Olivier Crouzet <kohateam at univ-lyon3.fr>
Date: Mon Jan 15 17:22:22 2018 +0100
Bug 19971: Typo in the comments of parseQuery routine
TEST PLAN
---------
1) Run these commands:
git checkout master
git pull
perldoc C4::Search
2) look for parseQuery
-- NOTE: The sample code provided below this heading has
the wrong function name!
3) Run these commands:
git checkout -b bug_19971 origin/master
perldoc C4::Search
4) look for parseQuery
-- NOTE: The wrong function name is corrected.
5) Run koha qa test tools
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 42ff4bfca63da3e4e8df39b4f6bce703f7cc9213
Author: Te Rauhina Jackson <terauhina.jackson at gmail.com>
Date: Tue Jan 16 21:21:21 2018 +0000
Bug 19221: Onboarding tool says user needs to be made superlibrarian
I changed the "To give new patron superlibrarian permissions go to:"
message to "To edit patron permissions, go to:". Please clarify if this
is clearer or not.
Test plan:
1) Apply patch
2) Go through the web installer
3) At the create koha administrator patron step, notice that at the
bottom, there is a message saying "To edit patron permissions, go
to:"
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 14a3e2fddf031aca6b76d69122464412c461c5f9
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Sun Dec 17 08:45:41 2017 +0000
Bug 19825: Make links to biblios on pending offline circulation page working again
0) Do not apply the patch
1) Have pending offline circulation operations - you can use standalone
application, Firefox add-on or built-in offline circulatin client - it
does not matter in this case
2) Go to Circulation -> pending offline circulation actions
3) You see all barcode in red and without links - even if the item and
biblio existed
4) Apply the patch
5) Repeat 1-3, now you should see the links to biblio on existing items
Note: Don't add non-existent barcodes actions and payment actions unti
bug 19771 is not fixed
Signed-off-by: Charlotte Cordwell <charlotte.cordwell123 at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit db7e3a41b15829a11d9f4465c95e36c7fd3eb735
Author: Grace Smyth <gracesmythh at gmail.com>
Date: Tue Jan 16 03:41:15 2018 +0000
Bug 19839: Removed Warning (invoice.pl - uncertainprices)
Test Plan
[1.] Check the patch to see that I have removed:
$template->param( uncertainprices => 1 ); from line 204 as Mr Druart has instructed to do
(to get to the patch see the comment above by Mr Druart)
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 84ab40c64680641cc0fe3bc0b277909b85ff278a
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Jan 23 02:24:28 2018 +0000
Bug 17682: DBRev 17.11.01.002
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 7b4b8699a69df4d4c6e0bedd421e385bfdc5dcee
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Jan 19 15:26:32 2018 -0300
Bug 17682: Replace 2 occurrences in de-DE and nb-NO
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 5bf7600456aa66c1984ba7e8f2d781f468f23b6e
Author: Charlotte Cordwell <charlotte.cordwell123 at gmail.com>
Date: Tue Jan 16 20:14:20 2018 +0000
Bug 17682: (follow-up) Change URL for Google Scholar in OPACSearchForTitleIn
Amended the sql statement so it only affects the http://www.scholar.google.com url
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 17a0a796bb3349f175ae82fa8a7ba05eb614391c
Author: Charlotte Cordwell <charlotte.cordwell123 at gmail.com>
Date: Tue Jan 16 03:55:49 2018 +0000
Bug 17682: Change URL for Google Scholar in OPACSearchForTitleIn
1)apply patch
2) go into administration --> search for OPACSearchForTitleIn
3) *click to edit*
4) look at the link and read the google scholar one.
5) check that the start link is https://scholar.google.com.
6) http://www.scholar.google is incorrect
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 479945b208d15dd9ea4290e512a873c75a994e3c
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Jan 19 14:11:51 2018 +0000
Bug 16603: (QA follow-up) Add a FIXME
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 18e5177e1a3a0fc6f0b16b827c2c28474ff54c03
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Dec 1 18:23:01 2017 +0000
Bug 16603: When processing uploaded offline circulation file, "apply directly" option fails
This patch is a temporary mitigation of whatever the real problem is.
The patch hides the "Apply directly" button so that the option isn't
available.
To test, apply the patch and generate a .koc file with some
transactions. Upload the file via Circulation -> Offline
circulation file upload. After the file is uploaded, you should see only
a "Add to offline circulation queue" button, which should work
correctly.
Signed-off-by: Grace Smyth <gracesmythh at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 8be48eeb5180a529c079a32e4db3766bd0e4e142
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Dec 18 14:42:25 2017 +0000
Bug 19677: Properly escape enumchrom/serialseq data
Some serial issues use angle brackets for denoting certain data.
Currently this is not displayed in Koha. This patch escapes the data so
that angle brackets will display.
To test:
1 - Add an enumchron field to an item containg angle brackets:
"This is a <test>"
2 - View the record in the staff and opac, not the field displays as:
"This is a"
3 - Apply patch
4 - Note full text now displays
Signed-off-by: Charlotte Cordwell <charlotte.cordwell123 at gmail.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 7086c399fd8a9329d440fa636fa8e383c265865b
Author: Mirko Tietgen <mirko at abunchofthings.net>
Date: Fri Jan 19 14:06:48 2018 +0100
Bug 18696: Change debian/source/format to quilt
debian/source/format uses 'native'. As Koha is not native Debian software,
and to allow Debian revision numbers like -2 in 16.05.13-2, it should be
changed to 'quilt'.
This is only relevant to packaging and does not affect Koha itself.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 6c7ea2aeb1f81c3d1e3418dd3587c02a7712dad1
Author: Mirko Tietgen <mirko at abunchofthings.net>
Date: Fri Jan 19 13:55:30 2018 +0100
Bug 19783: Move check_kohastructure.t to db_dependent
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 5c2a90e80c310200c7ddf26584586efff03e596f
Author: Mirko Tietgen <mirko at abunchofthings.net>
Date: Fri Jan 19 13:59:43 2018 +0100
Bug 20042: 00-load.t fails when Elasticsearch is not installed
00-load.t fails when Elasticsearch is not installed. Blocks packaging.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 0b3e70c961be7dcc5aa18f5dc7e0996852563e66
Author: Grace Smyth <gracesmythh at gmail.com>
Date: Thu Jan 18 20:30:00 2018 +0000
Bug 19987: If no z39.50/SRU servers the button should not show
Test plan:
[1.] Load the patch and make sure you have some Z39.50/SRU servers
(Administration => Z39.50/SRU servers administration)
[2.] Then go to authorities and notice that the 'New from
Z39.50/SRU' button is there
[3.] Next go to cataloging and notice that the 'New from Z39.50/SRU'
button is there too
[4.] Now make sure you have no Z39.50/SRU servers (remove the
servers)
(Administration => Z39.50/SRU servers administration)
[5.] Go to authorities and notice that the 'New from Z39.50/SRU'
button is not there
[6.] Lastly go to cataloging and notice that the 'New from Z39.50/SRU'
button is not there too
:)
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
I added a missing [% END %] during signoff. Hope no one minds!
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit fe2560c06a6ae8c93291c99b5afd410b5f721f52
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Tue Jan 16 10:20:21 2018 +0100
Bug 19977: Open only .pref files in Local Use tab (sysprefs)
Test plan:
1. Open .../prog/en/modules/admin/preferences/circulation.pref
with vim (check that it creates a .circulation.pref.swp in the same
directory)
2. Go to the "Local Use" tab in admin/systempreferences.pl
3. Confirm that the page works normally
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 6b93aca4066ea92bb0410103d094a37aa21f72cf
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Sun Dec 17 08:53:18 2017 +0000
Bug 19771: Fix crashing in pending offline circulation actions list
When the barcode is empty or invalid, an "Internal Server Error"
is triggered on the kohadev box.
TEST PLAN
---------
0) back up your database if you care about it.
1) Run the following commands:
git checkout master
git pull
git checkout -b bug_19771 origin/master
git bz apply 19771
-- This should be quite uneventful. Standard promptings.
2) Continue to run the following commands:
git checkout master
reset_all
sudo koha-shell -c bash kohadev
./misc/cronjobs/create_te_koc_db.pl --sqlite3
-- This will create a borrowers.db in your current directory.
3) On the host where you intend on running the koct install it.
-- https://sourceforge.net/projects/koha-oc/files/
download and install.
4) get the borrowers.db file to your host where you installed koct
5) point koct at the file you downloaded
Database -> Select Borrowers DB File
6) Create a .koc file with the following transactions.
check in, check out, check in (bad barcode),
pay fines (any non-zero amount).
7) Run the following commands:
restart_all
-- we want to make sure caching for plack isn't in the way.
8) In the staff client: Home -> Circulation
-> Upload offline circulation file (.koc)
9) Choose the file created and click 'Upload file'.
10) Add to offline circulation queue.
11) View pending offline circulation actions
-- This should die. Reading /var/log/koha/kohadev/plack-error.log
should be the same error as comment #0.
However, this was only the bad biblio error.
12) Run the following commands:
git checkout bug_19771
restart_all
13) Refresh staff client page.
-- it should all come up.
14) Select the bad biblio line, and delete it.
15) Run the following commands:
git checkout master
restart_all
16) Refresh the staff client page.
-- it should die. Same error as comment #0.
This confirms the fine payment issue.
17) Run the following commands
git checkout bug_19771
restart_all
18) Refresh the staff client page.
-- it should all come up.
19) run the koha qa test tools
20) if you backed up your database, restore it. :)
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 349359841a2ea379a183e181da37af38a55be7a9
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Jan 18 12:49:12 2018 -0300
Bug 20001: Fix confusion between array and arrayref
Illrequest->available_backends always returned only 1 element
TEST PLAN
---------
See bug 7317 comment #20 for configuring ILL
Make sure to restart_all
Strangely, ILLIBS didn't exist, but IL did in default install,
so use that as the patron code in your koha-conf.xml
Make sure to turn on the ILL related system preference.
1) Configure ILL.
-- this is the hard part. Hopefully the above will give you
enough.
2) open OPAC and log in
3) Click the 'your interlibrary loan request' in the left pane
4) Click the 'Create a new request' button.
-- when you hover your mouse over the links for the backends,
they will have ARRAY(...) instead of a meaningful name.
This is what triggers the error (see comment #7).
5) Run the following commands
git checkout -b bug_20001 origin/master
git bz apply 20001
restart_all
6) Refresh the OPAC page, and repeat step 4.
-- when hovering your mouse over the links for the backends,
they will have meaningful values now.
7) run koha qa test tools.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit cc8738afd113298ade1f0fa9135cd7e272f610b8
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu Oct 20 10:00:19 2016 -0300
Bug 17467: Add missing --status switch handling
RM note: I forgot this patch (no idea what happened!)
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 3f38b34445ada2bfb7c7dc48f340fd408b1a5b67
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Jan 15 10:10:41 2018 -0300
Bug 19968: Add missing use Date::Calc statement
It has been reported than the missing use statement can cause a
compilation error:
Undefined subroutine &Date::Calc::Today called at
/usr/share/koha/intranet/cgi-bin/cataloguing/value_builder/unimarc_field_100.pl
line 75.
Test plan:
Use this UNIMARC plugin and make sure it fixes the error or at least
does not break it
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a44804f015964ec95d997c9adfdaae4b3527fb50
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Jan 15 13:46:06 2018 -0300
Bug 19973: Fix SQL syntax error in uk-UA/mandatory/sample_notices.sql
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit ceeb92081a8dc67f8c685319eb461162b0ba7a19
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Jan 15 13:41:41 2018 -0300
Bug 18915: Add CHECKOUT_NOTE notice template for other languages
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 1107590df2a7fab465225c683a3ba62b7796584c
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Tue Jan 9 14:37:08 2018 +0000
Bug 19937: Silence warnings t/db_dependent/www/batch.t
TEST PLAN
---------
1) Run the following on a kohadevbox:
git checkout -b bug_19937 origin/master
sudo koha-shell -c bash kohadev
prove t/db_dependent/www/batch.t
cat /var/log/koha/kohadev/plack-error.log
The following errors are triggered at the end of the log file:
Use of uninitialized value in array element at
/home/vagrant/kohaclone/tools/batch_records_ajax.pl line 50.
Use of uninitialized value $results_per_page in numeric eq (==) at
/home/vagrant/kohaclone/tools/batch_records_ajax.pl line 53.
Use of uninitialized value in uc at
/home/vagrant/kohaclone/C4/ImportBatch.pm line 1120.
2) Run the following on a kohadevbox:
exit
git bz apply 19937
restart_all
sudo koha-shell -c bash kohadev
prove t/db_dependent/www/batch.t
cat /var/log/koha/kohadev/plack-error.log
The log file will end with the restarting of plack, not the
errors.
3) run koha qa test tools
Signed-off-by: Lee Jamison <ldjamison at marywood.edu>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Amended handling of $results_per_page.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit f25d650a1ca4fd6bb927484586210b74e2c40eb6
Author: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Date: Wed Oct 18 14:33:22 2017 +0300
Bug 19483: Fix test plan in t/db_dependent/www/*
t/db_dependent/www/* crashes test harness due to misconfigured test plan
prove t/db_dependent/www/
without defining KOHA_INTRANET_URL
bails out and marks the whole test suite as failed.
Test suite should not be failed if this optional WWW::Mechanize test
suite is not activated.
After this patch, the tests are properly skipped without failing the
whole tests.
This is important when running all tests under t, as this needlessly
fails the test suite.
Also handling of 'skip_all' is inconsistent in t/db_dependent/www
-tests, so this normalizes it to skip_all instead of bail_out
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit ee819e6862cab4a504828de17a24f1f08d635df7
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Jan 23 01:36:22 2018 +0000
Bug 18915: DBRev 17.11.01.001
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit e7dd617de0e8eb1769c81cbfe85333ace701764d
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Jan 12 11:31:42 2018 +0100
Bug 18915: (QA follow-up) Add note for installs after 17.05
Since the 17.05 upgrade adds the note and the sql file did not yet include
the note, we should add it when it is not there (for example new 17.11s).
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested by running the dbrev while there is a letter and while not.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 065d3de88c55d8ce9efd05ecf80b073fffef242a
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Sun Dec 17 23:42:36 2017 +0000
Bug 18915: Renaming svc/patron_notes to svc/checkout_notes
For consistency.
Signed-off-by: Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca>
https://bugs.koha-community.org/show_bug.cgi?id=19801
Signed-off-by: Marjorie Vila <marjorie.barry-vila at collecto.ca>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 92972fa3de205d736185e8a39b1e59309794f875
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Sun Dec 17 23:33:18 2017 +0000
Bug 18915: Giving CHECKOUT_NOTE access to issues table
This patch allows the notice to reference the issues table so that the
checkout note itself can be added to the note if wanted, such as in
Comment 9.
Sponsored-by: Catalyst IT
Signed-off-by: Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca>
https://bugs.koha-community.org/show_bug.cgi?id=19801
Signed-off-by: Marjorie Vila <marjorie.barry-vila at collecto.ca>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit c199ced310abdef53379115ee285757df20ac335
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Sun Aug 27 23:20:40 2017 +0000
Bug 18915: Fix checkout note email message
This patch replaces the <<biblio.item>> in the email with
<<biblio.title>> and uses CHECKOUT_NOTE instead of PATRON_NOTE.
This patch also adds the notice to
installer/data/mysql/en/mandatory/sample_notices.sql, and updates the
PATRON_NOTE entry in installer/data/mysql/updatedatabase.pl
To test:
1) Apply patch and update database
2) View the message_queue table in mysql
3) Check out an item if haven't already
4) Go to OPAC and set a checkout note for an item
5) View message_queue table and confirm it the title is included in the
email and all instances of 'patron note' have been replaced with
'checkout note'
6) Disable javascript in browser
7) repeat steps 4 and 5 and confirm all works as expected
Sponsored-by: Catalyst IT
Signed-off-by: Marjorie Vila <marjorie.barry-vila at collecto.ca>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit f6adfb4257d0326a101771246777b10965632bc8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jan 3 16:15:18 2018 -0300
Bug 19911: Escape password value during self-registration confirmation
The password must be correctly escape, it can contains html character
and break the display.
Test plan:
Apply first patch and confirm that the display is broken
Apply second patch (this one) and confirm that the display is fixed
Signed-off-by: Arturo <alongoria at sll.texas.gov>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 25b2cd2d72feda887d0d0f242972baa80f0d3463
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Jan 4 11:00:35 2018 -0300
Bug 19911: Do not escape html characters when saving passwords
When the password is not generated automatically, we should not escape
the html characters. Otherwise it will be changed without any warnings.
Signed-off-by: Arturo <alongoria at sll.texas.gov>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit d735b4957b6073c6d8bf085cc81382dc4dc50d06
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Jan 5 16:36:31 2018 -0300
Bug 19921: Fix update child when only one adult patron category exist
We are passing the Koha::Patron::Category object to the template instead
of the categorycode.
To reproduce this bug you must test in a system which has only one
patron category of the "adult" type. View the details of a patron with a
child-type patron category and choose More -> Update child to adult
patron.
This results in an error:
Can't call method "category_type" on an undefined value at
/home/vagrant/kohaclone/members/update-child.pl line 84.
The URL of the error page shows a problem with the parameters being
passed:
members/update-child.pl?op=update&borrowernumber=12345&catcode=Koha::Patron::Category=HASH(0xa168a18)&catcode_multi=
Test plan:
Make sure you have only 1 adult patron category
Update a child to adult
=> With this patch applied the error is gone and the patron has been
correctly updated
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 4538e6c4981b096f8ddcf4b235a7f9e2860ffe9b
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Sat Nov 4 01:01:42 2017 +0000
Bug 19580: Exclude period as splitting character for autotrunction
To test:
0 - Apply Unit test patch only
1 - prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
2 - Should fail
3 - Apply this patch
4 - prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
5 - should pass
6 - search for 'Local-number.raw:"4"' (or a vlid biblionumber)
7 - should get expected result
Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 57605308436cb0f60e2f45933126a61f17f88092
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Sat Nov 4 01:01:20 2017 +0000
Bug 19580: Unit tests
Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/ImportBatch.pm | 2 +-
C4/Search.pm | 2 +-
Koha.pm | 2 +-
Koha/Illrequest.pm | 4 +--
Koha/Number/Price.pm | 5 ++++
Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 4 +--
acqui/invoice.pl | 1 -
admin/systempreferences.pl | 2 +-
authorities/authorities-home.pl | 12 ++++++++
authorities/authorities.pl | 8 ++---
cataloguing/addbooks.pl | 12 ++++++++
cataloguing/value_builder/unimarc_field_100.pl | 1 +
circ/circulation.pl | 2 +-
debian/scripts/koha-zebra | 3 ++
debian/source/format | 2 +-
.../data/mysql/de-DE/mandatory/sample_notices.sql | 3 +-
.../mysql/de-DE/mandatory/system_preferences.sql | 2 +-
.../data/mysql/en/mandatory/sample_notices.sql | 3 +-
.../data/mysql/es-ES/mandatory/sample_notices.sql | 3 +-
.../mysql/fr-CA/obligatoire/sample_notices.sql | 3 +-
.../mysql/fr-FR/1-Obligatoire/sample_notices.sql | 3 +-
installer/data/mysql/it-IT/necessari/notices.sql | 3 +-
.../mysql/nb-NO/1-Obligatorisk/sample_notices.sql | 3 +-
.../nb-NO/1-Obligatorisk/system_preferences.sql | 2 +-
.../data/mysql/pl-PL/mandatory/sample_notices.sql | 3 +-
.../data/mysql/ru-RU/mandatory/sample_notices.sql | 3 +-
installer/data/mysql/sysprefs.sql | 2 +-
.../data/mysql/uk-UA/mandatory/sample_notices.sql | 6 ++--
installer/data/mysql/updatedatabase.pl | 31 +++++++++++++++++++-
.../prog/en/includes/authorities-toolbar.inc | 8 +++--
.../prog/en/modules/catalogue/detail.tt | 6 ++--
.../prog/en/modules/cataloguing/addbooks.tt | 2 ++
.../prog/en/modules/offline_circ/list.tt | 2 +-
.../prog/en/modules/offline_circ/process_koc.tt | 3 +-
.../prog/en/modules/onboarding/onboardingstep3.tt | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 6 ++--
.../en/modules/opac-registration-confirmation.tt | 4 +--
.../opac-tmpl/bootstrap/en/modules/opac-user.tt | 2 +-
members/boraccount.pl | 2 +-
members/holdshistory.pl | 2 +-
members/mancredit.pl | 2 +-
members/maninvoice.pl | 2 +-
members/member-flags.pl | 2 +-
members/member-password.pl | 2 +-
members/moremember.pl | 2 +-
members/pay.pl | 2 +-
members/paycollect.pl | 2 +-
members/printfeercpt.pl | 2 +-
members/printinvoice.pl | 2 +-
members/readingrec.pl | 2 +-
offline_circ/list.pl | 10 ++++---
opac/opac-issue-note.pl | 2 +-
opac/opac-memberentry.pl | 13 +++++---
opac/svc/{patron_notes => checkout_notes} | 5 ++--
t/00-load.t | 3 ++
t/Number/Price.t | 4 ++-
.../Koha_SearchEngine_Elasticsearch_Search.t | 23 ++++++++++++++-
t/{ => db_dependent}/check_kohastructure.t | 0
t/db_dependent/www/auth_values_input_www.t | 16 +++++-----
t/db_dependent/www/batch.t | 12 ++++++--
t/db_dependent/www/history.t | 17 ++++++-----
t/db_dependent/www/search_utf8.t | 7 +++--
tools/batch_records_ajax.pl | 4 +--
63 files changed, 216 insertions(+), 91 deletions(-)
rename opac/svc/{patron_notes => checkout_notes} (95%)
rename t/{ => db_dependent}/check_kohastructure.t (100%)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list