[koha-commits] main Koha release repository branch master updated. v17.11.00-331-g80de9fa

Tue Jan 23 20:15:38 CET 2018

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  80de9fa97cfc737e7da42418c059dbf6b1bcf1f7 (commit)
       via  c2bf4289ad16507f673bed36d222353adef6189f (commit)
       via  85b0424eb704d416950510c30b41a10ce56cbc3b (commit)
       via  c87adaf4f3802cb3d701529efc10fa65a70caac3 (commit)
       via  e7236df74223b3976f4da88f51d8321d7a4802f7 (commit)
      from  19e97bed4ecec730058c2f4f95efb49f07c0f44e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 80de9fa97cfc737e7da42418c059dbf6b1bcf1f7
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Jul 21 16:28:31 2017 -0300

    Bug 18964: Add --debugger option to koha-plack

    CAVEAT: This patch is only about allowing koha-plack to start a debugging
    session on a remote target. Configuring all the needed pieces to make it
    work is out of the scope of the bug. Testing should be focused (mainly) on
    making sure this introduces NO REGRESSIONS on regular use (i.e. not debugging).

    This patch adds the following option switches to koha-plack:

    --debugger
    ----------
    Toggle debugging

    --debugger-key
    --------------
    Some IDEs require a key, this needs to match because they are picky about it

    --debugger-location
    -------------------
    This option switch is used to specify the host:port your IDE is listening at.
    Inside kohadevbox (using Vdebug with Vim) this would be localhost:9000. Outside
    kohadevbox it would be 192.168.50.1:9000

    --debugger-path
    ---------------
    This is the path in which you installed the Komodo Remote Debugger library [1]. In kohadevbox
    you could put the contents of the downloaded .tar.gz in /home/vagrant/dbgp/perllib. That
    perllib seems to be required for things to work [2].

    You can test with a simple CLI script things work:

    PERL5LIB=/home/vagrant/dbgp/perllib:$PERL5LIB \
    PERLDB="BEGIN { require q(/home/vagrant/dbgp/perllib/perl5db.pl) }" \
    PERLDB_OPTS="RemotePort=192.168.50.1:9000" perl -d t/Prices.t

    If you see action on your IDE, you are on the right track on the IDE side.

    To test:
    - Apply this patch
    - Enable remote debugging on your IDE, on port 9000 (or adjust the command
      below to match your IDE's listening port).
    - Download the Komodo Remote Debugger package, and place the package's contents
      in /home/vagrant/dbgp/perllib (you should see perl5db.pl in there).
    - Run:
      $ sudo koha-plack --stop kohadev
      $ sudo kohaclone/debian/koha-plack --start \
                                         --debugger \
                                         --debugger-path /home/vagrant/dbgp/perllib \
                                         --debugger-location 192.168.50.1:9000 \
                                         kohadev
    => SUCCESS: You IDE/tool gets a connection from the Plack process.
    - Sign off :-D

    The explanation on how to use it assumes you are running kohadevbox.

    WARNING: The main difficulty I found was setting the right dir/file mappings.

    [1] http://code.activestate.com/komodo/remotedebugging/
    [2] https://github.com/Komodo/KomodoEdit/issues/644#issuecomment-236268012

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit c2bf4289ad16507f673bed36d222353adef6189f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jan 22 17:18:59 2018 -0300

    Bug 19985: Make TestBuilder.t pass even if default_circ_rules is not empty

    This table cannot contain more than 1 row, so we need to remove its data
    before trying to generate a new entry.

    Test plan:
    Set a default circ rule
     prove t/db_dependent/TestBuilder.t
    should return green

    Without this patch you get:
        #   Failed test 'TestBuilder should be able to create an object for every source'
        #   at t/db_dependent/TestBuilder.t line 78.
        #          got: '1'
        #     expected: '0'
        # The following sources have not been generated correctly: DefaultCircRule
        # Looks like you failed 1 test of 1.

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 85b0424eb704d416950510c30b41a10ce56cbc3b
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Mon May 8 16:47:06 2017 +0000

    Bug 18477: Populate article_requests table values for AR_PENDING notices

    The default AR_PENDING letter does not print populate <<article_requests.*>> fields.

    Test Plan:
    1) Enable article requests ( syspref: ArticleRequests => Enable, Circ and fine rules ALL/ALL (or a given category/itemtype): Article requests => Yes )
    2) Search for a title, click in to catalog detail, click 'Request Article' button.
    3) Select Patron
    4) Fill out request information
    5) Click 'Place request'
    6) Go to notices in patron record, inspect 'Article Request Received' notice. You should see the request information from step 4, but it doesn't display.
    7) Apply this patch
    8) Repeat steps 2-6, not the fields now display!

    Signed-off-by: Eric Phetteplace <phette23 at gmail.com>

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit c87adaf4f3802cb3d701529efc10fa65a70caac3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Jan 2 14:36:43 2018 -0300

    Bug 18477: Add tests

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit e7236df74223b3976f4da88f51d8321d7a4802f7
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date:   Mon Jan 22 23:52:21 2018 +0000

    Bug 20068: Check if user logged in before passing dashboard params to template

    This prevents warns from dashboard variables when not logged in

    To test:
    1) Go to OPAC main homepage. Do not log in
    2) Notice warn
    3) Apply patch and refresh
    4) Warn should be gone
    5) Log in
    6) Confirm dashboard shows as normal

    Sponsored-by: Catalyst IT

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-----------------------------------------------------------------------

Summary of changes:
 Koha/ArticleRequest.pm           |    1 +
 debian/scripts/koha-plack        |   63 +++++++++++++++++++++++++++++++++-----
 opac/opac-main.pl                |   31 +++++++++++--------
 t/db_dependent/ArticleRequests.t |   25 +++++++++++++--
 t/db_dependent/TestBuilder.t     |    1 +
 5 files changed, 99 insertions(+), 22 deletions(-)

hooks/post-receive
-- 
main Koha release repository