[koha-commits] main Koha release repository branch master updated. v17.11.00-352-gbd2d2fd
Git repo owner
gitmaster at git.koha-community.org
Tue Jan 30 18:29:29 CET 2018
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via bd2d2fd433baeca3d311c403b482c6a2000a6668 (commit)
via c76281f3fcb4f634a1e1a8f74b9663763c874dfd (commit)
via 83177006302494bc3a5bc67a7d89d373d5a9002c (commit)
via e04c780e9a51c06d606b1bf7cda89e465f1d7431 (commit)
via 20e89d051c9ca3def36e9cde742ea10fd59204aa (commit)
via e1ba582af9c93a96870365be2fd1609621567a2e (commit)
via 32a2b5a996a91bfa1f4a22c1c7ceefc9e2bd8b31 (commit)
via 13cb7e0490e7a41e2c47ba89e27bfdc446af572c (commit)
via 84fc8c65186053ea69e46b5c8aac736050e0ac54 (commit)
via 5d6e58f7cadd9c42ef5669b29674bd4b38fabc4f (commit)
via 65e541085c86ab2f6873a0c98d631b7719bcc62d (commit)
via 19a07cc16f2ffb1c019bf98707fcbe31e57168a5 (commit)
via f05da6ada78f2366a96cce4af25f20bab3b271c1 (commit)
via 24b72f8bfa122ed9bbbf697d15fb6de68c66f4a0 (commit)
via 10c3dc1a25f08994b832bd37998ff10c30ac2f88 (commit)
via c1cb8a14bcd5bcc1ca6fd9efb0b9912b773790a7 (commit)
via ccea385ce7bf65a2650d7993f3e9d0cd34d51c49 (commit)
via 74dec87b0f9d9868d910cf9e2b400598b2217aa8 (commit)
via f3abb73b5cc8c541f7b6c8acc4c03be337c77099 (commit)
from 7cb86656956131ed81cc74069a765a37664edd8e (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit bd2d2fd433baeca3d311c403b482c6a2000a6668
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Fri Jan 26 09:25:21 2018 +0000
Bug 16213: (QA follow-up) Fix terminology
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c76281f3fcb4f634a1e1a8f74b9663763c874dfd
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Wed Apr 6 13:12:51 2016 +0200
Bug 16213: Allow to select hold's itemtype when using API
Test plan:
1/ Use your usual "REST testing" tool to place a title-level hold with
an itemtype. The request should look like this:
POST /api/v1/holds
{
"borrowernumber": 1234,
"biblionumber": 456,
"branchcode": "CPL",
"itemtype": "A"
}
2/ Check that the hold was placed and the itemtype is correctly selected
3/ prove t/db_dependent/api/v1/holds.t
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 83177006302494bc3a5bc67a7d89d373d5a9002c
Author: Mirko Tietgen <mirko at abunchofthings.net>
Date: Tue Jan 23 12:11:32 2018 +0100
Bug 17084: Automatic debian/control updates
Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e04c780e9a51c06d606b1bf7cda89e465f1d7431
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu Jan 25 12:01:30 2018 +0100
Bug 20088: Fix uninitialized warning from svc/holds
Use of uninitialized value in array element at svc/holds line 56.
Test plan:
Check if the warn is no longer in the logs; the warning is triggered by
an ajax call from the circulation template in staff.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 20e89d051c9ca3def36e9cde742ea10fd59204aa
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Mon Jan 22 09:49:36 2018 +0100
Bug 20056: Resolve uninitialized warn in cmp_sysprefs.pl
When running a compare with --upd flag, I got the following warn:
Use of uninitialized value in addition (+) at misc/maintenance/cmp_sysprefs.pl line 125.
This is simply resolved by not returning undef but 0 in case of the Version
syspref in the sub UpdateOnePref.
Test plan:
Look at this simple change.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e1ba582af9c93a96870365be2fd1609621567a2e
Author: Zoe Bennett <zoebennett1308 at gmail.com>
Date: Wed Jan 17 23:16:38 2018 +0000
Bug 19827: Removing &checkuniquemember from the export in C4/Members.pm
Test Plan:
- Check that the line &checkuniquemember has been removed from the
export in C4/Members.pm
Signed-off-by: Roch D'Amour <roch.damour at inlibro.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 32a2b5a996a91bfa1f4a22c1c7ceefc9e2bd8b31
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Jan 26 12:43:58 2018 +0000
Bug 20091: Moved FailedLoginAttempts out of Norwegian Patron Database heading
To test:
1 - View systempreferences patron tab
2 - Note FailedLoginAttempts is uner 'Norwegian Patron Database'
3 - apply patch
4 - Now it is under 'General'
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Maksim Sen <maksim at inlibro.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 13cb7e0490e7a41e2c47ba89e27bfdc446af572c
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Sun Jan 28 01:41:01 2018 -0500
Bug 13990: (follow-up) silence warnings on testing
prove t/db_dependent/ILSDI_Services.t
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 84fc8c65186053ea69e46b5c8aac736050e0ac54
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Sun Jan 28 01:18:54 2018 -0500
Bug 13990: (QA follow-up) Add unit test coverage
prove t/db_dependent/ILSDI_Services.t
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5d6e58f7cadd9c42ef5669b29674bd4b38fabc4f
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Fri Jan 26 16:20:20 2018 +0000
Bug 13990: (follow-up) fix various whitespace errors
- tabs to 4 spaces
- trailing whitespace
- missing vertical whitespace before =head3
Without this patch, this bug fails qa test tools.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 65e541085c86ab2f6873a0c98d631b7719bcc62d
Author: Jon Knight <J.P.Knight at lboro.ac.uk>
Date: Tue Nov 7 17:27:56 2017 +0000
Bug 13990: ILS-DI LookupPatron requires ID Type
Patch provides a constrained set of borrower attributes to try in turn if the
ID type is not specified. Also added "email" to the POD documented list of
id types seeing as its quite a useful one for integration developers.
Test plan:
1) without the patch applied, turn on ils-di interface in your admin sysprefs
and then try accessing the URL:
https://your-server/cgi-bin/koha/ilsdi.pl?service=LookupPatron&id=Mabel
replacing "your-server" your Koha dev test domain name (localhost:8080 if
you're using a kohadevbox VM) and "Mabel" with the first name of a patron
(Mabel is in the test database already if you're using that).
You should get back an error message in the XML.
2) Apply the patch and repeat. This time you should get an <id> element in
the XML with Mabel's patron ID in it.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 19a07cc16f2ffb1c019bf98707fcbe31e57168a5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jan 30 14:06:27 2018 -0300
Bug 19230: (follow-up) Preventing warn when deleting course
Simplify 'unless' statement
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f05da6ada78f2366a96cce4af25f20bab3b271c1
Author: Aleisha Amohia <aleishaamohia at hotmail.com>
Date: Thu Dec 21 00:57:21 2017 +0000
Bug 19230: Preventing warn when deleting course
To test:
1) Ensure UseCourseReserves is enabled
2) Go to Course Reserves, create a course
3) When you are taken to the course page, you should notice the
'Argument "" isn't numeric in numeric gt' warn
4) Delete course
5) Notice warn, and that no confirm message popped up
6) Apply patch
7) Create a course again. Confirm the 'Argument "" isn't numeric in
numeric gt' warn did not show
8) Delete the course
9) Notice no warn and the confirm message pops up
Sponsored-by: Catalyst IT
Signed-off-by: Roch D'Amour <roch.damour at inlibro.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 24b72f8bfa122ed9bbbf697d15fb6de68c66f4a0
Author: Liz Rea <liz at catalyst.net.nz>
Date: Fri Jan 26 15:01:39 2018 +1300
Bug 20041: ILL module missing from more menu in staff when activated
Apply this patch
Check that ILL requests are now listed in More menu when ILL requests syspref is enabled
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 10c3dc1a25f08994b832bd37998ff10c30ac2f88
Author: Grace Smyth <gracesmythh at gmail.com>
Date: Wed Jan 17 20:36:59 2018 +0000
Bug 19986: 'Server name' doesn't appear as required
Test plan:
[1.] Go to Admin -> z39.50/SRU servers
[2.] Make a new z39.50 server
[3.] Fill in the required field (hostname, port, database)
[4.] Save the server
[5.] Notice that the form does not submit, tells you that Sever name is
required
[6.] Repeat steps 2 - 5 but this time make a new SRU server
[6.] Upload the patch and repeat steps 1 - 3 (make a new z39.50 server
and a new SRRU server)
[7.] See that now 'Server name:' is red and on the right side of the box
there is a required note
[8.] Save both servers and it should have created a new z39.50 server
and a new SRU server
Signed-off-by: Roch D'Amour <roch.damour at inlibro.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c1cb8a14bcd5bcc1ca6fd9efb0b9912b773790a7
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Jan 26 21:05:39 2018 +0000
Bug 20003: (QA follow-up) use patron checkouts method instead of Koha::Checkouts
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ccea385ce7bf65a2650d7993f3e9d0cd34d51c49
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Thu Jan 18 07:56:15 2018 +0000
Bug 20003: Fix showing number of remaining checkouts during checking in
Test plan:
0) Do not apply the patch
1) Have a patron with more then one checkout
2) Return one of patron's checkout and confirm the remaining number of
checkout is not shown
3) Apply the patch
4) Try it again and confirm the number is now shown
Signed-off-by: Roch D'Amour <roch.damour at inlibro.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 74dec87b0f9d9868d910cf9e2b400598b2217aa8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Jan 22 17:04:28 2018 -0300
Bug 19975: Fix search by tags at the OPAC
This bug has certainly be caused by
commit 091d6c513bcbee224ff06477e79be48cea7fe825
Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes
The reason is quite simple, in Koha::ItemType->translated_description
(called in opac-search.pl l.229) there is an eval to know if we have
access to the translated description of the item type, to avoid
retrieving it again.
The evaluation of $@ later in opac-search.pl is supposed to test the 2
eval made few lines before (a "normal" search, without tags), but
$@ contains the error message from the *last* eval command.
So we are raising an error that have been correctly handled in
Koha::ItemType.
Test plan:
At the OPAC, click Tag cloud, then click any of the tags
=> Without the patch you get
Koha::ItemType::get_column generated this error: DBIx::Class::Row::get_column(): No such column 'translated_description' on Koha::Schema::Result::Itemtype at /usr/share/koha/lib/Koha/Object.pm line 307
=> With the patch applied the page is correctly displayed
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f3abb73b5cc8c541f7b6c8acc4c03be337c77099
Author: Mirko Tietgen <mirko at abunchofthings.net>
Date: Tue Jan 23 11:43:10 2018 +0100
Bug 20072: Fix build-git-snapshot for Debian source format quilt
With bug 18696 we need a few tiny changes to build-git-snapshot:
- Debian revision number for debian/changelog
- "orig" in the file name for the tar.gz archive
Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
C4/ILSDI/Services.pm | 143 +++++++++++---------
C4/Members.pm | 1 -
Koha/REST/V1/Hold.pm | 4 +-
api/v1/swagger/paths/holds.json | 4 +
circ/returns.pl | 3 +-
course_reserves/mod_course.pl | 12 +-
debian/build-git-snapshot | 4 +-
debian/control | 30 ++--
.../intranet-tmpl/prog/en/includes/header.inc | 3 +
.../prog/en/modules/admin/preferences/patrons.pref | 10 +-
.../prog/en/modules/admin/z3950servers.tt | 4 +-
.../en/modules/course_reserves/course-details.tt | 2 +-
koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt | 5 +-
misc/maintenance/cmp_sysprefs.pl | 2 +-
opac/ilsdi.pl | 2 +-
opac/opac-search.pl | 2 +-
svc/holds | 4 +-
t/db_dependent/ILSDI_Services.t | 57 +++++++-
t/db_dependent/api/v1/holds.t | 46 ++++++-
19 files changed, 231 insertions(+), 107 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list