[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.07-25-gbdb60e7
Git repo owner
gitmaster at git.koha-community.org
Wed Jul 4 10:24:50 CEST 2018
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 17.11.x has been updated
via bdb60e7d19c8a7d5d80e064429a02779cb620a19 (commit)
via a876da7c054a7c31adfd05ec090c0de2f341ff27 (commit)
via 0040d05a370bb8507cf2872dc808d3fdb262038b (commit)
via a83004bb92014173573b2dbc393e451f1a4d339c (commit)
via 4f98d34c0fe8bb483869678e955881276e5ce257 (commit)
via bc8d1205a6e08a036bfb5ad99f191cdbf6f58690 (commit)
via ad6b2e8dc16fd4e4295ff53a5d3b61b72e71d59d (commit)
via 3e0ccc346ca6f6b758b88cd0d4f09c2e6bdb44e4 (commit)
via 65d196036df2f195569c7123df358995db1ca45e (commit)
via a9035a52d082924a8380639dcf423437b064a4f0 (commit)
via 16add1adb392389c87b30446cc13183d43aae167 (commit)
from 3a6a8707c593d063d488e96470fad5492dfd4e84 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit bdb60e7d19c8a7d5d80e064429a02779cb620a19
Author: Caitlin Goodger <caitlingoodger.student at wegc.school.nz>
Date: Tue May 29 17:32:12 2018 +0000
Bug 17886: Don't show option to add to existing list if there are no lists
This patch modifies the page for adding a title to a list so that the
"Add to existing list" option doesn't appear if there are no lists
defined.
TEST PLAN
---------
1) Make sure no lists exist at all.
2) Make there is at least one findable biblio record entered
3) Find that biblio record in the OPAC
4) Click 'Save to your lists'
-- Notice that the whole save to list section is there.
5) Apply this patch
6) Click 'Cancel'
7) Click 'Save to your lists'
-- Notice you can only add now, which makes sense.
8) Run koha qa test tools.
Perform the same tests in the staff client.
Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
Followed the test plan and the patch works.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit b6010314dfed0f35c87de1a6c8209cd3e8f8b3c8)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit a876da7c054a7c31adfd05ec090c0de2f341ff27
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Jun 14 14:20:44 2018 +0000
Bug 20945: Escape SQL parameters when constructing download links
TO test:
1 - Create a report that takes a parameter
2 - Enter a parameter containing '%'
3 - Attempt to download report, note link is misconstructed
4 - Apply patch
5 - Reload
6 - Note URL is now correct
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 0557c0fd9c468fb32011897318fb239dcdc30bc8)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 0040d05a370bb8507cf2872dc808d3fdb262038b
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu May 3 12:33:19 2018 +0200
Bug 20697: Bind calling GetAnalyticsCount to pref EasyAnalyticalRecords
If you do not use the EasyAnalyticalRecords feature (introduced with
bug 5528), you will have a lot of warnings in zebra-output.log like:
zebrasrv(1096) [request] Search biblios ERROR 114 1 1+0 RPN @attrset Bib-1 @attr 1=8911 259186
They come from C4::Items::GetAnalyticsCount called by catalogue/detail.pl.
This sub starts a Zebra search on index 'hi' (Host-Item-Number).
If you do not use this field at all (related to 773$9 in MARC21), Zebra
returns an Unsupported Use attribute error (114).
In making this change, I added one minor change:
[1] Remove the commented GetAnalyticsCount in additem.pl and correcting
indentation in that loop (removing tabs). So no change at all there.
NOTE: I will propose to bind the GetHostItemsInfo call in detail.pl and two
other scripts to this preference too on report 20702.
Test plan:
[1] If you use EasyAnalytics, verify that there is no change.
[2] If you do not, check the zebra-output.log. You should no longer see
searches for Host-Item-Number with 1=8911. (As well as ERROR 114 on
this index.)
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 6ad2c1402fa3a8d419a357233a6e4ad19e58a3db)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit a83004bb92014173573b2dbc393e451f1a4d339c
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Jun 18 18:29:57 2018 +0000
Bug 17869: Don't show pick-up library for list of holds in OPAC account when there is only one branch
This patch modifies the user summary page in the OPAC so that the
"pick up location" column isn't shown in the table of holds if there is
only one library defined.
To test, apply the patch and log into the OPAC as a user with one or
more holds.
- In a system with more than one library defined the "Holds" tab of
opac-user.pl should show a "Pick up location" column.
- In a system with only one library defined there should be now "Pick
up location" column.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 9d96e2142140b8184e77da038fde51c0f7000c87)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 4f98d34c0fe8bb483869678e955881276e5ce257
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Jun 7 14:03:11 2018 +0000
Bug 20893: batchRebuildItemsTables.pl has incorrect parameter
To test:
1 - run batchRebuildItemsTables.pl with a valid biblionumber
perl /usr/share/koha/bin/batchRebuildItemsTables.pl --where biblio.biblionumber=38483 -c
2 - Note it says 'undefined biblionumber
3 - Apply patch
4 - Do it again
5 - It works!
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 737702f9756f89f6f75b2a3323e03738234fa143)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit bc8d1205a6e08a036bfb5ad99f191cdbf6f58690
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Mon Jun 25 14:58:17 2018 +0200
Bug 16653: (QA follow-up) Avoid a warning and remove unused variables
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 73f37b3a561efe61832bde372ffc42fb9dd47f54)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit ad6b2e8dc16fd4e4295ff53a5d3b61b72e71d59d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Jun 7 11:47:46 2018 -0300
Bug 16653: Display number of checkouts when exporting 'Most-circulated items' as CSV
reports/cat_issues_top.pl does not export "Count of checkouts" column as CSV
To replicate:
1/ Make sure that test instance has circulation in a given date range
2/ Go to Home › Reports › Most-circulated items
3/ Select a date range
4/ Select 'To screen into the browser' radio button, click submit.
5/ Note that Columns 'Rank/Biblioitemnumbers', 'Global' and 'Count of checkouts' appear in screen output.
6/ Click the browser's back button
7/ Change output to 'To a file', click submit.
Without this patch:
the columns "100/", "Global" and "Total" are exported to the CSV file.
"100/" contains the rank, "Global" is still global, and the "Total" column is empty.
With this patch patch applied, the last column is filled and the "Total" line is removed
(This script is really dirty)
Signed-off-by: Pierre-Luc Lapointe <pierreluc.lapointe at inLibro.com>
(Yes it is)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 5bb6b6581c9385d693194338db3e7865d2c28409)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 3e0ccc346ca6f6b758b88cd0d4f09c2e6bdb44e4
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Fri Jun 8 09:43:13 2018 +0000
Bug 20903: Remove unnecessary category code parameters
Test plan:
0) Do no apply the patch
1) Have only one adults patrons category defined
2) Add a fine to child patron and pay it
3) Try to print the payment receipt (file printfeercpt.pl)
4) You see only ISE
5) Apply the patch
6) Try the printing again
7) Now you should see right receipt
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 5f03b21cf3a7141dc0f2ae2b1922505d55d4cd34)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 65d196036df2f195569c7123df358995db1ca45e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jun 26 12:37:19 2018 -0300
Bug 20998: Simplify the conditional statement
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit d874e52cdc6bcb20ee12885b9ecec0f339d315db)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit a9035a52d082924a8380639dcf423437b064a4f0
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Jun 26 15:02:02 2018 +0000
Bug 20998: Only perform quicksearch if patron found with cardnumber
This patch makes sure we have a patron before we try to access their
branchcode and allows search to work
To recreate:
1 - Enable 'IndependentBranches'
2 - Setup a patron with all permissions, but not a superlibrarian
3 - Login to staff client as that patron
4 - Click 'Patrons' in the toolbar and try a search
5 - Internal server error
6 - Apply patch
7 - Try the search again
8 - Success!
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 3afc24c776a30fc510c23177548b8b26fd44c4c7)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 16add1adb392389c87b30446cc13183d43aae167
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Jun 29 09:53:27 2018 -0300
Bug 21019: Fix display of patron's address on reserve pop-up on returns.pl
Caused by
commit 2b90ea2cb0e5e976de7ddef0151ae83d8ac578e6
Bug 17829: Move GetMember to Koha::Patron
address variable has been replaced by boraddress (wrong resolution
conflict?)
It does not affect master (thanks bug 18789)
Test plan:
Confirm the address of the patron with a hold placed on the item is now
displayed when this item is checked in
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
-----------------------------------------------------------------------
Summary of changes:
catalogue/detail.pl | 2 +-
cataloguing/additem.pl | 26 +++---
circ/returns.pl | 4 +-
.../prog/en/includes/reports-toolbar.inc | 2 +-
.../en/modules/virtualshelves/addbybiblionumber.tt | 86 ++++++++++----------
.../bootstrap/en/modules/opac-addbybiblionumber.tt | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-user.tt | 14 ++--
members/member.pl | 9 +-
members/printfeercpt.pl | 6 --
misc/batchRebuildItemsTables.pl | 2 +-
reports/cat_issues_top.pl | 17 +---
11 files changed, 77 insertions(+), 93 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list