[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.01-94-g49db39c

Sun Jul 15 22:37:29 CEST 2018

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  49db39c060163c3d46de4eff283919cc9af30a97 (commit)
       via  9e26419e30c88d8a9cd54660752fda89170ae3f8 (commit)
       via  1ad0724b804970fe9ca8e8333b1fb0b893c28cf4 (commit)
       via  7e3f399867abdf506ff271c57d652d1b3cdf8a7e (commit)
       via  654abf9966bd340689b1944a7e5266cde7127321 (commit)
       via  0536b99e6dfdf7e21dcf62963ed3f1449d434d3d (commit)
       via  53e0523207738cd489d77007c8e642b88030d4c6 (commit)
       via  43f509b08e7d30bca6c88e094bbfa763d036bf67 (commit)
       via  7662f4873e97272c677f4912c22aeeec25097bc2 (commit)
      from  ce63b26b476415f30cecd7be97b52b60c07341d1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 49db39c060163c3d46de4eff283919cc9af30a97
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri May 25 09:32:58 2018 +0000

    Bug 18822: Check if we have MARC::Record and convert if not when using ES

    The new_record_from_zebra subroutine assumes that when using ES we
    always get MARC::Record objects when using ES, but sometimes we get them as xml via Z39 or
    internally. This adds a test to new_from_zebra to confirm we have a
    record object and to convert it if not

    To test:
    1 - Perform an advanced search from the advanced editor, make sure to
    select 'Local catalog' and a remote source
    2 - Error 'Internal search error [Object object]'
    3 - Apply patch
    4 - Repeat search, success!
    5 - Select and deselect various servers, search should still work

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 9e26419e30c88d8a9cd54660752fda89170ae3f8
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Jun 19 11:21:41 2017 -0400

    Bug 18822: Better error response

    Apply this patch first to see a change in the error feedback - instead
    of [Object object] you should get a text readable error

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 1ad0724b804970fe9ca8e8333b1fb0b893c28cf4
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Mon Jul 2 10:41:24 2018 +0200

    Bug 20900: Add CPL branch in t_Batch.t too

    Same fix as previous patch.

    Test plan:
    Run t/db_dependent/Labels/t_Batch.t (without CPL branch)

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 7e3f399867abdf506ff271c57d652d1b3cdf8a7e
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Jun 8 10:56:10 2018 +0200

    Bug 20900: Add CPL test branch in rollingloans.t

    Trivial fix.

    Test plan:
    Without this patch and a CPL library, run rollingsloans.t. See warns.
    With this patch, no warns.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 654abf9966bd340689b1944a7e5266cde7127321
Author: Charles Farmer <charles.farmer at inLibro.com>
Date:   Fri Jun 29 16:12:59 2018 -0400

    Bug 21025: Add GetPreparedLetter to Koha::Patron::Discharge

    Test plan (shamelessly ripped from Bug20953):

    1) Set system preference 'useDischarge' to 'Allow'
    2) Choose a patron without checkouts nor fines nor restrictions
    3) Log at OPAC and go to patron page /cgi-bin/koha/opac-user.pl
    4) Click on 'ask for a discharge' tab
       => You see /cgi-bin/koha/opac-discharge.pl
          with text 'What is a discharge? ...'
    5) Click on 'Ask for a discharge' link
       => You see /cgi-bin/koha/opac-discharge.pl?op=request
          with text 'Your discharge request has been sent ...'
    6) In a new browser tab/page, go to intranet on /cgi-bin/koha/members/discharges.pl
       => You see one discharge requets for the patron
       => Click on 'allow' on patron discharge request
    7) Come back to OPAC and refresh /cgi-bin/koha/opac-discharge.pl
      => You see link 'Get your discharge'
    8) Click on the link to get your generated PDF
      => An error message should appear informing you to contact your website's admin
    9) Apply this patch
    10) Click again on the link to get your generated PDF
      => This time, a download prompt should appear

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 0536b99e6dfdf7e21dcf62963ed3f1449d434d3d
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Mon Jun 18 15:29:37 2018 +0000

    Bug 20698: Remove obsolete template: transfer-slip.tt

    This patch removes an unused template file, circ/transfer-slip.tt. Its
    use was removed by Bug 7001:

    http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=a9ded4fa008668df8c485fbbc76efa3cc9cc00d7#patch12

    To test, apply the patch and confirm that the file has been removed.
    Confirm that no references to the template exist in the codebase.

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 53e0523207738cd489d77007c8e642b88030d4c6
Author: Pasi Kallinen <pasi.kallinen at joensuu.fi>
Date:   Mon Mar 5 12:10:56 2018 +0200

    Bug 20332: Allow translating some grouped opac results texts

    The grouped OPAC results page has several untranslatable
    javascript-added texts, including the selection modifiers "Clear all"
    and "Select all" links, and the entries in the shelves/lists dropdown.

    Compare to opac-results.tt

    Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 43f509b08e7d30bca6c88e094bbfa763d036bf67
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Jul 13 11:48:42 2018 +0000

    Bug 20090: (RM follow-up) Add missing paren

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 7662f4873e97272c677f4912c22aeeec25097bc2
Author: David Kuhn <techservspec at gmail.com>
Date:   Thu Jan 25 09:27:19 2018 -0800

    Bug 20090: Missing script statement for Novelist Select on some record displays in OPAC

    This patch adds a check for UPCs and well as ISBNs to the Novelist Select conditionals in opac-detail.tt

    To test (note that you must subscribe to Novelist Select):

    1. If your library does not use the raton ratings feature, activate it for the purposes of this test.

    2. Display a record that does not have an ISBN in the 020 field, but has a upc (or other code) in the 024 field. The rating option will

    display as 5 radio buttons and a "rate it" button.

    3. Apply the patch.

    4. Display the same record again. The radio buttons will be replaced with stars. This indicates that the scripts on the page completed.

    Rather that using the patron ratings as in indicator, you can also use a web page inspector/debugger such as firebug or the built-in

    inspectors in most newer browsers to check for script errors.

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    I couldn't check with Novelist Select, but read and checked changed made carefully.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Search.pm                                       |    2 +-
 Koha/Patron/Discharge.pm                           |    1 +
 .../prog/en/includes/cateditor-ui.inc              |    2 +-
 .../prog/en/modules/circ/transfer-slip.tt          |   25 --------------------
 .../opac-tmpl/bootstrap/en/modules/opac-detail.tt  |    9 +++----
 .../bootstrap/en/modules/opac-results-grouped.tt   |    6 ++---
 t/db_dependent/Labels/t_Batch.t                    |   10 +++++++-
 t/db_dependent/rollingloans.t                      |    6 ++++-
 8 files changed, 25 insertions(+), 36 deletions(-)
 delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/circ/transfer-slip.tt

hooks/post-receive
-- 
main Koha release repository