[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.00-2-g359cbe9

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  359cbe9c5cae9165b22aa21e294695b932216694 (commit)
       via  721f05371e2877e83e5f2adb6b523c5086333f4b (commit)
      from  df8716197ad36f168689b98994fd693893c9d5d3 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 359cbe9c5cae9165b22aa21e294695b932216694
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon May 28 11:24:43 2018 -0300

    Bug 20825: (bug 19943 follow-up) call notforloan on itemtype instead of biblioitem
    
    On bug 19943:
     -        elsif ($biblioitem->{'notforloan'} == 1){
     +        elsif ($biblioitem->notforloan == 1){
    
    The biblioitems table does not contain a notforloan column, this comes
    from the item type.
    
    This bug only appears when item type is defined at biblio level
    (item-level_itypes=0)
    
    Test plan:
    Set item-level_itypes = biblio
    Check an item out
    
    Without this patch it explodes with
    "The method notforloan is not covered by tests!"
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    I reproduced the error condition and verified the tests failed without
    this patch. After this patch is applied, tests pass and checkout
    succeeds.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 721f05371e2877e83e5f2adb6b523c5086333f4b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon May 28 11:20:32 2018 -0300

    Bug 20825: Add regression tests
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm            |   17 ++++++++++-------
 t/db_dependent/Circulation.t |   36 +++++++++++++++++++++++++++++++++++-
 2 files changed, 45 insertions(+), 8 deletions(-)


hooks/post-receive
-- 
main Koha release repository