[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.00-16-gc5dc6ae

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  c5dc6aeae728078ca76e88f8af8693772006d842 (commit)
      from  34b780bf007239617d372a1923f7d1c3f35bb51e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c5dc6aeae728078ca76e88f8af8693772006d842
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date:   Mon May 21 14:56:58 2018 -0400

    Bug 20798: Client side validation for for fund selection prevents adding only some records to a basket
    
    Bug 19453 "fixed" the fund validation that never actually worked. This validation should be removed altogether instead. It is overly simplistic and simply checks to see if each record in the batch has a fund selected regardless of whether that record will be imported or not.
    
    In addition, the code completely ignores items generated by MarcItemFieldsToOrder such that even if items on that page have a fund selected, the javascript forces the librarian to make a selection from the left-hand fund pulldown even though it will not be used.
    
    Considering this bad validation is basically 'new' as it never worked before, the most sensible course of action would be to 'undo' the change and remove the validation.
    
    Test Plan:
    1) Add records to a basket from an import batch
    2) Select only some of those items in the batch
    3) Note Koha will not let you import them unless you set funds for *all*
       records in the batch
    4) Apply this patch
    5) Note Koha no longer forces a budget to be selected in the pulldown
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    https://bugs.koha-community.org/show_bug.cgi?id=20789
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 .../prog/en/modules/acqui/addorderiso2709.tt             |   14 --------------
 1 file changed, 14 deletions(-)


hooks/post-receive
-- 
main Koha release repository