[koha-commits] main Koha release repository branch master updated. v18.05.00-65-gc967e01

Fri Jun 15 12:54:01 CEST 2018

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  c967e010c0110e562c4cc71bc5d18837a2a956a0 (commit)
       via  2acf4bf510292281db013acb3bda0c1e9a779931 (commit)
       via  812adec528241ab6977697d5d6f2066b39b5b903 (commit)
       via  3495de67d40637462e9b359bee207a38206e0bba (commit)
       via  6613f36d5af67e5fcf7e7a6f3e80331805b8eea7 (commit)
       via  812645449684f88c769e04bb1eb1f55923a0e0d9 (commit)
       via  3c65318243de786bdc11d9ad335a253d59754d74 (commit)
       via  d795654ebfe31d8ae3d04cf952d1a24650b86b2c (commit)
       via  2367760e990ee55e9cfad0c4dc440824d45751d5 (commit)
       via  38d75d28afd485aabdb5d4491a0b8380dc8c409a (commit)
      from  6650c7efb41072a2937bfb6ce90ef08f5c442066 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c967e010c0110e562c4cc71bc5d18837a2a956a0
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date:   Fri Feb 23 08:44:45 2018 -0500

    Bug 20285: Lost item refund won't always pay down lost item fee first

    Due to a simple typo, the accountline passed to Koha::Account::pay from _FixAccountForLostAndReturned is not used. That means that the credit for the lost item fee may be applied to other fees before it is used on the lost fee itself.

    Test Plan:
    1) Find a patron with existing fines
    2) Ensure your settings will charge patrons for lost items
    3) Check out an item to a patron with existing fees that need paid
    4) Mark the item lost, charging the lost item fee
    5) Return the item
    6) Note the fee was refunded, but it paid down earlier fines first,
       and not the lost item fee first
    7) Apply this patch set
    8) Repeat steps 1 - 5
    9) Note the lost item fee is the first fee to be paid off by the lost
       item fee refund

    Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
    Followed the test plan and it works as expected.

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 2acf4bf510292281db013acb3bda0c1e9a779931
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date:   Fri Feb 23 08:44:24 2018 -0500

    Bug 20285: Unit Test

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 812adec528241ab6977697d5d6f2066b39b5b903
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Thu May 31 15:32:29 2018 +0000

    Bug 19970: Revise change of bug 19413 to work better for translations

    This patch changes how the submit and cancel buttons appear in the MARC
    008 plugin window. The controls are now displayed as buttons in a
    floating toolbar.

    To test you must have MARC tag 008 configured to use the
    marc21_field_008.pl plugin.

    - Apply the patch and open an existing or blank record in cataloging.
    - Click the plugin link next to tag 008 to trigger the popup window.
    - Confirm that "Save" and "Cancel" appear correctly in a toolbar.
    - Scroll down the page to confirm that the toolbar "sticks" to the top
      of the window.
    - Confirm that the "Save" and "Cancel" buttons work correctly.

    Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
    Followed the test plan and the patch works.

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 3495de67d40637462e9b359bee207a38206e0bba
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jun 4 13:02:33 2018 -0300

    Bug 20760: Fill authorised values in svc framework

    To test:
     1 - Map a marc field to an authorised value in the default framework -
    say 300$c -> CCODE
     2 - Open the advanced cataloguing editor
     3 - Create a new field 300$c - note there is no dropdown
     4 - browse to: /cgi-bin/koha/svc/cataloguing/framework?callback=define
     5 - Note the many instance of
    Koha::Schema::ResultSet::AuthorisedValueCategory->HASH...
     6 - Apply patch
     7 - Restart memcached and plack
     8 - reload/recreate record in rancor
     9 - Note that 300$c is now a dropdown as expected
    10 - repeate 4
    11 - note the authorised values look correct in response

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 6613f36d5af67e5fcf7e7a6f3e80331805b8eea7
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Jun 11 15:28:19 2018 +0000

    Bug 20911: Use 'POST' to submit search history forms

    To test:
    1 - Enable EnableOpacSearchHistory and EnableSearchHistory
    2 - Do some searches
    3 - View your search history in staff/opac
    4 - Confirm you can delete single or multiple rows
    5 - Confirm other page functionality has not changed

    Signed-off-by: Ed Veal <eveal at mckinneytexas.org>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 812645449684f88c769e04bb1eb1f55923a0e0d9
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Thu Jun 7 15:59:39 2018 +0200

    Bug 20892: Correct basketgroup link in histsearch.pl

    When searching an order, histsearch.pl page, you see if exists the backetgroup as a link.
    This link is composed of "basketgroup.pl?booksellerid=xxx", it must also contain "basketgroupid=xxx" and "opa=add".

    See Bug 11429 for example.

    Test plan :
    1) Create an order in a basket and add it to a basketgroup
    2) Search for this order, you get to page histsearch.pl
    3) Check clicking on basketgroup id leads to basketgroup details page

    Signed-off-by: Amit Gupta <amit.gupta at informaticsglobal.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 3c65318243de786bdc11d9ad335a253d59754d74
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Jun 12 11:13:46 2018 -0300

    Bug 20899: Fix patron's name display

    This is a follow-up for
      commit fa54100dffe092e606f79b15692eedaf78f42e45
      Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for issuehistory]

    We should use patron-title.inc to display (or hide) patron's info on the
    checkout history view

    Test plan:
    Issue an item, go to the biblio, click the circulation history for this
    tab.
    Note that the patron's name is showing.

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit d795654ebfe31d8ae3d04cf952d1a24650b86b2c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Jun 12 11:26:02 2018 -0300

    Bug 20918: Fix left-side navigation on the checkout history page

      commit fa54100dffe092e606f79b15692eedaf78f42e45
      Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for issuehistory]

    Removed:
    -    biblionumber => $biblionumber, # required for left-side navigation

    But did not deal with the side-effects.

    Test plan:
    When you are on the "Checkout history" page (/cgi-bin/koha/catalogue/issuehistory.pl?biblionumber=42),
    the left-side navigation is broken if this patch is not applied, the biblionumber is not set.

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 2367760e990ee55e9cfad0c4dc440824d45751d5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Jun 12 13:12:25 2018 -0300

    Bug 20922: Remove use of Koha::Number::Price in updatedatabase.pl

    Koha::Number::Format->round use Number::Format->round with a precision=2
    We should use it directly instead of Koha::* modules. It will avoid the
    DB entry to fail because schema changes.

    From the koha-devel list:

    http://lists.koha-community.org/pipermail/koha-devel/2018-June/044608.html

    16.06.00.042

    Upgrade to 16.06.00.041 done (Bug 14629 - Add aggressive ISSN matching
    feature equivalent to the aggressive ISBN matcher)
    DBD::mysql::st execute failed: Unknown column 'me.p_sep_by_space' in
    'field list' [for Statement "SELECT `me`.`currency`, `me`.`symbol`,
    `me`.`isocode`, `me`.`timestamp`, `me`.`rate`, `me`.`active`,
    `me`.`archived`, `me`.`p_sep_by_space` FROM `currency` `me` WHERE (
    `active` = ? )" with ParamValues: 0=1] at
    /usr/local/share/perl/5.24.1/DBIx/Class/Storage/DBI.pm line 1836.
    DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column
    'me.p_sep_by_space' in 'field list' at
    /inlibro/git/koha-csf-prod-inlibro/Koha/Objects.pm line 209

    Basically, the update code uses Koha::Number::Price, which in full
    modern object mode goes for its newly added *p_sep_by_space* _in the
    18.05 code_.  But the DB doesn't have it yet (it comes with 17.12.00.022).

    Signed-off-by: Blou <philippe.blouin at inlibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 38d75d28afd485aabdb5d4491a0b8380dc8c409a
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Tue May 29 11:48:14 2018 +0000

    Bug 20832: Fix opac user profile page when there is overdue fine and no rental charge

    Test plan:
    0) Do not apply the patch
    1) Have an overdue fine linked with specific item currently checked out
    to your patron
    2) Do not have any unpaid rental fees
    3) Go to this patron profile in opac - page opac-user.pl
    4) The page crashes with "Can't call method "get_column" on an undefined
    value at
    /usr/share/koha/opac/cgi-bin/opac/opac-user.pl line 217" in log
    5) Apply the patch
    6) Restart plack
    7) The page should working and show the right amounts for fines

    Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                                  |    2 +-
 installer/data/mysql/updatedatabase.pl             |   45 ++++++++++----------
 .../prog/en/includes/biblio-view-menu.inc          |    2 +-
 .../prog/en/modules/acqui/histsearch.tt            |    2 +-
 .../prog/en/modules/catalogue/issuehistory.tt      |    2 +-
 .../prog/en/modules/catalogue/search-history.tt    |    8 ++--
 .../cataloguing/value_builder/marc21_field_008.tt  |   20 ++++++++-
 .../bootstrap/en/modules/opac-search-history.tt    |    8 ++--
 opac/opac-user.pl                                  |    2 +-
 svc/cataloguing/framework                          |   19 ++-------
 t/db_dependent/Circulation.t                       |   10 +++++
 11 files changed, 68 insertions(+), 52 deletions(-)

hooks/post-receive
-- 
main Koha release repository