[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.06-38-gd39c4cd

Mon Jun 18 09:13:35 CEST 2018

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.11.x has been updated
       via  d39c4cd03e6cf56466fce022f058716b325e26c4 (commit)
       via  cd937321520e7aab567449d9051989869aade789 (commit)
       via  4e240ba05abd10aeb4a8c76e3d0af36e8383a322 (commit)
       via  df301bff9dc23863e6c9d0e1941f64c176e906f7 (commit)
       via  46ba09c838d958c54c1239df88e2e0a537828494 (commit)
       via  878f645c5dd6433cb78402b0658cca75e1b4e561 (commit)
      from  0d7922dc556160fb6dc1bfd9aa6cdc1bc3715206 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d39c4cd03e6cf56466fce022f058716b325e26c4
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date:   Fri Feb 23 08:44:45 2018 -0500

    Bug 20285: Lost item refund won't always pay down lost item fee first

    Due to a simple typo, the accountline passed to Koha::Account::pay from _FixAccountForLostAndReturned is not used. That means that the credit for the lost item fee may be applied to other fees before it is used on the lost fee itself.

    Test Plan:
    1) Find a patron with existing fines
    2) Ensure your settings will charge patrons for lost items
    3) Check out an item to a patron with existing fees that need paid
    4) Mark the item lost, charging the lost item fee
    5) Return the item
    6) Note the fee was refunded, but it paid down earlier fines first,
       and not the lost item fee first
    7) Apply this patch set
    8) Repeat steps 1 - 5
    9) Note the lost item fee is the first fee to be paid off by the lost
       item fee refund

    Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
    Followed the test plan and it works as expected.

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 2f2a5b2c58f49e2635a38040fa0130d5f2677488)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit cd937321520e7aab567449d9051989869aade789
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date:   Fri Feb 23 08:44:24 2018 -0500

    Bug 20285: Unit Test

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 096ba7d34cd08fcafed0aef2fcf272907cba55f0)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 4e240ba05abd10aeb4a8c76e3d0af36e8383a322
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Jun 4 13:02:33 2018 -0300

    Bug 20760: Fill authorised values in svc framework

    To test:
     1 - Map a marc field to an authorised value in the default framework -
    say 300$c -> CCODE
     2 - Open the advanced cataloguing editor
     3 - Create a new field 300$c - note there is no dropdown
     4 - browse to: /cgi-bin/koha/svc/cataloguing/framework?callback=define
     5 - Note the many instance of
    Koha::Schema::ResultSet::AuthorisedValueCategory->HASH...
     6 - Apply patch
     7 - Restart memcached and plack
     8 - reload/recreate record in rancor
     9 - Note that 300$c is now a dropdown as expected
    10 - repeate 4
    11 - note the authorised values look correct in response

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit ac390bd228c6ea7eab7c8b694a378a837f8da464)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit df301bff9dc23863e6c9d0e1941f64c176e906f7
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Jun 11 15:28:19 2018 +0000

    Bug 20911: Use 'POST' to submit search history forms

    To test:
    1 - Enable EnableOpacSearchHistory and EnableSearchHistory
    2 - Do some searches
    3 - View your search history in staff/opac
    4 - Confirm you can delete single or multiple rows
    5 - Confirm other page functionality has not changed

    Signed-off-by: Ed Veal <eveal at mckinneytexas.org>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit e4c26c44d3c70cf62225361a4cce94e1f5aa16c8)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 46ba09c838d958c54c1239df88e2e0a537828494
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Thu Jun 7 15:59:39 2018 +0200

    Bug 20892: Correct basketgroup link in histsearch.pl

    When searching an order, histsearch.pl page, you see if exists the backetgroup as a link.
    This link is composed of "basketgroup.pl?booksellerid=xxx", it must also contain "basketgroupid=xxx" and "opa=add".

    See Bug 11429 for example.

    Test plan :
    1) Create an order in a basket and add it to a basketgroup
    2) Search for this order, you get to page histsearch.pl
    3) Check clicking on basketgroup id leads to basketgroup details page

    Signed-off-by: Amit Gupta <amit.gupta at informaticsglobal.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit e60226e40117e50a5fcc51b125cac22036dfb32f)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 878f645c5dd6433cb78402b0658cca75e1b4e561
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Jun 12 13:12:25 2018 -0300

    Bug 20922: Remove use of Koha::Number::Price in updatedatabase.pl

    Koha::Number::Format->round use Number::Format->round with a precision=2
    We should use it directly instead of Koha::* modules. It will avoid the
    DB entry to fail because schema changes.

    From the koha-devel list:

    http://lists.koha-community.org/pipermail/koha-devel/2018-June/044608.html

    16.06.00.042

    Upgrade to 16.06.00.041 done (Bug 14629 - Add aggressive ISSN matching
    feature equivalent to the aggressive ISBN matcher)
    DBD::mysql::st execute failed: Unknown column 'me.p_sep_by_space' in
    'field list' [for Statement "SELECT `me`.`currency`, `me`.`symbol`,
    `me`.`isocode`, `me`.`timestamp`, `me`.`rate`, `me`.`active`,
    `me`.`archived`, `me`.`p_sep_by_space` FROM `currency` `me` WHERE (
    `active` = ? )" with ParamValues: 0=1] at
    /usr/local/share/perl/5.24.1/DBIx/Class/Storage/DBI.pm line 1836.
    DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column
    'me.p_sep_by_space' in 'field list' at
    /inlibro/git/koha-csf-prod-inlibro/Koha/Objects.pm line 209

    Basically, the update code uses Koha::Number::Price, which in full
    modern object mode goes for its newly added *p_sep_by_space* _in the
    18.05 code_.  But the DB doesn't have it yet (it comes with 17.12.00.022).

    Signed-off-by: Blou <philippe.blouin at inlibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 93de5885098b9982a3ab9ad73ff73111d71ac3ef)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                                  |    2 +-
 installer/data/mysql/updatedatabase.pl             |   45 ++++++++++----------
 .../prog/en/modules/acqui/histsearch.tt            |    2 +-
 .../prog/en/modules/catalogue/search-history.tt    |    8 ++--
 .../bootstrap/en/modules/opac-search-history.tt    |    8 ++--
 svc/cataloguing/framework                          |   19 ++-------
 t/db_dependent/Circulation.t                       |   10 +++++
 7 files changed, 47 insertions(+), 47 deletions(-)

hooks/post-receive
-- 
main Koha release repository