[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.01-13-g7861cc0

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  7861cc07ba8afdf09079c7b51fdb99ad99132688 (commit)
       via  5462c1a88b2652fb25c67f40946436eb243d6ed1 (commit)
      from  b3d1a5bfecbfbac4af8335757414def1ee3e2df5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 7861cc07ba8afdf09079c7b51fdb99ad99132688
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Thu May 3 13:12:19 2018 +0200

    Bug 20702: Bind results of GetHostItemsInfo to the EasyAnalyticalRecords pref
    
    Triggered by the finding on bug 20697.
    The three calls of GetHostItemsInfo should be controlled by the pref. This
    patch makes the sub return an empty list when the pref is disabled.
    
    The patch simplifies the sub by merging the two identical foreach loops
    depending on the field number in MARC21/UNIMARC.
    
    Will add a unit test on a follow-up patch.
    
    Test plan:
    See next patch.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 5462c1a88b2652fb25c67f40946436eb243d6ed1
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Thu May 3 14:08:01 2018 +0200

    Bug 20702: Add unit tests for GetHostItemsInfo
    
    Unfortunately, we did not have unit tests yet.
    Adding some simple tests that test basic operation of the sub when the
    pref is enabled/disabled and for MARC21/UNIMARC.
    
    Test plan:
    [1] Run t/db_dependent/Items/GetHostItemsInfo.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Items.pm                             |   62 +++++++++++++++----------------
 t/db_dependent/Items/GetHostItemsInfo.t |   41 ++++++++++++++++++++
 2 files changed, 70 insertions(+), 33 deletions(-)
 create mode 100644 t/db_dependent/Items/GetHostItemsInfo.t


hooks/post-receive
-- 
main Koha release repository