[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.07-9-gd62c83a

Thu Jun 28 10:35:05 CEST 2018

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.11.x has been updated
       via  d62c83a2416e603e2d2508aa58aa6efb72964024 (commit)
       via  0c09588514f49b7d02bb9adecb4d6cb9cc35b74d (commit)
       via  dae5e20b1ba4aafd194cb1ec8be489920075f3c5 (commit)
       via  781c33745bda17d94681d05edb0f0bef8271c697 (commit)
       via  9ef0e010cca0de135d8a270b2fd70ba155d018b6 (commit)
       via  f84a670970e973c059f8f31e0fc96b96e057c783 (commit)
       via  76dc84a7558d6f232afe05359c16aeb98d61a524 (commit)
       via  a3b3019ad3df3d4b24e31b23054b540f1df0fee7 (commit)
       via  8cd11380a89b74aa114ec7fc62735206027c2a6d (commit)
      from  d405ffe121df7a5345dcfee018e698d02a46d893 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d62c83a2416e603e2d2508aa58aa6efb72964024
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Thu May 3 13:12:19 2018 +0200

    Bug 20702: Bind results of GetHostItemsInfo to the EasyAnalyticalRecords pref

    Triggered by the finding on bug 20697.
    The three calls of GetHostItemsInfo should be controlled by the pref. This
    patch makes the sub return an empty list when the pref is disabled.

    The patch simplifies the sub by merging the two identical foreach loops
    depending on the field number in MARC21/UNIMARC.

    Will add a unit test on a follow-up patch.

    Test plan:
    See next patch.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 7861cc07ba8afdf09079c7b51fdb99ad99132688)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 0c09588514f49b7d02bb9adecb4d6cb9cc35b74d
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Thu May 3 14:08:01 2018 +0200

    Bug 20702: Add unit tests for GetHostItemsInfo

    Unfortunately, we did not have unit tests yet.
    Adding some simple tests that test basic operation of the sub when the
    pref is enabled/disabled and for MARC21/UNIMARC.

    Test plan:
    [1] Run t/db_dependent/Items/GetHostItemsInfo.t

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 5462c1a88b2652fb25c67f40946436eb243d6ed1)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit dae5e20b1ba4aafd194cb1ec8be489920075f3c5
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sun May 20 04:23:47 2018 +0200

    Bug 20794: Hide holds tab on details when user lacks circulate_remaining_permissions

    If a user doesn't have circulate_remaining permissions, but has borrowers:
    - checkouts tab is hidden
    - details tab is visible
    - holds tab on details is visible, but results in an error

    The problem is that the svc/holds script requires circulate_remaining_permissions.

    To test:
    - Create 2 staff users with and without circulate_remaining_permissions
      Both need borrowers permission
    - Go to the details tab in a patron's account who has holds
    - Verify that you get a datatables error for the staff patron without
      circulate_remaining_permissions
    - Apply patch
    - Verify that now the holds tab is no longer displayed for this patron

    Signed-off-by: Amit Gupta <amit.gupta at informaticsglobal.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit b3d1a5bfecbfbac4af8335757414def1ee3e2df5)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 781c33745bda17d94681d05edb0f0bef8271c697
Author: Pasi Kallinen <pasi.kallinen at joensuu.fi>
Date:   Tue Jun 5 13:26:43 2018 +0300

    Bug 20881: Order receiving: Price filter missing on_editing

    When the Price-filter is used on editable data, it should have the
    on_editing -tag. Add it to the orderreceive.tt

    Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    To test:
    - Set CurrencyFormat to FR
    - Create a basket with orders in acq
    - Close it
    - Receive shipment and pick order line to receive
    - On this screen verify that the actual cost appears as comma-separated
    - Apply patch
    - Refresh page
    - Verify that the actual cost now appears .-separated

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 279e328cdda0e3e17c244a39b933ce898bc5bee2)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 9ef0e010cca0de135d8a270b2fd70ba155d018b6
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Fri Jun 15 12:56:36 2018 +0200

    Bug 20951: add missing use Koha::Patron::Debarments in Koha::Patron::Discharge

    Koha::Patron::Discharge was missing use Koha::Patron::Debarments used in discharge() method.

    Test plan :
    1) Enable pref useDischarge
    2) Go to OPAC user page
    3) Go to 'ask for a discharge' tab
    4) Click on 'Ask for a discharge'
    5) Go to staff interface : /cgi-bin/koha/members/discharges.pl
    6) Click on Allow
    => Without patch you get software error
    => With patch the discharge is validated

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 842abeb423b81c61d2774f8446a5bcbb2d0a258c)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit f84a670970e973c059f8f31e0fc96b96e057c783
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Jun 8 13:06:58 2018 -0300

    Bug 20906: Fix translatable-templates.t

    From Jenkins:
    koha_1       | #   Failed test 'staff_prog templates are translatable'
    koha_1       | #   at xt/author/translatable-templates.t line 87.
    koha_1       | # Can't locate TmplTokenizer.pm in @INC (you may need to install the TmplTokenizer module) (@INC contains: /kohadevbox/koha /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at ./tmpl_process3.pl line 20.

    On Stretch, '.' is not longer added to @INC, see bug 17717 for more info

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 1600d82c610aba303ea0cb1f31f1a81d36483ffb)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 76dc84a7558d6f232afe05359c16aeb98d61a524
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Jun 8 15:21:22 2018 +0100

    Bug 20906: Prevent test failures due to precision changes (2)

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit a19c161675840c7a5f6546da3d678149d31e260b)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit a3b3019ad3df3d4b24e31b23054b540f1df0fee7
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Jun 8 14:32:02 2018 +0100

    Bug 20906: Prevent test failures due to stricter perl

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit baf43e6a5b1ddd57306ef779d725e05534aad92b)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 8cd11380a89b74aa114ec7fc62735206027c2a6d
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Fri Jun 8 12:50:31 2018 +0100

    Bug 20906: Prevent test failures due to precision changes

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit b13429395830f3f84bc551d769e2ee28c7a740ed)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Items.pm                                        |   62 +++++++++-----------
 Koha/Patron/Discharge.pm                           |    1 +
 docs/CAS/CASProxy/examples/proxy_cas_data.pl       |    2 +-
 .../prog/en/modules/acqui/orderreceive.tt          |    2 +-
 .../prog/en/modules/members/moremember.tt          |    5 +-
 t/db_dependent/Accounts.t                          |    4 +-
 t/db_dependent/Bookseller.t                        |   44 +++++++++-----
 t/db_dependent/Items/GetHostItemsInfo.t            |   41 +++++++++++++
 xt/author/translatable-templates.t                 |    8 ++-
 9 files changed, 113 insertions(+), 56 deletions(-)
 create mode 100644 t/db_dependent/Items/GetHostItemsInfo.t

hooks/post-receive
-- 
main Koha release repository