From gitmaster at git.koha-community.org Thu Mar 8 10:47:57 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 08 Mar 2018 09:47:57 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.09-5-geb005e7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via eb005e767e14e3f81e2d052699c4f236d4b0461f (commit) via 82010132eb3e4ef2eabd59be2487765d3ea5f63d (commit) via f1fc90de9537358db49823e9399b4172702fad83 (commit) from 605e6fb59f676e2fea225b27c5da4285a5abece1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit eb005e767e14e3f81e2d052699c4f236d4b0461f Author: Kyle M Hall Date: Tue Jan 30 11:22:52 2018 -0500 Bug 19530: Don't update the date arrived for closed transfers Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart (cherry picked from commit 9a6c8f6c1ebca35161c58b2a57015d1baa60d730) Signed-off-by: Fridolin Somers commit 82010132eb3e4ef2eabd59be2487765d3ea5f63d Author: Mark Tompsett Date: Wed Oct 25 21:28:10 2017 -0400 Bug 19530: Added commentary for last test when prove -v Before patch, prove -v had no comment for the last test. After patch, it says something in line with second last test. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart (cherry picked from commit 3fefcead1596467155ec28a77105e4416f454d8b) Signed-off-by: Fridolin Somers commit f1fc90de9537358db49823e9399b4172702fad83 Author: Kyle M Hall Date: Wed Oct 25 14:24:18 2017 -0400 Bug 19530: Prevent multiple transfers from existing for one item We have found multiple open branch transfers for a given item. While I'm not sure how it is happening at this point, it seems that it would make sense to cancel any existing branch transfers when initiating a new one. Test Plan: 1) prove t/db_dependent/Circulation/transfers.t Signed-off-by: Mark Tompsett Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart (cherry picked from commit 00fbf1878eb2a767769b1405aec4fff1b13711d0) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: C4/Items.pm | 2 ++ t/db_dependent/Circulation/transfers.t | 19 ++++++++++++++++++- 2 files changed, 20 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 12 16:25:45 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 12 Mar 2018 15:25:45 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.09-6-g5eb8bcb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via 5eb8bcb4eafa9fb717f24a34c245025f81d1a85b (commit) from eb005e767e14e3f81e2d052699c4f236d4b0461f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5eb8bcb4eafa9fb717f24a34c245025f81d1a85b Author: Victor Grousset Date: Mon Jan 29 16:09:24 2018 +0100 Bug 20098: Inventory tool: CVS export: fix itemlost column It was mapped with "lost" instead of "itemlost". == Test plan == 1. Have a lost item 2. Go to staff:/cgi-bin/koha/tools/inventory.pl 3. Tick "Optional filters" ? "items.itemlost" ? "name of Authorized values for the lost state" 4. Tick "Export to CSV file" 5. Submit 6. Open the CSV 7. Check that the lost item is in the list 8. You should observe that the "Lost status" column is empty for all items This is the problem 9. Apply this patch 10. Click submit to re-export the CSV 11. Open the CSV 12. Check that the lost item is in the list 13. You should observe that the "Lost status" column now filled with the expected values. 14. Smile because it works! :D Signed-off-by: Mark Tompsett Signed-off-by: Maksim Sen Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens (cherry picked from commit 756c95477d2a16843abbd3858d776e37e28b4e90) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: tools/inventory.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 14 10:08:38 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 14 Mar 2018 09:08:38 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.11.00-782-g48c764b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 48c764bd752c1e692aaea80cf54a09c810db5b9c (commit) via f85f104c3075f097e03eff45c08f51ae7ee5fa11 (commit) from 2201fda6c70442860cd8056326baa144adb912e1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 48c764bd752c1e692aaea80cf54a09c810db5b9c Author: Jonathan Druart Date: Tue Feb 27 15:30:18 2018 -0300 Bug 20286: Fix filter for BakerTaylor* prefs Signed-off-by: Brendan Gallagher Signed-off-by: Julian Maurice Signed-off-by: Nick Clemens commit f85f104c3075f097e03eff45c08f51ae7ee5fa11 Author: Jonathan Druart Date: Mon Feb 26 10:48:18 2018 -0300 Bug 20286: Correctly escape URI characters in OPAC RSS template Bug 19568 use the TT filter url whereas it must have escaped the URI characters with the uri filter. Test plan: Subscribe to an OPAC search => Without this patch you will get an empty page => With this patch applied you will see result list. Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher Signed-off-by: Julian Maurice Signed-off-by: Nick Clemens ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 15 10:28:34 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 15 Mar 2018 09:28:34 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.11.00-794-gbb97767 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via bb97767501a016609743c354b781a0783eb6e66b (commit) via c8f6a351aceabef991a3ee4a8efa9e37b4d246d7 (commit) via 37d6bafcf8b8a1570a0344b9817eb6f95f23ce42 (commit) via a36c1051787e0ebea106081f2ff02cf8a8ebffb4 (commit) via 4e3c60a19295394a5e0c9357504b5efc4228e059 (commit) via 4a90619e583be270dd4e581057a2fc30f48c4537 (commit) via 4f5d525d66f1436fb1a74f4fc9da3a0d17168e75 (commit) via 00374d0741b5c94ccdbbbc36164d4ef099ab3e2c (commit) via d4e444a01db991f54a771bbca1e689f959ac066c (commit) via 6db09ad3b070845539994ff4f1f8b9f7d6d2dfc8 (commit) via f312f83dbc14de6e31e15a36f03d5532f5396a8d (commit) via 184541269307726d7b457ff8beb9637adcd5016b (commit) from 48c764bd752c1e692aaea80cf54a09c810db5b9c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bb97767501a016609743c354b781a0783eb6e66b Author: Josef Moravec Date: Fri Mar 9 06:58:34 2018 +0000 Bug 12812: (Follow-up) Fix use of C4::Circulation Fixes this error: Undefined subroutine &main::MarkIssueReturned called at misc/cronjobs/longoverdue.pl line 316. Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice Signed-off-by: Nick Clemens commit c8f6a351aceabef991a3ee4a8efa9e37b4d246d7 Author: Kyle M Hall Date: Thu Feb 8 06:39:39 2018 -0500 Bug 12812: Longoverdue.pl --mark-returned doesn't return items The longoverdue.pl option --mark-returned doesn't work unless the --charge option is used as well. Test Plan: 1) Run long overdue with --mark-returned and not --charge, note your items are marked lost but not returned 2) Apply this patch 3) Repeat step 1, the items should now get returned! Tested with (for example): misc/cronjobs/longoverdue.pl --lost 10=1 --mark-returned --verbose --confirm Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice Signed-off-by: Nick Clemens commit 37d6bafcf8b8a1570a0344b9817eb6f95f23ce42 Author: Jonathan Druart Date: Tue Feb 27 15:54:38 2018 -0300 Bug 20303: Do not explode when receiving an order if authorisedby not set Signed-off-by: Mark Tompsett Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens commit a36c1051787e0ebea106081f2ff02cf8a8ebffb4 Author: Marcel de Rooy Date: Mon Mar 5 10:27:33 2018 +0100 Bug 19546: (QA follow-up) Make the returning cd more fool proof Trivial and hypothetical fix. If you create /root/AA B (space in dirname), the quotes added here will help you to get back where you came from. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 4e3c60a19295394a5e0c9357504b5efc4228e059 Author: Tomas Cohen Arazi Date: Fri Mar 2 10:36:34 2018 -0300 Bug 19546: Run starman from the instance's home dir This patch makes koha-plack jump into the instance's home directory to run. It is required because Perl 5.18 introduced a breaking change that makes perl die if @INC includes directories for which the user doesn't have read permission, and need to be traversed when querying for a lib. This is the case of '.', which is introduced automatically into @INC until Perl 5.26 (which removes the 'feature'). The Mojolicious::Plugins lib prefixes the plugin names with 'Mojolicious::Plugin' so it first looks (for example) for Mojolicious::Plugin::Koha::REST::Plugin::Pagination (Pagination is just the first one on the list). When it looks for it at '.' it dies (because of Perl's behaviour) so it doesn't query for the right namespace (the following to try). I only reproduced it in koha-testing-docker. To test, you just need to try this patched koha-plack and make sure it doesn't break due to this permissions issue. To test: - In your koha-testing-docker clone, run: $ docker-compose up -p test - Open a shell inside the container (on a separate terminal): $ docker exec -it test_koha_1 bash - From within the /root directory, restart plack: $ cd /root $ koha-plack --restart kohadev => FAIL: Logs show plack is broken due to permissions problems trying to find Mojolicious::Plugin::Koha::REST::Plugin::Pagination - Use the patched script from this patch: $ /kohadevbox/koha/debian/scripts/koha-plack --restart kohadev => SUCCESS: Plack runs fine, no error in the logs - Sign off :-D Note: people who has environments in which the problems is reproducible, please test this version of koha-plack and stamp your sign-off, PLEASE. Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 4a90619e583be270dd4e581057a2fc30f48c4537 Author: Josef Moravec Date: Fri Mar 2 10:13:00 2018 +0000 Bug 20323: Fix batch patron modification tool Test plan: 1) Go to Tools -> Batch patrons modification 2) Select some patrons and try to change any field --> without patch - it exploads with log: Can't call method "category" on unblessed reference at /home/vagrant/kohaclone/tools/modborrowers.pl --> with patch - the modification is properly made Signed-off-by: Roch D'Amour Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 4f5d525d66f1436fb1a74f4fc9da3a0d17168e75 Author: Tomas Cohen Arazi Date: Mon Mar 5 13:36:50 2018 -0300 Bug 20167: Make changing a hold pass the itemnumber to ModReserve If you have an item-level hold, changing an attribute (like priority, pickup location or suspended until date) makes the hold a biblio-level hold, because ModReserve is not passed the current itemnumber. This patch uses the hold's itemnumber and passes it to the ModReserve call. To test: - Run the regression tests from the previous patch: $ kshell k$ prove t/db_dependent/api/v1/holds.t => FAIL: Tests fail - Apply this patch - Run the tests: $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Claire Gravely Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens commit 00374d0741b5c94ccdbbbc36164d4ef099ab3e2c Author: Tomas Cohen Arazi Date: Mon Mar 5 13:35:33 2018 -0300 Bug 20167: Regression test Signed-off-by: Claire Gravely Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens commit d4e444a01db991f54a771bbca1e689f959ac066c Author: Marcel de Rooy Date: Mon Mar 5 11:30:15 2018 +0100 Bug 17717: (QA follow-up) Fix typo chdir This test does obviously not achieve the desired result: [ "chdir" != "no" ] Trivial fix. Adding the same quotes around starting_dir (just as for Bug 19546). Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 6db09ad3b070845539994ff4f1f8b9f7d6d2dfc8 Author: Tomas Cohen Arazi Date: Fri Mar 2 11:51:20 2018 -0300 Bug 17717: Make cronjobs using koha-foreach use --chdir In order to patch production sites we need to adjust the shipped cronjobs so they are called with the --chdir option switch. Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit f312f83dbc14de6e31e15a36f03d5532f5396a8d Author: Tomas Cohen Arazi Date: Fri Mar 2 11:17:40 2018 -0300 Bug 17717: Add a --chdir option switch for koha-foreach Until Perl 5.26, the current directory is added to @INC when running a Perl script [1]. Having the current directory in @INC means it can be tried to be traversed when performing a lib lookup. Since version 5.18, Perl dies when it finds an unreadable directory (permissions) in @INC that needs to be traversed. This behaviour won't change because Perl devs consider it an enhancement to security. [2] Because of this, we need to make sure our scripts are ran **from** a directory in which they have read permissions. Ths patch adds a --chdir option switch to the **koha-foreach** wrapper script, that makes the inner shells/scripts to be ran within the Koha instance's user home directory. The change is trivial and should be QAed easily. I tested this on a prod server: - Create a /tmp/test.pl file containing: use Modern::Perl; use Cwd; my $dir = getcwd; warn $dir; 1; A) then create a cronjob entry to run it using koha-foreach: (in /etc/cron.d/test): 1/* * * * * root koha-foreach perl /tmp/test.pl - Once I noticed the cronjob ran, I used mutt to read the emails in the root user. => FAIL: ... Subject: Cron koha-foreach --enabled perl /tmp/test.pl "/root" "/root" "/root" "/root" "/root" ... B) I then used the patched koha-foreach with different results: => SUCCESS: ... Subject: Cron /root/koha-foreach --chdir --enabled perl /tmp/test.pl "/var/lib/koha/acaderc" "/var/lib/koha/agro" "/var/lib/koha/anc" "/var/lib/koha/arico" "/var/lib/koha/artes" ... So this patch's approach works. But... C) master's koha-foreach seems to work just the same... I think it is because of my previous attempt to fix this by using sudo in koha-shell. So I think environmental conditions affect the behaviour (which shell is configured for cron, sudo configuration, etc). ==== In conclusion, I think we should go ahead with this patch as it will solve peoples issues, and it is a right solution (option #5 on the list) to this Perl behaviour change. It doesn't cover other commands, but followup patches could do. I avoided /tmp as it is writable by any user... so it is an easy path for both exploiting by replacing some lib, and also because the existence of an unreadable dir that the interpreter could try to traverse (unreadable /tmp/Authen or /tmp/Koha will trigger the same error, and I assume people know what they are putting on the instance's dir, at least it will be easier to track). A followup patch takes care of making the cronjobs use --chdir when calling koha-foreach [1] https://lists.debian.org/debian-devel-announce/2016/08/msg00013.html [2] https://rt.perl.org/Public/Bug/Display.html?id=123795 Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 184541269307726d7b457ff8beb9637adcd5016b Author: Jonathan Druart Date: Wed Feb 28 12:57:25 2018 -0300 Bug 20251: (bug 19280 follow-up) FIX SIP checkout Signed-off-by: Colin Campbell Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens ----------------------------------------------------------------------- Summary of changes: C4/SIP/ILS/Patron.pm | 2 -- C4/SIP/ILS/Transaction/Checkout.pm | 9 +++++---- Koha/REST/V1/Hold.pm | 1 + acqui/orderreceive.pl | 8 ++++++-- debian/docs/koha-foreach.xml | 17 +++++++++++++++-- debian/koha-common.cron.d | 2 +- debian/koha-common.cron.daily | 24 ++++++++++++------------ debian/koha-common.cron.hourly | 2 +- debian/koha-common.cron.monthly | 2 +- debian/scripts/koha-foreach | 11 +++++++++++ debian/scripts/koha-plack | 11 ++++++++++- misc/cronjobs/longoverdue.pl | 9 +++++++-- t/db_dependent/api/v1/holds.t | 5 +++-- tools/modborrowers.pl | 3 ++- 14 files changed, 75 insertions(+), 31 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 19 18:05:14 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 Mar 2018 17:05:14 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.11.00-823-g5dc0d1c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 5dc0d1c8bc916ba3acaa6349199f5d9b60ffef8b (commit) via 79f5051ed767bcc50cd2187a57b136eabbb513fb (commit) via c2208e9ca7526f70dc1bf87a8f7fb109b4a269bf (commit) via a674795972907e9562b3e5feb881c1e589c8e40d (commit) via 2a3cc2f98b7d85c1d4f7471be593452c7903ab22 (commit) via e7b004689c901af68d65bda6b36054b4242ef6e9 (commit) via 246746759afd39a4bf67aca9fc944b4659fb740d (commit) via 6d1525dbf1f0783ef90274b1e925e125bededb37 (commit) via c0132ffdcfe759ea16ea6642ce041c6fdde7f9e9 (commit) via 4271f90a06c3fef825e11efe6b53c858a3437f58 (commit) via 84bd0a17cc3401eb9718c30ae74c7898e7116cb3 (commit) via 80d6abf886213d85fad562ceb6be82064fafb640 (commit) via 9f94c8caafa341f395db60dfbfe1645b6885777e (commit) via c53f83afc6cfe49cd5f6424f709ecabb0286a405 (commit) via ceaf74a287f35986115716700de9a32086d33656 (commit) via 8b32870ac016312b1809fca26b4d04b28ea5fcf3 (commit) via 5b2e49141586d0c169de5a67349cd9785836b8e6 (commit) via 70941cde0ec70c4f59ff51abd713594a92cf1e3f (commit) via f0772f0c55a5ffba2b5e26587ba0ea8c91c09c8c (commit) via 73c21c4d30539371bb255346384bfa9f7cd945f8 (commit) via d9ce37ff3e7f351bdf3506e925b1333217743cea (commit) via aea565e71e0cf81933af3a45e9ad6511ba0a96c3 (commit) via f24e48577f478bf6d5132cce2a59febf8d36ce6d (commit) via 6d479dc5e53e3558207c75b73d58bce23328a61d (commit) via dd559df8b9f839b8dcfe765ba0e503a0c65aa3e6 (commit) via a67fdf3bd498bf1c5a90c2847570ea8eff9c52da (commit) via 4159512fc5639cccaf1c563e1bc824f3010d3f6a (commit) via e24e7ad7f17fb957c6747fa76ff79be30769eaa1 (commit) via be4d4a8e28a85f2baf90b03127428cadb551a00e (commit) from bb97767501a016609743c354b781a0783eb6e66b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5dc0d1c8bc916ba3acaa6349199f5d9b60ffef8b Author: Pasi Kallinen Date: Wed Mar 7 09:35:19 2018 +0200 Bug 20347: Add missing classes to search results elements The MARC21 XSLT doesn't add html classes to distinguish between certain elements, and there's no way to rely on the element positioning, making it impossible to style the elements with CSS. Add the missing classes to distinguish the elements. Test plan: 1) Apply patch 2) Search for any biblios 3) Check the search result page table HTML to see that the "Publisher", "Edition", "Source", "Other title", and "Online access" are wrapped in a span with class of results_summary and one of "publisher", "edition", "source", "other_title", and "online_access" 4) Check that the search results of the elements above looks correct when compared to the other elements Signed-off-by: Pasi Kallinen Signed-off-by: Sebastian Hierl Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 79f5051ed767bcc50cd2187a57b136eabbb513fb Author: Julian Maurice Date: Mon Mar 12 11:51:59 2018 +0100 Bug 11936: (QA follow-up) Consistent log message for item insert Fix the same error in another place Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit c2208e9ca7526f70dc1bf87a8f7fb109b4a269bf Author: Magnus Enger Date: Thu Feb 22 10:37:08 2018 +0100 Bug 11936: Consistent log message for item insert If you use bulkmarcimport.pl to import records with items it looks like the successfull insert of the record is reported multiple time, but the second and subsequent "ok" is really related to importing the item(s). This patch changes the log message on successfully inserting an item to match the log message given when inserting an item fails. To test, the easy way: - Look at lines 530 and 536 of bulkmarcimport.pl, and note that the "op" in those two lines are different - Apply the patch - Look at lines 530 and 536 again, and note that the "op" is now identical, and that this makes sense, since they are both related to the same operation, specifically inserting an item To test, the hard way - Have some records with items - Import the records with bulkmarcimport.pl, and make sure to specify the -l option, to create a log of the actions taken - Look at the log and verify it looks something like this: id;operation;status 1;insert;ok 1;insert;ok 2;insert;ok 2;insert;ok - Apply this patch and import some more records with items. The log should now be similar to this: id;operation;status 1;insert;ok 1;insertitem;ok 2;insert;ok 2;insertitem;ok Signed-off-by: Maksim Sen Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit a674795972907e9562b3e5feb881c1e589c8e40d Author: Claire Gravely Date: Tue Mar 13 08:53:29 2018 +0000 Bug 20382: Missing space between patron and cardnumber on check out screen There should be a space between patron name and cardnumber on the check out screen. This patch adds a space between patron and cardnumber. To test: 1 type a patron name into the check out search or go to the check out tab from a patron record 2 Confirm there is no space between patron name and cardnumber on the check out page 3 apply patch 4 confirm there is now a space 5 sign off :) Signed-off-by: Sebastian Hierl Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 2a3cc2f98b7d85c1d4f7471be593452c7903ab22 Author: Pasi Kallinen Date: Wed Feb 14 12:12:52 2018 +0200 Bug 20195: Untranslatable Show/Hide title attr replacement in opac detail There's javascript code in opac detail view that tries to replace the word "Show" with "Hide" (and vice versa) in a title attribute. In addition to those words being untranslatable, a word replacement like that would not work properly when using other languages. Replace the single title attribute with two translatable strings, one for the "Show" case and one "Hide", and use the whole string instead of trying to replace a single word. Test plan: 1) Make sure OpacBrowseResults is on 2) in OPAC, search the catalog and go to the detail view 3) Hover the mouse over the "Browse results" text in the grey box on the right side. The popup text should show something like "Show pagination list (1-5 / 5)" 4) Click on the "Browse results" 5) Hover the mouse again over the text. The popup should show "Hide pagination list (1-5 / 5)" 6) Update a language xx-YY, translate the new msgids "Show pagination list (%s-%s / %s)" and "Hide pagination list (%s-%s / %s)", and install the language 7) Repeat 2-5 with that language, making sure the popup texts show up correctly in that language Signed-off-by: Pasi Kallinen Signed-off-by: Brendan Gallagher Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit e7b004689c901af68d65bda6b36054b4242ef6e9 Author: Owen Leonard Date: Tue Mar 13 10:15:31 2018 +0000 Bug 20383: Hide link to plugin management if plugins are not enabled This patch adds a check in admin-home.pl to see whether plugins are enabled. If plugins are disabled, the link to plugins management is hidden even if the user has plugin management permission. To test, view the administration home page with plugins enabled and disabled via the enable_plugins flag in the Koha configuration file. Also test using users with different plugins permissions: - Plugins enabled - CAN_user_plugins = 1 -> Plugins link appears - CAN_user_plugins = 0 -> Plugins link hidden - Plugins disabled - CAN_user_plugins = 1, - CAN_user_plugins = 0 -> Plugins link hidden Signed-off-by: S?verine QUEUNE Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 246746759afd39a4bf67aca9fc944b4659fb740d Author: Owen Leonard Date: Mon Mar 12 12:56:08 2018 +0000 Bug 20372: Correct toolbar markup on some pages Differences in markup around some toolbars has the potential to create CSS styling problems. This patch changes the markup to be consistent with other instances of
To test, apply the patch and view these pages: - Course reserves (main page) - Course reserves -> Course detail page - Reports -> Dictionary On each of these pages the toolbar should look correct. Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 6d1525dbf1f0783ef90274b1e925e125bededb37 Author: Nick Clemens Date: Thu Mar 1 16:30:35 2018 +0000 Bug 20321: Remove get_biblionumber_from_isbn To test: 1 - grep get_biblionumber_from_isbn 2 - verify all occurences are not actual calls (except for test) 3 - Apply patch 4 - grep get_biblionumber_from_isbn 5 - Verify it is removed Signed-off-by: Roch D'Amour Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart commit c0132ffdcfe759ea16ea6642ce041c6fdde7f9e9 Author: Mark Tompsett Date: Thu Jul 6 18:51:56 2017 +0000 Bug 18908: Warning "Compatibility levels before 9 are deprecated" The following output: dh: Compatibility levels before 9 are deprecated (level 7 in use) dh_testdir -O--fail-missing dh_auto_clean -O--fail-missing dh_auto_clean: Compatibility levels before 9 are deprecated (level 7 in use) dh_clean -O--fail-missing is given when trying to following these instructions: https://wiki.koha-community.org/wiki/Building_Debian_Packages_-_The_Easy_Way This merely tweaks the debian/compat file from 7 to 9. The message goes away. Signed-off-by: Marcel de Rooy From https://www.debian.org/doc/manuals/maint-guide/dother.en.html: You may use compat level v9 in certain circumstances for compatibility with older systems. However, using any level below v9 is not recommended and should be avoided for new packages. Signed-off-by: Jonathan Druart commit 4271f90a06c3fef825e11efe6b53c858a3437f58 Author: Maksim Sen Date: Mon Mar 12 16:15:30 2018 -0400 Bug 20376: Make select/unselect all ignore disabled checkboxes on batch record deletion Test Plan: 0.1 - find at least one biblionumber that has at least one item checked out 0.2 - find at least one biblionumber that has zero items checked out. 1 - Go into the module "Tools > Batch record deletion" 2 - in "List of biblionumbers or authority ids (one per line)" put the values you found in step 0.1 and 0.2 3 - click continue 4 - biblionumbers with at least one item checked out should not be clickable. 5 - biblionumbers with zero items checked out should be clickable. 6 - click "Select all" and "Clear all", both buttons should change the "checked" status of the enabled AND disabled biblionumber checkboxes. 7 - apply patch 8 - click "Select all" and "Clear all", both buttons should change the "checked" status of ONLY the enabled biblionumber checkboxes. Signed-off-by: JM Broust Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 84bd0a17cc3401eb9718c30ae74c7898e7116cb3 Author: Jonathan Druart Date: Thu Feb 15 16:00:20 2018 -0300 Bug 20219: Remove t/smolder_smoke_signal The file is no longer used (is it?) and the project looks dead. Let remove that file. Signed-off-by: Roch D'Amour Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart commit 80d6abf886213d85fad562ceb6be82064fafb640 Author: David Cook Date: Mon Feb 19 10:11:29 2018 +1100 Bug 20173: Fix favicon.ico path in installer This patch corrects the favicon.ico path for the installer. On git installs, it used to point to ./koha-tmpl/favicon.ico, and on regular installs, it probably just didn't work. https://bugs.koha-community.org/show_bug.cgi?id=20173 Signed-off-by: Fridolin Somers Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 9f94c8caafa341f395db60dfbfe1645b6885777e Author: David Cook Date: Mon Feb 12 13:44:50 2018 +1100 Bug 20173: Clean up koha-tmpl directory This patch removes some HTML and ico files that are no longer used in Koha. Signed-off-by: Mark Tompsett Signed-off-by: Fridolin Somers Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit c53f83afc6cfe49cd5f6424f709ecabb0286a405 Author: Owen Leonard Date: Thu Mar 1 15:00:18 2018 +0000 Bug 20268: CSS regression: white gap on the top of the staff pages This patch makes template and CSS changes so that the staff client main page doesn't get an unwanted top margin from the Bootstrap-grid conversion. - The unused "main" class is removed from the login page - The "main" class on the staff client home page is changed to "intranet-main." - The CSS for the staff client home page has been modified accordingly. To test, apply the patch and clear your browser cache if necessary. - Open the staff client login page. It should look as it always does. - Log in and check the style of the main page. There should be no white margin at the top of the page. Signed-off-by: Claire Gravely Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit ceaf74a287f35986115716700de9a32086d33656 Author: Mark Tompsett Date: Tue Oct 31 02:28:58 2017 +0000 Bug 19547: Deal with --create-db missing debian.cnf issue Followed test plan. Patch functions as described and both commands execute. Signed-off-by: Dilan Johnpull? Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 8b32870ac016312b1809fca26b4d04b28ea5fcf3 Author: Mark Tompsett Date: Mon Oct 30 17:59:43 2017 -0400 Bug 19547: MariaDB install has no debian.cnf This attempts to handle issues arising when running koha-create on a system that never had MySQL installed. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 5b2e49141586d0c169de5a67349cd9785836b8e6 Author: Mark Tompsett Date: Fri Mar 9 11:54:16 2018 +0000 Bug 18570: (QA follow-up) Improved POD This tweaks the perldoc for SendQueuedMessages and adds some for _get_unsent_messages. TEST PLAN --------- perldoc C4::Letters -- look at _add_attachments (ugly), _get_unsent_messages (non-existent), SendQueuedMessages (no reference to borrowernumber or letter_code). apply patch perldoc C4::Letters -- confirm that SendQueuedMessages and _get_unsent_messages have reasonable POD information. -- notice how _add_attachments' POD is now readable run koha qa test tools Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit 70941cde0ec70c4f59ff51abd713594a92cf1e3f Author: Mark Tompsett Date: Thu Mar 8 00:15:33 2018 +0000 Bug 18570: Send Password Reset Emails immediately Run through the password reset process, and your server should send the message immediate, not waiting for the cronjob. Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit f0772f0c55a5ffba2b5e26587ba0ea8c91c09c8c Author: Mark Tompsett Date: Thu Mar 8 00:13:09 2018 +0000 Bug 18570: Prove that the letter code parameter tweaks work Run the following commands: kshell prove -v t/db_dependent/Letters.t Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit 73c21c4d30539371bb255346384bfa9f7cd945f8 Author: Mark Tompsett Date: Wed Mar 7 23:59:54 2018 +0000 Bug 18570: Tests to prove if email send was attempted kshell prove -v t/db_dependent/Passwordrecovery.t Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit d9ce37ff3e7f351bdf3506e925b1333217743cea Author: Marcel de Rooy Date: Fri Mar 16 09:02:36 2018 +0100 Bug 20430: (See also bug 19436) Button display depends on wrong server count This is a QA follow-up of bug 19436, submitted separately for ease of backporting it. (The bug was not raised by 19436.) Obviously, the number of authority servers not biblio servers should be the key factor for showing or hiding the button for new authority records via Z39.50/SRU. Trivial fix. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit aea565e71e0cf81933af3a45e9ad6511ba0a96c3 Author: Mark Tompsett Date: Thu Mar 8 03:03:46 2018 +0000 Bug 20097: (follow-up) Add a unit test kshell prove -v t/db_dependent/Record.t Signed-off-by: Mark Tompsett Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart commit f24e48577f478bf6d5132cce2a59febf8d36ce6d Author: Marcel de Rooy Date: Mon Jan 29 10:32:28 2018 +0100 Bug 20097: Use same regex in marc2dcxml and opac-export This regex allows: dc, oaidc, srwdc, and rdfdc. Test plan: [1] Check https://[yourserver]/cgi-bin/koha/opac-export.pl?bib=[some_biblionumber]&op=export&format=dc [2] Check https://[yourserver]/cgi-bin/koha/opac-export.pl?bib=[some_biblionumber]&op=export&format=oaidc [3] Check https://[yourserver]/cgi-bin/koha/opac-export.pl?bib=[some_biblionumber]&op=export&format=nodc. This one should trigger a not-supported message. Signed-off-by: Marcel de Rooy Signed-off-by: Mark Tompsett Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart commit 6d479dc5e53e3558207c75b73d58bce23328a61d Author: Lari Taskula Date: Fri Mar 9 15:49:27 2018 +0200 Bug 20367: Avoid resetting userid when BorrowerUnwantedField contains userid To test: 1. In staff client, set your username to firstname 2. Add userid to BorrowerUnwantedField system preference 3. Go to your patron modification screen (memberentry.pl) and click Save 4. Observe you get kicked out into login screen, saying: Error: You do not have permission to access this page. Log in as a different user 5. Apply patch and restart plack 6. Set your username back to firstname 7. Repeat step 3 8. Observe you were not kicked out and your userid stays the same Signed-off-by: Brendan Gallagher Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit dd559df8b9f839b8dcfe765ba0e503a0c65aa3e6 Author: Jose Martin Date: Wed Mar 7 15:21:39 2018 +0300 Bug 20348: SIP2 patron identification fails to use userid Replaces "or" with "||" in variable assignment second attempt to retrieve borrower was not being executed due to changed precedence Signed-off-by: Colin Campbell Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart commit a67fdf3bd498bf1c5a90c2847570ea8eff9c52da Author: Kyle M Hall Date: Fri Mar 9 06:43:18 2018 -0500 Bug 20341: Use AuthorisedValues plugin on the staff side Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit 4159512fc5639cccaf1c563e1bc824f3010d3f6a Author: Fridolin Somers Date: Tue Mar 6 12:26:19 2018 +0100 Bug 20341: Show authorized value description for withdrawn like damaged and lost Actually catalog detail page shows for damaged and lost items the authorized value description if exists. We must do the same for withdrawn information. Test plan : 1) Set for items a subfield linked to items.withdrawn and using the authorized value category 'WITHDRAWN' 2) Edit the authorized value category to add value '2' and description 'Eaten by dog' 3) Edit an item to set this withdrawn value 4) Go to staff interface and look at items in record detail page /cgi-bin/koh/catalogue/detail.pl : => Without patch you see 'Withdrawn' and with patch you see 'Eaten by dog' 5) Go to OPAc and look at items in record detail page /cgi-bin/koha/opac-detail.pl : => Without patch you see 'Withdrawn' and with patch you see 'Eaten by dog' Signed-off-by: delaye Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit e24e7ad7f17fb957c6747fa76ff79be30769eaa1 Author: Josef Moravec Date: Mon Feb 5 08:25:03 2018 +0000 Bug 19908: Do not use .optional in password match validation function Test plan: 0) Aplly only first patch 1) You will be able to submit a from on member-password.pl even if the passwords don't match 2) Apply this patch -> you can't be able to submit the form if the paswords don't match, but you'll be able to submit the form when password fields are blank Signed-off-by: Roch D'Amour Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit be4d4a8e28a85f2baf90b03127428cadb551a00e Author: Josef Moravec Date: Wed Jan 3 10:56:37 2018 +0000 Bug 19908: Password fields in edit/add patron form should respect BorrowerMandatoryField preference Test plan: 0) Do not apply the patch, note the password field is always required 1) Apply the patch 2) Try to add and edit patron with and without "password" in BorrowerMandatoryField, it should always respect this setting 3) Use "Change password" button in patron toolbar, the password field should be never required here - when leaved blank, the password is unchanged 4) Play with minPasswordLength and RequireStrongPassword preferences, to ensure they work as expected Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/Letters.pm | 63 ++++- C4/Record.pm | 2 +- C4/SIP/ILS/Patron.pm | 2 +- C4/XISBN.pm | 11 - Koha/Patron/Password/Recovery.pm | 7 +- admin/admin-home.pl | 6 + authorities/authorities-home.pl | 2 +- catalogue/detail.pl | 13 +- debian/compat | 2 +- debian/scripts/koha-create | 13 +- koha-tmpl/favicon.ico | Bin 1406 -> 0 bytes koha-tmpl/index.html | 6 - koha-tmpl/intranet-tmpl/prog/css/mainpage.css | 2 +- .../prog/en/includes/installer-doc-head-close.inc | 2 +- .../prog/en/includes/password_check.inc | 2 +- .../prog/en/includes/patron-title.inc | 2 +- .../prog/en/modules/admin/admin-home.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt | 2 +- .../prog/en/modules/catalogue/detail.tt | 25 +- .../en/modules/course_reserves/course-details.tt | 14 +- .../en/modules/course_reserves/course-reserves.tt | 8 +- .../intranet-tmpl/prog/en/modules/intranet-main.tt | 2 +- .../prog/en/modules/members/member-password.tt | 2 - .../prog/en/modules/members/memberentrygen.tt | 2 - .../prog/en/modules/reports/dictionary.tt | 4 +- .../prog/en/modules/tools/batch_delete_records.tt | 4 +- .../prog/en/xslt/MARC21slim2intranetResults.xsl | 12 +- koha-tmpl/intranet.html | 12 - .../bootstrap/en/includes/item-status.inc | 7 +- .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 12 +- koha-tmpl/opac.html | 11 - members/memberentry.pl | 2 +- misc/migration_tools/bulkmarcimport.pl | 4 +- opac/opac-detail.pl | 2 +- opac/opac-export.pl | 2 +- t/db_dependent/Letters.t | 9 +- t/db_dependent/Passwordrecovery.t | 7 +- t/db_dependent/Record.t | 16 +- t/db_dependent/XISBN.t | 9 +- t/smolder_smoke_signal | 279 -------------------- xt/fix-old-fsf-address.exclude | 1 - 41 files changed, 165 insertions(+), 420 deletions(-) delete mode 100644 koha-tmpl/favicon.ico delete mode 100644 koha-tmpl/index.html delete mode 100644 koha-tmpl/intranet.html delete mode 100644 koha-tmpl/opac.html delete mode 100755 t/smolder_smoke_signal hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 19 19:50:02 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 19 Mar 2018 18:50:02 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.11.00-826-g070c327 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 070c327c98ee49a882638be7a5d667b3ec6d4347 (commit) via f128ed7710f1d1fb54df7f076f0810ca4dc3d181 (commit) via 715fc55d28be57112ede6cfd41a101684513aec5 (commit) from 5dc0d1c8bc916ba3acaa6349199f5d9b60ffef8b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 070c327c98ee49a882638be7a5d667b3ec6d4347 Author: Jonathan Druart Date: Mon Mar 19 15:40:09 2018 -0300 Revert "Bug 20341: Use AuthorisedValues plugin on the staff side" This reverts commit a67fdf3bd498bf1c5a90c2847570ea8eff9c52da. I am not sure we already agreed on that: the UI let the ability to choose different AV category for each frameworks. I think it should be discussed widely before removing this possibility. Even if I am pretty sure it is not handle correctly everywhere. Signed-off-by: Jonathan Druart commit f128ed7710f1d1fb54df7f076f0810ca4dc3d181 Author: Jonathan Druart Date: Mon Mar 19 15:38:03 2018 -0300 Bug 7143: Update about page for new dev - Maksim Sen Signed-off-by: Jonathan Druart commit 715fc55d28be57112ede6cfd41a101684513aec5 Author: Jonathan Druart Date: Mon Mar 19 15:36:52 2018 -0300 Bug 7143: Update about page for new dev - Jose Martin Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: catalogue/detail.pl | 15 ++++++++++- docs/history.txt | 2 ++ koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 2 ++ .../prog/en/modules/catalogue/detail.tt | 27 +++++++++++++------- 4 files changed, 36 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 23 12:19:30 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 23 Mar 2018 11:19:30 +0000 Subject: [koha-commits] main Koha release repository branch 17.11.x updated. v17.11.03-14-g7e44bb8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.11.x has been updated via 7e44bb803fa085abdbded2311325f0c442b17708 (commit) via ff2b9b63b46e035caa7b96dbf1b7a4f1435e7c6f (commit) via 4b69178abac156110d5d92342cec045ea1e304a2 (commit) via e854b570021784d8e6ce8bb9d90e0b02d6f8c9a7 (commit) via 705deb2aa4bdadbd583bcf322cf0611303725b05 (commit) via 306b461a6a8e57814367de524dfa3bd22c2f3eca (commit) via d088816f8a833358557454e84bdbf04a0b7f3232 (commit) via f20b91d61b0cfbce6d036b94c08f169bde21bdb2 (commit) via 254684c3ed70f1f07023a9a1ebd8d078dcb633dc (commit) via b671510474fc00e82d5dbec0ff59c92bea7bcb31 (commit) via 802c81ce1afadefd01f9959c3823b2cd7dc3ba3e (commit) via 757c9b4231399ca6082a00b66beca8e59c0b462b (commit) via 241c75575e91643c6eef0d71c5f34151e8b30431 (commit) via 9f075a4fdb2649493820ffed20a352add02c05ea (commit) from 71c81423dd10447e7179e28a5423eb95e15fb416 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7e44bb803fa085abdbded2311325f0c442b17708 Author: Lari Taskula Date: Fri Mar 9 15:49:27 2018 +0200 Bug 20367: Avoid resetting userid when BorrowerUnwantedField contains userid To test: 1. In staff client, set your username to firstname 2. Add userid to BorrowerUnwantedField system preference 3. Go to your patron modification screen (memberentry.pl) and click Save 4. Observe you get kicked out into login screen, saying: Error: You do not have permission to access this page. Log in as a different user 5. Apply patch and restart plack 6. Set your username back to firstname 7. Repeat step 3 8. Observe you were not kicked out and your userid stays the same Signed-off-by: Brendan Gallagher Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens commit ff2b9b63b46e035caa7b96dbf1b7a4f1435e7c6f Author: Jose Martin Date: Wed Mar 7 15:21:39 2018 +0300 Bug 20348: SIP2 patron identification fails to use userid Replaces "or" with "||" in variable assignment second attempt to retrieve borrower was not being executed due to changed precedence Signed-off-by: Colin Campbell Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens commit 4b69178abac156110d5d92342cec045ea1e304a2 Author: Jonathan Druart Date: Tue Feb 27 15:54:38 2018 -0300 Bug 20303: Do not explode when receiving an order if authorisedby not set Signed-off-by: Mark Tompsett Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens Signed-off-by: Nick Clemens commit e854b570021784d8e6ce8bb9d90e0b02d6f8c9a7 Author: Tomas Cohen Arazi Date: Mon Mar 5 13:36:50 2018 -0300 Bug 20167: Make changing a hold pass the itemnumber to ModReserve If you have an item-level hold, changing an attribute (like priority, pickup location or suspended until date) makes the hold a biblio-level hold, because ModReserve is not passed the current itemnumber. This patch uses the hold's itemnumber and passes it to the ModReserve call. To test: - Run the regression tests from the previous patch: $ kshell k$ prove t/db_dependent/api/v1/holds.t => FAIL: Tests fail - Apply this patch - Run the tests: $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Claire Gravely Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens Signed-off-by: Nick Clemens commit 705deb2aa4bdadbd583bcf322cf0611303725b05 Author: Tomas Cohen Arazi Date: Mon Mar 5 13:35:33 2018 -0300 Bug 20167: Regression test Signed-off-by: Claire Gravely Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens Conflicts: t/db_dependent/api/v1/holds.t Signed-off-by: Nick Clemens commit 306b461a6a8e57814367de524dfa3bd22c2f3eca Author: Nick Clemens Date: Fri Feb 16 12:31:39 2018 +0000 Bug 20218: Fix matching of uri in tracklinks The current code matches using a regex, this breaks when the url contains special characters. We swtich it to equality check To test: 1 - Enable TrackClicks (either track or anonymous) 2 - Find the URL of a biblio in the OPAC 3 - Paste this into the 856$u of another record (or use any url containing a '?' or other characters) 4 - View the record in the opac 5 - Click the URL 6 - 404 Error! 7 - Apply patch 8 - Try again 9 - Success! Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens commit d088816f8a833358557454e84bdbf04a0b7f3232 Author: Mark Tompsett Date: Wed Feb 14 20:19:01 2018 +0000 Bug 20201: Silence warnings triggered by admin/aqplan.pl TEST PLAN --------- 0) back up DB 1) Run the following commands on a kohadevbox: reset_all git bz apply 20185 echo | sudo tee /var/log/koha/kohadev/plack-error.log restart_all 2) Navigate in a staff client: Home -> Administration -> Budgets -> Edit -> Planning by libraries -- could be any of the planning, but by libraries is nicely visible on screen. 3) Run the following commands: cat /var/log/koha/kohadev/plack-error.log -- several warnings. 4) Run the following commands: git bz apply 20201 echo | sudo tee /var/log/koha/kohadev/plack-error.log restart_all 5) repeat step 2 and refresh the staff client page. -- this time warnings related to aqplan.pl are not there. 6) run koha qa test tools Signed-off-by: Jonathan Druart Conflicts: admin/aqplan.pl Signed-off-by: Nick Clemens commit f20b91d61b0cfbce6d036b94c08f169bde21bdb2 Author: Jonathan Druart Date: Tue Feb 27 11:40:13 2018 -0300 Bug 19979: ->count can be called directly on Koha::Objects Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens commit 254684c3ed70f1f07023a9a1ebd8d078dcb633dc Author: Marcel de Rooy Date: Tue Jan 16 14:28:36 2018 +0100 Bug 19979: Fix get_facets_info test in Search.t The test should remove the holdingbranch key in the expected results when there is only one branch. See the logic in C4::Koha. Test plan: [1] Run Search.t on a database with multiple branches. [2] Run Search.t on a database with one branch. Without this patch the test would fail: Failed test '_get_facets_info returns the correct data'. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens commit b671510474fc00e82d5dbec0ff59c92bea7bcb31 Author: Jonathan Druart Date: Mon Feb 19 17:40:06 2018 -0300 Bug 20250: (bug 19529 follow-up) Prevent NoIssuesChargeGuarantees.t to fail randomly Signed-off-by: Jonathan Druart Conflicts: t/db_dependent/Circulation/NoIssuesChargeGuarantees.t Signed-off-by: Nick Clemens commit 802c81ce1afadefd01f9959c3823b2cd7dc3ba3e Author: Jonathan Druart Date: Sun Feb 18 15:10:30 2018 -0300 Bug 20148: Prevent adding same user multiple times to an order Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens commit 757c9b4231399ca6082a00b66beca8e59c0b462b Author: Pasi Kallinen Date: Wed Feb 7 09:45:20 2018 +0200 Bug 20148: Prevent adding same user multiple times to acq basket When adding a user to manage acquisitions basket, it is possible to add the same user multiple times. Prevent that. Test plan: 1) Go to Home -> Acquisitions -> [bookseller] -> [basket] 2) On the "Add user" in the Managed by-part, and try adding the same user multiple times. 3) Apply patch 4) Repeat 1 and 2. You should now get an error message saying the user is already in the list. Signed-off-by: Pasi Kallinen Signed-off-by: Roch D'Amour Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Conflicts: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt Signed-off-by: Nick Clemens commit 241c75575e91643c6eef0d71c5f34151e8b30431 Author: Marcel de Rooy Date: Thu Oct 12 13:13:41 2017 +0200 Bug 19452: [17.11.x] Remove the truncate option The truncate option is not really useful. Its result is probably not what most users of this script expect or need. It truncates both tables borrower_message_preferences and borrower_message_transport_preferences. This (unfortunately) includes deleting messaging preferences for patron categories. After that, adding preferences again will not add categories again, but only borrower preferences which are all disabled. Furthermore, we do not need to disable the foreign key check. Neither do we actually need to truncate, deleting records seems sufficient. Also deleting transport preferences is not needed, since it will be done by a cascade from messaging preferences. Note that the subsequent call of SetMessagingPreferencesFromDefaults will already delete the records. This makes it possible to remove the truncate option altogether. Test plan: [1] Select a patron category (say ST) and change days_in_advance to x. [2] Select a ST patron and set days_advance to y in his msg prefs. [3] Run borrowers-force-messaging-defaults.pl -doit [4] Verify that the patron has been reset to the default prefs (incl. value x in days_in_advance). [5] Verify that the patron category prefs are still intact. Signed-off-by: Marcel de Rooy Signed-off-by: Charles Farmer Signed-off-by: Nick Clemens Signed-off-by: Nick Clemens commit 9f075a4fdb2649493820ffed20a352add02c05ea Author: Jonathan Druart Date: Wed Feb 14 15:15:39 2018 -0300 Bug 20145: Do not insert 0000-00-00 in patron tests (and more) We should call Koha::Patron->is_expired in CanBookBeIssued instead of doing the same calculation. Tests have been adapted to pass with new SQL modes. We should not need to update the values in DB, we already have Bug 14717: Prevent 0000-00-00 dates in patron data (3.21.00.023) Test plan: prove t/db_dependent/Circulation/dateexpiry.t prove t/db_dependent/Koha/Patrons.t must return green Signed-off-by: Roch D'Amour Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Conflicts: C4/Circulation.pm t/db_dependent/Koha/Patrons.t Signed-off-by: Nick Clemens ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 11 ++--------- C4/SIP/ILS/Patron.pm | 2 +- C4/Utils/DataTables/Members.pm | 3 ++- Koha/Patron.pm | 4 ++-- Koha/REST/V1/Hold.pm | 1 + acqui/orderreceive.pl | 8 ++++++-- admin/aqplan.pl | 14 +++++++------- .../intranet-tmpl/prog/en/modules/acqui/basket.tt | 2 +- .../prog/en/modules/acqui/neworderempty.tt | 2 +- members/memberentry.pl | 2 +- .../borrowers-force-messaging-defaults.pl | 20 +++----------------- opac/tracklinks.pl | 2 +- .../Circulation/NoIssuesChargeGuarantees.t | 4 ++-- t/db_dependent/Circulation/dateexpiry.t | 4 ++-- t/db_dependent/Koha/Patrons.t | 8 ++------ t/db_dependent/Search.t | 4 ++++ t/db_dependent/api/v1/holds.t | 5 +++-- 17 files changed, 41 insertions(+), 55 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 23 15:39:20 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 23 Mar 2018 14:39:20 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.11.00-827-g450d0e3 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 450d0e3db1ce3d0eefaefc44d88b777f7ab294bc (commit) from 070c327c98ee49a882638be7a5d667b3ec6d4347 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 450d0e3db1ce3d0eefaefc44d88b777f7ab294bc Author: Owen Leonard Date: Fri Mar 23 13:39:45 2018 +0000 Bug 20268: (follow-up) Correct template error The login template must have a class attribute on the body tag in order for the template to pass tests. To test, apply the patch and confirm that the staff client login form still looks the same. For further confirmation you could update the IntranetUserCSS system preference with something like this: .main_main-auth { background-color: #CCF; } The login form should now have a different background color. Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 23 16:43:54 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 23 Mar 2018 15:43:54 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.11.00-873-g88fb04d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 88fb04d180f5251d3c150e31d767616f08796964 (commit) via d9bc1949e9dd544cf791acccbdacf5a595458ef8 (commit) via 6183c0e6a910663fec02bdba66d05f173310f562 (commit) via 3953fdb921d7f280ffbaca813956357aa67d42ca (commit) via 2ebc2aa6e2133594335f445a9fa89dc6266c0579 (commit) via cb336e633bf7e0cb25051a8ed8157af8486a58d7 (commit) via ab46f93df4049ff3ac7bcfcaaf932dc9446c025f (commit) via 58dccaee26181b42ab3a435e4b84786e3a75bcd3 (commit) via dc2339247bbe60e4f23f4d3993b2774648284674 (commit) via bddfed75913a2302c19c00b00a6fe86538af6f9f (commit) via 8b61e7145e7046ea042cfb2e7a4c81c89a924001 (commit) via f3abb1ace539ce7e68e414400d2c6ba2842dd248 (commit) via c5fbda6685fdc6107d57f97a77df9c9c6c0235f6 (commit) via ee5885a17a5e5a5e77a0e7efab7c4feb090e8b53 (commit) via 8f4a0c40c8d32e64c06b10ac4990e31f7fe35fee (commit) via 97b8bd5ebc41c4b1aa6792e190c87e82f9578a48 (commit) via cf0f2d9819e8b11053953b3513c33e51ce979623 (commit) via 6ee8f826f7474023117a4d4f5faa54caf0eef355 (commit) via 5855b015430505568a3e2d9da90e3afa06a5abb8 (commit) via 906c9166a7c63a4086116ce8711610f2448d2ff3 (commit) via d2610f39c7bbdcf086b21f204c21a7167cefe10b (commit) via f1926bda5613edd606d0357695b9a67d20926781 (commit) via e77982ade1254b48493aac28393888509a054846 (commit) via 4297841b98c7f992ef18c400fae2d7d77ae84b9e (commit) via 4a6c8883cc9022ab70459d978267c883062260a4 (commit) via dbc24783eef87520495d4795c9a17a8ab1d4f87a (commit) via 4537ea270b7b717f37b885dd4f715a74802641d2 (commit) via 3441efd1af00f06f8370d332692d8bba2c6be00a (commit) via 567e2ac8874839ec9b2490148c6afeabdfcf591b (commit) via bd29269185cfaea65a0d1eb4ca8003a5b5a984bb (commit) via c40e07d6a6ddead18d6851bb1ee211b0897348db (commit) via f2cf899a90117d63b7706b83af2b8d863b94c767 (commit) via 18e72e31957a51206875ac27d92929909a90ef34 (commit) via d03a4008240380a342ba6d7734c00f699f57902c (commit) via 841d592d3577115296007e254c1444a52fa29289 (commit) via 8627fde517c5c47e38700379ecc8f1c021c0651e (commit) via 11c1829dc306d801502e5b38555b2cf3f6cef9d2 (commit) via 736f8a9205b02c89fe007759d581d23f84c5d09a (commit) via f1c14d25d1bcf1cacb7bdeef3bfc7581f5c830ec (commit) via 3dda23db34b36992d8694858afe1bb29484ced3f (commit) via c55515d2daf1c9ed5fb09e5dc39667f4f39dbd85 (commit) via 84ca0487a05ea7532d68baa7526796cc13d55552 (commit) via 9c0be579fe6ce476ee4809321b63b0f215551fb4 (commit) via b85f8c9e2ad2ea5efa5a9b57df5614f24d8d9fdd (commit) via e8857894bd4fe04b1279c8d65826dda1b064a239 (commit) via 61c9f0c5a08273cec1cead966b754278986f3167 (commit) from 450d0e3db1ce3d0eefaefc44d88b777f7ab294bc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 88fb04d180f5251d3c150e31d767616f08796964 Author: Tomas Cohen Arazi Date: Fri Mar 9 10:51:53 2018 -0300 Bug 19943: Gentle error handling for bookcount.pl This patch tests the required parameters and redirects with a 400 HTTP code if parameters are invalid. It also removes the need for the passed biblioitemnumber which is not used at all. A (now) useless sub is removed too. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit d9bc1949e9dd544cf791acccbdacf5a595458ef8 Author: Jonathan Druart Date: Tue Jan 9 14:38:10 2018 -0300 Bug 19943: Remove C4::Biblio::GetBiblioItemData It is no longer used. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 6183c0e6a910663fec02bdba66d05f173310f562 Author: Jonathan Druart Date: Tue Jan 9 14:37:20 2018 -0300 Bug 19943: Koha::Biblio - Replace GetBiblioItemData with Koha::Biblio->biblioitem The biblioitem's info can be retrieved with Koha::Biblio->biblioitem Test plan: 1. Use the age restriction to restrict checkouts for a given patron 2. Check some items of a biblio out, go to "Items" tab, then "View item's checkout history" link. Compare views with and without patches Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 3953fdb921d7f280ffbaca813956357aa67d42ca Author: Jonathan Druart Date: Tue Jan 9 14:29:50 2018 -0300 Bug 19943: Remove itemtype vs itype confusion in CanBookBeIssued Just a preliminary step to clean the code a bit in CanBookBeIssued. The effective item type is already set from GetItem and we do not need to deal with that again. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 2ebc2aa6e2133594335f445a9fa89dc6266c0579 Author: Jonathan Druart Date: Tue Jan 9 13:58:53 2018 -0300 Bug 19940: Koha::Biblio - Remove GetBiblioItemInfosOf This subroutine is only used once and can be replaced easily with a Koha::Biblioitems->search call Test plan: Test this on top of bug 19941 and confirm that the correct item types are displayed Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit cb336e633bf7e0cb25051a8ed8157af8486a58d7 Author: Jonathan Druart Date: Mon Mar 13 13:04:01 2017 -0300 Bug 18255: Koha::Biblio - Replace GetBiblioItemByBiblioNumber with Koha::Biblio->biblioitem The subroutine GetBiblioItemByBiblioNumber considers that we have a 1-N relation between biblio and biblioitems, which is wrong (it's 1-1). So the calls can be replaced with Koha::biblio->biblioitem, it will ease the read of the code. Test plan: 1. Use the ILSDI service to display info of a bibliographic record, biblioitems fields must be displayed 2. Search for items, biblioitems info must be displayed as well in the result table Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit ab46f93df4049ff3ac7bcfcaaf932dc9446c025f Author: Kyle M Hall Date: Fri Mar 2 06:17:14 2018 -0500 Bug 19933: Fix typo in template plugin name Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart commit 58dccaee26181b42ab3a435e4b84786e3a75bcd3 Author: Kyle M Hall Date: Fri Mar 2 06:08:10 2018 -0500 Bug 19933: Move instantiation of in deletemem.pl Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart commit dc2339247bbe60e4f23f4d3993b2774648284674 Author: Jonathan Druart Date: Fri Mar 2 06:01:38 2018 -0500 Bug 19933: (follow-up) Remove patronflags - easy ones Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart commit bddfed75913a2302c19c00b00a6fe86538af6f9f Author: Jonathan Druart Date: Sun Jan 7 14:57:23 2018 -0300 Bug 19933: Remove patronflags - tricky ones Here we are, patronflags is used in a couple of places where (almost) all flags were really useful: C4::SIP::ILS::Patron->new and circulation.pl This patch only deal with the circulation code as I am not convident enough with SIP code. The change does not seems trivial because of the complexity of the existing code, but the logic is the same. We send a variable to the template depending on the situation of the patron. I guess only code eyes ball could catch issue in this patch quickly. Maybe we need to find a good place in a Koha module to move this code and provide code coverage (especially when C4::SIP::ILS::Patron will reuse it). Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart commit 8b61e7145e7046ea042cfb2e7a4c81c89a924001 Author: Jonathan Druart Date: Sun Jan 7 14:42:00 2018 -0300 Bug 19933: Remove patronflags - easy ones This patch replaces the easy occurrences of patronflags. These calls only need the CHARGES->amount value, that is the non issues charges. Luckily we now have a Koha::Account->non_issues_charges that deal with that. Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart commit f3abb1ace539ce7e68e414400d2c6ba2842dd248 Author: Jonathan Druart Date: Sun Jan 7 13:48:16 2018 -0300 Bug 19933: Remove patronflags - In CanBookBeIssued The change is trivial here, we only want to pass gonenoaddress, lost and is_debared to the template. Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart commit c5fbda6685fdc6107d57f97a77df9c9c6c0235f6 Author: Jonathan Druart Date: Sun Jan 7 14:06:14 2018 -0300 Bug 19933: Remove patronflags - unused vars oldamount/amountold in circulation.pl There is oldamound/amountold variable that is sent to the template but never used later. Let remove it now to avoid useless replacement. Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart commit ee5885a17a5e5a5e77a0e7efab7c4feb090e8b53 Author: Te Rauhina Jackson Date: Thu Jan 18 02:20:11 2018 +0000 Bug 16427: Add direct link to authority records from staff detail view (MARC21 subjects) I added a magnigying glass icon in the staff detail view that links to the authority records. Test Plan: 1) On the Koha staff page, create a new authority. The type of authority will be: Topical Term. 2) When creating authority, in tab 1 under -HEADING--TOPICAL TERM enter the topical term or geographic name entry element and then save the new authority e.g. science. 3) In circulation, search the catalog for a random book. Click the title of the book and you will be taken to the book details. 4) Edit the record and in tab 6, scroll down the - SUBJECT ADDED ENTRY--TOPICAL TERM and repeat this tag (the icon next to the title). 5) Edit the Topical term or geographic name entry element by clicking the button on the right of the bar. 6) In the Search main heading ($a only) enter your topical term e.g. science. 7) Press search, and then in the table that pops up, click 'choose'. 8) Save your edits and the new topical term will be in the 'Subject(s)' list of the book details. 9) Notice that there is no magnifying glass icon. 10) Apply this patch 11) Notice that there is now a magnifying glass icon next to the topical term. 12) Click on the magnifying glass and it will take you directly to the authorities records Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 8f4a0c40c8d32e64c06b10ac4990e31f7fe35fee Author: Owen Leonard Date: Fri Mar 16 10:16:23 2018 +0000 Bug 20432: Add black version of small Koha logo for use in the OPAC This patch adds a black version of the Koha logo for use in OPAC customization. To test, apply the patch and add this CSS to your OPACUserCSS system preference: .navbar-inverse .navbar-inner { background: #CCC none; } #logo { background: transparent url(/opac-tmpl/bootstrap/images/koha-logo-navbar-black.png) no-repeat scroll 0; } Refresh your OPAC and the top navigation bar should be changed from black to grey, and you should see a black version of the Koha logo. Signed-off-by: S?verine QUEUNE Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 97b8bd5ebc41c4b1aa6792e190c87e82f9578a48 Author: Nick Clemens Date: Thu Feb 22 16:46:19 2018 +0000 Bug 20275: Add comment to let user know they can define multiple plugindirs Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit cf0f2d9819e8b11053953b3513c33e51ce979623 Author: Marcel de Rooy Date: Thu Mar 15 14:51:34 2018 +0100 Bug 19929: (QA follow-up) Fix POD Make qa tools happy. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 6ee8f826f7474023117a4d4f5faa54caf0eef355 Author: Nick Clemens Date: Tue Jan 9 11:45:47 2018 +0000 Bug 19929: Add Koha objects for class sources and sorters prove -v t/db_dependent/Koha/ClassSortRules.t prove -v t/db_dependent/Koha/ClassSources.t Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 5855b015430505568a3e2d9da90e3afa06a5abb8 Author: Marcel de Rooy Date: Wed Mar 14 13:22:46 2018 +0100 Bug 19454: (QA follow-up) Fix selection on categorycode A follow-up on a preceding report introduced a join instead of a subquery. This made the categorycode ambiguous. Test plan: See former patches. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 906c9166a7c63a4086116ce8711610f2448d2ff3 Author: Marcel de Rooy Date: Mon Oct 16 13:08:22 2017 +0200 Bug 19454: (follow-up) Add a total line when updating Test plan: [1] Run the script with -doit and -cat [some_category] and verify that the printed total is correct. Signed-off-by: Marcel de Rooy Signed-off-by: Charles Farmer Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit d2610f39c7bbdcf086b21f204c21a7167cefe10b Author: Marcel de Rooy Date: Thu Oct 12 15:36:10 2017 +0200 Bug 19454: Add -category parameter to borrowers-force-messaging-defaults.pl Instead of updating patrons over all patron categories, it would be helpful if we could filter on a specified category. Test plan: [1] Select two patrons A and B in say categories C1 and C2. [2] Change the msg prefs for A and B away from defaults. [3] Run borrowers-force-messaging-defaults.pl -doit -cat C1 Verify that patron A changed and patron B did not. Signed-off-by: Marcel de Rooy Signed-off-by: Charles Farmer Amended: Replace -category by --category. (marcelr 20180314) Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit f1926bda5613edd606d0357695b9a67d20926781 Author: Kyle M Hall Date: Wed Nov 29 15:20:19 2017 -0500 Bug 19716: Add option to send header line for CSV output Currently, if outputting a CSV file using runreport.pl, you need to look at the report used to know what each column means. It would be nice if we could include column headers. Test Plan: 1) Apply this patch 2) Try using runreport.pl with --format csv --csv-header Signed-off-by: David Bourgault Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit e77982ade1254b48493aac28393888509a054846 Author: Kyle M Hall Date: Fri Mar 9 09:51:52 2018 -0500 Bug 18626: Add unit tests Signed-off-by: Jonathan Druart commit 4297841b98c7f992ef18c400fae2d7d77ae84b9e Author: Kyle M Hall Date: Thu May 11 00:44:12 2017 +0000 Bug 18626: Add ability to track cardnumber changes for patrons Some libraries want to keep a history of cardnumber changes for a patron. This is a feature that another ILS has. Test Plan: 1) Apply this patch 2) Enable the BorrowersLog 3) Modify a patron, update his or her cardnumber 4) Notice the entry in the action log containing the old and new cardnumbers 5) Edit a patron, leave the cardnumber the same 6) Note there is no cardnumber change entry in the action logs 7) Disable BorrowersLog, modify a patron cardnumber 8) Note there is no cardnumber change entry in teh action logs Followed test plan, works as expected Signed-off-by: Marc V?ron Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart commit 4a6c8883cc9022ab70459d978267c883062260a4 Author: Kyle M Hall Date: Fri Mar 9 10:49:03 2018 -0500 Bug 17826: Add POD Signed-off-by: Jonathan Druart commit dbc24783eef87520495d4795c9a17a8ab1d4f87a Author: Kyle M Hall Date: Thu Dec 29 15:39:28 2016 +0000 Bug 17826: Allow extended patron attributes to be sent in arbitrary SIP2 fields Some libraries need to be able to send additional patron data from the extended patron attributes in made up SIP2 fields for the patron information and patron status responses. Test Plan: 1) Apply this patch 2) Create 3 new patron attributes with the codes CODE1, CODE2, CODE3. Make a least one repeatable. 3) Create a patron, add those attibutes for the patron, make sure there are at least two instances of the repeatable code 4) Edit your SIP2 config file, add the following within the login stanza: 5) Using the sip cli emulator, run patron_information and patron_status_request messages for the patron 6) Note the values you set for the patron attributes are sent in the corrosponding fields! Signed-off-by: Kyle M Hall Signed-off-by: Daniel Mauchley Signed-off-by: Marcel de Rooy Amended: added parentheses on line 488 when assigning hashref to array. Signed-off-by: Jonathan Druart commit 4537ea270b7b717f37b885dd4f715a74802641d2 Author: Jenny Way Date: Wed Jan 17 20:20:23 2018 +0000 Bug 19856: (follow-up) Improve styling of reports sidebar Added divs to report-menu.inc as well. Should work on any reports page with sidebar now. Signed-off-by: claude Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 3441efd1af00f06f8370d332692d8bba2c6be00a Author: Jenny Way Date: Tue Jan 16 03:24:41 2018 +0000 Bug 19856: Improve styling of reports sidebar Test Plan 1. Open tools page and click on any of the links with a sidebar 2. Note the layout of the sidebar 3. Open reports page and click on any of the links with a sidebar 4. All the sidebars should have the same layout as the tools one Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 567e2ac8874839ec9b2490148c6afeabdfcf591b Author: Jonathan Druart Date: Mon Mar 19 17:18:26 2018 -0300 Bug 20264: DBRev 17.12.00.023 Signed-off-by: Jonathan Druart commit bd29269185cfaea65a0d1eb4ca8003a5b5a984bb Author: Jonathan Druart Date: Wed Feb 21 15:04:01 2018 -0300 Bug 20264: Remove syspref checkdigit According to http://irc.koha-community.org/koha/2013-06-26#i_1333289 http://irc.koha-community.org/koha/2013-06-26#i_1333589 and Hea data, this syspref is no longer in used and is always set to false. Signed-off-by: Dilan Johnpull? Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart commit c40e07d6a6ddead18d6851bb1ee211b0897348db Author: Jonathan Druart Date: Mon Mar 19 17:16:26 2018 -0300 Bug 4078: DBRev 17.12.00.022 Signed-off-by: Jonathan Druart commit f2cf899a90117d63b7706b83af2b8d863b94c767 Author: Jonathan Druart Date: Thu Feb 1 14:35:06 2018 -0300 Bug 4078: Add a new test Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart commit 18e72e31957a51206875ac27d92929909a90ef34 Author: Jonathan Druart Date: Thu Feb 1 14:32:39 2018 -0300 Bug 4078: Add the ability to display and configure the symbol for prices The symbol of currencies are not displayed (or not correctly) so far. This patch set adds the ability to configure the display of the symbol (with or without a whitespace between the symbol and the price). Test plan: 1. Execute the update DB entry, go to the currency admin page and tick the new "Space separation between symbol and value" checkbox 2. Add a fine to a patron and use their credentials to login at the OPAC 3. You should see the "$ 42 due fines and charges" info in the dashboard 4. Untick the new checkbox to remove the space and reload the OPAC main page. => The space should not be longer displayed ($42) Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart commit d03a4008240380a342ba6d7734c00f699f57902c Author: Jonathan Druart Date: Thu Feb 1 14:31:48 2018 -0300 Bug 4078: Pass with_symbol to module The template plugin did not pass the with_symbol flag to the module and so was not taken into account Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart commit 841d592d3577115296007e254c1444a52fa29289 Author: Jonathan Druart Date: Thu Feb 1 14:31:25 2018 -0300 Bug 4078: Add the checkbox to the UI Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart commit 8627fde517c5c47e38700379ecc8f1c021c0651e Author: Jonathan Druart Date: Thu Feb 1 14:30:53 2018 -0300 Bug 4078: Update DB entry - add new column currency.p_sep_by_space Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart commit 11c1829dc306d801502e5b38555b2cf3f6cef9d2 Author: Jonathan Druart Date: Thu Feb 1 14:30:39 2018 -0300 Bug 4078: DBIC Schema changes Signed-off-by: Kyle M Hall Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart commit 736f8a9205b02c89fe007759d581d23f84c5d09a Author: David Bourgault Date: Wed Jan 24 15:52:50 2018 -0500 Bug 17457: Add tests for each marc flavour + Added a `run_flavoured_tests` sub that runs for each MARC flavour * Moved SearchWithISBNVariation tests to the new sub I copied a lot of the necessary utility functions over Biblio.t (as of Jonathan's suggestion). I also tried to name and organize the code in such a way that it can be reused if anyone else needs to run "flavoured" tests in the future. prove t/db_dependant/Acquisition.t OK QA tool green Signed-off-by: Jonathan Druart commit f1c14d25d1bcf1cacb7bdeef3bfc7581f5c830ec Author: David Bourgault Date: Mon Sep 25 16:22:51 2017 -0400 Bug 17457: Adv. Acquisition search with ISBN variations Advanced acquisition search will now follow the "SearchWithISBNVariations" system preference. Test plan : 0) Make sure you have orders pending or completed 1) Enable SearchWithISBNVariations if it is not enabled 2) Search for one of your orders by its ISBN, it should appear 3) Search for the same order by a variation of its ISBN, I used this website to find it : http://www.hahnlibrary.net/libraries/isbncalc.html You should not get a result. 4) Apply patch 5) Repeat step 2-3. You should get a hit both times. 6) prove t/db_dependent/Acquisition.t Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 3dda23db34b36992d8694858afe1bb29484ced3f Author: Kyle M Hall Date: Fri Mar 2 12:36:20 2018 +0000 Bug 19160: Add POD Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit c55515d2daf1c9ed5fb09e5dc39667f4f39dbd85 Author: Kyle M Hall Date: Fri Mar 2 12:32:09 2018 +0000 Bug 19160: Remove tab characters causing qa script to fail Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit 84ca0487a05ea7532d68baa7526796cc13d55552 Author: Ulrich Kleiber Date: Wed Feb 7 10:06:20 2018 +0100 Bug 19160: (follow-up) Fix problems introduced by renaming logout_required to logout_if_required Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit 9c0be579fe6ce476ee4809321b63b0f215551fb4 Author: Jonathan Druart Date: Thu Jan 11 15:43:42 2018 -0300 Bug 19160: Isolate CAS code into its own module Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit b85f8c9e2ad2ea5efa5a9b57df5614f24d8d9fdd Author: Jonathan Druart Date: Thu Jan 11 15:37:18 2018 -0300 Bug 19160: Move the code from controller to C4::Auth_with_cas Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit e8857894bd4fe04b1279c8d65826dda1b064a239 Author: Jonathan Druart Date: Thu Jan 11 15:29:22 2018 -0300 Bug 19160: Move duplicated code to its own private subroutine Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit 61c9f0c5a08273cec1cead966b754278986f3167 Author: Chris Cormack Date: Thu Jun 8 09:38:30 2017 +1200 Bug 19160: CAS Single logout CAS supports single logout, where if you logout of one application it logs you out of all of them. This bug implements this You will need a CAS server (with single logout configure), and at least 2 applications (one being Koha) 1/ In Koha login via CAS 2/ Login to the other application via CAS 3/ Logout of the other application 4/ Notice you are still logged into Koha 5/ Log out of Koha 6/ Apply patch 7/ Login to Koha via CAS, login to other app via CAS 8/ Log out of other app 9/ Notice you are logged out of Koha If you dont have CAS, this patch should be a no op, you could test that 1/ Login and logout normally 2/ Apply patch 3/ Login and logout still work fine Signed-off-by: Katrin Fischer Patch works as described, local login still works correctly. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 25 +++- C4/Auth.pm | 50 +++---- C4/Auth_with_cas.pm | 62 +++++++-- C4/Biblio.pm | 76 ----------- C4/Circulation.pm | 42 +++--- C4/ILSDI/Services.pm | 12 +- C4/Members.pm | 79 ++++------- C4/SIP/ILS/Patron.pm | 60 ++++++++- C4/SIP/Sip/MsgType.pm | 6 + C4/UsageStats.pm | 1 - Koha.pm | 2 +- Koha/{BiblioFramework.pm => ClassSortRule.pm} | 6 +- Koha/{Biblios.pm => ClassSortRules.pm} | 24 ++-- Koha/{CsvProfile.pm => ClassSource.pm} | 8 +- Koha/{Biblios.pm => ClassSources.pm} | 24 ++-- Koha/Number/Price.pm | 8 +- Koha/Schema/Result/Currency.pm | 12 +- Koha/Template/Plugin/Price.pm | 2 +- admin/currency.pl | 3 + catalogue/itemsearch.pl | 5 +- cataloguing/merge.pl | 2 - circ/bookcount.pl | 29 ++-- circ/circulation.pl | 139 +++++++++----------- debian/templates/koha-conf-site.xml.in | 2 +- etc/SIPconfig.xml | 1 + etc/koha-conf.xml | 2 +- installer/data/mysql/kohastructure.sql | 1 + installer/data/mysql/sysprefs.sql | 1 - installer/data/mysql/updatedatabase.pl | 25 ++++ .../prog/en/includes/guided-reports-view.inc | 5 + .../prog/en/includes/reports-menu.inc | 95 ++++++------- .../prog/en/modules/admin/currency.tt | 8 ++ .../prog/en/modules/admin/preferences/patrons.pref | 6 - .../prog/en/modules/catalogue/moredetail.tt | 2 +- .../prog/en/modules/circ/circulation.tt | 7 +- .../en/modules/circ/circulation_batch_checkouts.tt | 4 +- .../prog/en/modules/members/deletemem.tt | 3 +- .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 17 +++ .../bootstrap/images/koha-logo-navbar-black.png | Bin 0 -> 1310 bytes members/deletemem.pl | 12 +- members/member-flags.pl | 1 - misc/cronjobs/delete_patrons.pl | 9 +- misc/cronjobs/runreport.pl | 11 ++ .../borrowers-force-messaging-defaults.pl | 18 ++- opac/opac-user.pl | 4 + reserve/request.pl | 12 +- serials/routing-preview.pl | 3 +- t/Number/Price.t | 15 ++- t/db_dependent/Acquisition.t | 126 +++++++++++++++++- t/db_dependent/Biblio.t | 8 +- t/db_dependent/Koha/ClassSortRules.t | 55 ++++++++ t/db_dependent/Koha/ClassSources.t | 59 +++++++++ t/db_dependent/Koha/Patrons.t | 21 ++- t/db_dependent/SIP/Patron.t | 44 ++++++- t/db_dependent/UsageStats.t | 1 - 55 files changed, 820 insertions(+), 435 deletions(-) copy Koha/{BiblioFramework.pm => ClassSortRule.pm} (87%) copy Koha/{Biblios.pm => ClassSortRules.pm} (75%) copy Koha/{CsvProfile.pm => ClassSource.pm} (84%) copy Koha/{Biblios.pm => ClassSources.pm} (76%) create mode 100644 koha-tmpl/opac-tmpl/bootstrap/images/koha-logo-navbar-black.png create mode 100644 t/db_dependent/Koha/ClassSortRules.t create mode 100644 t/db_dependent/Koha/ClassSources.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 23 17:33:14 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 23 Mar 2018 16:33:14 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.11.00-879-g13ae64d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 13ae64db80e98cf0ac0913fa302aa4499cc56b33 (commit) via ac21d687a13581b80489d0d901f28b80195ed773 (commit) via 07dedc7dbbcf72c2908aa890f67da2d048ade448 (commit) via 7a90a0ca1c62a6de7525844ad57e5903df6039a0 (commit) via f394973124476adcd998340c0aa7a9bae69c2a50 (commit) via fe85f7f674d20d6513fb8db25d0b6a1a908cd1fb (commit) from 88fb04d180f5251d3c150e31d767616f08796964 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 13ae64db80e98cf0ac0913fa302aa4499cc56b33 Author: Jonathan Druart Date: Fri Mar 23 13:22:35 2018 -0300 Bug 19943: Fix Borrower_PrevCheckout.t - create the biblioitem entry Signed-off-by: Jonathan Druart commit ac21d687a13581b80489d0d901f28b80195ed773 Author: Jonathan Druart Date: Fri Mar 23 13:20:49 2018 -0300 Bug 19943: Fix SwitchOnSiteCheckouts.t - create the biblioitem entry Signed-off-by: Jonathan Druart commit 07dedc7dbbcf72c2908aa890f67da2d048ade448 Author: Jonathan Druart Date: Fri Mar 23 13:18:59 2018 -0300 Bug 19943: Fix dateexpiry.t - create the biblioitem entry Signed-off-by: Jonathan Druart commit 7a90a0ca1c62a6de7525844ad57e5903df6039a0 Author: Jonathan Druart Date: Fri Mar 23 13:01:18 2018 -0300 Bug 19943: Fix NoIssuesChargeGuarantees.t - create the biblioitem entry Signed-off-by: Jonathan Druart commit f394973124476adcd998340c0aa7a9bae69c2a50 Author: Jonathan Druart Date: Fri Mar 23 13:13:59 2018 -0300 Bug 4078: Fix test when fr_FR.UTF-8 is installed Signed-off-by: Jonathan Druart commit fe85f7f674d20d6513fb8db25d0b6a1a908cd1fb Author: Jonathan Druart Date: Fri Mar 23 13:13:16 2018 -0300 Bug 20466: Fix fixture syntax in t/Prices.t Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: t/Number/Price.t | 2 +- t/Prices.t | 2 +- t/db_dependent/Circulation/NoIssuesChargeGuarantees.t | 1 + t/db_dependent/Circulation/SwitchOnSiteCheckouts.t | 6 ++++++ t/db_dependent/Circulation/dateexpiry.t | 6 +++--- t/db_dependent/Patron/Borrower_PrevCheckout.t | 3 +++ 6 files changed, 15 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 26 14:48:26 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 26 Mar 2018 12:48:26 +0000 Subject: [koha-commits] main Koha release repository branch 17.11.x updated. v17.11.03-15-g00c9f9b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.11.x has been updated via 00c9f9b0ea0179d8623bf350a7961a8cd75c5348 (commit) from 7e44bb803fa085abdbded2311325f0c442b17708 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 00c9f9b0ea0179d8623bf350a7961a8cd75c5348 Author: Jonathan Druart Date: Fri Mar 23 13:13:16 2018 -0300 Bug 20466: Fix fixture syntax in t/Prices.t Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: t/Prices.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 26 16:48:44 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 26 Mar 2018 14:48:44 +0000 Subject: [koha-commits] main Koha release repository branch 17.11.x updated. v17.11.03-16-g84be52b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.11.x has been updated via 84be52b39f3f2f080fa9be094f0044e70aed6c69 (commit) from 00c9f9b0ea0179d8623bf350a7961a8cd75c5348 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 84be52b39f3f2f080fa9be094f0044e70aed6c69 Author: Colin Campbell Date: Mon Mar 19 10:45:26 2018 +0000 Bug 20446 Revert to using syspref for item creation Using a per-basket setting is nonsensical when baskets are created automatically by quote processing a few lines before this attempts to read it. cron job aborts with a runtime error leaving basket for quote half-created. This reverts to the previous code using the global setting. (Basket itself will have been set to the global setting by default) Signed-off-by: Kyle M Hall Signed-off-by: Nick Clemens ----------------------------------------------------------------------- Summary of changes: Koha/EDI.pm | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 26 17:03:52 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 26 Mar 2018 15:03:52 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.11.00-880-g0d553fa Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 0d553fa72111c9168d07ae218bdcfc31761db631 (commit) from 13ae64db80e98cf0ac0913fa302aa4499cc56b33 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0d553fa72111c9168d07ae218bdcfc31761db631 Author: Mark Tompsett Date: Fri Mar 23 19:25:20 2018 +0000 Bug 18570: Follow up to fix test noise This sets a valid email and changes the tests to expect it was sent. prove t/db_dependent/Passwordrecovery.t -- noise before patch -- no noise after patch Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Passwordrecovery.t | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 26 22:09:46 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 26 Mar 2018 20:09:46 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.11.00-881-g5bdd4c0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 5bdd4c02af25873aed550bd1e312d07fa9b229f0 (commit) from 0d553fa72111c9168d07ae218bdcfc31761db631 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5bdd4c02af25873aed550bd1e312d07fa9b229f0 Author: Jonathan Druart Date: Mon Mar 26 16:55:51 2018 -0300 Bug 18789: (follow-up) Fix place hold page This patch fixes very weird behaviours introduced by commit 0ab22e1c7c6b6e8d14a4fb7478ab2a3d42da347d Bug 18789: Send Koha::Patron object to the templates The patron variable was only set when no action was defined. This patch restores the feature the easiest way possible (less changes) even if it is not the best one. Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: reserve/request.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Mar 26 22:42:53 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 26 Mar 2018 20:42:53 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.11.00-943-g385c161 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 385c16174b4156f59518cdd1de02ee81ba3c03b8 (commit) via 5e93b777fdc59c3b79fae2f9a86a763c7ceb7cdd (commit) via 18fb2f12e70b92de63bd283d7d137ee69aa82a9f (commit) via 011aa89777cd821869ca85e9aca7485550ecf001 (commit) via 95f881b96969dda6156d78fbe59410946f61ca99 (commit) via f9f2d9d86102bd03b72e03b5640ba9f2544c8a86 (commit) via 3c609249390aa37ba09a7fa4f71816456fa2e8ac (commit) via 1f4eb5df7e3c3eb156df176915fcac3a5d34553c (commit) via 42ff67e1732f5cbbaf580214d88f3f287ca34770 (commit) via b809726492aca4118dfdd9171a855cbf6739da84 (commit) via 077fcf3a6be405fc6bac7371f5586d1d696ec287 (commit) via 7ea03cefd6a1612ad60ead35bbac95588ff5723c (commit) via fbfbcae838eacf7684141260e263619dd7869aef (commit) via 0844092693358f873c059e78b51b5e1b6dd83166 (commit) via e42475ca28a56e83a672a618339ffdfacd09036c (commit) via 5e563d81aae7e2e38ecda8ce19381b023130118a (commit) via 3d41b8cce8235446812ec3a7309dd68abd4b86e4 (commit) via 49f50a7f267e7ea105895dc5165965b149697fe3 (commit) via 72061402d9e710de8ae322d46cd1d54702a27019 (commit) via 1c660aef299b8b705e8a31dce91de254195baabe (commit) via 4a9b69ec7adf85194cf6ef4991b1febfef692ede (commit) via 56da3e5705f2f41795a8b3c6a5ba365fe17c4137 (commit) via d6e8e88249914531d8b01f35200de6a8a4692b89 (commit) via 92b29b88c213b7ef6ebbecacc7db896a901880d3 (commit) via 8c5fa90668b2a402cddde3c2f469e3ddb0def63f (commit) via 9bf68c8c3e89bddb23662c9fbd03b7a7514c9955 (commit) via 76853c347ee49e2a8c3f132e0b786db3df987187 (commit) via 6d150eaeca5ba9c9fb3ef2229ce2138526b4db64 (commit) via ef7805aa3657e47daaa266b5334e98a1c1667d5f (commit) via 06424503b7c88bdead7cb7008a6a1aff3ced603e (commit) via dc2ad5fa9da6eecddffad8e47f7ba5f716229232 (commit) via 484d4cbbdd203578062f2dd6e15af788a0f7c1e0 (commit) via 0d614eec694f7aff11a54805c57fab1d4a463f24 (commit) via d239baf0fb331d4f99b10abef8b7085e579eb9ba (commit) via 830b5a7d7dad1d9d1593c14419496e81f7f4b24c (commit) via cd79cf177ee8787b48f1dd81179d5ef60640db4f (commit) via 9eed6c5190818b9ed40bedcb0242be9d8fc34f62 (commit) via 46c4aa3551f810e8d1853f5013a282ce4ee95541 (commit) via f47a999c9f36ed644b811e0f01b7cdcd11d068f9 (commit) via d9dff376ae1294d147af8eca49891128f509af6a (commit) via cc1bfafbd0c2b9e15f1253a7a7719a9ae889bfa2 (commit) via 4680a1e09e4ccf9a9028eb52b98ae0891c16e375 (commit) via abdc75b9a5703714c513e9f7b41e4d4814795d2f (commit) via 6737704c027f1195ed08c69ab395e3cc26806454 (commit) via 98d4ad2704026a39b8872a170c0a129b15b478fa (commit) via ebd523ffd55ba89892986c87bf8cab299d035361 (commit) via 49fd4a2dac3ff8b66fc4ff189d0a557c05e41898 (commit) via 9ef987dacfd28ee7d5e63b12e641e96910604284 (commit) via febb64260bc629105b0b0dc3c77da4b1452d6b8d (commit) via 5c3ead6ecd0641306c65a321d642a392a24dca63 (commit) via d3503e8119fd453241cb6d3824eeda0af0e5ec5e (commit) via 8b0df471e653be6e34b0800eeb7c269530195549 (commit) via 3c3ec562f1330d9b31033ac16d91ca0ab5ae5fbd (commit) via 7465cbac2f2c65d008bcc4870a3bc8d6c5668b71 (commit) via 74ac5baba5a618174aed679256a274dcdef10166 (commit) via 001ce959b625d85d74511b2fe603993a0f3db5d5 (commit) via 4427f90de037e0175383ba2b818f0c85b79c1a32 (commit) via 9007c6e8587196ab05e5727eac1e4bbb6c4ae9e4 (commit) via 1428615dad77f4a9702f287c461d792e908b5dcf (commit) via f3dfd5226d0c077428df797fb8b829ed7f333748 (commit) via 952b2242cfccec7a5cedcc858942f940f80d757b (commit) via 423fa9cc8f9bc1976296a3c5e26845b0c0d24608 (commit) from 5bdd4c02af25873aed550bd1e312d07fa9b229f0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 385c16174b4156f59518cdd1de02ee81ba3c03b8 Author: Tomas Cohen Arazi Date: Sat Feb 17 12:20:09 2018 -0300 Bug 17468: Remove koha-*-zebra scripts and its traces This patch removes traces from the (deprecated) koha-*-zebra scripts. To test: - Apply the patch - Verify no traces of koha-*-zebra remain on the codebase (besides Release Notes and the koha-zebra script): $ cd kohaclone $ git grep koha-start-zebra $ git grep koha-stop-zebra $ git grep koha-restart-zebra => SUCCESS: No traces! - Create the following symlinks: $ sudo ln -s /usr/sbin/koha-zebra /usr/sbin/koha-start-zebra $ sudo ln -s /usr/sbin/koha-zebra /usr/sbin/koha-stop-zebra $ sudo ln -s /usr/sbin/koha-zebra /usr/sbin/koha-restart-zebra - Try the koha-*-zebra commands: $ sudo koha-stop-zebra kohadev $ sudo koha-start-zebra kohadev $ sudo koha-restart-zebra kohadev => SUCCESS: They all work as expected! - Sign off :-D! Sponsored-by: Orex Digital Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit 5e93b777fdc59c3b79fae2f9a86a763c7ceb7cdd Author: Owen Leonard Date: Tue Mar 6 18:48:08 2018 +0000 Bug 20345: Put saved report keyword search form on reports home This patch makes cosmetic changes to the reports home page in the staff client following the pattern set on the Administration home page with the system preferences search box. A reports keyword search form is added, and reports actions have font-awesome icons. To test, apply the patch and view the reports home page. Confirm that all affected links work correctly and that the search form works correctly. Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 18fb2f12e70b92de63bd283d7d137ee69aa82a9f Author: Owen Leonard Date: Fri Jan 19 16:02:46 2018 +0000 Bug 20045: Switch single-column templates to Bootstrap grid: Various This patch updates various unrelated templates to use the Bootstrap grid. - about.tt - The about page - auth.tt - The login page These pages should look correct. - reports/reports-home.tt - The reports home page - admin/admin-home.tt - The administration home page These pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. - serials/subscription-add.tt - Serials -> Add subscription. The entry form should look correct during each step of the add/edit process. - suggestion/suggestion.tt - Acquisitions -> Suggestions -> New suggestion. The page with the new suggestion form should look correct. Signed-off-by: Roch D'Amour Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 011aa89777cd821869ca85e9aca7485550ecf001 Author: Owen Leonard Date: Tue Jan 16 16:55:36 2018 +0000 Bug 19983: Switch single-column templates to Bootstrap grid: Authorities This patch updates several single-column Authorities module templates to use the Bootstrap grid. - authorities-home - The home page of the Authorities module. - authorities.tt - The authority add/edit page. - blinddetail-biblio-search.tt - Not really testable -- It's the small popup window which appears during the process of linking an authority to a MARC record. - detail.tt - The authority detail page. Search for an authority record and click on the "details" link in the search results. - merge.tt - From a list of authority search results, select "Merge" from the Actions menu of two authority records. Test both the initial selection screen and the source/destination merging view. - searchresultlist.tt - The authority search results page. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 95f881b96969dda6156d78fbe59410946f61ca99 Author: Owen Leonard Date: Wed Feb 21 19:40:06 2018 +0000 Bug 19961: Move template JavaScript to the footer: Patron card creator This patch modifies the staff client patron card creator templates so that JavaScript is included in the footer instead of the header. Also changed: Removed "type" attribute from script tags. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, form validation, etc. - Creating and managing layouts - Creating and managing card batches - Creating and managing card templates - Creating and managing printer profiles - Creating and managing images Signed-off-by: Jesse Maseto Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit f9f2d9d86102bd03b72e03b5640ba9f2544c8a86 Author: Owen Leonard Date: Fri Feb 9 13:16:40 2018 +0000 Bug 19946: (follow-up) Add fixed footer to authorities Z39.50 popup This patch adds additional Bootstrap framework markup to the search form so that the "Save" and "Cancel" controls are in a fixed footer at the bottom of the window. This prevents the controls from disappearing down off screen. This patch also adds some whitespace to the "Author (meeting/conference)" label to enable better word wrapping. To test, apply the patch and go to Authorities -> New from Z39.50/SRU. In the popup window, both the search form and search results pages should look correct. Patch applies, form resizes, displays and functions as expected. Signed-off-by: Dilan Johnpull? Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 3c609249390aa37ba09a7fa4f71816456fa2e8ac Author: Owen Leonard Date: Wed Jan 10 16:10:44 2018 +0000 Bug 19946: Update popup window templates to use Bootstrap grid: Authority Z39.50 search This patch updates the authority Z39.50 search template to use the Bootstrap grid instead of the YUI grid. Also fixed: Some capitalization corrections, better handling. This patch does not fix Bug 17119. To test, apply the patch and go to Authorities -> New from Z39.50. In the popup window, both the search form and search results pages should look correct. Signed-off-by: Te Rauhina Jackson <terauhina.jackson at gmail.com> Signed-off-by: Te Rauhina Jackson <terauhina.jackson at gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 1f4eb5df7e3c3eb156df176915fcac3a5d34553c Author: Owen Leonard <oleonard at myacpl.org> Date: Wed Jan 10 17:42:59 2018 +0000 Bug 19949: Update popup window templates to use Bootstrap grid: Cataloging authority search This patch updates the cataloging authority search templates to use the Bootstrap grid instead of the YUI grid. To test you must have a MARC subfield configured with "Thesaurus" linked to an authority type. Apply the patch and go to Cataloging -> New record. Click the plugin link for the field which is linked to authorities. In the popup window, the search form and search results should look correct. Signed-off-by: Zoe Bennett <zoebennett1308 at gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 42ff67e1732f5cbbaf580214d88f3f287ca34770 Author: Owen Leonard <oleonard at myacpl.org> Date: Tue Jan 2 16:29:44 2018 +0000 Bug 19878: Move template JavaScript to the footer: UNIMARC editor plugins, part 7 This patch updates the last of the UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin. From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor. - unimarc_field_210c.tt - unimarc_field_210c_bis.tt - unimarc_field_225a.tt - unimarc_field_225a_bis.tt - unimarc_field_4XX.tt - unimarc_field_700-4.tt - unimarc_leader.tt Signed-off-by: Anne-Claire Bernaudin <anne-claire.bernaudin at univ-rennes1.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit b809726492aca4118dfdd9171a855cbf6739da84 Author: Owen Leonard <oleonard at myacpl.org> Date: Fri Dec 22 16:32:57 2017 +0000 Bug 19877: Move template JavaScript to the footer: UNIMARC editor plugins, part 6 This patch updates more UNIMARC plugin templates than ever before, so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin. From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor. - unimarc_field_128a.tt - unimarc_field_128b.tt - unimarc_field_128c.tt - unimarc_field_130.tt - unimarc_field_135a.tt - unimarc_field_140.tt - unimarc_field_141.tt Signed-off-by: delaye <stephane.delaye at biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 077fcf3a6be405fc6bac7371f5586d1d696ec287 Author: Owen Leonard <oleonard at myacpl.org> Date: Fri Dec 22 14:51:20 2017 +0000 Bug 19874: Move template JavaScript to the footer: UNIMARC editor plugins, part 5 This patch updates yet more UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin. From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor. - unimarc_field_125a.tt - unimarc_field_125b.tt - unimarc_field_126a.tt - unimarc_field_126b.tt - unimarc_field_127.tt Signed-off-by: delaye <stephane.delaye at biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 7ea03cefd6a1612ad60ead35bbac95588ff5723c Author: Owen Leonard <oleonard at myacpl.org> Date: Fri Dec 22 14:12:09 2017 +0000 Bug 19872: Move template JavaScript to the footer: UNIMARC editor plugins, part 4 This patch updates more and more UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin. From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor. - unimarc_field_124a.tt - unimarc_field_124b.tt - unimarc_field_124c.tt - unimarc_field_124d.tt - unimarc_field_124e.tt - unimarc_field_124f.tt - unimarc_field_124g.tt Signed-off-by: delaye <stephane.delaye at biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit fbfbcae838eacf7684141260e263619dd7869aef Author: Owen Leonard <oleonard at myacpl.org> Date: Thu Dec 21 18:20:12 2017 +0000 Bug 19869: Move template JavaScript to the footer: UNIMARC editor plugins, part 3 This patch updates even more UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin. From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor. - unimarc_field_123a.tt - unimarc_field_123d.tt - unimarc_field_123e.tt - unimarc_field_123f.tt - This template has been modified, but doesn't appear to be used. The unimarc_field_1234.pl script uses unimarc_field_123g.tt as its template. - unimarc_field_123g.tt - unimarc_field_123i_j.tt Signed-off-by: Anne-Claire Bernaudin <anne-claire.bernaudin at univ-rennes1.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 0844092693358f873c059e78b51b5e1b6dd83166 Author: Owen Leonard <oleonard at myacpl.org> Date: Thu Dec 21 17:45:09 2017 +0000 Bug 19868: Move template JavaScript to the footer: UNIMARC editor plugins, part 2 This patch updates several more UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin. From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor. - unimarc_field_116.tt - unimarc_field_117.tt - unimarc_field_120.tt - unimarc_field_121a.tt - unimarc_field_121b.tt - unimarc_field_122.tt Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit e42475ca28a56e83a672a618339ffdfacd09036c Author: Owen Leonard <oleonard at myacpl.org> Date: Thu Dec 21 16:30:05 2017 +0000 Bug 19866: Move template JavaScript to the footer: UNIMARC editor plugins, part 1 This patch updates several UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin. From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor. - unimarc_field_100.tt - unimarc_field_100_authorities.tt - unimarc_field_105.tt - unimarc_field_106.tt - unimarc_field_110.tt - unimarc_field_115a.tt - unimarc_field_115b.tt Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 5e563d81aae7e2e38ecda8ce19381b023130118a Author: Owen Leonard <oleonard at myacpl.org> Date: Tue Feb 20 14:19:31 2018 +0000 Bug 19786: (follow-up) Correct js include path, popup window size This follow-up adds the required KOHA_VERSION variable to two templates where it was missing. This patch also adds a 'window_size' parameter to a popup window function so that self-closing windows like blinddetail-biblio-search.pl can appear small and others at a reasonable size. To test, apply the patch and clear your browser cache if necessary. - Confirm that the QA tools do not complain about missing KOHA_VERSION in auth_finder.tt and searchresultlist_auth.tt. - Open a bibliographic record for editing in the basic editor using a framework in which a field is linked to authorities. - Trigger the authority selection window for that field. - Click the "Clear field" button at the top of the authority search pop-up window. Another smaller popup window should briefly appear, and then both windows should close. - Trigger the authority selection window again. - Click the "Create new authority" button. A new window should appear with the MARC authority editor. The window should be a usable size. Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 3d41b8cce8235446812ec3a7309dd68abd4b86e4 Author: Owen Leonard <oleonard at myacpl.org> Date: Fri Dec 8 19:57:28 2017 +0000 Bug 19786: Move template JavaScript to the footer: Authorities, part 2 This patch modifies the staff client patron lists templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of each modified template. I've made one change to the JavaScript in addition to moving it: I've made it so that the blank window which pops up briefly in this process is 100px x 100px instead of full screen. - Cataloging -> Add or edit bibliographic record in a framework which has authorities linked to a tag -> Click authorities plugin link -> Create new authority button -> Autocomplete on text inputs (except "Search all headings") -> Search -> Select authority record ("choose") -> Click authorities plugin link again -> Clear field Signed-off-by: Claire Gravely <claire_gravely at hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 49f50a7f267e7ea105895dc5165965b149697fe3 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Mon Mar 26 17:29:52 2018 -0300 Bug 15492: DBRev 17.12.00.024 Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 72061402d9e710de8ae322d46cd1d54702a27019 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Mon Mar 19 16:31:52 2018 -0300 Bug 15492: (QA followup) Make page refresh work correctly Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 1c660aef299b8b705e8a31dce91de254195baabe Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Wed Feb 21 17:11:59 2018 -0300 Bug 15492: Add KOHA_VERSION to included .css and .js Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 4a9b69ec7adf85194cf6ef4991b1febfef692ede Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Wed Dec 27 12:45:16 2017 -0300 Bug 15492: Display nicer message on data corruption This patch hides scary messages and changes the wording for a more idiomatic approach. Thanks to Nick :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 56da3e5705f2f41795a8b3c6a5ba365fe17c4137 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Wed Dec 27 12:32:11 2017 -0300 Bug 15492: Make SCI use its own sysprefs and CSS file Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit d6e8e88249914531d8b01f35200de6a8a4692b89 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Wed Dec 27 12:29:29 2017 -0300 Bug 15492: Make existing code aware of new self_check* permissions This patch makes the existing code for SCO use the new permissions schema for self check modules. Specifically addresses this change: circulate => self_checkout becomes slef_check => self_checkout_module about.pl checks are dejusted too. get_template_and_user gets refactored to avoid code duplication and the conditions are adjusted for the new permissions. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 92b29b88c213b7ef6ebbecacc7db896a901880d3 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Wed Dec 27 12:24:36 2017 -0300 Bug 15492: New sysprefs and permissions In order to make this module unrelated to the SCO module, this patch introduces the following sysprefs: - SelfCheckInMainUserBlock - SelfCheckInModuleUserID - SelfCheckInTimeout - SelfCheckInUserCSS - SelfCheckInUserJS It also adds a new user flag and sub-permission: - self_check => self_checkin_module and moves the circulate => self_checkout permission into - self_check => self_checkout_module Descriptions are adjusted accordingly. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 8c5fa90668b2a402cddde3c2f469e3ddb0def63f Author: Kyle M Hall <kyle at bywatersolutions.com> Date: Thu Dec 21 12:59:13 2017 -0500 Bug 15492: (QA follow-up) Reset SCI if idle for 30 seconds Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 9bf68c8c3e89bddb23662c9fbd03b7a7514c9955 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Fri Nov 10 15:32:43 2017 -0300 Bug 15492: Add SCI module This patch adds the SCI module, and adapts C4::Auth to know about it. The current behaviour is: - Requires admin user initialization/login - Uses the logged users' library - A form allows to scan multiple barcodes - A button sends the barcode list to the controller to batch perform the checkins - Successful and failed checkins are sent to the template - Results are displayed - Logout link To test: - Apply this patches - Make sure you upgrade: $ kshell k$ perl installer/data/mysql/updatedatabase.pl - Have 'SelfCheckInModule' disabled - Go to http://kohadev.myDNSname.org:8080/cgi-bin/koha/sci/sci-main.pl [1] => SUCCESS: You are rejected because the feature is disabled - Enable 'SelfCheckInModule' - Go to the previous URL => SUCCESS: You are required to login - Login with a user WITHOUT self_checkout permissions => SUCCESS: You are not allowed to log into the Self check-in module. - Login with a user WITH self_checkour permissions => SUCCESS: You gain access, and are presented the UI - Go through the several options => SUCCESS: All works as it should - Click the 'Help' link => SUCCESS: A help text is displayed on a modal - Sign off :-D - Bonus points: $ kshell k$ qa -c 2 -v 2 => SUCCESS: All tests green [1] Adjust to your dev's OPAC setup Signed-off-by: David Bourgault <david.bourgault at inlibro.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 76853c347ee49e2a8c3f132e0b786db3df987187 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Fri Nov 10 15:12:56 2017 -0300 Bug 15492: Add the SelfCheckInModule syspref Signed-off-by: David Bourgault <david.bourgault at inlibro.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 6d150eaeca5ba9c9fb3ef2229ce2138526b4db64 Author: Nick Clemens <nick at bywatersolutions.com> Date: Tue Jan 23 20:21:57 2018 +0000 Bug 20081: Set inline headers for uploaded pdfs To test: 1 - Edit a framework and add the 'upload/pl' plugin to the 856 field 2 - Attach a pdf to one record 3 - Attach a different type of file to another (To attach, edit a record in the framework edited above and find the helper by the 856 field) 4 - Click the links on the record 5 - Verify the pdf opens inline 6 - Verify the other file does not 7 - prove t/db_dependent/Upload.t Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit ef7805aa3657e47daaa266b5334e98a1c1667d5f Author: Nick Clemens <nick at bywatersolutions.com> Date: Thu Jan 11 18:19:33 2018 +0000 Bug 19957: Allow continued editing of report after saving To test: 1 - Edit or create a report 2 - Save it 3 - Note the report is saved but you can't keep editing 4 - Clicking 'Edit' returns you to editing 5 - Apply patch 6 - Save report 7 - Note success message remains, but report is still open for editing 8 - Note when you click the saved/updated message dissappears 9 - Try again after inserting erros into report (No Select, bad authorised value, etc.) 10 - Note errors stil display as expected 11 - Verify message works on update of existing report and save of new new report Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Charles Farmer <charles.farmer at inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Joubu: amended patch to fix alignment Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 06424503b7c88bdead7cb7008a6a1aff3ced603e Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Mon Mar 26 17:10:26 2018 -0300 Bug 18797: Create the biblioitem entry We need that since bug 19943 Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit dc2ad5fa9da6eecddffad8e47f7ba5f716229232 Author: Mark Tompsett <mtompset at hotmail.com> Date: Sat Mar 17 02:24:41 2018 +0000 Bug 18797: Make rollingloans test useful TEST PLAN --------- 1) Run the following commands on a kohadevbox: kshell prove -v t/db_dependent/rollingloans.t exit -- all the tests were skipped, not useful! 2) Apply this patch 3) Redo step 1 -- all the tests run 4) Run qa test tools Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 484d4cbbdd203578062f2dd6e15af788a0f7c1e0 Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Date: Tue Nov 7 15:29:56 2017 +0100 Bug 19584: Check compare barcodes box when uploading barcodes This patch makes two trivial changes in the inventory interface: [1] If you have uploaded a barcode file, the compare barcodes checkbox is automatically checked. In most cases this will be the option the user wants. The compare will report missed items on the shelf. [2] If the compare barcodes checkbox is checked, the Skip items on loan- checkbox is automatically checked. This again is often desirable. If you compare, you normally are not interested in seeing items reported missing while they are checked out. Test plan: [1] Upload a barcode file on inventory. Is the compare checked? [2] Toggle compare. Does 'skip items on loan' change accordingly? Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Grace Smyth <gracesmythh at gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 0d614eec694f7aff11a54805c57fab1d4a463f24 Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Date: Tue Nov 7 15:07:42 2017 +0100 Bug 19584: Replace label Status by Not for loan Status does not tell me that this is the Not for loan column. Trivial edit. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Grace Smyth <gracesmythh at gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit d239baf0fb331d4f99b10abef8b7085e579eb9ba Author: Charles Farmer <charles at inlibro.com> Date: Fri Jan 19 16:04:19 2018 -0500 Bug 19955: Minor grammatical correction Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 830b5a7d7dad1d9d1593c14419496e81f7f4b24c Author: Kyle M Hall <kyle at bywatetsolutions.com> Date: Thu Jan 11 13:00:31 2018 -0500 Bug 19955: Add ability to process only one 'type' of message ( sms, email, etc ) for a given run of process_message_queue.pl It would be nice to allow emails to be sent overnight, but limit the sending of SMS messages to hours when people are awake. Adding a type limit to process_message_queue.pl would allow this to be accomplished easily. Signed-off-by: Charles Farmer <charles.farmer at inLibro.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit cd79cf177ee8787b48f1dd81179d5ef60640db4f Author: Julian Maurice <julian.maurice at biblibre.com> Date: Thu Feb 22 10:51:27 2018 +0100 Bug 20267: Add basic .gitignore Ignore files generated by ExtUtils::MakeMaker NOTE: Limited scope does not affect files created by translation utilities Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 9eed6c5190818b9ed40bedcb0242be9d8fc34f62 Author: David Bourgault <david.bourgault at inlibro.com> Date: Tue Nov 28 11:23:01 2017 -0500 Bug 19708: Improve code for printing the cart in OPAC This removes a lot of useless code relating to the print function from opac-basket.tt, opac-basket.pl and opac/basket.js. It also fixes the CSS so that no extra blank page is printed. To test: 0) Add an item to your cart 1) Print your basket Note the appearance of the page. There will be an extra blank page. 2) Apply patch 3) Reload basket 4) Print your basket The appearce should be identical. The extra blank page is gone. This only affects the OPAC. Signed-off-by: Tom?s Cohen Arazi <tomascohen at theke.io> Signed-off-by: claude <claude.brayer at cea.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 46c4aa3551f810e8d1853f5013a282ce4ee95541 Author: Pasi Kallinen <pasi.kallinen at joensuu.fi> Date: Mon Mar 12 13:20:06 2018 +0200 Bug 12020: Allow translating label-edit-batch hardcoded strings Move the hardcoded error strings in the batch label edit into the template, so they can be translated. Test plan: 1) Apply patch 2) Go to Home -> Tools -> Label edit 3) Create a new batch with some items in it 4) Try to trigger any of the errors, check that the error messages look correct 5) Update a language xx-YY 5) Check that the error messages show up in xx-YY-staff-prog.po Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi> Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Changed branch to library in one of the error messages. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit f47a999c9f36ed644b811e0f01b7cdcd11d068f9 Author: Owen Leonard <oleonard at myacpl.org> Date: Fri Mar 16 10:30:30 2018 +0000 Bug 20433: Remove unused Mozilla Persona image file This patch removes an unused image file from the OPAC which was added when we added Mozilla Persona authentication but wasn't removed when Mozilla Persona went away. To test, apply the patch and confirm that the image no longer exists: koha-tmpl/opac-tmpl/bootstrap/images/sign_in_green.png Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit d9dff376ae1294d147af8eca49891128f509af6a Author: Victor Grousset <victor.grousset at biblibre.com> Date: Wed Feb 14 11:25:34 2018 +0100 Bug 20111: i18nize units in Patron card creator Test plan: 1. install and switch to the fr_FR locale or another one and adapt the test plan accordingly 2. go to /cgi-bin/koha/patroncards/edit-template.pl?op=new 3. then you should see the "Unit?s" dropdown with english units 4. apply this patch 5. install the language 6. refresh the page 7. then you should see the "Unit?s" dropdown with french units Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit cc1bfafbd0c2b9e15f1253a7a7719a9ae889bfa2 Author: Victor Grousset <victor.grousset at biblibre.com> Date: Tue Feb 13 14:27:23 2018 +0100 Bug 20111: Coding style: Fix indentation before doing actual change Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 4680a1e09e4ccf9a9028eb52b98ae0891c16e375 Author: Victor Grousset <victor.grousset at biblibre.com> Date: Mon Mar 5 11:47:25 2018 +0100 Bug 19522: i18n Label creator: wrap text with <span> In a SWITCH CASE. To avoid pollution and duplication in the .po files. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit abdc75b9a5703714c513e9f7b41e4d4814795d2f Author: Victor Grousset <victor.grousset at biblibre.com> Date: Fri Mar 2 14:00:04 2018 +0100 Bug 19522: Label creator: Batches: make "Export Labels" translatable Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 6737704c027f1195ed08c69ab395e3cc26806454 Author: Victor Grousset <victor.grousset at biblibre.com> Date: Fri Oct 27 15:24:52 2017 +0200 Bug 19522: Label creator: edit batch: make "Export label" translatable Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch 3. create a batch if there is none 4. edit that batch 5. Switch the language to French if you haven't done it yet 6. click on "Exporter le lot entier" 7. then you should see "Export labels" 8. apply this patch 9. install the language 10. replay steps 2 to 6 11. then you should see "Exporter des ?tiquettes" Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 98d4ad2704026a39b8872a170c0a129b15b478fa Author: Victor Grousset <victor.grousset at biblibre.com> Date: Fri Oct 27 11:51:21 2017 +0200 Bug 19522: Label creator: edit batch: make Call number translatable Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch 3. create a batch if there is none 4. edit that batch 5. then you should see "Call number" in the column names 6. apply this patch 7. install the fr_FR locale 8. refresh the page 9. then you should see "Cote" in the column names Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit ebd523ffd55ba89892986c87bf8cab299d035361 Author: Victor Grousset <victor.grousset at biblibre.com> Date: Thu Oct 26 15:56:54 2017 +0200 Bug 19522: Label creator: translate empty list message The name of the element wasn't translated in the message. Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch 3. ensure that the list is empty 4. then you should see "pas de Batches actuellement" 5. then you should see "cr?er un nouveau batch." 6. apply this patch 7. install the language 8. refresh the page 9. then you should see "pas de Lots actuellement" 10. then you should see "cr?er un nouveau lot ." Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 49fd4a2dac3ff8b66fc4ff189d0a557c05e41898 Author: Victor Grousset <victor.grousset at biblibre.com> Date: Wed Oct 25 17:17:21 2017 +0200 Bug 19522: Coding style: Replace tabs with spaces In Label creator: Templates: new/edit form Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 9ef987dacfd28ee7d5e63b12e641e96910604284 Author: Victor Grousset <victor.grousset at biblibre.com> Date: Wed Oct 25 15:22:11 2017 +0200 Bug 19522: Label creator - some strings are not translatable Templates: new form: Add hardcoded unit names to make them translatable. Test plan: 1. install the fr_FR locale 2. go to /cgi-bin/koha/labels/label-edit-template.pl?op=new 3. then you should see the "Unit?s" dropdown with english units 4. apply this patch 5. install the language 6. refresh the page 7. then you should see the "Unit?s" dropdown with french units Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit febb64260bc629105b0b0dc3c77da4b1452d6b8d Author: Victor Grousset <victor.grousset at biblibre.com> Date: Wed Oct 25 12:07:43 2017 +0200 Bug 19522: Coding style: Fix alignement after previous patch Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 5c3ead6ecd0641306c65a321d642a392a24dca63 Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Date: Thu Mar 15 12:37:11 2018 +0100 Bug 20422: Fix warning on uri_escape_utf8 in Output.pm When opac-details calls parametrized_url, it triggers an uninitialized warning when you would have a record without e.g. author, like: Use of uninitialized value in subroutine entry at /usr/share/perl5/URI/Escape.pm line 184. This is (imo) actually a bug in URI::Escape; it should check its args. But we resolve the warning here by adding the "// q{}" in parametrized_url. NOTE: Along the way we do something similar in the arrParamsBusc loop. If the variable is undefined, jump to the next one. (Consistent with the approach in the if-part preceding it.) Test plan: [1] Run t/Output.t again. Should pass now. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit d3503e8119fd453241cb6d3824eeda0af0e5ec5e Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Date: Thu Mar 15 14:07:11 2018 +0100 Bug 20422: Add unit test to Output.t for parametrized_url This test will reveal that we need to resolve a warning too. Test plan: [1] Run t/Output.t without the second patch. [2] The test will fail on the warning raised by an undefined value. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 8b0df471e653be6e34b0800eeb7c269530195549 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Wed Feb 28 14:26:06 2018 -0300 Bug 20298: Fix SMS characters counter when TranslateNotices is set If you have multiple languages installed, the notices and slips page uses the same HTML id multiple times, once for each language. This prevents eg. the SMS character count javascript from working, because each of the textareas has the same id. Test plan: Test the sms characters counter, with and without TranslateNotices Make sure other features on this page still work correctly QA: Make sure this change of id did not break something else. Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 3c3ec562f1330d9b31033ac16d91ca0ab5ae5fbd Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Sat Feb 17 18:48:50 2018 -0300 Bug 19467: Display description instead of code for itemtype and location On reports/itemslost.pl you must now see the descriptions instead of the code for itemtype and location Signed-off-by: delaye <stephane.delaye at biblibre.com> Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 7465cbac2f2c65d008bcc4870a3bc8d6c5668b71 Author: Victor Grousset <victor.grousset at biblibre.com> Date: Thu Mar 22 15:44:00 2018 +0100 Bug 20461: Serials: fix ignored params in subscription creation form In subscription-add.pl, the two params aren't passed to NewSubscription() but they are to ModSubscription() == Test plan == 1. Enable syspref "makePreviousSerialAvailable" 2. Create a minimal subscription with a value in the "Item type" and "item type for older issues" fields. 3. Edit the subscription 4. You should see that the two fields are empty. This is the bug. 5. Apply this patch 6. Do step 2 and 3 7. You should see that the two fields have the right value 8. Express the joy of a successful and easy sign off. (this is important, otherwise the sign off spell won't work!) Signed-off-by: delaye <stephane.delaye at biblibre.com> Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 74ac5baba5a618174aed679256a274dcdef10166 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Fri Mar 16 15:18:15 2018 -0300 Bug 20438: Allow uninstalling plugins not implementing the 'uninstall' method The plugins handling code expects plugins implementing an 'uninstall' method for cleanup purposes. It executes this method, and then moves on with removing the configuration entries in the storage, and the plugin itself. But the 'plugins-home.tt' template makes the tool display the 'Uninstall' link in the dropdown ONLY when the plugin has the 'uninstall' method. This patch fixes the issue. To reproduce: - Install the KitchenSink plugin [1] => SUCCESS: The 'actions' dropdown for KitchenSink shows an 'Uninstall' option - Edit the code for the plugin: $ sudo vim /var/lib/koha/kohadev/plugins/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm - Remove the uninstall sub - Restart everything: $ restart_all - Reload the browser => FAIL: There's no 'Uninstall' option in the actions dropdown. - Apply this patch - Restart everything $ restart_all - Reload the browser => SUCCESS: The 'actions' dropdown for KitchenSink shows an 'Uninstall' option - Sign off :-D [1] https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 001ce959b625d85d74511b2fe603993a0f3db5d5 Author: Owen Leonard <oleonard at myacpl.org> Date: Thu Mar 15 10:34:26 2018 +0000 Bug 20420: Remove unnecessary [% KOHA_VERSION %] from OPAC third-party sources This patch removes [% KOHA_VERSION %] from the <script> tag for some third-party JavaScript sources. [% KOHA_VERSION %] should only be used for Koha's JS resources. To test, apply the patch and enable the SocialNetworks and NovelistSelect* preferences. In the OPAC, view the detail page for a bibliographic record. In the right-hand sidebar you should see social network icons for Google+ and Twitter. Clicking either of them should trigger a sharing popup window. If you have Novelist credentials and can enable the feature for the OPAC you should see Novelist content in the place specified in your preferences. If you don't have Novelist credentials, put some random text in the NovelistSelectProfile system preference. Looking at the detail page in the OPAC, view source. You should see a link to Novelist JS around line 1020 of the source. Clicking the link should show JavaScript. This confirms that the path is correct, thus the bug has been fixed. Note: The QA tool will complain that [% KOHA_VERSION %] is missing. This is a false positive. Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 4427f90de037e0175383ba2b818f0c85b79c1a32 Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Date: Thu Mar 22 10:36:00 2018 +0100 Bug 20459: Correct message for cancelling an article request We should not ask for 'cancel this hold'. Remove corresponding TODO. Fix qa warning on old bootstrap style: btn btn-mini => btn btn-default btn-xs I removed above change, qa tool complaint is wrong (refers to staff, we are on opac) Test plan: Create an article request and cancel it on opac-user. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 9007c6e8587196ab05e5727eac1e4bbb6c4ae9e4 Author: Katrin Fischer <katrin.fischer.83 at web.de> Date: Fri Feb 23 14:29:48 2018 +0100 Bug 20067: Fix other checks for linked authorised value categories The same pattern was used in other files, this patch fixes it. Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 1428615dad77f4a9702f287c461d792e908b5dcf Author: Katrin Fischer <katrin.fischer.83 at web.de> Date: Fri Feb 23 14:20:17 2018 +0100 Bug 20067: Fix false display of authorised value for materials on staff detail page Koha didn't check for a linked authorised value category for Koha didn't check for a linked authorised value category for items.materials correctly which led to displaying false information on the detail page. To test: - before applying the patch: - make sure sample data and configuration is loaded - edit any item - write 2 in the $3 materials specificed - check the details page normal view - it will display 'restocking' - apply patch - check display, it should now show "2" - link 952$3 (MARC21) to ORDER_CANCELLATION_REASON - check display again, it should now show 'restocking' Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit f3dfd5226d0c077428df797fb8b829ed7f333748 Author: Fridolin Somers <fridolin.somers at biblibre.com> Date: Wed Jan 24 14:23:30 2018 +0100 Bug 20085: Better translatability of smart-rules.tt Template smart-rules.tt in administration contains some if/elsif/else with translatable strings. For example : [% IF rule.onshelfholds == 1 %] Yes [% ELSIF rule.onshelfholds == 2 %] If all unavailable [% ELSE %] If any unavailable [% END %] Adding span to translatable strings will allow to have the same translation than : <select name="onshelfholds" id="onshelfholds"> <option value="1">Yes</option> <option value="0">If any unavailable</option> <option value="2">If all unavailable</option> </select> This is important to allow editing an existing circulation and fine rule. Actually for example in french some strings are translated differently : msgid "%s Yes %s If all unavailable %s If any unavailable %s" msgstr "%s Oui %s Si tous indisponibles %s Si aucun indisponible %s" msgid "If any unavailable" msgstr "Si au moins un exemplaire est indisponible" Test plan : 1) Look at PO files, for example fr-FR and see there is : msgid "%s Yes %s If all unavailable %s If any unavailable %s" msgid "If any unavailable" 2) Apply patch 3) update PO files 4) Look at PO files, for example fr-FR and see there is now only : msgid "If any unavailable" 5) Install translation 6) Go to Administration > Circulation and fine rule 7) Check that when editing an existing rule, edition comboboxes are set on the correct value 8) Create a default holds policy by item type and check that correct values are displayed in table Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 952b2242cfccec7a5cedcc858942f940f80d757b Author: Owen Leonard <oleonard at myacpl.org> Date: Fri Mar 23 13:02:29 2018 +0000 Bug 20299: Koha is a gift This patch updates the database update script replacing the "pile of poo" emoji with the "wrapped gift" emoji. To test, apply the patch and go to Administration -> System preferences -> Local use. Set the "Version" preference back to trigger a database update. Go through the database update process and confirm that the "Convert DB tables to utf8mb4" upgrade message includes a gift emoji. Signed-off-by: Mason James <mtj at kohaaloha.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 423fa9cc8f9bc1976296a3c5e26845b0c0d24608 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Tue Jan 2 15:42:12 2018 -0300 Bug 18593: Move suggestions when bibliographic records are merged When bibliographic records are merged, the suggestions.biblionumber field should be replaced with the new record. Ideally we should have kept an history of the merges, to know what was the original record. Now we cannot fix the broken links. Test plan: 1) Create a suggestion in OPAC 2) Accept the suggestion in staff 3) Add order from this suggestion 4) Go to cataloguing search and search for the record and another 5) Merge the suggestion record with the catalog record - catalog record wins (should be the more common case when a patron suggests something that already exists) 6) Verify that after merging, the new title displays in the acquisition record 7) Verify that the suggestion info no longer displays in basket From Katrin's test plan: 8) Verify that the new title doesn't display in suggestions. The old title will still show as suggested (not updated) => This is the title from suggestions.title, I think it makes sense to show this one. Maybe we should open a new bug report to improve the display of the suggestion, and link to the bibliographic record Signed-off-by: Lucie Gay <lucie.gay at ens-paris-saclay.fr> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> ----------------------------------------------------------------------- Summary of changes: .gitignore | 4 + C4/Auth.pm | 45 ++- C4/Letters.pm | 8 +- C4/Output.pm | 4 +- C4/Search.pm | 2 +- Koha.pm | 2 +- Koha/UploadedFile.pm | 15 +- about.pl | 4 +- catalogue/detail.pl | 6 +- catalogue/itemsearch.pl | 6 +- catalogue/moredetail.pl | 6 +- cataloguing/merge.pl | 8 +- circ/circulation.pl | 2 +- debian/docs/koha-common.xml | 18 +- debian/docs/koha-rebuild-zebra.xml | 4 +- debian/docs/koha-restart-zebra.xml | 44 --- debian/docs/koha-start-zebra.xml | 44 --- debian/docs/koha-stop-zebra.xml | 44 --- debian/koha-common.bash-completion | 5 - debian/koha-common.install | 3 - debian/koha-common.links | 3 + debian/scripts/koha-restart-zebra | 116 -------- debian/scripts/koha-start-zebra | 89 ------ debian/scripts/koha-stop-zebra | 74 ----- installer/data/mysql/sysprefs.sql | 5 + installer/data/mysql/updatedatabase.pl | 71 ++++- installer/data/mysql/userflags.sql | 3 +- installer/data/mysql/userpermissions.sql | 5 +- koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 11 +- .../prog/en/includes/auth-finder-search.inc | 105 ------- .../intranet-tmpl/prog/en/includes/permissions.inc | 9 +- koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 15 +- .../prog/en/modules/admin/admin-home.tt | 16 +- .../en/modules/admin/preferences/circulation.pref | 28 +- .../prog/en/modules/admin/smart-rules.tt | 69 +++-- koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt | 4 +- .../prog/en/modules/authorities/auth_finder.tt | 27 +- .../en/modules/authorities/authorities-home.tt | 10 +- .../prog/en/modules/authorities/authorities.tt | 8 +- .../authorities/blinddetail-biblio-search.tt | 230 +++++++-------- .../prog/en/modules/authorities/detail.tt | 9 +- .../prog/en/modules/authorities/merge.tt | 10 +- .../modules/authorities/searchresultlist-auth.tt | 68 +++-- .../en/modules/authorities/searchresultlist.tt | 11 +- .../cataloguing/value_builder/unimarc_field_100.tt | 95 ++---- .../value_builder/unimarc_field_100_authorities.tt | 52 ++-- .../cataloguing/value_builder/unimarc_field_105.tt | 29 +- .../cataloguing/value_builder/unimarc_field_106.tt | 27 +- .../cataloguing/value_builder/unimarc_field_110.tt | 33 ++- .../value_builder/unimarc_field_115a.tt | 36 +-- .../value_builder/unimarc_field_115b.tt | 39 +-- .../cataloguing/value_builder/unimarc_field_116.tt | 29 +- .../cataloguing/value_builder/unimarc_field_117.tt | 27 +- .../cataloguing/value_builder/unimarc_field_120.tt | 29 +- .../value_builder/unimarc_field_121a.tt | 24 +- .../value_builder/unimarc_field_121b.tt | 34 +-- .../cataloguing/value_builder/unimarc_field_122.tt | 45 +-- .../value_builder/unimarc_field_123a.tt | 23 +- .../value_builder/unimarc_field_123d.tt | 23 +- .../value_builder/unimarc_field_123e.tt | 24 +- .../value_builder/unimarc_field_123f.tt | 24 +- .../value_builder/unimarc_field_123g.tt | 24 +- .../value_builder/unimarc_field_123i_j.tt | 38 +-- .../value_builder/unimarc_field_124a.tt | 27 +- .../value_builder/unimarc_field_124b.tt | 25 +- .../value_builder/unimarc_field_124c.tt | 25 +- .../value_builder/unimarc_field_124d.tt | 25 +- .../value_builder/unimarc_field_124e.tt | 27 +- .../value_builder/unimarc_field_124f.tt | 27 +- .../value_builder/unimarc_field_124g.tt | 25 +- .../value_builder/unimarc_field_125a.tt | 25 +- .../value_builder/unimarc_field_125b.tt | 25 +- .../value_builder/unimarc_field_126a.tt | 23 +- .../value_builder/unimarc_field_126b.tt | 27 +- .../cataloguing/value_builder/unimarc_field_127.tt | 40 +-- .../value_builder/unimarc_field_128a.tt | 28 +- .../value_builder/unimarc_field_128b.tt | 27 +- .../value_builder/unimarc_field_128c.tt | 24 +- .../cataloguing/value_builder/unimarc_field_130.tt | 28 +- .../value_builder/unimarc_field_135a.tt | 22 +- .../cataloguing/value_builder/unimarc_field_140.tt | 28 +- .../cataloguing/value_builder/unimarc_field_141.tt | 30 +- .../value_builder/unimarc_field_210c.tt | 26 +- .../value_builder/unimarc_field_210c_bis.tt | 51 ++-- .../value_builder/unimarc_field_225a.tt | 19 +- .../value_builder/unimarc_field_225a_bis.tt | 55 ++-- .../cataloguing/value_builder/unimarc_field_4XX.tt | 228 +++++++-------- .../value_builder/unimarc_field_700-4.tt | 33 ++- .../cataloguing/value_builder/unimarc_leader.tt | 31 +- .../en/modules/cataloguing/z3950_auth_search.tt | 166 ++++++----- .../prog/en/modules/labels/label-edit-batch.tt | 24 +- .../prog/en/modules/labels/label-edit-template.tt | 24 +- .../prog/en/modules/labels/label-manage.tt | 38 +-- .../prog/en/modules/patroncards/edit-batch.tt | 307 ++++++++++---------- .../prog/en/modules/patroncards/edit-layout.tt | 211 +++++++------- .../prog/en/modules/patroncards/edit-profile.tt | 74 ++--- .../prog/en/modules/patroncards/edit-template.tt | 115 ++++---- .../prog/en/modules/patroncards/image-manage.tt | 96 +++--- .../prog/en/modules/patroncards/manage.tt | 294 ++++++++++--------- .../prog/en/modules/patroncards/print.tt | 40 ++- .../prog/en/modules/plugins/plugins-home.tt | 2 - .../en/modules/reports/guided_reports_start.tt | 30 +- .../prog/en/modules/reports/itemslost.tt | 5 +- .../prog/en/modules/reports/reports-home.tt | 43 ++- .../prog/en/modules/serials/subscription-add.tt | 18 +- .../prog/en/modules/suggestion/suggestion.tt | 15 +- .../prog/en/modules/tools/inventory.tt | 7 +- .../intranet-tmpl/prog/en/modules/tools/letter.tt | 21 +- .../intranet-tmpl/prog/js/auth-finder-search.js | 104 +++++++ .../opac-tmpl/bootstrap/css/{sco.css => sci.css} | 12 + koha-tmpl/opac-tmpl/bootstrap/css/sco.css | 12 + .../opac-tmpl/bootstrap/en/modules/opac-auth.tt | 4 + .../opac-tmpl/bootstrap/en/modules/opac-basket.tt | 39 +-- .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 6 +- .../opac-tmpl/bootstrap/en/modules/opac-user.tt | 4 +- .../opac-tmpl/bootstrap/en/modules/sci/sci-main.tt | 272 +++++++++++++++++ .../opac-tmpl/bootstrap/images/sign_in_green.png | Bin 1803 -> 0 bytes koha-tmpl/opac-tmpl/bootstrap/js/basket.js | 5 - labels/label-edit-batch.pl | 14 +- misc/cronjobs/process_message_queue.pl | 5 +- opac/opac-basket.pl | 2 - opac/opac-detail.pl | 1 + opac/sci/sci-main.pl | 100 +++++++ opac/sco/help.pl | 18 +- opac/sco/sco-main.pl | 19 +- opac/sco/sco-patron-image.pl | 2 +- reports/guided_reports.pl | 26 +- serials/subscription-add.pl | 2 +- t/Output.t | 15 +- t/db_dependent/Letters.t | 8 +- t/db_dependent/Upload.t | 13 +- t/db_dependent/rollingloans.t | 28 +- tools/inventory.pl | 4 +- 133 files changed, 2726 insertions(+), 2395 deletions(-) create mode 100644 .gitignore delete mode 100644 debian/docs/koha-restart-zebra.xml delete mode 100644 debian/docs/koha-start-zebra.xml delete mode 100644 debian/docs/koha-stop-zebra.xml create mode 100644 debian/koha-common.links delete mode 100755 debian/scripts/koha-restart-zebra delete mode 100755 debian/scripts/koha-start-zebra delete mode 100755 debian/scripts/koha-stop-zebra create mode 100644 koha-tmpl/intranet-tmpl/prog/js/auth-finder-search.js copy koha-tmpl/opac-tmpl/bootstrap/css/{sco.css => sci.css} (97%) create mode 100644 koha-tmpl/opac-tmpl/bootstrap/en/modules/sci/sci-main.tt delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/images/sign_in_green.png create mode 100755 opac/sci/sci-main.pl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Mar 27 14:10:10 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 27 Mar 2018 12:10:10 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.09-19-g5f446a5 Message-ID: <E1f0nQY-0003is-HW@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via 5f446a5f0aa4a05f5502e8562c9bdd5552dc1597 (commit) via 900c11e25a6038990bc0c3102b74b8599659cead (commit) via fa20c7a4f562bd3ff3952276f62c6b5e4e7f85c4 (commit) via 1664e8080157461db9eae73e076806f4e41e712b (commit) via 7616fa9dcd310845d05f13c2f9847223e14b508f (commit) via 338674817621f542ee122b8e6b7c2f374c50ce1d (commit) via 88758966cdd3c5d1e6f3e1db2b91aefd6e45036a (commit) via f6c4a1c3c4ada7bf7307bbc6d3ba1d094cac7539 (commit) via c04a87e34f62ea7985fd161677fba4472a878434 (commit) via e89ee572633e220cd027e460d5709852dbdd0331 (commit) via cdce1d8f397cf42f971fb14031c85142b0a11bce (commit) via ac54d831df9d865f600f20e42ef29a7a2833bd4c (commit) via da33f365debdd09c8f9b8af2ca904d2f72d3c062 (commit) from 5eb8bcb4eafa9fb717f24a34c245025f81d1a85b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5f446a5f0aa4a05f5502e8562c9bdd5552dc1597 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Fri Mar 23 13:13:16 2018 -0300 Bug 20466: Fix fixture syntax in t/Prices.t Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 00c9f9b0ea0179d8623bf350a7961a8cd75c5348) Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com> commit 900c11e25a6038990bc0c3102b74b8599659cead Author: Lari Taskula <lari.taskula at jns.fi> Date: Fri Mar 9 15:49:27 2018 +0200 Bug 20367: Avoid resetting userid when BorrowerUnwantedField contains userid To test: 1. In staff client, set your username to firstname 2. Add userid to BorrowerUnwantedField system preference 3. Go to your patron modification screen (memberentry.pl) and click Save 4. Observe you get kicked out into login screen, saying: Error: You do not have permission to access this page. Log in as a different user 5. Apply patch and restart plack 6. Set your username back to firstname 7. Repeat step 3 8. Observe you were not kicked out and your userid stays the same Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> (cherry picked from commit 7e44bb803fa085abdbded2311325f0c442b17708) Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com> commit fa20c7a4f562bd3ff3952276f62c6b5e4e7f85c4 Author: Tomas Cohen Arazi <tomascohen at gmail.com> Date: Mon Mar 5 13:36:50 2018 -0300 Bug 20167: Make changing a hold pass the itemnumber to ModReserve If you have an item-level hold, changing an attribute (like priority, pickup location or suspended until date) makes the hold a biblio-level hold, because ModReserve is not passed the current itemnumber. This patch uses the hold's itemnumber and passes it to the ModReserve call. To test: - Run the regression tests from the previous patch: $ kshell k$ prove t/db_dependent/api/v1/holds.t => FAIL: Tests fail - Apply this patch - Run the tests: $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> (cherry picked from commit e854b570021784d8e6ce8bb9d90e0b02d6f8c9a7) Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com> commit 1664e8080157461db9eae73e076806f4e41e712b Author: Tomas Cohen Arazi <tomascohen at gmail.com> Date: Mon Mar 5 13:35:33 2018 -0300 Bug 20167: Regression test Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Conflicts: t/db_dependent/api/v1/holds.t Signed-off-by: Nick Clemens <nick at bywatersolutions.com> (cherry picked from commit 705deb2aa4bdadbd583bcf322cf0611303725b05) Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com> commit 7616fa9dcd310845d05f13c2f9847223e14b508f Author: Nick Clemens <nick at bywatersolutions.com> Date: Fri Feb 16 12:31:39 2018 +0000 Bug 20218: Fix matching of uri in tracklinks The current code matches using a regex, this breaks when the url contains special characters. We swtich it to equality check To test: 1 - Enable TrackClicks (either track or anonymous) 2 - Find the URL of a biblio in the OPAC 3 - Paste this into the 856$u of another record (or use any url containing a '?' or other characters) 4 - View the record in the opac 5 - Click the URL 6 - 404 Error! 7 - Apply patch 8 - Try again 9 - Success! Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> (cherry picked from commit 306b461a6a8e57814367de524dfa3bd22c2f3eca) Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com> commit 338674817621f542ee122b8e6b7c2f374c50ce1d Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Tue Feb 27 11:40:13 2018 -0300 Bug 19979: ->count can be called directly on Koha::Objects Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> (cherry picked from commit f20b91d61b0cfbce6d036b94c08f169bde21bdb2) Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com> commit 88758966cdd3c5d1e6f3e1db2b91aefd6e45036a Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Date: Tue Jan 16 14:28:36 2018 +0100 Bug 19979: Fix get_facets_info test in Search.t The test should remove the holdingbranch key in the expected results when there is only one branch. See the logic in C4::Koha. Test plan: [1] Run Search.t on a database with multiple branches. [2] Run Search.t on a database with one branch. Without this patch the test would fail: Failed test '_get_facets_info returns the correct data'. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> (cherry picked from commit 254684c3ed70f1f07023a9a1ebd8d078dcb633dc) Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com> commit f6c4a1c3c4ada7bf7307bbc6d3ba1d094cac7539 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Mon Feb 19 17:40:06 2018 -0300 Bug 20250: (bug 19529 follow-up) Prevent NoIssuesChargeGuarantees.t to fail randomly Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Conflicts: t/db_dependent/Circulation/NoIssuesChargeGuarantees.t Signed-off-by: Nick Clemens <nick at bywatersolutions.com> (cherry picked from commit b671510474fc00e82d5dbec0ff59c92bea7bcb31) Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com> commit c04a87e34f62ea7985fd161677fba4472a878434 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Wed Oct 25 13:16:53 2017 -0300 Bug 19529: Prevent NoIssuesChargeGuarantees.t to fail randomly Use a categorycode != "X" Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> (cherry picked from commit 667c07e0480825da10fa9dba4ae9e9625be51d99) Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com> commit e89ee572633e220cd027e460d5709852dbdd0331 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Sun Feb 18 15:10:30 2018 -0300 Bug 20148: Prevent adding same user multiple times to an order Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> (cherry picked from commit 802c81ce1afadefd01f9959c3823b2cd7dc3ba3e) Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com> commit cdce1d8f397cf42f971fb14031c85142b0a11bce Author: Pasi Kallinen <pasi.kallinen at joensuu.fi> Date: Wed Feb 7 09:45:20 2018 +0200 Bug 20148: Prevent adding same user multiple times to acq basket When adding a user to manage acquisitions basket, it is possible to add the same user multiple times. Prevent that. Test plan: 1) Go to Home -> Acquisitions -> [bookseller] -> [basket] 2) On the "Add user" in the Managed by-part, and try adding the same user multiple times. 3) Apply patch 4) Repeat 1 and 2. You should now get an error message saying the user is already in the list. Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi> Signed-off-by: Roch D'Amour <roch.damour at inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Conflicts: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt Signed-off-by: Nick Clemens <nick at bywatersolutions.com> (cherry picked from commit 757c9b4231399ca6082a00b66beca8e59c0b462b) Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com> commit ac54d831df9d865f600f20e42ef29a7a2833bd4c Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Date: Thu Oct 12 13:13:41 2017 +0200 Bug 19452: [17.05.x] Remove the truncate option The truncate option is not really useful. Its result is probably not what most users of this script expect or need. It truncates both tables borrower_message_preferences and borrower_message_transport_preferences. This (unfortunately) includes deleting messaging preferences for patron categories. After that, adding preferences again will not add categories again, but only borrower preferences which are all disabled. Furthermore, we do not need to disable the foreign key check. Neither do we actually need to truncate, deleting records seems sufficient. Also deleting transport preferences is not needed, since it will be done by a cascade from messaging preferences. Note that the subsequent call of SetMessagingPreferencesFromDefaults will already delete the records. This makes it possible to remove the truncate option altogether. Test plan: [1] Select a patron category (say ST) and change days_in_advance to x. [2] Select a ST patron and set days_advance to y in his msg prefs. [3] Run borrowers-force-messaging-defaults.pl -doit [4] Verify that the patron has been reset to the default prefs (incl. value x in days_in_advance). [5] Verify that the patron category prefs are still intact. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Charles Farmer <charles.farmer at inLibro.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com> commit da33f365debdd09c8f9b8af2ca904d2f72d3c062 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Wed Feb 14 15:15:39 2018 -0300 Bug 20145: Do not insert 0000-00-00 in patron tests (and more) We should call Koha::Patron->is_expired in CanBookBeIssued instead of doing the same calculation. Tests have been adapted to pass with new SQL modes. We should not need to update the values in DB, we already have Bug 14717: Prevent 0000-00-00 dates in patron data (3.21.00.023) Test plan: prove t/db_dependent/Circulation/dateexpiry.t prove t/db_dependent/Koha/Patrons.t must return green Signed-off-by: Roch D'Amour <roch.damour at inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Conflicts: C4/Circulation.pm t/db_dependent/Koha/Patrons.t Signed-off-by: Nick Clemens <nick at bywatersolutions.com> (cherry picked from commit 9f075a4fdb2649493820ffed20a352add02c05ea) Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com> ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 14 ++++---------- C4/Utils/DataTables/Members.pm | 3 ++- Koha/Patron.pm | 4 ++-- Koha/REST/V1/Hold.pm | 1 + .../intranet-tmpl/prog/en/modules/acqui/basket.tt | 2 +- .../prog/en/modules/acqui/neworderempty.tt | 2 +- members/memberentry.pl | 2 +- .../maintenance/borrowers-force-messaging-defaults | 20 +++----------------- opac/tracklinks.pl | 2 +- t/Prices.t | 2 +- .../Circulation/NoIssuesChargeGuarantees.t | 5 +++++ t/db_dependent/Circulation/dateexpiry.t | 4 ++-- t/db_dependent/Koha/Patrons.t | 8 ++------ t/db_dependent/Search.t | 4 ++++ t/db_dependent/api/v1/holds.t | 5 +++-- 15 files changed, 33 insertions(+), 45 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Mar 27 18:52:41 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 27 Mar 2018 16:52:41 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.11.00-954-g7aac304 Message-ID: <E1f0rpx-00088m-Lw@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 7aac30428f3ae24f384bad316650e26b32dc5fed (commit) via 24f25369a58d4a2bc2adf92853feeed4337e013e (commit) via d8b3497368b839e4fc594661719351efbe3433cc (commit) via 51d7a02726b81b28325f7a151c8670e2f2293f71 (commit) via da36fd4429863c77570543a08978d0ef1e290e41 (commit) via b03ce512c45544d2b9695f913a2291530cb63362 (commit) via f3f8c669141da6941f7eebaebb157e99a3a5e217 (commit) via 62f79301479a7926f5e5d2f3299a1d156f50d933 (commit) via b8a94b0a9a0c4b92ab22f61522d2c449012762fd (commit) via fec6a3c83a53a973db464512523c7f022e9ad976 (commit) via 9f757c7e6a05a70fd4e374b284396885daff336f (commit) from 385c16174b4156f59518cdd1de02ee81ba3c03b8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7aac30428f3ae24f384bad316650e26b32dc5fed Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Tue Mar 27 13:37:35 2018 -0300 Bug 20479: Ease readability - do not enter the block if not logged in Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 24f25369a58d4a2bc2adf92853feeed4337e013e Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Tue Mar 27 12:47:54 2018 -0300 Bug 20479: Use $flag instead of fetching patron Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit d8b3497368b839e4fc594661719351efbe3433cc Author: Nick Clemens <nick at bywatersolutions.com> Date: Tue Mar 27 15:05:57 2018 +0000 Bug 20479: (follow-up) Don't try to get flags for database user Login will still break in opac-user.pl, but that seems a bigger problem not from SCI module Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 51d7a02726b81b28325f7a151c8670e2f2293f71 Author: Nick Clemens <nick at bywatersolutions.com> Date: Tue Mar 27 12:47:57 2018 +0000 Bug 20479: Don't kick superlibrarians out of the opac To test: 1 - Try to log in to opac with a superlibrarian 2 - Everythign goes wrong 3 - Apply patch 4 - Try to log in with superlibrarian 5 - You can sign in Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit da36fd4429863c77570543a08978d0ef1e290e41 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Tue Mar 27 13:27:27 2018 -0300 Bug 20480: send KOHA_VERSION even if only one language is enabled Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit b03ce512c45544d2b9695f913a2291530cb63362 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Tue Mar 27 11:54:51 2018 -0300 Bug 20480: Make KOHA_VERSION available to all templates in all circumstances This patch makes C4::Templates::gettemplate set the KOHA_VERSION param for the template. This way this template parameter, which is required by (probably) all pages that include CSS/JS content is available in all circumstances. A noticeable problem with the current approach is when using the SCO and SCI modules with wrong/forbidden users: C4::Auth short-circuits and redirects to the login page, without setting the KOHA_VERSION param. This patch solves it for good. To test: - Enable the SCI module - Open the browser at http://localhost:8080/cgi-bin/koha/sci/sci-main.pl - Login with the db user (koha_kohadev / password) => FAIL: Login failure, but styling is broken - Apply this patch - Retry => SUCCESS: Everything looks as it should! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit f3f8c669141da6941f7eebaebb157e99a3a5e217 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Tue Mar 27 12:21:41 2018 -0300 Bug 20474: Mimick Letters.t Please improve if needed the 2 occurrences on a separate bug reports. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 62f79301479a7926f5e5d2f3299a1d156f50d933 Author: Mark Tompsett <mtompset at hotmail.com> Date: Mon Mar 26 15:39:28 2018 +0000 Bug 20474: Mock sendmail instead of actually emailing Copy mocking sendmail code from t/db_dependent/Letters.t into the Passwordrecovery.t test file. prove t/db_dependent/Passwordrecovery.t Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit b8a94b0a9a0c4b92ab22f61522d2c449012762fd Author: Mark Tompsett <mtompset at hotmail.com> Date: Mon Mar 26 16:46:19 2018 +0000 Bug 20474: Explicitly call sendmail to make mocking work Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit fec6a3c83a53a973db464512523c7f022e9ad976 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Tue Mar 27 12:03:51 2018 -0300 Bug 20045: Fix Selenium tests Element id=doc does not longer exist on the admin home page The "main block" need to be localized using the new class 'main container-fluid' We will certainly need to improve this later. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 9f757c7e6a05a70fd4e374b284396885daff336f Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Mon Mar 26 19:35:07 2018 -0300 Bug 20267: .gitignore do not need to be mapped in Makefile Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 13 ++++------- C4/Letters.pm | 8 +++---- C4/Templates.pm | 3 +++ t/Makefile.t | 1 + t/db_dependent/Passwordrecovery.t | 29 +++++++++++++++++++++--- t/db_dependent/selenium/administration_tasks.t | 12 +++++----- t/lib/Selenium.pm | 2 ++ 7 files changed, 47 insertions(+), 21 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Mar 27 23:04:12 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 27 Mar 2018 21:04:12 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.11.00-964-g64616fe Message-ID: <E1f0vlM-0004tN-SC@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 64616fe2ffc35bf65aa28dcbc36b30e648591cf2 (commit) via 031149a20c60fbb2eb5a940cf4000eec4bfe08f7 (commit) via de3f658e9b35a93717d615aa79fb7fc85bcaeb88 (commit) via 675daf17cd3eb031416efac4114726555b656600 (commit) via 49c5acc5b9a47946b514c339fed33862d98e63d7 (commit) via 304e2a8868d6473b8a624bd4cb88812c8b90e1d4 (commit) via 57844add803b67f0f5e5c691d172d4141d8d6540 (commit) via ce82441d2625ac45a224b8acea9f616a256296a4 (commit) via 7b70f369d58c380b8c3fb8a5b13981776a0945f1 (commit) via bdbd489428fd392e6d4c096e88fa42cda2283c56 (commit) from 7aac30428f3ae24f384bad316650e26b32dc5fed (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 64616fe2ffc35bf65aa28dcbc36b30e648591cf2 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Tue Mar 27 17:53:13 2018 -0300 Bug 19233: Restore styling of the button Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 031149a20c60fbb2eb5a940cf4000eec4bfe08f7 Author: Alex Arnaud <alex.arnaud at biblibre.com> Date: Tue Mar 13 15:09:22 2018 +0000 Bug 19583: Remove use of C4::AuthoritiesMarc Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit de3f658e9b35a93717d615aa79fb7fc85bcaeb88 Author: Nick Clemens <nick at bywatersolutions.com> Date: Mon Mar 12 15:56:45 2018 +0000 Bug 19582: (follow-up) get params in correct order We were ordering the values out of sync with the order of the mathclist param and so causing 'entire record' and 'all headings' to be reversed Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr> Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 675daf17cd3eb031416efac4114726555b656600 Author: Nick Clemens <nick at bywatersolutions.com> Date: Tue Nov 7 01:24:56 2017 +0000 Bug 19582: Unit tests Signed-off-by: David Bourgault <david.bourgault at inlibro.com> Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr> Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 49c5acc5b9a47946b514c339fed33862d98e63d7 Author: Nick Clemens <nick at bywatersolutions.com> Date: Mon Nov 6 17:14:34 2017 +0000 Bug 19582: Use compat routines for searching authorities in auth_finder.pl To test: 1 - Enable Zebra 2 - Perform an auth search 3 - note results 4 - Enable ES 5 - Repeat search, note (likely) diff results 6 - Open a record in cataloging and use the button to launch auth search 7 - Perform same search as above, note results match for eiher engine selected 8 - NOTE: Disbale sorting for ES search - this will be dealt with in another report Signed-off-by: David Bourgault <david.bourgault at inlibro.com> Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr> Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 304e2a8868d6473b8a624bd4cb88812c8b90e1d4 Author: Claire Gravely <claire.gravely at bsz-bw.de> Date: Tue Mar 13 11:18:33 2018 +0000 Bug 20386: Improve warning and error messages for Search Engine Configuration This patch updates a warning message and error message in the Search engine configuration for Elasticsearch. Note: elasticsearch does not need to be active in order to test. To test warning message: 1. go to: cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl 2. note the warning message 3. Apply patch 4. Note the change in warning message. Confirm it makes sense. To test error message: Apply patch and check the changed message in the template file mappings.tt and confirm it makes sense. Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 57844add803b67f0f5e5c691d172d4141d8d6540 Author: Fridolin Somers <fridolin.somers at biblibre.com> Date: Mon Dec 4 10:04:48 2017 +0100 Bug 19739: Add default ES configuration to koha-conf.xml Bug 18571 added default ES configuration for packaging config. This patch adds it to dev install in koha-conf.xml. Database name is used in index_name to allow multiple installs. Test plan : - Run dev install - Install ElasticSearch server and Koha deps - Enable ElasticSearch in Koha - Check indexing and searching works directly Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit ce82441d2625ac45a224b8acea9f616a256296a4 Author: Nick Clemens <nick at bywatersolutions.com> Date: Tue Mar 27 17:30:42 2018 +0000 Bug 19233: (follow-up) Use a button to submit form Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 7b70f369d58c380b8c3fb8a5b13981776a0945f1 Author: Owen Leonard <oleonard at myacpl.org> Date: Mon Sep 18 15:23:38 2017 +0000 Bug 19233: (follow-up) Send itemnumbers in report results to batch modification This patch changes the obscure "^" symbol to a styled link with the text "Batch modify." I think the only disadvantage of this is that it takes up more space, but it is outweighed by the improved clarity. This patch also makes minor indentation corrections to new lines of HTML. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit bdbd489428fd392e6d4c096e88fa42cda2283c56 Author: Nick Clemens <nick at bywatersolutions.com> Date: Fri Sep 1 00:54:44 2017 +0000 Bug 19233: Add ability to send itemnumbers in report results to batch modification To test: 1 - Apply patch 2 - Run a report with an itemnumber column 3 - Note there is a linked '^' after column title 4 - Hover over the '^' 5 - You should see a tooltip 'Send visible items to batch modification' 6 - Click the '^' 7 - You should be sent to batch item modification with itemnumbers that were visible in report Signed-off-by: George <george at nekls.org> Signed-off-by: BWS Sandboxes <ByWaterSandboxes at gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> ----------------------------------------------------------------------- Summary of changes: Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 1 + authorities/auth_finder.pl | 19 ++++++-- etc/koha-conf.xml | 5 ++ .../prog/en/includes/auth-finder-search.inc | 2 +- .../admin/searchengine/elasticsearch/mappings.tt | 4 +- .../en/modules/reports/guided_reports_start.tt | 48 ++++++++++++++++---- .../Koha/SearchEngine/Elasticsearch/QueryBuilder.t | 28 +++++++++++- 7 files changed, 89 insertions(+), 18 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 28 13:48:34 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 28 Mar 2018 11:48:34 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.09-25-g2f22ee7 Message-ID: <E1f19ZC-0006jQ-Nj@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via 2f22ee7576fb76acbae722f41208f52cb1af9ef3 (commit) via 289397d8854e5c4afd54a0303446108e546ebe28 (commit) via 2f020ef88a116c4a6425093b6bb5bfd6434a107e (commit) via 56d70a8458d5aa62b52425fbc6e097b03629e4c1 (commit) via 812756f54e059d00632c401dce7a2fe3764ecfc9 (commit) via 09ae62a758d44d669caf0ad095232af4287201a4 (commit) from 5f446a5f0aa4a05f5502e8562c9bdd5552dc1597 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2f22ee7576fb76acbae722f41208f52cb1af9ef3 Merge: 289397d 56d70a8 Author: Fridolin Somers <fridolin.somers at biblibre.com> Date: Tue Mar 27 14:10:41 2018 +0200 Merge remote-tracking branch 'translate/17.05.10-translate-20180327' into 17.05.x commit 289397d8854e5c4afd54a0303446108e546ebe28 Author: Fridolin Somers <fridolin.somers at biblibre.com> Date: Tue Mar 27 14:09:56 2018 +0200 Update release notes for 17.05.10 release commit 2f020ef88a116c4a6425093b6bb5bfd6434a107e Author: Fridolin Somers <fridolin.somers at biblibre.com> Date: Tue Mar 27 14:04:10 2018 +0200 Increment version for 17.05.10 release Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com> commit 56d70a8458d5aa62b52425fbc6e097b03629e4c1 Author: Koha translators <> Date: Tue Mar 27 09:07:33 2018 -0300 Translation updates for Koha 17.05.10 commit 812756f54e059d00632c401dce7a2fe3764ecfc9 Author: Mark Tompsett <mtompset at hotmail.com> Date: Tue Jan 30 22:35:39 2018 +0000 Bug 20083: Follow up - use same logic in opac-showmarc It was correctly pointed out that opac-showmarc would leak the same way as catalogue/showmarc.pl, and so this patch moves the authentication step up to the top where it should be so as to prevent inappropriate data leaks. TEST PLAN --------- 1) Set your OpacPublic system preference to Disabled 2) Open your OPAC and login 3) Find a biblio with items 4) Go to the opac details, particularly MARC view. 5) Copy the "view plain" shortcut link. 6) log out. 7) Paste the link into the address bar. -- the information will leak! 8) apply the patch 9) restart_all 10) Refresh the OPAC link -- log in screen will appear. 11) run koha qa test tools Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> (cherry picked from commit e40d0b81bfc059ece2b99475c7bf45fecea0eeb4) Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com> commit 09ae62a758d44d669caf0ad095232af4287201a4 Author: Andreas Roussos <arouss1980 at gmail.com> Date: Fri Jan 26 14:12:47 2018 +1300 Bug 20083 - Information disclosure when (mis)using the MARC Preview feature The MARC Preview feature in the Staff client (catalogue/showmarc.pl) does not check whether a user is logged in or not. As a consequence, it can be used to obtain information that would normally be available to logged-in users only. For example, you can view any bibliographic record by passing a value to the 'id' argument, but you can also view records as they were imported (normally done via the 'Staged MARC management' tool). All three 17.11 installations currently listed at https://wiki.koha-community.org/wiki/Koha_Demo_Installations are affected by this issue, as demonstrated by the URLs below: http://koha.adminkuhn.ch:8080/cgi-bin/koha/catalogue/showmarc.pl?importid=1&viewas=html http://pro.demo1711-koha.test.biblibre.eu/cgi-bin/koha/catalogue/showmarc.pl?id=1000&viewas=html https://staff-kohademo.equinoxinitiative.org/cgi-bin/koha/catalogue/showmarc.pl?id=1&viewas=html It should be noted that this only applies to XSLT-enabled installations. Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> (cherry picked from commit 095a92a94e87cac0c8bdf79f2413fb72efb13f9e) Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com> ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- catalogue/showmarc.pl | 21 +- installer/data/mysql/updatedatabase.pl | 6 + misc/release_notes/release_notes_17_05_10.md | 258 +++++++++++++ misc/translator/po/am-Ethi-marc-MARC21.po | 2 +- misc/translator/po/am-Ethi-marc-NORMARC.po | 2 +- misc/translator/po/am-Ethi-marc-UNIMARC.po | 2 +- misc/translator/po/am-Ethi-opac-bootstrap.po | 2 +- misc/translator/po/am-Ethi-staff-help.po | 2 +- misc/translator/po/am-Ethi-staff-prog.po | 382 +++++++++---------- misc/translator/po/ar-Arab-marc-MARC21.po | 2 +- misc/translator/po/ar-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ar-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ar-Arab-opac-bootstrap.po | 2 +- misc/translator/po/ar-Arab-staff-help.po | 2 +- misc/translator/po/ar-Arab-staff-prog.po | 382 +++++++++---------- misc/translator/po/as-IN-marc-MARC21.po | 2 +- misc/translator/po/as-IN-marc-NORMARC.po | 2 +- misc/translator/po/as-IN-marc-UNIMARC.po | 2 +- misc/translator/po/as-IN-opac-bootstrap.po | 2 +- misc/translator/po/as-IN-staff-help.po | 2 +- misc/translator/po/as-IN-staff-prog.po | 382 +++++++++---------- misc/translator/po/az-AZ-marc-MARC21.po | 2 +- misc/translator/po/az-AZ-marc-NORMARC.po | 2 +- misc/translator/po/az-AZ-marc-UNIMARC.po | 2 +- misc/translator/po/az-AZ-opac-bootstrap.po | 2 +- misc/translator/po/az-AZ-staff-help.po | 2 +- misc/translator/po/az-AZ-staff-prog.po | 382 +++++++++---------- misc/translator/po/be-BY-marc-MARC21.po | 2 +- misc/translator/po/be-BY-marc-NORMARC.po | 2 +- misc/translator/po/be-BY-marc-UNIMARC.po | 2 +- misc/translator/po/be-BY-opac-bootstrap.po | 2 +- misc/translator/po/be-BY-staff-help.po | 2 +- misc/translator/po/be-BY-staff-prog.po | 382 +++++++++---------- misc/translator/po/bg-Cyrl-marc-MARC21.po | 2 +- misc/translator/po/bg-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/bg-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/bg-Cyrl-opac-bootstrap.po | 2 +- misc/translator/po/bg-Cyrl-staff-help.po | 2 +- misc/translator/po/bg-Cyrl-staff-prog.po | 382 +++++++++---------- misc/translator/po/bn-IN-marc-MARC21.po | 2 +- misc/translator/po/bn-IN-marc-NORMARC.po | 2 +- misc/translator/po/bn-IN-marc-UNIMARC.po | 2 +- misc/translator/po/bn-IN-opac-bootstrap.po | 2 +- misc/translator/po/bn-IN-staff-help.po | 2 +- misc/translator/po/bn-IN-staff-prog.po | 382 +++++++++---------- misc/translator/po/ca-ES-marc-MARC21.po | 2 +- misc/translator/po/ca-ES-marc-NORMARC.po | 2 +- misc/translator/po/ca-ES-marc-UNIMARC.po | 2 +- misc/translator/po/ca-ES-opac-bootstrap.po | 2 +- misc/translator/po/ca-ES-staff-help.po | 2 +- misc/translator/po/ca-ES-staff-prog.po | 382 +++++++++---------- misc/translator/po/cs-CZ-marc-MARC21.po | 2 +- misc/translator/po/cs-CZ-marc-NORMARC.po | 2 +- misc/translator/po/cs-CZ-marc-UNIMARC.po | 2 +- misc/translator/po/cs-CZ-opac-bootstrap.po | 2 +- misc/translator/po/cs-CZ-staff-help.po | 2 +- misc/translator/po/cs-CZ-staff-prog.po | 382 +++++++++---------- misc/translator/po/cy-GB-marc-MARC21.po | 2 +- misc/translator/po/cy-GB-marc-NORMARC.po | 2 +- misc/translator/po/cy-GB-marc-UNIMARC.po | 2 +- misc/translator/po/cy-GB-opac-bootstrap.po | 2 +- misc/translator/po/cy-GB-staff-help.po | 2 +- misc/translator/po/cy-GB-staff-prog.po | 382 +++++++++---------- misc/translator/po/da-DK-marc-MARC21.po | 2 +- misc/translator/po/da-DK-marc-NORMARC.po | 2 +- misc/translator/po/da-DK-marc-UNIMARC.po | 2 +- misc/translator/po/da-DK-opac-bootstrap.po | 2 +- misc/translator/po/da-DK-staff-help.po | 2 +- misc/translator/po/da-DK-staff-prog.po | 382 +++++++++---------- misc/translator/po/de-CH-marc-MARC21.po | 2 +- misc/translator/po/de-CH-marc-NORMARC.po | 2 +- misc/translator/po/de-CH-marc-UNIMARC.po | 2 +- misc/translator/po/de-CH-opac-bootstrap.po | 2 +- misc/translator/po/de-CH-staff-help.po | 2 +- misc/translator/po/de-CH-staff-prog.po | 382 +++++++++---------- misc/translator/po/de-DE-marc-MARC21.po | 2 +- misc/translator/po/de-DE-marc-NORMARC.po | 2 +- misc/translator/po/de-DE-marc-UNIMARC.po | 2 +- misc/translator/po/de-DE-opac-bootstrap.po | 10 +- misc/translator/po/de-DE-pref.po | 1 + misc/translator/po/de-DE-staff-help.po | 7 +- misc/translator/po/de-DE-staff-prog.po | 401 ++++++++++---------- misc/translator/po/el-GR-marc-MARC21.po | 2 +- misc/translator/po/el-GR-marc-NORMARC.po | 2 +- misc/translator/po/el-GR-marc-UNIMARC.po | 2 +- misc/translator/po/el-GR-opac-bootstrap.po | 2 +- misc/translator/po/el-GR-staff-help.po | 2 +- misc/translator/po/el-GR-staff-prog.po | 382 +++++++++---------- misc/translator/po/en-GB-marc-MARC21.po | 2 +- misc/translator/po/en-GB-marc-NORMARC.po | 2 +- misc/translator/po/en-GB-marc-UNIMARC.po | 2 +- misc/translator/po/en-GB-opac-bootstrap.po | 2 +- misc/translator/po/en-GB-staff-help.po | 2 +- misc/translator/po/en-GB-staff-prog.po | 382 +++++++++---------- misc/translator/po/en-NZ-marc-MARC21.po | 2 +- misc/translator/po/en-NZ-marc-NORMARC.po | 2 +- misc/translator/po/en-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/en-NZ-opac-bootstrap.po | 2 +- misc/translator/po/en-NZ-staff-help.po | 2 +- misc/translator/po/en-NZ-staff-prog.po | 382 +++++++++---------- misc/translator/po/eo-marc-MARC21.po | 2 +- misc/translator/po/eo-marc-NORMARC.po | 2 +- misc/translator/po/eo-marc-UNIMARC.po | 2 +- misc/translator/po/eo-opac-bootstrap.po | 2 +- misc/translator/po/eo-staff-help.po | 2 +- misc/translator/po/eo-staff-prog.po | 382 +++++++++---------- misc/translator/po/es-ES-marc-MARC21.po | 2 +- misc/translator/po/es-ES-marc-NORMARC.po | 2 +- misc/translator/po/es-ES-marc-UNIMARC.po | 2 +- misc/translator/po/es-ES-opac-bootstrap.po | 26 +- misc/translator/po/es-ES-staff-help.po | 6 +- misc/translator/po/es-ES-staff-prog.po | 424 ++++++++++----------- misc/translator/po/eu-marc-MARC21.po | 2 +- misc/translator/po/eu-marc-NORMARC.po | 2 +- misc/translator/po/eu-marc-UNIMARC.po | 2 +- misc/translator/po/eu-opac-bootstrap.po | 2 +- misc/translator/po/eu-staff-help.po | 2 +- misc/translator/po/eu-staff-prog.po | 382 +++++++++---------- misc/translator/po/fa-Arab-marc-MARC21.po | 2 +- misc/translator/po/fa-Arab-marc-NORMARC.po | 2 +- misc/translator/po/fa-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/fa-Arab-opac-bootstrap.po | 2 +- misc/translator/po/fa-Arab-staff-help.po | 2 +- misc/translator/po/fa-Arab-staff-prog.po | 382 +++++++++---------- misc/translator/po/fi-FI-marc-MARC21.po | 2 +- misc/translator/po/fi-FI-marc-NORMARC.po | 2 +- misc/translator/po/fi-FI-marc-UNIMARC.po | 2 +- misc/translator/po/fi-FI-opac-bootstrap.po | 2 +- misc/translator/po/fi-FI-staff-help.po | 2 +- misc/translator/po/fi-FI-staff-prog.po | 382 +++++++++---------- misc/translator/po/fo-FO-marc-MARC21.po | 2 +- misc/translator/po/fo-FO-marc-NORMARC.po | 2 +- misc/translator/po/fo-FO-marc-UNIMARC.po | 2 +- misc/translator/po/fo-FO-opac-bootstrap.po | 2 +- misc/translator/po/fo-FO-staff-help.po | 2 +- misc/translator/po/fo-FO-staff-prog.po | 382 +++++++++---------- misc/translator/po/fr-CA-marc-MARC21.po | 2 +- misc/translator/po/fr-CA-marc-NORMARC.po | 2 +- misc/translator/po/fr-CA-marc-UNIMARC.po | 2 +- misc/translator/po/fr-CA-opac-bootstrap.po | 21 +- misc/translator/po/fr-CA-pref.po | 17 +- misc/translator/po/fr-CA-staff-help.po | 10 +- misc/translator/po/fr-CA-staff-prog.po | 459 +++++++++++----------- misc/translator/po/fr-FR-marc-MARC21.po | 2 +- misc/translator/po/fr-FR-marc-NORMARC.po | 2 +- misc/translator/po/fr-FR-marc-UNIMARC.po | 2 +- misc/translator/po/fr-FR-opac-bootstrap.po | 2 +- misc/translator/po/fr-FR-staff-help.po | 2 +- misc/translator/po/fr-FR-staff-prog.po | 397 +++++++++---------- misc/translator/po/gl-marc-MARC21.po | 2 +- misc/translator/po/gl-marc-NORMARC.po | 2 +- misc/translator/po/gl-marc-UNIMARC.po | 2 +- misc/translator/po/gl-opac-bootstrap.po | 2 +- misc/translator/po/gl-staff-help.po | 2 +- misc/translator/po/gl-staff-prog.po | 382 +++++++++---------- misc/translator/po/he-Hebr-marc-MARC21.po | 2 +- misc/translator/po/he-Hebr-marc-NORMARC.po | 2 +- misc/translator/po/he-Hebr-marc-UNIMARC.po | 2 +- misc/translator/po/he-Hebr-opac-bootstrap.po | 2 +- misc/translator/po/he-Hebr-staff-help.po | 2 +- misc/translator/po/he-Hebr-staff-prog.po | 382 +++++++++---------- misc/translator/po/hi-marc-MARC21.po | 2 +- misc/translator/po/hi-marc-NORMARC.po | 2 +- misc/translator/po/hi-marc-UNIMARC.po | 2 +- misc/translator/po/hi-opac-bootstrap.po | 2 +- misc/translator/po/hi-staff-help.po | 2 +- misc/translator/po/hi-staff-prog.po | 382 +++++++++---------- misc/translator/po/hr-HR-marc-MARC21.po | 2 +- misc/translator/po/hr-HR-marc-NORMARC.po | 2 +- misc/translator/po/hr-HR-marc-UNIMARC.po | 2 +- misc/translator/po/hr-HR-opac-bootstrap.po | 2 +- misc/translator/po/hr-HR-staff-help.po | 2 +- misc/translator/po/hr-HR-staff-prog.po | 382 +++++++++---------- misc/translator/po/hu-HU-marc-MARC21.po | 2 +- misc/translator/po/hu-HU-marc-NORMARC.po | 2 +- misc/translator/po/hu-HU-marc-UNIMARC.po | 2 +- misc/translator/po/hu-HU-opac-bootstrap.po | 2 +- misc/translator/po/hu-HU-staff-help.po | 2 +- misc/translator/po/hu-HU-staff-prog.po | 382 +++++++++---------- misc/translator/po/hy-Armn-marc-MARC21.po | 2 +- misc/translator/po/hy-Armn-marc-NORMARC.po | 2 +- misc/translator/po/hy-Armn-marc-UNIMARC.po | 2 +- misc/translator/po/hy-Armn-opac-bootstrap.po | 9 +- misc/translator/po/hy-Armn-staff-help.po | 2 +- misc/translator/po/hy-Armn-staff-prog.po | 442 +++++++++++----------- misc/translator/po/ia-marc-MARC21.po | 2 +- misc/translator/po/ia-marc-NORMARC.po | 2 +- misc/translator/po/ia-marc-UNIMARC.po | 2 +- misc/translator/po/ia-opac-bootstrap.po | 2 +- misc/translator/po/ia-staff-help.po | 2 +- misc/translator/po/ia-staff-prog.po | 382 +++++++++---------- misc/translator/po/id-ID-marc-MARC21.po | 2 +- misc/translator/po/id-ID-marc-NORMARC.po | 2 +- misc/translator/po/id-ID-marc-UNIMARC.po | 2 +- misc/translator/po/id-ID-opac-bootstrap.po | 2 +- misc/translator/po/id-ID-staff-help.po | 2 +- misc/translator/po/id-ID-staff-prog.po | 382 +++++++++---------- misc/translator/po/iq-CA-marc-MARC21.po | 2 +- misc/translator/po/iq-CA-marc-NORMARC.po | 2 +- misc/translator/po/iq-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iq-CA-opac-bootstrap.po | 2 +- misc/translator/po/iq-CA-staff-help.po | 2 +- misc/translator/po/iq-CA-staff-prog.po | 382 +++++++++---------- misc/translator/po/is-IS-marc-MARC21.po | 2 +- misc/translator/po/is-IS-marc-NORMARC.po | 2 +- misc/translator/po/is-IS-marc-UNIMARC.po | 2 +- misc/translator/po/is-IS-opac-bootstrap.po | 2 +- misc/translator/po/is-IS-staff-help.po | 2 +- misc/translator/po/is-IS-staff-prog.po | 382 +++++++++---------- misc/translator/po/it-IT-marc-MARC21.po | 2 +- misc/translator/po/it-IT-marc-NORMARC.po | 2 +- misc/translator/po/it-IT-marc-UNIMARC.po | 2 +- misc/translator/po/it-IT-opac-bootstrap.po | 2 +- misc/translator/po/it-IT-staff-help.po | 2 +- misc/translator/po/it-IT-staff-prog.po | 382 +++++++++---------- misc/translator/po/iu-CA-marc-MARC21.po | 2 +- misc/translator/po/iu-CA-marc-NORMARC.po | 2 +- misc/translator/po/iu-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iu-CA-opac-bootstrap.po | 2 +- misc/translator/po/iu-CA-staff-help.po | 2 +- misc/translator/po/iu-CA-staff-prog.po | 382 +++++++++---------- misc/translator/po/ja-Jpan-JP-marc-MARC21.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-NORMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-UNIMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-opac-bootstrap.po | 2 +- misc/translator/po/ja-Jpan-JP-staff-help.po | 2 +- misc/translator/po/ja-Jpan-JP-staff-prog.po | 382 +++++++++---------- misc/translator/po/ka-marc-MARC21.po | 2 +- misc/translator/po/ka-marc-NORMARC.po | 2 +- misc/translator/po/ka-marc-UNIMARC.po | 2 +- misc/translator/po/ka-opac-bootstrap.po | 2 +- misc/translator/po/ka-staff-help.po | 2 +- misc/translator/po/ka-staff-prog.po | 382 +++++++++---------- misc/translator/po/km-KH-marc-MARC21.po | 2 +- misc/translator/po/km-KH-marc-NORMARC.po | 2 +- misc/translator/po/km-KH-marc-UNIMARC.po | 2 +- misc/translator/po/km-KH-opac-bootstrap.po | 2 +- misc/translator/po/km-KH-staff-help.po | 2 +- misc/translator/po/km-KH-staff-prog.po | 382 +++++++++---------- misc/translator/po/kn-Knda-marc-MARC21.po | 2 +- misc/translator/po/kn-Knda-marc-NORMARC.po | 2 +- misc/translator/po/kn-Knda-marc-UNIMARC.po | 2 +- misc/translator/po/kn-Knda-opac-bootstrap.po | 2 +- misc/translator/po/kn-Knda-staff-help.po | 2 +- misc/translator/po/kn-Knda-staff-prog.po | 382 +++++++++---------- misc/translator/po/ko-Kore-KP-marc-MARC21.po | 2 +- misc/translator/po/ko-Kore-KP-marc-NORMARC.po | 2 +- misc/translator/po/ko-Kore-KP-marc-UNIMARC.po | 2 +- misc/translator/po/ko-Kore-KP-opac-bootstrap.po | 2 +- misc/translator/po/ko-Kore-KP-staff-help.po | 2 +- misc/translator/po/ko-Kore-KP-staff-prog.po | 382 +++++++++---------- misc/translator/po/ku-Arab-marc-MARC21.po | 2 +- misc/translator/po/ku-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ku-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ku-Arab-opac-bootstrap.po | 2 +- misc/translator/po/ku-Arab-staff-help.po | 2 +- misc/translator/po/ku-Arab-staff-prog.po | 382 +++++++++---------- misc/translator/po/lo-Laoo-marc-MARC21.po | 2 +- misc/translator/po/lo-Laoo-marc-NORMARC.po | 2 +- misc/translator/po/lo-Laoo-marc-UNIMARC.po | 2 +- misc/translator/po/lo-Laoo-opac-bootstrap.po | 2 +- misc/translator/po/lo-Laoo-staff-help.po | 2 +- misc/translator/po/lo-Laoo-staff-prog.po | 382 +++++++++---------- misc/translator/po/mi-NZ-marc-MARC21.po | 2 +- misc/translator/po/mi-NZ-marc-NORMARC.po | 2 +- misc/translator/po/mi-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/mi-NZ-opac-bootstrap.po | 2 +- misc/translator/po/mi-NZ-staff-help.po | 2 +- misc/translator/po/mi-NZ-staff-prog.po | 382 +++++++++---------- misc/translator/po/ml-marc-MARC21.po | 2 +- misc/translator/po/ml-marc-NORMARC.po | 2 +- misc/translator/po/ml-marc-UNIMARC.po | 2 +- misc/translator/po/ml-opac-bootstrap.po | 2 +- misc/translator/po/ml-staff-help.po | 2 +- misc/translator/po/ml-staff-prog.po | 382 +++++++++---------- misc/translator/po/mon-marc-MARC21.po | 2 +- misc/translator/po/mon-marc-NORMARC.po | 2 +- misc/translator/po/mon-marc-UNIMARC.po | 2 +- misc/translator/po/mon-opac-bootstrap.po | 2 +- misc/translator/po/mon-staff-help.po | 2 +- misc/translator/po/mon-staff-prog.po | 382 +++++++++---------- misc/translator/po/mr-marc-MARC21.po | 2 +- misc/translator/po/mr-marc-NORMARC.po | 2 +- misc/translator/po/mr-marc-UNIMARC.po | 2 +- misc/translator/po/mr-opac-bootstrap.po | 2 +- misc/translator/po/mr-staff-help.po | 2 +- misc/translator/po/mr-staff-prog.po | 382 +++++++++---------- misc/translator/po/ms-MY-marc-MARC21.po | 2 +- misc/translator/po/ms-MY-marc-NORMARC.po | 2 +- misc/translator/po/ms-MY-marc-UNIMARC.po | 2 +- misc/translator/po/ms-MY-opac-bootstrap.po | 2 +- misc/translator/po/ms-MY-staff-help.po | 2 +- misc/translator/po/ms-MY-staff-prog.po | 382 +++++++++---------- misc/translator/po/my-marc-MARC21.po | 2 +- misc/translator/po/my-marc-NORMARC.po | 2 +- misc/translator/po/my-marc-UNIMARC.po | 2 +- misc/translator/po/my-opac-bootstrap.po | 2 +- misc/translator/po/my-staff-help.po | 2 +- misc/translator/po/my-staff-prog.po | 382 +++++++++---------- misc/translator/po/nb-NO-marc-MARC21.po | 2 +- misc/translator/po/nb-NO-marc-NORMARC.po | 2 +- misc/translator/po/nb-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nb-NO-opac-bootstrap.po | 2 +- misc/translator/po/nb-NO-staff-help.po | 2 +- misc/translator/po/nb-NO-staff-prog.po | 382 +++++++++---------- misc/translator/po/ne-NE-marc-MARC21.po | 2 +- misc/translator/po/ne-NE-marc-NORMARC.po | 2 +- misc/translator/po/ne-NE-marc-UNIMARC.po | 2 +- misc/translator/po/ne-NE-opac-bootstrap.po | 2 +- misc/translator/po/ne-NE-staff-help.po | 2 +- misc/translator/po/ne-NE-staff-prog.po | 382 +++++++++---------- misc/translator/po/nl-BE-marc-MARC21.po | 2 +- misc/translator/po/nl-BE-marc-NORMARC.po | 2 +- misc/translator/po/nl-BE-marc-UNIMARC.po | 2 +- misc/translator/po/nl-BE-opac-bootstrap.po | 2 +- misc/translator/po/nl-BE-staff-help.po | 2 +- misc/translator/po/nl-BE-staff-prog.po | 382 +++++++++---------- misc/translator/po/nl-NL-marc-MARC21.po | 2 +- misc/translator/po/nl-NL-marc-NORMARC.po | 2 +- misc/translator/po/nl-NL-marc-UNIMARC.po | 2 +- misc/translator/po/nl-NL-opac-bootstrap.po | 2 +- misc/translator/po/nl-NL-staff-help.po | 2 +- misc/translator/po/nl-NL-staff-prog.po | 382 +++++++++---------- misc/translator/po/nn-NO-marc-MARC21.po | 2 +- misc/translator/po/nn-NO-marc-NORMARC.po | 2 +- misc/translator/po/nn-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nn-NO-opac-bootstrap.po | 2 +- misc/translator/po/nn-NO-staff-help.po | 2 +- misc/translator/po/nn-NO-staff-prog.po | 382 +++++++++---------- misc/translator/po/oc-marc-MARC21.po | 2 +- misc/translator/po/oc-marc-NORMARC.po | 2 +- misc/translator/po/oc-marc-UNIMARC.po | 2 +- misc/translator/po/oc-opac-bootstrap.po | 2 +- misc/translator/po/oc-staff-help.po | 2 +- misc/translator/po/oc-staff-prog.po | 382 +++++++++---------- misc/translator/po/pbr-marc-MARC21.po | 2 +- misc/translator/po/pbr-marc-NORMARC.po | 2 +- misc/translator/po/pbr-marc-UNIMARC.po | 2 +- misc/translator/po/pbr-opac-bootstrap.po | 2 +- misc/translator/po/pbr-staff-help.po | 2 +- misc/translator/po/pbr-staff-prog.po | 382 +++++++++---------- misc/translator/po/pl-PL-marc-MARC21.po | 2 +- misc/translator/po/pl-PL-marc-NORMARC.po | 2 +- misc/translator/po/pl-PL-marc-UNIMARC.po | 2 +- misc/translator/po/pl-PL-opac-bootstrap.po | 2 +- misc/translator/po/pl-PL-staff-help.po | 2 +- misc/translator/po/pl-PL-staff-prog.po | 382 +++++++++---------- misc/translator/po/prs-marc-MARC21.po | 2 +- misc/translator/po/prs-marc-NORMARC.po | 2 +- misc/translator/po/prs-marc-UNIMARC.po | 2 +- misc/translator/po/prs-opac-bootstrap.po | 2 +- misc/translator/po/prs-staff-help.po | 2 +- misc/translator/po/prs-staff-prog.po | 382 +++++++++---------- misc/translator/po/pt-BR-marc-MARC21.po | 2 +- misc/translator/po/pt-BR-marc-NORMARC.po | 2 +- misc/translator/po/pt-BR-marc-UNIMARC.po | 2 +- misc/translator/po/pt-BR-opac-bootstrap.po | 2 +- misc/translator/po/pt-BR-staff-help.po | 2 +- misc/translator/po/pt-BR-staff-prog.po | 382 +++++++++---------- misc/translator/po/pt-PT-marc-MARC21.po | 2 +- misc/translator/po/pt-PT-marc-NORMARC.po | 2 +- misc/translator/po/pt-PT-marc-UNIMARC.po | 2 +- misc/translator/po/pt-PT-opac-bootstrap.po | 17 +- misc/translator/po/pt-PT-staff-help.po | 12 +- misc/translator/po/pt-PT-staff-prog.po | 456 +++++++++++----------- misc/translator/po/ro-RO-marc-MARC21.po | 2 +- misc/translator/po/ro-RO-marc-NORMARC.po | 2 +- misc/translator/po/ro-RO-marc-UNIMARC.po | 2 +- misc/translator/po/ro-RO-opac-bootstrap.po | 2 +- misc/translator/po/ro-RO-staff-help.po | 2 +- misc/translator/po/ro-RO-staff-prog.po | 382 +++++++++---------- misc/translator/po/ru-RU-marc-MARC21.po | 2 +- misc/translator/po/ru-RU-marc-NORMARC.po | 2 +- misc/translator/po/ru-RU-marc-UNIMARC.po | 2 +- misc/translator/po/ru-RU-opac-bootstrap.po | 2 +- misc/translator/po/ru-RU-staff-help.po | 2 +- misc/translator/po/ru-RU-staff-prog.po | 382 +++++++++---------- misc/translator/po/rw-RW-marc-MARC21.po | 2 +- misc/translator/po/rw-RW-marc-NORMARC.po | 2 +- misc/translator/po/rw-RW-marc-UNIMARC.po | 2 +- misc/translator/po/rw-RW-opac-bootstrap.po | 2 +- misc/translator/po/rw-RW-staff-help.po | 2 +- misc/translator/po/rw-RW-staff-prog.po | 382 +++++++++---------- misc/translator/po/sd-PK-marc-MARC21.po | 2 +- misc/translator/po/sd-PK-marc-NORMARC.po | 2 +- misc/translator/po/sd-PK-marc-UNIMARC.po | 2 +- misc/translator/po/sd-PK-opac-bootstrap.po | 2 +- misc/translator/po/sd-PK-staff-help.po | 2 +- misc/translator/po/sd-PK-staff-prog.po | 382 +++++++++---------- misc/translator/po/sk-SK-marc-MARC21.po | 2 +- misc/translator/po/sk-SK-marc-NORMARC.po | 2 +- misc/translator/po/sk-SK-marc-UNIMARC.po | 2 +- misc/translator/po/sk-SK-opac-bootstrap.po | 2 +- misc/translator/po/sk-SK-staff-help.po | 2 +- misc/translator/po/sk-SK-staff-prog.po | 382 +++++++++---------- misc/translator/po/sl-SI-marc-MARC21.po | 2 +- misc/translator/po/sl-SI-marc-NORMARC.po | 2 +- misc/translator/po/sl-SI-marc-UNIMARC.po | 2 +- misc/translator/po/sl-SI-opac-bootstrap.po | 2 +- misc/translator/po/sl-SI-staff-help.po | 2 +- misc/translator/po/sl-SI-staff-prog.po | 382 +++++++++---------- misc/translator/po/sq-AL-marc-MARC21.po | 2 +- misc/translator/po/sq-AL-marc-NORMARC.po | 2 +- misc/translator/po/sq-AL-marc-UNIMARC.po | 2 +- misc/translator/po/sq-AL-opac-bootstrap.po | 2 +- misc/translator/po/sq-AL-staff-help.po | 2 +- misc/translator/po/sq-AL-staff-prog.po | 382 +++++++++---------- misc/translator/po/sr-Cyrl-marc-MARC21.po | 2 +- misc/translator/po/sr-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/sr-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/sr-Cyrl-opac-bootstrap.po | 2 +- misc/translator/po/sr-Cyrl-staff-help.po | 2 +- misc/translator/po/sr-Cyrl-staff-prog.po | 382 +++++++++---------- misc/translator/po/sv-SE-marc-MARC21.po | 2 +- misc/translator/po/sv-SE-marc-NORMARC.po | 2 +- misc/translator/po/sv-SE-marc-UNIMARC.po | 2 +- misc/translator/po/sv-SE-opac-bootstrap.po | 2 +- misc/translator/po/sv-SE-staff-help.po | 2 +- misc/translator/po/sv-SE-staff-prog.po | 382 +++++++++---------- misc/translator/po/sw-KE-marc-MARC21.po | 2 +- misc/translator/po/sw-KE-marc-NORMARC.po | 2 +- misc/translator/po/sw-KE-marc-UNIMARC.po | 2 +- misc/translator/po/sw-KE-opac-bootstrap.po | 2 +- misc/translator/po/sw-KE-staff-help.po | 2 +- misc/translator/po/sw-KE-staff-prog.po | 382 +++++++++---------- misc/translator/po/ta-LK-marc-MARC21.po | 2 +- misc/translator/po/ta-LK-marc-NORMARC.po | 2 +- misc/translator/po/ta-LK-marc-UNIMARC.po | 2 +- misc/translator/po/ta-LK-opac-bootstrap.po | 2 +- misc/translator/po/ta-LK-staff-help.po | 2 +- misc/translator/po/ta-LK-staff-prog.po | 382 +++++++++---------- misc/translator/po/ta-marc-MARC21.po | 2 +- misc/translator/po/ta-marc-NORMARC.po | 2 +- misc/translator/po/ta-marc-UNIMARC.po | 2 +- misc/translator/po/ta-opac-bootstrap.po | 2 +- misc/translator/po/ta-staff-help.po | 2 +- misc/translator/po/ta-staff-prog.po | 382 +++++++++---------- misc/translator/po/tet-marc-MARC21.po | 2 +- misc/translator/po/tet-marc-NORMARC.po | 2 +- misc/translator/po/tet-marc-UNIMARC.po | 2 +- misc/translator/po/tet-opac-bootstrap.po | 2 +- misc/translator/po/tet-staff-help.po | 2 +- misc/translator/po/tet-staff-prog.po | 382 +++++++++---------- misc/translator/po/th-TH-marc-MARC21.po | 2 +- misc/translator/po/th-TH-marc-NORMARC.po | 2 +- misc/translator/po/th-TH-marc-UNIMARC.po | 2 +- misc/translator/po/th-TH-opac-bootstrap.po | 2 +- misc/translator/po/th-TH-staff-help.po | 2 +- misc/translator/po/th-TH-staff-prog.po | 382 +++++++++---------- misc/translator/po/tl-PH-marc-MARC21.po | 2 +- misc/translator/po/tl-PH-marc-NORMARC.po | 2 +- misc/translator/po/tl-PH-marc-UNIMARC.po | 2 +- misc/translator/po/tl-PH-opac-bootstrap.po | 2 +- misc/translator/po/tl-PH-staff-help.po | 2 +- misc/translator/po/tl-PH-staff-prog.po | 382 +++++++++---------- misc/translator/po/tr-TR-marc-MARC21.po | 2 +- misc/translator/po/tr-TR-marc-NORMARC.po | 2 +- misc/translator/po/tr-TR-marc-UNIMARC.po | 2 +- misc/translator/po/tr-TR-opac-bootstrap.po | 17 +- misc/translator/po/tr-TR-staff-help.po | 2 +- misc/translator/po/tr-TR-staff-prog.po | 461 +++++++++++------------ misc/translator/po/uk-UA-marc-MARC21.po | 2 +- misc/translator/po/uk-UA-marc-NORMARC.po | 2 +- misc/translator/po/uk-UA-marc-UNIMARC.po | 2 +- misc/translator/po/uk-UA-opac-bootstrap.po | 2 +- misc/translator/po/uk-UA-staff-help.po | 2 +- misc/translator/po/uk-UA-staff-prog.po | 382 +++++++++---------- misc/translator/po/ur-Arab-marc-MARC21.po | 2 +- misc/translator/po/ur-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ur-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ur-Arab-opac-bootstrap.po | 2 +- misc/translator/po/ur-Arab-staff-help.po | 2 +- misc/translator/po/ur-Arab-staff-prog.po | 382 +++++++++---------- misc/translator/po/vi-VN-marc-MARC21.po | 2 +- misc/translator/po/vi-VN-marc-NORMARC.po | 2 +- misc/translator/po/vi-VN-marc-UNIMARC.po | 2 +- misc/translator/po/vi-VN-opac-bootstrap.po | 2 +- misc/translator/po/vi-VN-staff-help.po | 2 +- misc/translator/po/vi-VN-staff-prog.po | 382 +++++++++---------- misc/translator/po/zh-Hans-CN-marc-MARC21.po | 2 +- misc/translator/po/zh-Hans-CN-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hans-CN-marc-UNIMARC.po | 2 +- misc/translator/po/zh-Hans-CN-opac-bootstrap.po | 2 +- misc/translator/po/zh-Hans-CN-staff-help.po | 2 +- misc/translator/po/zh-Hans-CN-staff-prog.po | 382 +++++++++---------- misc/translator/po/zh-Hans-TW-marc-MARC21.po | 2 +- misc/translator/po/zh-Hans-TW-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hans-TW-marc-UNIMARC.po | 2 +- misc/translator/po/zh-Hans-TW-opac-bootstrap.po | 2 +- misc/translator/po/zh-Hans-TW-staff-help.po | 2 +- misc/translator/po/zh-Hans-TW-staff-prog.po | 382 +++++++++---------- opac/opac-showmarc.pl | 14 +- 493 files changed, 16399 insertions(+), 16153 deletions(-) create mode 100644 misc/release_notes/release_notes_17_05_10.md hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 28 13:49:48 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 28 Mar 2018 11:49:48 +0000 Subject: [koha-commits] main Koha release repository annotated tag v17.05.10 created. v17.05.10 Message-ID: <E1f19aO-0006pZ-2b@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v17.05.10 has been created at 296b93d2c5f37dc25264e65875d0b34f30fb5fdb (tag) tagging 2f22ee7576fb76acbae722f41208f52cb1af9ef3 (commit) replaces v17.05.09 tagged by Fridolin Somers on Tue Mar 27 14:11:19 2018 +0200 - Log ----------------------------------------------------------------- Koha release 17.05.10 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAABAgAGBQJaujTnAAoJECvJNkKAZAZurkQH/2C/PyQ3xAG6QsyFVGeUMDlj YPhGyp8yPJMFhfC74qZZ+DJVIDoBUfEgSyIBBEdzS6ThCyIs+fHtI4Z+koQ2tNOr F0Hnvra3CjVYb/9xr4flekeN3iu+W6ckJMGE8eUIaMtfFghkN6I/sc+bP52rFgkt 2wVhWn37s4PcwB4mBgEKl3S5Cngz/gVnV7NhaZQ5wPT8i54zHN3r2NwJ2PChjB2i oknFLpd4Q4jbAn21UplUQtJqDaQqXSeSmjE023ej7hkax5k7l1M+CIy2ipTVJIjG b7vPBTAxdkTvFgdn3pGu8nTrZq/+hh/am4FFtpNbOUex6RpOPDkw7NRD8GQ3oxg= =Q1SI -----END PGP SIGNATURE----- Andreas Roussos (1): Bug 20083 - Information disclosure when (mis)using the MARC Preview feature Fridolin Somers (4): Bug 20276: Fix GetCourseItem call to get itemnumber Increment version for 17.05.10 release Update release notes for 17.05.10 release Merge remote-tracking branch 'translate/17.05.10-translate-20180327' into 17.05.x Jonathan Druart (6): Bug 20145: Do not insert 0000-00-00 in patron tests (and more) Bug 20148: Prevent adding same user multiple times to an order Bug 19529: Prevent NoIssuesChargeGuarantees.t to fail randomly Bug 20250: (bug 19529 follow-up) Prevent NoIssuesChargeGuarantees.t to fail randomly Bug 19979: ->count can be called directly on Koha::Objects Bug 20466: Fix fixture syntax in t/Prices.t Koha translators (1): Translation updates for Koha 17.05.10 Kyle M Hall (2): Bug 19530: Prevent multiple transfers from existing for one item Bug 19530: Don't update the date arrived for closed transfers Lari Taskula (1): Bug 20367: Avoid resetting userid when BorrowerUnwantedField contains userid Marcel de Rooy (2): Bug 19452: [17.05.x] Remove the truncate option Bug 19979: Fix get_facets_info test in Search.t Mark Tompsett (2): Bug 19530: Added commentary for last test when prove -v Bug 20083: Follow up - use same logic in opac-showmarc Nick Clemens (2): Bug 19806: Add classes to itemnotes in issues table Bug 20218: Fix matching of uri in tracklinks Pasi Kallinen (1): Bug 20148: Prevent adding same user multiple times to acq basket Tomas Cohen Arazi (2): Bug 20167: Regression test Bug 20167: Make changing a hold pass the itemnumber to ModReserve Victor Grousset (1): Bug 20098: Inventory tool: CVS export: fix itemlost column ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 28 13:59:35 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 28 Mar 2018 11:59:35 +0000 Subject: [koha-commits] main Koha release repository branch 17.11.x updated. v17.11.03-21-gd0a0390 Message-ID: <E1f19jr-0007FH-5h@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.11.x has been updated via d0a0390b9d5739d582dd98165f321c49e08a02a4 (commit) via e40d0b81bfc059ece2b99475c7bf45fecea0eeb4 (commit) via 095a92a94e87cac0c8bdf79f2413fb72efb13f9e (commit) via f713da50563ba54bc89a3ae87419151f3bd8ac75 (commit) via ab49b92fa9176adf245bcb318d4b24192ccd325d (commit) from 84be52b39f3f2f080fa9be094f0044e70aed6c69 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d0a0390b9d5739d582dd98165f321c49e08a02a4 Author: Nick Clemens <nick at bywatersolutions.com> Date: Mon Mar 26 15:29:06 2018 +0000 Update relase notes for 17.11.04 release commit e40d0b81bfc059ece2b99475c7bf45fecea0eeb4 Author: Mark Tompsett <mtompset at hotmail.com> Date: Tue Jan 30 22:35:39 2018 +0000 Bug 20083: Follow up - use same logic in opac-showmarc It was correctly pointed out that opac-showmarc would leak the same way as catalogue/showmarc.pl, and so this patch moves the authentication step up to the top where it should be so as to prevent inappropriate data leaks. TEST PLAN --------- 1) Set your OpacPublic system preference to Disabled 2) Open your OPAC and login 3) Find a biblio with items 4) Go to the opac details, particularly MARC view. 5) Copy the "view plain" shortcut link. 6) log out. 7) Paste the link into the address bar. -- the information will leak! 8) apply the patch 9) restart_all 10) Refresh the OPAC link -- log in screen will appear. 11) run koha qa test tools Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> commit 095a92a94e87cac0c8bdf79f2413fb72efb13f9e Author: Andreas Roussos <arouss1980 at gmail.com> Date: Fri Jan 26 14:12:47 2018 +1300 Bug 20083 - Information disclosure when (mis)using the MARC Preview feature The MARC Preview feature in the Staff client (catalogue/showmarc.pl) does not check whether a user is logged in or not. As a consequence, it can be used to obtain information that would normally be available to logged-in users only. For example, you can view any bibliographic record by passing a value to the 'id' argument, but you can also view records as they were imported (normally done via the 'Staged MARC management' tool). All three 17.11 installations currently listed at https://wiki.koha-community.org/wiki/Koha_Demo_Installations are affected by this issue, as demonstrated by the URLs below: http://koha.adminkuhn.ch:8080/cgi-bin/koha/catalogue/showmarc.pl?importid=1&viewas=html http://pro.demo1711-koha.test.biblibre.eu/cgi-bin/koha/catalogue/showmarc.pl?id=1000&viewas=html https://staff-kohademo.equinoxinitiative.org/cgi-bin/koha/catalogue/showmarc.pl?id=1&viewas=html It should be noted that this only applies to XSLT-enabled installations. Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> commit f713da50563ba54bc89a3ae87419151f3bd8ac75 Author: Nick Clemens <nick at bywatersolutions.com> Date: Mon Mar 26 11:16:25 2018 -0400 Increment version for 17.11.04 release commit ab49b92fa9176adf245bcb318d4b24192ccd325d Author: Koha translators <> Date: Mon Mar 26 12:05:45 2018 -0300 Translation updates for Koha 17.11.04 ----------------------------------------------------------------------- Summary of changes: Koha.pm | 2 +- catalogue/showmarc.pl | 21 +- installer/data/mysql/updatedatabase.pl | 6 + misc/release_notes/release_notes_17_11_04.md | 249 ++ misc/translator/po/am-Ethi-marc-MARC21.po | 2 +- misc/translator/po/am-Ethi-marc-NORMARC.po | 2 +- misc/translator/po/am-Ethi-marc-UNIMARC.po | 2 +- misc/translator/po/am-Ethi-opac-bootstrap.po | 2 +- misc/translator/po/am-Ethi-staff-help.po | 2 +- misc/translator/po/am-Ethi-staff-prog.po | 2 +- misc/translator/po/ar-Arab-marc-MARC21.po | 2 +- misc/translator/po/ar-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ar-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ar-Arab-opac-bootstrap.po | 2 +- misc/translator/po/ar-Arab-staff-help.po | 2 +- misc/translator/po/ar-Arab-staff-prog.po | 2 +- misc/translator/po/as-IN-marc-MARC21.po | 2 +- misc/translator/po/as-IN-marc-NORMARC.po | 2 +- misc/translator/po/as-IN-marc-UNIMARC.po | 2 +- misc/translator/po/as-IN-opac-bootstrap.po | 2 +- misc/translator/po/as-IN-staff-help.po | 2 +- misc/translator/po/as-IN-staff-prog.po | 2 +- misc/translator/po/az-AZ-marc-MARC21.po | 2 +- misc/translator/po/az-AZ-marc-NORMARC.po | 2 +- misc/translator/po/az-AZ-marc-UNIMARC.po | 2 +- misc/translator/po/az-AZ-opac-bootstrap.po | 2 +- misc/translator/po/az-AZ-staff-help.po | 2 +- misc/translator/po/az-AZ-staff-prog.po | 2 +- misc/translator/po/be-BY-marc-MARC21.po | 2 +- misc/translator/po/be-BY-marc-NORMARC.po | 2 +- misc/translator/po/be-BY-marc-UNIMARC.po | 2 +- misc/translator/po/be-BY-opac-bootstrap.po | 2 +- misc/translator/po/be-BY-staff-help.po | 2 +- misc/translator/po/be-BY-staff-prog.po | 2 +- misc/translator/po/bg-Cyrl-marc-MARC21.po | 2 +- misc/translator/po/bg-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/bg-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/bg-Cyrl-opac-bootstrap.po | 2 +- misc/translator/po/bg-Cyrl-staff-help.po | 2 +- misc/translator/po/bg-Cyrl-staff-prog.po | 2 +- misc/translator/po/bn-IN-marc-MARC21.po | 2 +- misc/translator/po/bn-IN-marc-NORMARC.po | 2 +- misc/translator/po/bn-IN-marc-UNIMARC.po | 2 +- misc/translator/po/bn-IN-opac-bootstrap.po | 199 +- misc/translator/po/bn-IN-staff-help.po | 2 +- misc/translator/po/bn-IN-staff-prog.po | 2 +- misc/translator/po/ca-ES-marc-MARC21.po | 2 +- misc/translator/po/ca-ES-marc-NORMARC.po | 2 +- misc/translator/po/ca-ES-marc-UNIMARC.po | 2 +- misc/translator/po/ca-ES-opac-bootstrap.po | 2 +- misc/translator/po/ca-ES-staff-help.po | 2 +- misc/translator/po/ca-ES-staff-prog.po | 2 +- misc/translator/po/cs-CZ-marc-MARC21.po | 2 +- misc/translator/po/cs-CZ-marc-NORMARC.po | 2 +- misc/translator/po/cs-CZ-marc-UNIMARC.po | 2 +- misc/translator/po/cs-CZ-opac-bootstrap.po | 40 +- misc/translator/po/cs-CZ-pref.po | 18 +- misc/translator/po/cs-CZ-staff-help.po | 2 +- misc/translator/po/cs-CZ-staff-prog.po | 177 +- misc/translator/po/cy-GB-marc-MARC21.po | 2 +- misc/translator/po/cy-GB-marc-NORMARC.po | 2 +- misc/translator/po/cy-GB-marc-UNIMARC.po | 2 +- misc/translator/po/cy-GB-opac-bootstrap.po | 2 +- misc/translator/po/cy-GB-staff-help.po | 2 +- misc/translator/po/cy-GB-staff-prog.po | 2 +- misc/translator/po/da-DK-marc-MARC21.po | 2 +- misc/translator/po/da-DK-marc-NORMARC.po | 2 +- misc/translator/po/da-DK-marc-UNIMARC.po | 2 +- misc/translator/po/da-DK-opac-bootstrap.po | 2 +- misc/translator/po/da-DK-staff-help.po | 2 +- misc/translator/po/da-DK-staff-prog.po | 2 +- misc/translator/po/de-CH-marc-MARC21.po | 2 +- misc/translator/po/de-CH-marc-NORMARC.po | 2 +- misc/translator/po/de-CH-marc-UNIMARC.po | 2 +- misc/translator/po/de-CH-opac-bootstrap.po | 2 +- misc/translator/po/de-CH-staff-help.po | 2 +- misc/translator/po/de-CH-staff-prog.po | 2 +- misc/translator/po/de-DE-marc-MARC21.po | 2 +- misc/translator/po/de-DE-marc-NORMARC.po | 2 +- misc/translator/po/de-DE-marc-UNIMARC.po | 2 +- misc/translator/po/de-DE-opac-bootstrap.po | 8 +- misc/translator/po/de-DE-pref.po | 1 + misc/translator/po/de-DE-staff-help.po | 7 +- misc/translator/po/de-DE-staff-prog.po | 86 +- misc/translator/po/el-GR-marc-MARC21.po | 14 +- misc/translator/po/el-GR-marc-NORMARC.po | 2 +- misc/translator/po/el-GR-marc-UNIMARC.po | 39 +- misc/translator/po/el-GR-opac-bootstrap.po | 33 +- misc/translator/po/el-GR-pref.po | 17 +- misc/translator/po/el-GR-staff-help.po | 80 +- misc/translator/po/el-GR-staff-prog.po | 435 ++- misc/translator/po/en-GB-marc-MARC21.po | 2 +- misc/translator/po/en-GB-marc-NORMARC.po | 2 +- misc/translator/po/en-GB-marc-UNIMARC.po | 2 +- misc/translator/po/en-GB-opac-bootstrap.po | 2 +- misc/translator/po/en-GB-staff-help.po | 2 +- misc/translator/po/en-GB-staff-prog.po | 2 +- misc/translator/po/en-NZ-marc-MARC21.po | 2 +- misc/translator/po/en-NZ-marc-NORMARC.po | 2 +- misc/translator/po/en-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/en-NZ-opac-bootstrap.po | 2 +- misc/translator/po/en-NZ-staff-help.po | 2 +- misc/translator/po/en-NZ-staff-prog.po | 2 +- misc/translator/po/eo-marc-MARC21.po | 2 +- misc/translator/po/eo-marc-NORMARC.po | 2 +- misc/translator/po/eo-marc-UNIMARC.po | 2 +- misc/translator/po/eo-opac-bootstrap.po | 2048 +++++++------- misc/translator/po/eo-staff-help.po | 2 +- misc/translator/po/eo-staff-prog.po | 2 +- misc/translator/po/es-ES-marc-MARC21.po | 2 +- misc/translator/po/es-ES-marc-NORMARC.po | 2 +- misc/translator/po/es-ES-marc-UNIMARC.po | 2 +- misc/translator/po/es-ES-opac-bootstrap.po | 24 +- misc/translator/po/es-ES-staff-help.po | 6 +- misc/translator/po/es-ES-staff-prog.po | 81 +- misc/translator/po/eu-marc-MARC21.po | 2 +- misc/translator/po/eu-marc-NORMARC.po | 2 +- misc/translator/po/eu-marc-UNIMARC.po | 2 +- misc/translator/po/eu-opac-bootstrap.po | 2 +- misc/translator/po/eu-staff-help.po | 2 +- misc/translator/po/eu-staff-prog.po | 2 +- misc/translator/po/fa-Arab-marc-MARC21.po | 2 +- misc/translator/po/fa-Arab-marc-NORMARC.po | 2 +- misc/translator/po/fa-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/fa-Arab-opac-bootstrap.po | 2 +- misc/translator/po/fa-Arab-staff-help.po | 2 +- misc/translator/po/fa-Arab-staff-prog.po | 2 +- misc/translator/po/fi-FI-marc-MARC21.po | 122 +- misc/translator/po/fi-FI-marc-NORMARC.po | 2 +- misc/translator/po/fi-FI-marc-UNIMARC.po | 2 +- misc/translator/po/fi-FI-opac-bootstrap.po | 2 +- misc/translator/po/fi-FI-staff-help.po | 2 +- misc/translator/po/fi-FI-staff-prog.po | 631 ++--- misc/translator/po/fo-FO-marc-MARC21.po | 2 +- misc/translator/po/fo-FO-marc-NORMARC.po | 2 +- misc/translator/po/fo-FO-marc-UNIMARC.po | 2 +- misc/translator/po/fo-FO-opac-bootstrap.po | 2 +- misc/translator/po/fo-FO-staff-help.po | 2 +- misc/translator/po/fo-FO-staff-prog.po | 2 +- misc/translator/po/fr-CA-marc-MARC21.po | 12 +- misc/translator/po/fr-CA-marc-NORMARC.po | 2 +- misc/translator/po/fr-CA-marc-UNIMARC.po | 2 +- misc/translator/po/fr-CA-opac-bootstrap.po | 10 +- misc/translator/po/fr-CA-pref.po | 5 +- misc/translator/po/fr-CA-staff-help.po | 2 +- misc/translator/po/fr-CA-staff-prog.po | 258 +- misc/translator/po/fr-FR-marc-MARC21.po | 146 +- misc/translator/po/fr-FR-marc-NORMARC.po | 2 +- misc/translator/po/fr-FR-marc-UNIMARC.po | 2 +- misc/translator/po/fr-FR-opac-bootstrap.po | 18 +- misc/translator/po/fr-FR-pref.po | 8 +- misc/translator/po/fr-FR-staff-help.po | 2 +- misc/translator/po/fr-FR-staff-prog.po | 326 +-- misc/translator/po/gl-marc-MARC21.po | 2 +- misc/translator/po/gl-marc-NORMARC.po | 2 +- misc/translator/po/gl-marc-UNIMARC.po | 2 +- misc/translator/po/gl-opac-bootstrap.po | 2 +- misc/translator/po/gl-staff-help.po | 2 +- misc/translator/po/gl-staff-prog.po | 2 +- misc/translator/po/he-Hebr-marc-MARC21.po | 2 +- misc/translator/po/he-Hebr-marc-NORMARC.po | 2 +- misc/translator/po/he-Hebr-marc-UNIMARC.po | 2 +- misc/translator/po/he-Hebr-opac-bootstrap.po | 2 +- misc/translator/po/he-Hebr-staff-help.po | 2 +- misc/translator/po/he-Hebr-staff-prog.po | 2 +- misc/translator/po/hi-marc-MARC21.po | 2 +- misc/translator/po/hi-marc-NORMARC.po | 2 +- misc/translator/po/hi-marc-UNIMARC.po | 2 +- misc/translator/po/hi-opac-bootstrap.po | 2 +- misc/translator/po/hi-staff-help.po | 2 +- misc/translator/po/hi-staff-prog.po | 2 +- misc/translator/po/hr-HR-marc-MARC21.po | 2 +- misc/translator/po/hr-HR-marc-NORMARC.po | 2 +- misc/translator/po/hr-HR-marc-UNIMARC.po | 2 +- misc/translator/po/hr-HR-opac-bootstrap.po | 124 +- misc/translator/po/hr-HR-staff-help.po | 2 +- misc/translator/po/hr-HR-staff-prog.po | 44 +- misc/translator/po/hu-HU-marc-MARC21.po | 2 +- misc/translator/po/hu-HU-marc-NORMARC.po | 2 +- misc/translator/po/hu-HU-marc-UNIMARC.po | 2 +- misc/translator/po/hu-HU-opac-bootstrap.po | 2 +- misc/translator/po/hu-HU-staff-help.po | 2 +- misc/translator/po/hu-HU-staff-prog.po | 2 +- misc/translator/po/hy-Armn-marc-MARC21.po | 2 +- misc/translator/po/hy-Armn-marc-NORMARC.po | 2 +- misc/translator/po/hy-Armn-marc-UNIMARC.po | 2 +- misc/translator/po/hy-Armn-opac-bootstrap.po | 36 +- misc/translator/po/hy-Armn-staff-help.po | 2 +- misc/translator/po/hy-Armn-staff-prog.po | 149 +- misc/translator/po/ia-marc-MARC21.po | 2 +- misc/translator/po/ia-marc-NORMARC.po | 2 +- misc/translator/po/ia-marc-UNIMARC.po | 2 +- misc/translator/po/ia-opac-bootstrap.po | 2 +- misc/translator/po/ia-staff-help.po | 2 +- misc/translator/po/ia-staff-prog.po | 2 +- misc/translator/po/id-ID-marc-MARC21.po | 2 +- misc/translator/po/id-ID-marc-NORMARC.po | 2 +- misc/translator/po/id-ID-marc-UNIMARC.po | 2 +- misc/translator/po/id-ID-opac-bootstrap.po | 2 +- misc/translator/po/id-ID-staff-help.po | 2 +- misc/translator/po/id-ID-staff-prog.po | 2 +- misc/translator/po/iq-CA-marc-MARC21.po | 2 +- misc/translator/po/iq-CA-marc-NORMARC.po | 2 +- misc/translator/po/iq-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iq-CA-opac-bootstrap.po | 2 +- misc/translator/po/iq-CA-staff-help.po | 2 +- misc/translator/po/iq-CA-staff-prog.po | 2 +- misc/translator/po/is-IS-marc-MARC21.po | 2 +- misc/translator/po/is-IS-marc-NORMARC.po | 2 +- misc/translator/po/is-IS-marc-UNIMARC.po | 2 +- misc/translator/po/is-IS-opac-bootstrap.po | 2 +- misc/translator/po/is-IS-staff-help.po | 2 +- misc/translator/po/is-IS-staff-prog.po | 2 +- misc/translator/po/it-IT-marc-MARC21.po | 2 +- misc/translator/po/it-IT-marc-NORMARC.po | 2 +- misc/translator/po/it-IT-marc-UNIMARC.po | 2 +- misc/translator/po/it-IT-opac-bootstrap.po | 2 +- misc/translator/po/it-IT-staff-help.po | 2 +- misc/translator/po/it-IT-staff-prog.po | 10 +- misc/translator/po/iu-CA-marc-MARC21.po | 2 +- misc/translator/po/iu-CA-marc-NORMARC.po | 2 +- misc/translator/po/iu-CA-marc-UNIMARC.po | 2 +- misc/translator/po/iu-CA-opac-bootstrap.po | 2 +- misc/translator/po/iu-CA-staff-help.po | 2 +- misc/translator/po/iu-CA-staff-prog.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-MARC21.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-NORMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-marc-UNIMARC.po | 2 +- misc/translator/po/ja-Jpan-JP-opac-bootstrap.po | 2 +- misc/translator/po/ja-Jpan-JP-staff-help.po | 2 +- misc/translator/po/ja-Jpan-JP-staff-prog.po | 2 +- misc/translator/po/ka-marc-MARC21.po | 2 +- misc/translator/po/ka-marc-NORMARC.po | 2 +- misc/translator/po/ka-marc-UNIMARC.po | 2 +- misc/translator/po/ka-opac-bootstrap.po | 2 +- misc/translator/po/ka-staff-help.po | 2 +- misc/translator/po/ka-staff-prog.po | 2 +- misc/translator/po/km-KH-marc-MARC21.po | 2 +- misc/translator/po/km-KH-marc-NORMARC.po | 2 +- misc/translator/po/km-KH-marc-UNIMARC.po | 2 +- misc/translator/po/km-KH-opac-bootstrap.po | 2 +- misc/translator/po/km-KH-staff-help.po | 2 +- misc/translator/po/km-KH-staff-prog.po | 2 +- misc/translator/po/kn-Knda-marc-MARC21.po | 2 +- misc/translator/po/kn-Knda-marc-NORMARC.po | 2 +- misc/translator/po/kn-Knda-marc-UNIMARC.po | 2 +- misc/translator/po/kn-Knda-opac-bootstrap.po | 2 +- misc/translator/po/kn-Knda-staff-help.po | 2 +- misc/translator/po/kn-Knda-staff-prog.po | 2 +- misc/translator/po/ko-Kore-KP-marc-MARC21.po | 2 +- misc/translator/po/ko-Kore-KP-marc-NORMARC.po | 2 +- misc/translator/po/ko-Kore-KP-marc-UNIMARC.po | 2 +- misc/translator/po/ko-Kore-KP-opac-bootstrap.po | 2 +- misc/translator/po/ko-Kore-KP-staff-help.po | 2 +- misc/translator/po/ko-Kore-KP-staff-prog.po | 2 +- misc/translator/po/ku-Arab-marc-MARC21.po | 2 +- misc/translator/po/ku-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ku-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ku-Arab-opac-bootstrap.po | 2 +- misc/translator/po/ku-Arab-staff-help.po | 2 +- misc/translator/po/ku-Arab-staff-prog.po | 2 +- misc/translator/po/lo-Laoo-marc-MARC21.po | 2 +- misc/translator/po/lo-Laoo-marc-NORMARC.po | 2 +- misc/translator/po/lo-Laoo-marc-UNIMARC.po | 2 +- misc/translator/po/lo-Laoo-opac-bootstrap.po | 2 +- misc/translator/po/lo-Laoo-staff-help.po | 2 +- misc/translator/po/lo-Laoo-staff-prog.po | 2 +- misc/translator/po/mi-NZ-marc-MARC21.po | 2 +- misc/translator/po/mi-NZ-marc-NORMARC.po | 2 +- misc/translator/po/mi-NZ-marc-UNIMARC.po | 2 +- misc/translator/po/mi-NZ-opac-bootstrap.po | 2 +- misc/translator/po/mi-NZ-staff-help.po | 2 +- misc/translator/po/mi-NZ-staff-prog.po | 2 +- misc/translator/po/ml-marc-MARC21.po | 2 +- misc/translator/po/ml-marc-NORMARC.po | 2 +- misc/translator/po/ml-marc-UNIMARC.po | 2 +- misc/translator/po/ml-opac-bootstrap.po | 2 +- misc/translator/po/ml-staff-help.po | 2 +- misc/translator/po/ml-staff-prog.po | 2 +- misc/translator/po/mon-marc-MARC21.po | 2 +- misc/translator/po/mon-marc-NORMARC.po | 2 +- misc/translator/po/mon-marc-UNIMARC.po | 2 +- misc/translator/po/mon-opac-bootstrap.po | 2 +- misc/translator/po/mon-staff-help.po | 2 +- misc/translator/po/mon-staff-prog.po | 2 +- misc/translator/po/mr-marc-MARC21.po | 2 +- misc/translator/po/mr-marc-NORMARC.po | 2 +- misc/translator/po/mr-marc-UNIMARC.po | 2 +- misc/translator/po/mr-opac-bootstrap.po | 2 +- misc/translator/po/mr-staff-help.po | 2 +- misc/translator/po/mr-staff-prog.po | 2 +- misc/translator/po/ms-MY-marc-MARC21.po | 2 +- misc/translator/po/ms-MY-marc-NORMARC.po | 2 +- misc/translator/po/ms-MY-marc-UNIMARC.po | 2 +- misc/translator/po/ms-MY-opac-bootstrap.po | 2 +- misc/translator/po/ms-MY-staff-help.po | 2 +- misc/translator/po/ms-MY-staff-prog.po | 2 +- misc/translator/po/my-marc-MARC21.po | 2 +- misc/translator/po/my-marc-NORMARC.po | 2 +- misc/translator/po/my-marc-UNIMARC.po | 2 +- misc/translator/po/my-opac-bootstrap.po | 2 +- misc/translator/po/my-staff-help.po | 2 +- misc/translator/po/my-staff-prog.po | 2 +- misc/translator/po/nb-NO-marc-MARC21.po | 2 +- misc/translator/po/nb-NO-marc-NORMARC.po | 2 +- misc/translator/po/nb-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nb-NO-opac-bootstrap.po | 2 +- misc/translator/po/nb-NO-staff-help.po | 2 +- misc/translator/po/nb-NO-staff-prog.po | 2 +- misc/translator/po/ne-NE-marc-MARC21.po | 2 +- misc/translator/po/ne-NE-marc-NORMARC.po | 2 +- misc/translator/po/ne-NE-marc-UNIMARC.po | 2 +- misc/translator/po/ne-NE-opac-bootstrap.po | 2 +- misc/translator/po/ne-NE-staff-help.po | 2 +- misc/translator/po/ne-NE-staff-prog.po | 2 +- misc/translator/po/nl-BE-marc-MARC21.po | 2 +- misc/translator/po/nl-BE-marc-NORMARC.po | 2 +- misc/translator/po/nl-BE-marc-UNIMARC.po | 2 +- misc/translator/po/nl-BE-opac-bootstrap.po | 2 +- misc/translator/po/nl-BE-staff-help.po | 2 +- misc/translator/po/nl-BE-staff-prog.po | 2 +- misc/translator/po/nl-NL-marc-MARC21.po | 2 +- misc/translator/po/nl-NL-marc-NORMARC.po | 2 +- misc/translator/po/nl-NL-marc-UNIMARC.po | 2 +- misc/translator/po/nl-NL-opac-bootstrap.po | 2 +- misc/translator/po/nl-NL-staff-help.po | 2 +- misc/translator/po/nl-NL-staff-prog.po | 2 +- misc/translator/po/nn-NO-marc-MARC21.po | 2 +- misc/translator/po/nn-NO-marc-NORMARC.po | 2 +- misc/translator/po/nn-NO-marc-UNIMARC.po | 2 +- misc/translator/po/nn-NO-opac-bootstrap.po | 2 +- misc/translator/po/nn-NO-staff-help.po | 2 +- misc/translator/po/nn-NO-staff-prog.po | 2 +- misc/translator/po/oc-marc-MARC21.po | 2 +- misc/translator/po/oc-marc-NORMARC.po | 2 +- misc/translator/po/oc-marc-UNIMARC.po | 2 +- misc/translator/po/oc-opac-bootstrap.po | 2 +- misc/translator/po/oc-staff-help.po | 2 +- misc/translator/po/oc-staff-prog.po | 2 +- misc/translator/po/pbr-marc-MARC21.po | 2 +- misc/translator/po/pbr-marc-NORMARC.po | 2 +- misc/translator/po/pbr-marc-UNIMARC.po | 2 +- misc/translator/po/pbr-opac-bootstrap.po | 2 +- misc/translator/po/pbr-staff-help.po | 2 +- misc/translator/po/pbr-staff-prog.po | 2 +- misc/translator/po/pl-PL-marc-MARC21.po | 2 +- misc/translator/po/pl-PL-marc-NORMARC.po | 2 +- misc/translator/po/pl-PL-marc-UNIMARC.po | 2 +- misc/translator/po/pl-PL-opac-bootstrap.po | 2 +- misc/translator/po/pl-PL-staff-help.po | 2 +- misc/translator/po/pl-PL-staff-prog.po | 2 +- misc/translator/po/prs-marc-MARC21.po | 2 +- misc/translator/po/prs-marc-NORMARC.po | 2 +- misc/translator/po/prs-marc-UNIMARC.po | 2 +- misc/translator/po/prs-opac-bootstrap.po | 2 +- misc/translator/po/prs-staff-help.po | 2 +- misc/translator/po/prs-staff-prog.po | 2 +- misc/translator/po/pt-BR-marc-MARC21.po | 2 +- misc/translator/po/pt-BR-marc-NORMARC.po | 2 +- misc/translator/po/pt-BR-marc-UNIMARC.po | 2 +- misc/translator/po/pt-BR-opac-bootstrap.po | 2 +- misc/translator/po/pt-BR-staff-help.po | 2 +- misc/translator/po/pt-BR-staff-prog.po | 2 +- misc/translator/po/pt-PT-marc-MARC21.po | 2 +- misc/translator/po/pt-PT-marc-NORMARC.po | 2 +- misc/translator/po/pt-PT-marc-UNIMARC.po | 2 +- misc/translator/po/pt-PT-opac-bootstrap.po | 40 +- misc/translator/po/pt-PT-staff-help.po | 12 +- misc/translator/po/pt-PT-staff-prog.po | 166 +- misc/translator/po/ro-RO-marc-MARC21.po | 2 +- misc/translator/po/ro-RO-marc-NORMARC.po | 2 +- misc/translator/po/ro-RO-marc-UNIMARC.po | 2 +- misc/translator/po/ro-RO-opac-bootstrap.po | 2 +- misc/translator/po/ro-RO-staff-help.po | 2 +- misc/translator/po/ro-RO-staff-prog.po | 2 +- misc/translator/po/ru-RU-marc-MARC21.po | 2 +- misc/translator/po/ru-RU-marc-NORMARC.po | 2 +- misc/translator/po/ru-RU-marc-UNIMARC.po | 2 +- misc/translator/po/ru-RU-opac-bootstrap.po | 2 +- misc/translator/po/ru-RU-staff-help.po | 2 +- misc/translator/po/ru-RU-staff-prog.po | 2 +- misc/translator/po/rw-RW-marc-MARC21.po | 2 +- misc/translator/po/rw-RW-marc-NORMARC.po | 2 +- misc/translator/po/rw-RW-marc-UNIMARC.po | 2 +- misc/translator/po/rw-RW-opac-bootstrap.po | 2 +- misc/translator/po/rw-RW-staff-help.po | 2 +- misc/translator/po/rw-RW-staff-prog.po | 2 +- misc/translator/po/sd-PK-marc-MARC21.po | 2 +- misc/translator/po/sd-PK-marc-NORMARC.po | 2 +- misc/translator/po/sd-PK-marc-UNIMARC.po | 2 +- misc/translator/po/sd-PK-opac-bootstrap.po | 2 +- misc/translator/po/sd-PK-staff-help.po | 2 +- misc/translator/po/sd-PK-staff-prog.po | 2 +- misc/translator/po/sk-SK-marc-MARC21.po | 2 +- misc/translator/po/sk-SK-marc-NORMARC.po | 2 +- misc/translator/po/sk-SK-marc-UNIMARC.po | 2 +- misc/translator/po/sk-SK-opac-bootstrap.po | 44 +- misc/translator/po/sk-SK-staff-help.po | 2 +- misc/translator/po/sk-SK-staff-prog.po | 3306 ++++++++++++----------- misc/translator/po/sl-SI-marc-MARC21.po | 2 +- misc/translator/po/sl-SI-marc-NORMARC.po | 2 +- misc/translator/po/sl-SI-marc-UNIMARC.po | 2 +- misc/translator/po/sl-SI-opac-bootstrap.po | 2 +- misc/translator/po/sl-SI-staff-help.po | 2 +- misc/translator/po/sl-SI-staff-prog.po | 2 +- misc/translator/po/sq-AL-marc-MARC21.po | 2 +- misc/translator/po/sq-AL-marc-NORMARC.po | 2 +- misc/translator/po/sq-AL-marc-UNIMARC.po | 2 +- misc/translator/po/sq-AL-opac-bootstrap.po | 2 +- misc/translator/po/sq-AL-staff-help.po | 2 +- misc/translator/po/sq-AL-staff-prog.po | 2 +- misc/translator/po/sr-Cyrl-marc-MARC21.po | 2 +- misc/translator/po/sr-Cyrl-marc-NORMARC.po | 2 +- misc/translator/po/sr-Cyrl-marc-UNIMARC.po | 2 +- misc/translator/po/sr-Cyrl-opac-bootstrap.po | 2 +- misc/translator/po/sr-Cyrl-staff-help.po | 2 +- misc/translator/po/sr-Cyrl-staff-prog.po | 2 +- misc/translator/po/sv-SE-marc-MARC21.po | 2 +- misc/translator/po/sv-SE-marc-NORMARC.po | 2 +- misc/translator/po/sv-SE-marc-UNIMARC.po | 2 +- misc/translator/po/sv-SE-opac-bootstrap.po | 326 +-- misc/translator/po/sv-SE-staff-help.po | 2 +- misc/translator/po/sv-SE-staff-prog.po | 135 +- misc/translator/po/sw-KE-marc-MARC21.po | 2 +- misc/translator/po/sw-KE-marc-NORMARC.po | 2 +- misc/translator/po/sw-KE-marc-UNIMARC.po | 2 +- misc/translator/po/sw-KE-opac-bootstrap.po | 2 +- misc/translator/po/sw-KE-staff-help.po | 2 +- misc/translator/po/sw-KE-staff-prog.po | 2 +- misc/translator/po/ta-LK-marc-MARC21.po | 2 +- misc/translator/po/ta-LK-marc-NORMARC.po | 2 +- misc/translator/po/ta-LK-marc-UNIMARC.po | 2 +- misc/translator/po/ta-LK-opac-bootstrap.po | 2 +- misc/translator/po/ta-LK-staff-help.po | 2 +- misc/translator/po/ta-LK-staff-prog.po | 2 +- misc/translator/po/ta-marc-MARC21.po | 2 +- misc/translator/po/ta-marc-NORMARC.po | 2 +- misc/translator/po/ta-marc-UNIMARC.po | 2 +- misc/translator/po/ta-opac-bootstrap.po | 2 +- misc/translator/po/ta-staff-help.po | 2 +- misc/translator/po/ta-staff-prog.po | 2 +- misc/translator/po/tet-marc-MARC21.po | 2 +- misc/translator/po/tet-marc-NORMARC.po | 2 +- misc/translator/po/tet-marc-UNIMARC.po | 2 +- misc/translator/po/tet-opac-bootstrap.po | 2 +- misc/translator/po/tet-staff-help.po | 2 +- misc/translator/po/tet-staff-prog.po | 2 +- misc/translator/po/th-TH-marc-MARC21.po | 2 +- misc/translator/po/th-TH-marc-NORMARC.po | 2 +- misc/translator/po/th-TH-marc-UNIMARC.po | 2 +- misc/translator/po/th-TH-opac-bootstrap.po | 2 +- misc/translator/po/th-TH-staff-help.po | 2 +- misc/translator/po/th-TH-staff-prog.po | 2 +- misc/translator/po/tl-PH-marc-MARC21.po | 2 +- misc/translator/po/tl-PH-marc-NORMARC.po | 2 +- misc/translator/po/tl-PH-marc-UNIMARC.po | 2 +- misc/translator/po/tl-PH-opac-bootstrap.po | 2 +- misc/translator/po/tl-PH-staff-help.po | 2 +- misc/translator/po/tl-PH-staff-prog.po | 2 +- misc/translator/po/tr-TR-marc-MARC21.po | 2 +- misc/translator/po/tr-TR-marc-NORMARC.po | 2 +- misc/translator/po/tr-TR-marc-UNIMARC.po | 2 +- misc/translator/po/tr-TR-opac-bootstrap.po | 39 +- misc/translator/po/tr-TR-staff-help.po | 2 +- misc/translator/po/tr-TR-staff-prog.po | 150 +- misc/translator/po/uk-UA-marc-MARC21.po | 2 +- misc/translator/po/uk-UA-marc-NORMARC.po | 2 +- misc/translator/po/uk-UA-marc-UNIMARC.po | 2 +- misc/translator/po/uk-UA-opac-bootstrap.po | 29 +- misc/translator/po/uk-UA-pref.po | 31 +- misc/translator/po/uk-UA-staff-help.po | 2 +- misc/translator/po/uk-UA-staff-prog.po | 21 +- misc/translator/po/ur-Arab-marc-MARC21.po | 2 +- misc/translator/po/ur-Arab-marc-NORMARC.po | 2 +- misc/translator/po/ur-Arab-marc-UNIMARC.po | 2 +- misc/translator/po/ur-Arab-opac-bootstrap.po | 2 +- misc/translator/po/ur-Arab-staff-help.po | 2 +- misc/translator/po/ur-Arab-staff-prog.po | 2 +- misc/translator/po/vi-VN-marc-MARC21.po | 2 +- misc/translator/po/vi-VN-marc-NORMARC.po | 2 +- misc/translator/po/vi-VN-marc-UNIMARC.po | 2 +- misc/translator/po/vi-VN-opac-bootstrap.po | 2 +- misc/translator/po/vi-VN-staff-help.po | 2 +- misc/translator/po/vi-VN-staff-prog.po | 2 +- misc/translator/po/zh-Hans-CN-marc-MARC21.po | 20 +- misc/translator/po/zh-Hans-CN-marc-NORMARC.po | 10 +- misc/translator/po/zh-Hans-CN-marc-UNIMARC.po | 18 +- misc/translator/po/zh-Hans-CN-opac-bootstrap.po | 19 +- misc/translator/po/zh-Hans-CN-pref.po | 36 +- misc/translator/po/zh-Hans-CN-staff-help.po | 50 +- misc/translator/po/zh-Hans-CN-staff-prog.po | 31 +- misc/translator/po/zh-Hans-TW-marc-MARC21.po | 2 +- misc/translator/po/zh-Hans-TW-marc-NORMARC.po | 2 +- misc/translator/po/zh-Hans-TW-marc-UNIMARC.po | 2 +- misc/translator/po/zh-Hans-TW-opac-bootstrap.po | 2 +- misc/translator/po/zh-Hans-TW-staff-help.po | 2 +- misc/translator/po/zh-Hans-TW-staff-prog.po | 23 +- opac/opac-showmarc.pl | 14 +- 498 files changed, 5609 insertions(+), 5281 deletions(-) create mode 100644 misc/release_notes/release_notes_17_11_04.md hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Mar 28 14:02:03 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 28 Mar 2018 12:02:03 +0000 Subject: [koha-commits] main Koha release repository annotated tag v17.11.04 created. v17.11.04 Message-ID: <E1f19mF-0007Pr-UZ@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v17.11.04 has been created at 5ae1c85d1d2c48c4328ca2784ee4ecf312fcee66 (tag) tagging d0a0390b9d5739d582dd98165f321c49e08a02a4 (commit) replaces v17.11.03 tagged by Nick Clemens on Wed Mar 28 07:52:36 2018 -0400 - Log ----------------------------------------------------------------- Koha release 17.11.04 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABAgAGBQJau4IEAAoJEGolcazKjUn0wJYP/jJvyaJRNXsbSP128ClSTEER MIGq2u9M2d83z5eLTjoQg/kCBWO9DR7LT12TByk+UfGrY1Cfns819rN5wj0H38Jd Yut5foORMmygNjgzQnsPn1pEmfK8IuGN5zykU2aAKPNLI14gbctQ1BWeG2Nzh1Hv SjQDQHvyU7VcYGNo5/QIX6+9K2aZVfRxkCacU1EnIvaBbiPnUf15c78c4/+0efyW ZUg2KoKuIwtyKD96W2kIDOTHMvi1G+rZm9z7xPyLKz125XwXbS04T6jq5RM3W6eV ETHTBh0rrkmOWDQIJq3+WF8DIGDIkPOQi0MWsIVepbN8GjsIXacGb0I1CcqRsEY2 iZlxv9puJITzEDlsP9Y4baapEdUIKfmGuB4WgvQMsyUTV3F2eQBgVJ5ttgMW5FE/ ciCIoK4XWX1u5V2qRSbP9QMcnaS1Xw79F6zxDdEgvnwBh2iq0zS2r0U5WS+i4/Dh lf7ePWfNopYqsb9l9sKgXHOiL7K74CEVAni6o9PPRhNCW5B1lSo6xEpqzMdQuH7w FjpRHPBd5MtOcl37OTWbNaTVpos27DN+DdldTylYU6ucHTIN2ZUqTyz29bmg8P90 /2o2pNC68vRCSztGKt8oI3MDcbQYL00ICycRywp9nEjT7mZoq9eKWrGI1fxkPiVn gO9SrBzvFyViWVlhKScs =H9zs -----END PGP SIGNATURE----- Andreas Roussos (1): Bug 20083 - Information disclosure when (mis)using the MARC Preview feature Colin Campbell (1): Bug 20446 Revert to using syspref for item creation Jonathan Druart (6): Bug 20145: Do not insert 0000-00-00 in patron tests (and more) Bug 20148: Prevent adding same user multiple times to an order Bug 20250: (bug 19529 follow-up) Prevent NoIssuesChargeGuarantees.t to fail randomly Bug 19979: ->count can be called directly on Koha::Objects Bug 20303: Do not explode when receiving an order if authorisedby not set Bug 20466: Fix fixture syntax in t/Prices.t Jose Martin (1): Bug 20348: SIP2 patron identification fails to use userid Koha translators (1): Translation updates for Koha 17.11.04 Lari Taskula (1): Bug 20367: Avoid resetting userid when BorrowerUnwantedField contains userid Marcel de Rooy (2): Bug 19452: [17.11.x] Remove the truncate option Bug 19979: Fix get_facets_info test in Search.t Mark Tompsett (2): Bug 20201: Silence warnings triggered by admin/aqplan.pl Bug 20083: Follow up - use same logic in opac-showmarc Nick Clemens (3): Bug 20218: Fix matching of uri in tracklinks Increment version for 17.11.04 release Update relase notes for 17.11.04 release Pasi Kallinen (1): Bug 20148: Prevent adding same user multiple times to acq basket Tomas Cohen Arazi (2): Bug 20167: Regression test Bug 20167: Make changing a hold pass the itemnumber to ModReserve ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 29 17:11:06 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 29 Mar 2018 15:11:06 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.11.00-987-gfbf3744 Message-ID: <E1f1ZCk-00079T-Ka@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via fbf374498bb327b2948904fd8783944ab2a9e389 (commit) via a7e46047cffbca02d08049729911a274970244f5 (commit) via 87dc9b0ac1db2b689385a5b65e7d1293ea8bca0a (commit) via 10de4f437f3ca9f368e52f79ab6fb1b86c916209 (commit) via dce823c12255c8d3db3761c30fc04370d3682157 (commit) via 2183c7a175f1ac3648b7963a5d18dce0cd2936f9 (commit) via e36dc18376390d2747ce5d831064146817cd24c9 (commit) via 6c3a273af93dbe64d050190a6cdfb9e9453a9364 (commit) via dd9b6c165163ac1d6b52df6f2df17ec5de6b2758 (commit) via 7b8909cb9080216352b0a68564476c8861f7e790 (commit) via 275c5bd4fa11c30606d11d7bfb2eab8c0a31ed04 (commit) via ae57ac3792d16c546efdd4949c07218e8ccccf0b (commit) via 8b76ee39d4b3696d9ec7e71cdcc785b2980e10ff (commit) via 3afd4a7e1aff525d870aef5d4693016885a6dbcf (commit) via 8e07761f30c576e5f8b275d83ce6dea578148e94 (commit) via 444ac690745cb360db852303b1ff461fa8c7175e (commit) via e3e7c265acea3e30313d9f824ee27e5391bf71e8 (commit) via 8c12ddd88d5a3b04faa260a8fbbcc253f7c26c2d (commit) via e2869cb0143a6176e44ff5bf0b4d0dda65be7e2e (commit) via e0fbc15c9764e5cff1edf8b71d8c0f3370aa8da4 (commit) via 735b4e0fc027f7e8a66640fe11174f709131160f (commit) via ac38492107c14acd2651cae07beeb81a56d4f132 (commit) via 0a9031676eefbccad1afa6594df8990b8202b0fa (commit) from 64616fe2ffc35bf65aa28dcbc36b30e648591cf2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fbf374498bb327b2948904fd8783944ab2a9e389 Author: Lari Taskula <lari.taskula at jns.fi> Date: Wed Mar 28 21:19:52 2018 +0000 Bug 20490: Correct bug number typo in comment in Circulation.t NOTE: Confirmed that the typo of 17641 was part of bug 17941. Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit a7e46047cffbca02d08049729911a274970244f5 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Fri Dec 8 09:35:45 2017 -0300 Bug 19784: Adapt /v1/patrons to new naming guidelines This patch introduces two functions to the patrons endpoint: - _to_api - _to_model This are in charge of field mappings in order to comply with the guidelines. Koha::REST::V1:Auth is adjusted to handle 'patron_id' as well. 'borrowernumber' handling is kept until the existing endpoints get updated. To test: - Apply the patches - Run: $ kshell k$ prove t/db_dependent/api/v1/*.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 87dc9b0ac1db2b689385a5b65e7d1293ea8bca0a Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Fri Dec 8 09:25:35 2017 -0300 Bug 19784: Remove reference to 'borrowernumber' param from other endpoints This patch removes the $ref occurences for borrowernumber in not patron-specific endpoints. 'borrowernumber' is still used on them, but as a hardcoded parameter. The param rename will happen on a separate bug for each endpoint. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 10de4f437f3ca9f368e52f79ab6fb1b86c916209 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Fri Dec 8 09:17:28 2017 -0300 Bug 19784: Unit tests for /api/v1/patrons This patch adapts the existing endpoint's tests so they expect: - 'patron_id' for 'borrowernumber' - 'library_id' for 'branchcode' - 'category_id' for 'categorycode' In the process, I tried to make the tests more robust, by creating random data that gets deleted to make sure our tests cases can't have false positives. Independent subtests are wrapped inside transactions to avoid eventual interference. To test: - Apply the patch - Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => FAIL: The api doesn't implement the expected behaviour and attributes for endpoint responses Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit dce823c12255c8d3db3761c30fc04370d3682157 Author: Josef Moravec <josef.moravec at gmail.com> Date: Mon Feb 19 07:15:22 2018 +0000 Bug 16330: (QA follow-up) Update usage of search plugin because of bug 19686 Test plan: prove t/db_dependent/api/v1/patrons.t --> without patch the list subtest fail --> with patch test pass Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 2183c7a175f1ac3648b7963a5d18dce0cd2936f9 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Tue Dec 19 14:46:45 2017 -0300 Bug 16330: Remove validation code from Koha::Patron This patch removes previously added validation code from Koha::Patron as we will rely on the DB structure and relationships to catch the same problems. This is implemented on bug 19828. This patch also adapts the API controller class to expect this behaviour change from Koha::Patron. The expected exceptions are adjusted, and some minor changes take place. The API tests are adjusted as well. To test: - Run: $ kshell k$ prove t/db_dependent/Koha/Patrons.t k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests should still pass Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit e36dc18376390d2747ce5d831064146817cd24c9 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Tue Dec 12 18:53:45 2017 -0300 Bug 16330: (QA follow-up) ModMember requires borrowernumber Works perfectly. Well done everyone! Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> Signed-off-by: Dilan Johnpull? <dilan at calyx.net.au> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 6c3a273af93dbe64d050190a6cdfb9e9453a9364 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Tue Dec 5 16:43:00 2017 -0300 Bug 16330: (QA follow-up) Repect guidelines on plurals Patron > Patrons Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit dd9b6c165163ac1d6b52df6f2df17ec5de6b2758 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Mon Dec 4 16:18:47 2017 -0300 Bug 16330: Move patches to OpenAPI This patch refactors the original work so it implements the controllers and the spec using Mojolicious::Plugin::OpenAPI, and OpenAPI for the specification. It removes the ability for patrons without permissions to edit their own data or their guarantee's. This will be moved to a patron modification requests endpoint for simplicity. It makes use of bugs 19410 and 19686 and their dependencies to deal with parameters handling, query building and pagination. Tests are adapted. To test: - Apply this patches and the dependencies - Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 7b8909cb9080216352b0a68564476c8861f7e790 Author: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> Date: Wed Apr 27 13:47:04 2016 +0000 Bug 16330: Add routes to add, update and delete patrons This patch adds support for add, edit and delete patrons via REST API. GET /api/v1/patrons Get patron list from params GET /api/v1/patrons/<borrowernumber> Get single patron POST /api/v1/patrons Create a new patron PUT /api/v1/patrons/<borrowernumber> Update data about patron DEL /api/v1/patrons/<borrowernumber> Delete a patron Revised Test plan: 1) Apply this patch 2) Run tests perl t/db_dependent/api/v1/patrons.t 3) Add a user with proper rights to use the REST API 4) play with your favourite REST client (curl/httpie, etc.): Authenticate with the user created above and get a CGISESSION id. Use the CGISESSION to add, edit and delete patrons via the API. 5) Use PUT /patrons/<borrowernumber> for a patron without borrowers flag. This should go into pending patron modification status and needs to be accepted by a librarian. Please note there is no validation of body input in PUT/POST other than branchcode,category,userid,cardnumber. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 275c5bd4fa11c30606d11d7bfb2eab8c0a31ed04 Author: Katrin Fischer <katrin.fischer.83 at web.de> Date: Sun Mar 25 22:10:22 2018 +0200 Bug 19488: (QA follow-up) Fix spelling, remove () Fixes spelling to match the details page and removes (). Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit ae57ac3792d16c546efdd4949c07218e8ccccf0b Author: Jesse Maseto <jesse at bywatersolutions.com> Date: Fri Mar 2 14:48:06 2018 +0000 Bug 19488: Add borrowernumber to brief info on patron details pages in staff client To test: - View different tabs of a borrower's patron account in staff - Verify the borrowernumber is shown in the brief info section on the left Signed-off-by: JM Broust <jean-manuel.broust at univ-lyon2.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 8b76ee39d4b3696d9ec7e71cdcc785b2980e10ff Author: Nick Clemens <nick at bywatersolutions.com> Date: Wed Mar 28 12:42:19 2018 +0000 Bug 19564: (QA follow-up) Make commented out tests pass We likely shoudln't pass through an uncoverted sort order for now, but it does allow us to look ahead to implementing the orders directly so seems a good option to have. Either this patch should be used, or the commented out tests should be removed Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 3afd4a7e1aff525d870aef5d4693016885a6dbcf Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Fri Dec 22 15:21:51 2017 -0300 Bug 19564: Add tests for _convert_sort_fields Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 8e07761f30c576e5f8b275d83ce6dea578148e94 Author: David Gustafsson <david.gustafsson at ub.gu.se> Date: Thu Nov 2 15:02:23 2017 +0100 Bug 19564: Fix extraction of sort order from sort condition name Currently sort order is extracted from sort condition by splitting the field, instead use regular expression to extract the last part preceded by underscore. Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 444ac690745cb360db852303b1ff461fa8c7175e Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Wed Dec 20 21:35:47 2017 -0300 Bug 19673: Allow to set patron attributes to 0 with batch patron modification This patch will have to be tested deeply to make sure it will not introduce regression! The idea is to display an empty option in the patron attributes select and ignore it. That way we can deal with false values 0 and "" which were skipped before. Test plan: Add several patron attributes Use the batch patron modification tool to add/update/remove them Play with empty "" and 0 values, as well as other values Modify several attributes in a row Signed-off-by: Charles Farmer <charles.farmer at inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit e3e7c265acea3e30313d9f824ee27e5391bf71e8 Author: Nick Clemens <nick at bywatersolutions.com> Date: Thu Jan 4 15:31:52 2018 +0000 Bug 19916: Add keyword and standard ID fields to acq external search To test: 1 - Add an order from external source 2 - Note you don't have keyword or standard ID fields 3 - Add a catalog record from Z3950, note those fields are there 4 - Apply patch 5 - Check acq and note you do have those fields 6 - Do some searches to verify they work as expected Signed-off-by: Maksim Sen <maksim.sen at inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 8c12ddd88d5a3b04faa260a8fbbcc253f7c26c2d Author: Pasi Kallinen <pasi.kallinen at joensuu.fi> Date: Mon Mar 5 09:09:28 2018 +0200 Bug 20330: Allow translating more of quote upload Translate the error messages, and the table headers. Test plan: 1) Go to Home -> Tools -> Quote editor -> Import quotes 2) Upload quotes from a file. Try to trigger the error messages 3) On successful import, check the table header texts 4) Apply patch, update & install a language 5) The error messages and the table header texts should show up in the xx-YY-staff-prog.po 6) Repeat 1,2,3 Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi> Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit e2869cb0143a6176e44ff5bf0b4d0dda65be7e2e Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Wed Mar 28 15:54:56 2018 -0300 Bug 18055: The 2 new deps are used for testing purpose Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit e0fbc15c9764e5cff1edf8b71d8c0f3370aa8da4 Author: Tomas Cohen Arazi <tomascohen at theke.io> Date: Fri Sep 1 12:25:27 2017 -0300 Bug 18055: (QA followup) Only print output if DEBUG Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 735b4e0fc027f7e8a66640fe11174f709131160f Author: Mason James <mtj at kohaaloha.com> Date: Fri Jun 16 01:20:05 2017 +1200 Bug 18055: Speed up '00-strict.t' test, with Parallel::ForkManager add KOHA_PROVE_CPUS envar to manually set number of cpus to test.. 1/ set number of cpus to 1 $ export KOHA_PROVE_CPUS=1 2/ observe 1 cpus are used $ time prove -v t/db_dependent/00-strict.t t/db_dependent/00-strict.t .. Using 1 CPUs... 3/ unset number of cpus $ export KOHA_PROVE_CPUS= 4/ observe all available cpus are used $ time prove -v t/db_dependent/00-strict.t t/db_dependent/00-strict.t .. Using 32 CPUs... Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit ac38492107c14acd2651cae07beeb81a56d4f132 Author: Mason James <mtj at kohaaloha.com> Date: Sun Feb 5 14:40:06 2017 +1300 Bug 18055: Speed up '00-strict.t' test, with Parallel::ForkManager to test... 1/ run 00-strict.t test, (16.5 mins on a 4xcpu system) $ time prove t/db_dependent/00-strict.t ... Files=1, Tests=654, 994 wallclock secs ( 0.19 usr 0.04 sys + 873.40 cusr 116.20 csys = 989.83 CPU) Result: PASS real 16m34.104s 2/ apply patch 3/ install Parallel::ForkManager package $ sudo apt-get install libparallel-forkmanager-perl libsys-cpu-perl 4/ run 00-strict.t test again, (now 6 mins.. much faster) $ time prove t/db_dependent/00-strict.t ... Files=1, Tests=654, 364 wallclock secs ( 0.07 usr 0.01 sys + 1159.20 cusr 153.41 csys = 1312.69 CPU) Result: PASS real 6m4.355s Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Edit: removed debian/control changes as the file is generated Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> commit 0a9031676eefbccad1afa6594df8990b8202b0fa Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Mon Mar 26 13:13:58 2018 -0300 Bug 20455: Fix sort patrons by date expired We may need to apply this change for all other occurrences in our codebase. Test plan: - Make sure sample patron data is loaded and you have a patron without a date expired defined - Make an empty search for all patrons or another search that gives you a good amount of results - Try to sort on the date expired column => Without this patch you get Odd number of elements in anonymous hash at /home/vagrant/kohaclone/C4/Utils/DataTables/Members.pm line 189. output_pref is called with 'dateonly' (ref SCALAR), not a DateTime object Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> ----------------------------------------------------------------------- Summary of changes: C4/Installer/PerlDependencies.pm | 11 +- C4/Utils/DataTables/Members.pm | 2 +- Koha/Exceptions.pm | 8 +- Koha/Patron.pm | 16 +- Koha/REST/V1/Auth.pm | 9 +- Koha/REST/V1/Patron.pm | 45 -- Koha/REST/V1/Patrons.pm | 499 ++++++++++++++++ Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 4 +- acqui/z3950_search.pl | 8 +- api/v1/swagger/definitions/hold.json | 3 +- api/v1/swagger/definitions/patron.json | 140 ++--- api/v1/swagger/parameters.json | 8 +- api/v1/swagger/parameters/patron.json | 10 +- api/v1/swagger/paths.json | 4 +- api/v1/swagger/paths/holds.json | 7 +- api/v1/swagger/paths/illrequests.json | 6 +- api/v1/swagger/paths/patrons.json | 609 +++++++++++++++++++- api/v1/swagger/x-primitives.json | 4 +- .../intranet-tmpl/prog/en/includes/circ-menu.inc | 3 +- .../prog/en/modules/acqui/z3950_search.tt | 2 + .../prog/en/modules/tools/modborrowers.tt | 22 +- .../prog/en/modules/tools/quotes-upload.tt | 14 +- t/db_dependent/00-strict.t | 61 +- t/db_dependent/Circulation.t | 4 +- .../Koha_SearchEngine_Elasticsearch_Search.t | 25 +- t/db_dependent/api/v1/patrons.t | 505 ++++++++++++---- tools/modborrowers.pl | 3 - 27 files changed, 1735 insertions(+), 297 deletions(-) delete mode 100644 Koha/REST/V1/Patron.pm create mode 100644 Koha/REST/V1/Patrons.pm mode change 100644 => 100755 t/db_dependent/00-strict.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 29 17:57:14 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 29 Mar 2018 15:57:14 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.11.00-988-g43e57ef Message-ID: <E1f1ZvO-0001Gi-N2@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 43e57efa523ad05f45eb2ff5dcb928877b3b4209 (commit) from fbf374498bb327b2948904fd8783944ab2a9e389 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 43e57efa523ad05f45eb2ff5dcb928877b3b4209 Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Thu Mar 29 12:45:39 2018 -0300 Bug 16330: Remove unecessary Koha::Patron->store method Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> ----------------------------------------------------------------------- Summary of changes: Koha/Patron.pm | 12 ------------ 1 file changed, 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Mar 29 20:40:02 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 29 Mar 2018 18:40:02 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.11.00-989-gcaba1b2 Message-ID: <E1f1cSw-0001YS-Be@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via caba1b2daef753c7db946851491ce75ac978798c (commit) from 43e57efa523ad05f45eb2ff5dcb928877b3b4209 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit caba1b2daef753c7db946851491ce75ac978798c Author: Owen Leonard <oleonard at myacpl.org> Date: Thu Mar 29 17:57:01 2018 +0000 Bug 20498: (bug 19641 follow-up) Patron advanced search form missing from patron entry page My patch moving patron-related templates' javascript to the footer left out a script from the patron entry template which is required if the patron header search menu is going to work. To test, apply the patch and go to Patrons -> New patron. Clicking the [+] link in the "Search patrons" header search form should expand the advanced search options. Test that the page's toolbar still "floats" correctly when you scroll the page. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Mar 30 18:24:59 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 30 Mar 2018 16:24:59 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.11.00-990-g08039f4 Message-ID: <E1f1wpn-0006sk-O7@git.koha-community.org> This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 08039f41c196f9119e5ca82f762e5260d8c81a1a (commit) from caba1b2daef753c7db946851491ce75ac978798c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 08039f41c196f9119e5ca82f762e5260d8c81a1a Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Fri Mar 30 13:14:46 2018 -0300 Bug 20503: Prevent Borrower_PrevCheckout.t to fail randomly category_type must be != "X" Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Patron/Borrower_PrevCheckout.t | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository