[koha-commits] main Koha release repository branch master updated. v17.11.00-823-g5dc0d1c
Git repo owner
gitmaster at git.koha-community.org
Mon Mar 19 18:05:14 CET 2018
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 5dc0d1c8bc916ba3acaa6349199f5d9b60ffef8b (commit)
via 79f5051ed767bcc50cd2187a57b136eabbb513fb (commit)
via c2208e9ca7526f70dc1bf87a8f7fb109b4a269bf (commit)
via a674795972907e9562b3e5feb881c1e589c8e40d (commit)
via 2a3cc2f98b7d85c1d4f7471be593452c7903ab22 (commit)
via e7b004689c901af68d65bda6b36054b4242ef6e9 (commit)
via 246746759afd39a4bf67aca9fc944b4659fb740d (commit)
via 6d1525dbf1f0783ef90274b1e925e125bededb37 (commit)
via c0132ffdcfe759ea16ea6642ce041c6fdde7f9e9 (commit)
via 4271f90a06c3fef825e11efe6b53c858a3437f58 (commit)
via 84bd0a17cc3401eb9718c30ae74c7898e7116cb3 (commit)
via 80d6abf886213d85fad562ceb6be82064fafb640 (commit)
via 9f94c8caafa341f395db60dfbfe1645b6885777e (commit)
via c53f83afc6cfe49cd5f6424f709ecabb0286a405 (commit)
via ceaf74a287f35986115716700de9a32086d33656 (commit)
via 8b32870ac016312b1809fca26b4d04b28ea5fcf3 (commit)
via 5b2e49141586d0c169de5a67349cd9785836b8e6 (commit)
via 70941cde0ec70c4f59ff51abd713594a92cf1e3f (commit)
via f0772f0c55a5ffba2b5e26587ba0ea8c91c09c8c (commit)
via 73c21c4d30539371bb255346384bfa9f7cd945f8 (commit)
via d9ce37ff3e7f351bdf3506e925b1333217743cea (commit)
via aea565e71e0cf81933af3a45e9ad6511ba0a96c3 (commit)
via f24e48577f478bf6d5132cce2a59febf8d36ce6d (commit)
via 6d479dc5e53e3558207c75b73d58bce23328a61d (commit)
via dd559df8b9f839b8dcfe765ba0e503a0c65aa3e6 (commit)
via a67fdf3bd498bf1c5a90c2847570ea8eff9c52da (commit)
via 4159512fc5639cccaf1c563e1bc824f3010d3f6a (commit)
via e24e7ad7f17fb957c6747fa76ff79be30769eaa1 (commit)
via be4d4a8e28a85f2baf90b03127428cadb551a00e (commit)
from bb97767501a016609743c354b781a0783eb6e66b (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 5dc0d1c8bc916ba3acaa6349199f5d9b60ffef8b
Author: Pasi Kallinen <pasi.kallinen at joensuu.fi>
Date: Wed Mar 7 09:35:19 2018 +0200
Bug 20347: Add missing classes to search results elements
The MARC21 XSLT doesn't add html classes to distinguish between
certain elements, and there's no way to rely on the element
positioning, making it impossible to style the elements with CSS.
Add the missing classes to distinguish the elements.
Test plan:
1) Apply patch
2) Search for any biblios
3) Check the search result page table HTML to see that the
"Publisher", "Edition", "Source", "Other title", and "Online access"
are wrapped in a span with class of results_summary and one
of "publisher", "edition", "source", "other_title", and
"online_access"
4) Check that the search results of the elements above looks correct
when compared to the other elements
Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi>
Signed-off-by: Sebastian Hierl <s.hierl at aarome.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 79f5051ed767bcc50cd2187a57b136eabbb513fb
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Mon Mar 12 11:51:59 2018 +0100
Bug 11936: (QA follow-up) Consistent log message for item insert
Fix the same error in another place
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c2208e9ca7526f70dc1bf87a8f7fb109b4a269bf
Author: Magnus Enger <magnus at libriotech.no>
Date: Thu Feb 22 10:37:08 2018 +0100
Bug 11936: Consistent log message for item insert
If you use bulkmarcimport.pl to import records with items it looks
like the successfull insert of the record is reported multiple time,
but the second and subsequent "ok" is really related to importing
the item(s).
This patch changes the log message on successfully inserting an item
to match the log message given when inserting an item fails.
To test, the easy way:
- Look at lines 530 and 536 of bulkmarcimport.pl, and note that the
"op" in those two lines are different
- Apply the patch
- Look at lines 530 and 536 again, and note that the "op" is now
identical, and that this makes sense, since they are both related
to the same operation, specifically inserting an item
To test, the hard way
- Have some records with items
- Import the records with bulkmarcimport.pl, and make sure to specify
the -l option, to create a log of the actions taken
- Look at the log and verify it looks something like this:
id;operation;status
1;insert;ok
1;insert;ok
2;insert;ok
2;insert;ok
- Apply this patch and import some more records with items. The log
should now be similar to this:
id;operation;status
1;insert;ok
1;insertitem;ok
2;insert;ok
2;insertitem;ok
Signed-off-by: Maksim Sen <maksim.sen at inlibro.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit a674795972907e9562b3e5feb881c1e589c8e40d
Author: Claire Gravely <claire.gravely at bsz-bw.de>
Date: Tue Mar 13 08:53:29 2018 +0000
Bug 20382: Missing space between patron and cardnumber on check out screen
There should be a space between patron name and cardnumber on the check
out screen.
This patch adds a space between patron and cardnumber.
To test:
1 type a patron name into the check out search or go to the check out
tab from a patron record
2 Confirm there is no space between patron name and cardnumber on the
check out page
3 apply patch
4 confirm there is now a space
5 sign off :)
Signed-off-by: Sebastian Hierl <s.hierl at aarome.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2a3cc2f98b7d85c1d4f7471be593452c7903ab22
Author: Pasi Kallinen <pasi.kallinen at joensuu.fi>
Date: Wed Feb 14 12:12:52 2018 +0200
Bug 20195: Untranslatable Show/Hide title attr replacement in opac detail
There's javascript code in opac detail view that tries to replace
the word "Show" with "Hide" (and vice versa) in a title attribute.
In addition to those words being untranslatable, a word replacement
like that would not work properly when using other languages.
Replace the single title attribute with two translatable strings,
one for the "Show" case and one "Hide", and use the whole
string instead of trying to replace a single word.
Test plan:
1) Make sure OpacBrowseResults is on
2) in OPAC, search the catalog and go to the detail view
3) Hover the mouse over the "Browse results" text in the grey box on the
right side. The popup text should show something like
"Show pagination list (1-5 / 5)"
4) Click on the "Browse results"
5) Hover the mouse again over the text. The popup should show
"Hide pagination list (1-5 / 5)"
6) Update a language xx-YY, translate the new msgids
"Show pagination list (%s-%s / %s)" and
"Hide pagination list (%s-%s / %s)", and install the language
7) Repeat 2-5 with that language, making sure the popup
texts show up correctly in that language
Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e7b004689c901af68d65bda6b36054b4242ef6e9
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Mar 13 10:15:31 2018 +0000
Bug 20383: Hide link to plugin management if plugins are not enabled
This patch adds a check in admin-home.pl to see whether plugins are
enabled. If plugins are disabled, the link to plugins management is
hidden even if the user has plugin management permission.
To test, view the administration home page with plugins enabled and
disabled via the enable_plugins flag in the Koha configuration file.
Also test using users with different plugins permissions:
- Plugins enabled
- CAN_user_plugins = 1
-> Plugins link appears
- CAN_user_plugins = 0
-> Plugins link hidden
- Plugins disabled
- CAN_user_plugins = 1,
- CAN_user_plugins = 0
-> Plugins link hidden
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 246746759afd39a4bf67aca9fc944b4659fb740d
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Mar 12 12:56:08 2018 +0000
Bug 20372: Correct toolbar markup on some pages
Differences in markup around some toolbars has the potential to create
CSS styling problems. This patch changes the markup to be consistent
with other instances of <div id="toolbar"></div>
To test, apply the patch and view these pages:
- Course reserves (main page)
- Course reserves -> Course detail page
- Reports -> Dictionary
On each of these pages the toolbar should look correct.
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6d1525dbf1f0783ef90274b1e925e125bededb37
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Mar 1 16:30:35 2018 +0000
Bug 20321: Remove get_biblionumber_from_isbn
To test:
1 - grep get_biblionumber_from_isbn
2 - verify all occurences are not actual calls (except for test)
3 - Apply patch
4 - grep get_biblionumber_from_isbn
5 - Verify it is removed
Signed-off-by: Roch D'Amour <roch.damour at inlibro.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c0132ffdcfe759ea16ea6642ce041c6fdde7f9e9
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Thu Jul 6 18:51:56 2017 +0000
Bug 18908: Warning "Compatibility levels before 9 are deprecated"
The following output:
dh: Compatibility levels before 9 are deprecated (level 7 in use)
dh_testdir -O--fail-missing
dh_auto_clean -O--fail-missing
dh_auto_clean: Compatibility levels before 9 are deprecated (level 7 in use)
dh_clean -O--fail-missing
is given when trying to following these instructions:
https://wiki.koha-community.org/wiki/Building_Debian_Packages_-_The_Easy_Way
This merely tweaks the debian/compat file from 7 to 9.
The message goes away.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
From https://www.debian.org/doc/manuals/maint-guide/dother.en.html:
You may use compat level v9 in certain circumstances for compatibility with older systems. However, using any level below v9 is not recommended and should be avoided for new packages.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 4271f90a06c3fef825e11efe6b53c858a3437f58
Author: Maksim Sen <maksim.sen at inlibro.com>
Date: Mon Mar 12 16:15:30 2018 -0400
Bug 20376: Make select/unselect all ignore disabled checkboxes on batch record deletion
Test Plan:
0.1 - find at least one biblionumber that has at least one item checked out
0.2 - find at least one biblionumber that has zero items checked out.
1 - Go into the module "Tools > Batch record deletion"
2 - in "List of biblionumbers or authority ids (one per line)" put the values you found in step 0.1 and 0.2
3 - click continue
4 - biblionumbers with at least one item checked out should not be clickable.
5 - biblionumbers with zero items checked out should be clickable.
6 - click "Select all" and "Clear all", both buttons should change the "checked" status of the enabled AND disabled biblionumber checkboxes.
7 - apply patch
8 - click "Select all" and "Clear all", both buttons should change the "checked" status of ONLY the enabled biblionumber checkboxes.
Signed-off-by: JM Broust <jean-manuel.broust at univ-lyon2.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 84bd0a17cc3401eb9718c30ae74c7898e7116cb3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Feb 15 16:00:20 2018 -0300
Bug 20219: Remove t/smolder_smoke_signal
The file is no longer used (is it?) and the project looks dead. Let
remove that file.
Signed-off-by: Roch D'Amour <roch.damour at inlibro.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 80d6abf886213d85fad562ceb6be82064fafb640
Author: David Cook <dcook at prosentient.com.au>
Date: Mon Feb 19 10:11:29 2018 +1100
Bug 20173: Fix favicon.ico path in installer
This patch corrects the favicon.ico path for the installer.
On git installs, it used to point to ./koha-tmpl/favicon.ico,
and on regular installs, it probably just didn't work.
https://bugs.koha-community.org/show_bug.cgi?id=20173
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9f94c8caafa341f395db60dfbfe1645b6885777e
Author: David Cook <dcook at prosentient.com.au>
Date: Mon Feb 12 13:44:50 2018 +1100
Bug 20173: Clean up koha-tmpl directory
This patch removes some HTML and ico files that are no longer
used in Koha.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c53f83afc6cfe49cd5f6424f709ecabb0286a405
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Mar 1 15:00:18 2018 +0000
Bug 20268: CSS regression: white gap on the top of the staff pages
This patch makes template and CSS changes so that the staff client main
page doesn't get an unwanted top margin from the Bootstrap-grid
conversion.
- The unused "main" class is removed from the login page
- The "main" class on the staff client home page is changed to
"intranet-main."
- The CSS for the staff client home page has been modified accordingly.
To test, apply the patch and clear your browser cache if necessary.
- Open the staff client login page. It should look as it always does.
- Log in and check the style of the main page. There should be no white
margin at the top of the page.
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ceaf74a287f35986115716700de9a32086d33656
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Tue Oct 31 02:28:58 2017 +0000
Bug 19547: Deal with --create-db missing debian.cnf issue
Followed test plan. Patch functions as described and both commands execute.
Signed-off-by: Dilan Johnpullé <dilan at calyx.net.au>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8b32870ac016312b1809fca26b4d04b28ea5fcf3
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Mon Oct 30 17:59:43 2017 -0400
Bug 19547: MariaDB install has no debian.cnf
This attempts to handle issues arising when running
koha-create on a system that never had MySQL installed.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5b2e49141586d0c169de5a67349cd9785836b8e6
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Fri Mar 9 11:54:16 2018 +0000
Bug 18570: (QA follow-up) Improved POD
This tweaks the perldoc for SendQueuedMessages and adds
some for _get_unsent_messages.
TEST PLAN
---------
perldoc C4::Letters
-- look at _add_attachments (ugly), _get_unsent_messages (non-existent),
SendQueuedMessages (no reference to borrowernumber or letter_code).
apply patch
perldoc C4::Letters
-- confirm that SendQueuedMessages and _get_unsent_messages
have reasonable POD information.
-- notice how _add_attachments' POD is now readable
run koha qa test tools
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 70941cde0ec70c4f59ff51abd713594a92cf1e3f
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Thu Mar 8 00:15:33 2018 +0000
Bug 18570: Send Password Reset Emails immediately
Run through the password reset process, and your server
should send the message immediate, not waiting for the
cronjob.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f0772f0c55a5ffba2b5e26587ba0ea8c91c09c8c
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Thu Mar 8 00:13:09 2018 +0000
Bug 18570: Prove that the letter code parameter tweaks work
Run the following commands:
kshell
prove -v t/db_dependent/Letters.t
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 73c21c4d30539371bb255346384bfa9f7cd945f8
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Wed Mar 7 23:59:54 2018 +0000
Bug 18570: Tests to prove if email send was attempted
kshell
prove -v t/db_dependent/Passwordrecovery.t
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d9ce37ff3e7f351bdf3506e925b1333217743cea
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Mar 16 09:02:36 2018 +0100
Bug 20430: (See also bug 19436) Button display depends on wrong server count
This is a QA follow-up of bug 19436, submitted separately for ease of
backporting it. (The bug was not raised by 19436.)
Obviously, the number of authority servers not biblio servers should
be the key factor for showing or hiding the button for new authority
records via Z39.50/SRU.
Trivial fix.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit aea565e71e0cf81933af3a45e9ad6511ba0a96c3
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Thu Mar 8 03:03:46 2018 +0000
Bug 20097: (follow-up) Add a unit test
kshell
prove -v t/db_dependent/Record.t
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f24e48577f478bf6d5132cce2a59febf8d36ce6d
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Mon Jan 29 10:32:28 2018 +0100
Bug 20097: Use same regex in marc2dcxml and opac-export
This regex allows: dc, oaidc, srwdc, and rdfdc.
Test plan:
[1] Check https://[yourserver]/cgi-bin/koha/opac-export.pl?bib=[some_biblionumber]&op=export&format=dc
[2] Check https://[yourserver]/cgi-bin/koha/opac-export.pl?bib=[some_biblionumber]&op=export&format=oaidc
[3] Check https://[yourserver]/cgi-bin/koha/opac-export.pl?bib=[some_biblionumber]&op=export&format=nodc. This one should trigger a not-supported message.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6d479dc5e53e3558207c75b73d58bce23328a61d
Author: Lari Taskula <lari.taskula at jns.fi>
Date: Fri Mar 9 15:49:27 2018 +0200
Bug 20367: Avoid resetting userid when BorrowerUnwantedField contains userid
To test:
1. In staff client, set your username to firstname
2. Add userid to BorrowerUnwantedField system preference
3. Go to your patron modification screen (memberentry.pl) and click Save
4. Observe you get kicked out into login screen, saying:
Error: You do not have permission to access this page.
Log in as a different user
5. Apply patch and restart plack
6. Set your username back to firstname
7. Repeat step 3
8. Observe you were not kicked out and your userid stays the same
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit dd559df8b9f839b8dcfe765ba0e503a0c65aa3e6
Author: Jose Martin <jose.i.martin.cuesta at gmail.com>
Date: Wed Mar 7 15:21:39 2018 +0300
Bug 20348: SIP2 patron identification fails to use userid
Replaces "or" with "||" in variable assignment
second attempt to retrieve borrower was not being executed due
to changed precedence
Signed-off-by: Colin Campbell <colin.campbell at ptfs-europe.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit a67fdf3bd498bf1c5a90c2847570ea8eff9c52da
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date: Fri Mar 9 06:43:18 2018 -0500
Bug 20341: Use AuthorisedValues plugin on the staff side
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 4159512fc5639cccaf1c563e1bc824f3010d3f6a
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Tue Mar 6 12:26:19 2018 +0100
Bug 20341: Show authorized value description for withdrawn like damaged and lost
Actually catalog detail page shows for damaged and lost items the authorized value description if exists.
We must do the same for withdrawn information.
Test plan :
1) Set for items a subfield linked to items.withdrawn and using the authorized value category 'WITHDRAWN'
2) Edit the authorized value category to add value '2' and description 'Eaten by dog'
3) Edit an item to set this withdrawn value
4) Go to staff interface and look at items in record detail page /cgi-bin/koh/catalogue/detail.pl :
=> Without patch you see 'Withdrawn' and with patch you see 'Eaten by dog'
5) Go to OPAc and look at items in record detail page /cgi-bin/koha/opac-detail.pl :
=> Without patch you see 'Withdrawn' and with patch you see 'Eaten by dog'
Signed-off-by: delaye <stephane.delaye at biblibre.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e24e7ad7f17fb957c6747fa76ff79be30769eaa1
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Mon Feb 5 08:25:03 2018 +0000
Bug 19908: Do not use .optional in password match validation function
Test plan:
0) Aplly only first patch
1) You will be able to submit a from on member-password.pl even if the
passwords don't match
2) Apply this patch -> you can't be able to submit the form if the
paswords don't match, but you'll be able to submit the form when
password fields are blank
Signed-off-by: Roch D'Amour <roch.damour at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit be4d4a8e28a85f2baf90b03127428cadb551a00e
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Wed Jan 3 10:56:37 2018 +0000
Bug 19908: Password fields in edit/add patron form should respect BorrowerMandatoryField preference
Test plan:
0) Do not apply the patch, note the password field is always required
1) Apply the patch
2) Try to add and edit patron with and without "password" in BorrowerMandatoryField, it should always respect this setting
3) Use "Change password" button in patron toolbar, the password field
should be never required here - when leaved blank, the password is
unchanged
4) Play with minPasswordLength and RequireStrongPassword preferences,
to ensure they work as expected
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
C4/Letters.pm | 63 ++++-
C4/Record.pm | 2 +-
C4/SIP/ILS/Patron.pm | 2 +-
C4/XISBN.pm | 11 -
Koha/Patron/Password/Recovery.pm | 7 +-
admin/admin-home.pl | 6 +
authorities/authorities-home.pl | 2 +-
catalogue/detail.pl | 13 +-
debian/compat | 2 +-
debian/scripts/koha-create | 13 +-
koha-tmpl/favicon.ico | Bin 1406 -> 0 bytes
koha-tmpl/index.html | 6 -
koha-tmpl/intranet-tmpl/prog/css/mainpage.css | 2 +-
.../prog/en/includes/installer-doc-head-close.inc | 2 +-
.../prog/en/includes/password_check.inc | 2 +-
.../prog/en/includes/patron-title.inc | 2 +-
.../prog/en/modules/admin/admin-home.tt | 2 +-
koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt | 2 +-
.../prog/en/modules/catalogue/detail.tt | 25 +-
.../en/modules/course_reserves/course-details.tt | 14 +-
.../en/modules/course_reserves/course-reserves.tt | 8 +-
.../intranet-tmpl/prog/en/modules/intranet-main.tt | 2 +-
.../prog/en/modules/members/member-password.tt | 2 -
.../prog/en/modules/members/memberentrygen.tt | 2 -
.../prog/en/modules/reports/dictionary.tt | 4 +-
.../prog/en/modules/tools/batch_delete_records.tt | 4 +-
.../prog/en/xslt/MARC21slim2intranetResults.xsl | 12 +-
koha-tmpl/intranet.html | 12 -
.../bootstrap/en/includes/item-status.inc | 7 +-
.../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 12 +-
koha-tmpl/opac.html | 11 -
members/memberentry.pl | 2 +-
misc/migration_tools/bulkmarcimport.pl | 4 +-
opac/opac-detail.pl | 2 +-
opac/opac-export.pl | 2 +-
t/db_dependent/Letters.t | 9 +-
t/db_dependent/Passwordrecovery.t | 7 +-
t/db_dependent/Record.t | 16 +-
t/db_dependent/XISBN.t | 9 +-
t/smolder_smoke_signal | 279 --------------------
xt/fix-old-fsf-address.exclude | 1 -
41 files changed, 165 insertions(+), 420 deletions(-)
delete mode 100644 koha-tmpl/favicon.ico
delete mode 100644 koha-tmpl/index.html
delete mode 100644 koha-tmpl/intranet.html
delete mode 100644 koha-tmpl/opac.html
delete mode 100755 t/smolder_smoke_signal
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list