[koha-commits] main Koha release repository branch master updated. v17.11.00-873-g88fb04d
Git repo owner
gitmaster at git.koha-community.org
Fri Mar 23 16:43:54 CET 2018
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 88fb04d180f5251d3c150e31d767616f08796964 (commit)
via d9bc1949e9dd544cf791acccbdacf5a595458ef8 (commit)
via 6183c0e6a910663fec02bdba66d05f173310f562 (commit)
via 3953fdb921d7f280ffbaca813956357aa67d42ca (commit)
via 2ebc2aa6e2133594335f445a9fa89dc6266c0579 (commit)
via cb336e633bf7e0cb25051a8ed8157af8486a58d7 (commit)
via ab46f93df4049ff3ac7bcfcaaf932dc9446c025f (commit)
via 58dccaee26181b42ab3a435e4b84786e3a75bcd3 (commit)
via dc2339247bbe60e4f23f4d3993b2774648284674 (commit)
via bddfed75913a2302c19c00b00a6fe86538af6f9f (commit)
via 8b61e7145e7046ea042cfb2e7a4c81c89a924001 (commit)
via f3abb1ace539ce7e68e414400d2c6ba2842dd248 (commit)
via c5fbda6685fdc6107d57f97a77df9c9c6c0235f6 (commit)
via ee5885a17a5e5a5e77a0e7efab7c4feb090e8b53 (commit)
via 8f4a0c40c8d32e64c06b10ac4990e31f7fe35fee (commit)
via 97b8bd5ebc41c4b1aa6792e190c87e82f9578a48 (commit)
via cf0f2d9819e8b11053953b3513c33e51ce979623 (commit)
via 6ee8f826f7474023117a4d4f5faa54caf0eef355 (commit)
via 5855b015430505568a3e2d9da90e3afa06a5abb8 (commit)
via 906c9166a7c63a4086116ce8711610f2448d2ff3 (commit)
via d2610f39c7bbdcf086b21f204c21a7167cefe10b (commit)
via f1926bda5613edd606d0357695b9a67d20926781 (commit)
via e77982ade1254b48493aac28393888509a054846 (commit)
via 4297841b98c7f992ef18c400fae2d7d77ae84b9e (commit)
via 4a6c8883cc9022ab70459d978267c883062260a4 (commit)
via dbc24783eef87520495d4795c9a17a8ab1d4f87a (commit)
via 4537ea270b7b717f37b885dd4f715a74802641d2 (commit)
via 3441efd1af00f06f8370d332692d8bba2c6be00a (commit)
via 567e2ac8874839ec9b2490148c6afeabdfcf591b (commit)
via bd29269185cfaea65a0d1eb4ca8003a5b5a984bb (commit)
via c40e07d6a6ddead18d6851bb1ee211b0897348db (commit)
via f2cf899a90117d63b7706b83af2b8d863b94c767 (commit)
via 18e72e31957a51206875ac27d92929909a90ef34 (commit)
via d03a4008240380a342ba6d7734c00f699f57902c (commit)
via 841d592d3577115296007e254c1444a52fa29289 (commit)
via 8627fde517c5c47e38700379ecc8f1c021c0651e (commit)
via 11c1829dc306d801502e5b38555b2cf3f6cef9d2 (commit)
via 736f8a9205b02c89fe007759d581d23f84c5d09a (commit)
via f1c14d25d1bcf1cacb7bdeef3bfc7581f5c830ec (commit)
via 3dda23db34b36992d8694858afe1bb29484ced3f (commit)
via c55515d2daf1c9ed5fb09e5dc39667f4f39dbd85 (commit)
via 84ca0487a05ea7532d68baa7526796cc13d55552 (commit)
via 9c0be579fe6ce476ee4809321b63b0f215551fb4 (commit)
via b85f8c9e2ad2ea5efa5a9b57df5614f24d8d9fdd (commit)
via e8857894bd4fe04b1279c8d65826dda1b064a239 (commit)
via 61c9f0c5a08273cec1cead966b754278986f3167 (commit)
from 450d0e3db1ce3d0eefaefc44d88b777f7ab294bc (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 88fb04d180f5251d3c150e31d767616f08796964
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Mar 9 10:51:53 2018 -0300
Bug 19943: Gentle error handling for bookcount.pl
This patch tests the required parameters and redirects with a 400 HTTP
code if parameters are invalid.
It also removes the need for the passed biblioitemnumber which is not
used at all.
A (now) useless sub is removed too.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d9bc1949e9dd544cf791acccbdacf5a595458ef8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jan 9 14:38:10 2018 -0300
Bug 19943: Remove C4::Biblio::GetBiblioItemData
It is no longer used.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6183c0e6a910663fec02bdba66d05f173310f562
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jan 9 14:37:20 2018 -0300
Bug 19943: Koha::Biblio - Replace GetBiblioItemData with Koha::Biblio->biblioitem
The biblioitem's info can be retrieved with Koha::Biblio->biblioitem
Test plan:
1. Use the age restriction to restrict checkouts for a given patron
2. Check some items of a biblio out, go to "Items" tab, then "View
item's checkout history" link. Compare views with and without patches
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3953fdb921d7f280ffbaca813956357aa67d42ca
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jan 9 14:29:50 2018 -0300
Bug 19943: Remove itemtype vs itype confusion in CanBookBeIssued
Just a preliminary step to clean the code a bit in CanBookBeIssued.
The effective item type is already set from GetItem and we do not need
to deal with that again.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2ebc2aa6e2133594335f445a9fa89dc6266c0579
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jan 9 13:58:53 2018 -0300
Bug 19940: Koha::Biblio - Remove GetBiblioItemInfosOf
This subroutine is only used once and can be replaced easily with a
Koha::Biblioitems->search call
Test plan:
Test this on top of bug 19941 and confirm that the correct item types
are displayed
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit cb336e633bf7e0cb25051a8ed8157af8486a58d7
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Mar 13 13:04:01 2017 -0300
Bug 18255: Koha::Biblio - Replace GetBiblioItemByBiblioNumber with Koha::Biblio->biblioitem
The subroutine GetBiblioItemByBiblioNumber considers that we have a 1-N
relation between biblio and biblioitems, which is wrong (it's 1-1).
So the calls can be replaced with Koha::biblio->biblioitem, it will ease
the read of the code.
Test plan:
1. Use the ILSDI service to display info of a bibliographic record,
biblioitems fields must be displayed
2. Search for items, biblioitems info must be displayed as well in the
result table
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ab46f93df4049ff3ac7bcfcaaf932dc9446c025f
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date: Fri Mar 2 06:17:14 2018 -0500
Bug 19933: Fix typo in template plugin name
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 58dccaee26181b42ab3a435e4b84786e3a75bcd3
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date: Fri Mar 2 06:08:10 2018 -0500
Bug 19933: Move instantiation of in deletemem.pl
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit dc2339247bbe60e4f23f4d3993b2774648284674
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Mar 2 06:01:38 2018 -0500
Bug 19933: (follow-up) Remove patronflags - easy ones
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit bddfed75913a2302c19c00b00a6fe86538af6f9f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Sun Jan 7 14:57:23 2018 -0300
Bug 19933: Remove patronflags - tricky ones
Here we are, patronflags is used in a couple of places where (almost) all flags
were really useful: C4::SIP::ILS::Patron->new and circulation.pl
This patch only deal with the circulation code as I am not convident
enough with SIP code.
The change does not seems trivial because of the complexity of the
existing code, but the logic is the same. We send a variable to the
template depending on the situation of the patron.
I guess only code eyes ball could catch issue in this patch quickly.
Maybe we need to find a good place in a Koha module to move this code
and provide code coverage (especially when C4::SIP::ILS::Patron will
reuse it).
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8b61e7145e7046ea042cfb2e7a4c81c89a924001
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Sun Jan 7 14:42:00 2018 -0300
Bug 19933: Remove patronflags - easy ones
This patch replaces the easy occurrences of patronflags.
These calls only need the CHARGES->amount value, that is the non issues
charges. Luckily we now have a Koha::Account->non_issues_charges that
deal with that.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f3abb1ace539ce7e68e414400d2c6ba2842dd248
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Sun Jan 7 13:48:16 2018 -0300
Bug 19933: Remove patronflags - In CanBookBeIssued
The change is trivial here, we only want to pass gonenoaddress, lost and
is_debared to the template.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c5fbda6685fdc6107d57f97a77df9c9c6c0235f6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Sun Jan 7 14:06:14 2018 -0300
Bug 19933: Remove patronflags - unused vars oldamount/amountold in circulation.pl
There is oldamound/amountold variable that is sent to the template but
never used later. Let remove it now to avoid useless replacement.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ee5885a17a5e5a5e77a0e7efab7c4feb090e8b53
Author: Te Rauhina Jackson <terauhina.jackson at gmail.com>
Date: Thu Jan 18 02:20:11 2018 +0000
Bug 16427: Add direct link to authority records from staff detail view (MARC21 subjects)
I added a magnigying glass icon in the staff detail view that links to
the authority records.
Test Plan:
1) On the Koha staff page, create a new authority. The type of authority
will be: Topical Term.
2) When creating authority, in tab 1 under -HEADING--TOPICAL TERM enter
the topical term or geographic name entry element and then save the
new authority e.g. science.
3) In circulation, search the catalog for a random book. Click the title
of the book and you will be taken to the book details.
4) Edit the record and in tab 6, scroll down the - SUBJECT ADDED
ENTRY--TOPICAL TERM and repeat this tag (the icon next to the title).
5) Edit the Topical term or geographic name entry element by clicking
the button on the right of the bar.
6) In the Search main heading ($a only) enter your topical term e.g.
science.
7) Press search, and then in the table that pops up, click 'choose'.
8) Save your edits and the new topical term will be in the 'Subject(s)'
list of the book details.
9) Notice that there is no magnifying glass icon.
10) Apply this patch
11) Notice that there is now a magnifying glass icon next to the topical
term.
12) Click on the magnifying glass and it will take you directly to the
authorities records
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8f4a0c40c8d32e64c06b10ac4990e31f7fe35fee
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Mar 16 10:16:23 2018 +0000
Bug 20432: Add black version of small Koha logo for use in the OPAC
This patch adds a black version of the Koha logo for use in OPAC
customization.
To test, apply the patch and add this CSS to your OPACUserCSS system
preference:
.navbar-inverse .navbar-inner {
background: #CCC none;
}
#logo {
background: transparent url(/opac-tmpl/bootstrap/images/koha-logo-navbar-black.png) no-repeat scroll 0;
}
Refresh your OPAC and the top navigation bar should be changed from
black to grey, and you should see a black version of the Koha logo.
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 97b8bd5ebc41c4b1aa6792e190c87e82f9578a48
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Feb 22 16:46:19 2018 +0000
Bug 20275: Add comment to let user know they can define multiple plugindirs
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit cf0f2d9819e8b11053953b3513c33e51ce979623
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu Mar 15 14:51:34 2018 +0100
Bug 19929: (QA follow-up) Fix POD
Make qa tools happy.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6ee8f826f7474023117a4d4f5faa54caf0eef355
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Jan 9 11:45:47 2018 +0000
Bug 19929: Add Koha objects for class sources and sorters
prove -v t/db_dependent/Koha/ClassSortRules.t
prove -v t/db_dependent/Koha/ClassSources.t
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5855b015430505568a3e2d9da90e3afa06a5abb8
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed Mar 14 13:22:46 2018 +0100
Bug 19454: (QA follow-up) Fix selection on categorycode
A follow-up on a preceding report introduced a join instead of a
subquery. This made the categorycode ambiguous.
Test plan:
See former patches.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 906c9166a7c63a4086116ce8711610f2448d2ff3
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Mon Oct 16 13:08:22 2017 +0200
Bug 19454: (follow-up) Add a total line when updating
Test plan:
[1] Run the script with -doit and -cat [some_category] and verify that
the printed total is correct.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d2610f39c7bbdcf086b21f204c21a7167cefe10b
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu Oct 12 15:36:10 2017 +0200
Bug 19454: Add -category parameter to borrowers-force-messaging-defaults.pl
Instead of updating patrons over all patron categories, it would be
helpful if we could filter on a specified category.
Test plan:
[1] Select two patrons A and B in say categories C1 and C2.
[2] Change the msg prefs for A and B away from defaults.
[3] Run borrowers-force-messaging-defaults.pl -doit -cat C1
Verify that patron A changed and patron B did not.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
Amended: Replace -category by --category. (marcelr 20180314)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f1926bda5613edd606d0357695b9a67d20926781
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Nov 29 15:20:19 2017 -0500
Bug 19716: Add option to send header line for CSV output
Currently, if outputting a CSV file using runreport.pl, you need to look at the report used to know what each column means. It would be nice if we could include column headers.
Test Plan:
1) Apply this patch
2) Try using runreport.pl with --format csv --csv-header
Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e77982ade1254b48493aac28393888509a054846
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date: Fri Mar 9 09:51:52 2018 -0500
Bug 18626: Add unit tests
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 4297841b98c7f992ef18c400fae2d7d77ae84b9e
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu May 11 00:44:12 2017 +0000
Bug 18626: Add ability to track cardnumber changes for patrons
Some libraries want to keep a history of cardnumber changes for a
patron. This is a feature that another ILS has.
Test Plan:
1) Apply this patch
2) Enable the BorrowersLog
3) Modify a patron, update his or her cardnumber
4) Notice the entry in the action log containing the old and new cardnumbers
5) Edit a patron, leave the cardnumber the same
6) Note there is no cardnumber change entry in the action logs
7) Disable BorrowersLog, modify a patron cardnumber
8) Note there is no cardnumber change entry in teh action logs
Followed test plan, works as expected
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 4a6c8883cc9022ab70459d978267c883062260a4
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date: Fri Mar 9 10:49:03 2018 -0500
Bug 17826: Add POD
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit dbc24783eef87520495d4795c9a17a8ab1d4f87a
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Dec 29 15:39:28 2016 +0000
Bug 17826: Allow extended patron attributes to be sent in arbitrary SIP2 fields
Some libraries need to be able to send additional patron data from the
extended patron attributes in made up SIP2 fields for the patron
information and patron status responses.
Test Plan:
1) Apply this patch
2) Create 3 new patron attributes with the codes CODE1, CODE2, CODE3.
Make a least one repeatable.
3) Create a patron, add those attibutes for the patron, make sure there
are at least two instances of the repeatable code
4) Edit your SIP2 config file, add the following within the login stanza:
<patron_attribute field="XX" code="CODE1" />
<patron_attribute field="XY" code="CODE2" />
<patron_attribute field="XZ" code="CODE3" />
5) Using the sip cli emulator, run patron_information and
patron_status_request messages for the patron
6) Note the values you set for the patron attributes are sent in the
corrosponding fields!
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Daniel Mauchley <dmauchley at duchesne.utah.gov>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Amended: added parentheses on line 488 when assigning hashref to array.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 4537ea270b7b717f37b885dd4f715a74802641d2
Author: Jenny Way <jwayway at hotmail.com>
Date: Wed Jan 17 20:20:23 2018 +0000
Bug 19856: (follow-up) Improve styling of reports sidebar
Added divs to report-menu.inc as well. Should work on any reports page
with sidebar now.
Signed-off-by: claude <claude.brayer at cea.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3441efd1af00f06f8370d332692d8bba2c6be00a
Author: Jenny Way <jwayway at hotmail.com>
Date: Tue Jan 16 03:24:41 2018 +0000
Bug 19856: Improve styling of reports sidebar
Test Plan
1. Open tools page and click on any of the links with a sidebar
2. Note the layout of the sidebar
3. Open reports page and click on any of the links with a sidebar
4. All the sidebars should have the same layout as the tools one
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 567e2ac8874839ec9b2490148c6afeabdfcf591b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Mar 19 17:18:26 2018 -0300
Bug 20264: DBRev 17.12.00.023
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit bd29269185cfaea65a0d1eb4ca8003a5b5a984bb
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Feb 21 15:04:01 2018 -0300
Bug 20264: Remove syspref checkdigit
According to
http://irc.koha-community.org/koha/2013-06-26#i_1333289
http://irc.koha-community.org/koha/2013-06-26#i_1333589
and Hea data, this syspref is no longer in used and is always set to
false.
Signed-off-by: Dilan Johnpullé <dilan at calyx.net.au>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c40e07d6a6ddead18d6851bb1ee211b0897348db
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Mar 19 17:16:26 2018 -0300
Bug 4078: DBRev 17.12.00.022
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f2cf899a90117d63b7706b83af2b8d863b94c767
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Feb 1 14:35:06 2018 -0300
Bug 4078: Add a new test
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 18e72e31957a51206875ac27d92929909a90ef34
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Feb 1 14:32:39 2018 -0300
Bug 4078: Add the ability to display and configure the symbol for prices
The symbol of currencies are not displayed (or not correctly) so far.
This patch set adds the ability to configure the display of the symbol
(with or without a whitespace between the symbol and the price).
Test plan:
1. Execute the update DB entry, go to the currency admin page and tick the
new "Space separation between symbol and value" checkbox
2. Add a fine to a patron and use their credentials to login at the OPAC
3. You should see the "$ 42 due fines and charges" info in the
dashboard
4. Untick the new checkbox to remove the space and reload the OPAC main
page.
=> The space should not be longer displayed ($42)
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d03a4008240380a342ba6d7734c00f699f57902c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Feb 1 14:31:48 2018 -0300
Bug 4078: Pass with_symbol to module
The template plugin did not pass the with_symbol flag to the module and
so was not taken into account
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 841d592d3577115296007e254c1444a52fa29289
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Feb 1 14:31:25 2018 -0300
Bug 4078: Add the checkbox to the UI
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8627fde517c5c47e38700379ecc8f1c021c0651e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Feb 1 14:30:53 2018 -0300
Bug 4078: Update DB entry - add new column currency.p_sep_by_space
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 11c1829dc306d801502e5b38555b2cf3f6cef9d2
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Feb 1 14:30:39 2018 -0300
Bug 4078: DBIC Schema changes
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 736f8a9205b02c89fe007759d581d23f84c5d09a
Author: David Bourgault <david.bourgault at inlibro.com>
Date: Wed Jan 24 15:52:50 2018 -0500
Bug 17457: Add tests for each marc flavour
+ Added a `run_flavoured_tests` sub that runs for each MARC flavour
* Moved SearchWithISBNVariation tests to the new sub
I copied a lot of the necessary utility functions over Biblio.t (as of Jonathan's suggestion). I also tried to name and organize the code in such a way that it can be reused if anyone else needs to run "flavoured" tests in the future.
prove t/db_dependant/Acquisition.t OK
QA tool green
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f1c14d25d1bcf1cacb7bdeef3bfc7581f5c830ec
Author: David Bourgault <david.bourgault at inlibro.com>
Date: Mon Sep 25 16:22:51 2017 -0400
Bug 17457: Adv. Acquisition search with ISBN variations
Advanced acquisition search will now follow the "SearchWithISBNVariations" system preference.
Test plan :
0) Make sure you have orders pending or completed
1) Enable SearchWithISBNVariations if it is not enabled
2) Search for one of your orders by its ISBN, it should appear
3) Search for the same order by a variation of its ISBN, I used this website to find it : http://www.hahnlibrary.net/libraries/isbncalc.html
You should not get a result.
4) Apply patch
5) Repeat step 2-3. You should get a hit both times.
6) prove t/db_dependent/Acquisition.t
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3dda23db34b36992d8694858afe1bb29484ced3f
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Mar 2 12:36:20 2018 +0000
Bug 19160: Add POD
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c55515d2daf1c9ed5fb09e5dc39667f4f39dbd85
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Mar 2 12:32:09 2018 +0000
Bug 19160: Remove tab characters causing qa script to fail
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 84ca0487a05ea7532d68baa7526796cc13d55552
Author: Ulrich Kleiber <ulrich.kleiber at bsz-bw.de>
Date: Wed Feb 7 10:06:20 2018 +0100
Bug 19160: (follow-up) Fix problems introduced by renaming logout_required to logout_if_required
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9c0be579fe6ce476ee4809321b63b0f215551fb4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Jan 11 15:43:42 2018 -0300
Bug 19160: Isolate CAS code into its own module
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b85f8c9e2ad2ea5efa5a9b57df5614f24d8d9fdd
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Jan 11 15:37:18 2018 -0300
Bug 19160: Move the code from controller to C4::Auth_with_cas
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e8857894bd4fe04b1279c8d65826dda1b064a239
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Jan 11 15:29:22 2018 -0300
Bug 19160: Move duplicated code to its own private subroutine
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 61c9f0c5a08273cec1cead966b754278986f3167
Author: Chris Cormack <chrisc at catalyst.net.nz>
Date: Thu Jun 8 09:38:30 2017 +1200
Bug 19160: CAS Single logout
CAS supports single logout, where if you logout of one application it
logs you out of all of them.
This bug implements this
You will need a CAS server (with single logout configure),
and at least 2 applications (one being Koha)
1/ In Koha login via CAS
2/ Login to the other application via CAS
3/ Logout of the other application
4/ Notice you are still logged into Koha
5/ Log out of Koha
6/ Apply patch
7/ Login to Koha via CAS, login to other app via CAS
8/ Log out of other app
9/ Notice you are logged out of Koha
If you dont have CAS, this patch should be a no op, you could test that
1/ Login and logout normally
2/ Apply patch
3/ Login and logout still work fine
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Patch works as described, local login still works correctly.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
C4/Acquisition.pm | 25 +++-
C4/Auth.pm | 50 +++----
C4/Auth_with_cas.pm | 62 +++++++--
C4/Biblio.pm | 76 -----------
C4/Circulation.pm | 42 +++---
C4/ILSDI/Services.pm | 12 +-
C4/Members.pm | 79 ++++-------
C4/SIP/ILS/Patron.pm | 60 ++++++++-
C4/SIP/Sip/MsgType.pm | 6 +
C4/UsageStats.pm | 1 -
Koha.pm | 2 +-
Koha/{BiblioFramework.pm => ClassSortRule.pm} | 6 +-
Koha/{Biblios.pm => ClassSortRules.pm} | 24 ++--
Koha/{CsvProfile.pm => ClassSource.pm} | 8 +-
Koha/{Biblios.pm => ClassSources.pm} | 24 ++--
Koha/Number/Price.pm | 8 +-
Koha/Schema/Result/Currency.pm | 12 +-
Koha/Template/Plugin/Price.pm | 2 +-
admin/currency.pl | 3 +
catalogue/itemsearch.pl | 5 +-
cataloguing/merge.pl | 2 -
circ/bookcount.pl | 29 ++--
circ/circulation.pl | 139 +++++++++-----------
debian/templates/koha-conf-site.xml.in | 2 +-
etc/SIPconfig.xml | 1 +
etc/koha-conf.xml | 2 +-
installer/data/mysql/kohastructure.sql | 1 +
installer/data/mysql/sysprefs.sql | 1 -
installer/data/mysql/updatedatabase.pl | 25 ++++
.../prog/en/includes/guided-reports-view.inc | 5 +
.../prog/en/includes/reports-menu.inc | 95 ++++++-------
.../prog/en/modules/admin/currency.tt | 8 ++
.../prog/en/modules/admin/preferences/patrons.pref | 6 -
.../prog/en/modules/catalogue/moredetail.tt | 2 +-
.../prog/en/modules/circ/circulation.tt | 7 +-
.../en/modules/circ/circulation_batch_checkouts.tt | 4 +-
.../prog/en/modules/members/deletemem.tt | 3 +-
.../prog/en/xslt/MARC21slim2intranetDetail.xsl | 17 +++
.../bootstrap/images/koha-logo-navbar-black.png | Bin 0 -> 1310 bytes
members/deletemem.pl | 12 +-
members/member-flags.pl | 1 -
misc/cronjobs/delete_patrons.pl | 9 +-
misc/cronjobs/runreport.pl | 11 ++
.../borrowers-force-messaging-defaults.pl | 18 ++-
opac/opac-user.pl | 4 +
reserve/request.pl | 12 +-
serials/routing-preview.pl | 3 +-
t/Number/Price.t | 15 ++-
t/db_dependent/Acquisition.t | 126 +++++++++++++++++-
t/db_dependent/Biblio.t | 8 +-
t/db_dependent/Koha/ClassSortRules.t | 55 ++++++++
t/db_dependent/Koha/ClassSources.t | 59 +++++++++
t/db_dependent/Koha/Patrons.t | 21 ++-
t/db_dependent/SIP/Patron.t | 44 ++++++-
t/db_dependent/UsageStats.t | 1 -
55 files changed, 820 insertions(+), 435 deletions(-)
copy Koha/{BiblioFramework.pm => ClassSortRule.pm} (87%)
copy Koha/{Biblios.pm => ClassSortRules.pm} (75%)
copy Koha/{CsvProfile.pm => ClassSource.pm} (84%)
copy Koha/{Biblios.pm => ClassSources.pm} (76%)
create mode 100644 koha-tmpl/opac-tmpl/bootstrap/images/koha-logo-navbar-black.png
create mode 100644 t/db_dependent/Koha/ClassSortRules.t
create mode 100644 t/db_dependent/Koha/ClassSources.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list