[koha-commits] main Koha release repository branch master updated. v17.11.00-943-g385c161
Git repo owner
gitmaster at git.koha-community.org
Mon Mar 26 22:42:53 CEST 2018
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 385c16174b4156f59518cdd1de02ee81ba3c03b8 (commit)
via 5e93b777fdc59c3b79fae2f9a86a763c7ceb7cdd (commit)
via 18fb2f12e70b92de63bd283d7d137ee69aa82a9f (commit)
via 011aa89777cd821869ca85e9aca7485550ecf001 (commit)
via 95f881b96969dda6156d78fbe59410946f61ca99 (commit)
via f9f2d9d86102bd03b72e03b5640ba9f2544c8a86 (commit)
via 3c609249390aa37ba09a7fa4f71816456fa2e8ac (commit)
via 1f4eb5df7e3c3eb156df176915fcac3a5d34553c (commit)
via 42ff67e1732f5cbbaf580214d88f3f287ca34770 (commit)
via b809726492aca4118dfdd9171a855cbf6739da84 (commit)
via 077fcf3a6be405fc6bac7371f5586d1d696ec287 (commit)
via 7ea03cefd6a1612ad60ead35bbac95588ff5723c (commit)
via fbfbcae838eacf7684141260e263619dd7869aef (commit)
via 0844092693358f873c059e78b51b5e1b6dd83166 (commit)
via e42475ca28a56e83a672a618339ffdfacd09036c (commit)
via 5e563d81aae7e2e38ecda8ce19381b023130118a (commit)
via 3d41b8cce8235446812ec3a7309dd68abd4b86e4 (commit)
via 49f50a7f267e7ea105895dc5165965b149697fe3 (commit)
via 72061402d9e710de8ae322d46cd1d54702a27019 (commit)
via 1c660aef299b8b705e8a31dce91de254195baabe (commit)
via 4a9b69ec7adf85194cf6ef4991b1febfef692ede (commit)
via 56da3e5705f2f41795a8b3c6a5ba365fe17c4137 (commit)
via d6e8e88249914531d8b01f35200de6a8a4692b89 (commit)
via 92b29b88c213b7ef6ebbecacc7db896a901880d3 (commit)
via 8c5fa90668b2a402cddde3c2f469e3ddb0def63f (commit)
via 9bf68c8c3e89bddb23662c9fbd03b7a7514c9955 (commit)
via 76853c347ee49e2a8c3f132e0b786db3df987187 (commit)
via 6d150eaeca5ba9c9fb3ef2229ce2138526b4db64 (commit)
via ef7805aa3657e47daaa266b5334e98a1c1667d5f (commit)
via 06424503b7c88bdead7cb7008a6a1aff3ced603e (commit)
via dc2ad5fa9da6eecddffad8e47f7ba5f716229232 (commit)
via 484d4cbbdd203578062f2dd6e15af788a0f7c1e0 (commit)
via 0d614eec694f7aff11a54805c57fab1d4a463f24 (commit)
via d239baf0fb331d4f99b10abef8b7085e579eb9ba (commit)
via 830b5a7d7dad1d9d1593c14419496e81f7f4b24c (commit)
via cd79cf177ee8787b48f1dd81179d5ef60640db4f (commit)
via 9eed6c5190818b9ed40bedcb0242be9d8fc34f62 (commit)
via 46c4aa3551f810e8d1853f5013a282ce4ee95541 (commit)
via f47a999c9f36ed644b811e0f01b7cdcd11d068f9 (commit)
via d9dff376ae1294d147af8eca49891128f509af6a (commit)
via cc1bfafbd0c2b9e15f1253a7a7719a9ae889bfa2 (commit)
via 4680a1e09e4ccf9a9028eb52b98ae0891c16e375 (commit)
via abdc75b9a5703714c513e9f7b41e4d4814795d2f (commit)
via 6737704c027f1195ed08c69ab395e3cc26806454 (commit)
via 98d4ad2704026a39b8872a170c0a129b15b478fa (commit)
via ebd523ffd55ba89892986c87bf8cab299d035361 (commit)
via 49fd4a2dac3ff8b66fc4ff189d0a557c05e41898 (commit)
via 9ef987dacfd28ee7d5e63b12e641e96910604284 (commit)
via febb64260bc629105b0b0dc3c77da4b1452d6b8d (commit)
via 5c3ead6ecd0641306c65a321d642a392a24dca63 (commit)
via d3503e8119fd453241cb6d3824eeda0af0e5ec5e (commit)
via 8b0df471e653be6e34b0800eeb7c269530195549 (commit)
via 3c3ec562f1330d9b31033ac16d91ca0ab5ae5fbd (commit)
via 7465cbac2f2c65d008bcc4870a3bc8d6c5668b71 (commit)
via 74ac5baba5a618174aed679256a274dcdef10166 (commit)
via 001ce959b625d85d74511b2fe603993a0f3db5d5 (commit)
via 4427f90de037e0175383ba2b818f0c85b79c1a32 (commit)
via 9007c6e8587196ab05e5727eac1e4bbb6c4ae9e4 (commit)
via 1428615dad77f4a9702f287c461d792e908b5dcf (commit)
via f3dfd5226d0c077428df797fb8b829ed7f333748 (commit)
via 952b2242cfccec7a5cedcc858942f940f80d757b (commit)
via 423fa9cc8f9bc1976296a3c5e26845b0c0d24608 (commit)
from 5bdd4c02af25873aed550bd1e312d07fa9b229f0 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 385c16174b4156f59518cdd1de02ee81ba3c03b8
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Sat Feb 17 12:20:09 2018 -0300
Bug 17468: Remove koha-*-zebra scripts and its traces
This patch removes traces from the (deprecated) koha-*-zebra scripts.
To test:
- Apply the patch
- Verify no traces of koha-*-zebra remain on the codebase (besides
Release Notes and the koha-zebra script):
$ cd kohaclone
$ git grep koha-start-zebra
$ git grep koha-stop-zebra
$ git grep koha-restart-zebra
=> SUCCESS: No traces!
- Create the following symlinks:
$ sudo ln -s /usr/sbin/koha-zebra /usr/sbin/koha-start-zebra
$ sudo ln -s /usr/sbin/koha-zebra /usr/sbin/koha-stop-zebra
$ sudo ln -s /usr/sbin/koha-zebra /usr/sbin/koha-restart-zebra
- Try the koha-*-zebra commands:
$ sudo koha-stop-zebra kohadev
$ sudo koha-start-zebra kohadev
$ sudo koha-restart-zebra kohadev
=> SUCCESS: They all work as expected!
- Sign off :-D!
Sponsored-by: Orex Digital
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5e93b777fdc59c3b79fae2f9a86a763c7ceb7cdd
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Mar 6 18:48:08 2018 +0000
Bug 20345: Put saved report keyword search form on reports home
This patch makes cosmetic changes to the reports home page in the staff
client following the pattern set on the Administration home page with
the system preferences search box. A reports keyword search form is
added, and reports actions have font-awesome icons.
To test, apply the patch and view the reports home page. Confirm that
all affected links work correctly and that the search form works
correctly.
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 18fb2f12e70b92de63bd283d7d137ee69aa82a9f
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Jan 19 16:02:46 2018 +0000
Bug 20045: Switch single-column templates to Bootstrap grid: Various
This patch updates various unrelated templates to use the Bootstrap
grid.
- about.tt - The about page
- auth.tt - The login page
These pages should look correct.
- reports/reports-home.tt - The reports home page
- admin/admin-home.tt - The administration home page
These pages should look correct, with a single centered column
with wide margins on either side. At lower browser widths the margins
should disappear.
- serials/subscription-add.tt - Serials -> Add subscription. The entry
form should look correct during each step of the add/edit process.
- suggestion/suggestion.tt - Acquisitions -> Suggestions -> New
suggestion. The page with the new suggestion form should look correct.
Signed-off-by: Roch D'Amour <roch.damour at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 011aa89777cd821869ca85e9aca7485550ecf001
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Jan 16 16:55:36 2018 +0000
Bug 19983: Switch single-column templates to Bootstrap grid: Authorities
This patch updates several single-column Authorities module templates to
use the Bootstrap grid.
- authorities-home - The home page of the Authorities module.
- authorities.tt - The authority add/edit page.
- blinddetail-biblio-search.tt - Not really testable -- It's the small
popup window which appears during the process of linking an authority
to a MARC record.
- detail.tt - The authority detail page. Search for an authority record
and click on the "details" link in the search results.
- merge.tt - From a list of authority search results, select "Merge"
from the Actions menu of two authority records. Test both the initial
selection screen and the source/destination merging view.
- searchresultlist.tt - The authority search results page.
Each of these pages should look correct, with a single centered column
with wide margins on either side. At lower browser widths the margins
should disappear.
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 95f881b96969dda6156d78fbe59410946f61ca99
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Feb 21 19:40:06 2018 +0000
Bug 19961: Move template JavaScript to the footer: Patron card creator
This patch modifies the staff client patron card creator templates so
that JavaScript is included in the footer instead of the header.
Also changed: Removed "type" attribute from script tags.
To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.
- Creating and managing layouts
- Creating and managing card batches
- Creating and managing card templates
- Creating and managing printer profiles
- Creating and managing images
Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f9f2d9d86102bd03b72e03b5640ba9f2544c8a86
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Feb 9 13:16:40 2018 +0000
Bug 19946: (follow-up) Add fixed footer to authorities Z39.50 popup
This patch adds additional Bootstrap framework markup to the search form
so that the "Save" and "Cancel" controls are in a fixed footer at the
bottom of the window. This prevents the controls from disappearing down
off screen.
This patch also adds some whitespace to the "Author
(meeting/conference)" label to enable better word wrapping.
To test, apply the patch and go to Authorities -> New from Z39.50/SRU.
In the popup window, both the search form and search results pages
should look correct.
Patch applies, form resizes, displays and functions as expected.
Signed-off-by: Dilan Johnpullé <dilan at calyx.net.au>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3c609249390aa37ba09a7fa4f71816456fa2e8ac
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Jan 10 16:10:44 2018 +0000
Bug 19946: Update popup window templates to use Bootstrap grid: Authority Z39.50 search
This patch updates the authority Z39.50 search template to use the
Bootstrap grid instead of the YUI grid.
Also fixed: Some capitalization corrections, better <title>
handling. This patch does not fix Bug 17119.
To test, apply the patch and go to Authorities -> New from Z39.50.
In the popup window, both the search form and search results pages
should look correct.
Signed-off-by: Te Rauhina Jackson <terauhina.jackson at gmail.com>
Signed-off-by: Te Rauhina Jackson <terauhina.jackson at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1f4eb5df7e3c3eb156df176915fcac3a5d34553c
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Jan 10 17:42:59 2018 +0000
Bug 19949: Update popup window templates to use Bootstrap grid: Cataloging authority search
This patch updates the cataloging authority search templates to use the
Bootstrap grid instead of the YUI grid.
To test you must have a MARC subfield configured with "Thesaurus"
linked to an authority type.
Apply the patch and go to Cataloging -> New record. Click the plugin
link for the field which is linked to authorities. In the popup window,
the search form and search results should look correct.
Signed-off-by: Zoe Bennett <zoebennett1308 at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 42ff67e1732f5cbbaf580214d88f3f287ca34770
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Jan 2 16:29:44 2018 +0000
Bug 19878: Move template JavaScript to the footer: UNIMARC editor plugins, part 7
This patch updates the last of the UNIMARC plugin templates so that
JavaScript is included in the footer following the same pattern as
other templates which have been modified to fix Bug 17858.
To test you do not need a UNIMARC system.
Apply the patch and for each plugin, configure a MARC subfield (e.g.
100$a) to use that plugin.
From the MARC edit page, trigger the plugin and confirm that changes
made in the popup window are saved to the corresponding field in the
editor.
- unimarc_field_210c.tt
- unimarc_field_210c_bis.tt
- unimarc_field_225a.tt
- unimarc_field_225a_bis.tt
- unimarc_field_4XX.tt
- unimarc_field_700-4.tt
- unimarc_leader.tt
Signed-off-by: Anne-Claire Bernaudin <anne-claire.bernaudin at univ-rennes1.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit b809726492aca4118dfdd9171a855cbf6739da84
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Dec 22 16:32:57 2017 +0000
Bug 19877: Move template JavaScript to the footer: UNIMARC editor plugins, part 6
This patch updates more UNIMARC plugin templates than ever before, so
that JavaScript is included in the footer following the same pattern as
other templates which have been modified to fix Bug 17858.
To test you do not need a UNIMARC system.
Apply the patch and for each plugin, configure a MARC subfield (e.g.
100$a) to use that plugin.
From the MARC edit page, trigger the plugin and confirm that changes
made in the popup window are saved to the corresponding field in the
editor.
- unimarc_field_128a.tt
- unimarc_field_128b.tt
- unimarc_field_128c.tt
- unimarc_field_130.tt
- unimarc_field_135a.tt
- unimarc_field_140.tt
- unimarc_field_141.tt
Signed-off-by: delaye <stephane.delaye at biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 077fcf3a6be405fc6bac7371f5586d1d696ec287
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Dec 22 14:51:20 2017 +0000
Bug 19874: Move template JavaScript to the footer: UNIMARC editor plugins, part 5
This patch updates yet more UNIMARC plugin templates so that
JavaScript is included in the footer following the same pattern as other
templates which have been modified to fix Bug 17858.
To test you do not need a UNIMARC system.
Apply the patch and for each plugin, configure a MARC subfield (e.g.
100$a) to use that plugin.
From the MARC edit page, trigger the plugin and confirm that changes
made in the popup window are saved to the corresponding field in the
editor.
- unimarc_field_125a.tt
- unimarc_field_125b.tt
- unimarc_field_126a.tt
- unimarc_field_126b.tt
- unimarc_field_127.tt
Signed-off-by: delaye <stephane.delaye at biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7ea03cefd6a1612ad60ead35bbac95588ff5723c
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Dec 22 14:12:09 2017 +0000
Bug 19872: Move template JavaScript to the footer: UNIMARC editor plugins, part 4
This patch updates more and more UNIMARC plugin templates so that
JavaScript is included in the footer following the same pattern as other
templates which have been modified to fix Bug 17858.
To test you do not need a UNIMARC system.
Apply the patch and for each plugin, configure a MARC subfield (e.g.
100$a) to use that plugin.
From the MARC edit page, trigger the plugin and confirm that changes
made in the popup window are saved to the corresponding field in the
editor.
- unimarc_field_124a.tt
- unimarc_field_124b.tt
- unimarc_field_124c.tt
- unimarc_field_124d.tt
- unimarc_field_124e.tt
- unimarc_field_124f.tt
- unimarc_field_124g.tt
Signed-off-by: delaye <stephane.delaye at biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit fbfbcae838eacf7684141260e263619dd7869aef
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Dec 21 18:20:12 2017 +0000
Bug 19869: Move template JavaScript to the footer: UNIMARC editor plugins, part 3
This patch updates even more UNIMARC plugin templates so that
JavaScript is included in the footer following the same pattern as other
templates which have been modified to fix Bug 17858.
To test you do not need a UNIMARC system.
Apply the patch and for each plugin, configure a MARC subfield (e.g.
100$a) to use that plugin.
From the MARC edit page, trigger the plugin and confirm that changes
made in the popup window are saved to the corresponding field in the
editor.
- unimarc_field_123a.tt
- unimarc_field_123d.tt
- unimarc_field_123e.tt
- unimarc_field_123f.tt
- This template has been modified, but doesn't appear to be used. The
unimarc_field_1234.pl script uses unimarc_field_123g.tt as its
template.
- unimarc_field_123g.tt
- unimarc_field_123i_j.tt
Signed-off-by: Anne-Claire Bernaudin <anne-claire.bernaudin at univ-rennes1.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 0844092693358f873c059e78b51b5e1b6dd83166
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Dec 21 17:45:09 2017 +0000
Bug 19868: Move template JavaScript to the footer: UNIMARC editor plugins, part 2
This patch updates several more UNIMARC plugin templates so that
JavaScript is included in the footer following the same pattern as other
templates which have been modified to fix Bug 17858.
To test you do not need a UNIMARC system.
Apply the patch and for each plugin, configure a MARC subfield (e.g.
100$a) to use that plugin.
From the MARC edit page, trigger the plugin and confirm that changes
made in the popup window are saved to the corresponding field in the
editor.
- unimarc_field_116.tt
- unimarc_field_117.tt
- unimarc_field_120.tt
- unimarc_field_121a.tt
- unimarc_field_121b.tt
- unimarc_field_122.tt
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e42475ca28a56e83a672a618339ffdfacd09036c
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Dec 21 16:30:05 2017 +0000
Bug 19866: Move template JavaScript to the footer: UNIMARC editor plugins, part 1
This patch updates several UNIMARC plugin templates so that JavaScript
is included in the footer following the same pattern as other templates
which have been modified to fix Bug 17858.
To test you do not need a UNIMARC system.
Apply the patch and for each plugin, configure a MARC subfield (e.g.
100$a) to use that plugin.
From the MARC edit page, trigger the plugin and confirm that changes
made in the popup window are saved to the corresponding field in the
editor.
- unimarc_field_100.tt
- unimarc_field_100_authorities.tt
- unimarc_field_105.tt
- unimarc_field_106.tt
- unimarc_field_110.tt
- unimarc_field_115a.tt
- unimarc_field_115b.tt
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5e563d81aae7e2e38ecda8ce19381b023130118a
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Feb 20 14:19:31 2018 +0000
Bug 19786: (follow-up) Correct js include path, popup window size
This follow-up adds the required KOHA_VERSION variable to two templates
where it was missing.
This patch also adds a 'window_size' parameter to a popup window
function so that self-closing windows like blinddetail-biblio-search.pl
can appear small and others at a reasonable size.
To test, apply the patch and clear your browser cache if
necessary.
- Confirm that the QA tools do not complain about missing KOHA_VERSION
in auth_finder.tt and searchresultlist_auth.tt.
- Open a bibliographic record for editing in the basic editor using a
framework in which a field is linked to authorities.
- Trigger the authority selection window for that field.
- Click the "Clear field" button at the top of the authority search
pop-up window. Another smaller popup window should briefly appear, and
then both windows should close.
- Trigger the authority selection window again.
- Click the "Create new authority" button. A new window should appear
with the MARC authority editor. The window should be a usable size.
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3d41b8cce8235446812ec3a7309dd68abd4b86e4
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Dec 8 19:57:28 2017 +0000
Bug 19786: Move template JavaScript to the footer: Authorities, part 2
This patch modifies the staff client patron lists templates so that
JavaScript is included in the footer instead of the header.
To test, apply the patch and test the JavaScript-driven features of
each modified template.
I've made one change to the JavaScript in addition to moving it: I've
made it so that the blank window which pops up briefly in this process
is 100px x 100px instead of full screen.
- Cataloging -> Add or edit bibliographic record in a framework which
has authorities linked to a tag
-> Click authorities plugin link
-> Create new authority button
-> Autocomplete on text inputs (except "Search all headings")
-> Search
-> Select authority record ("choose")
-> Click authorities plugin link again
-> Clear field
Signed-off-by: Claire Gravely <claire_gravely at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 49f50a7f267e7ea105895dc5165965b149697fe3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Mar 26 17:29:52 2018 -0300
Bug 15492: DBRev 17.12.00.024
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 72061402d9e710de8ae322d46cd1d54702a27019
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Mar 19 16:31:52 2018 -0300
Bug 15492: (QA followup) Make page refresh work correctly
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1c660aef299b8b705e8a31dce91de254195baabe
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Feb 21 17:11:59 2018 -0300
Bug 15492: Add KOHA_VERSION to included .css and .js
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 4a9b69ec7adf85194cf6ef4991b1febfef692ede
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Dec 27 12:45:16 2017 -0300
Bug 15492: Display nicer message on data corruption
This patch hides scary messages and changes the wording for a more
idiomatic approach. Thanks to Nick :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 56da3e5705f2f41795a8b3c6a5ba365fe17c4137
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Dec 27 12:32:11 2017 -0300
Bug 15492: Make SCI use its own sysprefs and CSS file
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d6e8e88249914531d8b01f35200de6a8a4692b89
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Dec 27 12:29:29 2017 -0300
Bug 15492: Make existing code aware of new self_check* permissions
This patch makes the existing code for SCO use the new permissions schema
for self check modules. Specifically addresses this change:
circulate => self_checkout
becomes
slef_check => self_checkout_module
about.pl checks are dejusted too.
get_template_and_user gets refactored to avoid code duplication and the
conditions are adjusted for the new permissions.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 92b29b88c213b7ef6ebbecacc7db896a901880d3
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Dec 27 12:24:36 2017 -0300
Bug 15492: New sysprefs and permissions
In order to make this module unrelated to the SCO module, this
patch introduces the following sysprefs:
- SelfCheckInMainUserBlock
- SelfCheckInModuleUserID
- SelfCheckInTimeout
- SelfCheckInUserCSS
- SelfCheckInUserJS
It also adds a new user flag and sub-permission:
- self_check => self_checkin_module
and moves the circulate => self_checkout permission into
- self_check => self_checkout_module
Descriptions are adjusted accordingly.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8c5fa90668b2a402cddde3c2f469e3ddb0def63f
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Dec 21 12:59:13 2017 -0500
Bug 15492: (QA follow-up) Reset SCI if idle for 30 seconds
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9bf68c8c3e89bddb23662c9fbd03b7a7514c9955
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Nov 10 15:32:43 2017 -0300
Bug 15492: Add SCI module
This patch adds the SCI module, and adapts C4::Auth to know about it.
The current behaviour is:
- Requires admin user initialization/login
- Uses the logged users' library
- A form allows to scan multiple barcodes
- A button sends the barcode list to the controller
to batch perform the checkins
- Successful and failed checkins are sent to the template
- Results are displayed
- Logout link
To test:
- Apply this patches
- Make sure you upgrade:
$ kshell
k$ perl installer/data/mysql/updatedatabase.pl
- Have 'SelfCheckInModule' disabled
- Go to http://kohadev.myDNSname.org:8080/cgi-bin/koha/sci/sci-main.pl [1]
=> SUCCESS: You are rejected because the feature is disabled
- Enable 'SelfCheckInModule'
- Go to the previous URL
=> SUCCESS: You are required to login
- Login with a user WITHOUT self_checkout permissions
=> SUCCESS: You are not allowed to log into the Self check-in module.
- Login with a user WITH self_checkour permissions
=> SUCCESS: You gain access, and are presented the UI
- Go through the several options
=> SUCCESS: All works as it should
- Click the 'Help' link
=> SUCCESS: A help text is displayed on a modal
- Sign off :-D
- Bonus points:
$ kshell
k$ qa -c 2 -v 2
=> SUCCESS: All tests green
[1] Adjust to your dev's OPAC setup
Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 76853c347ee49e2a8c3f132e0b786db3df987187
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Nov 10 15:12:56 2017 -0300
Bug 15492: Add the SelfCheckInModule syspref
Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6d150eaeca5ba9c9fb3ef2229ce2138526b4db64
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Jan 23 20:21:57 2018 +0000
Bug 20081: Set inline headers for uploaded pdfs
To test:
1 - Edit a framework and add the 'upload/pl' plugin to the 856 field
2 - Attach a pdf to one record
3 - Attach a different type of file to another
(To attach, edit a record in the framework edited above and find the
helper by the 856 field)
4 - Click the links on the record
5 - Verify the pdf opens inline
6 - Verify the other file does not
7 - prove t/db_dependent/Upload.t
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ef7805aa3657e47daaa266b5334e98a1c1667d5f
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Jan 11 18:19:33 2018 +0000
Bug 19957: Allow continued editing of report after saving
To test:
1 - Edit or create a report
2 - Save it
3 - Note the report is saved but you can't keep editing
4 - Clicking 'Edit' returns you to editing
5 - Apply patch
6 - Save report
7 - Note success message remains, but report is still open for editing
8 - Note when you click the saved/updated message dissappears
9 - Try again after inserting erros into report (No Select, bad
authorised value, etc.)
10 - Note errors stil display as expected
11 - Verify message works on update of existing report and save of new
new report
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Joubu: amended patch to fix alignment
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 06424503b7c88bdead7cb7008a6a1aff3ced603e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Mar 26 17:10:26 2018 -0300
Bug 18797: Create the biblioitem entry
We need that since bug 19943
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit dc2ad5fa9da6eecddffad8e47f7ba5f716229232
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Sat Mar 17 02:24:41 2018 +0000
Bug 18797: Make rollingloans test useful
TEST PLAN
---------
1) Run the following commands on a kohadevbox:
kshell
prove -v t/db_dependent/rollingloans.t
exit
-- all the tests were skipped, not useful!
2) Apply this patch
3) Redo step 1
-- all the tests run
4) Run qa test tools
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 484d4cbbdd203578062f2dd6e15af788a0f7c1e0
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Tue Nov 7 15:29:56 2017 +0100
Bug 19584: Check compare barcodes box when uploading barcodes
This patch makes two trivial changes in the inventory interface:
[1] If you have uploaded a barcode file, the compare barcodes checkbox is
automatically checked. In most cases this will be the option the user wants.
The compare will report missed items on the shelf.
[2] If the compare barcodes checkbox is checked, the Skip items on loan-
checkbox is automatically checked. This again is often desirable. If you
compare, you normally are not interested in seeing items reported missing
while they are checked out.
Test plan:
[1] Upload a barcode file on inventory. Is the compare checked?
[2] Toggle compare. Does 'skip items on loan' change accordingly?
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Grace Smyth <gracesmythh at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 0d614eec694f7aff11a54805c57fab1d4a463f24
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Tue Nov 7 15:07:42 2017 +0100
Bug 19584: Replace label Status by Not for loan
Status does not tell me that this is the Not for loan column.
Trivial edit.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Grace Smyth <gracesmythh at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d239baf0fb331d4f99b10abef8b7085e579eb9ba
Author: Charles Farmer <charles at inlibro.com>
Date: Fri Jan 19 16:04:19 2018 -0500
Bug 19955: Minor grammatical correction
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 830b5a7d7dad1d9d1593c14419496e81f7f4b24c
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date: Thu Jan 11 13:00:31 2018 -0500
Bug 19955: Add ability to process only one 'type' of message ( sms, email, etc ) for a given run of process_message_queue.pl
It would be nice to allow emails to be sent overnight, but limit the sending of SMS messages to hours when people are awake. Adding a type limit to process_message_queue.pl would allow this to be accomplished easily.
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit cd79cf177ee8787b48f1dd81179d5ef60640db4f
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Thu Feb 22 10:51:27 2018 +0100
Bug 20267: Add basic .gitignore
Ignore files generated by ExtUtils::MakeMaker
NOTE: Limited scope does not affect files created
by translation utilities
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9eed6c5190818b9ed40bedcb0242be9d8fc34f62
Author: David Bourgault <david.bourgault at inlibro.com>
Date: Tue Nov 28 11:23:01 2017 -0500
Bug 19708: Improve code for printing the cart in OPAC
This removes a lot of useless code relating to the print function from opac-basket.tt, opac-basket.pl and opac/basket.js.
It also fixes the CSS so that no extra blank page is printed.
To test:
0) Add an item to your cart
1) Print your basket
Note the appearance of the page. There will be an extra blank page.
2) Apply patch
3) Reload basket
4) Print your basket
The appearce should be identical. The extra blank page is gone.
This only affects the OPAC.
Signed-off-by: Tomás Cohen Arazi <tomascohen at theke.io>
Signed-off-by: claude <claude.brayer at cea.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 46c4aa3551f810e8d1853f5013a282ce4ee95541
Author: Pasi Kallinen <pasi.kallinen at joensuu.fi>
Date: Mon Mar 12 13:20:06 2018 +0200
Bug 12020: Allow translating label-edit-batch hardcoded strings
Move the hardcoded error strings in the batch label edit into the template,
so they can be translated.
Test plan:
1) Apply patch
2) Go to Home -> Tools -> Label edit
3) Create a new batch with some items in it
4) Try to trigger any of the errors, check that the error
messages look correct
5) Update a language xx-YY
5) Check that the error messages show up in xx-YY-staff-prog.po
Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi>
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Changed branch to library in one of the error messages.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f47a999c9f36ed644b811e0f01b7cdcd11d068f9
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Mar 16 10:30:30 2018 +0000
Bug 20433: Remove unused Mozilla Persona image file
This patch removes an unused image file from the OPAC which was added
when we added Mozilla Persona authentication but wasn't removed when
Mozilla Persona went away.
To test, apply the patch and confirm that the image no longer exists:
koha-tmpl/opac-tmpl/bootstrap/images/sign_in_green.png
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d9dff376ae1294d147af8eca49891128f509af6a
Author: Victor Grousset <victor.grousset at biblibre.com>
Date: Wed Feb 14 11:25:34 2018 +0100
Bug 20111: i18nize units in Patron card creator
Test plan:
1. install and switch to the fr_FR locale
or another one and adapt the test plan accordingly
2. go to /cgi-bin/koha/patroncards/edit-template.pl?op=new
3. then you should see the "Unités" dropdown with english units
4. apply this patch
5. install the language
6. refresh the page
7. then you should see the "Unités" dropdown with french units
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit cc1bfafbd0c2b9e15f1253a7a7719a9ae889bfa2
Author: Victor Grousset <victor.grousset at biblibre.com>
Date: Tue Feb 13 14:27:23 2018 +0100
Bug 20111: Coding style: Fix indentation before doing actual change
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 4680a1e09e4ccf9a9028eb52b98ae0891c16e375
Author: Victor Grousset <victor.grousset at biblibre.com>
Date: Mon Mar 5 11:47:25 2018 +0100
Bug 19522: i18n Label creator: wrap text with <span>
In a SWITCH CASE.
To avoid pollution and duplication in the .po files.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit abdc75b9a5703714c513e9f7b41e4d4814795d2f
Author: Victor Grousset <victor.grousset at biblibre.com>
Date: Fri Mar 2 14:00:04 2018 +0100
Bug 19522: Label creator: Batches: make "Export Labels" translatable
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6737704c027f1195ed08c69ab395e3cc26806454
Author: Victor Grousset <victor.grousset at biblibre.com>
Date: Fri Oct 27 15:24:52 2017 +0200
Bug 19522: Label creator: edit batch: make "Export label" translatable
Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch
3. create a batch if there is none
4. edit that batch
5. Switch the language to French if you haven't done it yet
6. click on "Exporter le lot entier"
7. then you should see "Export labels"
8. apply this patch
9. install the language
10. replay steps 2 to 6
11. then you should see "Exporter des étiquettes"
Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 98d4ad2704026a39b8872a170c0a129b15b478fa
Author: Victor Grousset <victor.grousset at biblibre.com>
Date: Fri Oct 27 11:51:21 2017 +0200
Bug 19522: Label creator: edit batch: make Call number translatable
Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch
3. create a batch if there is none
4. edit that batch
5. then you should see "Call number" in the column names
6. apply this patch
7. install the fr_FR locale
8. refresh the page
9. then you should see "Cote" in the column names
Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ebd523ffd55ba89892986c87bf8cab299d035361
Author: Victor Grousset <victor.grousset at biblibre.com>
Date: Thu Oct 26 15:56:54 2017 +0200
Bug 19522: Label creator: translate empty list message
The name of the element wasn't translated in the message.
Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch
3. ensure that the list is empty
4. then you should see "pas de Batches actuellement"
5. then you should see "créer un nouveau batch."
6. apply this patch
7. install the language
8. refresh the page
9. then you should see "pas de Lots actuellement"
10. then you should see "créer un nouveau lot ."
Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 49fd4a2dac3ff8b66fc4ff189d0a557c05e41898
Author: Victor Grousset <victor.grousset at biblibre.com>
Date: Wed Oct 25 17:17:21 2017 +0200
Bug 19522: Coding style: Replace tabs with spaces
In Label creator: Templates: new/edit form
Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9ef987dacfd28ee7d5e63b12e641e96910604284
Author: Victor Grousset <victor.grousset at biblibre.com>
Date: Wed Oct 25 15:22:11 2017 +0200
Bug 19522: Label creator - some strings are not translatable
Templates: new form:
Add hardcoded unit names to make them translatable.
Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-edit-template.pl?op=new
3. then you should see the "Unités" dropdown with english units
4. apply this patch
5. install the language
6. refresh the page
7. then you should see the "Unités" dropdown with french units
Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit febb64260bc629105b0b0dc3c77da4b1452d6b8d
Author: Victor Grousset <victor.grousset at biblibre.com>
Date: Wed Oct 25 12:07:43 2017 +0200
Bug 19522: Coding style: Fix alignement after previous patch
Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5c3ead6ecd0641306c65a321d642a392a24dca63
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu Mar 15 12:37:11 2018 +0100
Bug 20422: Fix warning on uri_escape_utf8 in Output.pm
When opac-details calls parametrized_url, it triggers an uninitialized
warning when you would have a record without e.g. author, like:
Use of uninitialized value in subroutine entry at /usr/share/perl5/URI/Escape.pm line 184.
This is (imo) actually a bug in URI::Escape; it should check its args.
But we resolve the warning here by adding the "// q{}" in parametrized_url.
NOTE: Along the way we do something similar in the arrParamsBusc loop.
If the variable is undefined, jump to the next one. (Consistent with the
approach in the if-part preceding it.)
Test plan:
[1] Run t/Output.t again. Should pass now.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d3503e8119fd453241cb6d3824eeda0af0e5ec5e
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu Mar 15 14:07:11 2018 +0100
Bug 20422: Add unit test to Output.t for parametrized_url
This test will reveal that we need to resolve a warning too.
Test plan:
[1] Run t/Output.t without the second patch.
[2] The test will fail on the warning raised by an undefined value.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8b0df471e653be6e34b0800eeb7c269530195549
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Feb 28 14:26:06 2018 -0300
Bug 20298: Fix SMS characters counter when TranslateNotices is set
If you have multiple languages installed, the notices and slips page
uses the same HTML id multiple times, once for each language. This
prevents eg. the SMS character count javascript from working, because
each of the textareas has the same id.
Test plan:
Test the sms characters counter, with and without TranslateNotices
Make sure other features on this page still work correctly
QA: Make sure this change of id did not break something else.
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3c3ec562f1330d9b31033ac16d91ca0ab5ae5fbd
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Sat Feb 17 18:48:50 2018 -0300
Bug 19467: Display description instead of code for itemtype and location
On reports/itemslost.pl you must now see the descriptions instead of the
code for itemtype and location
Signed-off-by: delaye <stephane.delaye at biblibre.com>
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7465cbac2f2c65d008bcc4870a3bc8d6c5668b71
Author: Victor Grousset <victor.grousset at biblibre.com>
Date: Thu Mar 22 15:44:00 2018 +0100
Bug 20461: Serials: fix ignored params in subscription creation form
In subscription-add.pl, the two params aren't passed to
NewSubscription() but they are to ModSubscription()
== Test plan ==
1. Enable syspref "makePreviousSerialAvailable"
2. Create a minimal subscription with a value in the "Item type" and
"item type for older issues" fields.
3. Edit the subscription
4. You should see that the two fields are empty. This is the bug.
5. Apply this patch
6. Do step 2 and 3
7. You should see that the two fields have the right value
8. Express the joy of a successful and easy sign off.
(this is important, otherwise the sign off spell won't work!)
Signed-off-by: delaye <stephane.delaye at biblibre.com>
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 74ac5baba5a618174aed679256a274dcdef10166
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Mar 16 15:18:15 2018 -0300
Bug 20438: Allow uninstalling plugins not implementing the 'uninstall' method
The plugins handling code expects plugins implementing an 'uninstall' method for
cleanup purposes. It executes this method, and then moves on with removing the
configuration entries in the storage, and the plugin itself.
But the 'plugins-home.tt' template makes the tool display the 'Uninstall'
link in the dropdown ONLY when the plugin has the 'uninstall' method.
This patch fixes the issue.
To reproduce:
- Install the KitchenSink plugin [1]
=> SUCCESS: The 'actions' dropdown for KitchenSink shows an 'Uninstall' option
- Edit the code for the plugin:
$ sudo vim /var/lib/koha/kohadev/plugins/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm
- Remove the uninstall sub
- Restart everything:
$ restart_all
- Reload the browser
=> FAIL: There's no 'Uninstall' option in the actions dropdown.
- Apply this patch
- Restart everything
$ restart_all
- Reload the browser
=> SUCCESS: The 'actions' dropdown for KitchenSink shows an 'Uninstall' option
- Sign off :-D
[1] https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 001ce959b625d85d74511b2fe603993a0f3db5d5
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Mar 15 10:34:26 2018 +0000
Bug 20420: Remove unnecessary [% KOHA_VERSION %] from OPAC third-party sources
This patch removes [% KOHA_VERSION %] from the <script> tag for some
third-party JavaScript sources. [% KOHA_VERSION %] should only be used
for Koha's JS resources.
To test, apply the patch and enable the SocialNetworks and
NovelistSelect* preferences.
In the OPAC, view the detail page for a bibliographic record. In the
right-hand sidebar you should see social network icons for Google+ and
Twitter. Clicking either of them should trigger a sharing popup window.
If you have Novelist credentials and can enable the feature for the OPAC
you should see Novelist content in the place specified in your
preferences.
If you don't have Novelist credentials, put some random text in the
NovelistSelectProfile system preference. Looking at the detail page in
the OPAC, view source. You should see a link to Novelist JS around line
1020 of the source. Clicking the link should show JavaScript. This
confirms that the path is correct, thus the bug has been fixed.
Note: The QA tool will complain that [% KOHA_VERSION %] is missing. This
is a false positive.
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 4427f90de037e0175383ba2b818f0c85b79c1a32
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu Mar 22 10:36:00 2018 +0100
Bug 20459: Correct message for cancelling an article request
We should not ask for 'cancel this hold'. Remove corresponding TODO.
Fix qa warning on old bootstrap style:
btn btn-mini => btn btn-default btn-xs
I removed above change, qa tool complaint is wrong (refers to staff, we
are on opac)
Test plan:
Create an article request and cancel it on opac-user.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9007c6e8587196ab05e5727eac1e4bbb6c4ae9e4
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Fri Feb 23 14:29:48 2018 +0100
Bug 20067: Fix other checks for linked authorised value categories
The same pattern was used in other files, this patch fixes it.
Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1428615dad77f4a9702f287c461d792e908b5dcf
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Fri Feb 23 14:20:17 2018 +0100
Bug 20067: Fix false display of authorised value for materials on staff detail page
Koha didn't check for a linked authorised value category for
Koha didn't check for a linked authorised value category for
items.materials correctly which led to displaying false information
on the detail page.
To test:
- before applying the patch:
- make sure sample data and configuration is loaded
- edit any item
- write 2 in the $3 materials specificed
- check the details page normal view - it will display 'restocking'
- apply patch
- check display, it should now show "2"
- link 952$3 (MARC21) to ORDER_CANCELLATION_REASON
- check display again, it should now show 'restocking'
Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f3dfd5226d0c077428df797fb8b829ed7f333748
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Wed Jan 24 14:23:30 2018 +0100
Bug 20085: Better translatability of smart-rules.tt
Template smart-rules.tt in administration contains some if/elsif/else with translatable strings.
For example :
[% IF rule.onshelfholds == 1 %]
Yes
[% ELSIF rule.onshelfholds == 2 %]
If all unavailable
[% ELSE %]
If any unavailable
[% END %]
Adding span to translatable strings will allow to have the same translation than :
<select name="onshelfholds" id="onshelfholds">
<option value="1">Yes</option>
<option value="0">If any unavailable</option>
<option value="2">If all unavailable</option>
</select>
This is important to allow editing an existing circulation and fine rule.
Actually for example in french some strings are translated differently :
msgid "%s Yes %s If all unavailable %s If any unavailable %s"
msgstr "%s Oui %s Si tous indisponibles %s Si aucun indisponible %s"
msgid "If any unavailable"
msgstr "Si au moins un exemplaire est indisponible"
Test plan :
1) Look at PO files, for example fr-FR and see there is :
msgid "%s Yes %s If all unavailable %s If any unavailable %s"
msgid "If any unavailable"
2) Apply patch
3) update PO files
4) Look at PO files, for example fr-FR and see there is now only :
msgid "If any unavailable"
5) Install translation
6) Go to Administration > Circulation and fine rule
7) Check that when editing an existing rule, edition comboboxes are set on the correct value
8) Create a default holds policy by item type and check that correct values are displayed in table
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 952b2242cfccec7a5cedcc858942f940f80d757b
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Mar 23 13:02:29 2018 +0000
Bug 20299: Koha is a gift
This patch updates the database update script replacing the "pile of
poo" emoji with the "wrapped gift" emoji.
To test, apply the patch and go to Administration -> System preferences
-> Local use. Set the "Version" preference back to trigger a database
update. Go through the database update process and confirm that the
"Convert DB tables to utf8mb4" upgrade message includes a gift emoji.
Signed-off-by: Mason James <mtj at kohaaloha.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 423fa9cc8f9bc1976296a3c5e26845b0c0d24608
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jan 2 15:42:12 2018 -0300
Bug 18593: Move suggestions when bibliographic records are merged
When bibliographic records are merged, the suggestions.biblionumber
field should be replaced with the new record.
Ideally we should have kept an history of the merges, to know what was
the original record. Now we cannot fix the broken links.
Test plan:
1) Create a suggestion in OPAC
2) Accept the suggestion in staff
3) Add order from this suggestion
4) Go to cataloguing search and search for the record and another
5) Merge the suggestion record with the catalog record - catalog record wins (should be the more common case when a patron suggests something that already exists)
6) Verify that after merging, the new title displays in the acquisition record
7) Verify that the suggestion info no longer displays in basket
From Katrin's test plan:
8) Verify that the new title doesn't display in suggestions. The old title will still show as suggested (not updated)
=> This is the title from suggestions.title, I think it makes sense to show this one.
Maybe we should open a new bug report to improve the display of the suggestion, and link to the bibliographic record
Signed-off-by: Lucie Gay <lucie.gay at ens-paris-saclay.fr>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
.gitignore | 4 +
C4/Auth.pm | 45 ++-
C4/Letters.pm | 8 +-
C4/Output.pm | 4 +-
C4/Search.pm | 2 +-
Koha.pm | 2 +-
Koha/UploadedFile.pm | 15 +-
about.pl | 4 +-
catalogue/detail.pl | 6 +-
catalogue/itemsearch.pl | 6 +-
catalogue/moredetail.pl | 6 +-
cataloguing/merge.pl | 8 +-
circ/circulation.pl | 2 +-
debian/docs/koha-common.xml | 18 +-
debian/docs/koha-rebuild-zebra.xml | 4 +-
debian/docs/koha-restart-zebra.xml | 44 ---
debian/docs/koha-start-zebra.xml | 44 ---
debian/docs/koha-stop-zebra.xml | 44 ---
debian/koha-common.bash-completion | 5 -
debian/koha-common.install | 3 -
debian/koha-common.links | 3 +
debian/scripts/koha-restart-zebra | 116 --------
debian/scripts/koha-start-zebra | 89 ------
debian/scripts/koha-stop-zebra | 74 -----
installer/data/mysql/sysprefs.sql | 5 +
installer/data/mysql/updatedatabase.pl | 71 ++++-
installer/data/mysql/userflags.sql | 3 +-
installer/data/mysql/userpermissions.sql | 5 +-
koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 11 +-
.../prog/en/includes/auth-finder-search.inc | 105 -------
.../intranet-tmpl/prog/en/includes/permissions.inc | 9 +-
koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 15 +-
.../prog/en/modules/admin/admin-home.tt | 16 +-
.../en/modules/admin/preferences/circulation.pref | 28 +-
.../prog/en/modules/admin/smart-rules.tt | 69 +++--
koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt | 4 +-
.../prog/en/modules/authorities/auth_finder.tt | 27 +-
.../en/modules/authorities/authorities-home.tt | 10 +-
.../prog/en/modules/authorities/authorities.tt | 8 +-
.../authorities/blinddetail-biblio-search.tt | 230 +++++++--------
.../prog/en/modules/authorities/detail.tt | 9 +-
.../prog/en/modules/authorities/merge.tt | 10 +-
.../modules/authorities/searchresultlist-auth.tt | 68 +++--
.../en/modules/authorities/searchresultlist.tt | 11 +-
.../cataloguing/value_builder/unimarc_field_100.tt | 95 ++----
.../value_builder/unimarc_field_100_authorities.tt | 52 ++--
.../cataloguing/value_builder/unimarc_field_105.tt | 29 +-
.../cataloguing/value_builder/unimarc_field_106.tt | 27 +-
.../cataloguing/value_builder/unimarc_field_110.tt | 33 ++-
.../value_builder/unimarc_field_115a.tt | 36 +--
.../value_builder/unimarc_field_115b.tt | 39 +--
.../cataloguing/value_builder/unimarc_field_116.tt | 29 +-
.../cataloguing/value_builder/unimarc_field_117.tt | 27 +-
.../cataloguing/value_builder/unimarc_field_120.tt | 29 +-
.../value_builder/unimarc_field_121a.tt | 24 +-
.../value_builder/unimarc_field_121b.tt | 34 +--
.../cataloguing/value_builder/unimarc_field_122.tt | 45 +--
.../value_builder/unimarc_field_123a.tt | 23 +-
.../value_builder/unimarc_field_123d.tt | 23 +-
.../value_builder/unimarc_field_123e.tt | 24 +-
.../value_builder/unimarc_field_123f.tt | 24 +-
.../value_builder/unimarc_field_123g.tt | 24 +-
.../value_builder/unimarc_field_123i_j.tt | 38 +--
.../value_builder/unimarc_field_124a.tt | 27 +-
.../value_builder/unimarc_field_124b.tt | 25 +-
.../value_builder/unimarc_field_124c.tt | 25 +-
.../value_builder/unimarc_field_124d.tt | 25 +-
.../value_builder/unimarc_field_124e.tt | 27 +-
.../value_builder/unimarc_field_124f.tt | 27 +-
.../value_builder/unimarc_field_124g.tt | 25 +-
.../value_builder/unimarc_field_125a.tt | 25 +-
.../value_builder/unimarc_field_125b.tt | 25 +-
.../value_builder/unimarc_field_126a.tt | 23 +-
.../value_builder/unimarc_field_126b.tt | 27 +-
.../cataloguing/value_builder/unimarc_field_127.tt | 40 +--
.../value_builder/unimarc_field_128a.tt | 28 +-
.../value_builder/unimarc_field_128b.tt | 27 +-
.../value_builder/unimarc_field_128c.tt | 24 +-
.../cataloguing/value_builder/unimarc_field_130.tt | 28 +-
.../value_builder/unimarc_field_135a.tt | 22 +-
.../cataloguing/value_builder/unimarc_field_140.tt | 28 +-
.../cataloguing/value_builder/unimarc_field_141.tt | 30 +-
.../value_builder/unimarc_field_210c.tt | 26 +-
.../value_builder/unimarc_field_210c_bis.tt | 51 ++--
.../value_builder/unimarc_field_225a.tt | 19 +-
.../value_builder/unimarc_field_225a_bis.tt | 55 ++--
.../cataloguing/value_builder/unimarc_field_4XX.tt | 228 +++++++--------
.../value_builder/unimarc_field_700-4.tt | 33 ++-
.../cataloguing/value_builder/unimarc_leader.tt | 31 +-
.../en/modules/cataloguing/z3950_auth_search.tt | 166 ++++++-----
.../prog/en/modules/labels/label-edit-batch.tt | 24 +-
.../prog/en/modules/labels/label-edit-template.tt | 24 +-
.../prog/en/modules/labels/label-manage.tt | 38 +--
.../prog/en/modules/patroncards/edit-batch.tt | 307 ++++++++++----------
.../prog/en/modules/patroncards/edit-layout.tt | 211 +++++++-------
.../prog/en/modules/patroncards/edit-profile.tt | 74 ++---
.../prog/en/modules/patroncards/edit-template.tt | 115 ++++----
.../prog/en/modules/patroncards/image-manage.tt | 96 +++---
.../prog/en/modules/patroncards/manage.tt | 294 ++++++++++---------
.../prog/en/modules/patroncards/print.tt | 40 ++-
.../prog/en/modules/plugins/plugins-home.tt | 2 -
.../en/modules/reports/guided_reports_start.tt | 30 +-
.../prog/en/modules/reports/itemslost.tt | 5 +-
.../prog/en/modules/reports/reports-home.tt | 43 ++-
.../prog/en/modules/serials/subscription-add.tt | 18 +-
.../prog/en/modules/suggestion/suggestion.tt | 15 +-
.../prog/en/modules/tools/inventory.tt | 7 +-
.../intranet-tmpl/prog/en/modules/tools/letter.tt | 21 +-
.../intranet-tmpl/prog/js/auth-finder-search.js | 104 +++++++
.../opac-tmpl/bootstrap/css/{sco.css => sci.css} | 12 +
koha-tmpl/opac-tmpl/bootstrap/css/sco.css | 12 +
.../opac-tmpl/bootstrap/en/modules/opac-auth.tt | 4 +
.../opac-tmpl/bootstrap/en/modules/opac-basket.tt | 39 +--
.../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 6 +-
.../opac-tmpl/bootstrap/en/modules/opac-user.tt | 4 +-
.../opac-tmpl/bootstrap/en/modules/sci/sci-main.tt | 272 +++++++++++++++++
.../opac-tmpl/bootstrap/images/sign_in_green.png | Bin 1803 -> 0 bytes
koha-tmpl/opac-tmpl/bootstrap/js/basket.js | 5 -
labels/label-edit-batch.pl | 14 +-
misc/cronjobs/process_message_queue.pl | 5 +-
opac/opac-basket.pl | 2 -
opac/opac-detail.pl | 1 +
opac/sci/sci-main.pl | 100 +++++++
opac/sco/help.pl | 18 +-
opac/sco/sco-main.pl | 19 +-
opac/sco/sco-patron-image.pl | 2 +-
reports/guided_reports.pl | 26 +-
serials/subscription-add.pl | 2 +-
t/Output.t | 15 +-
t/db_dependent/Letters.t | 8 +-
t/db_dependent/Upload.t | 13 +-
t/db_dependent/rollingloans.t | 28 +-
tools/inventory.pl | 4 +-
133 files changed, 2726 insertions(+), 2395 deletions(-)
create mode 100644 .gitignore
delete mode 100644 debian/docs/koha-restart-zebra.xml
delete mode 100644 debian/docs/koha-start-zebra.xml
delete mode 100644 debian/docs/koha-stop-zebra.xml
create mode 100644 debian/koha-common.links
delete mode 100755 debian/scripts/koha-restart-zebra
delete mode 100755 debian/scripts/koha-start-zebra
delete mode 100755 debian/scripts/koha-stop-zebra
create mode 100644 koha-tmpl/intranet-tmpl/prog/js/auth-finder-search.js
copy koha-tmpl/opac-tmpl/bootstrap/css/{sco.css => sci.css} (97%)
create mode 100644 koha-tmpl/opac-tmpl/bootstrap/en/modules/sci/sci-main.tt
delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/images/sign_in_green.png
create mode 100755 opac/sci/sci-main.pl
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list