[koha-commits] main Koha release repository branch master updated. v17.11.00-987-gfbf3744
Git repo owner
gitmaster at git.koha-community.org
Thu Mar 29 17:11:06 CEST 2018
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via fbf374498bb327b2948904fd8783944ab2a9e389 (commit)
via a7e46047cffbca02d08049729911a274970244f5 (commit)
via 87dc9b0ac1db2b689385a5b65e7d1293ea8bca0a (commit)
via 10de4f437f3ca9f368e52f79ab6fb1b86c916209 (commit)
via dce823c12255c8d3db3761c30fc04370d3682157 (commit)
via 2183c7a175f1ac3648b7963a5d18dce0cd2936f9 (commit)
via e36dc18376390d2747ce5d831064146817cd24c9 (commit)
via 6c3a273af93dbe64d050190a6cdfb9e9453a9364 (commit)
via dd9b6c165163ac1d6b52df6f2df17ec5de6b2758 (commit)
via 7b8909cb9080216352b0a68564476c8861f7e790 (commit)
via 275c5bd4fa11c30606d11d7bfb2eab8c0a31ed04 (commit)
via ae57ac3792d16c546efdd4949c07218e8ccccf0b (commit)
via 8b76ee39d4b3696d9ec7e71cdcc785b2980e10ff (commit)
via 3afd4a7e1aff525d870aef5d4693016885a6dbcf (commit)
via 8e07761f30c576e5f8b275d83ce6dea578148e94 (commit)
via 444ac690745cb360db852303b1ff461fa8c7175e (commit)
via e3e7c265acea3e30313d9f824ee27e5391bf71e8 (commit)
via 8c12ddd88d5a3b04faa260a8fbbcc253f7c26c2d (commit)
via e2869cb0143a6176e44ff5bf0b4d0dda65be7e2e (commit)
via e0fbc15c9764e5cff1edf8b71d8c0f3370aa8da4 (commit)
via 735b4e0fc027f7e8a66640fe11174f709131160f (commit)
via ac38492107c14acd2651cae07beeb81a56d4f132 (commit)
via 0a9031676eefbccad1afa6594df8990b8202b0fa (commit)
from 64616fe2ffc35bf65aa28dcbc36b30e648591cf2 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit fbf374498bb327b2948904fd8783944ab2a9e389
Author: Lari Taskula <lari.taskula at jns.fi>
Date: Wed Mar 28 21:19:52 2018 +0000
Bug 20490: Correct bug number typo in comment in Circulation.t
NOTE: Confirmed that the typo of 17641 was part of bug 17941.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit a7e46047cffbca02d08049729911a274970244f5
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Dec 8 09:35:45 2017 -0300
Bug 19784: Adapt /v1/patrons to new naming guidelines
This patch introduces two functions to the patrons endpoint:
- _to_api
- _to_model
This are in charge of field mappings in order to comply with the
guidelines.
Koha::REST::V1:Auth is adjusted to handle 'patron_id' as well. 'borrowernumber'
handling is kept until the existing endpoints get updated.
To test:
- Apply the patches
- Run:
$ kshell
k$ prove t/db_dependent/api/v1/*.t
=> SUCCESS: Tests pass!
- Sign off :-D
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 87dc9b0ac1db2b689385a5b65e7d1293ea8bca0a
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Dec 8 09:25:35 2017 -0300
Bug 19784: Remove reference to 'borrowernumber' param from other endpoints
This patch removes the $ref occurences for borrowernumber in not
patron-specific endpoints. 'borrowernumber' is still used on them, but as a
hardcoded parameter. The param rename will happen on a separate bug for
each endpoint.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 10de4f437f3ca9f368e52f79ab6fb1b86c916209
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Dec 8 09:17:28 2017 -0300
Bug 19784: Unit tests for /api/v1/patrons
This patch adapts the existing endpoint's tests so they expect:
- 'patron_id' for 'borrowernumber'
- 'library_id' for 'branchcode'
- 'category_id' for 'categorycode'
In the process, I tried to make the tests more robust, by creating random
data that gets deleted to make sure our tests cases can't have false
positives.
Independent subtests are wrapped inside transactions to avoid
eventual interference.
To test:
- Apply the patch
- Run:
$ kshell
k$ prove t/db_dependent/api/v1/patrons.t
=> FAIL: The api doesn't implement the expected behaviour and attributes
for endpoint responses
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit dce823c12255c8d3db3761c30fc04370d3682157
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Mon Feb 19 07:15:22 2018 +0000
Bug 16330: (QA follow-up) Update usage of search plugin because of bug 19686
Test plan:
prove t/db_dependent/api/v1/patrons.t
--> without patch the list subtest fail
--> with patch test pass
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 2183c7a175f1ac3648b7963a5d18dce0cd2936f9
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Dec 19 14:46:45 2017 -0300
Bug 16330: Remove validation code from Koha::Patron
This patch removes previously added validation code from Koha::Patron
as we will rely on the DB structure and relationships to catch the same
problems. This is implemented on bug 19828.
This patch also adapts the API controller class to expect this behaviour
change from Koha::Patron. The expected exceptions are adjusted, and some
minor changes take place. The API tests are adjusted as well.
To test:
- Run:
$ kshell
k$ prove t/db_dependent/Koha/Patrons.t
k$ prove t/db_dependent/api/v1/patrons.t
=> SUCCESS: Tests should still pass
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e36dc18376390d2747ce5d831064146817cd24c9
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Dec 12 18:53:45 2017 -0300
Bug 16330: (QA follow-up) ModMember requires borrowernumber
Works perfectly. Well done everyone!
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
Signed-off-by: Dilan Johnpullé <dilan at calyx.net.au>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6c3a273af93dbe64d050190a6cdfb9e9453a9364
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Dec 5 16:43:00 2017 -0300
Bug 16330: (QA follow-up) Repect guidelines on plurals Patron > Patrons
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit dd9b6c165163ac1d6b52df6f2df17ec5de6b2758
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Dec 4 16:18:47 2017 -0300
Bug 16330: Move patches to OpenAPI
This patch refactors the original work so it implements the controllers
and the spec using Mojolicious::Plugin::OpenAPI, and OpenAPI for the specification.
It removes the ability for patrons without permissions to edit their own data or their
guarantee's. This will be moved to a patron modification requests endpoint for simplicity.
It makes use of bugs 19410 and 19686 and their dependencies to deal with parameters handling,
query building and pagination.
Tests are adapted.
To test:
- Apply this patches and the dependencies
- Run:
$ kshell
k$ prove t/db_dependent/api/v1/patrons.t
=> SUCCESS: Tests pass!
- Sign off :-D
Sponsored-by: ByWater Solutions
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7b8909cb9080216352b0a68564476c8861f7e790
Author: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
Date: Wed Apr 27 13:47:04 2016 +0000
Bug 16330: Add routes to add, update and delete patrons
This patch adds support for add, edit and delete patrons via REST API.
GET /api/v1/patrons Get patron list from params
GET /api/v1/patrons/<borrowernumber> Get single patron
POST /api/v1/patrons Create a new patron
PUT /api/v1/patrons/<borrowernumber> Update data about patron
DEL /api/v1/patrons/<borrowernumber> Delete a patron
Revised Test plan:
1) Apply this patch
2) Run tests perl t/db_dependent/api/v1/patrons.t
3) Add a user with proper rights to use the REST API
4) play with your favourite REST client (curl/httpie, etc.):
Authenticate with the user created above and get a CGISESSION id.
Use the CGISESSION to add, edit and delete patrons via the API.
5) Use PUT /patrons/<borrowernumber> for a patron without borrowers
flag. This should go into pending patron modification status and
needs to be accepted by a librarian.
Please note there is no validation of body input in PUT/POST other
than branchcode,category,userid,cardnumber.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 275c5bd4fa11c30606d11d7bfb2eab8c0a31ed04
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sun Mar 25 22:10:22 2018 +0200
Bug 19488: (QA follow-up) Fix spelling, remove ()
Fixes spelling to match the details page and removes ().
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ae57ac3792d16c546efdd4949c07218e8ccccf0b
Author: Jesse Maseto <jesse at bywatersolutions.com>
Date: Fri Mar 2 14:48:06 2018 +0000
Bug 19488: Add borrowernumber to brief info on patron details pages in staff client
To test:
- View different tabs of a borrower's patron account in staff
- Verify the borrowernumber is shown in the brief info section
on the left
Signed-off-by: JM Broust <jean-manuel.broust at univ-lyon2.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8b76ee39d4b3696d9ec7e71cdcc785b2980e10ff
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Mar 28 12:42:19 2018 +0000
Bug 19564: (QA follow-up) Make commented out tests pass
We likely shoudln't pass through an uncoverted sort order for now, but
it does allow us to look ahead to implementing the orders directly so
seems a good option to have.
Either this patch should be used, or the commented out tests should be
removed
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3afd4a7e1aff525d870aef5d4693016885a6dbcf
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Dec 22 15:21:51 2017 -0300
Bug 19564: Add tests for _convert_sort_fields
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8e07761f30c576e5f8b275d83ce6dea578148e94
Author: David Gustafsson <david.gustafsson at ub.gu.se>
Date: Thu Nov 2 15:02:23 2017 +0100
Bug 19564: Fix extraction of sort order from sort condition name
Currently sort order is extracted from sort condition by splitting the
field, instead use regular expression to extract the last part preceded
by underscore.
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 444ac690745cb360db852303b1ff461fa8c7175e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Dec 20 21:35:47 2017 -0300
Bug 19673: Allow to set patron attributes to 0 with batch patron modification
This patch will have to be tested deeply to make sure it will not
introduce regression!
The idea is to display an empty option in the patron attributes select
and ignore it. That way we can deal with false values 0 and "" which
were skipped before.
Test plan:
Add several patron attributes
Use the batch patron modification tool to add/update/remove them
Play with empty "" and 0 values, as well as other values
Modify several attributes in a row
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e3e7c265acea3e30313d9f824ee27e5391bf71e8
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Jan 4 15:31:52 2018 +0000
Bug 19916: Add keyword and standard ID fields to acq external search
To test:
1 - Add an order from external source
2 - Note you don't have keyword or standard ID fields
3 - Add a catalog record from Z3950, note those fields are there
4 - Apply patch
5 - Check acq and note you do have those fields
6 - Do some searches to verify they work as expected
Signed-off-by: Maksim Sen <maksim.sen at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8c12ddd88d5a3b04faa260a8fbbcc253f7c26c2d
Author: Pasi Kallinen <pasi.kallinen at joensuu.fi>
Date: Mon Mar 5 09:09:28 2018 +0200
Bug 20330: Allow translating more of quote upload
Translate the error messages, and the table headers.
Test plan:
1) Go to Home -> Tools -> Quote editor -> Import quotes
2) Upload quotes from a file. Try to trigger the error messages
3) On successful import, check the table header texts
4) Apply patch, update & install a language
5) The error messages and the table header texts should
show up in the xx-YY-staff-prog.po
6) Repeat 1,2,3
Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi>
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e2869cb0143a6176e44ff5bf0b4d0dda65be7e2e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Mar 28 15:54:56 2018 -0300
Bug 18055: The 2 new deps are used for testing purpose
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e0fbc15c9764e5cff1edf8b71d8c0f3370aa8da4
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Sep 1 12:25:27 2017 -0300
Bug 18055: (QA followup) Only print output if DEBUG
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 735b4e0fc027f7e8a66640fe11174f709131160f
Author: Mason James <mtj at kohaaloha.com>
Date: Fri Jun 16 01:20:05 2017 +1200
Bug 18055: Speed up '00-strict.t' test, with Parallel::ForkManager
add KOHA_PROVE_CPUS envar to manually set number of cpus
to test..
1/ set number of cpus to 1
$ export KOHA_PROVE_CPUS=1
2/ observe 1 cpus are used
$ time prove -v t/db_dependent/00-strict.t
t/db_dependent/00-strict.t ..
Using 1 CPUs...
3/ unset number of cpus
$ export KOHA_PROVE_CPUS=
4/ observe all available cpus are used
$ time prove -v t/db_dependent/00-strict.t
t/db_dependent/00-strict.t ..
Using 32 CPUs...
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ac38492107c14acd2651cae07beeb81a56d4f132
Author: Mason James <mtj at kohaaloha.com>
Date: Sun Feb 5 14:40:06 2017 +1300
Bug 18055: Speed up '00-strict.t' test, with Parallel::ForkManager
to test...
1/ run 00-strict.t test, (16.5 mins on a 4xcpu system)
$ time prove t/db_dependent/00-strict.t
...
Files=1, Tests=654, 994 wallclock secs ( 0.19 usr 0.04 sys + 873.40 cusr 116.20 csys = 989.83 CPU)
Result: PASS
real 16m34.104s
2/ apply patch
3/ install Parallel::ForkManager package
$ sudo apt-get install libparallel-forkmanager-perl libsys-cpu-perl
4/ run 00-strict.t test again, (now 6 mins.. much faster)
$ time prove t/db_dependent/00-strict.t
...
Files=1, Tests=654, 364 wallclock secs ( 0.07 usr 0.01 sys + 1159.20 cusr 153.41 csys = 1312.69 CPU)
Result: PASS
real 6m4.355s
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Edit: removed debian/control changes as the file is generated
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 0a9031676eefbccad1afa6594df8990b8202b0fa
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Mar 26 13:13:58 2018 -0300
Bug 20455: Fix sort patrons by date expired
We may need to apply this change for all other occurrences in our
codebase.
Test plan:
- Make sure sample patron data is loaded and you have a patron without a
date expired defined
- Make an empty search for all patrons or another search that gives you
a good amount of results
- Try to sort on the date expired column
=> Without this patch you get
Odd number of elements in anonymous hash
at /home/vagrant/kohaclone/C4/Utils/DataTables/Members.pm line 189.
output_pref is called with 'dateonly' (ref SCALAR), not a DateTime
object
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
C4/Installer/PerlDependencies.pm | 11 +-
C4/Utils/DataTables/Members.pm | 2 +-
Koha/Exceptions.pm | 8 +-
Koha/Patron.pm | 16 +-
Koha/REST/V1/Auth.pm | 9 +-
Koha/REST/V1/Patron.pm | 45 --
Koha/REST/V1/Patrons.pm | 499 ++++++++++++++++
Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 4 +-
acqui/z3950_search.pl | 8 +-
api/v1/swagger/definitions/hold.json | 3 +-
api/v1/swagger/definitions/patron.json | 140 ++---
api/v1/swagger/parameters.json | 8 +-
api/v1/swagger/parameters/patron.json | 10 +-
api/v1/swagger/paths.json | 4 +-
api/v1/swagger/paths/holds.json | 7 +-
api/v1/swagger/paths/illrequests.json | 6 +-
api/v1/swagger/paths/patrons.json | 609 +++++++++++++++++++-
api/v1/swagger/x-primitives.json | 4 +-
.../intranet-tmpl/prog/en/includes/circ-menu.inc | 3 +-
.../prog/en/modules/acqui/z3950_search.tt | 2 +
.../prog/en/modules/tools/modborrowers.tt | 22 +-
.../prog/en/modules/tools/quotes-upload.tt | 14 +-
t/db_dependent/00-strict.t | 61 +-
t/db_dependent/Circulation.t | 4 +-
.../Koha_SearchEngine_Elasticsearch_Search.t | 25 +-
t/db_dependent/api/v1/patrons.t | 505 ++++++++++++----
tools/modborrowers.pl | 3 -
27 files changed, 1735 insertions(+), 297 deletions(-)
delete mode 100644 Koha/REST/V1/Patron.pm
create mode 100644 Koha/REST/V1/Patrons.pm
mode change 100644 => 100755 t/db_dependent/00-strict.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list