From gitmaster at git.koha-community.org Wed May 2 08:10:57 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 02 May 2018 06:10:57 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.11-1-g524ae2c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via 524ae2ccfa058d605ec8e2f1373ae0ce0e72d4f1 (commit) from 0eff1d200af609f9f663db8e0cd29a26894654a2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 524ae2ccfa058d605ec8e2f1373ae0ce0e72d4f1 Author: Jonathan Druart Date: Wed Dec 20 13:17:50 2017 -0300 Bug 19671: Map itemtypes to hash for correct display in issues_stats.pl To test: 1 - Run the circulation wizard with itemtypes as columns, shelving locations as rows - display on screen 2 - Note all itemtype values are blank 3 - Switch rows/columns - same issue 4 - Apply patch 5 - Re-run reports 6 - Itemtypes should display correctly Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit b3bab56c3168217878e0db921cebef0a97c01303) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: reports/issues_stats.pl | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 3 16:14:08 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 03 May 2018 14:14:08 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.11.00-1354-gde9cfe0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via de9cfe0c946e394ebbe765f8b07bacf23d3d9c66 (commit) from e5d5038fa3a1fbfaf81f4b01d319b00af5a7c46c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit de9cfe0c946e394ebbe765f8b07bacf23d3d9c66 Author: David Bourgault Date: Tue May 1 15:09:53 2018 -0400 Bug 19466: Turn AutoCalc off for new installs Default value of AutoMemberNum is now 0. TEST PLAN: 0. Do a fresh install of Koha 1. In system preferences AutoMemberNum should be off 2. No warning should be shown next to the cardnumber field in the patron creation form. Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/sysprefs.sql | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 3 18:50:07 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 03 May 2018 16:50:07 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.11.00-1378-g150a589 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 150a589e088906e2eed255fe05aa292dfdde5fdc (commit) via 8c4928048e9013956413378ad33873d75d7d3e96 (commit) via ba0abdf9292c26cfddb040bb3e491d03bf7e013f (commit) via 67ec2ead88c7d58f7977a206ad75f00eddef8095 (commit) via 0f9ec1287539e61f4dd089131cf69cb90fb3f8e2 (commit) via 6d59eee2bae08799358a8ea4dc17d4dd861784c4 (commit) via b7787d1022b5f5c344e7d841a48ea1a2cc8dceed (commit) via ddd40048ce482d90eba45031b892e516af6de8cd (commit) via 4c3a257448a238ec070ef209be70f76182cc91c4 (commit) via 60e5a8a2aba887371966c593ffab44c6a4ac5d94 (commit) via 90fd45d0f279c58083e14f7953ea762726b8386f (commit) via 4c9b26e437f70f9ad422586cc3a40812aa660aff (commit) via fc595ecc175c84727ed33157b5572dcb7196e163 (commit) via fde5422d80f2f85c3080aa1b2eb9792059d9bf55 (commit) via d15af45055fd9c1c8df575f49a382ba7e4b48d0d (commit) via ae29e71c2a928b47a78b12e72d149849d8d8f331 (commit) via 2d285342347248749bb26e0be635e062bff265dc (commit) via e5220bc6a130e7fe8a31739b98993b203cfee2b6 (commit) via b6c739ae9c7ff7a50398d6d4e22f7afa69a3cc47 (commit) via 4f8add96131837dc797cb0222c67060732e4ffa8 (commit) via d6f3e1fbe6d2efa593b3a7ca06b6d8664d61f650 (commit) via 64be74b3380441b645ec808e0c30455e76b326e1 (commit) via 0a50dc1ad59b52ae47b5749b984763e8e85d0cb7 (commit) via ebc32f2aae4081c4f0e3e10e5353d65faff77c7a (commit) from de9cfe0c946e394ebbe765f8b07bacf23d3d9c66 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 150a589e088906e2eed255fe05aa292dfdde5fdc Author: Jonathan Druart Date: Thu May 3 13:39:53 2018 -0300 Bug 11317: DBRev 17.12.00.041 Signed-off-by: Jonathan Druart commit 8c4928048e9013956413378ad33873d75d7d3e96 Author: Katrin Fischer Date: Sat Apr 28 02:30:55 2018 +0200 Bug 11317: (QA follow-up) Change tool name to be more general I think this tool could be used in multiple ways, for all kinds of files that you want to protect by login in Koha. So a more general name might work better. This is a suggestion, not mandatory. Signed-off-by: Jonathan Druart commit ba0abdf9292c26cfddb040bb3e491d03bf7e013f Author: Katrin Fischer Date: Sat Apr 28 00:29:06 2018 +0200 Bug 11317: (QA follow-up) Fix merge error and punctuation 2 tiny fixes: - Remove space before : as this is not correct in English - Remove an errorenous commented line that probably snuck back in from a merge Signed-off-by: Jonathan Druart commit 67ec2ead88c7d58f7977a206ad75f00eddef8095 Author: Roch D'Amour Date: Mon Apr 23 09:20:35 2018 -0400 Bug 11317: (follow-up) Add two-level entry to koha-conf and remove unwanted characters - Removed merge marker - Changed include path in favor of using the Asset tt plugin (bug 20538) - Changed access_dir to a two-level entry for clarity Test plans stay the same, just make sure that the two-level configuration entry work properly and everything pass QA. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 0f9ec1287539e61f4dd089131cf69cb90fb3f8e2 Author: Roch D'Amour Date: Tue Apr 17 14:24:07 2018 -0400 Bug 11317: Add a way to access files from the intranet This squash contains all of these commits: - Adds a page to access log files on the server from the intranet - Update ID to allow for permalinking - Rename config to "'accessdir' and fix qa - Allows for multiple directories to be accessible - Update the link under reports - (Follow-up) Fixing merge error and cosmetic changes - (Follow-up) Fix tab chars and move javascript to the footer - (QA Follow-up) Fix datatable - Make filename unicode-proof, renamed accessdir to access_dir and fix update Test plans: - Apply patch, update database - Add to koha-conf: /tmp/koha-public/one /tmp/koha-public/two /tmp/koha-public - Create these directories ( mkdir /tmp/koha-public , etc...) - Create these files: echo "hello world!" > /tmp/koha-public/? echo "test" > /tmp/koha-public/one/samename.txt echo "this is not the same" > /tmp/koha-public/two/samename.txt - Login as Superadmin, go to tools > reports files - Click on ?, make sure it's downloadable and readable - Click on both samename.txt, look inside and make sure the file is different - Login as NON-superadmin. Go under tools, see no Report/Log under the third column - Go to add tools/access_file permission to user - See new entry under tools third column. - validate link is ok. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 6d59eee2bae08799358a8ea4dc17d4dd861784c4 Author: Mark Tompsett Date: Wed Mar 28 22:40:09 2018 +0000 Bug 20103: Readonly::XS is completely bogus post perl 5.8 A ha! Lie about who we are, and the module will return a version. ./koha_perl_deps.pl -a -- before patch Readonly::XS is 0 -- after patch it has a version number. run koha qa test tools Signed-off-by: Victor Grousset Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit b7787d1022b5f5c344e7d841a48ea1a2cc8dceed Author: Josef Moravec Date: Mon Mar 19 09:33:50 2018 +0000 Bug 20444: Remove sub GetAttributes 0) Apply this patch 1) git grep GetAttributes should return no occurencies Signed-off-by: S?verine QUEUNE Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit ddd40048ce482d90eba45031b892e516af6de8cd Author: Josef Moravec Date: Mon Mar 19 09:33:07 2018 +0000 Bug 20444: Update test 0) Apply this patch 1) prove t/db_dependent/Members/Attributes.t should return green Signed-off-by: S?verine QUEUNE Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 4c3a257448a238ec070ef209be70f76182cc91c4 Author: Josef Moravec Date: Mon Mar 19 09:27:07 2018 +0000 Bug 20444: Use Koha::Patron::Attribute::Types object for getting patron attributes in letter.pl Test plan: 0) Apply the patch 1) Do not have any patron attribute types defined 2) Go to Tools -> Notices and slips 3) Edit any slip/letter which uses table borrower 4) Confirm the editing works, and the slip/letter itself works 5) Add some patron attributes types and define them a value for any patron 6) Go to Tools -> Notices and slips and edit any slip/letter which uses table borrower 7) Confirm, the attributes are listed in available fields 8) Confirm the slip/letter is working when you add a attribute to it Signed-off-by: S?verine QUEUNE Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 60e5a8a2aba887371966c593ffab44c6a4ac5d94 Author: Alex Arnaud Date: Tue Dec 5 10:43:05 2017 +0000 Bug 19752: offline_circ/service.pl - Return HTTP status 401 when authentication failed and add option nocookie Test plan: - Apply this patch, - log in to Koha, - go to cgi-bin/koha/offline_circ/service.pl with no valid user and password as parameters and nocookie set to 1. i.e: cgi-bin/koha/offline_circ/service.pl?userid=alex&password=wrongpass&nocookie=1, - auth should fail - check that the response code is 401 Signed-off-by: Maksim Sen Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 90fd45d0f279c58083e14f7953ea762726b8386f Author: Katrin Fischer Date: Sun Apr 22 18:37:11 2018 +0000 Bug 19972: (QA follow-up) Fix id name Renames #type-filter to #itemtype-filter Signed-off-by: Jonathan Druart commit 4c9b26e437f70f9ad422586cc3a40812aa660aff Author: Victor Grousset Date: Tue Jan 16 10:06:20 2018 +0100 Bug 19972: Make holds to pull list honors item-level_itypes syspref And reflect that in the UI strings + variable names Test plan: 1. Set syspref "item-level_itypes" to "specific item" 2. Create a hold on a record with one item 3. Change the document type of the item 4. Check that the item edition page and the record page show 2 different types. 5. Go to /cgi-bin/koha/circ/pendingreserves.pl 6. Check that the displayed type is the item one 7. Set syspref "item-level_itypes" to "biblio record" 8. Go to /cgi-bin/koha/circ/pendingreserves.pl 9. See that the displayed type is the item one. When the sysopref says "record" This is the bug. 10. Apply this patch 11. Go to /cgi-bin/koha/circ/pendingreserves.pl 12. See that the displayed type now follows the syspref 13. Set syspref "item-level_itypes" to "specific item" 14. Go to /cgi-bin/koha/circ/pendingreserves.pl 15. See that the displayed type still follows the syspref Signed-off-by: Lucie Gay Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit fc595ecc175c84727ed33157b5572dcb7196e163 Author: Mark Tompsett Date: Thu Apr 26 16:57:47 2018 +0000 Bug 20666: Correct permissions on opac-routing-lists.pl You will need to have the 'Your routing lists' appear in the opac-user page in order to trigger the error. Make sure plack is off, and you will an error 500 page. Signed-off-by: Katrin Fischer Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit fde5422d80f2f85c3080aa1b2eb9792059d9bf55 Author: Mark Tompsett Date: Thu Apr 26 16:22:16 2018 +0000 Bug 20666: Correct executable permissions TEST PLAN --------- On a kohadevbox: 1) sudo koha-plack --enable kohadev 2) restart_all 3) Enter fines for a patron in the staff client 4) Go to the 'Fines' tab (left pane) 5) Go to the 'Account' tab (below the row of buttons) 6) Click 'Details' -- no issues 7) sudo koha-plack --disable kohadev 8) restart_all 9) refresh page -- Error 500 10) apply patch 11) restart_all 12) refresh page -- no issues 13) sudo koha-plack --enable kohadev 14) restart_all 15) refresh page -- no issues Signed-off-by: Katrin Fischer Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit d15af45055fd9c1c8df575f49a382ba7e4b48d0d Author: Jonathan Druart Date: Tue Apr 24 15:21:36 2018 -0300 Bug 20637: Fix filters content on the holds to pull screen libraries and locations are separated by
whereas itypes are using \n This patch standardized the separator to generate correctly the filters pulldown Test plan: - Place a hold on a biblio record which has several items - Define different locations and itypes for these items - Display the holds on the "Holds to pull" screen and make sure the filters are working correctly (focus on the dropdown list) Signed-off-by: Victor Grousset Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit ae29e71c2a928b47a78b12e72d149849d8d8f331 Author: Owen Leonard Date: Wed Apr 25 12:38:25 2018 +0000 Bug 20329: Text input fields are wider than the fieldset class they are inside of This alternate patch defines a width of 100% for text inputs and selects inside sidebar fieldsets. The scope of this style is limited to the sidebar by unsetting the width for fieldsets within "#yui-main," the main body of the page. This patch also removes inline styles from two templates which are now unnecessary. To test, apply the patch and clear your cache if necessary. View various pages which have a sidebar search form: acqui/invoices.pl, members/members-home.pl, circ/overdue.pl, acqui/parcel.pl. Confirm that form fields in the sidebar look correct. Confirm that other forms styled with the "brief" class aren't unintentionally affected by this patch. For example: circ/request-article.pl, members/member-password.pl, reports/reports-home.pl, reserve/request.pl Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit 2d285342347248749bb26e0be635e062bff265dc Author: Alex Buckley Date: Sun Mar 4 05:31:15 2018 +0000 Bug 20329: Shorten the width of text input fields This makes the text input fields fit tidily within the border of the fieldset class elements they are within. Test plan: 1. Go to the acqui/invoices.pl, members/members-home.pl, circ/overdue.pl, acqui/parcel.pl and notice that the text input fields on the fieldset element on the left hand side of the screen for filtering search results are too wide and go over the border of the fieldset element 2. Apply patch 3. Refresh the aforementioned pages and notice the text inputs have a shortened width and now fit within the fielset class element Sponsored-By: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit e5220bc6a130e7fe8a31739b98993b203cfee2b6 Author: Magnus Enger Date: Mon Apr 9 12:39:23 2018 +0200 Bug 20546: Display shelving location on checkin Currently, the sehlving location is not being displayed in the table of checked in items on /cgi-bin/koha/circ/returns.pl To test: - Make sure you have a couple of books with a value for shelving location (952$c) - Check the books out - Check the books in - Verify nothing is displayed in the "Shelving location" column - Apply this patch - Check the books out and in again - Verify the shelving location is now being displayed Signed-off-by: Katrin Fischer Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit b6c739ae9c7ff7a50398d6d4e22f7afa69a3cc47 Author: Julian Maurice Date: Thu Apr 26 13:48:58 2018 +0200 Bug 20304: (QA follow-up) Remove unwanted 'my' 'my' creates a new '$value' variable, and prevented the '$value' in outer scope to be modified Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit 4f8add96131837dc797cb0222c67060732e4ffa8 Author: Jonathan Druart Date: Tue Feb 27 13:36:21 2018 -0300 Bug 20304: Remove warnings from cataloguing scripts Signed-off-by: Mark Tompsett Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit d6f3e1fbe6d2efa593b3a7ca06b6d8664d61f650 Author: Jonathan Druart Date: Fri Mar 23 15:03:52 2018 -0300 Bug 18342: Mark Cache::Memcached as mandatory Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 64be74b3380441b645ec808e0c30455e76b326e1 Author: Jonathan Druart Date: Wed Sep 27 16:19:07 2017 -0300 Bug 18342: Enable memcached by default for new installs Note that there is no way to create an install without memcached. As it is now considered as stable, there is no point to not use it. Test plan: Create a new Koha install and make sure memcached is enabled by default Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 0a50dc1ad59b52ae47b5749b984763e8e85d0cb7 Author: Ere Maijala Date: Thu Apr 26 13:08:25 2018 +0000 Bug 20665: Reset MySQL connection time zone in the OAI-PMH Provider TEST PLAN --------- apply unit test patch prove t/db_dependent/OAI/Server.t -- should fail apply this patch prove t/db_dependent/OAI/Server.t -- should pass run koha qa test tools Signed-off-by: Mark Tompsett Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit ebc32f2aae4081c4f0e3e10e5353d65faff77c7a Author: Ere Maijala Date: Thu Apr 26 13:05:51 2018 +0000 Bug 20665: Units tests for testing MySQL connection time zone TEST PLAN --------- apply this test patch prove t/db_dependent/OAI/Server.t -- should fail apply the other patch prove t/db_dependent/OAI/Server.t -- should pass run koha qa test tools Signed-off-by: Mark Tompsett Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/Installer/PerlDependencies.pm | 2 +- C4/Installer/PerlModules.pm | 1 + C4/Members/Attributes.pm | 18 --- Koha.pm | 2 +- Koha/OAI/Server/Repository.pm | 13 +++ Makefile.PL | 2 +- cataloguing/additem.pl | 37 +++--- circ/pendingreserves.pl | 9 +- circ/returns.pl | 2 +- debian/docs/koha-create.xml | 15 --- debian/scripts/koha-create | 27 +---- debian/templates/koha-conf-site.xml.in | 10 +- debian/templates/koha-sites.conf | 4 +- etc/koha-conf.xml | 8 ++ installer/data/mysql/updatedatabase.pl | 11 ++ installer/data/mysql/userpermissions.sql | 1 + koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 11 +- .../intranet-tmpl/prog/en/includes/permissions.inc | 1 + .../intranet-tmpl/prog/en/includes/tools-menu.inc | 3 + .../prog/en/modules/acqui/basketgroup.tt | 4 +- .../prog/en/modules/admin/aqbudgets.tt | 2 +- .../prog/en/modules/circ/pendingreserves.tt | 18 +-- .../prog/en/modules/reports/reports-home.tt | 36 +++--- .../prog/en/modules/tools/access_files.tt | 72 ++++++++++++ .../prog/en/modules/tools/tools-home.tt | 6 + offline_circ/service.pl | 14 ++- rewrite-config.PL | 2 +- t/db_dependent/Members/Attributes.t | 14 +-- t/db_dependent/OAI/Server.t | 24 +++- tools/access_files.pl | 122 ++++++++++++++++++++ tools/letter.pl | 17 +-- 31 files changed, 367 insertions(+), 141 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/tools/access_files.tt mode change 100644 => 100755 members/accountline-details.pl mode change 100644 => 100755 opac/opac-routing-lists.pl create mode 100755 tools/access_files.pl hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 3 19:40:34 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 03 May 2018 17:40:34 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.11.00-1379-g75dc3fb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 75dc3fb0f3291221c3c1b59006ef75d92f4f63c2 (commit) from 150a589e088906e2eed255fe05aa292dfdde5fdc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 75dc3fb0f3291221c3c1b59006ef75d92f4f63c2 Author: Jonathan Druart Date: Thu May 3 14:30:00 2018 -0300 Bug 11317: Add id and class attributes to body This fixes xt/tt_valid.t # Failed test ' tag with id and class attributes' # at xt/tt_valid.t line 91 # Files list: # intranet-tmpl/prog/en/modules/tools/access_files.tt: 8 # Looks like you failed 1 test of 3. [16:44:56] xt/tt_valid.t Dubious, test returned 1 (wstat 256, 0x100) Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/tools/access_files.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 4 14:59:53 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 04 May 2018 12:59:53 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.11.00-1385-g6db7ab6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6db7ab6b93f52358bcbad60b60ad776a2cd68a23 (commit) via 4c36d4beb6f308ddec9b8da667ed23878bdc208d (commit) via be35e4883a5595b08c14364fb5da7c98a251aeb5 (commit) via 32a2528d53c7917a0d680dc54416df3202057a5e (commit) via d2d937fc9bb4bdd886c12964c4a21b324626528b (commit) via 305d3c36cb685fabce3ec4357ed769c25b12eb73 (commit) from 75dc3fb0f3291221c3c1b59006ef75d92f4f63c2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6db7ab6b93f52358bcbad60b60ad776a2cd68a23 Author: Mark Tompsett Date: Mon Mar 26 19:14:44 2018 +0000 Bug 20477: Silence floody noise on fast cataloging TEST PLAN --------- See comment #0 to reproduce. apply this patch restart_all echo | sudo tee /var/log/koha/kohadev/place-error.log restart_all cat /var/log/koha/kohadev/plack-error.log -- just restart information log into staff client again, home -> circulation -> fast cataloging cat /var/log/koha/kohadev/plack-error.log -- just restart information run qa test tools Signed-off-by: Roch D'Amour Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 4c36d4beb6f308ddec9b8da667ed23878bdc208d Author: Jonathan Druart Date: Thu Apr 19 09:54:45 2018 -0300 Bug 20620: Remove warnings in moredetail.pl Since 19995 warnings are displayed in moredetail.pl, we should get rid of them. Test plan: Hit moredetail.pl with different biblionumbers and confirm you do no longer see warnings in logs. Make sure values for rentalcharge, item type, ccode and replacementprice are displayed correctly. Signed-off-by: Bouzid Fergani Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit be35e4883a5595b08c14364fb5da7c98a251aeb5 Author: Mark Tompsett Date: Thu Apr 26 04:31:32 2018 +0000 Bug 20663: Add some POD, so koha test tools don't complain Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 32a2528d53c7917a0d680dc54416df3202057a5e Author: Mark Tompsett Date: Thu Apr 26 04:17:51 2018 +0000 Bug 20663: Remove dead code related to compound reports TEST PLAN --------- git grep "Create Compound Report" -- only one file git grep compound | grep 1 -- this is the only setting of the compound tt variable less koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt -- There is an TT IF statement for compound. -- In that statement it would trigger 'Save Compound' git grep save_compound -- only the template and the guided report perl git grep create_compound -- only triggered by the save code in the guided report perl -- in the export for the C4/Reports/Guided.pm git grep run_compound -- left over in export apply the patch look around and see the pieces are cleaned up. run koha qa test tools Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit d2d937fc9bb4bdd886c12964c4a21b324626528b Author: Katrin Fischer Date: Sun Apr 22 22:00:17 2018 +0000 Bug 19171: Attempt to make "no holds possible" messages less confusing At the moment, when no holds are possible, the OPAC reads something like: Sorry, none of these items can be placed on hold. No items available. This is confusing to the patrons, because the records have items, but they are not showing. The record also may have available items, they are just not permitted to place holds on them. Changes: - Only display the first message, when somoene tried unsuccessfully to place holds on multiple records. - Change first message to: Sorry, none of these titles can be placed on hold. - Change the second message to read: No items available to be placed on hold. - Remove around Sorry for better translatability. To test: - Try to place a hold on single record, where no hold is possible. - Try to place a hold on a single record, where a hold is possible. - Try to place holds on multiple records where no hold is possible. - Try to place holds on multiple records where at least one hold is possible. Verify the screen messages make sense in all cases. Signed-off-by: Owen Leonard Fixed stray during signoff. Signed-off-by: Marcel de Rooy For consistency with staff, I renamed multi_holds to multi_hold. Signed-off-by: Jonathan Druart commit 305d3c36cb685fabce3ec4357ed769c25b12eb73 Author: Jonathan Druart Date: Thu May 3 15:40:11 2018 -0300 Bug 20685: Escape letter template content in textarea Test plan: enter the following text into the Email template for 'HOLD_SLIP' in Home ? Tools ? Notices & Slips ? Modify notice

<>, <>


<> <>
<>
<>, <> <>


Edit it again Without this patch you will get: Signed-off-by: Barton Chittenden Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/Reports/Guided.pm | 38 +++++--------------- catalogue/moredetail.pl | 11 +++--- cataloguing/addbiblio.pl | 6 ++-- .../en/modules/reports/guided_reports_start.tt | 25 ------------- .../intranet-tmpl/prog/en/modules/tools/letter.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 8 ++--- opac/opac-reserve.pl | 4 +++ reports/guided_reports.pl | 16 --------- 8 files changed, 26 insertions(+), 84 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 7 17:35:43 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 07 May 2018 15:35:43 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.11.00-1394-g9a1bed8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 9a1bed84d6ac0ac5b0b9ee631363bc9cb0d74b73 (commit) via affd3f0eceba42ec7c92706452a892823eed39e0 (commit) via 23aa9866124064cbea8d52c1ec8f72089b4e8626 (commit) via f0b88ed328e83877cbb98c5e3904e6b087b5a9ca (commit) via 90d249b39dcc6702074aea7b747807d231d09024 (commit) via ab52b1f3ac03ad4b68ac4ab7fa29e32c5efe39b9 (commit) via 046f1f340132a97a2447a44707bdc1e2ded9a637 (commit) via 1b67f208232bbf7efa1eee35c3b1c28e5baa8199 (commit) via b12d5e7c20f44e12b990eaa2a083202bf8b5d43c (commit) from 6db7ab6b93f52358bcbad60b60ad776a2cd68a23 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9a1bed84d6ac0ac5b0b9ee631363bc9cb0d74b73 Author: Jonathan Druart Date: Mon May 7 12:22:40 2018 -0300 Bug 20531: (follow-up) Set the timestamps to the same value to get a correct order There were 2 places where it was failing! Signed-off-by: Jonathan Druart commit affd3f0eceba42ec7c92706452a892823eed39e0 Author: Mason James Date: Tue May 1 13:24:37 2018 +1200 Bug 20686: OPAC shows 'Login to OverDrive account' with 'OverDriveCirculation' syspref disabled ps: you will need an active and working overdrive account to test this patch 1/ prepare a koha with overdrive sysprefs set and working (OverDriveLibraryID,OverDriveClientKey,OverDriveClientSecret) 2/ set OverDriveCirculation syspref to 'disable' 3/ do an opac search, note the 'Login to OverDrive account' message is incorrectly displayed see pic 1 4/ apply patch 5/ do an opac search, note the 'Login to OverDrive account' message is no longer displayed (good) see pic 2 Can confirm that bug is replicable and patch applies and functions as described. Signed-off-by: Dilan Johnpull? Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 23aa9866124064cbea8d52c1ec8f72089b4e8626 Author: Jonathan Druart Date: Tue Feb 27 13:37:53 2018 -0300 Bug 20305: Remove warnings from tools scripts Signed-off-by: Julian Maurice Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit f0b88ed328e83877cbb98c5e3904e6b087b5a9ca Author: Marcel de Rooy Date: Fri May 4 08:10:46 2018 +0200 Bug 20687: (follow-up) Look for invitekey in show_accept and fix error codes We should check the invitekey in show_accept by passing it along in the search call. On the way I fixed some error checking: if the list number is invalid, or the list is public or you are the owner, or if the key is not found, we should set the right error code; the template contains those messages. Test plan: [1] Share a list and accept a correct invitation with another user. [2] Try to accept some invalid proposals: wrong key, wrong list. Signed-off-by: Marcel de Rooy Tested invalid key, wrong list, owner, public list, expiry. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit 90d249b39dcc6702074aea7b747807d231d09024 Author: Nick Clemens Date: Tue May 1 13:47:18 2018 +0000 Bug 20687: Check all share keys for a given list This patch gets all the shares for a list and iterates through to find the correct one when accepting from a link To test: 1 - Create a private list in the opac 2 - Invite 2 patrons to the list 3 - Try to accept from the patron you first shared to 4 - You will get a failure message about expiration of the link 5 - Apply patch 6 - Now try to accept the first share 7 - It works! Success! Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit ab52b1f3ac03ad4b68ac4ab7fa29e32c5efe39b9 Author: Tomas Cohen Arazi Date: Fri May 4 12:30:55 2018 -0300 Bug 20284: Fix minor compilation errors Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 046f1f340132a97a2447a44707bdc1e2ded9a637 Author: Tomas Cohen Arazi Date: Fri May 4 12:26:39 2018 -0300 Bug 20284: (QA follow-up) superlibrarian has ill permissions Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 1b67f208232bbf7efa1eee35c3b1c28e5baa8199 Author: Andrew Isherwood Date: Fri Apr 20 15:15:15 2018 +0100 Bug 20284: (follow-up) Added missing 'exit's This patch adds the exits that were missing after the redirects Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit b12d5e7c20f44e12b990eaa2a083202bf8b5d43c Author: Andrew Isherwood Date: Mon Apr 9 14:32:21 2018 +0100 Bug 20284: ILLModuleCopyrightClearance text breaks This patch fixes the display of the copyright notice text that is defined in ILLModuleCopyrightClearance preference when placing ILL requests from the OPAC. Handling of the copyrightclearance stage was missing, this has been added. To test: 1) Ensure you have at least one ILL backend available: https://wiki.koha-community.org/wiki/ILL_backends 2) Ensure you have the "ILLModule" preference enabled 3) Add some text to the "ILLModuleCopyrightClearance" preference 4) Navigate to a search results page in the catalog 5) Click the "Make an Interlibrary Loan request" link at the bottom 6) Choose "Create a new request", then select a backend 7) Observe the text you added earlier is displayed with buttons for agreeing or disagreeing (prior to this patch, this screen displayed an error) 8) Observe that clicking "Yes" takes you to the form for adding request details 9) Observe that clicking "No" takes you back to the "Interlibrary loan requests" page Signed-off-by: Barry Cannon Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 1 + .../bootstrap/en/modules/opac-illrequests.tt | 47 +++++++++++++------- .../bootstrap/en/modules/opac-overdrive-search.tt | 2 +- opac/opac-illrequests.pl | 30 ++++++++----- opac/opac-shareshelf.pl | 38 +++++++--------- t/db_dependent/Members/IssueSlip.t | 5 +++ tools/batchMod.pl | 2 +- 7 files changed, 75 insertions(+), 50 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 7 18:27:20 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 07 May 2018 16:27:20 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.11.00-1395-g8bb531b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8bb531b5308635d53345cd04617b47acb076970e (commit) from 9a1bed84d6ac0ac5b0b9ee631363bc9cb0d74b73 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8bb531b5308635d53345cd04617b47acb076970e Author: Jonathan Druart Date: Mon May 7 13:15:34 2018 -0300 Bug 20721: (bug 19403 follow-up) Prevent Circulation.t to fail randomly If items.restricted == 1, CanBookBeIssued will not returned what we are testing. The easiest and global fix is to define a default value at TestBuilder package level Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Circulation.t | 22 ---------------------- t/lib/TestBuilder.pm | 4 ++++ 2 files changed, 4 insertions(+), 22 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 9 16:56:19 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 09 May 2018 14:56:19 +0000 Subject: [koha-commits] main Koha release repository branch 17.05.x updated. v17.05.11-2-g9d44ba8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.05.x has been updated via 9d44ba8b29e645dad3827b78f21567cdc7cd0cdc (commit) from 524ae2ccfa058d605ec8e2f1373ae0ce0e72d4f1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9d44ba8b29e645dad3827b78f21567cdc7cd0cdc Author: Marcel de Rooy Date: Fri Feb 16 12:01:36 2018 +0100 Bug 20227: Check for categorycode in default_borrower_circ_rules Fixes silent crash when adding the same category twice. DBD::mysql::st execute failed: Duplicate entry 'ST' for key 'PRIMARY' [for Statement " INSERT INTO default_borrower_circ_rules (categorycode, maxissueqty, maxonsiteissueqty, max_holds) VALUES (?, ?, ?, ?) " with ParamValues: 0="ST", 1=undef, 2=undef, 3="3"] at /usr/share/koha/devclone/admin/smart-rules.pl line 309. (Line number affected by bug 15524.) Very trivial solution. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit 490f473a7815854893a0b2a38366c95af345a543) Signed-off-by: Fridolin Somers ----------------------------------------------------------------------- Summary of changes: admin/smart-rules.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed May 9 18:06:42 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 09 May 2018 16:06:42 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.11.00-1438-gdc300b6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via dc300b6547355019d9135c2023c444df7a7f3cff (commit) via fe7e0d1e5257f266ea81370553d235164186c245 (commit) via b8acd86231a3b63f311a1c6357acc8096bef06ed (commit) via 17e8acad70c778a1d544ad2cb22e0fc98ba2f312 (commit) via 432dd41418003494c6db24ef0fc9d81f83186ba3 (commit) via 763343a152b1e2a7a0c4fb6f6b8fd685843eb562 (commit) via a8579ac6c4fac0a660b506949bc47fcc7faf7674 (commit) via 5cf8bbfb7aea34b6367dfbbfb9d73f88851507fb (commit) via 997a5705504b63cbaf9ae41f0487f5c1654c686f (commit) via de0698076fee3061d3c37a8a922faf19a69336c8 (commit) via 027aa4f3495a5b1b3fd778470cdcd1c8f623233b (commit) via 0d96a9080dd2625229528adff8f35b9c2b8aebb9 (commit) via c46439abda66bfbf9cd7a987346331f93670062c (commit) via 5bf71bb837239ca9e3fdf4703074caf5eff7ec52 (commit) via 8eb9239a340e662c42f8686a4d29154cc54ec5e4 (commit) via ef7a900742cf8c7bc063cc6df74b922db235b8b6 (commit) via 2a8c3fad0a669870505d5b84b5fbaa7dd1c2a8a8 (commit) via d2454d6868c357ee65dd683d80ab16f2cc2366fc (commit) via 0cb1020e0cdb63143d3d954d4d9ff3a4bd93e330 (commit) via 82edceb2ed583ae9beaa63fd6208b380cc184c28 (commit) via 45841d9ec7d013a6288fc5e543accf58d63f4c9b (commit) via 28a750fb7678f9d7a4a601cc3c0ff828a8b8f8bf (commit) via 45efd8e3ec7fa2e68d29bf97a454f0fd04faa272 (commit) via 175b7730517c738d09c180623a161c3052740213 (commit) via b3f702625436a1b11e7740b6c53e26e68fa4184b (commit) via b67e88f429fb926a9032893f343c05a15e856c37 (commit) via 37efe6ff7643e1bfee201a3e9b3473a82a0d656f (commit) via 9007b25d0920dff1d0f7f976f4de866a7e1f20f0 (commit) via 30b763040cef34f083e66d047e50b5dd20c5ec7c (commit) via 05101f0afa28d1de67d8d313963cb06cc5b3e1e1 (commit) via 3aa102d0c35058bc6f2350d97e3da11815d368f1 (commit) via 462dc01cee6f8edc76c686d36aac66ef90a5aad4 (commit) via d012552ab636b23227990e3992e9dfe34733fcab (commit) via 714e55388921c3663dd65d0347e8b52d0664cc2d (commit) via 99b820653418f8d8ea57ef6e01f45879e783b0f8 (commit) via 3ada1214312d1bd904c7c98778a918a80c104740 (commit) via a5c28cc24b857c050c1fc41e270a601772cc381d (commit) via 5b2aec72a98d770456169f0e01c23e85954493c8 (commit) via 5c7d12e4e0f813fb31a9ebe7b5c6e5aee71c6cfc (commit) via 996b100f1f46f574cc597d4fd2865c1db8e5f4e7 (commit) via ccc034195ee8c3cd7d5e43b0b88cbbf98c865666 (commit) via 43a4b3c22c7a694975032a787c118fc1aeef5411 (commit) via 896bb7ec54d128d829ed34a06a85a64586e53bff (commit) from 8bb531b5308635d53345cd04617b47acb076970e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit dc300b6547355019d9135c2023c444df7a7f3cff Author: Jonathan Druart Date: Wed May 9 12:55:31 2018 -0300 Bug 20073: Update DBIC Schema changes Signed-off-by: Jonathan Druart commit fe7e0d1e5257f266ea81370553d235164186c245 Author: Tomas Cohen Arazi Date: Wed May 9 11:31:34 2018 -0300 Bug 20734: Add warning to the about page if RESTOAuth2ClientCredentials and not Net::OAuth2::AuthorizationServer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart commit b8acd86231a3b63f311a1c6357acc8096bef06ed Author: Jonathan Druart Date: Tue May 8 16:07:03 2018 -0300 Bug 20624: DBRev 17.12.00.044 Signed-off-by: Jonathan Druart commit 17e8acad70c778a1d544ad2cb22e0fc98ba2f312 Author: Tomas Cohen Arazi Date: Tue May 8 14:58:55 2018 -0300 Bug 20624: Net::OAuth2::AuthorizationServer is not a hard dependency While we get packaging sorted, Net::OAuth2::AuthorizationServer is not a hard dependency for Koha and the feature requiring it is disabled by default. This patch: - Makes the dependency optional - Makes the unit tests for the OAuth2 client credentials flow skip if the dependency is not met. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 432dd41418003494c6db24ef0fc9d81f83186ba3 Author: Tomas Cohen Arazi Date: Mon May 7 11:57:59 2018 -0300 Bug 20624: (QA follow-up) Add missing POD in Koha::REST::V1::OAuth Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 763343a152b1e2a7a0c4fb6f6b8fd685843eb562 Author: Tomas Cohen Arazi Date: Thu May 3 15:29:22 2018 -0300 Bug 20624: (QA follow-up) Handle missing deps gracefuly This patch makes the /token endpoint and the authenticate_api_request method behave correctly in the event of missing deps for OAuth2. To test: - Run: $ kshell k$ prove t/db_dependent/api/v1/oauth.t => FAIL: The behaviour is not implemented - Apply this patch - Run: k$ prove t/db_dependent/api/v1/oauth.t => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit a8579ac6c4fac0a660b506949bc47fcc7faf7674 Author: Tomas Cohen Arazi Date: Thu May 3 15:24:56 2018 -0300 Bug 20624: (QA follow-up) Unit tests for missing deps situation This patch tests the situation in which Net::OAuth2::AuthorizationServer is missing. It mocks Module::Load::Conditional::can_load and expects the /token endpoint answers 'Unimplemented grant type' to all requests, and the 'authenticate_api_request' in 'under' exit with unauthorized (403) to requests in which the Authorization header is passed containing a Bearer token, but OAuth2 is not really available. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/api/v1/oauth.t => FAIL: Tests fail because our REST endpoints don't support this behaviour. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit 5cf8bbfb7aea34b6367dfbbfb9d73f88851507fb Author: Tomas Cohen Arazi Date: Wed May 2 15:55:31 2018 -0300 Bug 20624: Make staff client respect RESTOAuth2ClientCredentials This patch makes the staff client UI respect the RESTOAuth2ClientCredentials syspref. To test: - Make sure RESTOAuth2ClientCredentials is "Don't enable" - Go to a patron's detail page => SUCCESS: The 'More' dropdown doesn't show the API keys management link. - Enable RESTOAuth2ClientCredentials - Reload => SUCCESS: The 'More' dropdown shows the API keys management link - Click on the API keys management link => SUCCESS: You can edit the api keys - Disable the syspref - Reload => SUCCESS: You are presented an error 400 page. - Sign off :-D Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit 997a5705504b63cbaf9ae41f0487f5c1654c686f Author: Tomas Cohen Arazi Date: Wed May 2 15:51:38 2018 -0300 Bug 20624: Make /api/v1/oauth/token respect RESTOAuth2ClientCredentials This patch makes the /api/v1/oauth/token enpoint respect the RESTOAuth2ClientCredentials syspref. It will return 400 (with 'Unimplemented grant type' error message) on the event of the syspref being disabled and the grant_type => 'client_credentials' value passed. To test: - Run: $ kshell k$ prove t/db_dependent/api/v1/oauth.t => FAIL: It fails because the off-switch is not implemented - Apply this patch - Run: k$ prove t/db_dependent/api/v1/oauth.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit de0698076fee3061d3c37a8a922faf19a69336c8 Author: Tomas Cohen Arazi Date: Wed May 2 15:21:53 2018 -0300 Bug 20624: Unit tests This patch adds tests to verify that disabling the RESTOAuth2ClientCredentials syspref makes any request on the /api/v1/oauth/token using the 'client_credentials' grant fail with 'grant not implemented'. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/api/v1/oauth.t => FAIL: Tests fail because the change is not implemented! Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit 027aa4f3495a5b1b3fd778470cdcd1c8f623233b Author: Tomas Cohen Arazi Date: Wed May 2 11:20:37 2018 -0300 Bug 20624: Add RESTOAuth2ClientCredentials syspref Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit 0d96a9080dd2625229528adff8f35b9c2b8aebb9 Author: Tomas Cohen Arazi Date: Thu May 3 15:53:16 2018 -0300 Bug 20612: (QA follow-up) Fix typo in method POD As Martin correctly highlighted, the method name is not correctly spelled in POD. This patch fixes it. To test: - Look carefully => FAIL: Method name is _verify_client_cb but POD says _verify_client_db - Apply this patch - Look carefully => SUCCESS: Notice the POD is fixed! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit c46439abda66bfbf9cd7a987346331f93670062c Author: Tomas Cohen Arazi Date: Wed Apr 18 13:40:13 2018 -0300 Bug 20612: koha-conf.xml cleanup Signed-off-by: Julian Maurice Signed-off-by: Benjamin Rokseth Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit 5bf71bb837239ca9e3fdf4703074caf5eff7ec52 Author: Tomas Cohen Arazi Date: Wed Apr 18 13:34:18 2018 -0300 Bug 20612: Make OAuth2 use patron's client_id/secret pairs This patch wires the OAuth related code so it leverages on the new Koha::ApiKey(s) classes and tools introduced by bug 20568 instead of the hardcoded entries in koha-conf.xml originally proposed by bug 20402. To test revisit the test plan for bug 20402, and verify that it works. But create API key pairs instead of writing them down in koha-conf.xml. Also: - Run: $ prove t/db_dependent/api/v1/oauth.t => SUCCESS: Tests pass! - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Julian Maurice Signed-off-by: Benjamin Rokseth Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit 8eb9239a340e662c42f8686a4d29154cc54ec5e4 Author: Tomas Cohen Arazi Date: Wed Apr 18 13:32:34 2018 -0300 Bug 20612: Unit tests This patch makes the oauth.t tests leverage on the new Koha::ApiKey(s) classes. It adds tests for expired tokens too. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/api/v1/oauth.t => FAIL: Tests should fail without the rest of the patches. Sponsored-by: ByWater Solutions Signed-off-by: Julian Maurice Signed-off-by: Benjamin Rokseth Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit ef7a900742cf8c7bc063cc6df74b922db235b8b6 Author: Jonathan Druart Date: Tue May 8 16:06:22 2018 -0300 Bug 20568: DBRev 17.12.00.043 Signed-off-by: Jonathan Druart commit 2a8c3fad0a669870505d5b84b5fbaa7dd1c2a8a8 Author: Jonathan Druart Date: Tue May 8 16:27:54 2018 -0300 Bug 20568: fix shebang Signed-off-by: Jonathan Druart commit d2454d6868c357ee65dd683d80ab16f2cc2366fc Author: Jonathan Druart Date: Tue May 8 16:15:54 2018 -0300 Bug 20568: Fix bad resolution conflict with bug 18403 borrowers module permission has now several subpermissions Signed-off-by: Jonathan Druart commit 0cb1020e0cdb63143d3d954d4d9ff3a4bd93e330 Author: Tomas Cohen Arazi Date: Thu May 3 15:51:15 2018 -0300 Bug 20568: (QA follow-up) Remove unused vars Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 82edceb2ed583ae9beaa63fd6208b380cc184c28 Author: Tomas Cohen Arazi Date: Wed May 2 11:05:05 2018 -0300 Bug 20568: (QA follow-up) Remove api-key management from OPAC Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 45841d9ec7d013a6288fc5e543accf58d63f4c9b Author: Tomas Cohen Arazi Date: Wed Apr 18 14:38:02 2018 -0300 Bug 20568: CSRF protection Edit: fix warning introduced by this patch Signed-off-by: Tomas Cohen Arazi Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit 28a750fb7678f9d7a4a601cc3c0ff828a8b8f8bf Author: Tomas Cohen Arazi Date: Sat Apr 14 14:50:23 2018 -0300 Bug 20568: (QA follow-up) Get rid of the id column Signed-off-by: Tomas Cohen Arazi Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit 45efd8e3ec7fa2e68d29bf97a454f0fd04faa272 Author: Tomas Cohen Arazi Date: Wed Apr 18 13:56:28 2018 -0300 Bug 20568: (QA follow-up) Make sure client_id and secret are not overwritten on store Signed-off-by: Tomas Cohen Arazi Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit 175b7730517c738d09c180623a161c3052740213 Author: Tomas Cohen Arazi Date: Wed Apr 18 13:56:00 2018 -0300 Bug 20568: (QA follow-up) Test client_id and secret are not overwritten Signed-off-by: Tomas Cohen Arazi Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit b3f702625436a1b11e7740b6c53e26e68fa4184b Author: Tomas Cohen Arazi Date: Wed Apr 18 10:55:43 2018 -0300 Bug 20568: (follow-up) Atomic update fix Signed-off-by: Tomas Cohen Arazi Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit b67e88f429fb926a9032893f343c05a15e856c37 Author: Tomas Cohen Arazi Date: Mon Apr 16 16:04:26 2018 -0300 Bug 20568: Move value => client_id + secret This patch addresses the request from Julian that api keys are expected to be client id/secret pairs. It does so by - Adding 'client_id' and 'secret' columns - Removing 'value' Tests got adjusted and so controller scripts and templates. Both libs and tests changes have been squashed. This ones remain in order to keep Owen's attribution on the template changes and avoid rebase conflicts. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit 37efe6ff7643e1bfee201a3e9b3473a82a0d656f Author: Owen Leonard Date: Mon Apr 16 15:23:50 2018 +0000 Bug 20568: (follow-up) Interface and markup changes This patch makes some interface changes to bring things better in line with existing interface patterns. This patch also re-indents the modified templates with 4 spaces instead of 2 and makes s self-closing. Also changed: Corrected system preference check in opac-apikeys.pl. To test, apply the patch and: In the staff client: - Open a patron record and choose More -> Manage API keys. - There should be a standard message dialog containing a link to "Generate a new key." - Clicking the link should show the form for adding a new key. - Test that clicking the "Cancel" link hides the form. - Test that creating the new key works correctly. - You should now see a table showing existing keys and a "Generate a new key" button above it. - Test that the "Delete" button asks for confirmation, and that confirming and denying both work correctly. - Test that "Revoke" and "Activate" actions still work correctly. In the OPAC: - Set the AllowPatronsManageAPIKeysInOPAC system preference to "Allow." - Log in to the OPAC and click the "your API keys" link in the sidebar. - Clicking the "Generate new key" button should display the form for adding a new key. - Clicking the "cancel" link should hide the form. - Submitting the form should add a new key. - You should now see a table showing existing keys. - Test that the "Delete" link asks for confirmation, and that confirming and denying both work correctly. - Test that "Revoke" and "Activate" actions still work correctly. - Set the AllowPatronsManageAPIKeysInOPAC system preference to "Don't allow." - Log in to the OPAC and confirm that the "your API keys" link in the sidebar is no longer visible. - Confirm that navigating directly to /cgi-bin/koha/opac-apikeys.pl results in a 404 error. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit 9007b25d0920dff1d0f7f976f4de866a7e1f20f0 Author: Tomas Cohen Arazi Date: Sat Apr 14 17:38:03 2018 -0300 Bug 20568: API key management for OPAC users This patch makes the OPAC interface for API keys management work with the new lib. Verify all actions work for a logged user. Users without login should be redirected to an error page. The AllowPatronsManageAPIKeysInOPAC syspref is added to control if the OPAC feature is enabled or not. To test: - Verify the syspref works - Verify users can manage their API keys Signed-off-by: Kyle M Hall Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit 30b763040cef34f083e66d047e50b5dd20c5ec7c Author: Tomas Cohen Arazi Date: Sat Apr 14 17:37:56 2018 -0300 Bug 20568: Unit tests This patch adds unit tests for the introduced classes: Koha::ApiKey(s). To test: - Apply this patch - Run $ kshell k$ prove t/db_dependent/Koha/ApiKeys.t => FAIL: Tests fail because the feature is not implemented. Signed-off-by: Kyle M Hall Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit 05101f0afa28d1de67d8d313963cb06cc5b3e1e1 Author: Tomas Cohen Arazi Date: Thu Apr 12 14:38:47 2018 -0300 Bug 20568: Add mandatory description field for api keys This patch changes the table structure adding fields usually found on this kind of api management pages. Signed-off-by: Kyle M Hall Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit 3aa102d0c35058bc6f2350d97e3da11815d368f1 Author: Julian Maurice Date: Mon Mar 23 20:14:23 2015 +0100 Bug 20568: API keys management in interface This introduces the concept of API keys for use in the new REST API. A key is a string of 32 alphanumerical characters (32 is purely arbitrary, it can be changed easily). A user can have multiple keys (unlimited at the moment) Keys can be generated automatically, and then we have the possibility to delete or revoke each one individually. Test plan: 1/ Go to staff interface 2/ Go to a borrower page 3/ In toolbar, click on More -> Manage API keys 4/ Click on "Generate new key" multiple times, check that they are correctly displayed under the button, and they are active by default 5/ Revoke some keys, check that they are not active anymore 6/ Delete some keys, check that they disappear from table 7/ Go to opac interface, log in 8/ In your user account pages, you now have a new tab to the left "your API keys". Click on it. 9/ Repeat steps 4-6 Signed-off-by: Kyle M Hall Signed-off-by: Julian Maurice Signed-off-by: Jonathan Druart commit 462dc01cee6f8edc76c686d36aac66ef90a5aad4 Author: Jonathan Druart Date: Wed May 9 12:54:57 2018 -0300 Bug 20402: Update DBIX schema Signed-off-by: Jonathan Druart commit d012552ab636b23227990e3992e9dfe34733fcab Author: Jonathan Druart Date: Tue May 8 16:05:04 2018 -0300 Bug 20402: DBRev 17.12.00.042 Signed-off-by: Jonathan Druart commit 714e55388921c3663dd65d0347e8b52d0664cc2d Author: Jonathan Druart Date: Tue May 8 16:44:42 2018 -0300 Bug 20402: only output if verbose flag is set Signed-off-by: Jonathan Druart commit 99b820653418f8d8ea57ef6e01f45879e783b0f8 Author: Julian Maurice Date: Fri Apr 20 10:37:37 2018 +0200 Bug 20402: Remove useless call to Koha::OAuthAccessTokens->search Signed-off-by: Jonathan Druart commit 3ada1214312d1bd904c7c98778a918a80c104740 Author: Tomas Cohen Arazi Date: Tue Apr 17 16:23:56 2018 -0300 Bug 20402: Add missing POD Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit a5c28cc24b857c050c1fc41e270a601772cc381d Author: Tomas Cohen Arazi Date: Tue Apr 17 16:23:36 2018 -0300 Bug 20402: Atomic update and kohastructure.sql fixes Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 5b2aec72a98d770456169f0e01c23e85954493c8 Author: Julian Maurice Date: Tue Apr 17 19:07:47 2018 +0200 Bug 20402: Use TestBuilder->build_object in oauth.t Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 5c7d12e4e0f813fb31a9ebe7b5c6e5aee71c6cfc Author: Julian Maurice Date: Tue Apr 17 19:07:01 2018 +0200 Bug 20402: Remove dependency on Mojo::Plugin::OAuth2::Server Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 996b100f1f46f574cc597d4fd2865c1db8e5f4e7 Author: Julian Maurice Date: Thu Apr 12 14:48:58 2018 +0200 Bug 20402: Don't look at cookies if OAuth2 is attempted and has failed Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit ccc034195ee8c3cd7d5e43b0b88cbbf98c865666 Author: Julian Maurice Date: Thu Apr 12 09:17:43 2018 +0200 Bug 20402: Fix oauth.t GET /patrons now requires { "borrowers": 1 } instead of { "borrowers": "edit_borrowers" } Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 43a4b3c22c7a694975032a787c118fc1aeef5411 Author: Julian Maurice Date: Tue Mar 13 13:17:12 2018 +0100 Bug 20402: Implement OAuth2 authentication for REST API It implements only the "client credentials" flow with no scopes support. API clients are tied to an existing patron and have the same permissions as the patron they are tied to. API Clients are defined in $KOHA_CONF. Test plan: 0. Install Net::OAuth2::AuthorizationServer 0.16 1. In $KOHA_CONF, add an element under : $CLIENT_ID $CLIENT_SECRET X 2. Apply patch, run updatedatabase.pl and reload starman 3. Install Firefox extension RESTer [1] 4. In RESTer, go to "Authorization" tab and create a new OAuth2 configuration: - OAuth flow: Client credentials - Access Token Request Method: POST - Access Token Request Endpoint: http://$KOHA_URL/api/v1/oauth/token - Access Token Request Client Authentication: Credentials in request body - Client ID: $CLIENT_ID - Client Secret: $CLIENT_SECRET 5. Click on the newly created configuration to generate a new token (which will be valid only for an hour) 6. In RESTer, set HTTP method to GET and url to http://$KOHA_URL/api/v1/patrons then click on SEND If patron X has permission 'borrowers', it should return 200 OK with the list of patrons Otherwise it should return 403 with the list of required permissions (Please test both cases) 7. Wait an hour (or run the following SQL query: UPDATE oauth_access_tokens SET expires = 0) and repeat step 6. You should have a 403 Forbidden status, and the token must have been removed from the database. 8. Create a bunch of tokens using RESTer, make some of them expires using the previous SQL query, and run the following command: misc/cronjobs/cleanup_database.pl --oauth-tokens Verify that expired tokens were removed, and that the others are still there 9. prove t/db_dependent/api/v1/oauth.t [1] https://addons.mozilla.org/en-US/firefox/addon/rester/ Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 896bb7ec54d128d829ed34a06a85a64586e53bff Author: Tomas Cohen Arazi Date: Thu Apr 5 11:07:30 2018 -0300 Bug 20525: Add --timezone switch to koha-create This patch adds a --timezone switch to koha-create so the timezone can be set on creation time. It defaults to empty (i.e. using the server's local time). To test: - Create an instance: $ sudo koha-create --create-db timezone1 => SUCCESS: /etc/koha/sites/timezone1/koha-conf.xml contains an empty entry. - Apply this patch - Run: $ perl misc4dev/cp_debian_files.pl - Create a new instance: $ sudo koha-create --create-db timezone2 => SUCCESS: /etc/koha/sites/timezone2/koha-conf.xml contains an empty entry (i.e. the current behaviour is preserved). - Create a new instance: $ sudo koha-create --create-db --timezone Your/Timezone timezone3 => SUCCESS: /etc/koha/sites/timezone3/koha-conf.xml contains Your/Timezone (i.e. introduced behaviour works) - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/Installer/PerlDependencies.pm | 5 + Koha.pm | 2 +- Koha/ApiKey.pm | 95 ++++++++++++ Koha/{CsvProfiles.pm => ApiKeys.pm} | 19 ++- Koha/OAuth.pm | 121 +++++++++++++++ Koha/{Acquisition/Fund.pm => OAuthAccessToken.pm} | 8 +- Koha/{Authority/Tags.pm => OAuthAccessTokens.pm} | 18 +-- Koha/REST/V1/Auth.pm | 55 +++++++ Koha/REST/V1/OAuth.pm | 96 ++++++++++++ Koha/Schema/Result/ApiKey.pm | 123 +++++++++++++++ Koha/Schema/Result/Borrower.pm | 19 ++- Koha/Schema/Result/OauthAccessToken.pm | 72 +++++++++ Koha/Schema/Result/SearchField.pm | 10 +- about.pl | 8 + api/v1/swagger/paths.json | 3 + api/v1/swagger/paths/oauth.json | 64 ++++++++ debian/docs/koha-create.xml | 8 + debian/scripts/koha-create | 13 +- debian/templates/koha-conf-site.xml.in | 2 +- installer/data/mysql/kohastructure.sql | 32 ++++ installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 57 +++++++ .../prog/en/includes/members-toolbar.inc | 10 ++ koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 9 +- .../en/modules/admin/preferences/web_services.pref | 8 +- .../prog/en/modules/members/apikeys.tt | 111 +++++++++++++ .../opac-tmpl/bootstrap/en/includes/usermenu.inc | 2 + members/apikeys.pl | 124 +++++++++++++++ misc/cronjobs/cleanup_database.pl | 11 ++ t/db_dependent/Koha/ApiKeys.t | 90 +++++++++++ t/db_dependent/api/v1/oauth.t | 164 ++++++++++++++++++++ 31 files changed, 1326 insertions(+), 34 deletions(-) create mode 100644 Koha/ApiKey.pm copy Koha/{CsvProfiles.pm => ApiKeys.pm} (80%) create mode 100644 Koha/OAuth.pm copy Koha/{Acquisition/Fund.pm => OAuthAccessToken.pm} (87%) copy Koha/{Authority/Tags.pm => OAuthAccessTokens.pm} (78%) create mode 100644 Koha/REST/V1/OAuth.pm create mode 100644 Koha/Schema/Result/ApiKey.pm create mode 100644 Koha/Schema/Result/OauthAccessToken.pm create mode 100644 api/v1/swagger/paths/oauth.json create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/members/apikeys.tt create mode 100755 members/apikeys.pl create mode 100755 t/db_dependent/Koha/ApiKeys.t create mode 100755 t/db_dependent/api/v1/oauth.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu May 10 19:53:19 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 10 May 2018 17:53:19 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.11.00-1439-gd2ea81e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via d2ea81e6529768ec4e85afb46cf2e3b7255f9a2e (commit) from dc300b6547355019d9135c2023c444df7a7f3cff (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d2ea81e6529768ec4e85afb46cf2e3b7255f9a2e Author: Jonathan Druart Date: Thu May 10 14:41:45 2018 -0300 Bug 18789: Fix borrowernumber on members/files.tt Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/members/files.tt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 11 16:22:26 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 11 May 2018 14:22:26 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.11.00-1457-g54944bd Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 54944bd10299d8af3c698d50ac75839af45fa300 (commit) via 935af3eab537244d9fbb70207ee41d7874591fdd (commit) via 8f3f232175183e117931bb6895cbc2d3dbf64534 (commit) via 1edd7f8265b5e51f3e651c207ee8c3301273891f (commit) via 5347537f1ab216dd283a5c85604b28d6f2d5c21c (commit) via 1bc3bbfdc78bfd559fec841c6ca47ddcbeb0f179 (commit) via 3811985c3a55b72900ba005c6867059776ee9281 (commit) via 4200ffb720f1864a6ee02c071dc5aa09ee258f42 (commit) via 9fce2434666505460030db1df3869c87c1ef83a7 (commit) via 3b47ed3f9076f76ce476da7314c08841ce5252d1 (commit) via 5a7976e34f12dfa2eb1ddc7d39db2271aa5f2e26 (commit) via f55f4e090b3d961abe0206fc1ed01335d0e6f909 (commit) via 6ea48ca9345862fc655e0ef418ea91d040ead03a (commit) via e3fd46d3dd7e87e2857437f45b9bdaae990c5fd1 (commit) via f0f66431758d1d051f8e6d165df027745c2a8f66 (commit) via 837fa4e6f7010b2ce94bff36fd9ceaf94de93a18 (commit) via ee82d441c2d84a506e553cf8e1e95984bae85204 (commit) via 94fd62dac9b8c0bcb3127c4eef91781984c55f7b (commit) from d2ea81e6529768ec4e85afb46cf2e3b7255f9a2e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 54944bd10299d8af3c698d50ac75839af45fa300 Author: Jonathan Druart Date: Wed Apr 18 15:11:47 2018 -0300 Bug 7910: Give feedack when the subscriptions have been renewed This patch adds a message to the user to let them know the subscription have been renewed successfully. Signed-off-by: S?verine QUEUNE Signed-off-by: Jonathan Druart commit 935af3eab537244d9fbb70207ee41d7874591fdd Author: Jonathan Druart Date: Fri Jan 5 13:29:06 2018 -0300 Bug 19792: Few minor fixes - No string extrapolation needed on SQL queries - '== undef' must be written 'if not defined' Signed-off-by: Jon Knight Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 8f3f232175183e117931bb6895cbc2d3dbf64534 Author: Marcel de Rooy Date: Wed Dec 27 17:04:36 2017 +0100 Bug 19792: (QA follow-up) Move anonymous sub out of GetHierarchy Test plan: Run t/db_dependent/Budgets.t. Without both patches, running the test is slower than with only the first or both patches. Signed-off-by: Marcel de Rooy Signed-off-by: Jon Knight Signed-off-by: Jonathan Druart commit 1edd7f8265b5e51f3e651c207ee8c3301273891f Author: David Bourgault Date: Mon Dec 11 11:56:27 2017 -0500 Bug 19792: Performance boost for GetBudgetHierarchy This patches reduces the number of SQL calls by combining multiple calls to the recursive functions GetBudgetSpent(), GetBudgetOrdered(), etc. into 4 big queries. It also removes duplicate function calls from acqui-home.pl Test plan: 0) Visit Acquisition home 0) Apply patch 1) Refresh page. It shoud look identical. 2) prove t/db_dependent/budgets.t Signed-off-by: Jon Knight Signed-off-by: Marcel de Rooy Signed-off-by: Jon Knight Signed-off-by: Jonathan Druart commit 5347537f1ab216dd283a5c85604b28d6f2d5c21c Author: Jonathan Druart Date: Fri Dec 22 14:52:26 2017 -0300 Bug 19579: Do not confirm the registration if email already used - PatronSelfRegistrationEmailMustBeUnique If PatronSelfRegistrationVerifyByEmail and PatronSelfRegistrationEmailMustBeUnique are set, it should not be possible to register twice with the same email. However the test is made on already created patron cards when the registration is done. Which means it is possible to register several times with the same email address and click on the registration link to finalise the registration. This patch adds a test when the registration link is clicked and display the "Registration invalid" generic message if the same email is used Test plan: 1. Patron submits self registration form using the same email address 3 times 2. Patron receives 3 verification emails 3. Patron clicks on 3 verify token URLs => Only the first registration should succeed, the 2 others must fail Maybe we should display a more specific message? Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 1bc3bbfdc78bfd559fec841c6ca47ddcbeb0f179 Author: Marcel de Rooy Date: Fri May 11 11:33:32 2018 +0200 Bug 20623: (QA follow-up) Remove one find call Imo these somewhat weird lines ask for improvement, but I don't want to change the exact conditions here. Just removing the need to call find twice. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 3811985c3a55b72900ba005c6867059776ee9281 Author: Victor Grousset Date: Fri Apr 20 11:17:26 2018 +0200 Bug 20623: Fix basket group PDF when itemtype not itemtype table When an item has an itemtype not in the itemtype table. Trying to fetch it's description lead to an error. Using authorized values like ccode to populate the itemtypes of the biblioitems (instead of the itemtype table) can lead to such data. Or importing records with invalid itemtype codes. Koha doesn't do enough checks at import to at least warn about these issues. == Test plan == 1. first we need an item with an itype not in the item_types table 1. download a record as MARCXML 2. find it's item type in administration; and the related code 3. open the MARCXML file and search for occurences of the code and replace them by some non-existing value like "FOOBAR" 4. also change the barcode so it won't be ignored because it's a duplicate 5. also change the title to easily find it later in the search 6. tools ? "Stage MARC records for import" 7. upload your file 8. "stage for import" 9. click "Manage staged records" You should end on the page related to your staged record 10. "Import this batch into the catalog" 2. now we need it in a basket group 1. have/create a active budget 2. have/create a fund 3. have/create a vendor with minimal info 4. create a basket with minimal info 5. add our imported item to the basket for example search it by name 6. go to the basket. URL should be /cgi-bin/koha/acqui/basket.pl?basketno=XXXXX 7. close this basket and tick "Attach this basket to a new basket group with the same name" 8. you will end up in the basket groups lists 9. go to the "closed" tab 11. go to the basket group your vendor page => Basket groups => Closed 3. export as PDF, it should fail (internal server error) this is the bug (no kidding ^_^) 4. apply this patch 5. reexport the basket as PDF 6. it should work 7. create an item type (in administration) that has the same code as the one that you put in the MARCXML 8. reexport the basket as PDF 9. check that in the PDF that the description is here: table at the bottom of the document ? "Document" column Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 4200ffb720f1864a6ee02c071dc5aa09ee258f42 Author: Jonathan Druart Date: Mon May 7 15:04:33 2018 -0300 Bug 20722: Display search results when searching only by ITEMTYPECAT - Create an entry for the ITEMTYPECAT authorised value category. Make sure to fill in the OPAC description. - Go to administration > itemtypes and add the new category to 2 item types. - Go to the OPAC and check that the advanced search shows your new itemtype group instead of the individual itemtypes. - Check the checkbox and Search. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 9fce2434666505460030db1df3869c87c1ef83a7 Author: Marcel de Rooy Date: Wed May 2 14:50:32 2018 +0200 Bug 20695: Fix multiple upload result in tools/upload script Instead of calling UploadedFiles->find only once with $id, we should extract all comma separated id's from the parameter. Test plan: [1] Before this patch, upload two files at once in Tools/Upload. After doing so, you should see only one result reported. But both files should have been uploaded. [2] With this patch, repeat step 1 and see two upload results. Signed-off-by: Marcel de Rooy Patch applies and functions as described. Signed-off-by: Dilan Johnpull? Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 3b47ed3f9076f76ce476da7314c08841ce5252d1 Author: Mark Tompsett Date: Mon May 7 18:14:22 2018 +0000 Bug 20719: USE Branches in TT files TEST PLAN --------- In the staff client on a kohadevbox: 1) Enable the HouseboundModule system preference. 2) Enable the EnableBorrowerFiles system preference. 3) Go to a patron detail page. -- note the Home library is shown. 4) Go to Fines tab (left pane) -- Home library is still shown. 5) Click each of the four horizontal tabs (Account, Pay fines, Create manual invoice, Create manual credit) -- Home library not visible for both create tabs and the account tab 6) Click the 'Create manual invoice' tab, and create some kind of entry. 7) On the 'Account' tab, the table has a 'Details' button. Click that. -- Home library not visible. 8) Click the 'Details' tab in the left pane. 9) Click 'More' button and choose 'Delete' -- Home library not visible when asked for delete confirmation. 10) Cancel that, and if you know how to actually set up the Norwegian system preferences you can figure out how to test the nl-search change. After seeing all these not visible, apply this patch. Repeat all the steps, but this time the Home library should be visible. Works OK. Signed-off-by: Amit Gupta Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 5a7976e34f12dfa2eb1ddc7d39db2271aa5f2e26 Author: Amit Gupta Date: Mon May 7 17:48:57 2018 +0530 Bug 20719: Add missing USE Branches to files.tt Test On a kohadevbox: 0. Enable the EnableBorrowerFiles system preference 1. Go to any patron, and click on the 'Files' tab in the left pane. -- the Home library is not displayed. 2. Apply the patch, restart_all, and reload the page. -- the Home library is now displayed. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit f55f4e090b3d961abe0206fc1ed01335d0e6f909 Author: Jonathan Druart Date: Fri Jan 19 09:34:20 2018 -0300 Bug 20746: Move it-IT files to optional Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit 6ea48ca9345862fc655e0ef418ea91d040ead03a Author: Tomas Cohen Arazi Date: Thu May 10 12:37:53 2018 -0300 Bug 20745: koha-zebra doesn't return the correct error codes This patch makes koha-zebra return 0 (or 1) even when verbose mode is off. This made koha-zebra --start always return a failure even when the daemon was correctly launched. To test: - Have Zebra running for kohadev instance on your KohaDevBox - Run: $ sudo koha-zebra --stop kohadev && echo yay || echo doh => FAIL: 'doh' is printed - Run: $ sudo koha-zebra --start kohadev e&& echo yay || echo doh => FAIL: 'doh' is printed as well - Apply this patch - Run: $ sudo perl misc4dev/cp_debian_files.pl $ sudo koha-zebra --stop kohadev && echo yay || echo doh => SUCCESS: 'yay' is printed - Run: $ sudo koha-zebra --start kohadev e&& echo yay || echo doh => SUCCESS: 'yay' is printed - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart commit e3fd46d3dd7e87e2857437f45b9bdaae990c5fd1 Author: Jonathan Druart Date: Wed Apr 25 16:08:25 2018 -0300 Bug 19181: Add new tests This patch reuses the method newly added to Selenium.pm and improve existing tests. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit f0f66431758d1d051f8e6d165df027745c2a8f66 Author: Mark Tompsett Date: Mon Oct 30 03:28:20 2017 +0000 Bug 19181: Change to use ENV, fix login and passwords The kohadevbox has admin/admin set, so for testing when creating the initial superuser, if you wish to minimize effort, use admin/admin. Otherwise, make sure to: export KOHA_USER={whatever your user is} export KOHA_PASS={whatever your password is} before attempting to run the test. Also, this test was failing because of a validation check on the passwords requiring uppercase letters, lowercase letters, and numbers. Changed the sample data passwords to fix. Signed-off-by: Mark Tompsett Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit 837fa4e6f7010b2ce94bff36fd9ceaf94de93a18 Author: Alex Buckley Date: Thu Jul 20 10:50:49 2017 +0000 Bug 19181: Selenium test for logging into the Koha intranet and OPAC This selenium test goes through the process of creating a category and patron user (as is completed in the basic_workflow.t test) then the superlibrarian used to create them is logged out and the newly created patron user authenticates into the OPAC and staff intranet therefore testing the authenitcation of both. Test plan (this test plan includes how to install Selenium as well as how to run this test, for the benefit of people who have not got Selenium installed on their machines): 1. wget https://selenium-release.storage.googleapis.com/2.53/selenium-server-standalone-2.53.0.jar 2. vim /etc/apt/sources.list.d/firefox.list 3. Paste into the file: deb http://packages.linuxmint.com debian import 4. sudo apt-get update 5. sudo apt-get install firefox 6. sudo apt-get install xvfb 7. Set the SELENIUM_PATH vartiable: SELENIUM_PATH=/home/vagrant/kohaclone/selenium-server-standalone-2.53.0.jar 8. Xvfb :1 -screen 0 1024x768x24 2>&1 >/dev/null & 9. DISPLAY=:1 java -jar $SELENIUM_PATH Note: This will start up the selenium server. Everytime you want to shut down this terminal window and want to restart Selenium just run the step 9 command to restart the Selenium server 10. Open a new terminal window and write in: git clone https://github.com/gempesaw/Selenium-Remote-Driver --branch build/master --single-branch --depth 1 11. cd Selenium-Remote-Driver 12. perl Makefile.PL 13. make 14. make test 15. sudo make install 16. Now everything is installed and you can et up for running the selenium tests 17. Create a superlibrarian user with the username koha and password koha 18. If your usual port configuration for the intranet and OPAC is 8081 and 8080 respectively then set the staffClientBaseURL and OPACBaseURL system preferences to localhost:8080 and localhost:80 respectively 19. sudo koha-shell 20. perl t/db_dependent/selenium/authenticate.t 21. The test should pass. Note: The time_diff comments in the test output showing what the test is doing Note: If you have issues with installing Selenium and Selenium::Remote::Driver please write a comment on the bug report and I will be more than happy to create a screencapture video showing all the steps Sponsored-By: Catalyst IT https://bugs.koha-community.org/show_bug.cgi?id=19181 Signed-off-by: Mark Tompsett Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart commit ee82d441c2d84a506e553cf8e1e95984bae85204 Author: Marcel de Rooy Date: Fri May 4 09:54:30 2018 +0200 Bug 11943: Add unit test for double accepts Test plan: Run t/db_dependent/Virtualshelves.t Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart commit 94fd62dac9b8c0bcb3127c4eef91781984c55f7b Author: Marcel de Rooy Date: Fri May 4 09:34:02 2018 +0200 Bug 11943: Prevent double accepts in Koha::Virtualshelfshare This 'bug' existed long enough now to finally remove it ;) We do so by deleting the invitation if the borrower already has a share on this list. Actually not that hard. We still need: a unit test and a db revision. Test plan: [1] Share a list. Let user B accept. [2] Without this patch: Share again and let B accept again. [3] Verify that you have two shares for this list in virtualshelfshares. [4] With this patch: Share another list, let B accept. [5] Share this other list again, let B accept again. [6] Verify that virtualshelfshares does not contain double entries now. (Note: This pertains to the second list only.) Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/Budgets.pm | 65 +++++++++- Koha/Virtualshelfshare.pm | 18 ++- acqui/acqui-home.pl | 3 - acqui/basketgroup.pl | 4 +- debian/scripts/koha-zebra | 22 ++-- .../{necessari => optional}/patron_categories.sql | 0 .../{necessari => optional}/patron_categories.txt | 0 .../{necessari => optional}/sample_holidays.sql | 0 .../{necessari => optional}/sample_holidays.txt | 0 .../{necessari => optional}/sample_itemtypes.sql | 0 .../{necessari => optional}/sample_itemtypes.txt | 0 .../it-IT/{necessari => optional}/sample_news.sql | 0 .../it-IT/{necessari => optional}/sample_news.txt | 0 .../prog/en/modules/members/accountline-details.tt | 1 + .../prog/en/modules/members/boraccount.tt | 1 + .../prog/en/modules/members/deletemem.tt | 1 + .../intranet-tmpl/prog/en/modules/members/files.tt | 1 + .../prog/en/modules/members/housebound.tt | 1 + .../prog/en/modules/members/mancredit.tt | 1 + .../prog/en/modules/members/maninvoice.tt | 1 + .../prog/en/modules/members/nl-search.tt | 1 + .../prog/en/modules/serials/checkexpiration.tt | 9 +- .../prog/en/modules/serials/subscription-renew.tt | 29 +++-- opac/opac-registration-verify.pl | 10 +- opac/opac-search.pl | 2 +- t/db_dependent/Virtualshelves.t | 10 +- t/db_dependent/selenium/authentication.t | 131 ++++++++++++++++++++ t/lib/Selenium.pm | 17 ++- tools/upload.pl | 12 +- 29 files changed, 296 insertions(+), 44 deletions(-) rename installer/data/mysql/it-IT/{necessari => optional}/patron_categories.sql (100%) rename installer/data/mysql/it-IT/{necessari => optional}/patron_categories.txt (100%) rename installer/data/mysql/it-IT/{necessari => optional}/sample_holidays.sql (100%) rename installer/data/mysql/it-IT/{necessari => optional}/sample_holidays.txt (100%) rename installer/data/mysql/it-IT/{necessari => optional}/sample_itemtypes.sql (100%) rename installer/data/mysql/it-IT/{necessari => optional}/sample_itemtypes.txt (100%) rename installer/data/mysql/it-IT/{necessari => optional}/sample_news.sql (100%) rename installer/data/mysql/it-IT/{necessari => optional}/sample_news.txt (100%) create mode 100644 t/db_dependent/selenium/authentication.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 11 19:22:26 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 11 May 2018 17:22:26 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.11.00-1460-g35d887f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 35d887fece0634eb92d030b959aeb991f10a0239 (commit) via d8a3fae361223c39244d8abde368d0877cf24652 (commit) via 92e318dfc5d26bd3c9c0e9963f4eca3b45677f47 (commit) from 54944bd10299d8af3c698d50ac75839af45fa300 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 35d887fece0634eb92d030b959aeb991f10a0239 Author: Victor Grousset Date: Fri May 11 17:43:33 2018 +0200 Bug 20623: (QA follow-up) avoid fetch() calls in some cases Signed-off-by: Jonathan Druart commit d8a3fae361223c39244d8abde368d0877cf24652 Author: Nick Clemens Date: Wed May 9 11:51:20 2018 +0000 Bug 20737: Use https for baker and taylor cover images Easy change, should be able to verify with code review or testing with dummy values To test: 1 - Put some values in baker and taylor prefs (don't need to be valid) 2 - Do a search on the opac (and have some items with isbns) 3 - Inspect the cover images links to ensure they are formed correctly 4 - prove -v t/External/BakerTaylor.t Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 92e318dfc5d26bd3c9c0e9963f4eca3b45677f47 Author: Nick Clemens Date: Fri May 4 13:54:49 2018 +0000 Bug 20707: Replace circ/search.pl circulate permission requirement with catalogue To test: 1 - Setup a staff patron with permissions: - catalogue - reserveforothers - course_reserves 2 - Log in to staff client as that patron 3 - Find a record and click to place a hold 4 - Type more than three letters into the search bar but don't submit 5 - Note that you will not receive autocomplete results 6 - Either submit, or try to visit any page in staff client 7 - Your session has been expired, you must log in again 8 - Log in, go to course reserves 9 - As before, trigger the autocomplete search in the instrcutor field 10 - Again your session has been terminated 11 - Apply patch 12 - Repeat above actions, this time you will not be kicked out Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: C4/External/BakerTaylor.pm | 6 +++--- acqui/basketgroup.pl | 8 +++++--- circ/ysearch.pl | 2 +- opac/opac-detail.pl | 2 +- t/External/BakerTaylor.t | 4 ++-- 5 files changed, 12 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri May 11 20:54:45 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 11 May 2018 18:54:45 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.11.00-1461-g52e93b7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 52e93b7121321b1e4b5c0872dd2c49f1cfaa80fc (commit) from 35d887fece0634eb92d030b959aeb991f10a0239 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 52e93b7121321b1e4b5c0872dd2c49f1cfaa80fc Author: Jonathan Druart Date: Fri May 11 15:41:35 2018 -0300 Bug 19181: Fix jenkins failure Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: t/db_dependent/selenium/authentication.t | 3 +++ 1 file changed, 3 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 14 16:29:07 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 14 May 2018 14:29:07 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.11.00-1471-g831e6fa Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 831e6fac4d84cf5cbc63354dcd1baa5100cfaba7 (commit) via 71eba3a74a65b49aeb5c24ddd5118df882cef14b (commit) via a88e052ae5e420eb2f8ffa7555756b0581b72652 (commit) via fdb5d0ca1ac16563c4b34c47dd32d61f96913d8a (commit) via 8ffaa7b8a32b9ee2d9d430c097322708f090f8f7 (commit) via da2886132e8445dd472b8b9ccd67e07365657c3a (commit) via 2b0c27beafae072087d1e63bb00cc5b193ed9917 (commit) via d90d8c9b272061986c101763d7c8f73ed7a9b0a2 (commit) via 624870631ce374e90db2035545150eca95c72677 (commit) via c65526f4904d6070cd88b3e7cb56a7beaed18e20 (commit) from 52e93b7121321b1e4b5c0872dd2c49f1cfaa80fc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 831e6fac4d84cf5cbc63354dcd1baa5100cfaba7 Author: Mirko Tietgen Date: Mon May 14 14:46:20 2018 +0200 Bug 20764: Koha_Template_Plugin_KohaPlugins.t is db dependent t/Koha_Template_Plugin_KohaPlugins.t is DB dependent. This patch moves it to t/db_dependent/ Signed-off-by: Jonathan Druart commit 71eba3a74a65b49aeb5c24ddd5118df882cef14b Author: Jonathan Druart Date: Mon May 14 11:11:34 2018 -0300 Bug 20428: Display warning if the entry is empty And not only if the entry is missing. We should do the same for other entries. Also, use Koha::UploadedFile->temporary_directory to know the fallback value. Signed-off-by: Jonathan Druart commit a88e052ae5e420eb2f8ffa7555756b0581b72652 Author: Marcel de Rooy Date: Mon May 14 09:05:21 2018 +0200 Bug 20428: (QA follow-up) Remove redundant directory level Upload creates its own upload folder in the temp folder, so there is no need to add another level in temporary_directory. Removing the creation of this folder in koha-create-dirs too. Also removing the use Koha::UploadedFiles in about.pl. No longer needed. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit fdb5d0ca1ac16563c4b34c47dd32d61f96913d8a Author: Tomas Cohen Arazi Date: Fri May 11 14:24:32 2018 -0300 Bug 20428: Make upload_tmp a more general tmp directory Signed-off-by: Tomas Cohen Arazi Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 8ffaa7b8a32b9ee2d9d430c097322708f090f8f7 Author: Mark Tompsett Date: Tue May 8 16:14:48 2018 +0000 Bug 20428: Added missing parameter --upload-tmp-path Line 463 lists valid parameters, but it was missing upload-tmp-path: which resulted in the koha-create saying it is an invalid parameter. TEST PLAN --------- 1) apply all patches but this. 2) sudo perl ~/misc4dev/cp_debian_files.pl 3) restart_all 4) sudo koha-create --create-db --upload-tmp-path unique-path awesome-test-name -- Fails to run. 5) apply this patch 6) repeat 2-4 7) sudo vi /etc/koha/sites/awesome-test-name/koha-conf.xml -- the upload_tmp_path entry should have unique-path in it. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit da2886132e8445dd472b8b9ccd67e07365657c3a Author: Tomas Cohen Arazi Date: Thu Mar 29 10:45:30 2018 -0300 Bug 20428: Make about.pl inform about missing upload_tmp_path entry This patch makes about.pl warn about a missing upload_tmp_path entry in koha-conf.xml. It also mentions the effectively used tmp dir. Signed-off-by: Kyle M Hall Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 2b0c27beafae072087d1e63bb00cc5b193ed9917 Author: Tomas Cohen Arazi Date: Thu Mar 29 10:44:59 2018 -0300 Bug 20428: Make Koha::UploadedFile use the new config entry for tmp files This patch makes Koha::UploadedFile->temporary_directory try to use the new configuration entry. It will fallback to File::Spec->tmpdir otherwise. Signed-off-by: Kyle M Hall Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit d90d8c9b272061986c101763d7c8f73ed7a9b0a2 Author: Tomas Cohen Arazi Date: Thu Mar 29 10:25:43 2018 -0300 Bug 20428: Add the option to specify a tmp uploads dir This patch adds an option to the koha-conf.xml file for specifying a temporary uploaded files directory. The koha-create script is adjusted to handle it and a convenient option switch is added. If ommited, it will default to /var/lib/koha//uploads_tmp. koha-create-dirs is patched to create the required directory with the right permissions. The docs get the new parameter documented. Signed-off-by: Kyle M Hall Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart commit 624870631ce374e90db2035545150eca95c72677 Author: Katrin Fischer Date: Thu May 10 21:05:07 2018 +0200 Bug 20404: Turn on ExtendedPatronAttributes by default for new installations Extended patron attributes are a very useful feature that should be more obvious. We should activate them by default for new installations. For testing: - Run the web isntaller on an empty database - Check that after installation ExtendedPatronAttributes is turned on Signed-off-by: Charles Farmer Signed-off-by: Jonathan Druart commit c65526f4904d6070cd88b3e7cb56a7beaed18e20 Author: Jonathan Druart Date: Fri May 11 16:25:13 2018 -0300 Bug 19181: Do not screenshot Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: Koha/UploadedFile.pm | 2 +- about.pl | 10 +++++++ debian/docs/koha-create.xml | 9 ++++++ debian/scripts/koha-create | 29 +++++++++++++++++--- debian/scripts/koha-create-dirs | 1 + debian/templates/koha-conf-site.xml.in | 1 + etc/koha-conf.xml | 1 + installer/data/mysql/sysprefs.sql | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 8 ++++++ .../Koha_Template_Plugin_KohaPlugins.t | 0 t/db_dependent/selenium/authentication.t | 1 - 11 files changed, 57 insertions(+), 7 deletions(-) rename t/{ => db_dependent}/Koha_Template_Plugin_KohaPlugins.t (100%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 14 17:37:04 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 14 May 2018 15:37:04 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.11.00-1474-g46b6485 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 46b648545470bcd39d751bff0709c0ec6d79e041 (commit) via 3a125dfb9144ae4165d9790121db1ed3b7129dc4 (commit) via 3523a01a07381a701375b81d540e325559449aae (commit) from 831e6fac4d84cf5cbc63354dcd1baa5100cfaba7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 46b648545470bcd39d751bff0709c0ec6d79e041 Author: Jonathan Druart Date: Mon May 14 12:25:42 2018 -0300 Bug 20404: Fix Patrons/Import.t Signed-off-by: Jonathan Druart commit 3a125dfb9144ae4165d9790121db1ed3b7129dc4 Author: Jonathan Druart Date: Mon May 14 12:14:33 2018 -0300 Bug 20764: Rename the test file Signed-off-by: Jonathan Druart commit 3523a01a07381a701375b81d540e325559449aae Author: Tomas Cohen Arazi Date: Mon May 14 12:03:32 2018 -0300 Bug 20764: (QA follow-up) Fix path to sample plugins Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: t/db_dependent/ImportBatch.t | 5 ++--- t/db_dependent/Koha/Patrons/Import.t | 13 +++++-------- .../Template/Plugin/KohaPlugins.t} | 2 +- t/{ => lib}/Koha/Plugin/MarcFieldValues.pm | 0 t/{ => lib}/Koha/Plugin/Test.pm | 0 5 files changed, 8 insertions(+), 12 deletions(-) rename t/db_dependent/{Koha_Template_Plugin_KohaPlugins.t => Koha/Template/Plugin/KohaPlugins.t} (97%) rename t/{ => lib}/Koha/Plugin/MarcFieldValues.pm (100%) rename t/{ => lib}/Koha/Plugin/Test.pm (100%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 14 17:44:37 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 14 May 2018 15:44:37 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.11.00-1475-gbdad7ae Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via bdad7aec0e34c81c7eb02a2de7552c4a03998a62 (commit) from 46b648545470bcd39d751bff0709c0ec6d79e041 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bdad7aec0e34c81c7eb02a2de7552c4a03998a62 Author: Jonathan Druart Date: Mon May 14 12:33:48 2018 -0300 Bug 20764: (follow-up) Rename the test file There is something wrong here... Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Koha/Template/Plugin/KohaPlugins.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 14 18:19:51 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 14 May 2018 16:19:51 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v17.11.00-1476-g3422a0d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 3422a0d93eb2ac607b9deee57f9e5c034907c839 (commit) from bdad7aec0e34c81c7eb02a2de7552c4a03998a62 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3422a0d93eb2ac607b9deee57f9e5c034907c839 Author: Jonathan Druart Date: Mon May 14 13:09:16 2018 -0300 Bug 20764: Fix Plugins.t Signed-off-by: Jonathan Druart ----------------------------------------------------------------------- Summary of changes: t/db_dependent/Plugins.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon May 14 19:35:05 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 14 May 2018 17:35:05 +0000 Subject: [koha-commits] main Koha release repository annotated tag v18.05.00-rc1 created. v18.05.00-rc1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v18.05.00-rc1 has been created at 771735cd7ff44a4ff95cac6b74888e96413f9042 (tag) tagging 3422a0d93eb2ac607b9deee57f9e5c034907c839 (commit) replaces v17.11.00 tagged by Jonathan Druart on Mon May 14 14:11:03 2018 -0300 - Log ----------------------------------------------------------------- Koha 18.05 release candidate 1 Aleisha Amohia (9): Bug 19496: Fixing to_address for patron notes Bug 19429: Add confirm message when deleting invoice from invoice search page Bug 19401: Add confirm message when deleting invoice Bug 19200: Preventing warns when exporting a basket Bug 18915: Fix checkout note email message Bug 18915: Giving CHECKOUT_NOTE access to issues table Bug 18915: Renaming svc/patron_notes to svc/checkout_notes Bug 20068: Check if user logged in before passing dashboard params to template Bug 19230: Preventing warn when deleting course Alex Arnaud (8): Bug 4319: [OPAC] Allow holds on waiting/transit items Bug 4319: (QA follow-up) Rename hasItemswaitingOrInTransit to has_items_waiting_or_intransit Bug 19583: Remove use of C4::AuthoritiesMarc Bug 17373: Add mappings for unimarc authorities - Match index Bug 20261: Fix pagination of the results in authority search Bug 19873: Ability to search on 0 value Bug 19873: Add unit tests Bug 19752: offline_circ/service.pl - Return HTTP status 401 when authentication failed and add option nocookie Alex Buckley (4): Bug 19514: Implement password restrictions into onboarding tool Bug 19243: Amended Selenium test to add the creation of patron category and authorised values Bug 20329: Shorten the width of text input fields Bug 19181: Selenium test for logging into the Koha intranet and OPAC Amit Gupta (4): Bug 19614: Fix XSS in members/pay.pl Bug 19612: Fix XSS in members/memberentry.pl Bug 19611: Fix XSS Flaws in supplier.pl Bug 20719: Add missing USE Branches to files.tt Andreas Roussos (1): Bug 20083: Information disclosure when (mis)using the MARC Preview feature Andrew Isherwood (6): Bug 20515: Fix permission check on "ILL request" menu options Bug 20515: (QA follow-up) Remove specific superlibrarian check Bug 20515: (follow-up) Add missing CAN_user_ill Bug 20556: Marking ILL request as complete.. Bug 20284: ILLModuleCopyrightClearance text breaks Bug 20284: (follow-up) Added missing 'exit's Benjamin Rokseth (1): Bug 16330: Add routes to add, update and delete patrons Bonnie Crawford (1): Bug 18819: "UNIMARC is used in Europe" text changed to "UNIMARC is used in a few European countries" Chad Billman (1): Bug 15752: Automatically switch to patron when cardnumber is read during circulation Charles Farmer (2): Bug 20249: (bug 18789 follow-up) "Patron has no outstanding fines" now appears alongside fines Bug 19955: Minor grammatical correction Charlotte Cordwell (8): Bug 17682: Change URL for Google Scholar in OPACSearchForTitleIn Bug 17682: (follow-up) Change URL for Google Scholar in OPACSearchForTitleIn Bug 19831: Turn on EnhancedMessagingPreferences by default for new installations Bug 19993: use Modern::Perl in Acquisition perl scripts Bug 19997: use Modern::Perl in Circulation perl scripts Bug 20012: use Modern::Perl in Reports perl scripts Bug 20020: use Modern::Perl in XT scripts Bug 19892: Replace numbersphr variable with Koha.Preference('OPACNumbersPreferPhrase') in OPAC Chris Cormack (1): Bug 19160: CAS Single logout Chris Nighswonger (1): Bug 10222: Error when saving Demco label templates Chris Weeks (1): Bug 19510: Add description for edi_manage in acquistion permissions Christophe Croullebois (1): Bug 20318: Merge invoices can lead to an merged invoice without Invoice number Claire Gravely (5): Bug 19769: 'Pickup library is different' message does not display library branch name when placing hold Bug 19678: Clicking Cancel when adding New Course to course reserves shows message Invalid Course! Bug 20382: Missing space between patron and cardnumber on check out screen Bug 20386: Improve warning and error messages for Search Engine Configuration Bug 20552: Fix HTML tag for search facets Colin Campbell (2): Bug 12598: Allow matched patron to be updated Bug 18625: Update lastseen in patron info request David Bourgault (10): Bug 19683: Fix authority types in tools/export template Bug 19681: Correct result count formatting Bug 11210: Writeoff partial amounts Bug 19702: Correct cookie path in Basket.js Bug 19466: Warn about conflicting settings of autoMemberNum and BorrowerMandatoryField for cardnumber Bug 17457: Adv. Acquisition search with ISBN variations Bug 17457: Add tests for each marc flavour Bug 19708: Improve code for printing the cart in OPAC Bug 19466: Turn AutoCalc off for new installs Bug 19792: Performance boost for GetBudgetHierarchy David Cook (2): Bug 20173: Clean up koha-tmpl directory Bug 20173: Fix favicon.ico path in installer David Gustafsson (3): Bug 19563: Generation of sort_fields uses incorrect condition Bug 19471: Show creation date in patron restrictions list Bug 19564: Fix extraction of sort order from sort condition name Ere Maijala (3): Bug 20073: Move Elasticsearch configs to yaml files and improve the default settings. Bug 20665: Units tests for testing MySQL connection time zone Bug 20665: Reset MySQL connection time zone in the OAI-PMH Provider Fridolin Somers (7): Bug 19646: fix value_builder marc21_linking_section template Bug 19640: fix OPAC IdRef webservice display Bug 18833: Plugin unimarc_field_210c pagination error Bug 20341: Show authorized value description for withdrawn like damaged and lost Bug 20085: Better translatability of smart-rules.tt Bug 19739: Add default ES configuration to koha-conf.xml Bug 17373: Elasticsearch - Authority mappings for UNIMARC - patch1 Fr?d?ric Demians (1): Bug 19788: Preserve case sensitivity when creating Local preferences Grace Smyth (6): Bug 19987: If no z39.50/SRU servers the button should not show Bug 19839: Removed Warning (invoice.pl - uncertainprices) Bug 18878: Align labels in item form to the right Bug 19986: 'Server name' doesn't appear as required Bug 19996: use Modern::Perl in cataloguing perl scripts Bug 20010: use Modern::Perl in Patroncards perl scripts Indranil Das Gupta (L2C2 Technologies) (1): Bug 20054: Remove attribute "text/css" for