[koha-commits] main Koha release repository branch master updated. v17.11.00-1385-g6db7ab6

Fri May 4 14:59:53 CEST 2018

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  6db7ab6b93f52358bcbad60b60ad776a2cd68a23 (commit)
       via  4c36d4beb6f308ddec9b8da667ed23878bdc208d (commit)
       via  be35e4883a5595b08c14364fb5da7c98a251aeb5 (commit)
       via  32a2528d53c7917a0d680dc54416df3202057a5e (commit)
       via  d2d937fc9bb4bdd886c12964c4a21b324626528b (commit)
       via  305d3c36cb685fabce3ec4357ed769c25b12eb73 (commit)
      from  75dc3fb0f3291221c3c1b59006ef75d92f4f63c2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 6db7ab6b93f52358bcbad60b60ad776a2cd68a23
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Mon Mar 26 19:14:44 2018 +0000

    Bug 20477: Silence floody noise on fast cataloging

    TEST PLAN
    ---------
    See comment #0 to reproduce.
    apply this patch
    restart_all

    echo | sudo tee /var/log/koha/kohadev/place-error.log
    restart_all
    cat /var/log/koha/kohadev/plack-error.log
    -- just restart information

    log into staff client again, home -> circulation -> fast cataloging

    cat /var/log/koha/kohadev/plack-error.log
    -- just restart information

    run qa test tools

    Signed-off-by: Roch D'Amour <roch.damour at inlibro.com>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 4c36d4beb6f308ddec9b8da667ed23878bdc208d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Apr 19 09:54:45 2018 -0300

    Bug 20620: Remove warnings in moredetail.pl

    Since 19995 warnings are displayed in moredetail.pl, we should get rid
    of them.

    Test plan:
    Hit moredetail.pl with different biblionumbers and confirm you do no
    longer see warnings in logs.

    Make sure values for rentalcharge, item type, ccode and replacementprice
    are displayed correctly.

    Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit be35e4883a5595b08c14364fb5da7c98a251aeb5
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Thu Apr 26 04:31:32 2018 +0000

    Bug 20663: Add some POD, so koha test tools don't complain

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 32a2528d53c7917a0d680dc54416df3202057a5e
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Thu Apr 26 04:17:51 2018 +0000

    Bug 20663: Remove dead code related to compound reports

    TEST PLAN
    ---------
    git grep "Create Compound Report"
    -- only one file
    git grep compound | grep 1
    -- this is the only setting of the compound tt variable
    less koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
    -- There is an TT IF statement for compound.
    -- In that statement it would trigger 'Save Compound'
    git grep save_compound
    -- only the template and the guided report perl
    git grep create_compound
    -- only triggered by the save code in the guided report perl
    -- in the export for the C4/Reports/Guided.pm
    git grep run_compound
    -- left over in export

    apply the patch
    look around and see the pieces are cleaned up.

    run koha qa test tools

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit d2d937fc9bb4bdd886c12964c4a21b324626528b
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sun Apr 22 22:00:17 2018 +0000

    Bug 19171: Attempt to make "no holds possible" messages less confusing

    At the moment, when no holds are possible, the OPAC reads something
    like:

    Sorry, none of these items can be placed on hold.
    No items available.

    This is confusing to the patrons, because the records have items,
    but they are not showing. The record also may have available items,
    they are just not permitted to place holds on them.

    Changes:
    - Only display the first message, when somoene tried unsuccessfully
      to place holds on multiple records.
    - Change first message to: Sorry, none of these titles can be placed on hold.
    - Change the second message to read:
      No items available to be placed on hold.
    - Remove <strong> around Sorry for better translatability.

    To test:
    - Try to place a hold on single record, where no hold is possible.
    - Try to place a hold on a single record, where a hold is possible.
    - Try to place holds on multiple records where no hold is possible.
    - Try to place holds on multiple records where at least one hold
      is possible.

      Verify the screen messages make sense in all cases.

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Fixed stray </strong> during signoff.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    For consistency with staff, I renamed multi_holds to multi_hold.

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 305d3c36cb685fabce3ec4357ed769c25b12eb73
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu May 3 15:40:11 2018 -0300

    Bug 20685: Escape letter template content in textarea

    Test plan:
    enter the following text into the Email template for 'HOLD_SLIP'
    in Home › Tools › Notices & Slips › Modify notice

    <div style='max-width: 4in;'>
    <h3><<borrowers.surname>>, <<borrowers.firstname>></h3><br />
    <<borrowers.streetnumber>> <<borrowers.address>><br />
    <<borrowers.address2>><br />
    <<borrowers.city>>, <<borrowers.state>> <<borrowers.zipcode>><br />
    <br />
    <br />
    <img src="/cgi-bin/koha/svc/barcode?barcode=<<borrowers.cardnumber>>&type=Industrial2of5&notext=1">

    Edit it again
    Without this patch you will get:
    <img src="/cgi-bin/koha/svc/barcode?barcode=<<borrowers.cardnumber>>&type=Industrial2of5¬ext=1">

    Signed-off-by: Barton Chittenden <barton at bywatersolutions.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-----------------------------------------------------------------------

Summary of changes:
 C4/Reports/Guided.pm                               |   38 +++++---------------
 catalogue/moredetail.pl                            |   11 +++---
 cataloguing/addbiblio.pl                           |    6 ++--
 .../en/modules/reports/guided_reports_start.tt     |   25 -------------
 .../intranet-tmpl/prog/en/modules/tools/letter.tt  |    2 +-
 .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt |    8 ++---
 opac/opac-reserve.pl                               |    4 +++
 reports/guided_reports.pl                          |   16 ---------
 8 files changed, 26 insertions(+), 84 deletions(-)

hooks/post-receive
-- 
main Koha release repository