[koha-commits] main Koha release repository branch master updated. v17.11.00-1457-g54944bd
Git repo owner
gitmaster at git.koha-community.org
Fri May 11 16:22:26 CEST 2018
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 54944bd10299d8af3c698d50ac75839af45fa300 (commit)
via 935af3eab537244d9fbb70207ee41d7874591fdd (commit)
via 8f3f232175183e117931bb6895cbc2d3dbf64534 (commit)
via 1edd7f8265b5e51f3e651c207ee8c3301273891f (commit)
via 5347537f1ab216dd283a5c85604b28d6f2d5c21c (commit)
via 1bc3bbfdc78bfd559fec841c6ca47ddcbeb0f179 (commit)
via 3811985c3a55b72900ba005c6867059776ee9281 (commit)
via 4200ffb720f1864a6ee02c071dc5aa09ee258f42 (commit)
via 9fce2434666505460030db1df3869c87c1ef83a7 (commit)
via 3b47ed3f9076f76ce476da7314c08841ce5252d1 (commit)
via 5a7976e34f12dfa2eb1ddc7d39db2271aa5f2e26 (commit)
via f55f4e090b3d961abe0206fc1ed01335d0e6f909 (commit)
via 6ea48ca9345862fc655e0ef418ea91d040ead03a (commit)
via e3fd46d3dd7e87e2857437f45b9bdaae990c5fd1 (commit)
via f0f66431758d1d051f8e6d165df027745c2a8f66 (commit)
via 837fa4e6f7010b2ce94bff36fd9ceaf94de93a18 (commit)
via ee82d441c2d84a506e553cf8e1e95984bae85204 (commit)
via 94fd62dac9b8c0bcb3127c4eef91781984c55f7b (commit)
from d2ea81e6529768ec4e85afb46cf2e3b7255f9a2e (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 54944bd10299d8af3c698d50ac75839af45fa300
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Apr 18 15:11:47 2018 -0300
Bug 7910: Give feedack when the subscriptions have been renewed
This patch adds a message to the user to let them know the subscription
have been renewed successfully.
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 935af3eab537244d9fbb70207ee41d7874591fdd
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Jan 5 13:29:06 2018 -0300
Bug 19792: Few minor fixes
- No string extrapolation needed on SQL queries
- '== undef' must be written 'if not defined'
Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 8f3f232175183e117931bb6895cbc2d3dbf64534
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed Dec 27 17:04:36 2017 +0100
Bug 19792: (QA follow-up) Move anonymous sub out of GetHierarchy
Test plan:
Run t/db_dependent/Budgets.t.
Without both patches, running the test is slower than with only the first
or both patches.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1edd7f8265b5e51f3e651c207ee8c3301273891f
Author: David Bourgault <david.bourgault at inlibro.com>
Date: Mon Dec 11 11:56:27 2017 -0500
Bug 19792: Performance boost for GetBudgetHierarchy
This patches reduces the number of SQL calls by combining multiple calls to the recursive functions GetBudgetSpent(), GetBudgetOrdered(), etc. into 4 big queries.
It also removes duplicate function calls from acqui-home.pl
Test plan:
0) Visit Acquisition home
0) Apply patch
1) Refresh page. It shoud look identical.
2) prove t/db_dependent/budgets.t
Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5347537f1ab216dd283a5c85604b28d6f2d5c21c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Dec 22 14:52:26 2017 -0300
Bug 19579: Do not confirm the registration if email already used - PatronSelfRegistrationEmailMustBeUnique
If PatronSelfRegistrationVerifyByEmail and
PatronSelfRegistrationEmailMustBeUnique are set, it should not be
possible to register twice with the same email.
However the test is made on already created patron cards when the
registration is done.
Which means it is possible to register several times with the same
email address and click on the registration link to finalise the
registration.
This patch adds a test when the registration link is clicked and display
the "Registration invalid" generic message if the same email is used
Test plan:
1. Patron submits self registration form using the same email address 3
times
2. Patron receives 3 verification emails
3. Patron clicks on 3 verify token URLs
=> Only the first registration should succeed, the 2 others must fail
Maybe we should display a more specific message?
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1bc3bbfdc78bfd559fec841c6ca47ddcbeb0f179
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri May 11 11:33:32 2018 +0200
Bug 20623: (QA follow-up) Remove one find call
Imo these somewhat weird lines ask for improvement, but I don't want to change
the exact conditions here. Just removing the need to call find twice.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3811985c3a55b72900ba005c6867059776ee9281
Author: Victor Grousset <victor.grousset at biblibre.com>
Date: Fri Apr 20 11:17:26 2018 +0200
Bug 20623: Fix basket group PDF when itemtype not itemtype table
When an item has an itemtype not in the itemtype table. Trying to fetch
it's description lead to an error.
Using authorized values like ccode to populate the itemtypes of the
biblioitems (instead of the itemtype table) can lead to such data.
Or importing records with invalid itemtype codes. Koha doesn't do enough
checks at import to at least warn about these issues.
== Test plan ==
1. first we need an item with an itype not in the item_types table
1. download a record as MARCXML
2. find it's item type in administration; and the related code
3. open the MARCXML file and search for occurences of the code
and replace them by some non-existing value like "FOOBAR"
4. also change the barcode so it won't be ignored because
it's a duplicate
5. also change the title to easily find it later in the search
6. tools → "Stage MARC records for import"
7. upload your file
8. "stage for import"
9. click "Manage staged records"
You should end on the page related to your staged record
10. "Import this batch into the catalog"
2. now we need it in a basket group
1. have/create a active budget
2. have/create a fund
3. have/create a vendor with minimal info
4. create a basket with minimal info
5. add our imported item to the basket
for example search it by name
6. go to the basket. URL should be
/cgi-bin/koha/acqui/basket.pl?basketno=XXXXX
7. close this basket
and tick "Attach this basket to a new basket group with the same name"
8. you will end up in the basket groups lists
9. go to the "closed" tab
11. go to the basket group
your vendor page => Basket groups => Closed
3. export as PDF, it should fail (internal server error)
this is the bug (no kidding ^_^)
4. apply this patch
5. reexport the basket as PDF
6. it should work
7. create an item type (in administration)
that has the same code as the one that you put in the MARCXML
8. reexport the basket as PDF
9. check that in the PDF that the description is here:
table at the bottom of the document → "Document" column
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 4200ffb720f1864a6ee02c071dc5aa09ee258f42
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon May 7 15:04:33 2018 -0300
Bug 20722: Display search results when searching only by ITEMTYPECAT
- Create an entry for the ITEMTYPECAT authorised value category.
Make sure to fill in the OPAC description.
- Go to administration > itemtypes and add the new category to 2 item types.
- Go to the OPAC and check that the advanced search shows your new itemtype
group instead of the individual itemtypes.
- Check the checkbox and Search.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 9fce2434666505460030db1df3869c87c1ef83a7
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed May 2 14:50:32 2018 +0200
Bug 20695: Fix multiple upload result in tools/upload script
Instead of calling UploadedFiles->find only once with $id, we should
extract all comma separated id's from the parameter.
Test plan:
[1] Before this patch, upload two files at once in Tools/Upload. After doing
so, you should see only one result reported. But both files should
have been uploaded.
[2] With this patch, repeat step 1 and see two upload results.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Patch applies and functions as described.
Signed-off-by: Dilan Johnpullé <dilan at calyx.net.au>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3b47ed3f9076f76ce476da7314c08841ce5252d1
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Mon May 7 18:14:22 2018 +0000
Bug 20719: USE Branches in TT files
TEST PLAN
---------
In the staff client on a kohadevbox:
1) Enable the HouseboundModule system preference.
2) Enable the EnableBorrowerFiles system preference.
3) Go to a patron detail page.
-- note the Home library is shown.
4) Go to Fines tab (left pane)
-- Home library is still shown.
5) Click each of the four horizontal tabs
(Account, Pay fines, Create manual invoice,
Create manual credit)
-- Home library not visible for both create tabs
and the account tab
6) Click the 'Create manual invoice' tab, and create
some kind of entry.
7) On the 'Account' tab, the table has a 'Details' button.
Click that.
-- Home library not visible.
8) Click the 'Details' tab in the left pane.
9) Click 'More' button and choose 'Delete'
-- Home library not visible when asked for delete
confirmation.
10) Cancel that, and if you know how to actually
set up the Norwegian system preferences you can
figure out how to test the nl-search change.
After seeing all these not visible, apply this patch.
Repeat all the steps, but this time the Home library
should be visible.
Works OK.
Signed-off-by: Amit Gupta <amit.gupta at informaticsglobal.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 5a7976e34f12dfa2eb1ddc7d39db2271aa5f2e26
Author: Amit Gupta <amit.gupta at informaticsglobal.com>
Date: Mon May 7 17:48:57 2018 +0530
Bug 20719: Add missing USE Branches to files.tt
Test
On a kohadevbox:
0. Enable the EnableBorrowerFiles system preference
1. Go to any patron, and click on the 'Files' tab in the
left pane.
-- the Home library is not displayed.
2. Apply the patch, restart_all, and reload the page.
-- the Home library is now displayed.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f55f4e090b3d961abe0206fc1ed01335d0e6f909
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Jan 19 09:34:20 2018 -0300
Bug 20746: Move it-IT files to optional
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 6ea48ca9345862fc655e0ef418ea91d040ead03a
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu May 10 12:37:53 2018 -0300
Bug 20745: koha-zebra doesn't return the correct error codes
This patch makes koha-zebra return 0 (or 1) even when verbose mode is
off. This made koha-zebra --start always return a failure even when the
daemon was correctly launched.
To test:
- Have Zebra running for kohadev instance on your KohaDevBox
- Run:
$ sudo koha-zebra --stop kohadev && echo yay || echo doh
=> FAIL: 'doh' is printed
- Run:
$ sudo koha-zebra --start kohadev e&& echo yay || echo doh
=> FAIL: 'doh' is printed as well
- Apply this patch
- Run:
$ sudo perl misc4dev/cp_debian_files.pl
$ sudo koha-zebra --stop kohadev && echo yay || echo doh
=> SUCCESS: 'yay' is printed
- Run:
$ sudo koha-zebra --start kohadev e&& echo yay || echo doh
=> SUCCESS: 'yay' is printed
- Sign off :-D
Sponsored-by: ByWater Solutions
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e3fd46d3dd7e87e2857437f45b9bdaae990c5fd1
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Apr 25 16:08:25 2018 -0300
Bug 19181: Add new tests
This patch reuses the method newly added to Selenium.pm and improve
existing tests.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f0f66431758d1d051f8e6d165df027745c2a8f66
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Mon Oct 30 03:28:20 2017 +0000
Bug 19181: Change to use ENV, fix login and passwords
The kohadevbox has admin/admin set, so for testing when
creating the initial superuser, if you wish to minimize
effort, use admin/admin. Otherwise, make sure to:
export KOHA_USER={whatever your user is}
export KOHA_PASS={whatever your password is}
before attempting to run the test.
Also, this test was failing because of a validation check on
the passwords requiring uppercase letters, lowercase letters,
and numbers. Changed the sample data passwords to fix.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 837fa4e6f7010b2ce94bff36fd9ceaf94de93a18
Author: Alex Buckley <alexbuckley at catalyst.net.nz>
Date: Thu Jul 20 10:50:49 2017 +0000
Bug 19181: Selenium test for logging into the Koha intranet and OPAC
This selenium test goes through the process of creating a category and
patron user (as is completed in the basic_workflow.t test) then the
superlibrarian used to create them is logged out and the newly created
patron user authenticates into the OPAC and staff intranet therefore testing the
authenitcation of both.
Test plan (this test plan includes how to install Selenium as well as
how to run this test, for the benefit of people who have not got
Selenium installed on their machines):
1. wget https://selenium-release.storage.googleapis.com/2.53/selenium-server-standalone-2.53.0.jar
2. vim /etc/apt/sources.list.d/firefox.list
3. Paste into the file:
deb http://packages.linuxmint.com debian import
4. sudo apt-get update
5. sudo apt-get install firefox
6. sudo apt-get install xvfb
7. Set the SELENIUM_PATH vartiable:
SELENIUM_PATH=/home/vagrant/kohaclone/selenium-server-standalone-2.53.0.jar
8. Xvfb :1 -screen 0 1024x768x24 2>&1 >/dev/null &
9. DISPLAY=:1 java -jar $SELENIUM_PATH
Note: This will start up the selenium server. Everytime you want to shut
down this terminal window and want to restart Selenium just run the step
9 command to restart the Selenium server
10. Open a new terminal window and write in:
git clone https://github.com/gempesaw/Selenium-Remote-Driver --branch
build/master --single-branch --depth 1
11. cd Selenium-Remote-Driver
12. perl Makefile.PL
13. make
14. make test
15. sudo make install
16. Now everything is installed and you can et up for running the selenium tests
17. Create a superlibrarian user with the username koha and password
koha
18. If your usual port configuration for the intranet and OPAC is 8081
and 8080 respectively then set the staffClientBaseURL and OPACBaseURL
system preferences to localhost:8080 and localhost:80 respectively
19. sudo koha-shell <instancename>
20. perl t/db_dependent/selenium/authenticate.t
21. The test should pass.
Note: The time_diff comments in the test output showing what the test is
doing
Note: If you have issues with installing Selenium and
Selenium::Remote::Driver please write a comment on the bug report and I
will be more than happy to create a screencapture video showing all the
steps
Sponsored-By: Catalyst IT
https://bugs.koha-community.org/show_bug.cgi?id=19181
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ee82d441c2d84a506e553cf8e1e95984bae85204
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri May 4 09:54:30 2018 +0200
Bug 11943: Add unit test for double accepts
Test plan:
Run t/db_dependent/Virtualshelves.t
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 94fd62dac9b8c0bcb3127c4eef91781984c55f7b
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri May 4 09:34:02 2018 +0200
Bug 11943: Prevent double accepts in Koha::Virtualshelfshare
This 'bug' existed long enough now to finally remove it ;)
We do so by deleting the invitation if the borrower already has a share
on this list. Actually not that hard.
We still need: a unit test and a db revision.
Test plan:
[1] Share a list. Let user B accept.
[2] Without this patch: Share again and let B accept again.
[3] Verify that you have two shares for this list in virtualshelfshares.
[4] With this patch: Share another list, let B accept.
[5] Share this other list again, let B accept again.
[6] Verify that virtualshelfshares does not contain double entries now.
(Note: This pertains to the second list only.)
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
C4/Budgets.pm | 65 +++++++++-
Koha/Virtualshelfshare.pm | 18 ++-
acqui/acqui-home.pl | 3 -
acqui/basketgroup.pl | 4 +-
debian/scripts/koha-zebra | 22 ++--
.../{necessari => optional}/patron_categories.sql | 0
.../{necessari => optional}/patron_categories.txt | 0
.../{necessari => optional}/sample_holidays.sql | 0
.../{necessari => optional}/sample_holidays.txt | 0
.../{necessari => optional}/sample_itemtypes.sql | 0
.../{necessari => optional}/sample_itemtypes.txt | 0
.../it-IT/{necessari => optional}/sample_news.sql | 0
.../it-IT/{necessari => optional}/sample_news.txt | 0
.../prog/en/modules/members/accountline-details.tt | 1 +
.../prog/en/modules/members/boraccount.tt | 1 +
.../prog/en/modules/members/deletemem.tt | 1 +
.../intranet-tmpl/prog/en/modules/members/files.tt | 1 +
.../prog/en/modules/members/housebound.tt | 1 +
.../prog/en/modules/members/mancredit.tt | 1 +
.../prog/en/modules/members/maninvoice.tt | 1 +
.../prog/en/modules/members/nl-search.tt | 1 +
.../prog/en/modules/serials/checkexpiration.tt | 9 +-
.../prog/en/modules/serials/subscription-renew.tt | 29 +++--
opac/opac-registration-verify.pl | 10 +-
opac/opac-search.pl | 2 +-
t/db_dependent/Virtualshelves.t | 10 +-
t/db_dependent/selenium/authentication.t | 131 ++++++++++++++++++++
t/lib/Selenium.pm | 17 ++-
tools/upload.pl | 12 +-
29 files changed, 296 insertions(+), 44 deletions(-)
rename installer/data/mysql/it-IT/{necessari => optional}/patron_categories.sql (100%)
rename installer/data/mysql/it-IT/{necessari => optional}/patron_categories.txt (100%)
rename installer/data/mysql/it-IT/{necessari => optional}/sample_holidays.sql (100%)
rename installer/data/mysql/it-IT/{necessari => optional}/sample_holidays.txt (100%)
rename installer/data/mysql/it-IT/{necessari => optional}/sample_itemtypes.sql (100%)
rename installer/data/mysql/it-IT/{necessari => optional}/sample_itemtypes.txt (100%)
rename installer/data/mysql/it-IT/{necessari => optional}/sample_news.sql (100%)
rename installer/data/mysql/it-IT/{necessari => optional}/sample_news.txt (100%)
create mode 100644 t/db_dependent/selenium/authentication.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list