[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.05-38-g16c6ff1
Git repo owner
gitmaster at git.koha-community.org
Mon May 14 20:22:51 CEST 2018
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 17.11.x has been updated
via 16c6ff1e3cb30f3aa4d2e23301b942eaf5a63d4c (commit)
via a8b8a1e68b5ab2f3f47a9a4836d3b1589bd5581b (commit)
via ebafcc700840a93c9c076819f8e42ad67ea1063d (commit)
via 548527a7ba3712d45181f8c25f50b69a147f6dce (commit)
via 450a8bd570c56c723d1a49aceb1ce80400506328 (commit)
via 5a6e7a6ffbab8e42e706486b9e75abe782a696b8 (commit)
via 094515fb74329c6ecee822070e5eb3e7789af6ff (commit)
via c224db15d7298381d3a1ea07f6f8d20b50fe7d3f (commit)
via 995e0bb96897c710864c2e7c75ba74e0a927fea2 (commit)
via f5be2d525f7540a4833c14759bdc0de2ba5657db (commit)
via 149645534bac47f8d0b9e63e7a9b53fc51f40076 (commit)
via dc2f137d02bf0f67430e9640423e801d000e9982 (commit)
via d9da812ec45de6bed96f18ffa854e761ff03e331 (commit)
via d7da6d1fea141a6b5c026b36780c6d840b52a25c (commit)
via 03b31bfc625484c9219935a50a5d0d3cf017b5e6 (commit)
via 14b70dc91006c16beb48d40fe23fad27ed206f02 (commit)
via 3fb5d1c7cd852b52cecd1ef763872bea78e1ba91 (commit)
via 1f4baf31bb19c615f43771efa3fac7e2333d3622 (commit)
via 1982b1ad11703c815ceda2d9de79af62cda5263e (commit)
via 3838dd83753a94adb32ab1b6facee7e700e20066 (commit)
via a444807b57bfc0317b23d1a62e08bcbb15d39bc8 (commit)
via dc008b90cd50b80c78520de6379c61e534efce75 (commit)
via 746086120fbe3086108e233a83a46643d9970888 (commit)
via 924e987ad808525d85122bbd14786ebb1a1f0a47 (commit)
via 082e4e257123d2f192008e531657ebb63adaef21 (commit)
via 6852c592f7f81b3d76b1ccfd38264bcd9cc75a61 (commit)
via 3c5457b577282ff993071f1e4f5f785d5ae3e49f (commit)
via e689e075d050230347000d2bb0113440b8f8d4a5 (commit)
via ecadc62eb4da98fd8f56f8de2e95f6270e7dc14a (commit)
via 16dfb0309b778725fdb76cadee9943a0344285ed (commit)
via 4fcddf80d559e2d7feeaa97c4bb114c8d2876ebd (commit)
via 7fc293eec0c0ca8e206e4f17ab46410a7c29e211 (commit)
via 09eaaaebcd8e02dbb3d026304d6227bbdc146cca (commit)
via 688d8c0092faf8d30ae5b40efd854721da5ccb36 (commit)
via f60bff7aa0e3ca932f5572b7837d912b8681ca2a (commit)
via 141bb554b2ffa036350bd0ab27d2520598f5ba9d (commit)
via 3b2ac332f901e1eafdfd33bc4210bbae01a1406e (commit)
via 7a1a9c92f190661264acc261d3f2e891fb107b6e (commit)
from cd31ea0d072decd6619b6a6fb6bba3c68acbe4b0 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 16c6ff1e3cb30f3aa4d2e23301b942eaf5a63d4c
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Fri Apr 6 14:59:28 2018 +0000
Bug 20122: Explicitly set path to fix emptying cart functionality
This is caused by bib_list not being deleted.
The path was not explicitly set.
This patch adds path=/ explicitly to ensure it
does get deleted.
TEST PLAN
---------
1) search for 'the' in OPAC
2) add several items to cart.
3) look at your cart.
4) empty and close the cart, select all->remove
-- either way window closes and it looks empty.
5) refresh the page
-- cart comes back.
-- in chromium inspecting the page, specifically
the "Application" area, bib_list is shown as
a cookie still.
6) apply patch
7) restart_all and empty cache forcing JS reload
8) repeat steps 1-5
-- this time cart stays empty.
-- and the bib_list cookie is gone
Signed-off-by: Roch D'Amour <roch.damour at inlibro.com> using firefox 59.0.2
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit a8b8a1e68b5ab2f3f47a9a4836d3b1589bd5581b
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date: Thu Apr 5 06:12:44 2018 -0400
Bug 20325: Remove warning, it is no longer true
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ebafcc700840a93c9c076819f8e42ad67ea1063d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Apr 4 15:36:46 2018 -0300
Bug 20325: Do not remove accountlines between tests
This is part of the tests, to make sure they have not been deleted
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Conflicts:
t/db_dependent/Accounts.t
commit 548527a7ba3712d45181f8c25f50b69a147f6dce
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Apr 4 15:19:54 2018 -0300
Bug 20325: Move tests to a subtest
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Conflicts:
t/db_dependent/Accounts.t
commit 450a8bd570c56c723d1a49aceb1ce80400506328
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date: Tue Mar 27 15:16:16 2018 -0400
Bug 20325: C4::Accounts::purge_zero_balance_fees does not check account_offsets
purge_zero_balance_fees is used in cleanup_database.pl to determine which fees can be cleaned up.
It uses a simple SQL query to determine which rows in accountlines need to be removed:
463 my $sth = $dbh->prepare(
464 q{
465 DELETE FROM accountlines
466 WHERE date < date_sub(curdate(), INTERVAL ? DAY)
467 AND ( amountoutstanding = 0 or amountoutstanding IS NULL );
468 }
The function comes with the following warning:
451 B<Warning:> Because fines and payments are not linked in accountlines, it is
452 possible for a fine to be deleted without the accompanying payment,
453 or vise versa. This won't affect the account balance, but might be
454 confusing to staff.
This was a reasonable solution prior to the addition of account_offsets in 17.11. The problem now is that rows in accountlines which are linked as credits in accountlines will *always* have amountoutstanding marked as 0. These are linked to debits via account_offsets. purge_zero_balance_fees will delete credits and leave rows in account_offsets which link to deleted credits.
Sites using the --fees option cleanup_database.pl which upgrade to 17.11 may have all of their credits removed without warning.
Test Plan:
1) Apply this patch
2) prove t/db_dependent/Accounts.t
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Conflicts:
t/db_dependent/Accounts.t
commit 5a6e7a6ffbab8e42e706486b9e75abe782a696b8
Author: Jesse Weaver <jweaver at bywatersolutions.com>
Date: Mon Jul 18 16:31:20 2016 -0600
Bug 19267: Rancor - Warn before leaving page if record modified
To test:
1 - Open the advanced editor
2 - Make some changes to a record
3 - Click on 'Patrons' or leave the page in some way
4 - Note there is no warning and changes are not saved
5 - Apply patch
6 - Open the advanced editor
7 - Make some changes
8 - Leave the page
9 - Note you get a warning of unsaved changes and can stay on the page
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 094515fb74329c6ecee822070e5eb3e7789af6ff
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Dec 14 07:03:39 2017 -0500
Bug 19812: Fix confusing holds count values in "Already received" table
In acqui/parcel.pl both the "Pending orders" and "Already received" tables show how many holds there are for the given record. However, the count of holds in the "Pending orders" table confuses librarians because it only lists holds for the particular items in the orderline. Due to that, the holds column may show 0 holds even if there are a dozen record level holds for that bib! This is not what librarians seem to expect, instead it seems that the same total holds in the "Pending orders" table would be preferred.
Test Plan:
1) Find an invoice with an item in the "Already received" table
2) Add one or more record level holds to the record
3) Note the holds column does not count those holds
4) Apply this patch
5) Note the holds column now shows total holds and holds for just those ordered items
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Nancy Keener <nkeener at washoecounty.us>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Bug 19812: (QA follow-up) Swap sides for total and item holds
Bug 19812: (QA follow-up) If 0 holds show '0' not '0 / 0'
Bug 19812: (QA follow-up) Remove unnecessary line
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit c224db15d7298381d3a1ea07f6f8d20b50fe7d3f
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Apr 4 15:54:58 2018 -0300
Bug 19910: Use span to make translators happy
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 995e0bb96897c710864c2e7c75ba74e0a927fea2
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Jan 3 14:07:17 2018 +0000
Bug 19910: Use the delimiter syspref to name download link
To test:
1 - Set delimiter syspref to anything but comma
2 - Download report results as comma separated text
3 - They actually follow the syspref
4 - Apply patch
5 - Download link should now match pref selection
6 - Change pref, note link changes
7 - Verify things still work as expected
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Victor Grousset <victor.grousset at biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f5be2d525f7540a4833c14759bdc0de2ba5657db
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Nov 6 15:35:50 2017 -0300
Bug 19578: Remove MARC punctuation in notices (TT syntax)
Jenkins fails (run 287) on a test in t/db_dependent/Letters/TemplateToolkit.t:
With the historical syntax:
# Your request for an article from tQYRS (c3Av58O0P5xkkIGu) has been canceled for the following reason:
With the TT syntax:
# Your request for an article from tQYRS_ (c3Av58O0P5xkkIGu) has been canceled for the following reason:
The last character of the biblio's title has been removed because it's a punctuation character.
It comes from: C4::Letters::_parseletter
893 $val =~ s/\p{P}$// if $val && $table=~/biblio/;
The same replacement is done for patron's attributes too.
Test plan:
- Confirm that the new tests pass. That should be enough to confirm this change make sense.
Test plan (manual):
- Create a biblio with a title ending with a punctuation (like "with_punctuation_"), or any other fields of biblio/biblioitem
- Generate a notice which will display this field (CHECKIN for instance)
Use the historical syntax and the TT syntax, both should display the title without the punctuation character at the end
CHECKIN historical:
The following items have been checked in:
----
<<biblio.title>>
----
CHECKIN TT syntax:
The following items have been checked in:
----
[% biblio.title %]
----
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 149645534bac47f8d0b9e63e7a9b53fc51f40076
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Mar 27 15:56:57 2018 -0300
Bug 19223: Add methods to correctly handle plugin-generated output
This patch introduces two methods to be used by plugin authors:
->output
->output_html
They are basically wrappers for the helper methods from C4::Output
(output_html_with_http_headers and output_with_http_headers).
Plugin authors can use them, or keep the current flexibility of handling
the headers themselves in their code.
The KitchenSink plugin should be updated to highlight this.
To test:
- Run:
$ kshell
k$ prove t/db_dependent/Plugins.t
=> FAIL: The methods are not implemented
- Apply this patch
- Run:
k$ prove t/db_dependent/Plugins.t
=> SUCCESS: Tests pass, and they are meaningful
- Sign off :-D
Sponsored-by: ByWater Solutions
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit dc2f137d02bf0f67430e9640423e801d000e9982
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Mar 27 15:56:41 2018 -0300
Bug 19223: Unit tests for output and output_html methods
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d9da812ec45de6bed96f18ffa854e761ff03e331
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Mar 27 16:46:16 2018 +0000
Bug 19892: (follow-up) Replace one more instance
This patch replaces one more instance of [% IF ( numbersphr ) %].
To test, apply the patch and view the source of the OPAC home page.
With the OPACNumbersPreferPhrase system preference set to 'use,' you
should find this in the HTML source:
<option value="callnum,phr">Call number</option>
With the preference set to 'don't use,' you should find this:
<option value="callnum">Call number</option>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit d7da6d1fea141a6b5c026b36780c6d840b52a25c
Author: Charlotte Cordwell <charlotte.cordwell123 at gmail.com>
Date: Thu Jan 18 01:29:05 2018 +0000
Bug 19892: Replace numbersphr variable with Koha.Preference('OPACNumbersPreferPhrase') in OPAC
Test Case
1) Check that the following files have been changed properly.
opac/opac-search.pl
opac/opac-main.pl
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
2)Apply bug
3) Check that there are no differences in behaviour as a result of the patch.
Signed-off-by: Roch D'Amour <roch.damour at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 03b31bfc625484c9219935a50a5d0d3cf017b5e6
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Feb 23 10:58:27 2018 +0000
Bug 20282: Match course reserve on holdingbranch
To test:
1 - Add a course (Course Reserves)
2 - Add an item to the course
3 - Ensure to change the holding branch for the course reserve
4 - Modify the course item
5 - Note the dropdwn for holding branch is unset
6 - Apply patch
7 - Modify the course item
8 - Dropdown should be correctly populated
Signed-off-by: Maksim Sen <maksim.sen at inlibro.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 14b70dc91006c16beb48d40fe23fad27ed206f02
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date: Mon Mar 12 07:15:12 2018 -0400
Bug 20369: Analytics search is broken with QueryAutoTruncate set to 'only if * is added'
Test Plan:
1) Enable EasyAnalytics
2) Disable QueryAutoTruncate
3) Create an analytic record, add some host items to it
4) Browser to the analytics tab for the record
5) Click the link in the 'used in' column of the table
6) No search results
7) Apply this patch
8) Reload the page, now you get the analytic record!
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3fb5d1c7cd852b52cecd1ef763872bea78e1ba91
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Wed Jan 3 11:20:46 2018 +0000
Bug 19907: Fix email validation in patron edit form
Test plan:
0) Confirm that email validation is not working in add/edit patron form
1) Apply the patch
2) Edit/add patron, the e-mail validation should be working now
3) Ensure the password validation is still working (use test plan from
bug 19908)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Conflicts:
koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
commit 1f4baf31bb19c615f43771efa3fac7e2333d3622
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Mar 26 12:22:15 2018 -0300
Bug 20462: Ensure batch item deletion will not delete the same item twice
This has been done on bug 9509 when barcodes are scaned, but not when using a text file.
Test plan (stolen from Barton on the bug report):
1) Create a text file containing duplicate barcodes
Here's a quick way to do that, substitute INSTANCE for the instance name of your test server:
sudo koha-mysql INSTANCE <<< "select barcode from items where barcode is not null limit 3" | sed '1d;p' > /tmp/dup_barcodes.txt
2) Go to Home › Tools › Batch item deletion
3) Click 'Choose File', select the file you created in step 1.
4) Click 'Continue'
5) Note that duplicate items appear in the list of items to batch delete
6) Check 'Delete records if no items remain'
7) This will trigger a software error
Note that entering the barcodes via the 'scan items one by one' text box removes duplicates in the list, so this only causes problems when uploading a file.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 1982b1ad11703c815ceda2d9de79af62cda5263e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Apr 2 14:30:23 2018 -0300
Bug 20318: Add class 'required' to the label
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3838dd83753a94adb32ab1b6facee7e700e20066
Author: Christophe Croullebois <christophe.croullebois at biblibre.com>
Date: Wed Mar 14 14:28:28 2018 +0000
Bug 20318: Merge invoices can lead to an merged invoice without Invoice number
When you want to merge invoices you have a page with a non editable
field 'Invoice number:' it shows the content of the first invoice to be
merged.
But if you validate by clicking the 'merge' button you arrive on the
next page which says that 'Invoice has been modified' and if you quit
this page without saving you have now a merged invoice without Invoice
number.
This tiny patch just prevents this issue to occur.
Test plan :
1° go to the acqui/invoices.pl page and search invoices to merge.
You must have at least 2 invoices on the same vendor
2° check boxes to select invoices to merge and click on 'merge selected
invoices' button
3° next page you see the non editable field 'Invoice number:'
4° click on the 'merge' button
5° next page you see 'Invoice has been modified'
6° leave this page i.e click on the left link 'Invoices'
7° search invoices you'll see the merged invoice without invoice number.
Apply the patch, replay the steps 1 to 3
4° on this page you can enter your invoice number and click on the
'merge' button.
If you leave this field empty and click merge, a message informs you
that it is required and you can not merge.
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Conflicts:
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt
commit a444807b57bfc0317b23d1a62e08bcbb15d39bc8
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date: Fri Mar 30 07:08:30 2018 -0400
Bug 18474: (QA follow-up) Remove useless else in template
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit dc008b90cd50b80c78520de6379c61e534efce75
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Dec 21 15:59:24 2017 -0300
Bug 18474: Restore multiple holds when patron is searched for
We lost the ability to place multiple holds when we are searching for
patrons. The multi_holds parameter is lost and not handled correctly in
the template.
Test plan:
- Make sure you can place multiple holds for a patron you will search for
- Same for simple hold
TODO the multiple holds view should not be displayed if only 1 record
has been selected from the search result.
Signed-off-by: claude brayer <claude.brayer at cea.fr>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 746086120fbe3086108e233a83a46643d9970888
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Mar 23 17:12:13 2018 +0000
Bug 20385: (follow-up) Assign blank instead of inappropraite value
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 924e987ad808525d85122bbd14786ebb1a1f0a47
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Mar 13 14:57:47 2018 +0000
Bug 20385: Don't try to get info for bad authtypecodes
TO test:
0 - Have a koha with ES enabled and some auth records
1 - backup your db
2 - sudo koha-mysql <<instance>>
3 - UPDATE auth_types SET authtypecode="PERSO_NAMB" WHERE
authtypecode="PERSO_NAME" (or adjust as necessary)
4 - Search for some authorities where a PERSO_NAME record will be
returned
5 - KA_BOOM!
6 - Apply patch
7 - Results are returned, they do not display a code, viewing record you
won't see code
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 082e4e257123d2f192008e531657ebb63adaef21
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Mar 30 13:14:46 2018 -0300
Bug 20503: Prevent Borrower_PrevCheckout.t to fail randomly
category_type must be != "X"
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Conflicts:
t/db_dependent/Patron/Borrower_PrevCheckout.t
commit 6852c592f7f81b3d76b1ccfd38264bcd9cc75a61
Author: Lari Taskula <lari.taskula at jns.fi>
Date: Wed Mar 28 21:19:52 2018 +0000
Bug 20490: Correct bug number typo in comment in Circulation.t
NOTE: Confirmed that the typo of 17641 was part of bug 17941.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3c5457b577282ff993071f1e4f5f785d5ae3e49f
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Mar 28 12:42:19 2018 +0000
Bug 19564: (QA follow-up) Make commented out tests pass
We likely shoudln't pass through an uncoverted sort order for now, but
it does allow us to look ahead to implementing the orders directly so
seems a good option to have.
Either this patch should be used, or the commented out tests should be
removed
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit e689e075d050230347000d2bb0113440b8f8d4a5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Dec 22 15:21:51 2017 -0300
Bug 19564: Add tests for _convert_sort_fields
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit ecadc62eb4da98fd8f56f8de2e95f6270e7dc14a
Author: David Gustafsson <david.gustafsson at ub.gu.se>
Date: Thu Nov 2 15:02:23 2017 +0100
Bug 19564: Fix extraction of sort order from sort condition name
Currently sort order is extracted from sort condition by splitting the
field, instead use regular expression to extract the last part preceded
by underscore.
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 16dfb0309b778725fdb76cadee9943a0344285ed
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Dec 20 21:35:47 2017 -0300
Bug 19673: Allow to set patron attributes to 0 with batch patron modification
This patch will have to be tested deeply to make sure it will not
introduce regression!
The idea is to display an empty option in the patron attributes select
and ignore it. That way we can deal with false values 0 and "" which
were skipped before.
Test plan:
Add several patron attributes
Use the batch patron modification tool to add/update/remove them
Play with empty "" and 0 values, as well as other values
Modify several attributes in a row
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Conflicts:
koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt
commit 4fcddf80d559e2d7feeaa97c4bb114c8d2876ebd
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Jan 4 15:31:52 2018 +0000
Bug 19916: Add keyword and standard ID fields to acq external search
To test:
1 - Add an order from external source
2 - Note you don't have keyword or standard ID fields
3 - Add a catalog record from Z3950, note those fields are there
4 - Apply patch
5 - Check acq and note you do have those fields
6 - Do some searches to verify they work as expected
Signed-off-by: Maksim Sen <maksim.sen at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7fc293eec0c0ca8e206e4f17ab46410a7c29e211
Author: Pasi Kallinen <pasi.kallinen at joensuu.fi>
Date: Mon Mar 5 09:09:28 2018 +0200
Bug 20330: Allow translating more of quote upload
Translate the error messages, and the table headers.
Test plan:
1) Go to Home -> Tools -> Quote editor -> Import quotes
2) Upload quotes from a file. Try to trigger the error messages
3) On successful import, check the table header texts
4) Apply patch, update & install a language
5) The error messages and the table header texts should
show up in the xx-YY-staff-prog.po
6) Repeat 1,2,3
Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi>
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Conflicts:
koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes-upload.tt
commit 09eaaaebcd8e02dbb3d026304d6227bbdc146cca
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Mar 26 13:13:58 2018 -0300
Bug 20455: Fix sort patrons by date expired
We may need to apply this change for all other occurrences in our
codebase.
Test plan:
- Make sure sample patron data is loaded and you have a patron without a
date expired defined
- Make an empty search for all patrons or another search that gives you
a good amount of results
- Try to sort on the date expired column
=> Without this patch you get
Odd number of elements in anonymous hash
at /home/vagrant/kohaclone/C4/Utils/DataTables/Members.pm line 189.
output_pref is called with 'dateonly' (ref SCALAR), not a DateTime
object
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 688d8c0092faf8d30ae5b40efd854721da5ccb36
Author: Claire Gravely <claire.gravely at bsz-bw.de>
Date: Tue Mar 13 11:18:33 2018 +0000
Bug 20386: Improve warning and error messages for Search Engine Configuration
This patch updates a warning message and error message in the Search
engine configuration for Elasticsearch.
Note: elasticsearch does not need to be active in order to test.
To test warning message:
1. go to: cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl
2. note the warning message
3. Apply patch
4. Note the change in warning message. Confirm it makes sense.
To test error message:
Apply patch and check the changed message in the template file mappings.tt and confirm it makes sense.
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit f60bff7aa0e3ca932f5572b7837d912b8681ca2a
Author: Alex Arnaud <alex.arnaud at biblibre.com>
Date: Tue Mar 13 15:09:22 2018 +0000
Bug 19583: Remove use of C4::AuthoritiesMarc
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 141bb554b2ffa036350bd0ab27d2520598f5ba9d
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Mar 12 15:56:45 2018 +0000
Bug 19582: (follow-up) get params in correct order
We were ordering the values out of sync with the order of the mathclist
param and so causing 'entire record' and 'all headings' to be reversed
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 3b2ac332f901e1eafdfd33bc4210bbae01a1406e
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Nov 7 01:24:56 2017 +0000
Bug 19582: Unit tests
Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
commit 7a1a9c92f190661264acc261d3f2e891fb107b6e
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Nov 6 17:14:34 2017 +0000
Bug 19582: Use compat routines for searching authorities in auth_finder.pl
To test:
1 - Enable Zebra
2 - Perform an auth search
3 - note results
4 - Enable ES
5 - Repeat search, note (likely) diff results
6 - Open a record in cataloging and use the button to launch auth search
7 - Perform same search as above, note results match for eiher engine
selected
8 - NOTE: Disbale sorting for ES search - this will be dealt with in
another report
Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
-----------------------------------------------------------------------
Summary of changes:
C4/Accounts.pm | 15 ++++--
C4/Letters.pm | 26 ++++++++++-
C4/Search.pm | 2 +-
C4/Utils/DataTables/Members.pm | 2 +-
Koha/Plugins/Base.pm | 43 ++++++++++++++++-
Koha/SearchEngine/Elasticsearch/QueryBuilder.pm | 5 +-
Koha/SearchEngine/Elasticsearch/Search.pm | 8 +---
.../Template/Plugin/Remove_MARC_punctuation.pm | 22 +++++----
acqui/parcel.pl | 4 +-
acqui/z3950_search.pl | 8 +++-
authorities/auth_finder.pl | 19 ++++++--
.../prog/en/includes/auth-finder-search.inc | 2 +-
.../prog/en/includes/cateditor-ui.inc | 7 +++
.../en/includes/circ-patron-search-results.inc | 13 ++++--
.../prog/en/includes/delimiter_text.inc | 8 ++++
.../prog/en/includes/reports-toolbar.inc | 3 +-
.../intranet-tmpl/prog/en/modules/acqui/invoice.tt | 2 +-
.../prog/en/modules/acqui/invoices.tt | 8 ++--
.../intranet-tmpl/prog/en/modules/acqui/parcel.tt | 12 +++--
.../prog/en/modules/acqui/z3950_search.tt | 2 +
.../admin/searchengine/elasticsearch/mappings.tt | 4 +-
.../en/modules/course_reserves/add_items-step2.tt | 2 +-
.../prog/en/modules/members/memberentrygen.tt | 12 -----
.../prog/en/modules/reserve/request.tt | 5 ++
.../prog/en/modules/tools/modborrowers.tt | 21 ++++++---
.../prog/en/modules/tools/quotes-upload.tt | 14 +++---
koha-tmpl/intranet-tmpl/prog/js/members.js | 7 +++
.../opac-tmpl/bootstrap/en/includes/masthead.inc | 4 +-
.../bootstrap/en/modules/opac-advsearch.tt | 4 +-
koha-tmpl/opac-tmpl/bootstrap/js/basket.js | 4 +-
misc/cronjobs/cleanup_database.pl | 3 --
opac/opac-main.pl | 4 --
opac/opac-search.pl | 3 --
reserve/request.pl | 11 ++---
t/Koha/Plugin/Test.pm | 10 ++++
t/db_dependent/Accounts.t | 49 +++++++++++++++++++-
t/db_dependent/Circulation.t | 4 +-
.../Koha/SearchEngine/Elasticsearch/QueryBuilder.t | 28 ++++++++++-
.../Koha_SearchEngine_Elasticsearch_Search.t | 25 +++++++++-
t/db_dependent/Letters/TemplateToolkit.t | 42 ++++++++++++++++-
t/db_dependent/Patron/Borrower_PrevCheckout.t | 3 +-
t/db_dependent/Plugins.t | 30 +++++++++++-
tools/batchMod.pl | 1 +
tools/modborrowers.pl | 3 --
44 files changed, 394 insertions(+), 110 deletions(-)
copy cataloguing/plugin_launcher.pl => Koha/Template/Plugin/Remove_MARC_punctuation.pm (71%)
mode change 100755 => 100644
create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/delimiter_text.inc
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list