[koha-commits] main Koha release repository branch master updated. v18.05.00-rc1-16-g1cb0147

Thu May 17 17:26:37 CEST 2018

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  1cb0147affce54f19004173456ff2f8027767b30 (commit)
       via  710c0e5df644731cee15f91b4ebc62924f7f85c9 (commit)
       via  45b6ea652797288d2910b121e3009696c847791d (commit)
      from  c1c7f5ede60ef63f5da969ff8495675248e50102 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 1cb0147affce54f19004173456ff2f8027767b30
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date:   Thu Jan 11 09:44:08 2018 -0500

    Bug 18856: (QA follow-up) Rename method to avoid confusion

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Hmm. I would have liked the opac parameter even better ;)

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 710c0e5df644731cee15f91b4ebc62924f7f85c9
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Jan 10 16:49:33 2018 -0300

    Bug 18856: Don't show cancel option for waiting holds in OPAC

    This is the alternative patch of Kyle's
    """
    If a hold is 'waiting' for the patron to collect then the patron should
    be prevented from cancelling the hold via their account in the opac.
    If a patron tries to cancel the hold, Koha will give an 'are you sure'
    alert and when you click Yes the page just refreshes and the hold
    remains.
    Staff can cancel the hold from the staff interface but they can then
    action the waiting hold.
    I think therefore that it is correct behaviour that a patron cannot
    cancel a hold when it reaches waiting state via the opac but it would be
    useful to either have a warning to prevent the cancellation or a useful
    message when they attempt to do so.

    The template was using a method that tells Koha if *staff* can cancel a
    hold,
    instead of patron.

    Test Plan:
    1) Set up a waiting hold
    2) Try to cancel it from the opac
    3) Note you cannot
    4) Apply this patch
    5) Reload the page
    6) Note the cancel button has disappeared for found holds
    """

    It sounds better to keep the ->is_cancelable method, for readability

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

commit 45b6ea652797288d2910b121e3009696c847791d
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Tue Apr 17 07:55:52 2018 +0200

    Bug 19862: Turn off RoutingListAddReserves on new installations

    The RoutingListAddReserves feature currently doesn't work as
    expected (see bug 2894) and should be turned off for new
    installations until properly fixed.

    To test:
    - Run the web installer
    - Confirm that RoutingListAddReserves is set to "Don't place"

    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Hold.pm                                          |   14 ++++++--------
 installer/data/mysql/sysprefs.sql                     |    2 +-
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt |    6 +++---
 t/db_dependent/Hold.t                                 |    8 ++++----
 4 files changed, 14 insertions(+), 16 deletions(-)

hooks/post-receive
-- 
main Koha release repository