[koha-commits] main Koha release repository branch master updated. v18.05.00-16-g0895ead

Tue May 29 16:45:37 CEST 2018

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  0895eadd676ca477b2064d30015eed2ec454f4d9 (commit)
       via  c48f3cd73c09d135a4c18b36d31b57382f9c2350 (commit)
       via  69f74104d5e705b95d8207e61fedfbd71ca2e673 (commit)
       via  da6fde55dd2f4e11f73490d6502483748666d1e7 (commit)
       via  60b0d9439bf45519a3b64750831c7905ba92e21e (commit)
       via  5486670aca2773b8205622e48058f34ec4827b74 (commit)
       via  db5628e7710325766e25648615c772d200348116 (commit)
       via  08c731f6da8ccb470e473bd089bc7e27289632ee (commit)
       via  76aa349ebe9dcaa84e667db770216a306f21ecf1 (commit)
       via  62595687c19d5a752b6c3e02e85fd94834c72e31 (commit)
       via  6773a5e3006de18d4b9eb94697abb7fccafe08c3 (commit)
       via  3b5599f00e2cfa3d6804c1bbcb0f353fbb837ab3 (commit)
       via  82a4f23ee3a05d057047d0fde8b1b74cb4dfd6ce (commit)
       via  96070c9ea431063052f8c360f52032db6568c139 (commit)
       via  b64262af2a237505c775739e7cbd2465637498ec (commit)
      from  c320e7e01ccaba92db74fb62caefdfaa1e06006f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0895eadd676ca477b2064d30015eed2ec454f4d9
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date:   Mon May 21 14:56:58 2018 -0400

    Bug 20798: Client side validation for for fund selection prevents adding only some records to a basket

    Bug 19453 "fixed" the fund validation that never actually worked. This validation should be removed altogether instead. It is overly simplistic and simply checks to see if each record in the batch has a fund selected regardless of whether that record will be imported or not.

    In addition, the code completely ignores items generated by MarcItemFieldsToOrder such that even if items on that page have a fund selected, the javascript forces the librarian to make a selection from the left-hand fund pulldown even though it will not be used.

    Considering this bad validation is basically 'new' as it never worked before, the most sensible course of action would be to 'undo' the change and remove the validation.

    Test Plan:
    1) Add records to a basket from an import batch
    2) Select only some of those items in the batch
    3) Note Koha will not let you import them unless you set funds for *all*
       records in the batch
    4) Apply this patch
    5) Note Koha no longer forces a budget to be selected in the pulldown

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    https://bugs.koha-community.org/show_bug.cgi?id=20789
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit c48f3cd73c09d135a4c18b36d31b57382f9c2350
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Sun May 13 01:44:28 2018 +0000

    Bug 20761: Fix some js includes in rancor

    To test:
    1 - Load the advanced cataloging editor
    2 - Inspect the network tab in your browser (F12)
    3 - Note failure to load 'cataloging_.js'
    4 - Note some other scripts don't have versioning
    5 - Apply patch
    6 - Reload page
    7 - Note cataloging.js loads with version number
    8 - Note more js files have versioning

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 69f74104d5e705b95d8207e61fedfbd71ca2e673
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Wed May 2 16:13:20 2018 +0200

    Bug 20696: Fix a few ugly "eq undef" comparisons in Search.pm

    Comparisons like $a eq undef should normally raise a warning like:
        Use of uninitialized value in string eq at ...
    But unfortunately we still suppress warnings here and there.

    Test plan:
    [1] Just read this patch and confirm the small changes.
    [2] Git grep on "eq undef" and do not find other occurrences.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Passes test plan and QA tools. Searching works correctly.

    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit da6fde55dd2f4e11f73490d6502483748666d1e7
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu May 24 16:33:19 2018 -0300

    Bug 20818: Add missing QA Manager entry in 18.05.00 release notes

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 60b0d9439bf45519a3b64750831c7905ba92e21e
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri May 18 14:01:09 2018 +0000

    Bug 20781: Set a minimum enrollemnt period 'in months' of 1

    To test:
     1 - Browse to Admin->Patron Categories
     2 - Click '+ New category'
     3 - Enter data as required, however, enter 0 in 'Enrolment period' ->
    'in months'
     4 - Save
     5 - View the list of categories, the new category has 'Enrolment period'
    = 'until'
     6 - Create a patron in this category, note their dateexipry is
    '0000-00-00'
     7 - Search for them
     8 - internal server error
     9 - Delete that patron
    10 - Apply patch
    11 - Edit the category, note you cannot save with 0 months
    12 - Set 1 month and save
    13 - Create a patron in this cateogry
    14 - Note they have a valid dateexpiry
    15 - Search for them
    16 - All works
    17 - Create a new category and verify you cannot add with 0 months

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 5486670aca2773b8205622e48058f34ec4827b74
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon May 14 14:04:01 2018 -0300

    Bug 20767: Display a stack trace when a method is not covered by tests

    When a method is not allowed yet (not covered by tests), developers get
    an error the is not really useful: "The method XXX is not covered by
    tests!"
    It would be more useful to have a stack trace in order to know where
    this error come from.

    Test plan:
    Modify some code to display this stack trace and confirm it makes sense
    to have it, i.e. it will make debug easier

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit db5628e7710325766e25648615c772d200348116
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Wed May 16 02:45:02 2018 +0200

    Bug 3886: Fix mismatch of required permissions for printing slips

    - Print summary (summary-print.pl)
    - Print quick slip (printslip.pl)
    - Print slip (printslip.pl)
    - Print overdues (print_overdues.pl)

    Perl scripts all require circulate_remaining_permissions, while
    in the template we were checking for edit_borrowers.

    Now the print pull down will only be visible if the patron has
    circulate or circulate_remaining_permissions.

    To test:
    - Verify that printing the listed slips works for staff users
      with either circulate or circulate_remaining_permissions
      and without edit_borrowers.

    Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 08c731f6da8ccb470e473bd089bc7e27289632ee
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Thu May 17 11:38:39 2018 +0000

    Bug 20774: Trivial HTML error in itemslost.tt

    This patch makes a minor correction to the markup of the lost items
    report template.

    To test, apply the patch and run the lost items report with parameters
    which will return results. The report results should look correct, and
    the page should validate with no relevant errors.

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 76aa349ebe9dcaa84e667db770216a306f21ecf1
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Thu May 10 17:54:38 2018 +0000

    Bug 20752: Fix capitalization on the files tab for patron files

    - Activate EnableBorrowerFiles
    - Go to any patron account in staff
    - Go to the files tab
    - Check that strings on the page ar all properly capitalized
      - button
      - legend on section

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 62595687c19d5a752b6c3e02e85fd94834c72e31
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Fri May 18 05:39:19 2018 +0000

    Bug 20791: Correct capitalization on 'Notices & slips' page

    - Standardizes spelling to 'Notices & slips'

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 6773a5e3006de18d4b9eb94697abb7fccafe08c3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon May 28 11:40:20 2018 -0300

    Bug 20827: Display Fund's owner name when selected

    When a fund is created or edited and does not have a owner yet, the
    name of the patron will not be displayed when selected.

    The HTML element the JS code expects is not present in the DOM.

    Test plan:
    - Create a fund, set a owner
    - remove the owner, edit, etc.
    - Save
    - Edit again
    Make sure it works as expected.

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 3b5599f00e2cfa3d6804c1bbcb0f353fbb837ab3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Apr 24 15:38:41 2018 -0300

    Bug 20652: Fix result sorting after search on limit only

    1 chomp was missing, spaces were replaced with %20
    This patch adds extra chomps, but it does not hurt

    Test plan:
    Advanced Search
    Choose an Item type (do not enter any other search limits)
    Search
    Click on Sort (it doesn't appear to matter what you sort on)

    Signed-off-by: Pierre-Luc Lapointe <pierreluc.lapointe at inLibro.com>
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 82a4f23ee3a05d057047d0fde8b1b74cb4dfd6ce
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon May 28 15:11:09 2018 -0300

    Bug 20822: (bug 18789 follow-up) Fix HOLD_SLIP

    Caused by
      commit ab47e46ea0ade643b308a8b00708d57995c57050
      Bug 18789: Pass a Koha::Patron object from returns.pl

    circ/returns.pl does not send a $patron Koha::Patron object to the
    template in case print_slip is set

    Test plan:
    Confirm a hold and print the slip

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 96070c9ea431063052f8c360f52032db6568c139
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon May 28 11:24:43 2018 -0300

    Bug 20825: (bug 19943 follow-up) call notforloan on itemtype instead of biblioitem

    On bug 19943:
     -        elsif ($biblioitem->{'notforloan'} == 1){
     +        elsif ($biblioitem->notforloan == 1){

    The biblioitems table does not contain a notforloan column, this comes
    from the item type.

    This bug only appears when item type is defined at biblio level
    (item-level_itypes=0)

    Test plan:
    Set item-level_itypes = biblio
    Check an item out

    Without this patch it explodes with
    "The method notforloan is not covered by tests!"

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    I reproduced the error condition and verified the tests failed without
    this patch. After this patch is applied, tests pass and checkout
    succeeds.

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit b64262af2a237505c775739e7cbd2465637498ec
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon May 28 11:20:32 2018 -0300

    Bug 20825: Add regression tests

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm                                  |   17 +++++----
 C4/Search.pm                                       |    7 ++--
 Koha/Object.pm                                     |    6 +++-
 Koha/Objects.pm                                    |   10 +++++-
 circ/returns.pl                                    |    2 +-
 .../prog/en/includes/cateditor-ui.inc              |    8 ++---
 .../prog/en/includes/members-toolbar.inc           |    4 ++-
 .../prog/en/modules/acqui/addorderiso2709.tt       |   14 --------
 .../prog/en/modules/admin/aqbudgets.tt             |    4 ++-
 .../prog/en/modules/catalogue/results.tt           |    8 ++---
 .../prog/en/modules/cataloguing/editor.tt          |    4 +--
 .../intranet-tmpl/prog/en/modules/circ/returns.tt  |    2 +-
 .../intranet-tmpl/prog/en/modules/members/files.tt |    4 +--
 .../prog/en/modules/reports/itemslost.tt           |    2 +-
 .../intranet-tmpl/prog/en/modules/tools/letter.tt  |    4 +--
 koha-tmpl/intranet-tmpl/prog/js/categories.js      |    3 +-
 misc/release_notes/release_notes_18_05_00.html     |    6 ++--
 misc/release_notes/release_notes_18_05_00.md       |    2 +-
 t/db_dependent/Circulation.t                       |   36 +++++++++++++++++++-
 t/db_dependent/Koha/Objects.t                      |   27 +++++++++++----
 20 files changed, 112 insertions(+), 58 deletions(-)

hooks/post-receive
-- 
main Koha release repository