From gitmaster at git.koha-community.org Thu Nov 1 20:22:37 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 01 Nov 2018 19:22:37 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v18.05.00-1254-g5ea877f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 5ea877f6cba299373e0ebb9c59f8797baba98bec (commit) via 5e2b67d8c5982029c427c75930bfec6a4395dd9f (commit) via 515ed462cff54afd0725471c977d437fbeb54aa4 (commit) via 9d78af26d96dd356a1ca05199c0fec20cd5077e1 (commit) via b5c456479da6a1033f9a697ca1bcf4295920aeb1 (commit) via 2d3ec5e6258232378c7c8dddf3f8bf1ef8471696 (commit) via ea19eee02ea2b6ecf680d7bcc1db788309d802e5 (commit) via c98c1d73786699322f247b8bd2167bb08014bf52 (commit) via 7736b5c2e32975502fa6198b5f7ec64feb7b8ffc (commit) via 8ceba54c8dcfd9b598375b8af432c0111ec63d04 (commit) from 8f6bd9415096924e2648a1a0a5866733f6839760 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5ea877f6cba299373e0ebb9c59f8797baba98bec Author: Magnus Enger Date: Tue Oct 16 21:25:43 2018 +0200 Bug 21585: Ignore missing firstname in ILL requests table To test: - Make sure you have a patron with just a surname and no firstname - Create an ILL request so that the name of this patron shows up in the Patron column of the ILL requests table - Before the patch, the name will display as "null Surname" - Apply the patch - Reload the ILL requests page - The name should now display as just "Surname" - Sign ye merrily off Signed-off-by: Andrew Isherwood Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens commit 5e2b67d8c5982029c427c75930bfec6a4395dd9f Author: Jonathan Druart Date: Mon Oct 29 18:16:19 2018 -0300 Bug 21717: Fix generation of real's values With strict SQL modes we now have TestBuilder tests that fail randomly with: Out of range value for column 'tax_rate_on_receiving' Out of range value for column 'discount' We are trying to insert a value that is too high for the type defined at DB level. It happens for discount when a value > 100 is generated. The datatype is float(6,4). From the MySQL Doc: """ MySQL permits a nonstandard syntax: FLOAT(M,D) or REAL(M,D) or DOUBLE PRECISION(M,D). Here, (M,D) means than values can be stored with up to M digits in total, of which D digits may be after the decimal point. """ So float(6,4) does not allow 100. To recreate easily the issue: use t::lib::TestBuilder; my $builder = t::lib::TestBuilder->new; $builder->build( { source => 'Aqorder', value => { discount => 100 } } )->{discount}; To make sure this patch fixes the issue you can use this script: use Modern::Perl; use t::lib::TestBuilder; my $builder = t::lib::TestBuilder->new; my ( $real, $i ) = ( 0, 0 ); while ( $real < 100 ) { $real = $builder->_gen_real( { info => { size => [ 6, 4 ] } } ); warn $i++; } warn "$i - $real"; Test plan: 0/ Does not apply this patch 1/ Run the snippet above 2/ Confirm that it fails quite quickly (constantly before 500 for me) 3/ Apply this patch 4/ Run again the script 5/ Confirm that it is stuck in an infinite loop 6/ CTRL-C :D QA Note: Other _gen_* subroutine may need a fix, but we will wait for them to fail TODO: 1. Add JS check to the interface to prevent the use to enter a value > 100 2. Allow '100' as a valid value for discount (?) Followed test plan, patch worked as described Signed-off-by: Alex Buckley Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens commit 515ed462cff54afd0725471c977d437fbeb54aa4 Author: Jonathan Druart Date: Tue Oct 16 14:52:25 2018 -0300 Bug 21556: Do not crash if a biblio is deleted twice To recreate: - Go to a bibliographic detail page - Delete it - Go back - Delete it again => Without this patch you will get a 500 Can't call method "holds" on an undefined value at /home/vagrant/kohaclone/C4/Biblio.pm line 406. => With this patch applied it will silently redirect you to the search form. Note: We could/should improve the behavior and display a message, but DelBiblio will need to be moved to Koha::Biblio->delete and other callers adjusted Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens commit 9d78af26d96dd356a1ca05199c0fec20cd5077e1 Author: David Cook Date: Fri Oct 12 01:53:22 2018 +0000 Bug 21556: Deleting same record twice leads to fatal software error If you delete a record, confirm the deletion, and try to delete the record and confirm it again befoe the first deletion completes, you'll generate a fatal software error. This patch unbinds the click handlers for the "Delete record" button after the deletion is confirmed and just before the Javascript processes the redirect to the next page in the process. To test: 1) You will need a bibliographic record that is able to be deleted 2) Click "Edit", then "Delete record", then "OK" 3) While the browser is reloading, click "Edit", then "Delete record", then "OK 4) Observe a fatal error such as "Internal server error" or 'Can't call method "holds" on an undefined value at /home/vagrant/kohaclone/C4/Biblio.pm line 406.' 5) Apply the patch 6) Run "restart_all" on kohadevbox (or otherwise restart Plack if running Plack) 7) Navigate to another bibliographic record that is able to be deleted 8) Click "Edit", then "Delete record", then "OK" 9) While the browser is reloading, click "Edit", then "Delete record" 10) Observe that no fatal software error is generated 11) You are redirected to http://localhost:8081/cgi-bin/koha/catalogue/search.pl (on kohadevbox) Signed-off-by: Pierre-Marc Thibault Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens commit b5c456479da6a1033f9a697ca1bcf4295920aeb1 Author: Nick Clemens Date: Tue Oct 30 11:59:26 2018 +0000 Bug 21725: Use full statement in HAVING rather than constructed column To test: 1 - prove -v t/db_dpendent/Acquisition/GetBasketsInfosByBookseller.t 2 - Apply patch 3 - prove -v t/db_dpendent/Acquisition/GetBasketsInfosByBookseller.t 4 - It passes 5 - Have some open/closed and some fully and not full received baskets 6 - View a vendor and confirm baskets are shwn as expected 7 - Check 'Show all baskets' shows all baskets Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Note sure this is the best thing but it fixes the issue Signed-off-by: Nick Clemens commit 2d3ec5e6258232378c7c8dddf3f8bf1ef8471696 Author: Nick Clemens Date: Thu Nov 1 19:03:01 2018 +0000 Bug 21682: DBRev 18.06.00.048 Signed-off-by: Nick Clemens commit ea19eee02ea2b6ecf680d7bcc1db788309d802e5 Author: Jonathan Druart Date: Wed Oct 31 15:36:21 2018 -0300 Bug 21682: Add update DB entry for existing installs Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens commit c98c1d73786699322f247b8bd2167bb08014bf52 Author: Martin Renvoize Date: Fri Oct 26 11:55:54 2018 +0100 Bug 21682: Corrections for strict sql in stockrotationrotas Test Plan: 1) Ensure you're database is prior to version 18.06.00.040 2) Ensure 'strict_sql_modes' is enabled 3) Run updatedatabase 4) See no errors during upgrade 5) Run a fresh install 6) Note no errors during database installation Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens commit 7736b5c2e32975502fa6198b5f7ec64feb7b8ffc Author: Nick Clemens Date: Tue Oct 23 12:30:25 2018 +0000 Bug 21476: Fix HTML5 media from playing in the OPAC - incorrect filters This patch makes a correction to a template filter to prevent incorrectly-encoded HTML in media source links which were preventing media from embedding correctly in the OPAC. To test, apply the patch and enable the HTML5MediaEnabled and HTML5MediaYouTube system preferences. - Edit a record to include links to videos in 856$u. For example: - https://www.youtube.com/watch?v=grTwH6Evdfc - https://archive.org/download/POPEYEMeetsSindbadTheSailor1936/POPEYE%20meets%20Sindbad%20The%20Sailor%20%281936%29.ogv View the record in the OPAC and confirm that the videos display in the "Play media" tab and that they play correctly. Tested and works as described, also matches the intranet code. Signed-off-by: Alex Buckley Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens commit 8ceba54c8dcfd9b598375b8af432c0111ec63d04 Author: Nick Clemens Date: Wed Oct 31 12:18:58 2018 +0000 Bug 21742: Fix YouTube variable propagation The loop to find all media has an $isyoutube variable. This was declared outside the loop and never reset. Once a YouTube video was encountered all subsequent videos were considered as YouTube. This patch reduces the scope of the variable and resets per loop. To test: 1 - Enable HTML5Media and HTML5MediaYouTube 2 - Add 856$u to record for a youtube vido and a pdf (sample record attached to bug) 3 - View the record, the Play media tab has two video boxes 4 - Play the second, it fails 5 - Apply patch 6 - View record, Play media should include only one video link Signed-off-by: Devinim Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 8 +++++++- C4/Biblio.pm | 5 ++++- C4/HTML5Media.pm | 2 +- Koha.pm | 2 +- installer/data/mysql/kohastructure.sql | 4 ++-- installer/data/mysql/updatedatabase.pl | 9 ++++++++- .../intranet-tmpl/prog/en/modules/ill/ill-requests.tt | 11 +++++++---- koha-tmpl/intranet-tmpl/prog/js/catalog.js | 1 + koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +- t/db_dependent/Biblio.t | 13 ++++++++++++- t/lib/TestBuilder.pm | 2 +- 11 files changed, 45 insertions(+), 14 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Nov 2 11:55:52 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 02 Nov 2018 10:55:52 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v18.05.00-1284-g1a0172a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 1a0172a253e5432e5eef862768aaacb3463501f2 (commit) via 84857caaef467b7c3dfa82404143de8dc41fc858 (commit) via 9783773ada4dec115342a4f8f16b29eb5b98cc2f (commit) via e87fa069dc3d10284a2bd31b7c7913132fed5d06 (commit) via 60ca17c616e6026fbd271fb3f99473f3ef7edf00 (commit) via 7910a530b85b6ee42307d41cba57b95ced2aca27 (commit) via 741f17e916a3f64d71b55fd87065136307e3bae7 (commit) via 7a1641cd41bf51a992cb07dff58d320c49f15b68 (commit) via 70651422a7517338a68e22321d9918757746ef33 (commit) via e1b5fa657de843a177fb4bf57947a1376152d021 (commit) via e31e0e5daa764892dfb7878696cb1159d27c3a1c (commit) via 8b7a7a2bb34609c402117933625e06e1b8e2cd69 (commit) via 5e4e10c4ca558180137bf5a4ff5a68495efa0ec7 (commit) via 12ed04eabb32cb957acd9f88d94ccada0ac09d07 (commit) via 32c4dbfd6814f01ae2b430e88f13b89bd374f34f (commit) via ce6a27b0d287f14eb0d515db6b2a5e1f5d278381 (commit) via f947655862abc813df685d51edbfbe7b34027178 (commit) via 4ffd2d3b347072f6422adb98608859264ba269d6 (commit) via 8e8f26f2cb2195f1e07136898320875dc055aad4 (commit) via 3fb44a8bd63663fb7c4d93e85c30d58d9b2ce08f (commit) via f4f995a4e690b53504561294655e548a53994a81 (commit) via 1c8952a36b3b810b7bc290a7eb7cc85cc766ed61 (commit) via 7085772e8de25fe49b77555e318cc03ab6bcb33b (commit) via 433fc3f120cfa08fda1dd55a7db721bdf3bf1e9b (commit) via ca3c2b0b639f571981570d4a342c74a1ca026996 (commit) via ebf0336059635f2ea13c7f626b794e92e4980f46 (commit) via 8302a5d6ab287e37b9927efad6401c00c1089869 (commit) via 4bd78f7443ac108eab35263b89bb610e6675d8c2 (commit) via 966e6351760d08825b79a5b7c96af167cf8d9267 (commit) via 9df62cf1caed793f883122eca332c409eddce710 (commit) from 5ea877f6cba299373e0ebb9c59f8797baba98bec (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1a0172a253e5432e5eef862768aaacb3463501f2 Author: Nick Clemens Date: Fri Nov 2 10:41:15 2018 +0000 Bug 20968: (RM follow-up) Add missing filter Signed-off-by: Nick Clemens commit 84857caaef467b7c3dfa82404143de8dc41fc858 Author: Julian Maurice Date: Fri Oct 5 15:18:59 2018 +0200 Bug 21501: Remove dead code from course reserves module search_on parameter is not used in any templates so course-reserves.pl can be simplified a bit Test plan: 1. Go to course reserves module and verify that it is still working 2. `git grep search_on` should return nothing Signed-off-by: Pierre-Marc Thibault Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens commit 9783773ada4dec115342a4f8f16b29eb5b98cc2f Author: Andrew Isherwood Date: Fri Jun 29 09:23:38 2018 +0100 Bug 20968: (follow-up) Replace tabs with spaces Signed-off-by: Stephen Graham Signed-off-by: Kyle M Hall Signed-off-by: Nick Clemens commit e87fa069dc3d10284a2bd31b7c7913132fed5d06 Author: Kyle M Hall Date: Wed Jun 27 13:21:53 2018 -0400 Bug 20968: Rename method get_intranet_catalog_toolbar_button to intranet_catalog_biblio_enhancements_toolbar_button Signed-off-by: Stephen Graham Signed-off-by: Kyle M Hall Signed-off-by: Nick Clemens commit 60ca17c616e6026fbd271fb3f99473f3ef7edf00 Author: Kyle M Hall Date: Wed Jun 27 17:13:37 2018 +0000 Bug 20968: Add unit tests Signed-off-by: Stephen Graham Signed-off-by: Kyle M Hall Signed-off-by: Nick Clemens commit 7910a530b85b6ee42307d41cba57b95ced2aca27 Author: Andrew Isherwood Date: Wed Jun 27 17:13:27 2018 +0100 Bug 20968: (follow-up) Respond to feedback This patch: - Removes the unecessary testing for intranet_catalog_biblio_enhancements method in detail.pl - Renames get_toolbar_button to get_intranet_catalog_toolbar_button Signed-off-by: Stephen Graham Signed-off-by: Kyle M Hall Signed-off-by: Nick Clemens commit 741f17e916a3f64d71b55fd87065136307e3bae7 Author: Andrew Isherwood Date: Wed Jun 20 12:47:10 2018 +0100 Bug 20968: Add hooks into cat-toolbar.inc to display buttons This commit adds hooks into cat-toolbar.inc to allow the display of arbitrary buttons as supplied by plugins within the intranet_catalog_biblio_enhancements class that provide the method get_toolbar_button To test: 1) Download the plugin from https://github.com/PTFS-Europe/cla-permissions-check-plugin 2) Follow the installation instructions from: https://github.com/PTFS-Europe/cla-permissions-check-plugin 3) TEST: Observe that the "CLA Check Permissions" button takes the user to the Check Permissions page and a modal displays containing the results of the query 4) Remove the API key from the plugin "Configuration" page 5) TEST: Ensure that the "CLA Check Permissions" button takes the user to the Check Permissions page and message displays informing the user that "Did not receive required request parameters" https://bugs.koha-community.org/show_bug.cgi?id=20968 Signed-off-by: Stephen Graham Signed-off-by: Kyle M Hall Signed-off-by: Nick Clemens commit 7a1641cd41bf51a992cb07dff58d320c49f15b68 Author: Nick Clemens Date: Fri Nov 2 10:31:47 2018 +0000 Bug 14385: DBRev 18.06.00.050 Signed-off-by: Nick Clemens commit 70651422a7517338a68e22321d9918757746ef33 Author: Marcel de Rooy Date: Fri Oct 12 07:54:24 2018 +0200 Bug 14385: (QA follow-up) Additional changes and fixes [1] searchResults: second my $interface can be removed: unused [2] call of getitemtypeimagelocation on L2119 needs interface key [3] ISBDdetail: No need to find patron again (line 182 vs 84) [4] opac-search: No need to find patron twice (657 and 631) [5] tabs on line 2220 of C4/Search.pm (qa tools warn) [6] Ugly hack to overcome "Undefined subroutine &C4::Items::ModZebra" by loading C4::Items before C4::Biblio when running tests Koha/BiblioUtils/Iterator.t and Labels/t_Label.t. This is a more general problem that needs attention somewhere else. It seems that Biblio.pm is one of the suspects. [7] This patch set makes Search.t crash/fail with me. Note that without these patches Search.t still passed! Why o why.. A little debugging pointed me to a missing MPL branch (aarg). Adding the simple test on the result of Libraries->find in C4::Biblio::GetAuthorisedValueDesc made the test continue. [8] Resolve: Variable "$borcat" is not available at opac-detail.pl line 246 Lexical $borcat cannot be used in sub searchAgain in opac-detail.pl under Plack. Must be defined with our (or passed as argument). [9] Resolve crash on TWO serious typos in opac-basket on ONE line: Koha::Patron->find({ borrowernumber -> $borrowernumber }) Yeah: find is in Koha::Patrons and we need => !! No need to pass a hash to find method btw for a pk value. [10] Serious bugfixing here. Add List::Util to opac-basket. Can't locate object method "none" via package "1". You can't test everything :) Signed-off-by: Marcel de Rooy After this longer list I renamed Final to Additional in the patch title :) Signed-off-by: Nick Clemens commit e1b5fa657de843a177fb4bf57947a1376152d021 Author: Mark Tompsett Date: Mon Mar 5 20:11:52 2018 +0000 Bug 14385: Squash of a lot of patches rebased - Added missing GetHiddenItems parameter change case Without this prove t had a failure. - Always use mocks, not set_preference - Tweaks so t/db_dependent/00-strict.t passes There was a typo botcat vs borcat and borrowernumber was never defined. Grabbing from userenv, like other code does. - Tweak t/db_dependent/Items.t to fully test changes This will test all the if structures fully in GetHiddenItemnumbers. prove t/db_dependent/Items.t - Tweak borrower category code $borrower->{categorycode} on a Koha::Patron is not the same as $borrower->categorycode. Fixed error. - Search was returning URLS for wrong interface There was one search context place wrong. Changed it to $is_opac as the logic for setting $is_opac was modified correctly. - Corrected issues with category code. When a user isn't logged in, $borrower is undef and causes error when determining category code. Added conditional check. - Properly trigger all changes in C4/Search.pm - Fix QA Test tool failures C4/Search.pm had some tabs. - Add some commenting to make sense of logic - Refactor EmbedItemsInMarcBiblio parameters to hashref - Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call. prove t/db_dependent/Items.t - Add missing test to trigger Koha/BiblioUtils/Iterator change - Add borrower category overrides These files generally add borcat parameter to GetMarcBiblio. Others might include correction of filtering of items (opac-basket), or a comment as to why no changes were done (opac-search). In the case of opac-search, correcting the first FIXME will likely correct the OpacHiddenItems issues on tags. As such, that is beyond this bugs scope. Some code had loop optimizations and fixes made, like a 'next unless $record' when the biblio shouldn't even be in the list. - Modify opac-ISBDdetail and opac-MARCdetail Both files had similar logic. They were rearranged and optimized, so that both files would have practically identical initial blocks of code. Optimizations were possible, because GetMarcBiblio returns a filtered record, so that there is no double call (once in the opac-### file and once in GetMarcBiblio) to GetHiddenItemnumbers. - Fix hiding in opac-tags opac/opac-tags.pl was not properly hiding. There is currently one known bug associated with tags left. If you have two biblios tagged by different people with the same tag, the opac-search will show the one you tagged that is supposed to be hidden, because tag searches work differently than regular searches. This is beyond the scope of this bug. See the FIXME's in opac/opac-search.pl - Trigger the C4::ILSDI::Services changes prove t/db_dependent/ILSDI_Services.t - Added missing 'my' - Test C4/Labels/Label.pm changes - Improve C4::Record::marcrecord2csv test cases - Corrected opac-details searchResult call - Fix breaking issues constraint in ITerator test - Fix ILSDI_Services test when clubs with branch exist - Rebased again! - Rebased t/db_dependent/Items.t conflict. The test plan is in comment #112 last I checked. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit e31e0e5daa764892dfb7878696cb1159d27c3a1c Author: Aleisha Amohia Date: Fri Sep 16 02:42:03 2016 +0000 Bug 14385: (follow-up) Changes to sysprefs.sql and atomicupdate Run updatedatabase.pl when testing Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Aleisha Amohia Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 8b7a7a2bb34609c402117933625e06e1b8e2cd69 Author: Mirko Tietgen Date: Tue Jul 19 17:45:43 2016 +0200 Bug 14385: (follow-up) C4::Borrowers not found GetMember is in C4::Members, not C4::Borrowers Signed-off-by: Claire Gravely Signed-off-by: Mark Tompsett Signed-off-by: Aleisha Amohia Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 5e4e10c4ca558180137bf5a4ff5a68495efa0ec7 Author: Chris Cormack Date: Thu Nov 6 10:34:18 2014 +1300 Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower categories Edit: Fixing merge conflicts in - t/db_dependent/Items.t - t/db_dependent/Search.t - C4/Search.pm Changes the API for calling GetHiddenItems and all the places in the code that call it. This is to allow borrower categories to be passed in. Adds an OpacHiddenItemsExceptions syspref to allow certain borrower categories to be able to see items, even if they are marked hidden by OpacHiddenItems To test: 1) Make two borrowers, one in a category that should see everything (ie Adult), and another in a category that should only see certain things (ie Adult - exceptions) 2) Add the borrower that can see everything (the Adult) to OpacHiddenItemsExceptions 3) To the OpacHiddenItems syspref, add an item type (ensure that you have some records that fall under this type in your library). 4) Log in as the borrower that should only see certain things (Adult - exception) 5) Do a search, filtered to show records which are the item type that you specified in the OpacHiddenItems syspref. No records should show for this borrower as this item type is hidden to them. 6) Log in as the borrower that should see everything (Adult) 7) Do the same search. There should be results from this search, as this borrower category has been specified as an exception to the hidden items Signed-off-by: Claire Gravely Signed-off-by: Mark Tompsett Signed-off-by: Aleisha Amohia Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 12ed04eabb32cb957acd9f88d94ccada0ac09d07 Author: Nick Clemens Date: Wed Oct 24 01:17:51 2018 +0000 Bug 21640: Enable output to STDOUT for Itiva outbound script To test: 1 - Enable the TalkingTechItivaPhoneNotification 2 - Copy 'HOLD' notice 'email' transport to the phone section 3 - Enable EnhancedMessagingPreferences 4 - Find a patron and enable 'phone' for the 'Hold filled' notice Note: You might not be able to do this straightaway, bug 21639 If the phone box has a '-' and not a checkbox: sudo koha-mysql kohadev INSERT INTO message_transports (message_attribute_id,message_transport_type,is_digest,letter_module,letter_code) VALUES (4,'phone',0,'reserves','HOLD'); 5 - Place a hold for the patron 6 - Check it in and confirm the hold to set it waiting 7 - sudo koha-shell kohadev 8 - perl misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl --type=RESERVE -w 0 -v 9 - Note the Output says it will be on STDOUT, but nothing is output 10 - Apply patch 11 - repeat 12 - Hold info is output to command line Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 32c4dbfd6814f01ae2b430e88f13b89bd374f34f Author: Jonathan Druart Date: Thu Oct 18 19:27:21 2018 -0300 Bug 21606: [sql_modes] Fix matching rules insert Fix: Incorrect integer value: '' for column 'offset' Incorrect integer value: '' for column 'score' Test plan: Add/edit matching rules Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit ce6a27b0d287f14eb0d515db6b2a5e1f5d278381 Author: Andrew Isherwood Date: Wed Oct 31 15:26:27 2018 +0000 Bug 20996: (QA follow-up) Fix pod Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens commit f947655862abc813df685d51edbfbe7b34027178 Author: Andrew Isherwood Date: Wed Oct 31 15:25:17 2018 +0000 Bug 20996: (follow-up) Fix merge problems Merge conflicts resolved Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens commit 4ffd2d3b347072f6422adb98608859264ba269d6 Author: Andrew Isherwood Date: Fri Sep 28 13:44:16 2018 +0100 Bug 20996: (follow-up) Fix column name expectation This bug changes how request metadata is obtained. Previously the appropriate backend's metadata function would return it. For at least the FreeForm backend, the metadata property names we title cased. The datatable JS was expecting this and breaks with the new metadata getting which is performed in the API controller, which just returns the property names as they appear in the DB. This patch changes the expectation of the JS to match what's coming back from the API Signed-off-by: Magnus Enger Tested by repeatedly loading the API-call http://intranet/api/v1/illrequests?embed=metadata,patron,capabilities,library in Chromium and watching the reported time to load the URL. There is a siginificant decrease in the time with the patches compared to the time it takes without the patches. I had some concerns along the way, but they have all been fixed. Signed-off-by: Magnus Enger Tested by repeatedly loading the API-call http://intranet/api/v1/illrequests?embed=metadata,patron,capabilities,library in Chromium and watching the reported time to load the URL. There is a siginificant decrease in the time with the patches compared to the time it takes without the patches. I had some concerns along the way, but they have all been fixed. Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens commit 8e8f26f2cb2195f1e07136898320875dc055aad4 Author: Andrew Isherwood Date: Tue Sep 25 15:19:53 2018 +0100 Bug 20996: (follow-up) Add to conf tpl Since we now require the block, we should add it to the config templates Signed-off-by: Magnus Enger Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens commit 3fb44a8bd63663fb7c4d93e85c30d58d9b2ce08f Author: Andrew Isherwood Date: Thu Jul 5 14:46:16 2018 +0100 Bug 20996: Further enhance performance We were immediately unblessing all request objects after retrieval then, at a later stage, re-instantiating each one so we could call methods on that. This was a very bad idea. We now preserve the objects for as long as we can. Signed-off-by: Magnus Enger Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens commit f4f995a4e690b53504561294655e548a53994a81 Author: Andrew Isherwood Date: Wed Jul 4 13:13:33 2018 +0100 Bug 20996: Fix unit tests - Remove unit tests relating to TO_JSON - Add tests for new explicit embedding - Modify tests relating to now deprecated brw_cat Signed-off-by: Magnus Enger Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens commit 1c8952a36b3b810b7bc290a7eb7cc85cc766ed61 Author: Andrew Isherwood Date: Tue Jul 3 11:36:58 2018 +0100 Bug 20996: Remove prefix use of borrower category This patch removes the potential use of borrower category as a ILL request ID prefix. It makes no sense. We provide the ability for a site to define a request prefix based on branch, there is no use case for using the borrower category. Add to this that the borrower for every request was being retrieved in order to get the category, it's a huge performance hit also. We also now require the block in the block and complain if it's not present. The request prefix should be defined in this block. This patch also improves the performance of the API request that returns all requests, optionally including additional data. It also deprecates the overloaded TO_JSON method and moves the request augmentation code into the API route's controller. It may be that we want to shift it out of there at some point, but it is fine where it is for now. Signed-off-by: Magnus Enger Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens commit 7085772e8de25fe49b77555e318cc03ab6bcb33b Author: Jonathan Druart Date: Thu Oct 18 18:10:19 2018 -0300 Bug 21604: Fix add/edit fund/budget [Strict SQL modes context] For insert aqbudgetperiods: Incorrect integer value: '' for column 'budget_period_id' For insert/update aqbudgets Incorrect integer value: '' for column 'budget_owner_id' Incorrect decimal value: '' for column 'budget_encumb' Test plan: Add/edit budgets and funds A good example of why we should use Koha::Object for all our objects Signed-off-by: Pierre-Marc Thibault Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 433fc3f120cfa08fda1dd55a7db721bdf3bf1e9b Author: Marcel de Rooy Date: Fri Nov 2 07:44:34 2018 +0100 Bug 21604: Add two trivial test cases Adding an id in AddBudgetPeriod and an empty string in AddBudget for budget_encumb. Test plan: Run Budgets.t with/without this patch in strict sql mode. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit ca3c2b0b639f571981570d4a342c74a1ca026996 Author: Martin Renvoize Date: Fri Oct 19 14:37:26 2018 +0100 Bug 21620: Prevent stockrotation cronjob failures Superflous use of sprintf combined with rebasing issue left the stockrotation cronjob such that a 'No action taken' email report would catastrophically fail with the error: Redundant argument in sprintf at ./stockrotation.pl line 316 This patch both resolves the error and cleans up some additional unrequired sprintf usage. Test Plan 1) Create a rotation plan 2) Add some items to the rotation plan 3) Run the cronjob using `stockrotation.pl --report=email --send-email --execute` 4) Note the lack of errors Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit ebf0336059635f2ea13c7f626b794e92e4980f46 Author: Nick Clemens Date: Fri Nov 2 10:01:16 2018 +0000 Bug 21656: DBRev 18.06.00.049 Signed-off-by: Nick Clemens commit 8302a5d6ab287e37b9927efad6401c00c1089869 Author: Jonathan Druart Date: Thu Oct 25 13:34:44 2018 -0300 Bug 21656: Update 4 missing sample_notices.sql Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 4bd78f7443ac108eab35263b89bb610e6675d8c2 Author: Jonathan Druart Date: Thu Oct 25 13:32:17 2018 -0300 Bug 21656: Reduce the risk of possible side-effects Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 966e6351760d08825b79a5b7c96af167cf8d9267 Author: Mark Tompsett Date: Thu Oct 25 15:30:10 2018 +0000 Bug 21656: (follow-up) Fix atomicupdate The atomicupdate is going to run as part of an upgrade. It needs to UPDATE, not INSERT. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens commit 9df62cf1caed793f883122eca332c409eddce710 Author: Martin Renvoize Date: Wed Oct 24 11:14:56 2018 +0100 Bug 21656: Fix for bad TT syntax in default stock rotation notice Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens ----------------------------------------------------------------------- Summary of changes: C4/Biblio.pm | 50 +++++-- C4/Budgets.pm | 5 + C4/Items.pm | 17 ++- C4/Matcher.pm | 4 +- C4/Record.pm | 5 +- C4/Search.pm | 32 ++--- Koha.pm | 2 +- Koha/BiblioUtils/Iterator.pm | 4 +- Koha/Exporter/Record.pm | 5 +- Koha/Illrequest.pm | 51 +------ Koha/Illrequest/Config.pm | 22 ++- Koha/REST/V1/Illrequests.pm | 108 ++++++++++++-- about.pl | 7 + catalogue/detail.pl | 64 +++++---- catalogue/search.pl | 2 +- cataloguing/addbooks.pl | 5 +- cataloguing/additem.pl | 4 +- course_reserves/course-reserves.pl | 16 +-- debian/templates/koha-conf-site.xml.in | 7 + etc/koha-conf.xml | 7 + ill/ill-requests.pl | 9 +- .../data/mysql/de-DE/mandatory/sample_notices.sql | 2 +- .../data/mysql/en/mandatory/sample_notices.sql | 2 +- .../data/mysql/es-ES/mandatory/sample_notices.sql | 2 +- .../mysql/fr-CA/obligatoire/sample_notices.sql | 2 +- .../mysql/fr-FR/1-Obligatoire/sample_notices.sql | 2 +- installer/data/mysql/it-IT/necessari/notices.sql | 2 +- .../mysql/nb-NO/1-Obligatorisk/sample_notices.sql | 2 +- .../data/mysql/pl-PL/mandatory/sample_notices.sql | 2 +- .../data/mysql/ru-RU/mandatory/sample_notices.sql | 2 +- installer/data/mysql/sysprefs.sql | 1 + .../data/mysql/uk-UA/mandatory/sample_notices.sql | 2 +- installer/data/mysql/updatedatabase.pl | 19 +++ .../intranet-tmpl/prog/en/includes/cat-toolbar.inc | 4 + koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 5 + .../prog/en/modules/admin/preferences/opac.pref | 3 + .../en/modules/course_reserves/course-reserves.tt | 21 --- .../prog/en/modules/ill/ill-requests.tt | 6 +- .../prog/en/modules/plugins/plugins-home.tt | 3 + .../opac-tmpl/bootstrap/en/modules/opac-tags.tt | 2 + misc/cronjobs/stockrotation.pl | 25 ++-- .../thirdparty/TalkingTech_itiva_outbound.pl | 2 +- misc/migration_tools/build_oai_sets.pl | 4 +- opac/opac-ISBDdetail.pl | 60 ++++---- opac/opac-MARCdetail.pl | 74 +++++----- opac/opac-basket.pl | 30 +++- opac/opac-detail.pl | 55 +++++--- opac/opac-downloadcart.pl | 13 +- opac/opac-downloadshelf.pl | 11 +- opac/opac-export.pl | 16 ++- opac/opac-search.pl | 15 +- opac/opac-sendbasket.pl | 5 +- opac/opac-sendshelf.pl | 15 +- opac/opac-tags.pl | 46 +++++- opac/opac-user.pl | 8 +- t/db_dependent/Budgets.t | 2 + t/db_dependent/ILSDI_Services.t | 42 +++++- t/db_dependent/Illrequests.t | 75 +--------- t/db_dependent/Items.t | 59 +++++--- t/db_dependent/Koha/BiblioUtils/Iterator.t | 76 ++++++++++ t/db_dependent/Labels/t_Label.t | 147 ++++++++++++++++++++ t/db_dependent/Plugins.t | 4 +- t/db_dependent/Record/marcrecord2csv.t | 8 +- t/db_dependent/Search.t | 50 ++++++- t/db_dependent/api/v1/illrequests.t | 19 ++- t/lib/Koha/Plugin/Test.pm | 10 ++ 66 files changed, 981 insertions(+), 400 deletions(-) create mode 100644 t/db_dependent/Koha/BiblioUtils/Iterator.t create mode 100644 t/db_dependent/Labels/t_Label.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 5 13:09:14 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 Nov 2018 12:09:14 +0000 Subject: [koha-commits] main Koha release repository branch 17.11.x updated. v17.11.11-2-gb0ce47f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 17.11.x has been updated via b0ce47f6d8890be5534ed5b08d7582065f536c3b (commit) via e066901611d9d6be39ff95f70738c28fc5d339c3 (commit) from 3aa274a7b9073107db4407d51057f4b7875fec77 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b0ce47f6d8890be5534ed5b08d7582065f536c3b Author: Jonathan Druart Date: Fri Sep 21 17:55:40 2018 -0300 Bug 21396: Add 2 missing use statements in Koha::Account 1. require C4::Letters must be use C4::Letters (from bug 19191) 2. There is call to C4::Circulation::ReturnLostItem, but no use of C4::Circulation (from bug 20631) Test plan: finger crossed, I ran the tests from t/db_dependent/Koha and they all passed Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 1b56e446ed64cad9d4dd42a8cb3f1953f424e0aa) Signed-off-by: Martin Renvoize (cherry picked from commit 362c9331a241bedb3efcab57c0e1287c5ed1c18a) Signed-off-by: Fridolin Somers commit e066901611d9d6be39ff95f70738c28fc5d339c3 Author: Fridolin Somers Date: Fri Nov 2 15:18:20 2018 +0100 [17.11.x] correct duplicat keys in definitions.json ----------------------------------------------------------------------- Summary of changes: Koha/Account.pm | 1 + api/v1/swagger/definitions.json | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 5 13:59:02 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 Nov 2018 12:59:02 +0000 Subject: [koha-commits] main Koha release repository branch 18.05.x updated. v18.05.05-29-gcbb6605 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.05.x has been updated via cbb6605d632eba95599704fc3867c11f6947d531 (commit) via b8968579b8e7d3865a6db4436becb2647e962bc6 (commit) via b5662f6ab922aef7782febe0a3c0547c322ebfb6 (commit) via e70b624bc6b375384c81f2e2065621f3473e9607 (commit) via f8063726ba1c486d2a62be2a930fb5cac0797856 (commit) via 64b31d4cc897c884c40c27c242f70f0885df55d8 (commit) via 6c2eeaa43443e0591eebbf00f48dacfff005b647 (commit) via 286b453d3a41ed186ac44ac339319f934e2fb0eb (commit) via fa1846a7c17e33ef740ade83154d7347bf21cccd (commit) from 8969eccaaeddfffbdc30a2f36e6dfc64595d607e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cbb6605d632eba95599704fc3867c11f6947d531 Author: Jonathan Druart Date: Thu Oct 18 11:07:02 2018 -0300 Bug 20521: Use a specific config for strict sql modes To avoid disrupting testers and new developers it will be turned off by default. We will turn it on for Jenkins so devs will have to take care of the regressions they introduce (!) Signed-off-by: Nick Clemens (cherry picked from commit 17e5691daaa0f6b73623198eded648c78e40056a) Signed-off-by: Martin Renvoize commit b8968579b8e7d3865a6db4436becb2647e962bc6 Author: Jonathan Druart Date: Wed Oct 17 20:24:09 2018 -0300 Bug 21597: Incorrect decimal value: 't_value_bib639' for column 'price' Fix t/db_dependent/selenium/basic_workflow.t We want to send specific values depending on the data type in DB For instance integer, or varchar(10) Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens (cherry picked from commit b7da4f890b9d9a7b2a919ce8529198ab443115cd) Signed-off-by: Martin Renvoize commit b5662f6ab922aef7782febe0a3c0547c322ebfb6 Author: Jonathan Druart Date: Wed Oct 17 19:21:56 2018 -0300 Bug 21597: Incorrect date value: '0' for column 'onloan' Fix t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t items.onloan `onloan` date DEFAULT NULL, DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect date value: '0' for column 'onloan' at row 1 at /home/vagrant/kohaclone/t/lib/TestBuilder.pm line 288 Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens (cherry picked from commit 489c636316209d4f4e7d8648cc5832347e792076) Signed-off-by: Martin Renvoize commit e70b624bc6b375384c81f2e2065621f3473e9607 Author: Jonathan Druart Date: Wed Oct 17 19:18:58 2018 -0300 Bug 21597: Data too long for column 'invitekey' Fix t/db_dependent/Virtualshelves.t virtualshelfshares.invitekey `invitekey` varchar(10) COLLATE utf8mb4_unicode_ci DEFAULT NULL, We should not insert a longer string! DBIx::Class::Storage::DBI::_dbh_execute(): Data too long for column 'invitekey' at row 1 at /home/vagrant/kohaclone/Koha/Object.pm line 125 Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens (cherry picked from commit f19a99209528e85003cd56104640effe75e4f126) Signed-off-by: Martin Renvoize commit f8063726ba1c486d2a62be2a930fb5cac0797856 Author: Jonathan Druart Date: Wed Oct 17 19:11:29 2018 -0300 Bug 21597: Field 'amount' doesn't have a default value Fix t/db_dependent/Accounts.t Default value could be 0, or left as it. It seems that the different initialisation we have in the code pass a value for 'amount' account_offsets.amount `amount` decimal(26,6) NOT NULL, DBIx::Class::Storage::DBI::_dbh_execute(): Field 'amount' doesn't have a default value at /home/vagrant/kohaclone/Koha/Object.pm line 125 Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens (cherry picked from commit 82884b0bd81a79c9a0c700463f1fcc632314863c) Signed-off-by: Martin Renvoize commit 64b31d4cc897c884c40c27c242f70f0885df55d8 Author: Jonathan Druart Date: Wed Oct 17 19:07:20 2018 -0300 Bug 21597: Column 'notforloan' cannot be null Fix t/db_dependent/Circulation.t items.notforloan: `notforloan` tinyint(1) NOT NULL DEFAULT '0', t/db_dependent/Circulation.t .. 115/119 DBD::mysql::st execute failed: Column 'notforloan' cannot be null [for Statement "UPDATE `items` SET `notforloan` = ? WHERE ( `itemnumber` = ? )" with ParamValues: 0=undef, 1='1046'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. # No tests run! # Failed test 'No tests run for subtest "item-level_itypes = 0"' # at t/db_dependent/Circulation.t line 2356. # Looks like you failed 1 test of 2. # Failed test 'CanBookBeIssued | notforloan' # at t/db_dependent/Circulation.t line 2359. Can't locate object method "rethrow" via package "DBD::mysql::st execute failed: Column 'notforloan' cannot be null [for Statement "UPDATE `items` SET `notforloan` = ? WHERE ( `itemnumber` = ? )" with ParamValues: 0=undef, 1='1046'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens (cherry picked from commit a40b8ebde788ac4082670e30b03fcbade2cc5544) Signed-off-by: Martin Renvoize commit 6c2eeaa43443e0591eebbf00f48dacfff005b647 Author: Jonathan Druart Date: Thu Oct 18 08:32:59 2018 -0300 Bug 21599: Fix item type creation by defining default values Same as what we have in Koha::Patron->new, empty strings should not be inserted in integer or date column type DBD::mysql::st execute failed: Incorrect decimal value: '' for column 'defaultreplacecost' at row 1 [for Statement "INSERT INTO `itemtypes` ( `checkinmsg`, `checkinmsgtype`, `defaultreplacecost`, `description`, `hideinopac`, `imageurl`, `itemtype`, `notforloan`, `processfee`, `rentalcharge`, `searchcategory`, `sip_media_type`, `summary`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0="", 1="message", 2="", 3="xx", 4=0, 5='', 6="XX", 7=0, 8="", 9="", 10="", 11=undef, 12=""] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. Test plan: Create a new itemtype Signed-off-by: Claire Gravely Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens (cherry picked from commit 33c142ba3b7cfd37dd90569de2a5802849b09ef5) Signed-off-by: Martin Renvoize commit 286b453d3a41ed186ac44ac339319f934e2fb0eb Author: Jonathan Druart Date: Wed Oct 17 19:31:14 2018 -0300 Bug 21598: 'koha_kohadev.aqbudgets.budget_parent_id' isn't in GROUP BY DBD::mysql::db selectall_hashref failed: 'koha_kohadev.aqbudgets.budget_parent_id' isn't in GROUP BY [for Statement " at /home/vagrant/kohaclone/C4/Budgets.pm line 558. and at /home/vagrant/kohaclone/C4/Budgets.pm line 565. Test plan: hit /cgi-bin/koha/admin/aqbudgets.pl Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens (cherry picked from commit 60e00a332e2a500746f12908042dd61250d1f79a) Signed-off-by: Martin Renvoize commit fa1846a7c17e33ef740ade83154d7347bf21cccd Author: Nick Clemens Date: Thu Oct 18 10:05:38 2018 +0000 Bug 21593: Remove GROUP BY from GetAuthValueDropbox With new MYSQL modes we are permitted only full group by. In this case I don't think we need a GROUP BY at all To test: 1 - Try to pay a fine or create a borrower 2 - Internal server error 3 - Apply patch 4 - Page should load 5 - Test various authorised values ot ensure they work e.g. Set bsort1 and bsort2 to have some authorised values with and without branch limits set PAYMENT_TYPE to have some values with and without branch limits Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens (cherry picked from commit 87c7e534f15aff14d6e82cbb67ecbb8e8715c2b7) Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Budgets.pm | 4 ++-- Koha/Database.pm | 6 +++++- Koha/ItemType.pm | 12 ++++++++++++ Koha/Template/Plugin/AuthorisedValues.pm | 1 - t/db_dependent/Accounts.t | 6 +++--- t/db_dependent/Circulation.t | 2 +- t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t | 2 +- t/db_dependent/Virtualshelves.t | 4 ++-- t/db_dependent/selenium/basic_workflow.t | 19 ++++++++++++++++++- 9 files changed, 44 insertions(+), 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Nov 5 16:08:33 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 05 Nov 2018 15:08:33 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v18.05.00-1308-gf683c18 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via f683c181acdd0e7c285f6930c2067b6f20ff00a4 (commit) via fef32fac36800b6033367827ff45905db1d261c7 (commit) via 1dc17d8502baa50885871419c0152fedc1977710 (commit) via f6808f5e554c8608e70865f15bf1cb6b39c1221c (commit) via 368a9b1d5316cc1a7bdb91c6b0a55ddd83b6fc4a (commit) via 9c02784fe5d7c3e66334163fa8068406b8bee5c8 (commit) via c9d3e5470709f1f44e0952d06832a45909046ef1 (commit) via 433eb16fd30d2b4e1e5e65c6d120600054ad2c1e (commit) via 2e003cd04b8626a054412212fe377077658668f2 (commit) via c4ff0eac6039c15ef16ced9f7523b931c674ecac (commit) via 458e07928505570affd43bd4c8dbe8e1c170a409 (commit) via 529ed6faa43b6c2543695ec594fe891139cca83f (commit) via 7f6671587c0b78c22c3696f4a468a48a97af840d (commit) via 1ba78e0a21b5ccdeb0c9bfbe690929a8ffe4c9cd (commit) via 6e82493b65092f426cd5d5bdbacedc8d79d13469 (commit) via 401b706392cb49d36ba9842d6f9397a5f0d1a686 (commit) via 4ea7f20ca3c55ac7f0df00207aadb854260bdc13 (commit) via fd3a378f9a8f43f9ac2b4fae73d881f36cc5f9bf (commit) via 44778ddcc9badc800860cbcf6489065646cb3f15 (commit) via a8b6a5daa56d3b681d1157c29a10caedfda984ad (commit) via 36a2627c399d7f6a59d68d7bc15edbadd528b56f (commit) via e427cf5b3f3ded54dbc6899c149a2de3e8ab13ea (commit) via e520d699109958712212ead8b8935a63402e5b37 (commit) via 5b807fd3d75e059ad8ea48c126b3aaf2b68a26e9 (commit) from 1a0172a253e5432e5eef862768aaacb3463501f2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f683c181acdd0e7c285f6930c2067b6f20ff00a4 Author: Jonathan Druart Date: Wed Oct 24 15:31:02 2018 -0300 Bug 21650: Remove the subroutine C4::Items::GetLastAcquisitions C4::Items::GetLastAcquisitions has been added by commit 7753bbad4fb4df47c8fb4f959fc68764a71cb623 Adding Some new functions (?) Apparently it has never been used, we should remove it to avoid unnecessary maintenance. Test plan: git grep GetLastAcquisitions must not return any results NOTE: POD Coverage test failure is expected on removal Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit fef32fac36800b6033367827ff45905db1d261c7 Author: Jonathan Druart Date: Thu Oct 25 17:17:50 2018 -0300 Bug 21645: Fix focus when modal is shown First the event must be defined in the document.ready block, then, since bootstrap 3 the event is 'shown.bs.modal', not 'shown' Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens commit 1dc17d8502baa50885871419c0152fedc1977710 Author: Jonathan Druart Date: Thu Oct 25 17:09:26 2018 -0300 Bug 21645: e.preventDefault on click Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens commit f6808f5e554c8608e70865f15bf1cb6b39c1221c Author: Owen Leonard Date: Wed Oct 24 14:01:18 2018 +0000 Bug 21645: Clean up library groups template This patch modifies the library groups administration page to help compliance with several coding guidelines: - Move JavaScript to the footer - Convert to Bootstrap grid - Other markup corrections To test, apply the patch and go to Administration -> Library groups. - Confirm that the page how has a "Library groups" heading. - Confirm that action buttons in the table of library groups are styled correctly. - Test both adding and editing groups. The "Required" label on required fields should be styled correctly. - Test all JavaScript-driven interactions on the page: - Adding, editing, and deleting groups - Removing libraries from groups - Expanding and collapsing group hierarchies - Validate the page's HTML and confirm that there are no errors found in the main body of the page. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens commit 368a9b1d5316cc1a7bdb91c6b0a55ddd83b6fc4a Author: Owen Leonard Date: Tue Jul 24 13:00:21 2018 +0000 Bug 21570: Update two-column templates with Bootstrap grid: Various This patch modifies several assorted templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from