[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.05-29-gcbb6605

Mon Nov 5 13:59:02 CET 2018

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  cbb6605d632eba95599704fc3867c11f6947d531 (commit)
       via  b8968579b8e7d3865a6db4436becb2647e962bc6 (commit)
       via  b5662f6ab922aef7782febe0a3c0547c322ebfb6 (commit)
       via  e70b624bc6b375384c81f2e2065621f3473e9607 (commit)
       via  f8063726ba1c486d2a62be2a930fb5cac0797856 (commit)
       via  64b31d4cc897c884c40c27c242f70f0885df55d8 (commit)
       via  6c2eeaa43443e0591eebbf00f48dacfff005b647 (commit)
       via  286b453d3a41ed186ac44ac339319f934e2fb0eb (commit)
       via  fa1846a7c17e33ef740ade83154d7347bf21cccd (commit)
      from  8969eccaaeddfffbdc30a2f36e6dfc64595d607e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit cbb6605d632eba95599704fc3867c11f6947d531
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Oct 18 11:07:02 2018 -0300

    Bug 20521: Use a specific config for strict sql modes

    To avoid disrupting testers and new developers it will be turned off by default.

    We will turn it on for Jenkins so devs will have to take care of the
    regressions they introduce (!)

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 17e5691daaa0f6b73623198eded648c78e40056a)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit b8968579b8e7d3865a6db4436becb2647e962bc6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Oct 17 20:24:09 2018 -0300

    Bug 21597: Incorrect decimal value: 't_value_bib639' for column 'price'

    Fix t/db_dependent/selenium/basic_workflow.t

    We want to send specific values depending on the data type in DB
    For instance integer, or varchar(10)

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit b7da4f890b9d9a7b2a919ce8529198ab443115cd)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit b5662f6ab922aef7782febe0a3c0547c322ebfb6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Oct 17 19:21:56 2018 -0300

    Bug 21597: Incorrect date value: '0' for column 'onloan'

    Fix t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t

    items.onloan
      `onloan` date DEFAULT NULL,

    DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect date value: '0' for
    column 'onloan' at row 1 at /home/vagrant/kohaclone/t/lib/TestBuilder.pm
    line 288

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 489c636316209d4f4e7d8648cc5832347e792076)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit e70b624bc6b375384c81f2e2065621f3473e9607
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Oct 17 19:18:58 2018 -0300

    Bug 21597: Data too long for column 'invitekey'

    Fix t/db_dependent/Virtualshelves.t

    virtualshelfshares.invitekey
      `invitekey` varchar(10) COLLATE utf8mb4_unicode_ci DEFAULT NULL,

    We should not insert a longer string!

    DBIx::Class::Storage::DBI::_dbh_execute(): Data too long for column
    'invitekey' at row 1 at /home/vagrant/kohaclone/Koha/Object.pm line 125

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit f19a99209528e85003cd56104640effe75e4f126)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit f8063726ba1c486d2a62be2a930fb5cac0797856
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Oct 17 19:11:29 2018 -0300

    Bug 21597: Field 'amount' doesn't have a default value

    Fix t/db_dependent/Accounts.t

    Default value could be 0, or left as it.
    It seems that the different initialisation we have in the code pass a
    value for 'amount'

    account_offsets.amount
      `amount` decimal(26,6) NOT NULL,

    DBIx::Class::Storage::DBI::_dbh_execute(): Field 'amount' doesn't
    have a default value at /home/vagrant/kohaclone/Koha/Object.pm line 125

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 82884b0bd81a79c9a0c700463f1fcc632314863c)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 64b31d4cc897c884c40c27c242f70f0885df55d8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Oct 17 19:07:20 2018 -0300

    Bug 21597: Column 'notforloan' cannot be null

    Fix t/db_dependent/Circulation.t

    items.notforloan:
      `notforloan` tinyint(1) NOT NULL DEFAULT '0',

    t/db_dependent/Circulation.t .. 115/119 DBD::mysql::st execute failed: Column 'notforloan' cannot be null [for Statement "UPDATE `items` SET `notforloan` = ? WHERE ( `itemnumber` = ? )" with ParamValues: 0=undef, 1='1046'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832.
            # No tests run!

        #   Failed test 'No tests run for subtest "item-level_itypes = 0"'
        #   at t/db_dependent/Circulation.t line 2356.
        # Looks like you failed 1 test of 2.

     #   Failed test 'CanBookBeIssued | notforloan'
     #   at t/db_dependent/Circulation.t line 2359.
    Can't locate object method "rethrow" via package "DBD::mysql::st execute failed: Column 'notforloan' cannot be null [for Statement "UPDATE `items` SET `notforloan` = ? WHERE ( `itemnumber` = ? )" with ParamValues: 0=undef, 1='1046'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832.

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit a40b8ebde788ac4082670e30b03fcbade2cc5544)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 6c2eeaa43443e0591eebbf00f48dacfff005b647
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Oct 18 08:32:59 2018 -0300

    Bug 21599: Fix item type creation by defining default values

    Same as what we have in Koha::Patron->new, empty strings should not be
    inserted in integer or date column type

    DBD::mysql::st execute failed: Incorrect decimal value: '' for column 'defaultreplacecost' at row 1 [for Statement "INSERT INTO `itemtypes` ( `checkinmsg`, `checkinmsgtype`, `defaultreplacecost`, `description`, `hideinopac`, `imageurl`, `itemtype`, `notforloan`, `processfee`, `rentalcharge`, `searchcategory`, `sip_media_type`, `summary`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0="", 1="message", 2="", 3="xx", 4=0, 5='', 6="XX", 7=0, 8="", 9="", 10="", 11=undef, 12=""] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832.

    Test plan:
    Create a new itemtype

    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 33c142ba3b7cfd37dd90569de2a5802849b09ef5)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 286b453d3a41ed186ac44ac339319f934e2fb0eb
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Oct 17 19:31:14 2018 -0300

    Bug 21598: 'koha_kohadev.aqbudgets.budget_parent_id' isn't in GROUP BY

    DBD::mysql::db selectall_hashref failed:
    'koha_kohadev.aqbudgets.budget_parent_id' isn't in GROUP BY [for
    Statement "

        at /home/vagrant/kohaclone/C4/Budgets.pm line 558.
    and
        at /home/vagrant/kohaclone/C4/Budgets.pm line 565.

    Test plan:
    hit /cgi-bin/koha/admin/aqbudgets.pl

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 60e00a332e2a500746f12908042dd61250d1f79a)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit fa1846a7c17e33ef740ade83154d7347bf21cccd
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Thu Oct 18 10:05:38 2018 +0000

    Bug 21593: Remove GROUP BY from GetAuthValueDropbox

    With new MYSQL modes we are permitted only full group by.

    In this case I don't think we need a GROUP BY at all

    To test:
    1 - Try to pay a fine or create a borrower
    2 - Internal server error
    3 - Apply patch
    4 - Page should load
    5 - Test various authorised values ot ensure they work
       e.g. Set bsort1 and bsort2 to have some authorised values with and
       without branch limits
       set PAYMENT_TYPE to have some values with and without branch limits

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 87c7e534f15aff14d6e82cbb67ecbb8e8715c2b7)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Budgets.pm                                       |    4 ++--
 Koha/Database.pm                                    |    6 +++++-
 Koha/ItemType.pm                                    |   12 ++++++++++++
 Koha/Template/Plugin/AuthorisedValues.pm            |    1 -
 t/db_dependent/Accounts.t                           |    6 +++---
 t/db_dependent/Circulation.t                        |    2 +-
 t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t |    2 +-
 t/db_dependent/Virtualshelves.t                     |    4 ++--
 t/db_dependent/selenium/basic_workflow.t            |   19 ++++++++++++++++++-
 9 files changed, 44 insertions(+), 12 deletions(-)

hooks/post-receive
-- 
main Koha release repository