[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.11-14-g10f3702

Fri Nov 9 07:57:17 CET 2018

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.11.x has been updated
       via  10f370292d86c27d72f80e1a5010c80d8431bb88 (commit)
       via  81b41d44e4f4f85fe1a1ad9bfa204f8692706df9 (commit)
       via  7cfcfae3c4207a37a9b4b3836bd093a9376e51fa (commit)
       via  74a1687fc54e15d3e8ba15f040a37d34556f8cd0 (commit)
       via  c8efbde5ed6bb62e4c4d81872e0f7eebdbe9d4cd (commit)
       via  68c83c4c8691307c65025717003417f870cb1098 (commit)
       via  5a69e301970c324ee8110bb10d6d7fea4616fbcc (commit)
       via  78c9815c7d425836e5b7fbbc749cc0b59a898277 (commit)
       via  fb53f07036145761497e332e23aa741ba5b7c1f1 (commit)
       via  079efd6341579984391f6a6bc7cf467886789da2 (commit)
       via  35218c4982a25fdc393196210c580ae6cab42c48 (commit)
      from  3c54c66ccbf1d619dc51a075dc75d0899bf625b0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 10f370292d86c27d72f80e1a5010c80d8431bb88
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Thu Oct 11 15:59:13 2018 +0000

    Bug 21550: DataTables four button pagination uses the wrong icon for disabled buttons

    This patch modifies the DataTables CSS which styles "full_nubmers"
    controls which are disabled: First and Previous buttons on the first
    page of results, Next and Last buttons on the last page of results.
    These buttons should have gray icons instead of blue.

    To test, apply the patch and clear your browser cache if necessary. View
    a page which uses a "full_numbers" DataTables configuration, e.g.

    - Administration -> Cities
    - ILL requests -> List requests
    - Circulation -> Holds to pull

    Confirm that buttons in their disabled state have a gray icon and text
    instead of blue.

    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit d9b922f46f8d551949f337f29edef6985130c8ba)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 417e28f14ebccdef073491b94bbbad8a80a0630d)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 81b41d44e4f4f85fe1a1ad9bfa204f8692706df9
Author: Andreas Roussos <arouss1980 at gmail.com>
Date:   Sat Oct 6 10:15:26 2018 +0300

    Bug 21506: DataTables four button pagination uses the wrong icon for First and Last buttons

    Pages with DataTables' four button pagination use the wrong
    icon for 'First' and 'Last'. Also, the icons for all four
    buttons are truncated at the bottom.

    This patch fixes that.

    Test plan:
    1) Go to a page that uses four button pagination (e.g. Home >
       Administration > MARC frameworks) and notice how the
       pagination icons for First/Previous and Next/Last are the
       same. Also notice all four icons are clipped at the bottom.
    2) Apply the patch.
    3) Refresh the page; the First and Last buttons' icons now
       include a vertical bar, and there is no clipping visible.
    4) For completeness, check other affected pages as well.

    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 074c329774adb7b23f85293a7f6d146c0d989f99)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 8802d32b7f4e9f4642d3b0f7f7f8a871b85662ed)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 7cfcfae3c4207a37a9b4b3836bd093a9376e51fa
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Oct 9 11:30:23 2018 +0000

    Bug 21417: DBRev 17.11.11.002

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit cf8890465d32d780e4177438d9b6ae807b1df36d)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 18d04888b2264ab85a24290c51eed01c051418ce)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 74a1687fc54e15d3e8ba15f040a37d34556f8cd0
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Thu Sep 27 16:07:37 2018 +0100

    Bug 21417: (QA follow-up) Display default EAN as such in admin display

    A branch value of null is interpreted as the default
    Add text 'All libraries' to this case in the display
    rather than blank so that its function is clear to the
    user

    Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit d70daacebae50fde8449f4cec2bb4578747610fc)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit f0937049f376d829d6baad81c66c298e93587acf)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit c8efbde5ed6bb62e4c4d81872e0f7eebdbe9d4cd
Author: Kyle M Hall <kyle at bywatersolutiosn.com>
Date:   Thu Sep 27 06:51:27 2018 -0400

    Bug 21417: EDI ordering fails when basket and EAN libraries do not match

    When clicking Create EDIFACT Order on /acqui/basket.pl, an EDIFACT message will not be generated if aqbasket.branch does not match edifact_ean.branchcode. This failure does not generate any sort of error message, it just fails to produce a message.

    We should allow ean's to not require a branch to be set, then if we don't find a branch specific each, we can look for the default version of the ean.

    Test Plan:
    1) Apply this patch set
    2) Run updatedatabase
    3) Verify you can create a Library EAN without setting a branchcode for it
    4) Verify you can use this EAN to send an EDI order where the basket has a branchcode set

    Signed-off-by: Colin Campbell <colin.campbell at ptfs-europe.com>
    Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 18674cfde322c52fafb3114b397bb1ebe7941b97)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit c2537558e0ed79cc00a71d7405b7e738835372a8)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 68c83c4c8691307c65025717003417f870cb1098
Author: Andreas Roussos <arouss1980 at gmail.com>
Date:   Sat Sep 29 19:51:45 2018 +0300

    Bug 21455: Authority search options get shuffled around when you click on 'Search'

    In the staff client, when you perform an authority search the
    selected values for the 'Search all headings:' and 'Search
    entire record:' options get shuffled around when you click on
    the 'Search' button.

    This patch fixes that.

    Test plan:
    1) Perform an authority search and set the 'Search all headings:'
       option to 'starts with'.
    2) Click on the 'Search' button.
    3) Notice how the 'Search all headings:' option is now 'contains',
       and 'starts with' has moved down to the 'Search entire record:'
       option.
    4) Apply the patch.
    5) Hit 'Search' again. This time the selected search options do
       not move around.

    Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 6cee98c04fce2129de21c65c9e0c407a508df9bd)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit d0db6f69bbc38b943dd723eca05f181de1a60cf8)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 5a69e301970c324ee8110bb10d6d7fea4616fbcc
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Jun 11 11:34:22 2018 -0300

    Bug 20910: Display 773$g when $0 is present too

    This patch makes the XSLT logic add the $g subfield in the 773 display
    in both the OPAC and staff interface MARC21 record detail pages.

    The XSLT chooses between different ways to create the link for the
    related content, but then it only adds the $g in two of the cases.
    There's no obvious reason for a different display.

    To test:
    - Have  a record with:

    =773   $tHost title $gp4.

    => SUCCESS: Notice the Detail view shows:
      In: Host title p4.

    - Have another record with:

    =773   $tHost title $gp4. $w100
    - Enable UseControlNumber (only to cover the case):
    => SUCCESS: Notice the detail view shows
      In: Host title p4.

    - Have another record with:

    =773   $tHost title $gp4. $0456

    => FAIL: The Detail view doesn't show p4.
    - Apply this patch
    - Reload
    => SUCCESS: The Detail view displays p4.!
    - Sign off :-D

    Sponsored-by: Escuela de Orientacion Lacaniana
    Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>
    Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit f161d4e823aa84d7c602089eacacbdf2bfc502ce)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 8a7b508cf4bfb9ed03259139c8819a7011995bf5)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 78c9815c7d425836e5b7fbbc749cc0b59a898277
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Wed May 16 01:05:07 2018 +0000

    Bug 9968: Fix wrong index for Standard number in advanced and label search

    'Standard number' indicates that you can search ISBN, ISSN and other
    standard numbers, but we are using the wrong index and only get a
    very limited search for biblionumber instead.

    This patch changes the index from sn to ident.

    To test:
    - Check both staff and OPAC advanced search:
      - Search for Standard number = ISBN
      - Search for Standard number = ISSN
      Both should work.
      Toggle [Intranet|OPAC]NumbersPreferPhrase system preferences
    - Check the label creator
      - Add a new batch
      - Use 'add items' option and search for Standard number

    Signed-off-by: Michal Denar <black23 at gmail.com>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 09a7d37d53a87e35f2151e00200995ab3dfa3896)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit d341326362656853d0f8d371bd7d685b9c4266d7)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit fb53f07036145761497e332e23aa741ba5b7c1f1
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Wed Apr 25 16:44:03 2018 +0000

    Bug 17237: Remove CREATE USER 'user'@'%' line

    Having a 'user'@'%' line decreases database security.
    Bug 16690 closes the need for such a line, and this
    bug removes the use of it.

    TEST PLAN
    ---------
    While this depends on 16690, it is not required for testing.

    On a kohadev box:
    sudo koha-create --create-db test_17237_a
    git bz apply 17237
    sudo perl ~/misc4dev/cp_debian_files.pl
    restart_all
    sudo systemctl daemon-reload
    sudo koha-create --create_db test_17237_b
    sudo mysql -u root
    SELECT user,host from mysql.user;
    -- test_17237_a will have two entries, one being '%'
    -- test_17237_b will only have one entry, not '%'

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

    (cherry picked from commit 1e856e7e7316749f59cb4e721e352b0a60237def)

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    (cherry picked from commit 291c250dcfe23c046f3b5df419b8819fb92cbcf3)

    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 079efd6341579984391f6a6bc7cf467886789da2
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Oct 19 16:50:40 2018 +0000

    Bug 21617: DBRev 17.11.11.001

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 8150058b387b39469b64853a07d512bcc0a3741d)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 5bc9139097327a05f411935cec08ded322a46032)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 35218c4982a25fdc393196210c580ae6cab42c48
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Oct 19 10:51:05 2018 +0200

    Bug 21617: statistics.ccode is not long enough (see also DBRev 18.05.04.001)

    Warn from a test:
    DBD::mysql::st execute failed: Data too long for column 'ccode' at row 1 [for Statement "INSERT INTO statistics
            (datetime,
             branch,          type,        value,
             other,           itemnumber,  itemtype, location,
             borrowernumber,  proccode,    ccode)
             VALUES (now(),?,?,?,?,?,?,?,?,?,?)" with ParamValues: 0="z8LIyIV", 1='issue', 2=undef, 3='', 4='2584', 5='E_QkzaV5Ay', 6='oDnFRZyog2CS2_XoUB_MB2sBxyI3elbFPC_AekxLPrduGTXKnlNoLKEdQrXzpAw5zD1pGbZshV9ydZup', 7='2000005168', 8='', 9='j9ZDn74omZAoZrTOdC4a05SpWRSHPR2apfss7y5V6QJuQnBEk32XWXCfMp7'] at C4/Stats.pm line 138.

    The dbrev 18.05.04.001 did not change it from 10 to 80 as in other tables.

    We should either truncate to 10 chars in Stats.pm or increase to varchar(80). Since it is varchar and not char, we should not be afraid about size. I choose for the latter here.

    Test plan:
    Run db rev.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit ad20a30a831c5f3482f2eed80cc36269ebbef05f)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 08ece37ccabb739ff2ae7f34ccd8ea2e88827e18)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha.pm                                            |    2 +-
 Koha/EDI.pm                                        |   10 ++++++++
 Koha/Schema/Result/EdifactEan.pm                   |   15 ++++++++----
 admin/edi_ean_accounts.pl                          |    4 ++--
 authorities/auth_finder.pl                         |   14 +++++-------
 debian/scripts/koha-create                         |    2 --
 installer/data/mysql/kohastructure.sql             |    2 +-
 installer/data/mysql/updatedatabase.pl             |   15 ++++++++++++
 koha-tmpl/intranet-tmpl/prog/css/datatables.css    |   24 +++++++++++++++++++-
 .../prog/en/includes/search_indexes.inc            |    4 ++--
 .../prog/en/modules/admin/edi_ean_accounts.tt      |   11 ++++++---
 .../intranet-tmpl/prog/en/modules/labels/search.tt |    2 +-
 .../prog/en/xslt/MARC21slim2intranetDetail.xsl     |    6 +++--
 koha-tmpl/intranet-tmpl/prog/js/datatables.js      |    8 +++----
 .../bootstrap/en/modules/opac-advsearch.tt         |    4 ++--
 .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl    |    5 ++--
 16 files changed, 92 insertions(+), 36 deletions(-)

hooks/post-receive
-- 
main Koha release repository