[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.05-109-gfc04b4b

Fri Nov 16 13:36:35 CET 2018

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  fc04b4b1bc0ee1fb423168e62ca6af9a207ac508 (commit)
       via  6b4410d9673205e08cd58924a2ec04860b9f74d2 (commit)
       via  2a899edbcc8c3739bd96bab9cfe06fbd8b1147a5 (commit)
       via  db0c642d9b5c051b16a535882cea181f425860d2 (commit)
       via  cd3af66cd47c34bc01afa188ce879a4d3e2cc353 (commit)
       via  2c7724f3bf10949454d4fe09702c0366ae41ad8d (commit)
       via  c3243e912f28ffb874d1c9fa0389c89bf8a0183c (commit)
       via  241032230da86f4d87e4f616aca5e17cf214cfd5 (commit)
      from  be3fec7132e015f241fa0f1ef95e0b95eebaaee8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit fc04b4b1bc0ee1fb423168e62ca6af9a207ac508
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Oct 31 11:50:59 2018 -0300

    Bug 21740: Show @ when editing fixed-length fields on bibliographic frameworks

    This is a consistency issue: we store '@' as the subfield for
    fixed-lenght fields, yet on editing '_' is displayed (on the form and
    the tab). This was probably done to avoid URI encoding problems in the
    past.

    This patch restores the '@' everywhere.

    To test:
    - Open the MARC structure for any bibliographic MARC framework
    - Choose Actions > Subfields on any fixed-length field
    => ERROR: Notice the tab has an underscore (_) and the subfield code is '_' as well.
    - Cancel
    => SUCCESS: '@' is displayed on the list
    - Apply this patch
    - Restart all the things:
      $ restart_all
    - Choose Actions > Subfields on any fixed-length field
    => SUCCESS: '@' is displayed in the tab title, and on the 'Subfield
    code' form field.
    - Save some changes
    => SUCCESS: Things work correctly.
    - Sign off :-D

    Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>

    Signed-off-by: Devinim <kohadevinim at devinim.com.tr>

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit e520d699109958712212ead8b8935a63402e5b37)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 6b4410d9673205e08cd58924a2ec04860b9f74d2
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date:   Fri Jun 29 09:23:38 2018 +0100

    Bug 20968: (follow-up) Replace tabs with spaces

    Signed-off-by: Stephen Graham <s.graham4 at herts.ac.uk>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 9783773ada4dec115342a4f8f16b29eb5b98cc2f)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 2a899edbcc8c3739bd96bab9cfe06fbd8b1147a5
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date:   Wed Jun 27 13:21:53 2018 -0400

    Bug 20968: Rename method get_intranet_catalog_toolbar_button to intranet_catalog_biblio_enhancements_toolbar_button

    Signed-off-by: Stephen Graham <s.graham4 at herts.ac.uk>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit e87fa069dc3d10284a2bd31b7c7913132fed5d06)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit db0c642d9b5c051b16a535882cea181f425860d2
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Wed Jun 27 17:13:37 2018 +0000

    Bug 20968: Add unit tests

    Signed-off-by: Stephen Graham <s.graham4 at herts.ac.uk>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 60ca17c616e6026fbd271fb3f99473f3ef7edf00)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit cd3af66cd47c34bc01afa188ce879a4d3e2cc353
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date:   Wed Jun 27 17:13:27 2018 +0100

    Bug 20968: (follow-up) Respond to feedback

    This patch:

    - Removes the unecessary testing for
    intranet_catalog_biblio_enhancements method in detail.pl
    - Renames get_toolbar_button to get_intranet_catalog_toolbar_button

    Signed-off-by: Stephen Graham <s.graham4 at herts.ac.uk>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 7910a530b85b6ee42307d41cba57b95ced2aca27)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 2c7724f3bf10949454d4fe09702c0366ae41ad8d
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date:   Wed Jun 20 12:47:10 2018 +0100

    Bug 20968: Add hooks into cat-toolbar.inc to display buttons

    This commit adds hooks into cat-toolbar.inc to allow the display of
    arbitrary buttons as supplied by plugins within the
    intranet_catalog_biblio_enhancements class that provide the method
    get_toolbar_button

    To test:

    1) Download the plugin from
    https://github.com/PTFS-Europe/cla-permissions-check-plugin
    2) Follow the installation instructions from:
    https://github.com/PTFS-Europe/cla-permissions-check-plugin
    3) TEST: Observe that the "CLA Check Permissions" button takes the user
    to the Check Permissions page and a modal displays containing the
    results of the query
    4) Remove the API key from the plugin "Configuration" page
    5) TEST: Ensure that the "CLA Check Permissions" button takes the user
    to the Check Permissions page and message displays informing the user
    that "Did not receive required request parameters"

    https://bugs.koha-community.org/show_bug.cgi?id=20968

    Signed-off-by: Stephen Graham <s.graham4 at herts.ac.uk>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 741f17e916a3f64d71b55fd87065136307e3bae7)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit c3243e912f28ffb874d1c9fa0389c89bf8a0183c
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Oct 24 01:17:51 2018 +0000

    Bug 21640: Enable output to STDOUT for Itiva outbound script

    To test:
     1 - Enable the TalkingTechItivaPhoneNotification
     2 - Copy 'HOLD' notice 'email' transport to the phone section
     3 - Enable EnhancedMessagingPreferences
     4 - Find a patron and enable 'phone' for the 'Hold filled' notice
        Note: You might not be able to do this straightaway, bug 21639
        If the phone box has a '-' and not a checkbox:
        sudo koha-mysql kohadev
        INSERT INTO message_transports (message_attribute_id,message_transport_type,is_digest,letter_module,letter_code) VALUES (4,'phone',0,'reserves','HOLD');
     5 - Place a hold for the patron
     6 - Check it in and confirm the hold to set it waiting
     7 - sudo koha-shell kohadev
     8 - perl misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl --type=RESERVE -w 0 -v
     9 - Note the Output says it will be on STDOUT, but nothing is output
    10 - Apply patch
    11 - repeat
    12 - Hold info is output to command line

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 12ed04eabb32cb957acd9f88d94ccada0ac09d07)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 241032230da86f4d87e4f616aca5e17cf214cfd5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Oct 18 19:27:21 2018 -0300

    Bug 21606: [sql_modes] Fix matching rules insert

    Fix:
    Incorrect integer value: '' for column 'offset'
    Incorrect integer value: '' for column 'score'

    Test plan:
    Add/edit matching rules

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 32c4dbfd6814f01ae2b430e88f13b89bd374f34f)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Matcher.pm                                      |    4 +-
 admin/marc_subfields_structure.pl                  |    3 +-
 catalogue/detail.pl                                |   64 ++++++++++++--------
 .../intranet-tmpl/prog/en/includes/cat-toolbar.inc |    4 ++
 .../en/modules/admin/marc_subfields_structure.tt   |    6 +-
 .../prog/en/modules/plugins/plugins-home.tt        |    3 +
 .../thirdparty/TalkingTech_itiva_outbound.pl       |    2 +-
 t/db_dependent/Plugins.t                           |    4 +-
 t/lib/Koha/Plugin/Test.pm                          |   10 +++
 9 files changed, 66 insertions(+), 34 deletions(-)

hooks/post-receive
-- 
main Koha release repository