[koha-commits] main Koha release repository branch master updated. v18.05.00-1528-gaeaf74b

Wed Nov 21 12:47:35 CET 2018

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  aeaf74b7cc6608d7b81aaba10defdca6decdaa1d (commit)
       via  a9fc00db03a8210b3edb69a922209a4e8f6df9a1 (commit)
       via  9316001126953c41985eb2853fc25163362591d1 (commit)
       via  df68391a5ec2eac05a88373dc10c136c8d057e98 (commit)
       via  81ac96abec1226b6635022c0a3f69697d13c7d62 (commit)
       via  b704a1adfc3fcee739194d7d6cb79800ba991e51 (commit)
       via  a1d24a2b61359552942fc2420fe18c093c169191 (commit)
       via  5b62714e47d5acd0a4c371024edacc02cfe6f5b5 (commit)
       via  3c18d4c18fad5a0d470c7bdf1ac746a640f25099 (commit)
       via  9166ba2bff5898f4b93593a60372e8fb2253d44a (commit)
      from  812ac89812e2a58029a0ab41836c959b8c376004 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit aeaf74b7cc6608d7b81aaba10defdca6decdaa1d
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Tue Nov 20 16:32:46 2018 +0100

    Bug 21819: (QA follow-up) Replace onchange() in touched code

    AFAIK we should not call document...onchange() and assume that it works.
    Apparently, it does at least in some browsers. But we are not sure.
    We could easily replace them here by the documented jQuery counterpart.

    Note: If you try git grep -l -E "onchange\(" you will find some
    occurrences in two libraries and only in one js file (this one).
    We should replace all occurrences here; will open a new report for that.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Verified that the change event was triggered: span should expand/collapse.

    Signed-off-by: Andreas Roussos <arouss1980 at gmail.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit a9fc00db03a8210b3edb69a922209a4e8f6df9a1
Author: Andreas Roussos <arouss1980 at gmail.com>
Date:   Sat Nov 17 11:35:00 2018 +0200

    Bug 21819: Marc modification templates action always checks Regexp checkbox

    When editing a MARC modification template action, the 'RegEx'
    checkbox to the right of the 'to field' textboxes will always
    appear checked, even if no regular expression has been added.

    This patch fixes that.

    Test plan (steps 1-5 are copied from the original report -- thanks Pasi!):
    1) Go to Tools > Marc modification templates, and create a new template
    2) Add a new action to the template
    3) Edit the action so it's "Move" field to another field.
       Do not check the RegEx checkbox after the "To" field.
    4) Save the action.
    5) Edit the same action again. The checkbox is now checked.
    6) Apply the patch and hit Ctrl-F5 to do a hard refresh in your browser.
    7) Edit the action you saved in 4): this time the 'RegEx' checkbox
       should be unchecked.
    8) For completeness, add a regular expression to the "Move" action
       created in 3) and click on 'Update action'. When you re-edit this
       action the 'RegEx' checkbox should be checked.

    Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 9316001126953c41985eb2853fc25163362591d1
Author: Isobel Graham <isobel.graham09 at gmail.com>
Date:   Mon Nov 19 12:08:33 2018 +0000

    Bug 21615: Move stock rotation in the tools menu

    Mentored-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>
    Signed-off-by: Andreas Roussos <arouss1980 at gmail.com>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit df68391a5ec2eac05a88373dc10c136c8d057e98
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Nov 16 17:23:14 2018 +0000

    Bug 21854: Use template plugin to display category description

    Rather than getting the description in the script and passing, we should
    just use the tmeplate plugin to get the description from the category
    code.

    To test:
    1 - Find a patron, note their category
    2 - Visit Tools - Batch patron modification
    3 - Enter barcode of patron above
    4 - Note category does not show in the display of patrons to be modified
    5 - Apply patch
    6 - Reload the page, note the patron category displays
    7 - Modify the patron (anything but category)
    8 - Check that category still diplays correctly in results

    Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
    Signed-off-by: Andreas Roussos <arouss1980 at gmail.com>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 81ac96abec1226b6635022c0a3f69697d13c7d62
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Nov 14 19:08:09 2018 +0000

    Bug 21837: Don't set holdingbranch filter using selected homebranch filter

    To recreate:
    1 - Open the overdues report (don't worry if you don't have results)
    2 - Choose to filter by homebranch
    3 - Note the holdingbranch filter is set to the selected homebranch
    4 - Apply patch
    5 - Clear filters
    6 - repeat
    7 - only homebranch is set

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit b704a1adfc3fcee739194d7d6cb79800ba991e51
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Oct 22 17:52:46 2018 -0300

    Bug 21529: (bug 13618 follow-up) Display print notices with HTML tags

    Replace a wrong html filter with raw.

    Test plan:
    Define a HOLD or DISCHARGE notice template, with html tags.
    Generate them and confirm that html tags are displayed (which restore
    the existing behaviour prior to bug 13618)

    Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit a1d24a2b61359552942fc2420fe18c093c169191
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date:   Mon Oct 29 14:10:42 2018 +0000

    Bug 21529: (follow-up) USE raw filter

    In order to be able to make use of the $raw filter, we need to USE it
    first

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 5b62714e47d5acd0a4c371024edacc02cfe6f5b5
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Sun Nov 18 05:36:44 2018 +0000

    Bug 21853: (follow-up) to solve printpdf error

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Theoretically this follow-up makes no difference. All modules only export
    printpdf and now we are just asking explicitly for printpdf. But if it
    resolves some exception on the rule..

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 3c18d4c18fad5a0d470c7bdf1ac746a640f25099
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Sat Nov 17 11:58:02 2018 +0100

    Bug 21853: Fix PDF export of basketgroups

    In recent versions of Perl, '.' is not included by default in @INC. This
    breaks PDF export of basketgroups.

    This patch moves acqui/pdfformat/*.pm files in Koha namespace so that
    they can be 'require'd without manipulating @INC

    Test plan:
    1. Turn off Plack/Starman and test PDF export for every value of
       OrderPdfFormat system preference
    2. Turn on Plack/Starman and test PDF export for every value of
       OrderPdfFormat system preference
    3. Test on a dev install and a standard/package install

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 9166ba2bff5898f4b93593a60372e8fb2253d44a
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Tue Nov 13 17:00:23 2018 +0100

    Bug 21823: Force creation of POT file even if there is no messages

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 {acqui => Koha}/pdfformat/layout2pages.pm          |    3 +-
 {acqui => Koha}/pdfformat/layout2pagesde.pm        |    3 +-
 {acqui => Koha}/pdfformat/layout3pages.pm          |    3 +-
 {acqui => Koha}/pdfformat/layout3pagesfr.pm        |    2 +-
 acqui/basketgroup.pl                               |   31 ++++++++++----------
 circ/overdue.pl                                    |    2 +-
 .../intranet-tmpl/prog/en/includes/tools-menu.inc  |    6 ++--
 .../prog/en/modules/batch/print-notices.tt         |    3 +-
 .../prog/en/modules/tools/modborrowers.tt          |    3 +-
 .../prog/js/marc_modification_templates.js         |   14 +++++----
 misc/translator/LangInstaller.pm                   |    2 +-
 tools/modborrowers.pl                              |    3 --
 12 files changed, 36 insertions(+), 39 deletions(-)
 rename {acqui => Koha}/pdfformat/layout2pages.pm (99%)
 rename {acqui => Koha}/pdfformat/layout2pagesde.pm (99%)
 rename {acqui => Koha}/pdfformat/layout3pages.pm (99%)
 rename {acqui => Koha}/pdfformat/layout3pagesfr.pm (99%)

hooks/post-receive
-- 
main Koha release repository