[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.12-11-g4c83922
Git repo owner
gitmaster at git.koha-community.org
Wed Nov 28 12:20:40 CET 2018
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 17.11.x has been updated
via 4c839227058208b73893f1bd3615ebf05e94581c (commit)
via dc499a612eb5f8ac2b31c6ca39aaad4c1a3918e7 (commit)
via d337d5efd3a7466f9fcd7623fe0047efa3037de4 (commit)
via a4dc8b7c8dc2adb7cdecd4f7b1ccf8334cd2664b (commit)
via 9a6f56fc2bc086e2cb3c2554bab0009bcb9a0bf8 (commit)
via 35cbbd8de9d858e38f87dcfdd4e19f8f4ec6e6a6 (commit)
via 1671f009e61d6e0fffaa5a627e5e85fcadf8f7fc (commit)
via 4adc6ca70ef4a8605d71ff8f8fd6a1b6df1a7ef0 (commit)
via 1ad17b4484c27c705a61e785709f36bf4b543c03 (commit)
via 8617db86e6db72c39848a49c75a013a3014e9af3 (commit)
via 0b3b8498157e42988e5d1782a20ccf94258c4d61 (commit)
from ffb903404d24eb92083c4b4f9afdce25547a267e (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 4c839227058208b73893f1bd3615ebf05e94581c
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Fri Sep 14 16:06:49 2018 -0700
Bug 21349: Instructors with special characters in cardnumber cannot be removed from course reserves
The cardnumber can contain strange non-javascript-friendly
characters. This patch converts all the internal references
to borrowernumber, but displays the cardnumber when showing
list of matching users.
TEST PLAN
---------
1) Make sure Course Reserves is being used. Check system preferences.
2) Make sure there is a Course entered.
3) Make sure there is a patron with an cardnumber which breaks
the existing javascript (eg. Ka-boom:Ka-boom!KABOOM@#$!)
4) Go into the course list.
5) Click the course name link
6) In the "Instructor Search" box enter the patron name.
7) Select the patron which has the ugly cardnumber.
8) Click Save
-- The course listing should have the new teacher listed.
9) Click the course name link again.
10) Click 'Remove' beside the instructor's name.
-- nothing happens, and inspecting the error console gives
you the ugly error described in comment #0
11) apply this patch
12) restart_all
13) sudo service apache2 restart
14) refresh the page.
15) click 'Remove' beside the instructor's name.
-- name is removed.
16) Click Save
-- the course listing no longer lists the new teacher.
17) Actually confirm that adding and removing others normally
works as expected.
18) run koha qa test tools.
Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 2ca766f39245e1c3bd9b4acc9ce01a9eeaec8a56)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 827da7b676d8cbe42f696613541d1217d3f9370a)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit dc499a612eb5f8ac2b31c6ca39aaad4c1a3918e7
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Oct 24 19:50:02 2018 -0300
Bug 21654: Remove refund_lost_item_fee_rules.sql from the installer process
This is a follow-up patch for bug 14048 comment 97
Test plan:
git grep refund_lost_item_fee_rules.sql
should not return any results
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 51ce2ebfe12e344beec4d73109e885c5c303347c)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit faf4548438505f81dfb80b18018b3d460edd1ad9)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit d337d5efd3a7466f9fcd7623fe0047efa3037de4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Oct 22 17:02:51 2018 -0300
Bug 21629: Use cn_sort instead of itemcallnumber when displaying a list
DBMS can sort callnumbers correctly using cn_sort. We should use it
showing a list's content.
Test plan:
- Add items with callnumber to a list
- Display the list
- List the content by callnumbers
=> Confirm that the records are correctly sorted by callnumber
Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 20cba0d2956de5b1ff38b4a5f4b0f620204930e0)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 3d751067b771051e160e8d834fe346276ec93e12)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit a4dc8b7c8dc2adb7cdecd4f7b1ccf8334cd2664b
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sun Oct 21 02:34:25 2018 +0000
Bug 21625: Fix wording and typo in SMSSendDriver system preference description
SMSSendDriver was missing an S.
Koha is sending not receiving messages, so I think switching
that will be a little more clear.
To test:
Verify that the system preference description reads correctly.
Signed-off-by: Andreas Roussos <arouss1980 at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 9d0fc26c4335fc9be7a01e3069c458e9397fc94f)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 883672e7740d955aa2f29b1eb69036145582ec63)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 9a6f56fc2bc086e2cb3c2554bab0009bcb9a0bf8
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Wed Oct 17 01:39:41 2018 +0000
Bug 21005: Address QA tool failures on tabs
Only whitespace changes.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit b2070ef98b74908860556872cc08c0b2ce74b8b1)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 0f719ee1b0d87ef7243c0824a1555c9399000cf8)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 35cbbd8de9d858e38f87dcfdd4e19f8f4ec6e6a6
Author: David Cook <dcook at prosentient.com.au>
Date: Fri Aug 10 18:08:13 2018 +1000
Bug 21005: Missing row/column defaults cause unexpected results in report wizards
Some report wizards are missing row/column defaults, which sometimes return blank
pages (borrowers_stats.pl) or results always equalling 0, which a non-discerning
user may interpret incorrectly.
If the DEBUG environmental variable is enabled, missing row/column choices will
actually cause fatal software errors as well, which is also undesirable for users.
This patch adds default choices for row and column on
report wizards that had no radio buttons selected, so that a user
can't submit the form without choosing a row and column. This
prevents errors.
To test:
1) Apply patch
2) Visit /cgi-bin/koha/reports/issues_avg_stats.pl
3) Visit /cgi-bin/koha/reports/borrowers_stats.pl
4) Visit /cgi-bin/koha/reports/catalogue_stats.pl
5) Visit /cgi-bin/koha/reports/issues_stats.pl
6) Observe that default choices for row/column are there
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 6a451360b8fd0a56dd07be050cdecf538d890612)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 4edef313918d8930de54d532089ed66c981bbb6e)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 1671f009e61d6e0fffaa5a627e5e85fcadf8f7fc
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Tue Apr 17 23:59:58 2018 +0000
Bug 20592: Return early in ModItem if nothing to update
Two lines of code and move them earlier.
Add a check to make sure there are changes.
Followed the test plan, both the _BEFORE_ and after do as described.
Signed-off-by: Cori Lynn Arnold <carnold at dgiinc.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 1f0064bbddb9d00529d5eac1c096e669732eb551)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 75d6195c0ef36c4da244c4e2e2341696c94642c1)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 4adc6ca70ef4a8605d71ff8f8fd6a1b6df1a7ef0
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Apr 24 15:53:02 2018 -0300
Bug 20592: Add tests
NOTE: It isn't really a test, but it does trigger
the return line which was added to ModItem.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 619eca1c7aaebf4db6ed170a3cbd14065da79c9d)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 02860425d9ed9229664dc1d977f1d45ce83bcb50)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 1ad17b4484c27c705a61e785709f36bf4b543c03
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Oct 5 12:50:26 2018 +0000
Bug 21497: [17.11.x] Correctly format dates for ILL requests in OPAC
This patch updates the opac ILL template to use the $KohaDates plugin
for displaying dates. Also updated:
- Added "title-string" sorting to allow for correct sorting of dates in
the table of requests.
To test, apply the patch and log in to the OPAC as a user who has
multiple outstanding ILL requests.
- In the table of ILL requests, the "Request placed" and "Last updated"
dates should be formatted according to your system's dateformat
preference.
- Sorting of those columns should work correctly.
- View a request and confirm that "Request placed" and "Last updated"
dates in this view are also formatted correctly.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit a2418f743ce1e14d32229b5dd8d05aeb13f9e664)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit e68d3d988497289656bcf12b7f260cdc91cbc176)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 8617db86e6db72c39848a49c75a013a3014e9af3
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Sat Oct 13 09:17:00 2018 -0300
Bug 18959: Skip xt/author/Text_CSV_Various.t if Text::CSV::Unicode missing
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit ca9a1b76d8d729b1c09dbedbd90bd3f748351c4b)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 882e18500c0ace2a1df7ad7ad3e38ece865a2953)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 0b3b8498157e42988e5d1782a20ccf94258c4d61
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Sat Oct 13 09:15:52 2018 -0300
Bug 18959: Text::CSV::Unicode missing from dependencies
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit eb3f78f82e8139739a17c11cc89f58865d7536b0)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 7d4756c89741958e22714730793cc200e276686f)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Installer.pm | 1 -
C4/Installer/PerlDependencies.pm | 5 +++++
C4/Items.pm | 5 +++--
course_reserves/mod_course.pl | 2 +-
.../prog/en/modules/admin/preferences/patrons.pref | 2 +-
.../prog/en/modules/course_reserves/course.tt | 18 +++++++++---------
.../prog/en/modules/reports/borrowers_stats.tt | 4 ++--
.../prog/en/modules/reports/catalogue_stats.tt | 8 ++++----
.../prog/en/modules/reports/issues_avg_stats.tt | 4 ++--
.../prog/en/modules/reports/issues_stats.tt | 4 ++--
.../bootstrap/en/modules/opac-illrequests.tt | 13 +++++++------
opac/opac-shelves.pl | 2 +-
t/db_dependent/Items.t | 6 ++++++
virtualshelves/shelves.pl | 2 +-
xt/author/Text_CSV_Various.t | 20 ++++++++++++++------
15 files changed, 58 insertions(+), 38 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list