[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.12-32-g4cdab45
Git repo owner
gitmaster at git.koha-community.org
Wed Nov 28 15:56:16 CET 2018
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 17.11.x has been updated
via 4cdab45880ac12655438a63a098f15e94f05d64d (commit)
via f504fbfcbc4ffedb9d05f1326d53618675e93b4e (commit)
via aac9f41bc316e891bcef59ae14cad8da85cd2c08 (commit)
via 717dc940fa7424adb564284da7923bb62ecec1b5 (commit)
via 6cac87dc9feacb9e514277fd6ed284779fa87a2f (commit)
via 8bf9d17a3807aa0fd2ac408fc9bdcc1d9bda21be (commit)
via e3e89c1b768605a810cae5d0e910adace4de150c (commit)
via ad8e9ab3b26ecbda5ae8cd1c07c25a9c63592da3 (commit)
via ed81686c23665288d8b12e4e02269932a6d63d76 (commit)
via 1e1449bf185a3eb6e5996f0e48c8ee686072b929 (commit)
via fc014eb5be388926cd011eec3debe011a26ce51c (commit)
via 74e175bb145161f3bfadbaec618f5d37f724b737 (commit)
via 56f469e858eadbf369273777e7bc761324f6af08 (commit)
from 46a28ad7231fc1738c90bd0dbb94d24f2e31fc8d (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 4cdab45880ac12655438a63a098f15e94f05d64d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Oct 17 15:47:29 2018 -0300
Bug 21015: Remove unecessary 'use Koha::Schema' statements in t/
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 9fb827d59d0421b1f3e2de36239cef4c7411c666)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 26b9c4abac5795194a48aea017630b54e54f0fe5)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit f504fbfcbc4ffedb9d05f1326d53618675e93b4e
Author: Joonas Kylmälä <joonas.kylmala at iki.fi>
Date: Fri Jun 29 11:09:41 2018 +0300
Bug 21015: fix performance issue with C4::Members
loading Koha::Schema ("use Koha::Schema;") takes significantly time as
it loads almost a couple hundred classes. Koha::Database has done that
already once and we can use it to get the ResultSet "Borrower" as
well, so let's use that. This also make the code more unified because
Koha::Database is used throughout the code instead of Koha::Schema.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 83e0765f448c35c6f387d41fe39feb94b9bc64f3)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit f130fd6ec9538fff02582b6dae40e0445f607320)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit aac9f41bc316e891bcef59ae14cad8da85cd2c08
Author: David Cook <dcook at prosentient.com.au>
Date: Fri Oct 26 10:52:45 2018 +1100
Bug 21666: Replace unsupported use attribute with more widely supported attribute
search.js uses the 1=1004
author personal attribute which isn't supported by libraries like
Seattle Public Library.
This patch aligns search.js
with C4/Breeding.pm which uses the more widely supported 1=1003
author attribute.
To test:
1. Set up Seattle Public Library as a Z39.50 target
2. Try to search author using the Advanced Editor advanced search
3. Observe failure
4. Apply the patch
5. Try to search again
6. Observe successful retrieval of records
Signed-off-by: Cori Lynn Arnold <carnold at dgiinc.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit a08e72c5e72ebbd17cc088584d097ecfa6b1e4d2)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 8a166e2e294d193b3784bd0d7b031af54d2a8ff9)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 717dc940fa7424adb564284da7923bb62ecec1b5
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Oct 31 11:50:59 2018 -0300
Bug 21740: Show @ when editing fixed-length fields on bibliographic frameworks
This is a consistency issue: we store '@' as the subfield for
fixed-lenght fields, yet on editing '_' is displayed (on the form and
the tab). This was probably done to avoid URI encoding problems in the
past.
This patch restores the '@' everywhere.
To test:
- Open the MARC structure for any bibliographic MARC framework
- Choose Actions > Subfields on any fixed-length field
=> ERROR: Notice the tab has an underscore (_) and the subfield code is '_' as well.
- Cancel
=> SUCCESS: '@' is displayed on the list
- Apply this patch
- Restart all the things:
$ restart_all
- Choose Actions > Subfields on any fixed-length field
=> SUCCESS: '@' is displayed in the tab title, and on the 'Subfield
code' form field.
- Save some changes
=> SUCCESS: Things work correctly.
- Sign off :-D
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
Signed-off-by: Devinim <kohadevinim at devinim.com.tr>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit e520d699109958712212ead8b8935a63402e5b37)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit fc04b4b1bc0ee1fb423168e62ca6af9a207ac508)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 6cac87dc9feacb9e514277fd6ed284779fa87a2f
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Oct 24 01:17:51 2018 +0000
Bug 21640: Enable output to STDOUT for Itiva outbound script
To test:
1 - Enable the TalkingTechItivaPhoneNotification
2 - Copy 'HOLD' notice 'email' transport to the phone section
3 - Enable EnhancedMessagingPreferences
4 - Find a patron and enable 'phone' for the 'Hold filled' notice
Note: You might not be able to do this straightaway, bug 21639
If the phone box has a '-' and not a checkbox:
sudo koha-mysql kohadev
INSERT INTO message_transports (message_attribute_id,message_transport_type,is_digest,letter_module,letter_code) VALUES (4,'phone',0,'reserves','HOLD');
5 - Place a hold for the patron
6 - Check it in and confirm the hold to set it waiting
7 - sudo koha-shell kohadev
8 - perl misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl --type=RESERVE -w 0 -v
9 - Note the Output says it will be on STDOUT, but nothing is output
10 - Apply patch
11 - repeat
12 - Hold info is output to command line
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 12ed04eabb32cb957acd9f88d94ccada0ac09d07)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit c3243e912f28ffb874d1c9fa0389c89bf8a0183c)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 8bf9d17a3807aa0fd2ac408fc9bdcc1d9bda21be
Author: Magnus Enger <magnus at libriotech.no>
Date: Tue Oct 16 21:25:43 2018 +0200
Bug 21585: Ignore missing firstname in ILL requests table
To test:
- Make sure you have a patron with just a surname and no firstname
- Create an ILL request so that the name of this patron shows up in
the Patron column of the ILL requests table
- Before the patch, the name will display as "null Surname"
- Apply the patch
- Reload the ILL requests page
- The name should now display as just "Surname"
- Sign ye merrily off
Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 5ea877f6cba299373e0ebb9c59f8797baba98bec)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit da971a81da893ca625d78b172ccab8f4131a8664)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit e3e89c1b768605a810cae5d0e910adace4de150c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Oct 16 14:52:25 2018 -0300
Bug 21556: Do not crash if a biblio is deleted twice
To recreate:
- Go to a bibliographic detail page
- Delete it
- Go back
- Delete it again
=> Without this patch you will get a 500
Can't call method "holds" on an undefined value at
/home/vagrant/kohaclone/C4/Biblio.pm line 406.
=> With this patch applied it will silently redirect you to the search
form.
Note: We could/should improve the behavior and display a message, but
DelBiblio will need to be moved to Koha::Biblio->delete and other
callers adjusted
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 515ed462cff54afd0725471c977d437fbeb54aa4)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit b5148f412b741d1342c564360c690f14c9be6b94)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit ad8e9ab3b26ecbda5ae8cd1c07c25a9c63592da3
Author: David Cook <dcook at prosentient.com.au>
Date: Fri Oct 12 01:53:22 2018 +0000
Bug 21556: Deleting same record twice leads to fatal software error
If you delete a record, confirm the deletion, and try to delete the
record and confirm it again befoe the first deletion completes, you'll
generate a fatal software error.
This patch unbinds the click handlers for the "Delete record" button
after the deletion is confirmed and just before the Javascript
processes the redirect to the next page in the process.
To test:
1) You will need a bibliographic record that is able to be deleted
2) Click "Edit", then "Delete record", then "OK"
3) While the browser is reloading, click "Edit", then "Delete record",
then "OK
4) Observe a fatal error such as "Internal server error" or 'Can't call
method "holds" on an undefined value at
/home/vagrant/kohaclone/C4/Biblio.pm line 406.'
5) Apply the patch
6) Run "restart_all" on kohadevbox (or otherwise restart Plack if
running Plack)
7) Navigate to another bibliographic record that is able to be deleted
8) Click "Edit", then "Delete record", then "OK"
9) While the browser is reloading, click "Edit", then "Delete record"
10) Observe that no fatal software error is generated
11) You are redirected to
http://localhost:8081/cgi-bin/koha/catalogue/search.pl (on kohadevbox)
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 9d78af26d96dd356a1ca05199c0fec20cd5077e1)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 4f239147fc240d1f8caa49d3722b712758b9ed77)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit ed81686c23665288d8b12e4e02269932a6d63d76
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Mon Oct 29 19:59:00 2018 +0000
Bug 21698: (QA follow-up) Fix typo verbosev -> verbose
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 04114d4b835c10bb03b9c092268fc632d5552fed)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 776423df10e6237be78420ef63e1a53694cb884d)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 1e1449bf185a3eb6e5996f0e48c8ee686072b929
Author: Magnus Enger <magnus at libriotech.no>
Date: Fri Oct 26 22:47:16 2018 +0200
Bug 21698: Fix POD of cancel_unfilled_holds.pl
To test:
- Run "perldoc misc/cronjobs/holds/cancel_unfilled_holds.pl"
- Notice some problems:
-- No description in the NAME section
-- Descriptions of options in the SYNOPSIS section
-- A literal head1
-- Long options are listed with a single leading dash
-- Options --verbose and --confirm are not listed under OPTIONS)
- Take a look at the script itself to see that --verbose and
--confirm should be listed.
- Also note the typo on line 97: 'v|verbosev' => \$verbose,
- Apply the patch
- Look at the script and perldoc again and check that all problems
described above are now fixed.
Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit b7b6727f92615bcebf2f037202e6647a34c7705a)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 77969527962b4f8c098b59f50989bbea26831803)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit fc014eb5be388926cd011eec3debe011a26ce51c
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Mon Jun 5 11:55:12 2017 +0200
Bug 18720: Use exception instead of die in GetBasketAsCsv
Test plan:
prove t/db_dependent/Acquisition/GetBasketAsCSV.t
Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 77ea4686395f88c9678c611a78e6db4fd4c04101)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 1ee7a438b2dc18e2a202795bb4203b58a0c36674)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 74e175bb145161f3bfadbaec618f5d37f724b737
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Aug 13 13:39:42 2018 +0000
Bug 10442: Remove references to non-standard "error" class
The CSS for <div class="error"> is obsolete and should not be used. This
patch removes the definition from the main CSS file and corrects
instances of its use in the templates to the standard <div class="dialog
alert">.
To test:
- In Acquisitions -> Late orders, locate an order from a vendor which
doesn't have an email address. Selecting that order and clicking
"Claim" should trigger an error dialog, "This vendor has no email." It
should be styled correctly.
- With AcqCreateItem set to "when placing an order," add to an existing
order using the "From a new (empty) record" option. Add two items with
identical barcodes and submit the form. A error should show at
the top of the page.
- With AcqCreateItem set to "when receiving an order," receive an order
and add two items with identical barcodes. Submitting the form should
trigger an error message at the top of the page.
With the remaining cases I don't know how to trigger the errors in
question, so a visual check of the changes may be required:
- Administration -> Funds -> "You are not authorized to modify this
fund"
- Administration -> Search engine configuration
(/admin/searchengine/elasticsearch/mappgings.pl) -> Various
modification errors.
- With the AutoEmailOpacUser preference set to "send," adding a patron
without an email address can trigger an error, "This member has no
email."
- With plugins enabled, and installed, there are error messages
displayed under various circumstances.
Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 52028d9932ce1d10ad690261d8f6983b074b2909)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 3557009b1668f9fbc20222fd4c2351b99beee5b8)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
commit 56f469e858eadbf369273777e7bc761324f6af08
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Oct 29 19:23:53 2018 -0300
Bug 21080: Fix patron's attributes display when PA_CLASS is used
When a patron attribute class (AV PA_CLASS) is created, the patron's
edit view is broken:
https://screenshots.firefox.com/62uNhoUtH6rPXm9l/pro.kohadev.org
To recreate:
1. Create 1+ authorised values PA_CLASS
2. Create patron's attributes using it
3. Edit a patron
it depends on the order of the fieldset and the ol elements
This is certainly not the best fix but the display does not look broken!
Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 559e051bb9eecbc92f63aa2941caea6ee373fe0e)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
(cherry picked from commit 2b746513b4c2454ccc594510c277c059b56a8797)
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Acquisition.pm | 3 +-
C4/Biblio.pm | 5 ++-
C4/Members.pm | 3 +-
admin/marc_subfields_structure.pl | 3 +-
.../intranet-tmpl/lib/koha/cateditor/search.js | 2 +-
.../prog/en/modules/acqui/lateorders.tt | 6 ++--
.../prog/en/modules/acqui/neworderempty.tt | 2 +-
.../prog/en/modules/acqui/orderreceive.tt | 2 +-
.../prog/en/modules/admin/aqbudgets.tt | 2 +-
.../en/modules/admin/marc_subfields_structure.tt | 6 ++--
.../admin/searchengine/elasticsearch/mappings.tt | 4 +--
.../prog/en/modules/ill/ill-requests.tt | 11 +++---
.../prog/en/modules/members/memberentrygen.tt | 14 ++++----
.../prog/en/modules/plugins/plugins-home.tt | 8 +++--
koha-tmpl/intranet-tmpl/prog/js/additem.js | 10 +++---
koha-tmpl/intranet-tmpl/prog/js/catalog.js | 1 +
misc/cronjobs/holds/cancel_unfilled_holds.pl | 38 ++++++++++----------
.../thirdparty/TalkingTech_itiva_outbound.pl | 2 +-
t/Koha_ExternalContent_OverDrive.t | 2 --
t/Members/cardnumber.t | 1 -
t/db_dependent/Acquisition/GetBasketAsCSV.t | 14 ++++++--
t/db_dependent/Biblio.t | 12 ++++++-
t/db_dependent/Sitemapper.t | 1 -
t/lib/Mocks.pm | 1 -
24 files changed, 87 insertions(+), 66 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list