[koha-commits] main Koha release repository branch master updated. v18.11.00-16-ga3036b4

Thu Nov 29 20:29:16 CET 2018

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  a3036b4760d80dd3d2188f5f95c6f4279ecef74b (commit)
       via  99535e0fda491d2e1d704dd80f6613c0a7b8d06b (commit)
       via  4302bdda5c1c348e63003589795af3d37249c167 (commit)
       via  5fc2ccd7332ca53dfe07bd079cc446d1df923496 (commit)
       via  1176947b42342ca725020455361fe092255e4d04 (commit)
       via  98bfe5d93cb6715b3095309082b241aaafe869da (commit)
       via  52b52ab896be2831309a6c3f3401a4118c7b0f33 (commit)
       via  d0e72b437332b1ef0b3bcee98616ac8fef3f1e7a (commit)
       via  5cacb502392aaebaef84339233227eb261d45277 (commit)
       via  ed22c5fc0f65cc3736a8dbabb159b6b4b9b2f7c4 (commit)
       via  f44a4f1d2a13735c52948df29e773728d04ab991 (commit)
       via  3e1e1448e9132dce81571a4c3f31eb67816f14f9 (commit)
       via  f99b9b5b3d88d8ed2eed0f64da0f5ef2a1483f3e (commit)
       via  d8531b8fcbfc8fe09540ddb940149a7d7dbb4fb9 (commit)
       via  bd81f0418c14af82cdd9f4858c32b18d76a90b49 (commit)
      from  1277351f1969ce32f06c6e1d5fc6bdc471dd5ac4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a3036b4760d80dd3d2188f5f95c6f4279ecef74b
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Tue Nov 27 20:28:29 2018 -0300

    Bug 18805: Add ability to use up account credits

    This patch introduces a new button in the 'Pay fines' tab  on the
    patron's account page. This button, labeled 'Normalize account' is only
    displayed when outstanding credits are available, that could be used to
    pay up existing debts.

    When clicking the button, the Koha::Account::normalize_balance method
    (bug 21896) is used for the purpose.

    To test:
    - Apply this patch (on top of 21896)
    - On a patron's 'Fines' tab, create a 'manual invoice' (maybe more than
      one)
    - Go to the 'Pay fines' tab
    => SUCCESS: No 'Apply credits' button is displayed.
    - On the 'create manual credit' tab, create a couple credits.
    - Go to the 'Pay fines'
    => SUCCESS: 'Apply credits' button is displayed
    - Click on 'Apply credits'
    => SUCCESS: Outstanding credits have been used to pay up debts.
    - Play with different options (credit excedes debts and vice-versa, they
            match, etc)
    => SUCCESS: They all work as expected
    - Sign off :-D

    Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 99535e0fda491d2e1d704dd80f6613c0a7b8d06b
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Thu Nov 29 13:49:27 2018 +0000

    Bug 21896: (QA follow-up) Document and Test for FIFO behaviour

    A short dicussion lead to the decision to make it explictly clear that
    this method will implicitly apply credits against debits in a 'First In
    First Out' manor, meaning oldest outstanding debits will be paid off
    first.

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 4302bdda5c1c348e63003589795af3d37249c167
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu Nov 29 10:55:51 2018 -0300

    Bug 21896: (QA follow-up) Add tests for FIFO behaviour

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 5fc2ccd7332ca53dfe07bd079cc446d1df923496
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Nov 28 10:24:36 2018 -0300

    Bug 21896: (QA follow-up) normalize_balance -> reconcile_balance rename

    This was requested on the QA review and I agree.

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 1176947b42342ca725020455361fe092255e4d04
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Tue Nov 27 19:34:29 2018 -0300

    Bug 21896: Add Koha::Account::normalize_balance

    This patch adds the normalize_balance() method to Koha::Account. Its
    purpose is to apply outstanding credits (i.e. manual ones ore remaining
    amounts like in the case of refunds) to outstanding debts.

    To test:
    - Apply this patchset
    - Run:
      $ kshell
     k$ prove t/db_dependent/Koha/Account.t
    => SUCCESS: Tests pass!
    - Sign off :-D

    Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 98bfe5d93cb6715b3095309082b241aaafe869da
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Tue Nov 27 17:06:20 2018 -0300

    Bug 21896: Add unit tests for Koha::Account::normalize_balance

    Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 52b52ab896be2831309a6c3f3401a4118c7b0f33
Author: Nazlı Çetin <nazli at devinim.com.tr>
Date:   Thu Nov 29 14:50:29 2018 +0000

    Bug 7143: Update about page for Nazlı

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit d0e72b437332b1ef0b3bcee98616ac8fef3f1e7a
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Wed Nov 28 16:07:57 2018 +0100

    Bug 7143: Update OpenHub link for Fridolin Somers in about page

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 5cacb502392aaebaef84339233227eb261d45277
Author: Pasi Kallinen <pasi.kallinen at joensuu.fi>
Date:   Wed Oct 31 14:04:33 2018 +0200

    Bug 21736: Allow translating the localization widget messages

    The widget used to translate the item type names to other
    languages has few javascript messages that cannot be translated.
    Add the mechanism to enable their translation.

    Test plan:

    1) Install and update a language
    2) Check the po-files, there's no msgid for
       "A translation already exists for this language."
    3) Apply the patch
    4) Install and update a language
    5) There should be a msgid for the one in 2, and
       couple other messages from localization.tt
    6) Translate those messages, update the translated templates
    7) Go to Administration -> Item types -> Modify item type ->
       Translate into other languages
       Add a new translation, check that the message given by the widget
       was in correct language.

    Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi>

    Signed-off-by: Owen Leonard <oleonard at myacpl.org>

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit ed22c5fc0f65cc3736a8dbabb159b6b4b9b2f7c4
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Wed Nov 28 13:41:53 2018 -0500

    Bug 21905: Plugin hook intranet_catalog_biblio_enhancements_toolbar_button incorrectly filtered

    The new plugin hook intranet_catalog_biblio_enhancements_toolbar_button is rendered useless due to the outputted html being escaped using the html filter. It should be using the raw filter instead.

    Test Plan:
    1) Enable plugins
    2) Download and install the latest version of the Kitchen Sink plugin
       https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases/download/v2.1.21/koha-plugin-kitchen-sink-v2.1.21.kpz
    3) Browse to catalogue/detail.pl for a record
    4) Note you see the raw html of the plugin output in the toolbar
    5) Apply this patch
    6) Restart all the things
    7) Reload the page
    8) Note the html is now correctly rendered as a button

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit f44a4f1d2a13735c52948df29e773728d04ab991
Author: Andreas Roussos <arouss1980 at gmail.com>
Date:   Thu Nov 22 15:55:25 2018 +0200

    Bug 21861: (follow-up) replace onchange() with jQuery equivalent

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 3e1e1448e9132dce81571a4c3f31eb67816f14f9
Author: Andreas Roussos <arouss1980 at gmail.com>
Date:   Sat Nov 17 20:03:36 2018 +0200

    Bug 21861: The MARC modification template actions editor does not always validate user input

    The MARC modification template actions editor does not validate
    user input when adding a conditional clause, making it possible
    to save a modification action without filling in all necessary
    fields.

    This patch fixes that.

    Test plan:
    1) Create a MARC modification template and add a new action,
       e.g. "Copy All field(s) 200$a to field 600$a".
       Add a condition ("if" or "unless") but leave the relevant
       field and subfield textboxes empty.
       Add "matches" or "doesn't match" as a comparison operator.
       Check the "RegEx" checkbox, leave the regex textbox empty.
    2) Click on "Add action" and notice how it accepts your input.
       Also notice the extra space in the Action column RegEx.
    3) Edit your modification action and notice the missing "m/"
       before the conditional RegEx.

    4) Apply the patch and hit CTRL-F5 to reload the relevant JS.

    5) Edit the modification action you added previously (or add
       a new one). Try leaving the textboxes mentioned above empty
       and then submit your changes. You should get pop-up windows
       informing you about missing fields.
    6) Now try typing a value in the conditional regex textbox and
       Update your action. In the Action column, there should be
       no spaces between the delimiters of the matching operator
       and the value you just entered.
    7) Edit your action: notice how the "m/" before the regular
       expression and the "/" after it are now showing correctly.

    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit f99b9b5b3d88d8ed2eed0f64da0f5ef2a1483f3e
Author: Mirko Tietgen <mirko at abunchofthings.net>
Date:   Wed Nov 28 11:18:09 2018 +0100

    Bug 21897: Typo in postinst

    Small typo (missing space)

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit d8531b8fcbfc8fe09540ddb940149a7d7dbb4fb9
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Wed Nov 28 10:05:19 2018 +0100

    Bug 21895: Fix path to POT file

    Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit bd81f0418c14af82cdd9f4858c32b18d76a90b49
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Wed Nov 28 00:51:45 2018 +0100

    Bug 21895: Fix translation for package install

    The string extraction process was not taking into account the fact that
    standard/package install have a completely different directory structure
    than the dev install

    This patch tries to keep the exact same behaviour for dev installs,
    while making it work for standard install by using opachtdocs,
    intrahtdocs, opacdir and intranetdir from $KOHA_CONF

    Test plan:
    1. Follow test plan in
    https://gitlab.com/koha-community/Koha/commit/d708255c7a4d981c7c7bdd0644a75202ec43b297
    2. Do a standard install and repeat step 1 on this new install
    3. If you know how to build the Debian package, build it, install it and
    verify that koha-translate works as expected
    4. prove t/LangInstaller.t

    Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Account.pm                                    |   29 ++++
 Koha/Account/Line.pm                               |    8 +
 Koha/Schema/Result/Accountline.pm                  |    7 +-
 debian/koha-common.postinst                        |    2 +-
 docs/history.txt                                   |    2 +-
 .../intranet-tmpl/prog/en/includes/cat-toolbar.inc |    2 +-
 koha-tmpl/intranet-tmpl/prog/en/modules/about.tt   |    8 +-
 .../prog/en/modules/admin/localization.tt          |   16 +-
 .../intranet-tmpl/prog/en/modules/members/pay.tt   |   10 ++
 .../modules/tools/marc_modification_templates.tt   |    8 +-
 .../prog/js/marc_modification_templates.js         |   21 +++
 members/pay.pl                                     |   21 ++-
 misc/translator/LangInstaller.pm                   |   79 +++++++---
 t/LangInstaller.t                                  |   13 +-
 t/db_dependent/Koha/Account.t                      |  161 +++++++++++++++++++-
 15 files changed, 339 insertions(+), 48 deletions(-)

hooks/post-receive
-- 
main Koha release repository