[koha-commits] main Koha release repository branch master updated. v18.05.00-1043-ge757448

Git repo owner gitmaster at git.koha-community.org
Mon Oct 15 19:05:54 CEST 2018


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  e7574481b19addd2747baf5917e772d28cd38bc5 (commit)
       via  ed7f9a45453fa88dd2a6d17f07566931b6149678 (commit)
       via  5e2862c6b8eb102f623ccc4d667b4e38895703e4 (commit)
       via  936198ba6aebaace6d0bfab4f0d4667274872555 (commit)
       via  720d6360a0038a943b4554c4180cc0ebb61c2b4d (commit)
       via  e652f47cedfdf069b054b4f623ec5674640555ec (commit)
       via  cea8a72708e68b82eeeaaec2d985ec0a69dd4a11 (commit)
       via  a32c92c6013b199cc26efd15d0442e3f3a2eed6b (commit)
       via  d9b922f46f8d551949f337f29edef6985130c8ba (commit)
       via  bfbbe52ff7ff0ec93825684e4728db705b4100d1 (commit)
       via  c6c4d82325eb7d11b34a113c69acbff18e283542 (commit)
       via  ab13b53854e0aa726c8112d8f31cc553484637bd (commit)
       via  8d9284668c6de2d5fbfc4079a8b0516ba1645876 (commit)
       via  9965aa43e15aaa63fd8999daa98618d20698e89b (commit)
       via  c6198717c4be56ba99deb57aa6d117d23a032eea (commit)
       via  fd0df2ad55f9a5ff180dc0dfa22fede5f0ad37cd (commit)
       via  959162b2f3c9689bb56433ee08c300b40822d700 (commit)
       via  1a8e1165ca7abf9e2b7e5c7de0cdf26cbd4e30ac (commit)
       via  1fddd295b8e83b60f2b838f09f3175c5acfeec28 (commit)
       via  dab70daa55a90f7b50f8c2dc9fefdef0762e5daf (commit)
       via  3f09e1d73338c86762412546e1a0617df698f422 (commit)
       via  b23fe0b0b8d468fe80d40aef1a12296421cc1d37 (commit)
       via  9c6025ccbfd0c57d45fec444ee57e72c3aad512b (commit)
       via  3e6f9b8a1d5b293cfe5a00732e2b6f1371046855 (commit)
       via  b1bb9f9e6b028dce0109755180100e4033424227 (commit)
      from  3950dd4f6c42a865a584bad3fea2d81e0282dcc1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e7574481b19addd2747baf5917e772d28cd38bc5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Oct 15 11:42:34 2018 -0300

    Bug 21479: Zebra index can return different result
    
    If the zebra index has been rebuilt by previous tests, the order/results
    will be different, and we will not have biblionumber 1, 3, 5
    
    Let make this more flexible
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit ed7f9a45453fa88dd2a6d17f07566931b6149678
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Mon Aug 13 13:55:31 2018 +0000

    Bug 18480: Get rid of unwanted / distracting link in patron search for fund owner
    
    This patch modifies templates where a pop-up window is used to display
    patron search results. A link has been added to the patron name which
    triggers a modal window displaying more details about that patron. With
    each page in the test plan, check that clicking linked names in search
    results triggers a modal with the correct data.
    
     - Acquisitions -> Vendor -> View basket -> Add user
     - Acquisitions -> Vendor -> Add to basket -> From a new (empty) record
       -> Add user
     - Acquisitions -> Funds -> Edit fund -> Select owner
     - Tools -> Patron card creator -> Manage -> Card batches -> Edit -> Add
       patrons
     - Serials -> Subscription -> Edit routing list -> Add recipients
    
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 5e2862c6b8eb102f623ccc4d667b4e38895703e4
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Oct 15 14:14:37 2018 +0000

    Bug 21337: (RM follow-up) Adjust number of tests
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 936198ba6aebaace6d0bfab4f0d4667274872555
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Mon Oct 1 09:52:21 2018 +0200

    Bug 21337: (QA follow-up) Rollback for partial delete
    
    Puts delete loop in a txn_do.
    Raises Koha::Exceptions::Patron::Delete when Patron->delete does not return
    true (like 0 or -1).
    Unit test adjusted accordingly.
    
    Note: A follow-up report for raising exceptions in Object->delete could well
    be considered. Not here please.
    
    Test plan:
    Run t/db_dependent/Koha/Patrons.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 720d6360a0038a943b4554c4180cc0ebb61c2b4d
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Thu Sep 13 12:26:57 2018 +0200

    Bug 21337: (follow-up) Add parameter for move_to_deleted action
    
    For consistency, it would be better to make the move optional.
    
    Test plan:
    Run again t/db_dependent/Koha/Patrons.t.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit e652f47cedfdf069b054b4f623ec5674640555ec
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Wed Sep 12 15:49:45 2018 +0200

    Bug 21337: Add Koha::Patrons->delete (trivial wrapper)
    
    Adds Koha::Patrons->delete as wrapper around Koha::Patron->delete. We do
    not want to bypass Koha::Patron and let DBIx do the job without further
    housekeeping. A call to move_to_deleted is included now, but could be
    made optional with a parameter if needed.
    
    Test plan:
    Run t/db_dependent/Koha/Patrons.t
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit cea8a72708e68b82eeeaaec2d985ec0a69dd4a11
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Tue Sep 25 18:40:28 2018 +0000

    Bug 21409: Add column configuration to course reserves
    
    This patch adds columns configuration and print/export options to two
    tables: The table listing courses and the table listing titles reserved
    for a course.
    
    To test you should have more than one course and multiple title reserved
    for at least one course.
    
    - Apply the patch and go to Course reserves
      - In the table of courses, confirm that all DataTables controls work
        correctly: paging, filter, column visibility, export, etc.
      - View a course with multiple titles reserved. Test all DataTables
        controls on this table too.
    - Go to Administration -> Columns settings
      - Change the settings for the courses and reserves table and confirm
        that these changes are applied correctly.
    
    Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit a32c92c6013b199cc26efd15d0442e3f3a2eed6b
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Sat Aug 11 18:47:23 2018 +0000

    Bug 15139: Add non-public item notes to overdue report
    
    Sometimes libraries want to see internal notes on the overdue
    reports page, this patch adds the notes.
    
    Additional fixes:
    - Library column was always empty, now library displays
    - Replacement price was not formatted according to CurrencyFormat
    
    To test:
    - Make sure you have some overdue issues in your system
    - Circulation > Overdues report
    - Make sure everything displays as it should
      - Verify internal item note shows
      - Verify price is correctly formatted (syspref CurrencyFormat)
      - Library shows
    - Download list of overdues
      - Verify the new column displays
    
    Signed-off-by: Spencer <ssmith3 at mckinneytexas.org>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Amended patch: remove the branchcode line, added on its own bug report,
    see bug 21463
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit d9b922f46f8d551949f337f29edef6985130c8ba
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Thu Oct 11 15:59:13 2018 +0000

    Bug 21550: DataTables four button pagination uses the wrong icon for disabled buttons
    
    This patch modifies the DataTables CSS which styles "full_nubmers"
    controls which are disabled: First and Previous buttons on the first
    page of results, Next and Last buttons on the last page of results.
    These buttons should have gray icons instead of blue.
    
    To test, apply the patch and clear your browser cache if necessary. View
    a page which uses a "full_numbers" DataTables configuration, e.g.
    
    - Administration -> Cities
    - ILL requests -> List requests
    - Circulation -> Holds to pull
    
    Confirm that buttons in their disabled state have a gray icon and text
    instead of blue.
    
    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit bfbbe52ff7ff0ec93825684e4728db705b4100d1
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Wed Jul 25 14:37:59 2018 +0200

    Bug 21115: Add multi_param call and add divider in cache key in svc/report and opac counterpart
    
    Resolve things like:
    CGI::param called in list context from package CGI::Compile::ROOT::usr_share_koha_prodclone_opac_svc_report line 42, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436.
    
    The cache key in both script looks like:
        opac:report:id:602018
    but should for consistency be:
        opac:report:id:60:2018
    Note: The 2018 here is part of the sql_params and should not be
    concatenated to the report id.
    
    Test plan:
    Do not yet apply this patch.
    Make a report public, set cache to 300 secs.
    Check its output with opac/svc/report.
    Check for the warn in your log.
    Apply the patch, restart Plack and flush cache.
    Check opac/svc/report.
    Modify your report; e.g. add a simple string to the SELECT.
    Check opac/svc/report. You should still see cached output.
    Flush the cache.
    Check opac/svc/report. You should now see the added text.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Tested also by clearing individual keys with $cache->clear_from_cache.
    
    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit c6c4d82325eb7d11b34a113c69acbff18e283542
Author: Blou <philippe.blouin at inlibro.com>
Date:   Thu Oct 4 13:00:08 2018 -0400

    Bug 21291: (follow-up) Pass subscriptionsnumber to all tools in staff detail's sidebar
    
    The subscriptionsnumber is required in biblio-view-menu.inc to display
    the Subscription(s) tab. In detail.pl, if you click any of
    
    Labeled MARC  (you need to set the syspref viewLabeledMARC)
    Hold(s)
    Article requests
    Checkout history
    Modification log
    Rota          (you need to set the syspref StockRotation)
    
    you lose the Subscription(s) tab.
    
    This patch fixes the display by having each feature script generate that
    value to be passed to the UI. I keep this separated from the first patch
    since it's not exactly the same issue, and the solution might not
    please.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit ab13b53854e0aa726c8112d8f31cc553484637bd
Author: Blou <philippe.blouin at inlibro.com>
Date:   Thu Aug 30 10:33:44 2018 -0400

    Bug 21291: request-article.pl doesn't show MARC, LabeledMARC and ISBD in sidebar
    
    When on a detailed record in the intranet, any click on the sidebar
    will lead you to another page with the same sidebar EXCEPT for "Article
    requests".
    
    When clicking on article requests, you get a new sidebar without
    MARC
    Labeled MARC
    ISBD
    
    This fix adds the required C4::Biblio::enabled_staff_search_views that
    loads the required hash with the permissions.
    
    TEST
    0) login with a user having all rights
    1) go to any detailed notices, notice the sidebar on the left
    2) click on MARC
    3) notice the sidebar is the same in the new page
    4) click on Request articles
    5) notice the missing labels on the sidebar
    6) apply patch, redo steps
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 8d9284668c6de2d5fbfc4079a8b0516ba1645876
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Fri Feb 2 14:34:34 2018 +0100

    Bug 20131: Inventory optional filters correct "For loan" addition
    
    In inventory, optional filters are build from authorize values categories used for items.notforloan, items.itemlost, items.withdrawn and items.damaged.
    
    The bug is that description of value 0 is always "For loan".
    This seems to be only for "notforloan".
    
    Second bug is that if a description exists for "notforloan" value 0, it is not used.
    
    This patch corrects by adding "For loan" only for "notforloan" authorized values and if there is no 0 value.
    It changes the description added by code from "ignore" to a more unlikly user defined "__IGNORE__".
    
    Test plan:
    1) Make sure you have authorized values defined on items.notforloan, say "NFL" category, with at least a value and description but no 0 value
    2) Make sure you have authorized values defined on items.itemlost, say "LOST" category, with 0 = "Not lost" and 1 = "Lost"
    3) Go to inventory /cgi-bin/koha/tools/inventory.pl
    4) Without patch you see "For loan" on both items.notforloan and items.itemlost
    5) With patch you see "For loan" only in items.notforloan, you see for items.itemlost : "Not lost" and "Lost"
    6) Create in authorized values category "NFL" a value 0 with description "Available"
    7) Go to inventory /cgi-bin/koha/tools/inventory.pl
    8) Without patch you see "For loan" in items.notforloan for value 0
    9) With patch you see "Available" in items.notforloan for value 0
    
    Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 9965aa43e15aaa63fd8999daa98618d20698e89b
Author: Baptiste Wojtkowski <baptiste.wojtkowski at biblibre.com>
Date:   Tue May 23 08:54:00 2017 +0000

    Bug 18655: Correct the choose link in unimarc_field_210c value builder
    
    - Link 'choose' is now a button.
    - It doesn't call directly javascript anymore (use of listener).
    - field to load stored in html on the page (less escaping needed).
    
    Test plan :
    1) Use UNIMARC catalog
    2) Define unimarc_field_210c value builder on 210$c
    3) Define an autority type EDITORS with heading on 200$b
    4) Create an autority of this type with a single quote in heading, ie : l'avenir
    5) Index this new autority
    6) Edit a biblio record and launch 210$c value builder
    7) Search for new autority
    8) Click on 'Choose'
    => Heading should be pasted in 210$c
    
    Signed-off-by: David Nind <david at davidnind.com>
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit c6198717c4be56ba99deb57aa6d117d23a032eea
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Mon Oct 8 11:47:15 2018 +0100

    Bug 21113: Corrections to patron merge confirmation prompt
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit fd0df2ad55f9a5ff180dc0dfa22fede5f0ad37cd
Author: Margaret Hade <margaret at bywatersolutions.com>
Date:   Fri Sep 21 12:41:52 2018 -0700

    Bug 21351: Rename the Taiwanese language pack to use correct file name
    
    The words "Han (Simplified variant)" is appearing in the language name because the file is titled "zh-Hans-TW" when it should be titled "zh-Hant-TW". The database is set up to use "Hant" but it just incorrectly named.
    
    Test plan
    1. Apply patch.
    2. Install zh-Hant-TW on your Koha server.
    3. Navagate to I18N/L10N preferences and confirm that the english text description states (Traditional variant).
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Files on translate.kc.org have already been fixed by Bernardo.
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 959162b2f3c9689bb56433ee08c300b40822d700
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Wed Oct 10 15:02:14 2018 +0000

    Bug 21537: Fix typo for options_for_item_types
    
    To test:
     0 - Set UseACQFrameworkForBiblioRecords to 'Use'
     1 - Define a subfield in the ACQ framework linked to authorised value
     'itemtypes'
     2 - Make sure that field is visible
     3 - Create a purchase suggestion
     4 - Accept it
     5 - Go to Acquisitions
     6 - Find a vendor with an open basket, or create one
     7 - Add to the basket using a suggestion
     8 - Choose the suggestion
     9 - Internal server error
    10 - Apply patch
    11 - Place order form a suggestion again
    12 - Confirm that the field linked to itemtypes shows correctly
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 1a8e1165ca7abf9e2b7e5c7de0cdf26cbd4e30ac
Author: Ere Maijala <ere.maijala at helsinki.fi>
Date:   Mon Sep 17 01:13:55 2018 +0300

    Bug 21365: Call BiblioAutoLink from AddBiblio and ModBiblio
    
    This makes e.g. the advanced MARC editor, and anything that uses AddBiblio or
    ModBiblio honor BiblioAddsAuthorities.
    
    To test:
    1. Make sure BiblioAddsAuthorities and AutoCreateAuthorities preferences are enabled.
    2. Add a new record using advanced editor (enable EnableAdvancedCatalogingEditor to
    use it), include a previously non-existing author.
    3. Save the record and observe the author get an authority number.
    4. Add another author, save the record and make sure it also gets an authority number.
    
    Signed-off-by: Michal Denar <black23 at gmail.com>
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 1fddd295b8e83b60f2b838f09f3175c5acfeec28
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Wed Oct 10 13:43:40 2018 +0200

    Bug 21279: Fix   in transport cost matrix
    
    Test plan:
    On Home › Administration › Transport cost matrix you should no longer
    see " ".
    Fill some values and save, you should see the correct values.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit dab70daa55a90f7b50f8c2dc9fefdef0762e5daf
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Mon Oct 15 13:07:11 2018 +0000

    Bug 19687: (RM follow-up) Export correct function name
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 3f09e1d73338c86762412546e1a0617df698f422
Author: David Gustafsson <david.gustafsson at ub.gu.se>
Date:   Wed Sep 26 17:25:44 2018 +0200

    Bug 19687: Undefined subroutine in bulkmarcimport
    
    Bulkmarcimport produces undefined subroutine error for
    C4::Items::TransformMarcToKoha and C4::Items::GetMarcStructure
    probably caused by mutually recursive modules. Put exports in
    BEGIN clause before all the other imports.
    
    To test:
    1) Run bulkmarcimport.pl before applying patch and verify
    that undefined subroutine error occurs
    2) Apply patch
    3) Run bulkmarcimport.pl again and verify that no errors are
    produced
    
    Sponsored-by: Gothenburg University Library
    
    Signed-off-by: George Veranis <gveranis at gmail.com>
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit b23fe0b0b8d468fe80d40aef1a12296421cc1d37
Author: Dobrica Pavlinusic <dpavlin at rot13.org>
Date:   Thu Sep 6 13:21:53 2018 +0200

    Bug 21320: Holds to pull should honor syspref AllowHoldsOnDamagedItems
    
    Test plan:
    
    1. Set syspref AllowHoldsOnDamagedItems to Allow
    2. Create a hold on record with item which is damaged
    3. Verify that it doesn't appear in report
    4. Apply patch and verify that it's now visible
    
    Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 9c6025ccbfd0c57d45fec444ee57e72c3aad512b
Author: Alex Arnaud <alex.arnaud at biblibre.com>
Date:   Wed Feb 21 13:10:50 2018 +0000

    Bug 10382: Course reserves: handle empty values
    
    Test Plan:
    1) Create an item, do not set a collection code
    2) Add the item to a course, and choose to set a collection code
    3) Ensure the course is enabled, and the collection code is now visible
    4) Disable the course, ensure the collection code is no longer visible
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 3e6f9b8a1d5b293cfe5a00732e2b6f1371046855
Author: Alex Arnaud <alex.arnaud at biblibre.com>
Date:   Thu Mar 9 13:42:04 2017 +0000

    Bug 10382: Add unit tests for course items
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit b1bb9f9e6b028dce0109755180100e4033424227
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Wed Jun 5 10:01:17 2013 -0400

    Bug 10382: collection not returning to null when removed from course reserves
    
    Test Plan:
    1) Create an item, do not set a collection code
    2) Add the item to a course, and choose to set a collection code
    3) Ensure the course is enabled, and the collection code is now visible
    4) Disable the course, ensure the collection code is no longer visible
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Biblio.pm                                       |  155 +++++------
 C4/CourseReserves.pm                               |   89 ++-----
 C4/Items.pm                                        |   90 +++----
 Koha/Exceptions/Patron.pm                          |   14 +
 Koha/Patrons.pm                                    |   27 ++
 acqui/addorderiso2709.pl                           |    6 +-
 acqui/neworderempty.pl                             |    3 -
 admin/columns_settings.yml                         |   55 ++++
 catalogue/issuehistory.pl                          |    2 +
 catalogue/labeledMARCdetail.pl                     |    2 +
 catalogue/stockrotation.pl                         |    3 +
 cataloguing/addbiblio.pl                           |    3 -
 circ/overdue.pl                                    |    6 +-
 circ/pendingreserves.pl                            |    7 +-
 circ/request-article.pl                            |    4 +
 koha-tmpl/intranet-tmpl/prog/css/datatables.css    |   20 ++
 .../prog/en/modules/acqui/neworderempty.tt         |    3 +-
 .../en/modules/acqui/tables/members_results.tt     |    2 +-
 .../prog/en/modules/admin/columns_settings.tt      |    6 +
 .../prog/en/modules/admin/transport-cost-matrix.tt |    2 +-
 .../value_builder/unimarc_field_210c.tt            |   13 +-
 .../intranet-tmpl/prog/en/modules/circ/overdue.tt  |    5 +-
 .../prog/en/modules/common/patron_search.tt        |   36 +++
 .../en/modules/course_reserves/add_items-step2.tt  |    8 +-
 .../en/modules/course_reserves/course-details.tt   |   22 +-
 .../en/modules/course_reserves/course-reserves.tt  |   14 +-
 .../en/modules/members/tables/members_results.tt   |    2 +-
 .../prog/en/modules/patron_lists/list.tt           |    4 +-
 .../modules/patroncards/tables/members_results.tt  |    2 +-
 .../en/modules/serials/tables/members_results.tt   |    2 +-
 .../prog/en/modules/tools/inventory.tt             |    2 +-
 ...TW-marc-MARC21.po => zh-Hant-TW-marc-MARC21.po} |    0
 ...-marc-NORMARC.po => zh-Hant-TW-marc-NORMARC.po} |    0
 ...-marc-UNIMARC.po => zh-Hant-TW-marc-UNIMARC.po} |    0
 ...c-bootstrap.po => zh-Hant-TW-opac-bootstrap.po} |    0
 .../po/{zh-Hans-TW-pref.po => zh-Hant-TW-pref.po}  |    0
 ...s-TW-staff-prog.po => zh-Hant-TW-staff-prog.po} |    0
 opac/svc/report                                    |    4 +-
 reserve/request.pl                                 |    2 +
 svc/report                                         |    4 +-
 t/db_dependent/CourseReserves/CourseItems.t        |  268 ++++++++++++++++++++
 t/db_dependent/Koha/Patrons.t                      |   27 +-
 t/db_dependent/selenium/regressions.t              |   14 +-
 tools/inventory.pl                                 |    2 +-
 tools/viewlog.pl                                   |    2 +
 45 files changed, 666 insertions(+), 266 deletions(-)
 create mode 100644 Koha/Exceptions/Patron.pm
 rename misc/translator/po/{zh-Hans-TW-marc-MARC21.po => zh-Hant-TW-marc-MARC21.po} (100%)
 rename misc/translator/po/{zh-Hans-TW-marc-NORMARC.po => zh-Hant-TW-marc-NORMARC.po} (100%)
 rename misc/translator/po/{zh-Hans-TW-marc-UNIMARC.po => zh-Hant-TW-marc-UNIMARC.po} (100%)
 rename misc/translator/po/{zh-Hans-TW-opac-bootstrap.po => zh-Hant-TW-opac-bootstrap.po} (100%)
 rename misc/translator/po/{zh-Hans-TW-pref.po => zh-Hant-TW-pref.po} (100%)
 rename misc/translator/po/{zh-Hans-TW-staff-prog.po => zh-Hant-TW-staff-prog.po} (100%)
 create mode 100644 t/db_dependent/CourseReserves/CourseItems.t


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list