[koha-commits] main Koha release repository branch master updated. v18.05.00-1078-g17e5691

Thu Oct 18 16:36:15 CEST 2018

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  17e5691daaa0f6b73623198eded648c78e40056a (commit)
       via  b7da4f890b9d9a7b2a919ce8529198ab443115cd (commit)
       via  573d9dafc10cb82e0f80f6fbbd8214ec88cfa3b6 (commit)
       via  489c636316209d4f4e7d8648cc5832347e792076 (commit)
       via  f19a99209528e85003cd56104640effe75e4f126 (commit)
       via  82884b0bd81a79c9a0c700463f1fcc632314863c (commit)
       via  a40b8ebde788ac4082670e30b03fcbade2cc5544 (commit)
       via  33c142ba3b7cfd37dd90569de2a5802849b09ef5 (commit)
       via  60e00a332e2a500746f12908042dd61250d1f79a (commit)
       via  7eb4d3f8a1537e1c9eea478f0802b30fae7690db (commit)
       via  5024cb3acffdfb9f67dce5587eb062ea3130bdbb (commit)
       via  f8e7a175575649ab1303c65ae259501dda90f3ff (commit)
       via  9e253d7bced1d10d7e3975871db985debba5a497 (commit)
      from  87c7e534f15aff14d6e82cbb67ecbb8e8715c2b7 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 17e5691daaa0f6b73623198eded648c78e40056a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Oct 18 11:07:02 2018 -0300

    Bug 20521: Use a specific config for strict sql modes

    To avoid disrupting testers and new developers it will be turned off by default.

    We will turn it on for Jenkins so devs will have to take care of the
    regressions they introduce (!)

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit b7da4f890b9d9a7b2a919ce8529198ab443115cd
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Oct 17 20:24:09 2018 -0300

    Bug 21597: Incorrect decimal value: 't_value_bib639' for column 'price'

    Fix t/db_dependent/selenium/basic_workflow.t

    We want to send specific values depending on the data type in DB
    For instance integer, or varchar(10)

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 573d9dafc10cb82e0f80f6fbbd8214ec88cfa3b6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Oct 17 19:26:32 2018 -0300

    Bug 21597: Field 'description' doesn't have a default value

    Nick proposed another fix, see bug 21594.
    The interface does not explode so I do not think we should make a DB
    update in a rush.

    Fix t/db_dependent/Koha/Object.t and t/db_dependent/Koha/ApiKeys.t

    api_keys.description and api_keys.secret:
      `secret` varchar(191) COLLATE utf8mb4_unicode_ci NOT NULL,
      `description` varchar(255) COLLATE utf8mb4_unicode_ci NOT NULL,

        #   Failed test 'Exception is thrown correctly'
        #   at t/db_dependent/Koha/Object.t line 262.
        # expecting: Koha::Exceptions::Object::FKConstraint
        # found: DBIx::Class::Exception (DBIx::Class::Storage::DBI::_dbh_execute(): Field 'description' doesn't have a default value at /home/vagrant/kohaclone/Koha/Object.pm line 125
        # )
        # Looks like you planned 7 tests but ran 1.
        # Looks like you failed 1 test of 1 run.

    and later, but not related:
    Can't locate object method "message" via package
    "DBIx::Class::Exception" at t/db_dependent/Koha/Object.t line 264.

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 489c636316209d4f4e7d8648cc5832347e792076
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Oct 17 19:21:56 2018 -0300

    Bug 21597: Incorrect date value: '0' for column 'onloan'

    Fix t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t

    items.onloan
      `onloan` date DEFAULT NULL,

    DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect date value: '0' for
    column 'onloan' at row 1 at /home/vagrant/kohaclone/t/lib/TestBuilder.pm
    line 288

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit f19a99209528e85003cd56104640effe75e4f126
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Oct 17 19:18:58 2018 -0300

    Bug 21597: Data too long for column 'invitekey'

    Fix t/db_dependent/Virtualshelves.t

    virtualshelfshares.invitekey
      `invitekey` varchar(10) COLLATE utf8mb4_unicode_ci DEFAULT NULL,

    We should not insert a longer string!

    DBIx::Class::Storage::DBI::_dbh_execute(): Data too long for column
    'invitekey' at row 1 at /home/vagrant/kohaclone/Koha/Object.pm line 125

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 82884b0bd81a79c9a0c700463f1fcc632314863c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Oct 17 19:11:29 2018 -0300

    Bug 21597: Field 'amount' doesn't have a default value

    Fix t/db_dependent/Accounts.t

    Default value could be 0, or left as it.
    It seems that the different initialisation we have in the code pass a
    value for 'amount'

    account_offsets.amount
      `amount` decimal(26,6) NOT NULL,

    DBIx::Class::Storage::DBI::_dbh_execute(): Field 'amount' doesn't
    have a default value at /home/vagrant/kohaclone/Koha/Object.pm line 125

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit a40b8ebde788ac4082670e30b03fcbade2cc5544
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Oct 17 19:07:20 2018 -0300

    Bug 21597: Column 'notforloan' cannot be null

    Fix t/db_dependent/Circulation.t

    items.notforloan:
      `notforloan` tinyint(1) NOT NULL DEFAULT '0',

    t/db_dependent/Circulation.t .. 115/119 DBD::mysql::st execute failed: Column 'notforloan' cannot be null [for Statement "UPDATE `items` SET `notforloan` = ? WHERE ( `itemnumber` = ? )" with ParamValues: 0=undef, 1='1046'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832.
            # No tests run!

        #   Failed test 'No tests run for subtest "item-level_itypes = 0"'
        #   at t/db_dependent/Circulation.t line 2356.
        # Looks like you failed 1 test of 2.

     #   Failed test 'CanBookBeIssued | notforloan'
     #   at t/db_dependent/Circulation.t line 2359.
    Can't locate object method "rethrow" via package "DBD::mysql::st execute failed: Column 'notforloan' cannot be null [for Statement "UPDATE `items` SET `notforloan` = ? WHERE ( `itemnumber` = ? )" with ParamValues: 0=undef, 1='1046'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832.

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 33c142ba3b7cfd37dd90569de2a5802849b09ef5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Oct 18 08:32:59 2018 -0300

    Bug 21599: Fix item type creation by defining default values

    Same as what we have in Koha::Patron->new, empty strings should not be
    inserted in integer or date column type

    DBD::mysql::st execute failed: Incorrect decimal value: '' for column 'defaultreplacecost' at row 1 [for Statement "INSERT INTO `itemtypes` ( `checkinmsg`, `checkinmsgtype`, `defaultreplacecost`, `description`, `hideinopac`, `imageurl`, `itemtype`, `notforloan`, `processfee`, `rentalcharge`, `searchcategory`, `sip_media_type`, `summary`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0="", 1="message", 2="", 3="xx", 4=0, 5='', 6="XX", 7=0, 8="", 9="", 10="", 11=undef, 12=""] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832.

    Test plan:
    Create a new itemtype

    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 60e00a332e2a500746f12908042dd61250d1f79a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Oct 17 19:31:14 2018 -0300

    Bug 21598: 'koha_kohadev.aqbudgets.budget_parent_id' isn't in GROUP BY

    DBD::mysql::db selectall_hashref failed:
    'koha_kohadev.aqbudgets.budget_parent_id' isn't in GROUP BY [for
    Statement "

        at /home/vagrant/kohaclone/C4/Budgets.pm line 558.
    and
        at /home/vagrant/kohaclone/C4/Budgets.pm line 565.

    Test plan:
    hit /cgi-bin/koha/admin/aqbudgets.pl

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 7eb4d3f8a1537e1c9eea478f0802b30fae7690db
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Oct 17 20:02:12 2018 -0300

    Bug 21596: Handle empty string for lost when storing a patron

    lost - should default to 0 at DB level, not null
    But let fix it as it for now

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 5024cb3acffdfb9f67dce5587eb062ea3130bdbb
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Oct 17 20:01:47 2018 -0300

    Bug 21596: Handle empty string for other attributes when storing a patron

    lastseen, updated_on => dates
    gonenoaddress, login_attempts, privacy_guarantor_checkouts => [tiny]int

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit f8e7a175575649ab1303c65ae259501dda90f3ff
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Oct 17 19:53:47 2018 -0300

    Bug 21596: Handle empty string for flags when storing a patron

    Incorrect integer value: '' for column 'flags'

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 9e253d7bced1d10d7e3975871db985debba5a497
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Oct 17 19:51:50 2018 -0300

    Bug 21596: Handle empty string for date_renewed when storing a patron

    Incorrect date value: '' for column 'date_renewed'

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Budgets.pm                                       |    4 ++--
 Koha/Database.pm                                    |    2 +-
 Koha/ItemType.pm                                    |   12 ++++++++++++
 Koha/Patron.pm                                      |   16 ++++++++++++++--
 Koha/Patrons/Import.pm                              |    2 +-
 t/db_dependent/Accounts.t                           |    6 +++---
 t/db_dependent/Circulation.t                        |    2 +-
 t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t |    2 +-
 t/db_dependent/Koha/ApiKeys.t                       |    2 +-
 t/db_dependent/Koha/Object.t                        |    3 ++-
 t/db_dependent/Virtualshelves.t                     |    4 ++--
 t/db_dependent/selenium/basic_workflow.t            |   19 ++++++++++++++++++-
 12 files changed, 58 insertions(+), 16 deletions(-)

hooks/post-receive
-- 
main Koha release repository