From gitmaster at git.koha-community.org Wed Sep 5 10:19:50 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 05 Sep 2018 08:19:50 +0000 Subject: [koha-commits] main Koha release repository branch 18.05.x updated. v18.05.03-1-g36abd06 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.05.x has been updated via 36abd064648cd88fa853e0f69726c1a68dc14fe5 (commit) from 20c85f636572aab559ff10839cef9ec09b0e914a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 36abd064648cd88fa853e0f69726c1a68dc14fe5 Author: Martin Renvoize Date: Wed Sep 5 09:05:03 2018 +0100 Bug 21068: Remove NorwegianPatronDB related code Bug 11401 introduced code to support Norwegian national library card. This code is too specific to be part of Koha as it, it should be a plugin instead. Moreover nobody uses it, but a modified version (see comment 3). RMaint: Rather than backporting the removal as is, I have created a deprecation warning to highlight the codes upcoming removal. Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Members.pm | 3 +++ 1 file changed, 3 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 5 12:11:13 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 05 Sep 2018 10:11:13 +0000 Subject: [koha-commits] main Koha release repository branch 18.05.x updated. v18.05.03-5-gf9f8c6b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.05.x has been updated via f9f8c6bbd0afeafa09554cf98f551228a6607952 (commit) via a87364d0ffbf906a4888f5d6d66e1a74cf280f58 (commit) via 3af501884e136454bca1c5a78c1a6b56e876f6be (commit) via 1bb7e7c0167be0feffc86b574620c5fc65120993 (commit) from 36abd064648cd88fa853e0f69726c1a68dc14fe5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f9f8c6bbd0afeafa09554cf98f551228a6607952 Author: Jonathan Druart Date: Wed Jul 25 12:25:58 2018 -0300 Bug 21096: Do not display loggedinusername in template This patch is a little fix for a much bigger hidden issues. The original issue: 1. Set the firstname and surname values of a paontr to utf-8 characters ("wide characters"), for instance ?? 2. Use this patron to login at the staff interface => In the header the logged in patron's info (concat of firstname and surname) are displayed correctly 3. Hit whatever link => In the header the info are now displayed incorrectly ("??") What happens? After that the user loggin, loggedinusername is set with the value from the DB (borrowers.userid) On next hits it is picked from the session (which contains the decoded utf8 value, see first lines of C4::Context->set_userenv) From C4::Auth::checkauth: 834 $s_userid = $session->param('id') // '' The quick fix is to use the logged_in_user variable in the template, but it seems that issues may occurred if external authentication is used (ldap, shib, cas). Could someone test this? Test plan: Make sure the original issue is fixed Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit be691d86e35acebace0f1576ea9380f405dd55ce) Signed-off-by: Martin Renvoize commit a87364d0ffbf906a4888f5d6d66e1a74cf280f58 Author: Jonathan Druart Date: Fri Aug 10 17:02:38 2018 -0300 Bug 21168: Handle deleted checked-in items on checking in circ/returns.pl generates a server error when attempting to checkin an item while the list of previously-returned items contains an item that has been deleted. Error text: Can't call method "biblio" on an undefined value at /usr/share/koha/intranet/cgi-bin/circ/returns.pl line 606. Test plan: - checkout two items - checkin item1 - on a separate tab, delete item1 - on the original tab (which still shows item1 in the list of Checked-In Items), attempt to check in item2 => No error appears Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 823c76cdc58b7b80b365a4f313fed3462f0df720) Signed-off-by: Martin Renvoize commit 3af501884e136454bca1c5a78c1a6b56e876f6be Author: Kyle M Hall Date: Thu Aug 16 07:11:17 2018 -0400 Bug 21231: BlockReturnofLostItems does not prevent lost items being found When the syspref BlockReturnOfLostItems is set to Block, the item is blocked from being returned, but is still considered found -- it's set to lost=0 and a refund is applied to the patron (if circ rules allow). The item can then be checked in a second time and returned as it is no longer lost. Test Plan: 1) Set an item to lost 2) Set BlockReturnOfLostItems to Block 3) Check the lost item in 4) Checkin message should say item is lost and cannot be returned 5) Check lost status of item, it should remain unchanged Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit ca2430480eaa4338b3e4aed766589b1406565d69) Signed-off-by: Martin Renvoize commit 1bb7e7c0167be0feffc86b574620c5fc65120993 Author: Kyle M Hall Date: Thu Aug 16 07:10:43 2018 -0400 Bug 21231: Add Unit Test Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 44d7063209137696d0c844ff82880a973029e534) Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 2 +- C4/Circulation.pm | 4 +++- C4/Items.pm | 14 ++++++++++---- circ/returns.pl | 2 ++ koha-tmpl/intranet-tmpl/prog/en/includes/header.inc | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 7 ++++++- .../prog/en/modules/patron_lists/add-modify.tt | 2 +- .../prog/en/modules/serials/subscription-add.tt | 2 +- .../prog/en/modules/virtualshelves/shelves.tt | 4 ++-- t/db_dependent/Circulation/Returns.t | 5 ++++- 12 files changed, 35 insertions(+), 17 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Sep 5 15:06:16 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 05 Sep 2018 13:06:16 +0000 Subject: [koha-commits] main Koha release repository branch 18.05.x updated. v18.05.03-11-g3516f11 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.05.x has been updated via 3516f113b7cc7cca7c292b5e9c6dc1abc5fc0e46 (commit) via e9f859c0e433d3cf3c0123432787a5801fa5a7d7 (commit) via acba1272764455af6164daa8e9246561b7b41bd3 (commit) via 514939a8046cb82a66cfb3966a14020e846face3 (commit) via 727e2df2b889cdfedaabad77172c640f79c3687b (commit) via 6ec1ca154cbcad9b2db7cacabe806936fce02465 (commit) from f9f8c6bbd0afeafa09554cf98f551228a6607952 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3516f113b7cc7cca7c292b5e9c6dc1abc5fc0e46 Author: Martin Renvoize Date: Wed Sep 5 13:52:41 2018 +0100 Bug 21202: Replace C4::Items::GetItemsByBiblioitemnumber calls http://lists.koha-community.org/pipermail/koha-devel/2018-August/044757.html Prior to this patch, GetRecords returned timestampX, cardX and borrowerX for the last 3 patrons who checked out the items. I have no idea if it is a desired effects but, as this code has been there for a very long time (2005), I suspect it's not. The "doc" (/ilsdi.pl?service=Describe&verb=GetRecords) does not say anything about the checkouts info. Test plan: hit /ilsdi.pl?service=GetRecords&id=1 and confirm the info about items are displayed correctly Signed-off-by: Josef Moravec's avatarJosef Moravec Signed-off-by: 's avatarMarcel de Rooy Signed-off-by: Wm. Nick Clemens's avatarNick Clemens RMaint: Converted to deprecation warning Signed-off-by: Martin Renvoize commit e9f859c0e433d3cf3c0123432787a5801fa5a7d7 Author: Jonathan Druart Date: Mon Aug 6 19:42:20 2018 -0300 Bug 21207: Remove unused RM C4::Overdues::GetItems sub Test plan: git grep GetItems | grep -v GetItemsInCollection | grep -v GetItemsForInventory | grep -v GetItemsInfo | grep -v GetItemsLocationInfo | grep -v GetItemsAvailable | grep -v GetItemsByBiblioitemnumber should not return any occurrences of code in perl scripts Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 3795141f54991e0a4c95629754ac2759330ed2e6) Signed-off-by: Martin Renvoize commit acba1272764455af6164daa8e9246561b7b41bd3 Author: Katrin Fischer Date: Wed Aug 8 20:28:29 2018 +0000 Bug 20994: Fix capitaization "Save to Lists" On the OPAC result list, below each result, there is a link: "Save to Lists". Patch changes this to "Save to lists" following our capitalization rules. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens (cherry picked from commit d5296743a4b4e6e6004bdb68926a3584e55435e4) Signed-off-by: Martin Renvoize commit 514939a8046cb82a66cfb3966a14020e846face3 Author: Jonathan Druart Date: Wed Aug 15 14:21:47 2018 -0300 Bug 21139: (follow-up) Floating toolbars - Remove unecessary height Found where QAing bug 20935, we actually want the hidden toolbar to be the exact same height as the visible one. Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens (cherry picked from commit 592905a4d2d41a1a7b757c48fbac8fc6f025bf9b) Signed-off-by: Martin Renvoize commit 727e2df2b889cdfedaabad77172c640f79c3687b Author: Jonathan Druart Date: Wed Aug 15 15:17:57 2018 -0300 Bug 19991: Remove warning from opac-user Use of uninitialized value in split at /home/vagrant/kohaclone/opac/opac-user.pl line 78. Use of uninitialized value $search_query in string ne at /home/vagrant/kohaclone/opac/opac-user.pl line 367. Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens (cherry picked from commit 38428fd71e76fdd7c9a452bc831affa03918994c) Signed-off-by: Martin Renvoize commit 6ec1ca154cbcad9b2db7cacabe806936fce02465 Author: Charlotte Cordwell Date: Wed Jan 17 20:46:59 2018 +0000 Bug 19991: use Modern::Perl in OPAC perl scripts Test Case: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; errors/400.pl errors/401.pl errors/402.pl errors/403.pl errors/404.pl errors/500.pl opac-account-pay-paypal-return.pl opac-alert-subscribe.pl opac-authorities-home.pl opac-authoritiesdetail.pl opac-browser.pl opac-ics.pl opac-image.pl opac-imageviewer.pl opac-messaging.pl opac-modrequest-suspend.pl opac-modrequest.pl opac-mymessages.pl opac-overdrive-search.pl opac-passwd.pl opac-patron-image.pl opac-privacy.pl opac-ratings-ajax.pl opac-ratings.pl opac-readingrecord.pl opac-renew.pl opac-sendshelf.pl opac-serial-issues.pl opac-showreviews.pl opac-suggestions.pl opac-tags_subject.pl opac-topissues.pl opac-user.pl sco/help.pl sco/printslip.pl sco/sco-patron-image.pl svc/overdrive_proxy svc/suggestion unapi Signed-off-by: Maryse Simard Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens (cherry picked from commit 59d436ee6023985a299f568fab9fd896492b207a) Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: C4/Items.pm | 1 + C4/Overdues.pm | 34 -------------------- .../lib/jquery/plugins/jquery.fixFloat.js | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-results.tt | 2 +- opac/errors/400.pl | 4 +-- opac/errors/401.pl | 4 +-- opac/errors/402.pl | 4 +-- opac/errors/403.pl | 4 +-- opac/errors/404.pl | 4 +-- opac/errors/500.pl | 4 +-- opac/opac-account-pay-paypal-return.pl | 3 +- opac/opac-alert-subscribe.pl | 4 +-- opac/opac-authorities-home.pl | 3 +- opac/opac-authoritiesdetail.pl | 3 +- opac/opac-browser.pl | 3 +- opac/opac-ics.pl | 3 +- opac/opac-image.pl | 3 +- opac/opac-imageviewer.pl | 3 +- opac/opac-messaging.pl | 3 +- opac/opac-modrequest-suspend.pl | 3 +- opac/opac-modrequest.pl | 3 +- opac/opac-mymessages.pl | 3 +- opac/opac-overdrive-search.pl | 3 +- opac/opac-passwd.pl | 3 +- opac/opac-patron-image.pl | 3 +- opac/opac-privacy.pl | 2 +- opac/opac-ratings-ajax.pl | 3 +- opac/opac-ratings.pl | 3 +- opac/opac-readingrecord.pl | 3 +- opac/opac-renew.pl | 3 +- opac/opac-sendshelf.pl | 3 +- opac/opac-serial-issues.pl | 3 +- opac/opac-showreviews.pl | 3 +- opac/opac-suggestions.pl | 4 +-- opac/opac-tags_subject.pl | 3 +- opac/opac-topissues.pl | 3 +- opac/opac-user.pl | 5 ++- opac/sco/help.pl | 3 +- opac/sco/printslip.pl | 3 +- opac/sco/sco-patron-image.pl | 3 +- opac/svc/overdrive_proxy | 3 +- opac/svc/suggestion | 3 +- opac/unapi | 3 +- 43 files changed, 44 insertions(+), 121 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 6 12:27:59 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 06 Sep 2018 10:27:59 +0000 Subject: [koha-commits] main Koha release repository branch 18.05.x updated. v18.05.03-12-gee1eec9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 18.05.x has been updated via ee1eec9d255e3a9341c9e17558d6d1f835add5ce (commit) from 3516f113b7cc7cca7c292b5e9c6dc1abc5fc0e46 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ee1eec9d255e3a9341c9e17558d6d1f835add5ce Author: Tomas Cohen Arazi Date: Fri Aug 24 10:45:52 2018 -0300 Bug 21267: Set X-FORWARDED-PROTO https if required This patch makes the apache configuration for the reverse proxy (required for Plack) so it sets the X-FORWARDED-PROTO header correctly for Plack::Middleware::ReverseProxy to use it. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Ulrich Kleiber Signed-off-by: Marcel de Rooy Since we actually resolve 19799 now (Changing language on OPAC redirects back to homepage), I will move that code to a new enh report. Signed-off-by: Nick Clemens (cherry picked from commit 302dd7bf8233ebf640bfde82fc050f8b08b2757c) Signed-off-by: Martin Renvoize ----------------------------------------------------------------------- Summary of changes: debian/templates/apache-shared-intranet-plack.conf | 2 +- debian/templates/apache-shared-opac-plack.conf | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Sep 6 19:50:57 2018 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 06 Sep 2018 17:50:57 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v18.05.00-680-g5616e22 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 5616e22236e8c263da0629a25b3aa7146e19c866 (commit) via 87c2755c04c962dab69ac846ecdff0893d35b9df (commit) via 6739346e1b8f542f38852f49277ccfb150a5095c (commit) via bfbc6cc941632269582891d63c58cea8b4fe668f (commit) via ac07a5074f3a77f1af691af40ce67facdcd43685 (commit) via 5496dc7eeaf6ddbe5503dade970e95ed0f283b55 (commit) via 3bede9a9d79f2999a7176afad38f75ae283b4a5c (commit) via d9a8ac0489d22fe174ea28af7f90f00a7ca15676 (commit) via 206ba82a46eff0d3b29ae6ed65bd3f3b0ef8bbde (commit) via 2e641b698e2c329f36e06cc8969e749bd13dff1a (commit) via f190ef3f2e7b7a03c3ca10086ed3a923b7c11bdb (commit) via de629e2a28f14cb3d64fd8a767b1bfe30d3d82de (commit) via b40070f4ad58f921f6994b304618bb560d471586 (commit) via 3afbe3cf5d544572aa2febc1d745fb77c7f305e3 (commit) via c556ad49b8a3e0d6112ebcc899a09723709e11de (commit) via 69316c7b8b937972477ec0a19475f41baf08f6b6 (commit) via ce411c186dd2a4e35a3b1855b86283522cc7bfd3 (commit) via 24fc43b9780260069c7aa1a328209f373d57e1bf (commit) via 8d404ec2ccbff96f638baf2746010648de3ed007 (commit) via d9ceb30a4d72cbaf387bba2fc550b7bad1609e8f (commit) via d2db67fbcbb77629e79d0eafd5c6ad241b5aa8e0 (commit) via 9a53a7384a60dbd52de7894ac685648a8108c830 (commit) via bf8834a1e65235c6e174866a25d76bdcd88be988 (commit) via 4577ca53c87d047d25182f88ebefed9583f515df (commit) via e0f58070f2634c3a5bf4ffb08c7d29e9183f2919 (commit) via 60a2589d3cb44bca3ec65cfe4d551a2d4563e020 (commit) via 2c000059ef4def47b120ddadfeae37f6a50bfa3a (commit) via 9900181cd3943e962901df662f71b1dbba33e22b (commit) via 662e64f76652cc4b3708fba8a16fa86a28d248ba (commit) via 00606e13002f6253c9bb5329a0876d53ac4638b6 (commit) via 135bf128a3f93da8161362ff174cbde32eed214d (commit) via b8c1198a79fbfbbda367accd23ddec27e0e6399d (commit) via a344710aed6b9d6b42301b0382e653380935a73f (commit) via 1ce0930ed11792c5af55b43b3ff5fe6aef4cf42f (commit) from f04cd87e671bdcacacb5c98c3f18e0c5da3aa82a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5616e22236e8c263da0629a25b3aa7146e19c866 Author: Katrin Fischer Date: Mon Aug 13 02:04:29 2018 +0000 Bug 19817: (QA follow-up) Add German manual and fix system preference help files - German language manuals were added since this patch was started - The structure of the manual was changed slightly, system preferences were moved into their own chapter To test: - Test help files display correctly for system preferences display correctly Note: Local use uses a different page than the other tabs - Test German shows up as option in KohaManualLanguage and links correctly Signed-off-by: Nick Clemens commit 87c2755c04c962dab69ac846ecdff0893d35b9df Author: Jonathan Druart Date: Thu Aug 16 11:59:36 2018 -0300 Bug 19817: Remove numbering from chapter file names See commit 8ad495abf1e42c5e73c5cb62ec32e1a54d16f8e8 Remove numbering from chapter file names from koha-manual Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 6739346e1b8f542f38852f49277ccfb150a5095c Author: Jonathan Druart Date: Tue Apr 10 11:07:03 2018 -0300 Bug 19817: use https instead of http the https version was not working when I wrote the first patches Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit bfbc6cc941632269582891d63c58cea8b4fe668f Author: Jonathan Druart Date: Mon Apr 9 11:30:01 2018 -0300 Bug 19817: Use the language from the interface if valid Use the UI language for the manual, if exists. Use the pref as a fallback. With the call to get_template_and_user the value of preferred_language switched from 'es' (spanish) to 'en' from one click to another (??) Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit ac07a5074f3a77f1af691af40ce67facdcd43685 Author: Jonathan Druart Date: Wed Apr 4 13:35:35 2018 -0300 Bug 19817: Open the manual in a new window, not a popup Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 5496dc7eeaf6ddbe5503dade970e95ed0f283b55 Author: Jonathan Druart Date: Wed Apr 4 13:30:04 2018 -0300 Bug 19817: Add pref KohaManualLanguage Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 3bede9a9d79f2999a7176afad38f75ae283b4a5c Author: Jonathan Druart Date: Mon Dec 18 18:23:29 2017 -0300 Bug 19817: Move code to Koha::Manual to make it testable and reusable Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit d9a8ac0489d22fe174ea28af7f90f00a7ca15676 Author: Jonathan Druart Date: Mon Dec 18 16:21:25 2017 -0300 Bug 19817: Make the location of the manual configurable - KohaManualBaseURL Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 206ba82a46eff0d3b29ae6ed65bd3f3b0ef8bbde Author: Jonathan Druart Date: Thu Dec 14 15:11:36 2017 -0300 Bug 19817: Remove local help files + edit help feature Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit 2e641b698e2c329f36e06cc8969e749bd13dff1a Author: Jonathan Druart Date: Thu Dec 14 15:03:44 2017 -0300 Bug 19817: Redirect to the online manual Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens commit f190ef3f2e7b7a03c3ca10086ed3a923b7c11bdb Author: Nick Clemens Date: Thu Sep 6 16:52:59 2018 +0000 Bug 7534: DBRev 18.06.00.024 Signed-off-by: Nick Clemens commit de629e2a28f14cb3d64fd8a767b1bfe30d3d82de Author: Kyle M Hall Date: Thu Sep 6 09:50:04 2018 -0400 Bug 7534: (QA follow-up) Don't do pickup branch checking for determining holdability in the OPAC Signed-off-by: Nick Clemens commit b40070f4ad58f921f6994b304618bb560d471586 Author: Nick Clemens Date: Sat Aug 25 19:06:21 2018 +0000 Bug 7534: (RM follow-up) Fix tests and adjust after bug 15524 Signed-off-by: Nick Clemens commit 3afbe3cf5d544572aa2febc1d745fb77c7f305e3 Author: Kyle M Hall Date: Wed Aug 15 13:51:10 2018 -0400 Bug 7534: Disambiguate branchcode parameter, make it match between subroutines Signed-off-by: Nick Clemens commit c556ad49b8a3e0d6112ebcc899a09723709e11de Author: Kyle M Hall Date: Wed Aug 15 13:46:14 2018 -0400 Bug 7534: Fix number of tests for Holds.t Signed-off-by: Nick Clemens commit 69316c7b8b937972477ec0a19475f41baf08f6b6 Author: Lari Taskula Date: Tue Feb 7 17:53:52 2017 +0200 Bug 7534: Check hold availability to desired pickup location in opac-reserve.pl To test: -1. Have access to your browser's developer tools in order to modify