[koha-commits] main Koha release repository branch master updated. v18.05.00-700-ga9e8599
Git repo owner
gitmaster at git.koha-community.org
Fri Sep 7 18:16:07 CEST 2018
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via a9e859942c8cf8c4de8e872fb3ed79b5f80fa19a (commit)
via ec463e80aadbf30144d417e123e884726fff77f2 (commit)
via d96e2e71b8ac77e09194d02e72d67ec5c03187ec (commit)
via c66a2894e1857b403a52d8392d46c343be7d0ed8 (commit)
via 96a095f4e1d14721ace2198fb369670ce848c9ef (commit)
via 6a2a80988dd121215284c4458438fdb0fe41b86c (commit)
via 289e96848a2320e5c8c93f46327143a4b73c267f (commit)
via 418c65d2e28eb6a2c9e3bb56505918434cf5f04c (commit)
via 80e8c857e31cf14bb760731715a2f854d7c72441 (commit)
via dfadaa45aa8ce226d9ba111ebad6e44271e39e41 (commit)
via d6424c1999d3563c5243185503dd5a9b5b928f8f (commit)
via e85d6e12ea4dccd8fa08ec600864c2f985dcf886 (commit)
via 8d53a1508d3fb8c6336839995f61036809ffedd2 (commit)
via 70c6266081a566149c7b3b49c95958a31417d435 (commit)
via b6813142ddedebf96bb6dfa50d5544d42c30e5e1 (commit)
via 2b0e73b9e1b7f19a55510521a990fa00411157c5 (commit)
via c1d2363063d1c3eb2d37e45c9a3074cea9c783b4 (commit)
via 86bcc81122f20a096f46ac66de3d95ec21dcbd96 (commit)
via 9dbcbe587db1f50594f17f91ab6643acb7bcc3df (commit)
via 4cd57521c43f4e8c5e37ec61e1112ff2b74453ad (commit)
from 5616e22236e8c263da0629a25b3aa7146e19c866 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit a9e859942c8cf8c4de8e872fb3ed79b5f80fa19a
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Fri Sep 7 17:06:38 2018 +0200
Bug 19550: (QA follow-up) Add missing [% USE %]
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit ec463e80aadbf30144d417e123e884726fff77f2
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Sep 6 14:34:03 2018 +0000
Bug 19550: (RM follow-up) Add filters
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit d96e2e71b8ac77e09194d02e72d67ec5c03187ec
Author: Julian Maurice <julian.maurice at biblibre.com>
Date: Tue Oct 31 12:25:17 2017 +0000
Bug 19550: Add links to related authorities for UNIMARC
Links exist in search results for MARC21 but not for UNIMARC.
This patch fixes that.
Test plan:
1. Create an authority with a field 550 that links to another authority
e.g. 550 $a Foo $9 42
2. Reindex this authority
3. Search for this authority
4. See that you now have a link "Foo" to authorities/detail.pl?authid=42
in the summary
Signed-off-by: delaye <stephane.delaye at biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit c66a2894e1857b403a52d8392d46c343be7d0ed8
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Sep 7 15:53:24 2018 +0000
Bug 21235: DBRev 18.06.00.027
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 96a095f4e1d14721ace2198fb369670ce848c9ef
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Fri Sep 7 16:28:22 2018 +0100
Bug 21235: (QA follow-up) Remove table services_throttle
Add the missing db update to nuke the services throttle from high orbit
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 6a2a80988dd121215284c4458438fdb0fe41b86c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Aug 15 12:01:56 2018 -0300
Bug 21235: Remove table services_throttle
This table was only used by XISBN, this patch remove the table and the
related code (cronjobs)
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
https://bugs.koha-community.org/show_bug.cgi?id=21235
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 289e96848a2320e5c8c93f46327143a4b73c267f
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Sep 6 11:56:41 2018 +0000
Bug 21319: Remove highlight and tooltip on Koha Team version
This patch modifies the about page to remove a <span> on the Koha
version number which explained the version numbering change.
To test, apply the patch and view the "Koha team" tab on the about page.
The "Koha 18.05 release team" header should not have the number
highlighted.
Signed-off-by: pierre-marc <pierre-marc.thibault at inLibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 418c65d2e28eb6a2c9e3bb56505918434cf5f04c
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Thu May 17 10:33:32 2018 -0300
Bug 20776: Add Selenium::Remote::Driver to the dependency list
This dependency is missing from the PerlDependencies.pm file.
This patch adds it.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 80e8c857e31cf14bb760731715a2f854d7c72441
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Sep 7 13:32:31 2018 +0000
Bug 17530: DBRev 18.06.00.025
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit dfadaa45aa8ce226d9ba111ebad6e44271e39e41
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Sep 7 07:50:13 2018 +0200
Bug 17530: (QA follow-up) Fix caching error
The fourth patch made this change:
- $last_article_requestable_guesses->{$key} = $res;
+ $cache->set_in_cache(GUESSED_ITEMTYPES_KEY, $res);
This removed the category level in the cached hash. Adding it back here.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested by verifying cached values, running opac-search with anonymous
session as well as user context.
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit d6424c1999d3563c5243185503dd5a9b5b928f8f
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Mon Sep 3 11:49:08 2018 +0200
Bug 17530: (QA follow-up) Add pref ArticleRequestsLinkControl
As requested by RM on Bugzilla comment53.
This pref allows you to always display the link on search results.
Which is the previous behavior ;) It will raise false positives, whereas
the algorithm may result in false positives or negatives (depending on
default item type and circulation rules).
When upgrading the pref is set to always (current behavior), new installs
get the new calc value using the algorithm in may_article_request.
Test plan:
Run t/db_dependent/Koha/IssuingRules/guess_article_requestable_itemtypes.t
Run t/db_dependent/ArticleRequests.t
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit e85d6e12ea4dccd8fa08ec600864c2f985dcf886
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Mon Jun 4 10:03:40 2018 +0200
Bug 17530: (QA follow-up) Move may_article_request to ItemType
As requested by QA, we should move may_article_request out of Biblio.
For reasons of performance removed the wrapper layer of may_article_request
in opac-search. No need to look up all item types. For readability kept
the routine in the detail scripts.
Note for running ArticleRequests.t: A possible failure on the subtest
'search_limited' is addressed on bug 20866. So you can ignore that one.
As long as the subtest for may_article_request passes.
Test plan:
See previous patches.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 8d53a1508d3fb8c6336839995f61036809ffedd2
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu May 31 09:53:00 2018 +0200
Bug 17530: (QA follow-up) Replace class_or_self variables
See comment23. Requested by QA.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 70c6266081a566149c7b3b49c95958a31417d435
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu Mar 15 12:04:30 2018 +0100
Bug 17530: (QA follow-up) Replace our variable by cached value
Instead of saving the state locally in a variable during Plack lifetime,
we move the saved hash to the cache. We clear the key when we enter
smart-rules.pl. This makes a change in circ rules immediately effective.
Test plan:
Run the modified tests.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit b6813142ddedebf96bb6dfa50d5544d42c30e5e1
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu Mar 1 15:38:48 2018 +0100
Bug 17530: Use can_article_request to control sidebar link
Before this patch, the 'Request article' link is displayed whenever the
pref is enabled. In many cases this might be useless. Instead of a guess
as in opac-search, we now call can_article_request to know for sure.
Note: at least this is the case when a user has logged in.
Update sidebar template with template variable artreqpossible.
Add code in opac-detail, MARCdetail and ISBDdetail to fill it.
Test plan:
[1] Look for two biblios with items: one that should allow article requests
and one that should not (respecting branch, patron, item type).
[2] Verify on detail, ISBD and MARC that the link is displayed for
the first biblio and hidden for the second biblio.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 2b0e73b9e1b7f19a55510521a990fa00411157c5
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu Mar 1 15:25:44 2018 +0100
Bug 17530: Use may_article_request method in opac-search
If you enable pref ArticleRequests, until now all search results got the
'Request article' link. This patch tries to improve the situation by
using the new sub with the itemtype of the search result.
In most cases the number of links will drastically decrease. It may still
be possible sometimes that a link is shown while it effectively is not
possible, but we do not get the performance burden of determining that and
going through all items.
Test plan:
[1] Look for two borrowers P1 and P2 within categories C1 resp. C2.
[2] Look for two biblios B1 and B2 with default item types I1 resp. I2.
(See 942c in case of MARC21.)
[3] Make sure that no circ rules allow article requests. Enable the pref.
[4] Add/modify circ rule category=C1, itemtype=I1, art_req=yes.
Log out. Search for B1 and B2, verify that only B1 has AR link.
Log in as P1. Verify that only B1 has AR link.
Log in as P2. Verify that no biblio has AR link.
[5] Add/modify circ rule category=C2, itemtype=I2, art_req=item_only.
Log out. Search for B1 and B2, verify that both have AR links.
Log in as P1. Verify that only B1 has AR link.
Log in as P2. Verify that only B2 has AR link.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit c1d2363063d1c3eb2d37e45c9a3074cea9c783b4
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu Mar 1 14:29:01 2018 +0100
Bug 17530: Add Koha::IssuingRules->guess_article_requestable_itemtypes
This routine looks at the issuingrules and makes a fast 'intelligent
guess' if article requests may be allowed for item types while
branch code and patron category may not be available.
We also add Koha::Biblio->may_article_request using the routine based
on default item type or parameter. Implemented as both class and instance
method. Added a few tests.
Test plan:
[1] Run t/db_dependent/Koha/IssuingRules/guess_article_requestable_itemtypes.t
[2] Run t/db_dependent/ArticleRequests.t to test Koha::Biblio changes.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 86bcc81122f20a096f46ac66de3d95ec21dcbd96
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Sep 6 19:04:45 2018 +0000
Bug 7534: (RM follow-up) Fix TT syntax
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 9dbcbe587db1f50594f17f91ab6643acb7bcc3df
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Sep 4 16:11:15 2018 -0300
Bug 13618: Do not use html filters with KohaSpan
To recreate the issue:
Go to Home › Administration › Library groups
Create a new group
"Group <span class='name'>xxx</span> created."
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 4cd57521c43f4e8c5e37ec61e1112ff2b74453ad
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Sep 7 13:09:42 2018 +0000
Bug 19817: DBRev 18.06.00.025
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Installer/PerlDependencies.pm | 5 ++
C4/XISBN.pm | 28 --------
Koha.pm | 2 +-
Koha/IssuingRules.pm | 66 +++++++++++++++++
Koha/ItemType.pm | 21 ++++++
Koha/Schema/Result/ServicesThrottle.pm | 66 -----------------
admin/smart-rules.pl | 4 ++
debian/koha-common.cron.daily | 1 -
installer/data/mysql/atomicupdate/bug_19817.sql | 5 --
installer/data/mysql/kohastructure.sql | 11 ---
installer/data/mysql/sysprefs.sql | 1 +
installer/data/mysql/updatedatabase.pl | 27 +++++++
.../en/includes/authorities-search-results.inc | 18 +++--
koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 2 +-
.../prog/en/modules/admin/branches.tt | 12 +++-
.../prog/en/modules/admin/library_groups.tt | 10 +--
.../en/modules/admin/preferences/circulation.pref | 6 ++
.../bootstrap/en/includes/opac-detail-sidebar.inc | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-results.tt | 2 +-
misc/cronjobs/crontab.example | 3 -
misc/cronjobs/services_throttle.pl | 21 ------
opac/opac-ISBDdetail.pl | 7 ++
opac/opac-MARCdetail.pl | 8 +++
opac/opac-detail.pl | 8 +++
opac/opac-search.pl | 10 +++
t/db_dependent/ArticleRequests.t | 32 ++++++++-
.../guess_article_requestable_itemtypes.t | 76 ++++++++++++++++++++
27 files changed, 300 insertions(+), 154 deletions(-)
delete mode 100644 Koha/Schema/Result/ServicesThrottle.pm
delete mode 100644 installer/data/mysql/atomicupdate/bug_19817.sql
delete mode 100755 misc/cronjobs/services_throttle.pl
create mode 100644 t/db_dependent/Koha/IssuingRules/guess_article_requestable_itemtypes.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list