[koha-commits] main Koha release repository branch master updated. v18.05.00-737-g2847ac4

Sun Sep 16 01:37:48 CEST 2018

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  2847ac4b4de239a430e6e9d20f6e895435c56d7b (commit)
       via  2d94834807851c3325f26572c7a228903034741c (commit)
       via  b64f1808f1682c5e132e0ddbc19ae5869a55bd99 (commit)
       via  f9359675e2f6a8b89ce471ac5f090eef33be3305 (commit)
       via  11e513f83f0c5fdd0d47de14b7c09635faf58ae4 (commit)
       via  cb406f72b0266c97ac904754cc9637035000f5ca (commit)
       via  a6f8eac4edb6463d8ff16928d6f2cddcf4dfbfc2 (commit)
       via  ca887754ead4d6207811d751229c4a4dbcf4af80 (commit)
      from  b29c4e2bf9562c47b525b2b0644fb48db7853df2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 2847ac4b4de239a430e6e9d20f6e895435c56d7b
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Sat Sep 15 21:52:47 2018 +0000

    Bug 20777: DBRev 18.06.00.030

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 2d94834807851c3325f26572c7a228903034741c
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Fri Sep 14 09:10:50 2018 -0700

    Bug 20777: (follow-up) Remove 'dispute' reference in /credits endpoint

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit b64f1808f1682c5e132e0ddbc19ae5869a55bd99
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu May 17 10:55:26 2018 -0300

    Bug 20777: DBIC update

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit f9359675e2f6a8b89ce471ac5f090eef33be3305
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Thu May 17 10:53:55 2018 -0300

    Bug 20777: Remove unused accountlines.dispute field

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit 11e513f83f0c5fdd0d47de14b7c09635faf58ae4
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Sat Sep 15 21:44:05 2018 +0000

    Bug 21288: DBRev 18.06.00.029

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit cb406f72b0266c97ac904754cc9637035000f5ca
Author: Pasi Kallinen <pasi.kallinen at joensuu.fi>
Date:   Thu Aug 30 11:29:54 2018 +0300

    Bug 21288: Slowness in acquisition caused by GetInvoices

    The SQL query done by GetInvoices is quite slow on our production server,
    taking about a minute.

    In the query, there's this join:

      LEFT JOIN subscription ON biblio.biblionumber = subscription.biblionumber

    but there's no index on subscription.biblionumber. Adding the index speeds
    up the query so it only takes up about 3 seconds.

    Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi>

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit a6f8eac4edb6463d8ff16928d6f2cddcf4dfbfc2
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Mon May 14 16:18:29 2018 +0200

    Bug 20765: Fix search for items by acqdate in label batch

    In Tools >  Label creator, when creating a batch you can add items using a search.

    This search has filters on acquisition date.
    Actually those filters does not work.
    The create a search using CCL syntaxe to query Zebra search engine.

    The cause is that operator "ge" or "le" must be before "st-date-normalized" in CCL query.
    Looks like it is because of "st-date-normalized" uses "r=o" in ccl.properties.

    Test plan :
    1) Check in advance search you have indexed acquisition date
    2) Go to Tools > Label creator
    3) Click on New > Label batch
    4) Click on Add item(s)
    5) Enter a relevent date in "Added on or after date" and in "Added on or before date"
    6) Click on "Search"
    => SUCCESS: You get results
    7) Apply the patch
    8) Retry the 'Add item(s)' step
    => SUCCESS: Patch doesn't change behaviour for old Zebra
    9) Get rid of the patch on your working branch
    10) Use the latest Zebra:
    - /etc/apt/sources.list.d/indexdata.list:
    deb http://ftp.indexdata.dk/debian jessie main
    - Add the repo key:
      $ wget http://ftp.indexdata.dk/debian/indexdata.asc -O- | sudo apt-key add -
    - Upgrade:
      $ sudo apt update; sudo apt dist-upgrade
      $ sudo koha-rebuild-zebra -f -a -b -v kohadev
      $ restart_all
    11) Retry the 'Add item(s)' step
    => FAIL: No results!
    9) Apply the patch, retry
    => SUCCESS: Search results!
    - Sign off :-D

    Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
    Followed the test plan and it works.
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    It doesn't break with 2.0.59-1 (stretch/jessie), and fixes the problem
    for 2.1.X.

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

commit ca887754ead4d6207811d751229c4a4dbcf4af80
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Sat Sep 15 11:24:32 2018 -0700

    Bug 21355: Prevent GetDailyQuote.t to fail when run after 23:00

    Tests will fail (Jenkins run #554) if run after 23:00

     #   Failed test 'Id is correct'
     #   at t/db_dependent/Koha/GetDailyQuote.t line 72.
     #          got: 6
     #     expected: 8

     #   Failed test 'Timestamp 2018-09-15 00:44:46 is correct'
     #   at t/db_dependent/Koha/GetDailyQuote.t line 74.
     #          got: '2018-09-14 23:44:46'
     #     expected: '2018-09-15 00:44:46'
     # Looks like you failed 2 tests of 12.
     [23:44:46] t/db_dependent/Koha/GetDailyQuote.t
     Dubious, test returned 2 (wstat 512, 0x200)

    Adding only 1 second will hugely reduce the risk of failure here.

    It also updates a useless test (column 'quote' does not exist)

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Tested:
    - Run:
      $ sudo date -s 2018-09-15T23:10:00
      $ kshell
     k$ prove t/db_dependent/Koha/GetDailyQuote.t
    => FAIL: Tests fail as patch author mentions
    - Apply the patch
     k$ prove t/db_dependent/Koha/GetDailyQuote.t
    => SUCCESS: Tests pass!

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha.pm                                |    2 +-
 Koha/REST/V1/Patrons/Account.pm        |    1 -
 Koha/Schema/Result/Accountline.pm      |   11 ++---------
 installer/data/mysql/kohastructure.sql |    2 +-
 installer/data/mysql/updatedatabase.pl |   23 +++++++++++++++++++++++
 labels/label-item-search.pl            |    4 ++--
 t/db_dependent/Koha/GetDailyQuote.t    |    4 ++--
 7 files changed, 31 insertions(+), 16 deletions(-)

hooks/post-receive
-- 
main Koha release repository