[koha-commits] main Koha release repository branch 18.05.x updated. v18.05.03-27-g44ce16d

Mon Sep 17 16:13:25 CEST 2018

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.05.x has been updated
       via  44ce16d0069fdff7b487753277c11d368a083ccb (commit)
       via  40536fedd39a0a22c3e93a00721b573d66392e09 (commit)
       via  06f0209840d290bb1a7340f4b1af8d55e932f7c1 (commit)
       via  b8b006fd73381b0be9aac2432aebae07cfffca7d (commit)
      from  31db0813d36f21a0c898b75841a3e34364619a84 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 44ce16d0069fdff7b487753277c11d368a083ccb
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Sat Sep 15 21:44:05 2018 +0000

    Bug 21288: DBRev 18.05.03.002

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 11e513f83f0c5fdd0d47de14b7c09635faf58ae4)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 40536fedd39a0a22c3e93a00721b573d66392e09
Author: Pasi Kallinen <pasi.kallinen at joensuu.fi>
Date:   Thu Aug 30 11:29:54 2018 +0300

    Bug 21288: Slowness in acquisition caused by GetInvoices

    The SQL query done by GetInvoices is quite slow on our production server,
    taking about a minute.

    In the query, there's this join:

      LEFT JOIN subscription ON biblio.biblionumber = subscription.biblionumber

    but there's no index on subscription.biblionumber. Adding the index speeds
    up the query so it only takes up about 3 seconds.

    Signed-off-by: Pasi Kallinen <pasi.kallinen at joensuu.fi>

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit cb406f72b0266c97ac904754cc9637035000f5ca)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 06f0209840d290bb1a7340f4b1af8d55e932f7c1
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Mon May 14 16:18:29 2018 +0200

    Bug 20765: Fix search for items by acqdate in label batch

    In Tools >  Label creator, when creating a batch you can add items using a search.

    This search has filters on acquisition date.
    Actually those filters does not work.
    The create a search using CCL syntaxe to query Zebra search engine.

    The cause is that operator "ge" or "le" must be before "st-date-normalized" in CCL query.
    Looks like it is because of "st-date-normalized" uses "r=o" in ccl.properties.

    Test plan :
    1) Check in advance search you have indexed acquisition date
    2) Go to Tools > Label creator
    3) Click on New > Label batch
    4) Click on Add item(s)
    5) Enter a relevent date in "Added on or after date" and in "Added on or before date"
    6) Click on "Search"
    => SUCCESS: You get results
    7) Apply the patch
    8) Retry the 'Add item(s)' step
    => SUCCESS: Patch doesn't change behaviour for old Zebra
    9) Get rid of the patch on your working branch
    10) Use the latest Zebra:
    - /etc/apt/sources.list.d/indexdata.list:
    deb http://ftp.indexdata.dk/debian jessie main
    - Add the repo key:
      $ wget http://ftp.indexdata.dk/debian/indexdata.asc -O- | sudo apt-key add -
    - Upgrade:
      $ sudo apt update; sudo apt dist-upgrade
      $ sudo koha-rebuild-zebra -f -a -b -v kohadev
      $ restart_all
    11) Retry the 'Add item(s)' step
    => FAIL: No results!
    9) Apply the patch, retry
    => SUCCESS: Search results!
    - Sign off :-D

    Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
    Followed the test plan and it works.
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    It doesn't break with 2.0.59-1 (stretch/jessie), and fixes the problem
    for 2.1.X.

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit a6f8eac4edb6463d8ff16928d6f2cddcf4dfbfc2)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit b8b006fd73381b0be9aac2432aebae07cfffca7d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Sat Sep 15 11:24:32 2018 -0700

    Bug 21355: Prevent GetDailyQuote.t to fail when run after 23:00

    Tests will fail (Jenkins run #554) if run after 23:00

     #   Failed test 'Id is correct'
     #   at t/db_dependent/Koha/GetDailyQuote.t line 72.
     #          got: 6
     #     expected: 8

     #   Failed test 'Timestamp 2018-09-15 00:44:46 is correct'
     #   at t/db_dependent/Koha/GetDailyQuote.t line 74.
     #          got: '2018-09-14 23:44:46'
     #     expected: '2018-09-15 00:44:46'
     # Looks like you failed 2 tests of 12.
     [23:44:46] t/db_dependent/Koha/GetDailyQuote.t
     Dubious, test returned 2 (wstat 512, 0x200)

    Adding only 1 second will hugely reduce the risk of failure here.

    It also updates a useless test (column 'quote' does not exist)

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Tested:
    - Run:
      $ sudo date -s 2018-09-15T23:10:00
      $ kshell
     k$ prove t/db_dependent/Koha/GetDailyQuote.t
    => FAIL: Tests fail as patch author mentions
    - Apply the patch
     k$ prove t/db_dependent/Koha/GetDailyQuote.t
    => SUCCESS: Tests pass!

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit ca887754ead4d6207811d751229c4a4dbcf4af80)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha.pm                                |    2 +-
 installer/data/mysql/kohastructure.sql |    1 +
 installer/data/mysql/updatedatabase.pl |   11 +++++++++++
 labels/label-item-search.pl            |    4 ++--
 t/db_dependent/Koha/GetDailyQuote.t    |    4 ++--
 5 files changed, 17 insertions(+), 5 deletions(-)

hooks/post-receive
-- 
main Koha release repository