[koha-commits] main Koha release repository branch 17.11.x updated. v17.11.09-60-gac7fa5b

Git repo owner gitmaster at git.koha-community.org
Fri Sep 21 16:34:21 CEST 2018


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 17.11.x has been updated
       via  ac7fa5b07a8ee552840ccf76dd868e33c1eb0378 (commit)
       via  c710786c775e24b887e8365d7b5badad8ab376e8 (commit)
       via  6d7fc073d883275e25efe5a5f0c531b766aceeb9 (commit)
       via  56833de0380c04ed72b8f692535660361fee0cbd (commit)
       via  d13124a2e28f505a8e894ec92f0826296dbadb23 (commit)
       via  a3c88ab41e78023831b54a18d1b82d48c3c53ef4 (commit)
       via  34e1d76152a085378c9a98ffd849abebd586da76 (commit)
       via  f0db075dde813eae5b46df6f39decd7fc896d4a4 (commit)
       via  2a7f362d2030c242559146bf2f4d583031f81d0d (commit)
       via  a4573184230ce89257b17533fafae05bfbd490d9 (commit)
       via  85b488a9ead98970f0a4e7bbe6ea3668e18365d0 (commit)
       via  3c78199927465ab98c8e51b64b6f50ae8377c4a9 (commit)
       via  2fdf6e23223a712689170aa1eab2d96e9b8198ce (commit)
       via  463e7de027716aaf909e49a930a9e962fe458014 (commit)
       via  9fee5ac6fde75ad9ed0252e0b870d6800756f66e (commit)
       via  859eb738f4a1b86243a265e11ec2029eabfe623e (commit)
       via  659d4cc0d41f9e9d87c591d96b66c3a369720e38 (commit)
      from  2aeacaa96ee71cbd77fdfd372206ead7bce0c589 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ac7fa5b07a8ee552840ccf76dd868e33c1eb0378
Author: Joy Nelson <joy at bywatersolutions.com>
Date:   Fri Jun 22 13:48:25 2018 -0700

    Bug 20984: Add 300$f to display
    
    Adding Type of Unit (300$f) to the Opac details and staff side searches results and details display
    
    Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit a122a5333445299da8a01e47a65b25f733e6ce7c)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 516d156bb2aec724e429414f7053e3a2f8fffda1)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit c710786c775e24b887e8365d7b5badad8ab376e8
Author: Joy Nelson <joy at bywatersolutions.com>
Date:   Fri Jun 22 11:56:11 2018 -0700

    Bug 17625: adding subfields f and g to XSLT display
    
    Adding 245$f and 245$g to the Results and Detail pages on OPAC and staff side
    
    Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
    
    Signed-off-by: Cab Vinton <bibliwho at gmail.com>
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit fe9c6450979b5b7fd05821dd22c523ea6d10d3cd)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 7a53a3defe45099f02c0bbb4d077e01303feca38)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 6d7fc073d883275e25efe5a5f0c531b766aceeb9
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Aug 7 11:14:54 2018 -0300

    Bug 21150: add the biblionumber to the output
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 76141a352ed5ff8c9541c0d4b1c99e22e5339add)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit bacb859d1c637b7d9d32b2205c97cc00557e9888)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 56833de0380c04ed72b8f692535660361fee0cbd
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Aug 3 14:59:33 2018 -0300

    Bug 21150: Search for item types inconsistencies
    
    search_for_data_inconsistencies.pl will now display errors if:
    1.item-level_itypes is set to "specific item" and items.itype is not set
    or not set to an item type defined in the system (itemtypes.itemtype)
    2.item-level_itypes is set to "biblio record" and biblioitems.itemtype is not set
    or not set to an item type defined in the system (itemtypes.itemtype)
    
    Test plan:
    Use the script and the different possible combinations to display the
    errors
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 6fd1a8c11484e8c1cd771aea0c6ac98a2ab18f40)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 41b06b411c3ad2a5006980507c344c568357c752)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit d13124a2e28f505a8e894ec92f0826296dbadb23
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Tue Jul 31 16:23:43 2018 +0000

    Bug 20509: Add to script documentation
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 9b73cc22890aadae0fa6afd9d82d5109cc47fd80)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 7ba665179bb35a3ddf940f506e5dfed06f11b346)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit a3c88ab41e78023831b54a18d1b82d48c3c53ef4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Jun 27 15:35:57 2018 -0300

    Bug 20509: Search for not defined authority codes
    
    This patch adds a new check in
    misc/maintenance/search_for_data_inconsistencies.pl to search for not
    defined authority codes.
    
    Test plan:
    Set some auth_header.authtypecode to not defined authority codes in Koha
    (UPDATE auth_header SET authtypecode="XXX" WHERE authid=42;)
    Then run `misc/maintenance/search_for_data_inconsistencies.pl`
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 9558a118dacd74b77c27f63fc41611945aeff052)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit c2387c58f1a4d2ed2fd1180957871634ae5f93ce)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 34e1d76152a085378c9a98ffd849abebd586da76
Author: Josef Moravec <josef.moravec at gmail.com>
Date:   Wed Jun 27 20:27:09 2018 +0000

    Bug 21011: (follow-up) Fix pod, fix missing homebranch condition, change mode to executable
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 5892ab07118b04a8071b49c40b441df326e15f07)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 5ec194dfa9a1198bf5578bd3c7fac613da529f3c)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit f0db075dde813eae5b46df6f39decd7fc896d4a4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Jun 27 15:32:56 2018 -0300

    Bug 21011: Search for items with not defined homebranch and/or holdingbranch
    
    From bug 5789: scripts can fail if items.homebranch and/or
    items.holdingbranch is not defined
    
    This script will help people catching these migration issues.
    
    Test plan:
    Update your items table to set some homebranch or holdingbranch to NULL
    Run this script
    It will display the different items with not defined values in these
    fields.
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 7d47bb311827298ddc30297bbd388e8f8905db48)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit b5b74454cd0c5f8cb5b46ac60ca94b37e1503fc8)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 2a7f362d2030c242559146bf2f4d583031f81d0d
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Wed Aug 8 20:34:32 2018 +0000

    Bug 20631: Remove unused RemoveLostItem from C4::Accounts
    
    RemoveLostItem was 'used' in C4::Accounts, but is not
    actually used there.
    
    Call has been removed by
      commit ed9cf81c3aa8fd82f9347556364e9d2e6cef8a82
      Bug 15896 - Use Koha::Account::pay internally for makepayment
    
    To test:
    - Verify that the routine was actually not used!
    
    Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 9ccfa48f6ee8ec44d1621874383b10f68d939f34)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 8b1944bbd876d2928536b0c457922eb71e9aa54b)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit a4573184230ce89257b17533fafae05bfbd490d9
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Thu Aug 9 17:46:09 2018 +0000

    Bug 20504: Fix lang attribute in html tag on systempreferences page
    
    On the system preferences page the lang attribute of the
    html tag is always empty.
    
    To test:
    - Go to systempreferences
    - Check the html source and look at the html tag,
      it should read: <html lang="">
    - Apply patch
    - Check the html source again: <html lang="en">
      Verify the language code shown matches the currently
      selected language in the staff interface
    - Verify the language system preferences work correctly
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    The problem was actually that
      $lang = $template->param( 'lang' );
    should certainly be $lang = $input->param( 'lang' );
    and, as it, it overrides the value of 'lang' passed from C4::Auth
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 56c50a66169f956584050a8630a71cfa7d5984cb)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 32b01b264277a77dbb79133f5af8eeecbe64d997)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 85b488a9ead98970f0a4e7bbe6ea3668e18365d0
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Mon Aug 20 07:04:37 2018 +0000

    Bug 7996: (QA follow-up) Remove unnecessary permission check view logs template
    
    Permission is checked in the perl file, no need to check again
    in the template.
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 3484db7187ca4ca62a617d9362b8c64c37f60cfd)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit b1aa841e1ed21dc300dc188aa76fd57b33044c95)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 3c78199927465ab98c8e51b64b6f50ae8377c4a9
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Fri Aug 17 11:07:41 2018 +0000

    Bug 7996: Correct wrong permissions for modification log
    
    To test:
     1 - Create a staff patron with catalogue,borrowers,and view_system_logs
         permissions
     2 - Log in using that patron
     3 - Go to tools
     4 - Click 'Log viewer'
     5 - You get a blank page
     6 - View borrower circ screen, note you do not see 'Modification log'
     7 - Edit a borrower, note you do not see 'Modification log'
     8 - Apply patch
     9 - 'Log Viewer' should now load correctly
    10 - You should see 'Modification log' tab during circ
    11 - You should see 'Modification log' tab when editing patron
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit a750ebdbd994ef2a793e632eea4e35bbc7f1ec6d)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit d8b3095f7d533bd2151d710085259f29349faf5b)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 2fdf6e23223a712689170aa1eab2d96e9b8198ce
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Thu Jul 26 15:36:24 2018 +0000

    Bug 19511: Local cover images not centered in table column in staff client search results
    
    This patch modifies the JavaScript which embeds local cover images in
    staff client catalog search results. It now adds the "thumbail" class to
    the image, matching Amazon cover images.
    
    To test you should have one or more titles with local cover images
    attached. Apply the patch and clear your browser cache if necessary.
    
    Enable both the AmazonCoverImages and LocalCoverImages system
    preferences and perform a search which will return titles with local
    cover images. Confirm that local covers are styled like Amazon covers.
    
    Tested and confirmed local cover images are appearing quite nicely now.
    Signed-off-by: Dilan Johnpullé <dilan at calyx.net.au>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit afa51869c39e1a450314a6d13098571566cc241c)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 683589ec9556d65c9995125c962ce7c471495937)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 463e7de027716aaf909e49a930a9e962fe458014
Author: Nick Clemens <nick at bywatersolutions.com>
Date:   Tue Aug 21 11:49:55 2018 +0000

    Bug 21144: DBRev 17.11.09.002
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit df06587b763de2acd2d4e1afa3da8ad1841f7577)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 4ee626a6f362bbf96342613b7f64f1b0e3b2503e)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 9fee5ac6fde75ad9ed0252e0b870d6800756f66e
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Thu Aug 2 02:19:42 2018 +0200

    Bug 21144: Add ROADTYPE to default authorised values categories
    
    The ROADTYPE category was missing from the default list of
    authorised value categories available.
    
    To test:
    - Verify ROADTYPE is not listed as authorised value category
    - Apply patch and run database update
    - Verify ROADTYPE is now listed
    - Add an entry, for example: AV = Avenue
    - Add or edit a patron, verify a pull down with your entry
      shows on the form.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 266d7b5fa844b512cf68f4b08d6c07474c2ccc42)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 6c099d4360060829a230eeb243333182346d3d59)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 859eb738f4a1b86243a265e11ec2029eabfe623e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Aug 17 12:07:55 2018 -0300

    Bug 21142: Open uploaded files in utf-8 - batch mod/del
    
    Batch item/record modification/deletion tools does not open uploaded
    files in utf-8
    
    Test plan:
    Edit and delete records and items using a file which will contain:
    valid and invalid barcodes with and without utf-8 chars (💕)
    
    You should see the warning message:
     "The *** 39999000💕001679 does not exist in the database."
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit f5f31679bf260d17e996fbe8e2e77f695ac7ddfc)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit 0d7ba4634ad795703cbb97e371e07ae9252a6c53)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

commit 659d4cc0d41f9e9d87c591d96b66c3a369720e38
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Aug 16 12:29:43 2018 -0300

    Bug 21238: Prevent TemplateToolkit.t to fail on slow servers
    
    It failed 3x in the last 6 runs (on node 1), we should mock
    DateTime->now to prevent it to fail again.
    
    The error is:
    koha_1       |         #   Failed test at
    t/db_dependent/Letters/TemplateToolkit.t line 724.
    
    When comparing <<today>> replacement:
    koha_1       |         # 08/16/2018 14:25<br />
    [...]
    koha_1       |         # 08/16/2018 14:24<br />
    
    Let's mock DateTime->now to prevent it to fail again.
    
    Test plan:
    0. Do not apply this patch
    1. Add "sleep(60);" at line ~715, before "# Add a second checkout"
    2. Run the tests
    => Fail!
    3. Apply this patch
    4. Run the tests again
    => Pass!
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit d24d77d495a56e76046907ab19e9474cab28169c)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    (cherry picked from commit fba97f0772ad6fd40b359e626ce9fb82f3d92182)
    Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Accounts.pm                                     |    1 -
 Koha.pm                                            |    2 +-
 admin/preferences.pl                               |    4 +-
 installer/data/mysql/mandatory/auth_val_cat.sql    |    4 +-
 installer/data/mysql/updatedatabase.pl             |    7 +
 .../intranet-tmpl/prog/en/includes/circ-menu.inc   |    2 +-
 .../prog/en/includes/members-menu.inc              |    2 +-
 .../intranet-tmpl/prog/en/modules/tools/viewlog.tt |    2 -
 .../prog/en/xslt/MARC21slim2intranetDetail.xsl     |    5 +-
 .../prog/en/xslt/MARC21slim2intranetResults.xsl    |    5 +-
 koha-tmpl/intranet-tmpl/prog/js/localcovers.js     |    5 +-
 .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl    |    5 +-
 .../bootstrap/en/xslt/MARC21slim2OPACResults.xsl   |    3 +-
 .../maintenance/search_for_data_inconsistencies.pl |  143 ++++++++++++++++++++
 t/db_dependent/Letters/TemplateToolkit.t           |    5 +-
 tools/batchMod.pl                                  |    1 +
 tools/batch_delete_records.pl                      |    1 +
 tools/batch_record_modification.pl                 |    1 +
 18 files changed, 178 insertions(+), 20 deletions(-)
 create mode 100755 misc/maintenance/search_for_data_inconsistencies.pl


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list