[koha-commits] main Koha release repository branch master updated. v18.05.00-803-gde434c2
Git repo owner
gitmaster at git.koha-community.org
Wed Sep 26 21:37:11 CEST 2018
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via de434c2398aa0629e6a9119cebb353ba517a20b9 (commit)
via 4bbbd083cf4cc73442bc8911d7e7e240e01cc039 (commit)
via 616ed6013f590024a795847eab6cc317d37050ec (commit)
via 393b2582349b48f67e5693629bb197aa73df31a1 (commit)
via 172f2e0e05759baa6c60d86acd9981fef499a162 (commit)
via 90ff0f33430bfc643982c883a8f59150dbeffde2 (commit)
via 3ef81d996909d8bd1cd290b6a9c67df8e2c8e2ef (commit)
via 647422883d56d7512053f4d6cdbecc41a3e80586 (commit)
via 100385196ecadb34669190caa241ed73ea2a5a1c (commit)
via 8577d55d4ee867282c37c8b4a5b4e847fc9f17a7 (commit)
via 9037e661b16006181a2661191f25ac09df862b0a (commit)
via 270a408949e69b97aff87a208a559c4736e20426 (commit)
via b5becc84f5f2e8f82b765b5ebf3f87a84d89cfd8 (commit)
via c59ef0452ccbae17de3b839da4fa2c9f7f6b2e6f (commit)
via eec74a2cd1847a859b4fab37c42882ba192ee560 (commit)
via cc3bc2920744e35256b45b784c9788a64fe6dd04 (commit)
via a62742f4260425af8e69a88822b7affc9cc93c68 (commit)
via d415e51180cac0152c2ab0f95e846b196883f42e (commit)
via bf908a5f07ffbd492c42483aace120dae8316048 (commit)
via d60b0a2e4d3359c127f1e801db9e35dd217f8790 (commit)
via c6a26d2c9e767623c7bc0698297bbc165301e7ed (commit)
via fb5b377ffd13d9931e9e159b23ce6f886b06d57f (commit)
via db683b285cfb31deb9dbdafbc5a18e0b471ffa65 (commit)
via 78124100ec6708de99bea3e4e181da3897130d0e (commit)
via 7de47202f2876892524c8b68de962c0776f32881 (commit)
from 8fa1bd72debea6e23020a93d5c30dd99d7ed1822 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit de434c2398aa0629e6a9119cebb353ba517a20b9
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Apr 6 12:53:35 2018 +0000
Bug 20534: Floating toolbar when editing vendors
This patch moves the Save and Cancel controls on the vendor edit form
into a toolbar which sticks to the top of the screen as you scroll.
To test, apply the patch and Acquisitions -> New vendor.
- Confirm that as you scroll down the page, the toolbar with the Save
and Cancel buttons sticks to the top of the screen.
- Test that the Save and Cancel buttons both work correctly.
- Perform the same tests when editing an existing vendor.
Signed-off-by: Maksim Sen <maksim.sen at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 4bbbd083cf4cc73442bc8911d7e7e240e01cc039
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Sep 12 17:43:15 2018 +0000
Bug 21341: Style button on acquisitions existing record search with Bootstrap
This patch adds Bootstrap button styles to two links: View MARC and
Order.
Unrelated: A "modal-wide" class has been added to the View MARC modal to
give more room for the MARC view.
To test, apply the patch and go to Acquisitions -> Vendor -> Basket ->
Add to basket -> From an existing record.
In the record search results, confirm that the View MARC and Order links
are now Bootstrap buttons. Test the View MARC button and confirm that
the modal preview fills most of the screen.
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 616ed6013f590024a795847eab6cc317d37050ec
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Sat Sep 15 22:36:40 2018 +0000
Bug 21333: (follow-up) Make link a button
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 393b2582349b48f67e5693629bb197aa73df31a1
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Tue Sep 11 16:26:04 2018 +0000
Bug 21333: Add ability to add to basket from a new file
This patch adds a workflow for adding to a basket from a file. It
removes the need to stage the file before going to the basket and allows
you to stage the file and return to the basket
To test:
1 - Have basket in acquissitions
2 - Click add to basket
3 - Note new option to 'Add from new file'
4 - Click it
5 - You will be sent to the record import tool
6 - Stage your file
7 - There is a link after staging 'Add records to basket'
8 - Click it
9 - Your items should be added
Signed-off-by: Sonia <sonia.bouis at univ-lyon3.fr>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 172f2e0e05759baa6c60d86acd9981fef499a162
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date: Fri Mar 2 11:10:12 2018 -0500
Bug 19620: Allow skipping of patrons with valid emails for Talking Tech
Some libraries want to be able to skip patrons with valid email addresses when generated outbound files for Talking Tech.
Test Plan:
1) Apply this patch
2) Run TalkingTech_itiva_outbound.pl
Overdue will be easiest to use for testing
3) Note one or more patrons show up that have email addresses
4) Run again with -s ( or --skip-patrons-with-email )
5) Note the new file no longer has patrons with emails!
Signed-off-by: Jesse Maseto <jesse at bywatersolution.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
I did not test but changes make sense
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 90ff0f33430bfc643982c883a8f59150dbeffde2
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Sep 26 19:00:16 2018 +0000
Bug 7143: Update about page for new dev - Alberto Martinez
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 3ef81d996909d8bd1cd290b6a9c67df8e2c8e2ef
Author: Alberto <martinez.alberto at icloud.com>
Date: Sun Sep 16 15:34:37 2018 -0700
Bug 21350: Added icon to Pending on-site checkouts and moved
When pending on-site checkouts is enabled, it will display checkout items that are being used in the library
test plan:
1. Go to Koha administration
2. Search for "onSiteChekouts"
3. Enable "onSitecheckout"
4. Save all Circulation preferences
5. Go back to home page and click "Circulations"
6. Please confirm there is an icon and the link is below Fast cataloging
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Amended patch: replace tabs with 4 spaces
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 647422883d56d7512053f4d6cdbecc41a3e80586
Author: Victor Grousset <victor.grousset at biblibre.com>
Date: Tue Jun 12 14:04:37 2018 +0000
Bug 20915: Use date --iso-8601 instead of date +%Y-%m-%d
In delete_patrons.pl's POD
To be more readable and crontab friendly
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 100385196ecadb34669190caa241ed73ea2a5a1c
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date: Thu Apr 26 15:07:07 2018 -0400
Bug 20669: Add upgrade method to plugins
It would be nice if plugins had an upgrade method to handle altering tables and such when a new version of a plugin is installed. Right now it must be done in a completely bespoke manner.
Test Plan:
1) Apply this patch
2) Download the 2 most recent releases of the Kitchen Sink plugin
https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases
3) Install the earlier release
4) Look at the configuration page, at the bottom it should say the
plugin has never been upgraded
5) Install the newer release
6) Reload the configuration page, it should now say that the plugin
was upgraded and give you the date and time of the upgrade
Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 8577d55d4ee867282c37c8b4a5b4e847fc9f17a7
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Thu Sep 20 11:35:11 2018 +0000
Bug 21380: (QA follow-up) Use uri filter in link parameters
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 9037e661b16006181a2661191f25ac09df862b0a
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Sep 19 14:48:08 2018 +0000
Bug 21380: Circulation history UI improvements - make barcode clickable
This patch modifies the patron circulation history template so that the
barcode of each item links to the item details page.
To test, apply the patch and view the circulation history for a patron
with multiple current or past checkouts.
In the table of titles, the barcode for each item should correctly link
to the item details page for that item.
Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 270a408949e69b97aff87a208a559c4736e20426
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Sep 21 18:35:06 2018 -0300
Bug 21397: Mark "Routing list" tab as active when selected
/members/routing-lists.pl?borrowernumber=5 show the different tab of the
menu but "Routing lists" is not displayed as the selected one (active).
"routinglistview" must be set and passed to the template
Test plan:
Enable the RoutingSerials pref
and hit /members/routing-lists.pl?borrowernumber=42
The "Routing lists" tab must be selected/active
Followed test plan and tab now shows as active.
Signed-off-by: Dilan Johnpullé <dilan at calyx.net.au>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit b5becc84f5f2e8f82b765b5ebf3f87a84d89cfd8
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Sep 26 16:17:06 2018 +0000
Bug 5458: DBRev 18.06.00.032
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit c59ef0452ccbae17de3b839da4fa2c9f7f6b2e6f
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Tue Sep 4 10:40:29 2018 +0200
Bug 5458: increase ccode column to varchar 80
Koha allows you to define an authorised value having length 80, but then you
can't use it.
Here is why:
The SQL field items.ccode is a varchar(10).
The SQL field authorised_values.authorised_value is a varchar(80).
Therefore the authorised value is truncated to length 10 in items.ccode and the mapping from authorised value to description string fails in Koha.
This patch increases ccode column to varchar 80, like location.
Test plan :
1) Dont apply patches
2) Check there is on item field a subfield with authorised value category CCODE
3) Check this subfield is linked with database column items.ccode
4) Create an authorised values in category CCODE with 'DOCUMENTATION'
5) Edit an item on ccode and choose 'DOCUMENTATION'
6) Save item
7) Look at items.ccode in database or export in MARCXML
8) The value is troncated to 'DOCUMENTAT'
9) Apply patches and update database with installer/data/mysql/atomicupdate/bug_5458.sql
10) Repeate step 5 to 7
11) The value is not truncated 'DOCUMENTATION'
Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit eec74a2cd1847a859b4fab37c42882ba192ee560
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Sep 21 11:38:15 2018 +0200
Bug 20023: (QA follow-up) Tiny simplification
Remove empty emails from the list rightaway.
Would be tempted to lc the params->{email} at the start btw..
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit cc3bc2920744e35256b45b784c9788a64fe6dd04
Author: Blou <philippe.blouin at inlibro.com>
Date: Mon Sep 17 16:34:19 2018 -0400
Bug 20023: Password recovery using email should be case insensitive
When entering an email to recover the password, a user should not have to know or remember the casing of the given email.
Test
0) enable OpacResetPassword
1) On the OPAC, click "Forgot your password"
2) Enter your email address as in your user account BUT WITH A DIFFERENT CASING
3) Submit. This will fail.
4) Apply the patch, redo with success.
Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a62742f4260425af8e69a88822b7affc9cc93c68
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Aug 13 12:40:22 2018 -0300
Bug 21196: Use replacement cost from the item type if not set at item level
When circ rules are set to cap at item replacement cost, calcfine only
checks the price in the item record, not the default replacement cost by
item type.
Note: We do not take '0' into account, what if you do not want to set
a replacement cost for an item? It is how it is done in chargelostitem
so keeping the existing behaviour, but that may be considered as a bug (?)
Test plan:
- Set useDefaultReplacementCost to use
- Set a default replacement cost for a given item type
- Create an item of that type with a replacementcost=0
- Create a circ rule for that item type that accrues fines but caps at
replacement cost
- check the item out, forcing a due date in the past
- check that item in
=> Fines should have been generated
Signed-off-by: Caroline Cyr La rose <caroline.cyr-la-rose at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit d415e51180cac0152c2ab0f95e846b196883f42e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Aug 13 12:36:41 2018 -0300
Bug 21196: Add tests
Signed-off-by: Caroline Cyr La rose <caroline.cyr-la-rose at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit bf908a5f07ffbd492c42483aace120dae8316048
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Sun Sep 16 10:41:49 2018 -0700
Bug 21353: (follow-up) same check for select/clear all links
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit d60b0a2e4d3359c127f1e801db9e35dd217f8790
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Sat Sep 15 11:02:05 2018 -0700
Bug 21353: Display checkboxes to merge patron even if cannot manage lists
When permission 'manage_patron_lists' is off, there is no checkbox on
/cgi-bin/koha/members/member.pl to merge patrons.
Test plan:
Remove permission manage_patron_lists
Add permission edit_borrowers
Search for patrons
=> Without this patch you will not be able to select patrons to merge
(checkboxes are not displayed)
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit c6a26d2c9e767623c7bc0698297bbc165301e7ed
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Sep 14 16:10:56 2018 -0700
Bug 21323: Handle multi params in redirect after login
Multi params are not handle correctly after login
Test plan:
[0] Use staff interface
[1] Use advance search and tick itemtype more than one checkbox
[2] Copy result url
[3] Logout
[4] Paste url in browser
[5] Type username and password
[6] In search result page, results limit description under breadcrumbs
will show all limits
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit fb5b377ffd13d9931e9e159b23ce6f886b06d57f
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Jun 29 14:26:17 2018 +0000
Bug 20223: Merge members-menu and circ-menu inc files
This patch removes members-menu.inc and replaces the last functional use
of it with a call to circ-menu.inc.
An invalid use of members-menu.inc has been removed from member.tt.
To test, apply the patch and open a patron record for editing. The
sidebar menu should look correct and all sidebar links should work
correctly.
View the patrons home page and confirm that nothing has broken.
Search the Koha codebase for references to members-menu.inc. There
should be none.
Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit db683b285cfb31deb9dbdafbc5a18e0b471ffa65
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Sep 21 09:15:08 2018 +0200
Bug 21281: (QA follow-up) Introduce _add_backtics
Added a (initially trivial) test in Creators/Lib.t too.
Sometimes you start something, but you end somewhere else ;)
The test seems a bit slower now (regex, lookahead, etc). But this should
not hurt label creators in daily use.
Advantages: code is even more solid, consolidated in one place and can be
tested on its own.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 78124100ec6708de99bea3e4e181da3897130d0e
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Wed Sep 5 18:41:32 2018 +0000
Bug 21281: Correct t/db_dependent/Creators/Lib.t failures
TEST PLAN
---------
1) apply first patch
2) kshell kohadev
3) prove -r -v t/db_dependent/Creators/
-- failures
4) apply this patch
5) repeat 2,3
-- no failures
6) run koha qa test tools
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 7de47202f2876892524c8b68de962c0776f32881
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Aug 29 17:05:50 2018 -0300
Bug 21281: Surround creator_templates.rows with backquotes
'rows' is a reserved word since MariaDB 10.2.4 and MySQL
https://mariadb.com/kb/en/library/mariadb-1024-release-notes/
https://dev.mysql.com/doc/refman/8.0/en/keywords.html
Test plan:
Do not apply this patch and make sure you recreate the reported issue
Apply this patch and confirm that it is now fixed.
QA will take care for the changes in installer and test files
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Auth.pm | 4 +-
C4/Creators/Lib.pm | 24 +++++++--
C4/Overdues.pm | 10 ++++
Koha.pm | 2 +-
Koha/Plugins/Base.pm | 51 ++++++++++++++++++++
Koha/Schema/Result/BranchTransferLimit.pm | 8 +--
Koha/Schema/Result/CourseItem.pm | 8 +--
Koha/Schema/Result/Deleteditem.pm | 8 +--
Koha/Schema/Result/Item.pm | 8 +--
Koha/Schema/Result/Statistic.pm | 8 +--
docs/history.txt | 1 +
installer/data/mysql/kohastructure.sql | 10 ++--
installer/data/mysql/patroncards_upgrade.pl | 2 +-
installer/data/mysql/updatedatabase.pl | 10 ++++
.../en/includes/acquisitions-add-to-basket.inc | 1 +
.../prog/en/includes/members-menu.inc | 28 -----------
koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 1 +
.../prog/en/modules/acqui/neworderbiblio.tt | 6 +--
.../prog/en/modules/acqui/supplier.tt | 13 ++++-
.../prog/en/modules/circ/circulation-home.tt | 10 ++--
.../prog/en/modules/members/member.tt | 11 ++---
.../prog/en/modules/members/memberentrygen.tt | 2 +-
.../prog/en/modules/members/readingrec.tt | 2 +-
.../en/modules/members/tables/members_results.tt | 2 +-
.../prog/en/modules/tools/stage-marc-import.tt | 9 ++++
members/routing-lists.pl | 1 +
misc/cronjobs/delete_patrons.pl | 2 +-
.../thirdparty/TalkingTech_itiva_outbound.pl | 7 +++
opac/opac-password-recovery.pl | 10 ++--
t/db_dependent/Circulation/CalcFine.t | 31 ++++++++++--
t/db_dependent/Creators/Lib.t | 18 +++++--
t/db_dependent/Plugins.t | 17 ++++++-
t/lib/Koha/Plugin/Test.pm | 5 ++
tools/stage-marc-import.pl | 12 ++++-
34 files changed, 240 insertions(+), 102 deletions(-)
delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/members-menu.inc
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list