[koha-commits] main Koha release repository branch master updated. v18.11.00-1083-g08f02c1
Git repo owner
gitmaster at git.koha-community.org
Thu Apr 11 16:10:23 CEST 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 08f02c1aa5a6ae1f1ee3b10a086831c1a2dbcb66 (commit)
via ccc2b4b073113b2c0603437b5a84d4544ede16e4 (commit)
via 968c888e1579ab28ec165819a011612d8b8f5570 (commit)
via f7869ad48b8f2f86f2b912aad1c3dcbd1a5679c1 (commit)
via a5f3d405f56202beb4426da52f3bf4019f26484b (commit)
via 761b410f99cbbfff8e353c538fde2b6816408795 (commit)
via 275dee5f9b9a26b3490bf3646c71c78a2d8647eb (commit)
via 1493c42e7bae5bffab430072587b7aa0527f6fc7 (commit)
via 7208ac6196a8619dbb0cca3b6f01480f4c46cab1 (commit)
via 19b9aacfbae616f7198cd93ebdbd97115d204c5b (commit)
via 9cbc5f2aa072ec41a70fd1fa1de4f684fcd695e9 (commit)
via 3db5feb900d3e6a6400767c771afe78bab0fa880 (commit)
via fbdb2b2be009140be6f9b5b84c765741bc828a3c (commit)
via b215c7d55195a4912fb3ab585aba6ee44581f746 (commit)
via 3323a428eaf662a0ba1a31b2cb56002a7372461a (commit)
via 7acb5394e1f62728c90a1d18e988c23a3e2862d2 (commit)
via edf173e6ef1fa6de6e07f41c229799733456901a (commit)
via d498c2563d76c05a1e819d63d8b56f732c3a7768 (commit)
via d8a196cc9decd19a5401907adc64c7dee80a0c55 (commit)
via a1eba24391b4653f842a1767a48ac8b9f470b8ea (commit)
via 9c0197a8d1b1a29f28de4b91e6605ae0a1088235 (commit)
via 5768ea9532e0ee19b77346e2ba13681339b18017 (commit)
via bc5e84eedc7132c64452e7f37e5a825f6d17c9bd (commit)
via a00e1467b9754432196df838b6e000262b7251e7 (commit)
via 7d550eb1b3b10f82c8463e85beb63184952fc4f1 (commit)
via 30ab16657b10dbe8e5c42f1f3900a31c3506bb25 (commit)
via 083f789b9548ec70d86dc48911df1bc9febda619 (commit)
via bfeac6486516f185d9882d294d5000ab773c7dd5 (commit)
via 3c2ce5df6f550fd2452b978e1b5f7ac54e66b092 (commit)
via 3e9989568e171ebcfc73df80c49556e0b663a8ae (commit)
via 679fdaebb1a611859a968f22b85c37fbc00b055b (commit)
via 64740260e51b4249dbc99d151dadfb173cde5298 (commit)
via d3059e6c94f324d6984368fa8b8e77ad1dfbcf71 (commit)
from 35921d30a99f3f4c4cdb21438c8516444a10f24c (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 08f02c1aa5a6ae1f1ee3b10a086831c1a2dbcb66
Author: Hayley Mapley <hayleymapley at catalyst.net.nz>
Date: Mon Apr 8 10:25:11 2019 +1200
Bug 19630: Removed constant message from Status column
Test plan:
Same as initial test plan, except that when a hold has no status that
the Status column for that hold should be blank instead of saying
"Hold has been placed".
Sponsored-by: Catalyst IT
Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit ccc2b4b073113b2c0603437b5a84d4544ede16e4
Author: Hayley Mapley <hayleymapley at catalyst.net.nz>
Date: Thu Mar 14 21:37:36 2019 +0000
Bug 19630: Added Status column to Patron Holds table
When a hold has been suspended or is waiting, the status
message appears in the Barcode column of the Holds table. This patch
fixes this by adding a separate Status column which details the status
of the Hold, whether it has been suspended, or is in transit, etc.
Test plan:
1) Place an item level hold and a 'Next Available' record level hold for
a patron.
2) View the holds in Patrons->Patron details for that Patron in the Check out and Details tabs
3) Suspend one of the holds, and note that the status appears in the
barcode column
4) Set a hold to be waiting for pickup, and note the status appears in
the barcode column
5) Apply the patch
6) Check the same holds and note that the statuses now appear in the new
column called Status, and note that if a hold has status effect that the
row reads "Hold has been placed"
7) Verify that this is the case in both the Holds tables (in Check out
tab and Details tab)
Sponsored-by: Catalyst IT
Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos at inLibro.com>
Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 968c888e1579ab28ec165819a011612d8b8f5570
Author: Hayley Mapley <hayleymapley at catalyst.net.nz>
Date: Thu Mar 14 04:14:57 2019 +0000
Bug 19497: Removed title (tooltip) from Edit button in items_search_fields.tt
This patch removes the tooltip that appears when hovering over the Edit button
of Item Search Fields in the staff client. This was done for consistency reasons,
including that this tooltip is not translated and tooltips do not appear to be
on the majority of buttons in the staff client.
Test plan:
1) In Home->Administration->Item search fields create a new search field
if you haven't got any already
2) Observe the tooltip that appears when hovering over the Edit button in
the Item serach fields table.
3) Apply the patch and observe that the tool tip no longer appears.
Sponsored-by: Catalyst IT
Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit f7869ad48b8f2f86f2b912aad1c3dcbd1a5679c1
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Apr 11 13:39:10 2019 +0000
Bug 19670: DBRev 18.12.00.041
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a5f3d405f56202beb4426da52f3bf4019f26484b
Author: Ere Maijala <ere.maijala at helsinki.fi>
Date: Thu Mar 14 14:33:18 2019 +0200
Bug 19670: Change Collation of marc_field to allow mixed case mappings
Test plan:
1. Apply patch and update database
2. Verify that you can add a search field mapping for both 100a and 100A.
3. Verify that the above also works with a newly-created database.
Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 761b410f99cbbfff8e353c538fde2b6816408795
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Mar 6 19:02:50 2019 +0000
Bug 22444: currencies_manage permission doesn't provide link to manage currencies when selected alone
This patch modifies the acquisitions sidebar menu so that it checks
properly for the currencies_manage permission.
This patch also removes the menu link directly to the administration
home page. Since we're removing the check on the general
"CAN_user_parameters" permission it doesn't make sense to assume the
page is accessible.
To test, apply the patch and modifiy a staff user so that they have no
"parameters" permissions but do have "currencies_manage" permission.
Go to the Acquisitions home page. There should be a link to currencies
management in the sidebar menu.
Perform the same test with a user who has "parameters" permissions but
not "currencies_manage" permission. There should be no link to
currencies in the acquisitions sidebar menu. The user should have access
to the administrative home page.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 275dee5f9b9a26b3490bf3646c71c78a2d8647eb
Author: Maryse Simard <maryse.simard at inlibro.com>
Date: Thu Feb 7 08:24:03 2019 -0500
Bug 21263: Pickup library not set correctly when using Default holds policy
In the case of a specific item hold, it can only be fulfilled if the pickup library
matches the hold fulfillment policy. Therefore, if OPACAllowUserToChooseBranch is
set to don't allow, the pickup library should correspond to the policy.
In case of hold that does not specify an item, the homebranch or holdingbranch
can't be determined at this time, so the pickup library still defaults to the
homebranch of the borrower. Same if there is no policy or it states 'any'.
To test:
- Make sure OPACAllowUserToChooseBranch is set to don't allow
- Make sure you have two branches A and B
- Have one item whose homebranch is B
- Have one user whose homebranch is A
- Make sure the circulation rules allow the user to reserve the item's item type
1. Go to Administration > Circulation and fines rules
2. Create a Default holds policy by item type for that item type
- Item type = item's item type
- Hold policy = From any library
- Hold pickup library match = item's home library
- Return policy = item returns home
3. Go to the OPAC and log in with the user's credentials
4. Search for the item
5. Click on "Place hold"
6. Select a specific item and confirm hold
7. In the user's file on the OPAC and check the reservation's pickup library. It should be the item's homebranch
You can then repeat the steps for 'item's holding library' or 'any library' as
the Hold pickup library match. It should also work the same way if there is no
'Default holds policy by item type' for this item type but a 'Default checkout,
hold and return policy' set.
Finally, check that placing a hold without selecting a specific item still
defaults the pickup library to the borrower's homebranch.
Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 1493c42e7bae5bffab430072587b7aa0527f6fc7
Author: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>
Date: Fri Apr 5 14:45:39 2019 +0100
Bug 22121: Display 'Price paid' on ILL requests according to CurrencyFormat pref
To test:
- Install BLDSS backend
see: https://wiki.koha-community.org/wiki/ILL_backends
- Add a new BLDSS ILL request
- Edit ILL request
- Fill in Price paid field
- Verify Price paid is formatted correctly on 'Manage ILL request'
page
Signed-off-by: Ethan Amohia <ethan.amohia at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
https://bugs.koha-community.org/show_bug.cgi?id=22121
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 7208ac6196a8619dbb0cca3b6f01480f4c46cab1
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Mar 7 09:14:25 2019 -0300
Bug 22472: Make column_exists early return if the table does not exist
On the way we move TableExists to C4::Installer, where it belongs to.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 19b9aacfbae616f7198cd93ebdbd97115d204c5b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Mar 7 09:14:06 2019 -0300
Bug 22472: Add tests
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 9cbc5f2aa072ec41a70fd1fa1de4f684fcd695e9
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Thu Apr 4 00:56:43 2019 +0000
Bug 21659: Change link to basket group edit page
I have taken another look at other links like the one
from acq order search and changed the link to not lead
to the vendor's basket group page but to the edit page
of the invidividual basket group.
To test:
- Same as first patch, verify links now lead
to the basket grou edit page
https://bugs.koha-community.org/show_bug.cgi?id=21650
Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos at inLibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 3db5feb900d3e6a6400767c771afe78bab0fa880
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Mon Mar 11 16:24:16 2019 +0000
Bug 21659: Fix links to basket groups from order receive page
Fixes a problem with the template variables on the order
receive page, so that the links to basket groups work
correctly again.
To test:
- Create some orders with and without basket groups
- Receive shipment
- Verify that the basket group links for pending orders work right
- Receive an order line
- Verify that the basket group links for received orders work right
Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos at inLibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit fbdb2b2be009140be6f9b5b84c765741bc828a3c
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Wed Apr 3 22:35:38 2019 +0200
Bug 22634: Standardize table creation for stockrotation* tables in kohastructure.sql
The existing pattern is:
DROP TABLE IF EXISTS ...
CRATE TABLE
Stockrotation was using:
CREATE TABLE IF NOT EXISTS ...
which would not recreate the table in a database it's already
existing in possibly causing mismatches in table structure.
To test:
- Drop your database
- Run through the web installer
- Make sure there are no Database/SQL errors
- Makse sure the 4 stockrotation tables have been created
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit b215c7d55195a4912fb3ab585aba6ee44581f746
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Wed Apr 3 19:28:38 2019 +0000
Bug 22631: Make links on barcode on hold summary page consistent (bug 21070)
Bug 21070 changed the link on the holds summary so the barcode
would link to the item on moredetail for an item level hold.
If a hold is already waiting, the link still goes to the detail
page of the record. This patch changes it so the barcode always
links to the item.
To test:
- Place some item level holds on a record
- Verify the barcodes on the hold summary page link to
moredetail.pl
- Return one of the items so that the hold is waiting
- Verify the barcode links to the record detail page now
- Apply patch
- Verify barcodes for pending and waiting holds now both
link to moredetail.pl
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Bin Wen <bin.wen at inlibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 3323a428eaf662a0ba1a31b2cb56002a7372461a
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Mon Apr 1 19:15:18 2019 +0000
Bug 22624: Show OPAC description for authorised values in OPAC
Patch adds the IS_OPAC parameter to a few GetByCode calls in
OPAC files.
To test:
- Add different OPAC and intranet descriptions to some authorised
value categories:
- TERM
- DEPARTMENT
- LOC
- CCODE
- Create a new course using the values and adding items to it
- Check the course reserves overview and detail pages in OPAC
- Verify Department, term, location, and collection show
the OPAC description if existing
- Create a subscription, make sure a default location is selected
- Check the OPAC detail page, subscription tab for this subsription
in the OPAC
- Verify the location of the subscription displays correctly
Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 7acb5394e1f62728c90a1d18e988c23a3e2862d2
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Apr 4 18:27:28 2019 +0000
Bug 13629: SingleBranchMode removes both library and availability search from advanced search
This patch modifies the OPAC advanced search form so that it is possible
to limit searches to available items even if there is only one library.
To test, apply the patch and go to the advanced search page in the OPAC.
- With only one library configured: There should be a section labeled
"Availability" with just the "only available" checkbox.
- With multiple libraries: The section should be labeled "Location and
availability" and should have the library dropdown and the
availability checkbox.
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit edf173e6ef1fa6de6e07f41c229799733456901a
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Apr 4 14:05:21 2019 +0000
Bug 14358: Changing the module refreshes the page and resets library choice
This patch makes an incremental change towards fixing Bug 14358: The
"New notice" button is converted to a dropdown button which asks the
user to select a module to start with.
To test, apply the patch and go to Tools -> Notices. Test the "New
notice" button and confirm that module selections are reflected in the
notice add form you are shown.
Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois at inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit d498c2563d76c05a1e819d63d8b56f732c3a7768
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Apr 11 12:30:50 2019 +0000
Bug 22680: Compiled CSS
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit d8a196cc9decd19a5401907adc64c7dee80a0c55
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Apr 10 17:55:22 2019 +0000
Bug 22680: OPAC language footer not positioned correctly
This patch modifies the OPAC CSS so that the language-selection footer
is positioned correctly.
To test, apply the patch and rebuild the OPAC CSS.
- Enable one or more translations in the OPAC
- View a page in the OPAC which can display in your browser without a
vertical scrollbar (for instance, the OPAC main page with no news
items or OpacMainUserBlock).
- The language-selection footer should appear at the bottom of the
screen. At smaller browser heights the footer should scroll
offscreen.
- Test with content in the opaccredits system preference, and with
OpacKohaUrl enabled. The footer should still be positioned
correctly.
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a1eba24391b4653f842a1767a48ac8b9f470b8ea
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Apr 11 12:26:21 2019 +0000
Bug 22626: (RM follow-up) Adjust column after 12166
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 9c0197a8d1b1a29f28de4b91e6605ae0a1088235
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Apr 9 16:06:27 2019 +0000
Bug 22626: 'Filter paid transactions' broken on Transactions tab in staff
This patch changes a parameter in the function which filters the
DataTable of transactions. The addition of more columns to the table
changed the index of the column which is being filtered.
To test, apply the patch and locate a patron who has multiple fines or
charges, some of them paid. Go to Accounting -> Transactions. Test the
"Filter paid transactions" link. Table rows which show "0.00" in the
"Oustanding" column should be hidden.
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 5768ea9532e0ee19b77346e2ba13681339b18017
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Thu Apr 11 12:21:01 2019 +0000
Bug 12166: DBRev 18.12.00.040
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit bc5e84eedc7132c64452e7f37e5a825f6d17c9bd
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Tue Apr 9 09:19:16 2019 +0100
Bug 12166: (QA follow-up) Update test for description
Update the relevant test to check for 'description eq title' as aposed
to the old 'description eq "Reserve Charge - title"'.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a00e1467b9754432196df838b6e000262b7251e7
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sat Apr 6 13:16:56 2019 +0000
Bug 12166: (follow-up) Fix sequence of columns in OPAC
Type and description column headings were switched.
To test:
- Check the table headings of the fines table in the
OPAC fines table match the content
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 7d550eb1b3b10f82c8463e85beb63184952fc4f1
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sat Apr 6 12:11:38 2019 +0000
Bug 12166: (follow-up) Remove 'Reserve Charge' from descriptions in accountlines
With the prior 'Hold fee' will be displayed in OPAC and staff, so
the 'Reserve Charge' would just be an untranslatable double up
of information.
To test:
- Make sure you create some Reserve Charges prior to applying this
patch set
- Verify they show in staff and OPAC account
- Apply patch
- Run database update
- Verfy the "Rental Charge - " is gone and old and new entries
match now
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 30ab16657b10dbe8e5c42f1f3900a31c3506bb25
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Apr 4 15:44:30 2019 +0000
Bug 12166: Improve display of Reserve charges in patron account
This patch makes changes to the way hold fees are recorded and displayed
in the OPAC and staff client:
- No English strings should be stored in the accountline description.
- The accounttype code should be used to display what kind of charge it
is.
To test, apply the patch and go to the staff client:
- Configure a patron category to have a hold fee.
- Place one or more holds for a patron in that category.
- On the patron's record, view Accounting -> Make a payment
- There should be a separate column for "Account type" showing "Hold
fee" for the hold charges.
- There should be no "Res" or "Reserve Charge" text in the
description column--just the title.
- Switch to the "Transactions" tab. The display should be similar.
- In the OPAC, log in as a patron who has hold fees on their account.
- View the "your fines" page to confirm that the information is
displayed correctly there as well.
- Place a hold for a patron who incurs hold charges.
- Log in to the self-checkout module as that patron and check out an
item which will fulfill that hold.
- The correct fine information should be saved to accountlines: A "Res"
type with a description consisting only of the title.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 083f789b9548ec70d86dc48911df1bc9febda619
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Feb 27 12:45:47 2019 -0500
Bug 20937: Truncate items for print notices when user has an email
To test:
1 - Set PrintNoticesMaxLines to 1
2 - Checkout 2 (or more) items to a patron and make them overdue to trigger a
notice
3 - Make sure the patron has an email
4 - Make sure the notice you are sending is set to 'print' as the type
5 - Run overdue_notices.pl without the 'nomail' option
6 - Find the message and note all items have been added
7 - Apply patch
8 - Clear the message queue
9 - Re-run overdue_notices.pl
10 - Confirm the message now has only 1 item.
11 - Set PrintNoticesMaxLines to 0
12 - Clear the message queue
13 - Re-run overdue_notices.pl
14 - Confirm the message has 2 items as expected
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit bfeac6486516f185d9882d294d5000ab773c7dd5
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sun Apr 7 16:25:28 2019 +0000
Bug 22075: Fix encoding problem with RIS export in OPAC
When exporting a record with diacritics in RIS
format from the detail page in OPAC the encoding
is not correct and the diacritics appear broken.
This patch fixes it.
To test:
- Find or create a record with some special
chars in your OPAC
- Go to the detail page
- Save as > RIS
- Verify the diacritics are broken in an editor
- Apply patch
- Repeat and verify everything now displays correctly
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 3c2ce5df6f550fd2452b978e1b5f7ac54e66b092
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Mar 25 12:55:03 2019 +0000
Bug 22541: Invoice adjustments should show invoice number and include link on ordered.pl and spent.pl
To test:
1 - Find a vendor in acquisitions
2 - Click 'receive shipment'
3 - Create an invoice
4 - Click 'Finish receiving'
5 - Add an adjustment that encumbers while open and update adjustments
6 - Go to acqui-home and click on the ordered total for the fund with the adjustment
7 - Note the invoice adjustment shows the invoice id and does not link
8 - Add another invoice and another adjustment, but close the invoice this time
9 - Go to acqui-home and click on the spent total for the fund with the adjustment
10 - Note the invoice adjustment shows the invoice id and does not link
11 - Apply patch
12 - Visit the spent and ordered pages and note the adjustments show invoicenumber and are links
13 - prove -v t/db_dependent/Koha/Acquisition/Invoice/Adjustments.t
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 3e9989568e171ebcfc73df80c49556e0b663a8ae
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Wed Mar 27 16:19:29 2019 +0100
Bug 22595: Items search is mixing inputs
Items search is using inputs and selects from search form to create an Ajax call.
In this call selects are parsed before inputs.
But a custom search field can be used with authorised values and used after a regular search field.
In this case the "q" param is not ordered like the "name" param.
Test plan :
1) Go to Administration > Item search fields
2) Define a search field with an authorised values category
3) Go to items search
4) Use a regular filter like call number
5) Click on new field
6) Use custom field with an authorised value
7) Perform search
=> Without patch you get wrong resuts, authorised value is used as value for first field
=> You can see this by listening traffic in Firebug, look at params "f" and "q"
8) Check some combinaison of select and input filters
Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 679fdaebb1a611859a968f22b85c37fbc00b055b
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Jan 31 14:29:45 2019 +0000
Bug 22250: Clean up Mana KB integration with serials and reports
This patch makes many changes to templates and JavaScript related to the
integration of Mana with serials reports:
- Many incorrect uses of the raw filter with html
- Corrections to Bootstrap modal markup
- Untranslatable strings moved out of JavaScript
- Removed markup and JavaScript related to reports comments, a feature
which doesn't exist in this version.
New include file: mana/mana-comment-status.inc
This file contains hidden-by-default messages which are shown during
the process of submitting a comment on a subscription.
New include file: mana/mana-share-report.inc
This file contains the "Share report" modal markup formerly in
guided_reports_start.tt
New JavaScript file: mana.js
Previously mana.inc, an include file containing only JavaScript which
didn't include any template processing.
Changed: mana/mana-report-search-result.inc
This include file is now a full template so that jQuery's load()
function can be used to pull its contents into the reports search
modal.
Changed: svc/mana/search
This script was returning json-encoded HTML. Now it returns regular
HTML.
To test you must have Mana configured and enabled. Apply the patch and
go to Reports -> Saved reports.
- Choose New report -> New SQL from Mana. A "Mana search" modal should
appear.
- Perform a search which will return results, e.g. "circulation."
- A "Loading" indicator should appear while the results are being
retrieved. It should disappear when results appear.
- Results should appear in the DataTable with sorting, paging, and
search options.
- In the "Notes" column, notes longer than 200 characters should be
truncated with a "Show more" link. Clicking it should expand the
comment and reveal a "Show less" link in its place.
- Click the "Import" button (previously "Use"). The button icon
should change to a loading indicator.
- When the import is complete you should be redirected to a view of
your new report.
Go to Serials and click the "Search on Mana" link in the sidebar.
- Perform a search for a serial
- Results should appear in a DataTable with sorting, paging, and search
options.
- Sorting by title should ignore articles "a," "an," and "the."
Create a new subscription or edit an existing subscription which will
match a record in Mana.
- On the second step of adding/editing the subscription a message
should appear at the top of the form, "Searching for subscription in
Mana Knowledge Base," with a loading icon.
- When searching has completed a "Show Mana results" link should
appear.
- Clicking the link should trigger a modal showing search results which
match your subscription, displayed in a DataTable with sorting,
paging, and search options.
- The last column of the table should contain "Import" and "Report"
buttons.
- Clicking the "Report" button should trigger a menu. Any existing
comments will be listed as well as a "New comment" item.
- Clicking an existing comment should cause the menu to close and a
"Submitting comment" message to appear. It should be shortly
replaced with a "Your comment has been submitted" message.
- Clicking "New comment" should reveal a comment form.
- It should not be possible to submit an empty comment.
- Clicking the "cancel" link should redisplay the search results.
- Submitting a new comment should trigger a "Submitting comment"
message followed by a "Your comment has been submitted"
message.
- In the table of search results, click the "Import" button
(previously "Use"). The button icon should change to a loading
indicator.
- The modal should close and the data from Mana should be loaded
into the subscription entry form.
View the detail page of a subscription which has saved with Mana data.
- There should be a "Report mistake" button in the toolbar. Clicking
it should reveal a menu of comments like the one you saw previously.
- Clicking an existing comment should cause the menu to close and a
"Submitting comment" message to appear. It should be shortly
replaced with a "Your comment has been submitted" message.
- Clicking "New comment" should reveal a comment form modal.
- It should not be possible to submit an empty comment.
- Clicking the "cancel" link should hide the modal.
- Submitting a new comment should trigger a "Submitting comment"
message followed by a "Your comment has been submitted"
message.
Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 64740260e51b4249dbc99d151dadfb173cde5298
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Tue Mar 12 11:11:45 2019 +0000
Bug 19747: Add link to article requests help page
Newer manuals contain information about article requests.
This patch adds the link to the article request section
in the manual.
To test:
- Activate ArticleRequests system preference
- Go to Circulation > Article requests
- Click on Help
- Verify that you end up in the proper section of the manual
Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit d3059e6c94f324d6984368fa8b8e77ad1dfbcf71
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Wed Apr 3 15:59:20 2019 +0100
Bug 20912: (QA follow-up) Fix for missed signature failure
We missed a change in calling parameters passed to CalcDateDue in AddRenewal
during the initial QAing. This patch corrects the call and adds a test to catch
regressions.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Acquisition.pm | 1 -
C4/Circulation.pm | 2 +-
C4/Installer.pm | 16 +-
C4/Reserves.pm | 2 +-
Koha.pm | 2 +-
Koha/Acquisition/Invoice/Adjustment.pm | 15 ++
Koha/Manual.pm | 1 +
acqui/ordered.pl | 2 +-
acqui/spent.pl | 2 +-
installer/data/mysql/kohastructure.sql | 11 +-
installer/data/mysql/updatedatabase.pl | 36 +--
.../intranet-tmpl/prog/en/includes/accounts.inc | 1 +
.../prog/en/includes/acquisitions-menu.inc | 3 +-
.../intranet-tmpl/prog/en/includes/holds_table.inc | 2 +-
koha-tmpl/intranet-tmpl/prog/en/includes/mana.inc | 44 ----
.../prog/en/includes/mana/mana-comment-status.inc | 10 +
.../en/includes/mana/mana-report-search-result.inc | 190 +++++++++------
.../prog/en/includes/mana/mana-share-report.inc | 95 ++++++++
.../mana/mana-subscription-search-result.inc | 138 ++++++-----
.../prog/en/includes/reports-toolbar.inc | 133 +++--------
.../prog/en/includes/serials-toolbar.inc | 102 ++++----
.../intranet-tmpl/prog/en/modules/acqui/ordered.tt | 6 +-
.../intranet-tmpl/prog/en/modules/acqui/parcel.tt | 4 +-
.../intranet-tmpl/prog/en/modules/acqui/spent.tt | 12 +-
.../prog/en/modules/admin/items_search_fields.tt | 2 +-
.../prog/en/modules/catalogue/itemsearch.tt | 18 +-
.../prog/en/modules/circ/circulation.tt | 1 +
.../prog/en/modules/ill/ill-requests.tt | 7 +-
.../en/modules/mana/mana-report-search-result.tt | 2 +-
.../mana/mana-subscription-search-result.tt | 2 +-
.../prog/en/modules/members/boraccount.tt | 11 +-
.../prog/en/modules/members/moremember.tt | 1 +
.../intranet-tmpl/prog/en/modules/members/pay.tt | 32 +--
.../en/modules/reports/guided_reports_start.tt | 213 ++++++++---------
.../prog/en/modules/serials/serials-search.tt | 1 -
.../prog/en/modules/serials/subscription-add.tt | 42 +++-
.../prog/en/modules/serials/subscription-detail.tt | 12 +-
.../intranet-tmpl/prog/en/modules/tools/letter.tt | 26 +-
koha-tmpl/intranet-tmpl/prog/js/holds.js | 70 +++---
koha-tmpl/intranet-tmpl/prog/js/mana.js | 83 +++++++
.../intranet-tmpl/prog/js/subscription-add.js | 249 +++++++++++---------
koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +-
koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 12 +-
.../bootstrap/en/includes/account-table.inc | 14 +-
.../bootstrap/en/modules/opac-advsearch.tt | 17 +-
.../bootstrap/en/modules/opac-course-details.tt | 8 +-
.../bootstrap/en/modules/opac-course-reserves.tt | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 4 +-
misc/cronjobs/overdue_notices.pl | 2 +
opac/opac-export.pl | 7 +
opac/opac-reserve.pl | 14 ++
opac/sco/sco-main.pl | 2 +-
svc/mana/search | 5 +-
t/db_dependent/Circulation.t | 9 +-
t/db_dependent/Installer.t | 8 +-
.../Koha/Acquisition/Invoice/Adjustments.t | 10 +-
t/db_dependent/Reserves.t | 2 +-
57 files changed, 1002 insertions(+), 718 deletions(-)
delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/mana.inc
create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/mana/mana-comment-status.inc
create mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/mana/mana-share-report.inc
create mode 100644 koha-tmpl/intranet-tmpl/prog/js/mana.js
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list