[koha-commits] main Koha release repository branch master updated. v18.11.00-1203-gec6b3d1
Git repo owner
gitmaster at git.koha-community.org
Wed Apr 17 14:43:37 CEST 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via ec6b3d18348189461b3d7587cb055394962255b6 (commit)
via 92b329b22393ec802cabc2e048d7eebfecdcf9cf (commit)
via 4c01891613f68d5eecc9d971717d2a439be041bb (commit)
via 8f8367c728112178d4831a9776c55d58eb7ef22b (commit)
via a2b057758d83c3530c38ced02921c82185f3251f (commit)
via 313ad660e7ae28fb3f9036839b2cb773494c4af0 (commit)
via 374527c1cb34788dc29eed2ef7a4fa52c7989052 (commit)
via 5ed025a73f6c7c8d7ab859a2bad97a60e8c3986d (commit)
via 79ebbffd26b04222831f3b734c4f44d69d199a0b (commit)
via cd082782d1b42765d2ef1094a7e52f792ae75980 (commit)
via 9ebdfb1ed1ff1c7a110dc7a7718bb17cd231f66f (commit)
via 0393f053b08b316f4da174559b6f44f5a8b20e3b (commit)
via 4605d76a73f9b13ba3b0259e3f480fb396051309 (commit)
via 693bbc76e736f048c4c16e7a5664f3494db287c0 (commit)
via 21e9b55c2c9c2b72b9901233ea9263b5f5edfa5f (commit)
via 2a59d22b894aa4d932d021eddf64b2a24c1b8e0c (commit)
via 78d35a2e44a3eeb303bdc81c66645d5d0412f54d (commit)
via e0f83eb4b68a53f8de87c82a2e48628c71e20f88 (commit)
via b31d314613994da218740b735139af70f009fca8 (commit)
via 3f7e19ea7a054d55ccd0b8d74339cf6644bebfd0 (commit)
via 8153c73c6b3a8a8855091004e6a586d8b2de0e9d (commit)
via 47111d993dd6308365732ad63e5cdc90823151ee (commit)
via fb192699859aa124a827ceac27a9b1776d9629b3 (commit)
via 81d3e415a9d87c7b6253a7ddb84efb6432715145 (commit)
via 47df429cc6b4a643e678391e95ec475dbe4b89c1 (commit)
via 6f9341a7f79fd913669ee870a7f243f74d52498f (commit)
via d86f17e6b86fe2c94a6b27488f06598122cd120d (commit)
via 5e1894c94813f10efa0c0d0454958ce19b890742 (commit)
via af84af7cb7cd7ade4054ad155963db4d1ecd6272 (commit)
via 23db9b1d67ee9bf1927bfd7f11da46886d51999b (commit)
via 2ca2585b1c5b61024351c32d84e605f61d04a418 (commit)
via f7f5f167e5736a1e40b59058fb4a99f96daaea42 (commit)
via 0611621ed082a2463b8a15d61273b5720c9db31c (commit)
via 71f17b35ee8023967e671ca9203d5d5b62aa2931 (commit)
via 37460d924eef0383e55ef8078944354a9d500e9a (commit)
via 3b62cbb17bc062c2bb4801eb30460b5f82a171c0 (commit)
via 4b3eb99ad6cd9fc8e9bac6627c38bd16600aa38a (commit)
via b107d5029ed25cc26d16edb5c571ace749b46ccb (commit)
via e37dd514ad08f390a884752d84e457fa74bf208f (commit)
via 03deaadd31cfcb282c1210456a9429a8e41669a4 (commit)
via 93d130f357f77e5e8f8756642f422a2b12164d04 (commit)
via fa64402384fa198ecafa5c54abc5a83b8ce42de3 (commit)
via 2a9b9a526bb3e1c73e09cbee499a2debcab74ee5 (commit)
via f3afec0587f4baeff580e153ea592020d4d36be3 (commit)
via 4177d2e32942b16e65748852df881541406297bd (commit)
via f6e143c73c9ba7f6b1daf76d592dc7a56e8694bb (commit)
via a3a3bf2dda3219b3385b587585985c51f6cc8498 (commit)
via 4779cf845077ffd7f564b63b22f72ba99aa812ff (commit)
via 9f34d208d08fc89d2d0b4d3718fc43e3f32ff055 (commit)
from fc6b7e5c3e101e0c5935f34c45b72cf3fd4f1bb7 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit ec6b3d18348189461b3d7587cb055394962255b6
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Apr 17 12:22:45 2019 +0000
Bug 20128: DBRev 18.12.00.054
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 92b329b22393ec802cabc2e048d7eebfecdcf9cf
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Wed Apr 10 21:38:57 2019 +0000
Bug 20128: Add new permission for new installations
Change was missing from userpermissions.sql
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 4c01891613f68d5eecc9d971717d2a439be041bb
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Mar 21 10:16:34 2019 +0000
Bug 20128: (QA follow-up) Corrections to haspermission
The haspermission routine wrongly assumed that get_user_subpermissions
would return a list of all subpermissions if the user had the top level
permission, but instead if just returns 1.
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 8f8367c728112178d4831a9776c55d58eb7ef22b
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Mar 13 05:23:21 2019 +0000
Bug 20128: Problem when checking individual perms where borrower has top level
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a2b057758d83c3530c38ced02921c82185f3251f
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Mar 6 12:21:38 2019 -0500
Bug 20128: Add permission for advanced cataloging editor
To test:
1 - Have a borrower with edit_catalogue permission and one with
editcatalogue top level
2 - Confirm they can both access the advanced editor from the
'Cataloguing' home page or from the basic editor
3 - Apply patch
4 - Update database
5 - Confirm borrower with 'edit_catalogue' has 'advanced_editor'
permission
6 - Confirm borrowers can access advanced editor as above
7 - Remove 'advanced_editor' permission from borrower
8 - Ensure they cannot access the advanced editor
9 - Ensure links to 'Edit record' from search results go to basic editor
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 313ad660e7ae28fb3f9036839b2cb773494c4af0
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Apr 17 12:17:35 2019 +0000
Bug 17171: DBRev 18.12.00.053
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 374527c1cb34788dc29eed2ef7a4fa52c7989052
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Wed Apr 10 22:43:53 2019 +0000
Bug 17171: (QA follow-up) Remove cardnumber template variable
The INCLUDE already takes care of displaying the cardnumber, the
extra variable is not needed.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 5ed025a73f6c7c8d7ab859a2bad97a60e8c3986d
Author: Liz Rea <wizzyrea at gmail.com>
Date: Mon Apr 1 19:38:17 2019 +0000
Bug 17171: (QA follow-up) Using patron-title.inc for names
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 79ebbffd26b04222831f3b734c4f44d69d199a0b
Author: Kyle M Hall <kyle at bywatetsolutions.com>
Date: Tue Mar 27 10:11:27 2018 -0400
Bug 17171: (QA follow-up) Add message to batch checkout template
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit cd082782d1b42765d2ef1094a7e52f792ae75980
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Sun Jun 11 09:10:17 2017 +0000
Bug 17171: Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation
Some libraries don't want to force the librarians to manually confirm
each checkout when the item is checked out to another. Instead, they
would prefer to be alerted after the fact.
Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Enable the new syspref AutoReturnCheckedOutItems
4) Check an item out to a patron
5) Check the same item out to another patron
6) Note you are not prompted to confirm the checkout,
but are instead alerted that is had been checked out to another patron!
Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>
Signed-off-by: BWS Sandboxes <ByWaterSandboxes at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 9ebdfb1ed1ff1c7a110dc7a7718bb17cd231f66f
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Wed Apr 10 01:15:30 2019 +0200
Bug 22580: Remove deprecated delete_expired_opac_registrations.pl cronjob
Removes the deprecated script and changes the hint on the
PatronSelfRegistrationExpireTemporaryAccountsDelay sytem preference.
To test:
- Make sure the script misc/cronjobs/delete_expired_opac_registrations.pl
was deleted
- Make sure the hint on the PatronSelfRegistrationExpireTemporaryAccountsDelay
system preference is correct
- Make sure there are no other reference to the removed script
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 0393f053b08b316f4da174559b6f44f5a8b20e3b
Author: Agustin Moyano <agustinmoyano at theke.io>
Date: Wed Mar 20 00:16:05 2019 -0300
Bug 22538: Add a noticeable alert about waiting holds
In SCO, bug 21772 introduced holds information, but it lacked the
capability to attract atention when any of those holds was in waiting
status. Because SCO and opac-user uses the same include file for holds
table, this bug applies to both modules.
To test:
1) Have a patron with holds in waiting status and pending status.
2) Enable SCO module.
3) Holds tab label contains holds count, but doesn't inform that there
is something that requires attention.
5) Holds tab content has no visual aid to recognize without reading
effort which holds are in waiting status.
6) Apply this patch
=> SUCCESS: Holds tab label has a visual aid to indicate that
something requires attention, and in
holds table it's easy to recognize waiting holds without reading
effort.
7) Sign off
Sponsored-by: Theke Solutions
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 4605d76a73f9b13ba3b0259e3f480fb396051309
Author: Owen Leonard <oleonard at myacpl.org>
Date: Wed Mar 6 19:59:53 2019 +0000
Bug 3766: Cities/Towns only on one address
This patch ties the alternate address and alternate contact address
fields in the patron entry form to the cities and towns data. This
provides a dropdown of predefined city data to these address fields.
To test, apply the patch and edit a patron record.
Test city selection for all three address fields: Main address,
alternate address, and alternate contact. Confirm that city selection
works correctly and that your changes are saved correctly.
Perform these tests with all AddressFormat options: French, German, and
US.
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 693bbc76e736f048c4c16e7a5664f3494db287c0
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Mar 26 13:51:47 2019 +0000
Bug 11969: Show patrons star rating on their reading history
This patch adds display of a user's ratings to their reading history in
the OPAC.
Also changed: Removed obsolete "border" attribute from the template, and
removed obsolete JavaScript include from opac-results.tt
To test, apply the patch and rebuild the OPAC CSS. OpacStarRatings
should be set to all (results and details).
- Log in to the OPAC as a user with a reading history and titles in
that history which have ratings.
- Under the "your reading history" tab, your ratings should show under
rated titles with the date of the rating.
- Test also with OpacStarRatings set to a value other than "all."
Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
Star ratings are displayed in Reading History with OpacStarRatings
enabled, and are not displayed when OpacStarRatings is disabled, as
expected.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 21e9b55c2c9c2b72b9901233ea9263b5f5edfa5f
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Apr 17 11:42:05 2019 +0000
Bug 22311: DBRev 18.12.00.052
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 2a59d22b894aa4d932d021eddf64b2a24c1b8e0c
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Feb 22 08:00:33 2019 -0500
Bug 22311: Add a SysPref to allow adding content to the #moresearches div in the opac
The idea of this development would be to match the syspref 'OPACSearchForTitleIn' but
for populating the search headers (#moresearches) on the opac page to allow staff to
easily add links without jQuery.
Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Update the new OpacMoreSearches system preference to include the following line:
<li><a href="https://duckduckgo.com/">Duck Duck Go</a></li>
4) Browse to the OPAC
5) Note your new link displays in the "moresearches" area of the OPAC.
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 78d35a2e44a3eeb303bdc81c66645d5d0412f54d
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Mon Apr 8 10:47:03 2019 +0000
Bug 22372: (QA follow-up) Change 'Available location' to 'Shelving location'
Make terminology more consistent with other places in Koha.
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit e0f83eb4b68a53f8de87c82a2e48628c71e20f88
Author: Matthias Meusburger <matthias.meusburger at biblibre.com>
Date: Tue Feb 12 15:33:33 2019 +0100
Bug 22372: Add available location to Holds awaiting pickup
Test plan:
- Go to Circulation, Holds awaiting pickup (circ/waitingreserves.pl)
- Note the additional column for available location.
Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos at inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit b31d314613994da218740b735139af70f009fca8
Author: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Date: Wed Nov 28 13:14:21 2018 -0300
Bug 21899: Update MARC21 frameworks to Update 27 (November 2018)
This bug updates MARC21 english frameworks to Update 27
Bibliographic
-------------
* New fields 251, 341 and 532 with corresponding subfields
* New subfields 041$p, 041$q and 041$r
* Renamed subfield 041$j
Authorities
-----------
* New subfield 055$2
To test:
1) Remove all your frameworks
2) Check mandatory bibliographic and authority files load without problem
3) Check new fields/subfields
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 3f7e19ea7a054d55ccd0b8d74339cf6644bebfd0
Author: Josef Moravec <josef.moravec at gmail.com>
Date: Mon Apr 8 06:03:42 2019 +0000
Bug 22656: Fix charts in reports
This reverts a change on Create chart button in report toolbar made by
bug 22023
1) Confirm the bug
a) Create some SQL report
b) Run it and click on "Show chart settings" button
c) There is no modal or other way to actually draw the chart
2) Apply the patch
3) Go through 1) again - the modal and chart should work
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 8153c73c6b3a8a8855091004e6a586d8b2de0e9d
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Apr 17 11:21:07 2019 +0000
Bug 21943: Compiled CSS
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 47111d993dd6308365732ad63e5cdc90823151ee
Author: Owen Leonard <oleonard at myacpl.org>
Date: Mon Mar 11 13:41:49 2019 +0000
Bug 21943: (follow-up) Fix float error with sidebar menu
This patch makes a minor change to the staff client CSS to fix a float
clearing problem when the <main> element contains only a floated element
like <fieldset>. It is a global change, but shouldn't cause unwanted
effects because a non-clearing <main> isn't used in any
float-dependent layouts.
To test, apply the patch and regenerate the staff client CSS. View the
place hold screen and confirm that the sidebar menu looks correct at
narrower browser widths.
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit fb192699859aa124a827ceac27a9b1776d9629b3
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Dec 4 16:27:00 2018 +0000
Bug 21943: Clean up holds template
This patch makes a few markup corrections to the holds template in the
staff client: Replace some YUI markup with Bootstrap; Replace invalid
"alt" attributes with "title."
To test, apply the patch and test the process of placing a hold, both
single and multiple holds. At each step of the process the page should
look correct and adjust well at various browser widths.
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 81d3e415a9d87c7b6253a7ddb84efb6432715145
Author: Liz Rea <wizzyrea at gmail.com>
Date: Fri Mar 29 16:31:14 2019 +0000
Bug 22616: Updating error text messages
To test:
Apply this patch
Go to a borrower that doesn't exist, check that the error message is
displayed and looks correct. (i.e. http://127.0.0.1:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=9999999999999999)
Go to an item, subscription, biblio that don't exist, check that the
error message is correct and the links work
Go to a borrower that the logged in user doesn't have permission to see, check that the error message is correct and the links work.
Signed-off-by: Bin Wen <bin.wen at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 47df429cc6b4a643e678391e95ec475dbe4b89c1
Author: Liz Rea <wizzyrea at gmail.com>
Date: Thu Mar 21 17:59:59 2019 +0000
Bug 22576: OPAC password text refresh
To test:
Create a patron with a username and password
Make sure that password resets on OPAC are allowed in your system
preferences (OpacPasswordChange -> Allow)
Log into the OPAC with this patron
Click the "Change password" tab
Change the password - notice that the button to submit the changes says
"Submit Changes" and also that the success page says "Return to my
record"
Apply this patch
Reset the password again, noticing that the button to submit the new
password says "Change password" and the success page says "Return to my
account"
Signed-off-by: Marie-Luce Laflamme <marie-luce.laflamme at inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 6f9341a7f79fd913669ee870a7f243f74d52498f
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Apr 17 11:15:22 2019 +0000
Bug 21336: DBRev 18.12.00.051
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit d86f17e6b86fe2c94a6b27488f06598122cd120d
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date: Thu Apr 4 09:42:38 2019 +0100
Bug 21336: (QA follow-up) Add tests for administrative lockout
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 5e1894c94813f10efa0c0d0454958ce19b890742
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Mar 29 08:30:06 2019 +0000
Bug 21336: (QA follow-up) Add column_exists in db revision
As requested by Josef on comment70.
Test plan:
Run db revision twice. No warnings.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit af84af7cb7cd7ade4054ad155963db4d1ecd6272
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Mon Dec 17 09:15:29 2018 +0100
Bug 21336: (follow-up) Handle strict SQL mode in _anonymize_column
When a field is not nullable we should pass empty string, zero or today
to a char, numeric or date column.
The mandatory parameter does not refer to a database constraint but a Koha
preference. Only for strings we generate a random value.
Test plan:
Enable strict_sql_modes.
Run t/db_dependent/Koha/Patrons.t again.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 23db9b1d67ee9bf1927bfd7f11da46886d51999b
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Oct 26 12:21:13 2018 +0200
Bug 21336: (follow-up) Fix last line after PatronRemovalDelay in pref file
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 2ca2585b1c5b61024351c32d84e605f61d04a418
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed Sep 12 14:25:26 2018 +0200
Bug 21336: Adjust cleanup_database.pl
Add the new Patron routines to this cron job. Actions are performed only if
preferences are set.
Note: No specific command line flags for these actions are added here
(and probably not needed too). So no crontab changes too.
Test plan:
Add a new patron.
Enable GDPR_Policy and refuse consent on OPAC for this patron.
Set only the first delay to zero (0) for immediate action.
Run cleanup_database.pl --logs (or any other flag) for the first time.
Check lock and expiration.
Set the second delay to zero (0) for immediate action.
Run cleanup_database.pl --logs for the second time. Check anonymization.
Set the third delay to zero (0) for immediate action.
Run cleanup_database.pl --logs for the third time. Check removal.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Amended: Added the warn $@ line in cleanup_database.pl
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit f7f5f167e5736a1e40b59058fb4a99f96daaea42
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed Sep 12 14:25:26 2018 +0200
Bug 21336: Search, lock and anonymize methods
Add Koha::Patron->lock and anonymize.
Add Koha::Patrons methods search_unsubscribed, search_anonymize_candidates
and search_anonymized. And wrappers for lock and anonymize.
Add unit tests.
Test plan:
Run t/db_dependent/Koha/Patrons.t
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 0611621ed082a2463b8a15d61273b5720c9db31c
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed Oct 3 15:36:46 2018 +0200
Bug 21336: Introduce administrative lockout
As a preparation for Koha::Patron->lock, we add the concept of administrative
lockout. The account is locked just as it would have been by too much
failed login attempts.
This is handled by a negative value in borrowers.login_attempts.
Test plan:
Run t/db_dependent/Auth.t
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 71f17b35ee8023967e671ca9203d5d5b62aa2931
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Mon Oct 1 14:46:15 2018 +0200
Bug 21336: Do not increase login_attempts after locking
If an account has been locked, there is no use to keep increasing this
number. It is not true too; after the pref number has been reached,
we can not really speak of login attempts anymore. The credentials are
just ignored.
Adding a dbrev to put existing values in line. And a simple test in
Auth.t to confirm that login_attempts stop increasing.
Note: It feels safe to keep the '>=' condition in account_locked. But it
could obviously be changed to '=='. (Added a test for that.)
Note: Adding a mock_preference in Auth.t too for GDPR_Policy. Since not all
tests will pass when the pref is enabled (though disabled by default).
Test plan:
Run dbrev with updatedatabase.pl.
Run t/db_dependent/Koha/Patrons.t
Run t/db_dependent/Auth.t
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 37460d924eef0383e55ef8078944354a9d500e9a
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu Sep 20 12:48:10 2018 +0200
Bug 21336: Database update for new prefs
This patch adds three new prefs:
- UnsubscribeReflectionDelay
- PatronAnonymizeDelay
- PatronRemovalDelay
Test plan:
Run upgrade.
Check patrons pref page. Look under Privacy.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 3b62cbb17bc062c2bb4801eb30460b5f82a171c0
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed Sep 19 16:56:16 2018 +0200
Bug 21336: Database revision for borrowers.flgAnonymized
This new flag should speak for itself ;)
Test plan:
Run installer or updatedatabase.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 4b3eb99ad6cd9fc8e9bac6627c38bd16600aa38a
Author: Owen Leonard <oleonard at myacpl.org>
Date: Tue Apr 16 16:34:13 2019 +0000
Bug 22716: Use gender-neutral pronouns in system preference descriptions
This patch makes a few corrections to the .pref files which provide
descriptions for system preferences. Language like "him or her" is
replaced with "they/them" pronouns.
To test, apply the patch and check the following preferences:
- OPACFineNoRenewalsBlockAutoRenew
- ExpireReservesMaxPickUpDelayCharge
- PatronSelfRegistrationVerifyByEmail
Signed-off-by: Lisette <lisettes at latahlibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit b107d5029ed25cc26d16edb5c571ace749b46ccb
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Apr 17 10:31:03 2019 +0000
Bug 22274: Compiled CSS
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit e37dd514ad08f390a884752d84e457fa74bf208f
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Apr 11 15:12:30 2019 +0000
Bug 22274: (follow-up) Use one CSS file for SCO and SCI
This patch makes the self-checkin CSS created in Bug 22638 the CSS for
self-checkout as well. The interfaces have the same requirements.
This patch also replaces some old image-based icons with Font Awesome
icons.
To test, apply the patch and rebuild the OPAC CSS. Clear your browser
cache if necessary.
- Enable both self checkout (WebBasedSelfCheck) and self checkin
(SelfCheckInModule).
- Test both interfaces, confirming that the style is consistent for
each and looks correct.
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 03deaadd31cfcb282c1210456a9429a8e41669a4
Author: Claire Gravely <claire.gravely at bsz-bw.de>
Date: Wed Apr 3 13:01:21 2019 +0000
Bug 22274: Self-checkout/checkin pages not covered by OPAC CSS changes
This patch updates the Self-checkout pages to match the new OPAC style.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 93d130f357f77e5e8f8756642f422a2b12164d04
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Apr 11 13:50:12 2019 +0000
Bug 22638: (follow-up) Convert SCI CSS to SCSS
This patch makes a number of follow-up changes, including:
- Covert remaining icons to Font Awesome
- Convert CSS to SCSS
- Move SCSS which is common to both the OPAC and SCI into separate
files to be including in each during compilation.
- Make minor correction to opac.scss to fix SCSS build warning
To test, apply the patch and rebuild the OPAC CSS. Clear your browser
cache if necessary.
- Enable the self checkin module using using the SelfCheckInModule
system preference.
- Open the self checkin interface and test the checkin process.
Everything should look correct.
- After submitting barcodes for checkin, the "Finish" button should
show a Font Awesome icon instead of an image icon.
- Enable multiple translations and set the OpacLangSelectorMode
preference to show the language menu in the footer.
- Confirm that the language menu looks correct.
- View the regular OPAC to make sure the changes to opac.scss didn't
result in unintended changes to the interface.
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit fa64402384fa198ecafa5c54abc5a83b8ce42de3
Author: Claire Gravely <claire.gravely at bsz-bw.de>
Date: Thu Apr 4 07:27:45 2019 +0000
Bug 22638: Self checkin CSS update
This patch updates the Self-Checkin CSS to match tne new OPAC design.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 2a9b9a526bb3e1c73e09cbee499a2debcab74ee5
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sun Apr 14 03:13:01 2019 +0000
Bug 21172: Remove obsolete framework parameter from GetMarcFromKohaField
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit f3afec0587f4baeff580e153ea592020d4d36be3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Aug 7 17:06:41 2018 -0300
Bug 21172: Remove warning from addbiblio.pl
Argument "01e" isn't numeric in numeric ne (!=) at
/home/vagrant/kohaclone/cataloguing/addbiblio.pl line 507.
A tagfield can be 01e and so raise a warning is compared with == or !=
This patch also fixes few inconsistencies:
- tagfield for items.itemnumber must be retrieved with GetMarcFromKohaField
(to support other marcflavours)
- do not use $_
- loop only once on $usedTagsLib
Test plan:
For devs only, read the code and confirm the changes make sense.
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 4177d2e32942b16e65748852df881541406297bd
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Wed Apr 17 10:11:04 2019 +0000
Bug 22044: DBRev 18.12.00.048
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit f6e143c73c9ba7f6b1daf76d592dc7a56e8694bb
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sun Apr 14 04:26:29 2019 +0000
Bug 22044: Fix sysprefs.sql description to use circ column description
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit a3a3bf2dda3219b3385b587585985c51f6cc8498
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Mon Apr 15 13:32:12 2019 +0000
Bug 22044: Correct syspref name
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 4779cf845077ffd7f564b63b22f72ba99aa812ff
Author: Nick Clemens <nick at bywatersolutions.com>
Date: Fri Dec 21 19:19:05 2018 +0000
Bug 22044: Set default and add NoRenewalBeforePrecision preference for new/affected installs
I am not sure the correct answer - for upgraded installs the pref was
set to date, which changed behaviour
For new installs the pref was unset, behaved as if 'exact_time' so we
shouldn't change behaviour?
If the perceived default is date then the code should be changed, or
this shouldn't be a pref at all?
To test:
1 - Have a new system missing this pref
2 - Note when searchign the pref in staff client if appears as 'date'
3 - Check the db to confirm value is 'NULL'
4 - Apply patch and run update
5 - Pref is now set to 'exact_time'
Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
commit 9f34d208d08fc89d2d0b4d3718fc43e3f32ff055
Author: Lucas Gass <lucas at bywatersolutions.com>
Date: Fri Apr 12 23:04:06 2019 +0000
Bug 22702: circulation note on patron page should allow for HTML tags
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Auth.pm | 4 +-
C4/Circulation.pm | 4 +
Koha.pm | 2 +-
Koha/Patron.pm | 90 +++++-
Koha/Patrons.pm | 136 +++++++-
Koha/Schema/Result/Borrower.pm | 18 +-
Koha/Schema/Result/Deletedborrower.pm | 18 +-
cataloguing/addbiblio.pl | 19 +-
cataloguing/editor.pl | 7 +-
.../marc21/mandatory/authorities_normal_marc21.sql | 3 +-
.../marc21/mandatory/marc21_framework_DEFAULT.sql | 29 +-
installer/data/mysql/kohastructure.sql | 2 +
installer/data/mysql/sysprefs.sql | 6 +
installer/data/mysql/updatedatabase.pl | 78 +++++
installer/data/mysql/userpermissions.sql | 1 +
.../intranet-tmpl/prog/css/src/staff-global.scss | 6 +
koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 2 +-
.../prog/en/includes/blocking_errors.inc | 12 +-
.../en/includes/member-alt-address-style-de.inc | 39 ++-
.../en/includes/member-alt-address-style-fr.inc | 14 +
.../en/includes/member-alt-address-style-us.inc | 18 +-
.../en/includes/member-alt-contact-style-de.inc | 16 +-
.../en/includes/member-alt-contact-style-fr.inc | 20 +-
.../en/includes/member-alt-contact-style-us.inc | 20 +-
.../en/includes/member-main-address-style-de.inc | 2 +-
.../en/includes/member-main-address-style-fr.inc | 20 +-
.../en/includes/member-main-address-style-us.inc | 2 +-
.../intranet-tmpl/prog/en/includes/permissions.inc | 5 +
.../prog/en/includes/reports-toolbar.inc | 3 +-
.../prog/en/includes/waiting_holds.inc | 3 +
.../en/modules/admin/preferences/circulation.pref | 10 +-
.../prog/en/modules/admin/preferences/opac.pref | 9 +-
.../prog/en/modules/admin/preferences/patrons.pref | 8 +
.../prog/en/modules/cataloguing/addbiblio.tt | 2 +-
.../prog/en/modules/cataloguing/addbooks.tt | 2 +-
.../prog/en/modules/circ/circulation.tt | 8 +-
.../en/modules/circ/circulation_batch_checkouts.tt | 3 +
.../prog/en/modules/members/memberentrygen.tt | 9 +-
.../prog/en/modules/members/moremember.tt | 2 +-
.../prog/en/modules/reserve/request.tt | 39 ++-
koha-tmpl/intranet-tmpl/prog/js/members.js | 15 +-
koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +-
koha-tmpl/opac-tmpl/bootstrap/css/sci.css | 208 ------------
koha-tmpl/opac-tmpl/bootstrap/css/sco.css | 213 +-----------
koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss | 196 +++++++++++
koha-tmpl/opac-tmpl/bootstrap/css/src/_fonts.scss | 35 ++
koha-tmpl/opac-tmpl/bootstrap/css/src/_mixins.scss | 6 +-
koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 210 +-----------
koha-tmpl/opac-tmpl/bootstrap/css/src/sco.scss | 340 ++++++++++++++++++++
.../bootstrap/en/includes/holds-table.inc | 1 +
.../bootstrap/en/includes/masthead-sco.inc | 4 +-
.../opac-tmpl/bootstrap/en/includes/masthead.inc | 1 +
.../opac-tmpl/bootstrap/en/modules/opac-passwd.tt | 4 +-
.../bootstrap/en/modules/opac-readingrecord.tt | 26 +-
.../opac-tmpl/bootstrap/en/modules/opac-results.tt | 1 -
.../opac-tmpl/bootstrap/en/modules/sci/sci-main.tt | 10 +-
.../opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 30 +-
misc/cronjobs/cleanup_database.pl | 8 +
misc/cronjobs/delete_expired_opac_registrations.pl | 71 ----
opac/opac-readingrecord.pl | 9 +-
opac/sco/sco-main.pl | 6 +
t/db_dependent/Auth.t | 49 ++-
t/db_dependent/Auth/haspermission.t | 21 +-
t/db_dependent/Circulation.t | 62 +++-
t/db_dependent/Koha/Patrons.t | 173 +++++++++-
65 files changed, 1561 insertions(+), 831 deletions(-)
delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/sci.css
create mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss
create mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/src/_fonts.scss
create mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/src/sco.scss
delete mode 100755 misc/cronjobs/delete_expired_opac_registrations.pl
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list