[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.04-95-ga1f80ad

Git repo owner gitmaster at git.koha-community.org
Thu Apr 25 15:41:22 CEST 2019


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 18.11.x has been updated
       via  a1f80ad2950ea100e34260be7ae7d6e7f6f3bea7 (commit)
       via  f3b362120f0b8a75a89ad6846e7bdad93b2e37ca (commit)
       via  6055a519c4474ab3b9004ed99b9b2e76c9735076 (commit)
       via  a1ff52bef45884b9a292cc5f84fdc49fce1c2c36 (commit)
       via  b56789dbc58c217c0129d2728cc5c202c627c27e (commit)
       via  83affe394dfb9c983f79045d43ace06f3daab65d (commit)
       via  0d29ae30119e7f5be27c00afc4791ab4b2cbb627 (commit)
      from  383349f83fb9362a6f875cc11a9efbb5caed2956 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a1f80ad2950ea100e34260be7ae7d6e7f6f3bea7
Author: Christopher Brannon <cbrannon at cdalibrary.org>
Date:   Wed Dec 5 20:33:25 2018 +0000

    Bug 21346: Remove inline onclicks per comment 42
    
    To test:
    1)  Apply patch.
    2)  Check that there is no changed behavior with buttons or checkboxes.
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit d5d4501290704b9b3a0893a4a3df0a356abe445b)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit f3b362120f0b8a75a89ad6846e7bdad93b2e37ca
Author: Christopher Brannon <cbrannon at cdalibrary.org>
Date:   Sun Nov 4 03:47:30 2018 +0000

    Bug 21346: Convert dialogs to modals.
    
    This addresses most of the transfer dialogs.  There are some dialogs
    that I have not converted because I don't know what triggers them,
    therefore I cannot test them.
    
    The following scenarios have been addresses, and should be tested:
    
    FOR TRANSFERS
    
    1) Checkin with no issue, hold or transfer; not at home (AutomaticItemReturn set to Don't)
         * Should give 3 options - Yes, Yes with print, or No.
         * Yes and Yes with print should trigger a transfer back home.
         * No should do nothing.
         * Print should open a window for printing, with correct
         information.
         * All three options should close the modal.
    
         TO TEST:
         1) Set AutomaticItemREturn to Don't.
         2) Check in an item with no issues, holds or transfers set, at a
         location other than the owning library.
         3) Test conditions above.
    
    2) Checkin with no issue, hold or transfer; not at home (AutomaticItemReturn set to Do)
        * Should give 2 options - Print or OK.
        * Should automatically set transfer.
        * Print should open a window for printing, with correct information.
        * Both buttons should close modal.
    
        TO TEST:
        1) Set AutomaticItemReturn to Do.
        2) Check in an item with no issues, holds or transfers set, at a
        location other than the owning library.
        3) Test conditions above.
    
    3) Checkin with no issues or holds, but transfer already set
        * Should give 3 options - OK, Print or Cancel.
        * OK and print should not touch existing transfer.
        * Cancel should remove the exisiting transfer.
        * Print should open a window for printing, with correct information.
        * All three options should close the modal.
    
        TO TEST:
        1) Check in an item following step 2 of either test above.
        2) Check in item again, while a transfer exists.
        3) Test conditions above.
    
    WRONG BRANCH
    
    4) If AllowReturnToBranch is not set "to any library", and the item is not checked in at the appropriate branch, the wrong-branch-modal pops up:
        * Should give 1 option - OK.
        * Should not check anything in or initiate a transfer.
        * OK should close the modal.
    
        TO TEST:
        1) Set AllowReturnToBranch to "only the library the item is from".
        You can test the other settings, as long as you pay attention to
        where you are checking the item in at.
        2) Check in an item at a branch other than the owning library.
        3) Test conditions above.
    
    Signed-off-by: Lisette <lisetteslatah at gmail.com>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 5ed171a45c46f63b18266ad3a3d0a978719ca285)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 6055a519c4474ab3b9004ed99b9b2e76c9735076
Author: Christopher Brannon <cbrannon at cdalibrary.org>
Date:   Thu Nov 1 21:08:19 2018 +0000

    Bug 21346: Remove double dialog
    
    To Test:
    1) Place a hold on an item for pickup at another branch.
    2) Check in item to trigger hold and transfer.
    3) Check in item again without changing location.  Note modal AND old
    dialog behind modal.
    4) Apply patch.
    5) Check in item again without changing location.  Note modal without
    the old dialog.
    
    Signed-off-by: Lisette <lisetteslatah at gmail.com>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 230905e1d56a11cf5619f95c95920eb09803900c)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit a1ff52bef45884b9a292cc5f84fdc49fce1c2c36
Author: Christopher Brannon <cbrannon at cdalibrary.org>
Date:   Thu Nov 1 20:21:08 2018 +0000

    Bug 21346: Streamline logic in holds and transfers
    
    1) Replaced comparison with string to make testing branch easier.
    2) Replaced useless 0 values with undef.
    
    Does not change any behavior, only simplifies code.
    
    Signed-off-by: Lisette <lisetteslatah at gmail.com>
    
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 48787acc6f725686583bb05f45888acf3e1231d0)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit b56789dbc58c217c0129d2728cc5c202c627c27e
Author: Thatcher Leonard <thatcher.f.leonard at gmail.com>
Date:   Wed Apr 10 23:23:46 2019 +0000

    Bug 18584: Our legacy code contains trailing-spaces
    
    This patch removes trailing spaces and replaces tab characters with
    spaces in the branch transfer limits template.
    
    Mentored-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 8eb22efa0893849e2967e34c821c018c6405f8d3)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 83affe394dfb9c983f79045d43ace06f3daab65d
Author: Arthur Suzuki <arthur.suzuki at biblibre.com>
Date:   Wed Mar 27 15:49:04 2019 +0100

    Bug 22597: Remove "more_subfields_xml" from GetPatronInfo response
    
    Test plan
    1/ Set an item with some xml data in more_subfields_xml
    2/ Issue this item to a borrower
    3/ Query the webservice with GetPatronInfo methods and show_loans=1 params
    4/ Check no <more_subfields_xml> tags are returned in the xml response from the webservice
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 73bc117b057bd5ea73c4075d586b644b0cafe00b)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

commit 0d29ae30119e7f5be27c00afc4791ab4b2cbb627
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date:   Wed Feb 6 00:14:01 2019 +0000

    Bug 19648: Revise marc21_field_007.xml
    
    - Removes some doubled up entries
    - Fixes some whitespace issues
    - Adds some missing entries, for example:
        007, nonprojected graphic, secondary support material a-c
    
    To test:
      - Verify that the 007 cataloging plugin works correctly and
        matches standard:
        http://www.loc.gov/marc/bibliographic/bd007k.html
    
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
    (cherry picked from commit 7b90dace95e4c289a2b36b5f95d9116dbd5440db)
    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/ILSDI/Services.pm                               |    1 +
 circ/returns.pl                                    |   10 +-
 .../prog/en/data/marc21_field_007.xml              |   89 ++++----
 .../en/modules/admin/branch_transfer_limits.tt     |   78 +++----
 .../intranet-tmpl/prog/en/modules/circ/returns.tt  |  213 +++++++++++++-------
 5 files changed, 227 insertions(+), 164 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list