[koha-commits] main Koha release repository branch 18.11.x updated. v18.11.04-111-gfb73c4a
Git repo owner
gitmaster at git.koha-community.org
Thu Apr 25 16:49:10 CEST 2019
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 18.11.x has been updated
via fb73c4a3470b37058c41f216fbc95df60e3c9621 (commit)
via cf76b870033fcf709941d048e3fdbac7b7123e5e (commit)
via b1f2d795defee116ce30522eb76f4981ca21b804 (commit)
via 89f0c3a9da9d009e7fea0c76f706676078dc9860 (commit)
via 16846985e1032b89bb9df16f445c04f3c47dd375 (commit)
via 5469ae4eea46416410bddaef4934aa1db6e767f9 (commit)
from b415a676f1a22b51fc89d35ea459ffa88b908706 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit fb73c4a3470b37058c41f216fbc95df60e3c9621
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Fri Dec 7 16:05:52 2018 +0100
Bug 21975: Avoid unnecessary substitutions in automatic item modification by age
Automatic item modification by age cronjob is based on rules with conditions and substitutions.
When substitution value is equal to actual item value, the code should not call C4::Items::ModItem. It adds unnecessary action log and entry in zebraqueue.
With a rule than can impact all catalogue you can explode your database with action logs.
Test plan :
1) Run prove t/db_dependent/Items/AutomaticItemModificationByAge.t
2) Define a item modification by age with no condition
3) Run several times misc/cronjobs/automatic_item_modification_by_age.pl
4) Check it creates only one entry in action_logs and zebraqueue
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 3a3ffbc54b8dec8ee63332417fe2732ee93f3034)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit cf76b870033fcf709941d048e3fdbac7b7123e5e
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Fri Dec 7 15:21:48 2018 +0100
Bug 21975: add Unit Test
Added missing transaction rollback
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 0be8fd212067ebd4b36e00b4d139761aa0e021c3)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit b1f2d795defee116ce30522eb76f4981ca21b804
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Fri Dec 7 15:58:54 2018 +0100
Bug 21975: get item field in substitutions
substitutions field stores the item field with 'items.' prefix.
Looks like call of C4::Items::ModItem() works but it will not if ORM object is used in the futur.
So I prefer fix it now and it is needed for main patch.
Test plan :
Run t/db_dependent/Items/AutomaticItemModificationByAge.t
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 003b70b697f9c57da8bfb0aca1223c867a07ac97)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 89f0c3a9da9d009e7fea0c76f706676078dc9860
Author: Owen Leonard <oleonard at myacpl.org>
Date: Fri Apr 12 11:04:06 2019 +0000
Bug 18011: Enrollment period date on patron category can be set in the past without any error/warning messages
This patch modifies the patron category edit form so that the enrollment
period datepicker widget cannot be used to select a date in the past.
The <input> element had a "datepicker" class, which triggers a default
datepicker configuration. This was overriding the configuration in the
page-specific JavaScript file.
To test, apply the patch and go to Administration -> Patron categories.
Click the "Enrollment period -> Until date" field and verify that dates
before today are disabled.
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com>
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 34c835ed141a3b4758ad77e5b72f30e83d57024f)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 16846985e1032b89bb9df16f445c04f3c47dd375
Author: Ere Maijala <ere.maijala at helsinki.fi>
Date: Thu Mar 7 16:35:30 2019 +0200
Bug 22474: Clone field config before adding fields to it
Test plain:
1. Reindex both authorities and biblios with the -d flag to recreate the index, e.g. "perl misc/search_tools/rebuild_elastic_search.pl -v -d"
2. Check that authorities only contains authority-specific fields in Elasticsearch e.g. by fetching http://localhost:9200/koha_dev_authorities/_mappings
3. Reindex both without the -d flag and verify it works, e.g. "perl misc/search_tools/rebuild_elastic_search.pl -v"
Signed-off-by: Björn Nylén <bjorn.nylen at ub.lu.se>
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 118f685dbf1519077ece65a47f83bff179efbf9b)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
commit 5469ae4eea46416410bddaef4934aa1db6e767f9
Author: Katrin Fischer <katrin.fischer.83 at web.de>
Date: Sun Apr 7 18:23:32 2019 +0000
Bug 22090: Add missing information to cash register CSV file
Some information was missing from the CSV export file
of the Cash register report: manager surname, patron surname
and payment notes.
Also pretties up the column headers a bit and makes the
sequence between GUI and CSV export match.
To test:
- Make sure you have some fines and fees and payments in
your system
- Make a search with the Cash register report
- Export results as CSV
- Proof read hader line and make sure contents match headings
- Verify first name and surname are shown for manager and patron
- Verify notes show up
Signed-off-by: Michal Denar <black23 at gmail.com>
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
(cherry picked from commit 1a2572915b4bf4a11b3a65c3a65e506610263a03)
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Installer/PerlDependencies.pm | 2 +-
C4/Items.pm | 6 +++++-
Koha/SearchEngine/Elasticsearch.pm | 21 +++++++++++---------
.../csv_headers/reports/cash_register_stats.tt | 2 +-
.../prog/en/modules/admin/categories.tt | 2 +-
.../prog/en/modules/reports/cash_register_stats.tt | 2 +-
reports/cash_register_stats.pl | 6 +++---
.../Items/AutomaticItemModificationByAge.t | 12 +++++++++--
8 files changed, 34 insertions(+), 19 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list